Re: [PR] KAFKA-16093: Fix spurious REST-related warnings on Connect startup [kafka]

2024-01-09 Thread via GitHub
vamossagar12 commented on code in PR #15149: URL: https://github.com/apache/kafka/pull/15149#discussion_r1446980325 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/HerderRequestHandler.java: ## @@ -41,18 +41,11 @@ public class HerderRequestHandler {

[jira] [Commented] (KAFKA-16090) Refactor call to storage tool from kafka docker wrapper

2024-01-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805005#comment-17805005 ] Mickael Maison commented on KAFKA-16090: Context: https://github.com/apache/kafk

[jira] [Updated] (KAFKA-16102) about DynamicListenerConfig, the dynamic modification of the listener's port or IP does not take effect.

2024-01-09 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jialun Peng updated KAFKA-16102: Reviewer: (was: Colin Patrick McCabe) > about DynamicListenerConfig, the dynamic modification of

[jira] [Resolved] (KAFKA-15735) KRaft support in SaslMultiMechanismConsumerTest

2024-01-09 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-15735. --- Fix Version/s: 3.8.0 Resolution: Fixed > KRaft support in SaslMultiMechanismConsumerTest > --

Re: [PR] [KAFKA-15735] Adding KRaft test [kafka]

2024-01-09 Thread via GitHub
omkreddy merged PR #15156: URL: https://github.com/apache/kafka/pull/15156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15594: Add version 3.6 to Kafka Streams system tests [kafka]

2024-01-09 Thread via GitHub
mjsax commented on PR #15151: URL: https://github.com/apache/kafka/pull/15151#issuecomment-1884303284 Merged #15157 and rebased this PR afterwards. Re-triggered system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/6025/ -- This is an automated message

Re: [PR] MINOR: bump dev version for system tests to 3.8 [kafka]

2024-01-09 Thread via GitHub
mjsax merged PR #15157: URL: https://github.com/apache/kafka/pull/15157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-14517:Implement regex subscriptions [kafka]

2024-01-09 Thread via GitHub
JimmyWang6 commented on PR #14327: URL: https://github.com/apache/kafka/pull/14327#issuecomment-1884289264 @dajac I've updated the PR. Please take a look when you have a moment. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-16071) NPE in testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2024-01-09 Thread Owen C.H. Leung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804981#comment-17804981 ] Owen C.H. Leung commented on KAFKA-16071: - I think this is related to https://is

Re: [PR] KAFKA-14546 - Support Partitioner fallback to default [kafka]

2024-01-09 Thread via GitHub
philipnee commented on code in PR #14531: URL: https://github.com/apache/kafka/pull/14531#discussion_r1446899891 ## clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java: ## @@ -26,6 +26,15 @@ */ public interface Partitioner extends Configurable, Closeable

Re: [PR] KAFKA-14546 - Support Partitioner fallback to default [kafka]

2024-01-09 Thread via GitHub
philipnee commented on PR #14531: URL: https://github.com/apache/kafka/pull/14531#issuecomment-1884215706 @jimbogithub - thanks for the PR, i've got a few questions to clarify: - `KafkaProducer.partition(...) not throw IllegalArgumentException if the Partitioner returns RecordMetadata.UN

Re: [PR] KAFKA-14546 - Support Partitioner fallback to default [kafka]

2024-01-09 Thread via GitHub
philipnee commented on code in PR #14531: URL: https://github.com/apache/kafka/pull/14531#discussion_r1446881807 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1368,7 +1368,7 @@ private int partition(ProducerRecord record, byte[] serialize

Re: [PR] KAFKA-14546 - Support Partitioner fallback to default [kafka]

2024-01-09 Thread via GitHub
jimbogithub commented on PR #14531: URL: https://github.com/apache/kafka/pull/14531#issuecomment-1884148153 This PR is still valid and desired, has no merge conflicts and does build despite Jenkins protestations. I do not have the ability to add Reviewers. -- This is an automated message

Re: [PR] KAFKA-14546 - Support Partitioner fallback to default [kafka]

2024-01-09 Thread via GitHub
github-actions[bot] commented on PR #14531: URL: https://github.com/apache/kafka/pull/14531#issuecomment-1884136280 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-14511: extend AlterIncrementalConfigs API to support group config [kafka]

2024-01-09 Thread via GitHub
DL1231 commented on PR #15067: URL: https://github.com/apache/kafka/pull/15067#issuecomment-1884122272 @AndrewJSchofield, I've updated the PR. Please take a look again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] KAFKA-14511: extend AlterIncrementalConfigs API to support group config [kafka]

2024-01-09 Thread via GitHub
DL1231 commented on code in PR #15067: URL: https://github.com/apache/kafka/pull/15067#discussion_r1446824176 ## core/src/main/scala/kafka/server/ControllerConfigurationValidator.scala: ## @@ -113,6 +121,22 @@ class ControllerConfigurationValidator(kafkaConfig: KafkaConfig) ext

Re: [PR] KAFKA-14511: extend AlterIncrementalConfigs API to support group config [kafka]

2024-01-09 Thread via GitHub
DL1231 commented on code in PR #15067: URL: https://github.com/apache/kafka/pull/15067#discussion_r1446824091 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -353,7 +358,8 @@ class BrokerServer( dynamicConfigHandlers = Map[String, ConfigHandler]( Co

Re: [PR] KAFKA-14511: extend AlterIncrementalConfigs API to support group config [kafka]

2024-01-09 Thread via GitHub
DL1231 commented on code in PR #15067: URL: https://github.com/apache/kafka/pull/15067#discussion_r1446823998 ## clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java: ## @@ -223,6 +223,7 @@ public enum ConfigSource { DYNAMIC_BROKER_CONFIG, // d

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446822116 ## clients/src/main/java/org/apache/kafka/common/requests/ListGroupsRequest.java: ## @@ -50,6 +50,10 @@ public ListGroupsRequest build(short version) {

Re: [PR] MINOR: Enable kraft test in kafka.api and kafka.network [kafka]

2024-01-09 Thread via GitHub
dengziming commented on code in PR #14595: URL: https://github.com/apache/kafka/pull/14595#discussion_r1446812841 ## core/src/test/scala/integration/kafka/api/RackAwareAutoTopicCreationTest.scala: ## @@ -35,31 +37,37 @@ class RackAwareAutoTopicCreationTest extends KafkaServerTe

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446780228 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -453,19 +454,31 @@ public Group group(String groupId, long comm

Re: [PR] KAFKA-14505; [5/N] Add `UNSTABLE_OFFSET_COMMIT` error support [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15155: URL: https://github.com/apache/kafka/pull/15155#discussion_r1446778536 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -195,6 +196,11 @@ public OffsetMetadataManager build() { *

Re: [PR] KAFKA-14505; [5/N] Add `UNSTABLE_OFFSET_COMMIT` error support [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15155: URL: https://github.com/apache/kafka/pull/15155#discussion_r1446774595 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -668,6 +697,8 @@ public OffsetFetchResponseData.OffsetFetchRespo

Re: [PR] KAFKA-14505; [5/N] Add `UNSTABLE_OFFSET_COMMIT` error support [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15155: URL: https://github.com/apache/kafka/pull/15155#discussion_r1446773736 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -195,6 +196,11 @@ public OffsetMetadataManager build() { *

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446773716 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -633,8 +633,8 @@ class KafkaApisTest extends Logging { val requestData = DescribeQuorumReque

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446771432 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -327,23 +327,26 @@ class GroupCoordinatorAdapterTest { @Test def

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446770934 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -327,23 +327,26 @@ class GroupCoordinatorAdapterTest { @Test def

Re: [PR] KAFKA-14505; [5/N] Add `UNSTABLE_OFFSET_COMMIT` error support [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15155: URL: https://github.com/apache/kafka/pull/15155#discussion_r1446770811 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -656,6 +663,28 @@ public int deleteAllOffsets( return n

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446770934 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -327,23 +327,26 @@ class GroupCoordinatorAdapterTest { @Test def

Re: [PR] KAFKA-14505; [5/N] Add `UNSTABLE_OFFSET_COMMIT` error support [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15155: URL: https://github.com/apache/kafka/pull/15155#discussion_r1446770811 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -656,6 +663,28 @@ public int deleteAllOffsets( return n

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446767928 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -1105,16 +1105,17 @@ private[group] class GroupCoordinator( } } - def handleLi

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-09 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1446766566 ## clients/src/main/java/org/apache/kafka/common/ConsumerGroupType.java: ## @@ -0,0 +1,50 @@ +/* Review Comment: Yes it is, we can consider it part of the admin c

[jira] [Commented] (KAFKA-15475) Timeout request might retry forever even if the user API times out in PrototypeAsyncConsumer

2024-01-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804922#comment-17804922 ] Kirk True commented on KAFKA-15475: --- [~lianetm] would you kindly point me at the code

[jira] [Commented] (KAFKA-15475) Timeout request might retry forever even if the user API times out in PrototypeAsyncConsumer

2024-01-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804921#comment-17804921 ] Kirk True commented on KAFKA-15475: --- [~lianetm] / [~pnee] —I need to refresh my memory

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1446756748 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final Set del

Re: [PR] KAFKA-15181: Improvements for TopicBaseRemoteLogMetadataManager [kafka]

2024-01-09 Thread via GitHub
junrao commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1446751658 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +63,403 @@ class ConsumerTask implements Runnable, Closeab

[jira] [Resolved] (KAFKA-16094) BrokerRegistrationRequest.logDirs field must be ignorable

2024-01-09 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-16094. -- Fix Version/s: 3.7.0 Resolution: Fixed > BrokerRegistrationRequest.logDirs field must b

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1446743080 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final Set del

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1446742642 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final Set del

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-09 Thread via GitHub
artemlivshits commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1446724899 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final S

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-09 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1446722719 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -140,6 +141,71 @@ class KRaftMetadataCache(val brokerId: Int) extends MetadataCach

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-09 Thread via GitHub
artemlivshits commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1446639923 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -140,6 +141,71 @@ class KRaftMetadataCache(val brokerId: Int) extends MetadataCache

Re: [PR] KAFKA-16094: BrokerRegistrationRequest.logDirs field must be ignorable [kafka]

2024-01-09 Thread via GitHub
cmccabe merged PR #15153: URL: https://github.com/apache/kafka/pull/15153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-14505; [4/N] Wire transaction verification [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15142: URL: https://github.com/apache/kafka/pull/15142#discussion_r1446688518 ## core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala: ## @@ -201,18 +203,55 @@ class CoordinatorPartitionWriter[T]( )) } + /** +

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-09 Thread via GitHub
OmniaGM commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1446673095 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-09 Thread via GitHub
dajac commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1446669238 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] KAFKA-14505; [4/N] Wire transaction verification [kafka]

2024-01-09 Thread via GitHub
dajac commented on code in PR #15142: URL: https://github.com/apache/kafka/pull/15142#discussion_r1446663978 ## core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala: ## @@ -201,18 +203,55 @@ class CoordinatorPartitionWriter[T]( )) } + /** + *

Re: [PR] KAFKA-14505; [4/N] Wire transaction verification [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15142: URL: https://github.com/apache/kafka/pull/15142#discussion_r1446657520 ## core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala: ## @@ -201,18 +203,55 @@ class CoordinatorPartitionWriter[T]( )) } + /** +

Re: [PR] KAFKA-14505; [4/N] Wire transaction verification [kafka]

2024-01-09 Thread via GitHub
dajac commented on code in PR #15142: URL: https://github.com/apache/kafka/pull/15142#discussion_r1446654869 ## core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala: ## @@ -201,18 +203,55 @@ class CoordinatorPartitionWriter[T]( )) } + /** + *

[jira] [Resolved] (KAFKA-15946) AsyncKafkaConsumer should retry commits on the application thread instead of auto-retry

2024-01-09 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-15946. Fix Version/s: 3.7.0 (was: 3.8.0) Assignee: Lianet Magrans

[jira] [Resolved] (KAFKA-15967) Fix revocation in reconcilation logic

2024-01-09 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-15967. Fix Version/s: 3.7.0 (was: 3.8.0) Assignee: Lianet Magrans

[jira] [Updated] (KAFKA-15553) Review consumer positions update

2024-01-09 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15553: --- Summary: Review consumer positions update (was: Review consumer positions update using comm

[jira] [Updated] (KAFKA-15553) Review consumer positions update using committed offset

2024-01-09 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15553: --- Summary: Review consumer positions update using committed offset (was: Review committed off

[jira] [Updated] (KAFKA-16004) Review new consumer inflight offset commit logic

2024-01-09 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16004: --- Description: New consumer logic for committing offsets handles inflight requests, to validat

Re: [PR] Metadata schema checker [kafka]

2024-01-09 Thread via GitHub
mannoopj commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1446640522 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] [Resolved] (KAFKA-15872) Investigate autocommit retry logic

2024-01-09 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-15872. Fix Version/s: (was: 3.8.0) Resolution: Duplicate > Investigate autocommit retr

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-01-09 Thread via GitHub
philipnee commented on code in PR #15148: URL: https://github.com/apache/kafka/pull/15148#discussion_r1446637026 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -175,16 +182,40 @@ public static boolean validateRequiredResour

[jira] [Resolved] (KAFKA-15455) Add support for OffsetCommit version 9 in consumer

2024-01-09 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-15455. Fix Version/s: 3.7.0 (was: 3.8.0) Resolution: Fixed > Add su

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-01-09 Thread via GitHub
apoorvmittal10 commented on code in PR #15148: URL: https://github.com/apache/kafka/pull/15148#discussion_r1446625255 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -175,16 +182,40 @@ public static boolean validateRequiredR

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-01-09 Thread via GitHub
philipnee commented on code in PR #15148: URL: https://github.com/apache/kafka/pull/15148#discussion_r1446620286 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -175,16 +182,40 @@ public static boolean validateRequiredResour

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-01-09 Thread via GitHub
apoorvmittal10 commented on PR #15148: URL: https://github.com/apache/kafka/pull/15148#issuecomment-1883799949 Build passed on all environments with unrelated tests failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-16082) JBOD: Possible dataloss when moving leader partition

2024-01-09 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804880#comment-17804880 ] Proven Provenzano commented on KAFKA-16082: --- [~gnarula] added an improvement f

[jira] [Comment Edited] (KAFKA-16082) JBOD: Possible dataloss when moving leader partition

2024-01-09 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804879#comment-17804879 ] Proven Provenzano edited comment on KAFKA-16082 at 1/9/24 8:49 PM: ---

Re: [PR] MINOR: Add reviewers GitHub action [kafka]

2024-01-09 Thread via GitHub
mumrah commented on PR #15115: URL: https://github.com/apache/kafka/pull/15115#issuecomment-1883771689 > Although that way we won't be able to merge it via browser That's a non-starter IMO. I wonder if we could write our own bot for these kinds of automations. https://probot.g

[jira] [Commented] (KAFKA-16082) JBOD: Possible dataloss when moving leader partition

2024-01-09 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804879#comment-17804879 ] Proven Provenzano commented on KAFKA-16082: --- For the case of 3:   If I underst

[PR] KAFKA-15853: Move AuthorizerUtils and its dependencies to server module [kafka]

2024-01-09 Thread via GitHub
OmniaGM opened a new pull request, #15167: URL: https://github.com/apache/kafka/pull/15167 Blocker for #15103 - Moving AuthorizerUtils and Session into server module ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test c

Re: [PR] MINOR: Enable kraft test in kafka.api and kafka.network [kafka]

2024-01-09 Thread via GitHub
mimaison commented on code in PR #14595: URL: https://github.com/apache/kafka/pull/14595#discussion_r1446558104 ## core/src/test/scala/integration/kafka/api/RackAwareAutoTopicCreationTest.scala: ## @@ -35,31 +37,37 @@ class RackAwareAutoTopicCreationTest extends KafkaServerTest

Re: [PR] KAFKA-14505; [4/N] Wire transaction verification [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15142: URL: https://github.com/apache/kafka/pull/15142#discussion_r1446538966 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/PartitionWriter.java: ## @@ -116,4 +120,21 @@ long appendEndTransactionMarker( in

Re: [PR] KAFKA-14505; [4/N] Wire transaction verification [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15142: URL: https://github.com/apache/kafka/pull/15142#discussion_r1446536290 ## core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala: ## @@ -201,18 +203,55 @@ class CoordinatorPartitionWriter[T]( )) } + /** +

[jira] [Created] (KAFKA-16106) group size counters do not reflect the actual sizes when operations fail

2024-01-09 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-16106: Summary: group size counters do not reflect the actual sizes when operations fail Key: KAFKA-16106 URL: https://issues.apache.org/jira/browse/KAFKA-16106 Project: Kafka

[jira] [Updated] (KAFKA-16100) Consistent handling of timeouts and responses for new consumer ApplicationEvents

2024-01-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16100: -- Fix Version/s: 3.8.0 > Consistent handling of timeouts and responses for new consumer > ApplicationEv

[jira] [Updated] (KAFKA-16100) Consistent handling of timeouts and responses for new consumer ApplicationEvents

2024-01-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16100: -- Labels: consumer-threading-refactor (was: ) > Consistent handling of timeouts and responses for new c

[jira] [Updated] (KAFKA-16104) Enable additional PlaintextConsumerTest tests for new consumer

2024-01-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16104: -- Fix Version/s: 3.8.0 > Enable additional PlaintextConsumerTest tests for new consumer > --

[jira] [Updated] (KAFKA-16104) Enable additional PlaintextConsumerTest tests for new consumer

2024-01-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16104: -- Labels: consumer-threading-refactor (was: ) > Enable additional PlaintextConsumerTest tests for new c

Re: [PR] KAFKA-16083: Exclude throttle time when expiring inflight requests on a connection [kafka]

2024-01-09 Thread via GitHub
jolshan commented on PR #15130: URL: https://github.com/apache/kafka/pull/15130#issuecomment-1883672884 ^ Those are issues I see frequently and are likely unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (KAFKA-15557) Investigate FetcherTest's/FetchRequestManager's duplicate metadata update in assignFromUserNoId

2024-01-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15557: -- Fix Version/s: 4.0.0 (was: 3.8.0) > Investigate FetcherTest's/FetchRequestManag

[jira] [Commented] (KAFKA-15250) DefaultBackgroundThread is running tight loop

2024-01-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804861#comment-17804861 ] Kirk True commented on KAFKA-15250: --- This is still an issue. If you enable detailed lo

[jira] [Reopened] (KAFKA-15250) DefaultBackgroundThread is running tight loop

2024-01-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reopened KAFKA-15250: --- Assignee: Kirk True (was: Philip Nee) > DefaultBackgroundThread is running tight loop > -

[jira] [Updated] (KAFKA-15250) DefaultBackgroundThread is running tight loop

2024-01-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15250: -- Fix Version/s: 3.8.0 > DefaultBackgroundThread is running tight loop > ---

[jira] [Resolved] (KAFKA-15941) Flaky test: shouldRestoreNullRecord() – org.apache.kafka.streams.integration.RestoreIntegrationTest

2024-01-09 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-15941. Resolution: Cannot Reproduce > Flaky test: shouldRestoreNullRecord() – > org.apache.kafka

[jira] [Closed] (KAFKA-15941) Flaky test: shouldRestoreNullRecord() – org.apache.kafka.streams.integration.RestoreIntegrationTest

2024-01-09 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy closed KAFKA-15941. -- Assignee: Lucas Brutschy > Flaky test: shouldRestoreNullRecord() – > org.apache.kafka.streams

[jira] [Commented] (KAFKA-15941) Flaky test: shouldRestoreNullRecord() – org.apache.kafka.streams.integration.RestoreIntegrationTest

2024-01-09 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804856#comment-17804856 ] Lucas Brutschy commented on KAFKA-15941: Test hasn't failed in the last month so

Re: [PR] KAFKA-16093: Fix spurious REST-related warnings on Connect startup [kafka]

2024-01-09 Thread via GitHub
C0urante commented on code in PR #15149: URL: https://github.com/apache/kafka/pull/15149#discussion_r1446506255 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java: ## @@ -226,20 +235,20 @@ protected final void initializeResources() {

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-09 Thread via GitHub
mumrah commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1446495993 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1409,6 +1426,77 @@ class KafkaApis(val requestChannel: RequestChannel, )) } + def handleDescribe

Re: [PR] KAFKA-16093: Fix spurious REST-related warnings on Connect startup [kafka]

2024-01-09 Thread via GitHub
C0urante commented on code in PR #15149: URL: https://github.com/apache/kafka/pull/15149#discussion_r1446490147 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -159,7 +163,8 @@ public class ConnectorsResourceTes

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1446488616 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final Set del

Re: [PR] KAFKA-14683 Migrate #testStartPaused to Mockito [kafka]

2024-01-09 Thread via GitHub
gharris1727 commented on PR #14663: URL: https://github.com/apache/kafka/pull/14663#issuecomment-1883616431 Hi @hgeraldino Thanks for taking on the migration! I understand the idea behind your refactor-then-deduplicate strategy, but I think the excessive duplication is making it diffi

[jira] [Commented] (KAFKA-15475) Timeout request might retry forever even if the user API times out in PrototypeAsyncConsumer

2024-01-09 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804846#comment-17804846 ] Lianet Magrans commented on KAFKA-15475: Heads up, the TopicMetadataManager and

[jira] [Assigned] (KAFKA-15588) Purge the unsent offset commits/fetches when the member is fenced/failed

2024-01-09 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans reassigned KAFKA-15588: -- Assignee: Lianet Magrans (was: Philip Nee) > Purge the unsent offset commits/fetches

[jira] [Resolved] (KAFKA-16099) Handle timeouts for AsyncKafkaConsumer.commitSync

2024-01-09 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-16099. Fix Version/s: 3.7.0 Resolution: Fixed > Handle timeouts for AsyncKafkaConsumer.com

[PR] KAFKA-15853: Move ProcessRole to server module [kafka]

2024-01-09 Thread via GitHub
OmniaGM opened a new pull request, #15166: URL: https://github.com/apache/kafka/pull/15166 prepare to move KafkaConfig ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify doc

[jira] [Updated] (KAFKA-16105) Reassignment of tiered topics is failing due to RemoteStorageException

2024-01-09 Thread Anatolii Popov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anatolii Popov updated KAFKA-16105: --- Description: When partition reassignment is happening for a tiered topic in most of the cas

[jira] [Created] (KAFKA-16105) Reassignment of tiered topics is failing due to RemoteStorageException

2024-01-09 Thread Anatolii Popov (Jira)
Anatolii Popov created KAFKA-16105: -- Summary: Reassignment of tiered topics is failing due to RemoteStorageException Key: KAFKA-16105 URL: https://issues.apache.org/jira/browse/KAFKA-16105 Project: K

[PR] Reassignment fix [kafka]

2024-01-09 Thread via GitHub
AnatolyPopov opened a new pull request, #15165: URL: https://github.com/apache/kafka/pull/15165 When partition reassignment is happening for a tiered topic in most of the cases it's stuck with RemoteStorageException's on follower nodes saying that it can not construct remote log auxilary st

[PR] KAFKA-15853: Move PasswordEncoder to server module [kafka]

2024-01-09 Thread via GitHub
OmniaGM opened a new pull request, #15164: URL: https://github.com/apache/kafka/pull/15164 blocked on #15158 - Tests will fail ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] V

Re: [PR] KAFKA-15721: KRaft support in DeleteTopicsRequestWithDeletionDisabledTest [kafka]

2024-01-09 Thread via GitHub
jolshan commented on PR #15124: URL: https://github.com/apache/kafka/pull/15124#issuecomment-1883534800 Sorry I don't seem to get notified for tags until the PR gets merged. I need to look at my notification settings 😅 -- This is an automated message from the Apache Git Service. To respo

[jira] [Updated] (KAFKA-15284) Implement ConsumerGroupProtocolVersionResolver to determine consumer group protocol

2024-01-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15284: -- Fix Version/s: 4.0.0 (was: 3.8.0) > Implement ConsumerGroupProtocolVersionResol

[PR] KAFKA-16097: Add suspended tasks back to the state updater when reassigned [kafka]

2024-01-09 Thread via GitHub
lucasbru opened a new pull request, #15163: URL: https://github.com/apache/kafka/pull/15163 When a partition is revoked, the corresponding task gets a pending action "SUSPEND". This pending action may overwrite a previous pending action. If the task was previously removed from the s

[jira] [Updated] (KAFKA-14404) Fix & update docs on client configs controlled by Streams

2024-01-09 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari updated KAFKA-14404: External issue URL: (was: https://github.com/apache/kafka/pull/15162) > Fix & update docs on cli

[jira] [Updated] (KAFKA-14404) Fix & update docs on client configs controlled by Streams

2024-01-09 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari updated KAFKA-14404: External issue URL: https://github.com/apache/kafka/pull/15162 > Fix & update docs on client confi

  1   2   3   >