[jira] [Commented] (KAFKA-16701) Some SocketServerTest buffered close tests flaky failing locally

2024-07-19 Thread bboyleonp (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867469#comment-17867469 ] bboyleonp commented on KAFKA-16701: --- Hi [~gharris1727], I am using M2 Mac with JDK 17, and I can

Re: [PR] KAFKA-16558 Implemented HeartbeatRequestState toStringBase() and added a test for it [kafka]

2024-07-19 Thread via GitHub
mjsax commented on code in PR #16373: URL: https://github.com/apache/kafka/pull/16373#discussion_r1685169625 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -153,6 +154,35 @@ public void cleanup() { } }

Re: [PR] KAFKA-16558 Implemented HeartbeatRequestState toStringBase() and added a test for it [kafka]

2024-07-19 Thread via GitHub
mjsax commented on code in PR #16373: URL: https://github.com/apache/kafka/pull/16373#discussion_r1685169625 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -153,6 +154,35 @@ public void cleanup() { } }

Re: [PR] KAFKA-16558 Implemented HeartbeatRequestState toStringBase() and added a test for it [kafka]

2024-07-19 Thread via GitHub
mjsax commented on code in PR #16373: URL: https://github.com/apache/kafka/pull/16373#discussion_r1685169625 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -153,6 +154,35 @@ public void cleanup() { } }

Re: [PR] KAFKA-16558 Implemented HeartbeatRequestState toStringBase() and added a test for it [kafka]

2024-07-19 Thread via GitHub
mjsax commented on code in PR #16373: URL: https://github.com/apache/kafka/pull/16373#discussion_r1685169625 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -153,6 +154,35 @@ public void cleanup() { } }

Re: [PR] KAFKA-16558 Implemented HeartbeatRequestState toStringBase() and added a test for it [kafka]

2024-07-19 Thread via GitHub
mjsax commented on code in PR #16373: URL: https://github.com/apache/kafka/pull/16373#discussion_r1685169766 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -485,6 +485,18 @@ public void resetTimer() {

[PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

2024-07-19 Thread via GitHub
TaiJuWu opened a new pull request, #16638: URL: https://github.com/apache/kafka/pull/16638 *More detailed description of your change, See [KAFKA-17163](https://issues.apache.org/jira/browse/KAFKA-17163) *Summary of testing strategy (including rationale) ### Committer

[jira] [Comment Edited] (KAFKA-17163) Revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure for AsyncKafkaConsumer

2024-07-19 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867142#comment-17867142 ] TaiJuWu edited comment on KAFKA-17163 at 7/19/24 10:30 PM: --- Hi [~lianetm] ,

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
jsancio commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1685046009 ## raft/src/main/java/org/apache/kafka/raft/internals/AddVoterHandler.java: ## @@ -0,0 +1,383 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
jolshan commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1685037958 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1685017655 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1685009137 ## raft/src/main/java/org/apache/kafka/raft/internals/AddVoterHandler.java: ## @@ -0,0 +1,383 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1685007655 ## raft/src/main/java/org/apache/kafka/raft/Endpoints.java: ## @@ -101,6 +102,21 @@ public BeginQuorumEpochRequestData.LeaderEndpointCollection toBeginQuorumEpochRe

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1685007319 ## raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java: ## @@ -65,7 +65,7 @@ public final class KRaftControlRecordStateMachine {

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
jolshan commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684962284 ## core/src/test/scala/unit/kafka/server/BrokerFeaturesTest.scala: ## @@ -95,10 +97,20 @@ class BrokerFeaturesTest { val expectedFeatures = Map[String, Short](

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
junrao commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684941966 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -217,9 +217,10 @@ public enum MetadataVersion { // Add ELR related

[jira] [Updated] (KAFKA-17170) Add test to ensure new consumer acks reconciled assignment even if first HB with ack lost

2024-07-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-17170: --- Description: When a consumer reconciles an assignment, it transitions to ACKNOWLEDGING, so

[jira] [Updated] (KAFKA-17170) Add test to ensure new consumer acks reconciled assignment even if first HB with ack lost

2024-07-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-17170: --- Description: When a consumer reconciles an assignment, it transitions to ACKNOWLEDGING, so

[jira] [Updated] (KAFKA-17170) Add test to ensure new consumer acks reconciled assignment even if first HB with ack lost

2024-07-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-17170: --- Description: When a consumer reconciles an assignment, it transitions to ACKNOWLEDGING, so

[jira] [Created] (KAFKA-17170) Add test to ensure new consumer acks reconciled assignment even if first HB with ack lost

2024-07-19 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17170: -- Summary: Add test to ensure new consumer acks reconciled assignment even if first HB with ack lost Key: KAFKA-17170 URL: https://issues.apache.org/jira/browse/KAFKA-17170

[jira] [Commented] (KAFKA-16068) Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors

2024-07-19 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867411#comment-17867411 ] Chris Egerton commented on KAFKA-16068: --- @johndoe I've reassigned this to myself; let me know if

[jira] [Assigned] (KAFKA-16068) Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors

2024-07-19 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-16068: - Assignee: Chris Egerton (was: johndoe) > Use TestPlugins in

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
jolshan commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684885144 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit

Re: [PR] KAFKA-14569: Migrate Connect's integration test EmbeddedKafkaCluster from ZK to KRaft mode [kafka]

2024-07-19 Thread via GitHub
C0urante commented on PR #16599: URL: https://github.com/apache/kafka/pull/16599#issuecomment-2239959002 Well, I tried to push a new commit at least. Looks like airplane wifi is strong enough to publish GitHub comments but not enough to push commits. Will keep retrying until the commit

Re: [PR] KAFKA-14569: Migrate Connect's integration test EmbeddedKafkaCluster from ZK to KRaft mode [kafka]

2024-07-19 Thread via GitHub
C0urante commented on PR #16599: URL: https://github.com/apache/kafka/pull/16599#issuecomment-2239932531 Thanks Mickael! Pushed a new commit, ready for another round when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-14569: Migrate Connect's integration test EmbeddedKafkaCluster from ZK to KRaft mode [kafka]

2024-07-19 Thread via GitHub
C0urante commented on code in PR #16599: URL: https://github.com/apache/kafka/pull/16599#discussion_r1684858189 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExactlyOnceSourceIntegrationTest.java: ## @@ -694,12 +701,29 @@ public void

Re: [PR] KAFKA-14569: Migrate Connect's integration test EmbeddedKafkaCluster from ZK to KRaft mode [kafka]

2024-07-19 Thread via GitHub
C0urante commented on code in PR #16599: URL: https://github.com/apache/kafka/pull/16599#discussion_r1684857716 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java: ## @@ -95,98 +88,60 @@ import static

Re: [PR] KAFKA-16709: abortAndPauseCleaning only when future log is not existed [kafka]

2024-07-19 Thread via GitHub
junrao commented on code in PR #15951: URL: https://github.com/apache/kafka/pull/15951#discussion_r1678493157 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -427,7 +427,7 @@ class Partition(val topicPartition: TopicPartition, * @param highWatermarkCheckpoints

[PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-19 Thread via GitHub
ahuang98 opened a new pull request, #16637: URL: https://github.com/apache/kafka/pull/16637 This handles V2 of the DescribeQuorum protocol to support KIP-853 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage

Re: [PR] MINOR: Clarify ACL requirements for Connect workers when exactly.once.source.support is set to preparing [kafka]

2024-07-19 Thread via GitHub
C0urante commented on PR #16636: URL: https://github.com/apache/kafka/pull/16636#issuecomment-2239840026 If approved, I'll backport onto our docs repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-17044) Connector deletion can lead to resource leak during a long running connector startup

2024-07-19 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867397#comment-17867397 ] Chris Egerton commented on KAFKA-17044: --- The crux of the issue is that invoking {{stop}} on a

[PR] MINOR: Clarify ACL requirements for Connect workers when exactly.once.source.support is set to preparing [kafka]

2024-07-19 Thread via GitHub
C0urante opened a new pull request, #16636: URL: https://github.com/apache/kafka/pull/16636 I noticed that we don't explicitly call out worker ACL requirements when `exactly.once.source.support` is set to `preparing`. We should include this information in our docs so that cluster

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
jolshan commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684718844 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
jolshan commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684712684 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
jolshan commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684712684 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684705617 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit

[jira] [Created] (KAFKA-17169) Add an EndpointsTest suite that test all of the public methods

2024-07-19 Thread Jira
José Armando García Sancio created KAFKA-17169: -- Summary: Add an EndpointsTest suite that test all of the public methods Key: KAFKA-17169 URL: https://issues.apache.org/jira/browse/KAFKA-17169

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
jsancio commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684708856 ## raft/src/main/java/org/apache/kafka/raft/Endpoints.java: ## @@ -101,6 +102,21 @@ public BeginQuorumEpochRequestData.LeaderEndpointCollection toBeginQuorumEpochRe

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
jsancio commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684706132 ## raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java: ## @@ -221,7 +230,7 @@ private void maybeLoadLog() { } private

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
jsancio commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684705773 ## raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java: ## @@ -65,7 +65,7 @@ public final class KRaftControlRecordStateMachine {

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684705617 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit

Re: [PR] KAFKA-16056: Revoking connectors and tasks upon worker poll timeout expiry to prevent duplicate task assignments [kafka]

2024-07-19 Thread via GitHub
gharris1727 commented on PR #16628: URL: https://github.com/apache/kafka/pull/16628#issuecomment-2239732197 Can't seem to run ./gradlew :connect:runtime:spotlessApply locally. Let me check this and updatez spotless behavior is jre-version-dependent, you can run with JDK11 and it

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
jsancio commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684696258 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -273,10 +292,29 @@ public void appendLeaderChangeMessageAndBootstrapRecords(long currentTimeMs) {

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
junrao commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684690411 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit =

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
junrao commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684690411 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit =

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
jolshan commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684693402 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
junrao commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684690411 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit =

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
jsancio commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684686209 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -3154,14 +3279,15 @@ private static Registration unregister(Listener listener) { }

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
jsancio commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684684173 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -348,22 +360,29 @@ private void onUpdateLeaderHighWatermark( private void

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
jsancio commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684658784 ## raft/src/main/java/org/apache/kafka/raft/internals/AddVoterHandler.java: ## @@ -0,0 +1,383 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
jolshan commented on PR #16183: URL: https://github.com/apache/kafka/pull/16183#issuecomment-2239635110 Given that Kraft version starts at 0, I guess we should have all versions start a zero for consistency. I also noticed one test asserts all features with version zero bootstrap with

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
jolshan commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684645307 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
jolshan commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684642190 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -217,8 +217,12 @@ public enum MetadataVersion { // Add ELR related

Re: [PR] MINOR: Add integration test for plugin aliases [kafka]

2024-07-19 Thread via GitHub
C0urante merged PR #16621: URL: https://github.com/apache/kafka/pull/16621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Add integration test for plugin aliases [kafka]

2024-07-19 Thread via GitHub
C0urante commented on PR #16621: URL: https://github.com/apache/kafka/pull/16621#issuecomment-2239624234 The changes in the latest commit are trivial, the build passes locally, and CI indicates that the prior commit is healthy. Merging... -- This is an automated message from the Apache

Re: [PR] MINOR: Add integration test for plugin aliases [kafka]

2024-07-19 Thread via GitHub
C0urante commented on code in PR #16621: URL: https://github.com/apache/kafka/pull/16621#discussion_r1684638235 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -1375,6 +1380,57 @@ public void

[jira] [Updated] (KAFKA-17163) Revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure for AsyncKafkaConsumer

2024-07-19 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17163: -- Component/s: clients > Revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure for

[jira] [Commented] (KAFKA-16524) Metrics for KIP-853

2024-07-19 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867384#comment-17867384 ] José Armando García Sancio commented on KAFKA-16524: [~xiaochen.hi] sounds good.

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
junrao commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684620247 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit =

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684612120 ## raft/src/main/java/org/apache/kafka/raft/Endpoints.java: ## @@ -101,6 +102,21 @@ public BeginQuorumEpochRequestData.LeaderEndpointCollection toBeginQuorumEpochRe

Re: [PR] KAFKA-16192: Introduce transaction.version and usage of flexible records to coordinators [kafka]

2024-07-19 Thread via GitHub
jolshan commented on PR #16183: URL: https://github.com/apache/kafka/pull/16183#issuecomment-2239559725 Will look at the apiversions test failures  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684609938 ## raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java: ## @@ -221,7 +230,7 @@ private void maybeLoadLog() { } private

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684609661 ## raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java: ## @@ -65,7 +65,7 @@ public final class KRaftControlRecordStateMachine {

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684608021 ## raft/src/main/java/org/apache/kafka/raft/internals/AddVoterHandler.java.orig: ## @@ -0,0 +1,379 @@ +/* Review Comment: I do not think you intended to submit

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684606840 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -273,10 +292,29 @@ public void appendLeaderChangeMessageAndBootstrapRecords(long currentTimeMs) {

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684606280 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -3154,14 +3279,15 @@ private static Registration unregister(Listener listener) { }

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684605221 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -348,22 +360,29 @@ private void onUpdateLeaderHighWatermark( private void

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-19 Thread via GitHub
cmccabe commented on code in PR #16626: URL: https://github.com/apache/kafka/pull/16626#discussion_r1684601533 ## raft/src/main/java/org/apache/kafka/raft/internals/AddVoterHandler.java: ## @@ -0,0 +1,383 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-17142: Fix deadlock caused by LogManagerTest#testLogRecoveryMetrics [kafka]

2024-07-19 Thread via GitHub
junrao commented on code in PR #16614: URL: https://github.com/apache/kafka/pull/16614#discussion_r1684592601 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long

Re: [PR] KAFKA-17153 KafkaMetricsGroup#newGauge should accept functional interface instead of `com.yammer.metrics.core.Gague` [kafka]

2024-07-19 Thread via GitHub
brandboat commented on code in PR #16618: URL: https://github.com/apache/kafka/pull/16618#discussion_r1684578678 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -70,16 +71,26 @@ public static MetricName explicitMetricName(String

[PR] KAFKA-17144: Retract unimplemented ListGroups v6 added in error [kafka]

2024-07-19 Thread via GitHub
AndrewJSchofield opened a new pull request, #16635: URL: https://github.com/apache/kafka/pull/16635 List Groups v6 was introduced in error as part of KIP-932. We agreed not to bump ListGroups during KIP discussion, but the RPC definitions were made in error. No code changes apart from the

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-19 Thread via GitHub
brenden20 commented on PR #16200: URL: https://github.com/apache/kafka/pull/16200#issuecomment-2239426940 @lianetm thank you for the review! I addressed the comments you left. Let me know if it is good -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-19 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1684512734 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -898,6 +837,30 @@ private HeartbeatRequestManager

Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter` to tools module [kafka]

2024-07-19 Thread via GitHub
m1a2st commented on PR #16019: URL: https://github.com/apache/kafka/pull/16019#issuecomment-2239400247 @chia7712, PTAL, Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] MINOR: Move queued.max.requests, queued.max.request.bytes to SocketSe… [kafka]

2024-07-19 Thread via GitHub
mimaison opened a new pull request, #16634: URL: https://github.com/apache/kafka/pull/16634 …rverConfigs These 2 configurations are only used in SocketServer ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

Re: [PR] MINOR: Various cleanups in metadata [kafka]

2024-07-19 Thread via GitHub
mimaison commented on PR #16610: URL: https://github.com/apache/kafka/pull/16610#issuecomment-2239252863 My bad. Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (KAFKA-17163) Revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure for AsyncKafkaConsumer

2024-07-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867334#comment-17867334 ] Lianet Magrans commented on KAFKA-17163: Sure, thanks for helping out! Happy to help with the

[jira] [Resolved] (KAFKA-12877) Fix KRPC files with missing flexibleVersions annotation

2024-07-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12877. Fix Version/s: 3.0.0 Resolution: Fixed > Fix KRPC files with missing

Re: [PR] KAFKA-17142: Fix deadlock caused by LogManagerTest#testLogRecoveryMetrics [kafka]

2024-07-19 Thread via GitHub
FrankYang0529 commented on code in PR #16614: URL: https://github.com/apache/kafka/pull/16614#discussion_r1684321413 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long

[jira] [Resolved] (KAFKA-17132) Revisit testMissingOffsetNoResetPolicy for AsyncConsumer

2024-07-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17132. Fix Version/s: 3.9.0 Resolution: Fixed > Revisit testMissingOffsetNoResetPolicy

Re: [PR] KAFKA-17132: Revisit testMissingOffsetNoResetPolicy for AsyncConsumer [kafka]

2024-07-19 Thread via GitHub
chia7712 merged PR #16587: URL: https://github.com/apache/kafka/pull/16587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-17082: replace kafka.utils.LogCaptureAppender with org.apache.kafka.common.utils.LogCaptureAppender [kafka]

2024-07-19 Thread via GitHub
chia7712 commented on code in PR #16601: URL: https://github.com/apache/kafka/pull/16601#discussion_r1684192782 ## core/src/test/scala/unit/kafka/admin/AclCommandTest.scala: ## @@ -217,17 +217,16 @@ class AclCommandTest extends QuorumTestHarness with Logging {

Re: [PR] MINOR: Various cleanups in metadata [kafka]

2024-07-19 Thread via GitHub
chia7712 commented on PR #16610: URL: https://github.com/apache/kafka/pull/16610#issuecomment-2238844809 @mimaison please fix the build error on scala 2.12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (KAFKA-17121) junit-platform.properties files in published artifacts pollute the test classpath of consumers

2024-07-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17121. Fix Version/s: 3.9.0 Resolution: Fixed > junit-platform.properties files in

Re: [PR] KAFKA-17121: junit-platform.properties files in published artifacts pollute the test classpath of consumers [kafka]

2024-07-19 Thread via GitHub
chia7712 merged PR #16624: URL: https://github.com/apache/kafka/pull/16624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16855 : Based on tiered state of topic, check for tasks [kafka]

2024-07-19 Thread via GitHub
showuon commented on PR #16615: URL: https://github.com/apache/kafka/pull/16615#issuecomment-2238836955 @clolov , do you have POC for KRaft implementation? If no, please let me know. I might need some time to implement it. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16855 : Based on tiered state of topic, check for tasks [kafka]

2024-07-19 Thread via GitHub
showuon commented on PR #16615: URL: https://github.com/apache/kafka/pull/16615#issuecomment-2238831264 From the [KIP-950](https://cwiki.apache.org/confluence/display/KAFKA/KIP-950%3A++Tiered+Storage+Disablement#KIP950:TieredStorageDisablement-Disablement-KRaftBackedCluster), when user

[PR] KAFKA-17159: Make sure kafka-cluster-test-kit-executor get down when closing KafkaClusterTestKit [kafka]

2024-07-19 Thread via GitHub
FrankYang0529 opened a new pull request, #16633: URL: https://github.com/apache/kafka/pull/16633 When trying to remove `TestUtils.waitForCondition` in https://github.com/apache/kafka/pull/16499, kraft may have thread leak. We can use

[PR] MINOR: Extract SockerServer inner classes to server module [kafka]

2024-07-19 Thread via GitHub
mimaison opened a new pull request, #16632: URL: https://github.com/apache/kafka/pull/16632 All remaining classes depend on KafkaConfig so can't be extracted at the moment. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-07-19 Thread via GitHub
cadonna merged PR #16093: URL: https://github.com/apache/kafka/pull/16093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-16524) Metrics for KIP-853

2024-07-19 Thread xiaochen.zhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867213#comment-17867213 ] xiaochen.zhou commented on KAFKA-16524: --- I would like to give a try on this, can I take this

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-07-19 Thread via GitHub
loicgreffier commented on PR #16093: URL: https://github.com/apache/kafka/pull/16093#issuecomment-2238616251 > Thanks for the updates @loicgreffier , @sebastienviale , and @Dabz! > > I just have one comment on my own proposal  > > For the rest LGTM! > > Could you write

Re: [PR] KAFKA-16984: Complete consumer leave on response to leave request [kafka]

2024-07-19 Thread via GitHub
lucasbru merged PR #16569: URL: https://github.com/apache/kafka/pull/16569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-07-19 Thread via GitHub
cadonna commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1683955470 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorNodeTest.java: ## @@ -34,36 +44,110 @@ import org.apache.kafka.test.StreamsTestUtils;

[jira] [Commented] (KAFKA-16926) Optimize BeginQuorumEpoch heartbeat

2024-07-19 Thread xiaochen.zhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867214#comment-17867214 ] xiaochen.zhou commented on KAFKA-16926: --- I would like to give a try on this, can I take this

Re: [PR] KAFKA-17121: junit-platform.properties files in published artifacts pollute the test classpath of consumers [kafka]

2024-07-19 Thread via GitHub
wilkinsona commented on PR #16624: URL: https://github.com/apache/kafka/pull/16624#issuecomment-2238458153 LGTM, @chia7712. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (KAFKA-5511) ConfigDef.define() overloads take too many parameters

2024-07-19 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867195#comment-17867195 ] Ksolves India Limited commented on KAFKA-5511: -- We can implement a ConfigKeyBuilder to

[jira] [Commented] (KAFKA-4998) Add utility to convert between TopicPartition and PartitionInfo

2024-07-19 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867192#comment-17867192 ] Ksolves India Limited commented on KAFKA-4998: -- As per my understanding, A method named