Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-16 Thread via GitHub
hanyuzheng7 commented on PR #14523: URL: https://github.com/apache/kafka/pull/14523#issuecomment-1765551586 @mjsax Thank you for reviewing the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-16 Thread via GitHub
mjsax merged PR #14523: URL: https://github.com/apache/kafka/pull/14523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-16 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1360875657 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +718,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-16 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1360875255 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -1071,16 +1568,51 @@ public void shouldHandleKeyQuery(

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-15 Thread via GitHub
mjsax commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1360050468 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +718,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-12 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1357233277 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -863,6 +863,14 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-12 Thread via GitHub
mjsax commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1357200716 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -880,25 +888,113 @@ private void shouldHandleWindowKeyQueries(final

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-12 Thread via GitHub
mjsax commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1357200115 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -880,25 +888,113 @@ private void shouldHandleWindowKeyQueries(final

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-12 Thread via GitHub
mjsax commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1357193113 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -863,6 +863,14 @@ private void shouldHandleWindowKeyQueries(final

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-12 Thread via GitHub
mjsax commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1357188427 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-12 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356041608 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -880,25 +888,113 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356034620 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -863,6 +863,14 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356034620 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -863,6 +863,14 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356034620 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -863,6 +863,14 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356034620 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -863,6 +863,14 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356033429 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356041608 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -880,25 +888,113 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356044046 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -847,11 +847,11 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356033429 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356033429 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356043842 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -413,7 +413,7 @@ public static void before()

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356044046 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -847,11 +847,11 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356043842 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -413,7 +413,7 @@ public static void before()

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on PR #14523: URL: https://github.com/apache/kafka/pull/14523#issuecomment-1758892421 > Thanks for extending this test. This is very helpful. > > I am wondering, if it would be beneficial to add more input record, such that a few windows have more than one

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356042346 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -880,25 +888,113 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356041608 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -880,25 +888,113 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356034620 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -863,6 +863,14 @@ private void

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356033429 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356033429 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
hanyuzheng7 commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1356033429 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {

Re: [PR] KAFKA-15569: test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-11 Thread via GitHub
mjsax commented on code in PR #14523: URL: https://github.com/apache/kafka/pull/14523#discussion_r1355991839 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ## @@ -716,7 +716,7 @@ public void process(final Record record) {