Back with some proxy updates

2003-12-03 Thread Jeremy Arnold
Hello, After a somewhat longer break than I was intending, I'm back to doing some JMeter work. We're settled back in the U.S. now after our year in Sweden. I'm a little behind on the JMeter mailing lists, but have continued to read the messages and will eventually get caught up. And

Re: cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/proxy ProxyControl.java

2003-12-03 Thread Jeremy Arnold
Hello, Sorry for not running the tests -- I'll get into the habit of doing that. I see that Sebastian beat me to fixing my stupid mistake -- sorry I wasn't able to get to it earlier. On a related topic, I didn't have much luck trying to run just this specific test inside Eclipse in

Travelling

2003-09-07 Thread Jeremy Arnold
Hello, Just so you guys know, I'll probably be a bit quiet for the next few weeks. Out of town on business for a few days, and then out of town on vacation for a few days, then home for a couple days, out on business for a couple days, and then we're moving back to the States. (Yay!) And

Re: Suggestion: sort messages.properties files

2003-09-05 Thread Jeremy Arnold
Sorting it may help, but what about splitting it up as well? I think it would be nice to have the HTTP messages kept with the HTTP protocol, etc. Of course, this would require some changes to how the lookups are doneI haven't really thought through the details of how that should work,

Re: Missing license headers

2003-09-03 Thread Jeremy Arnold
and then start with a fresh checkout in the new one. Jeremy [EMAIL PROTECTED] wrote: I'd be interested. -Mike On 3 Sep 2003 at 0:16, Jeremy Arnold wrote: Mike, Personally I find it easiest to use different workspaces for work projects vs other projects. This is one reason why. Similar

Missing license headers

2003-09-02 Thread Jeremy Arnold
Hello, There are several JMeter files which do not have the Apache license header. The license should be added to these files. But I would assume that before we add these headers we need to track down where the file came from and make sure it is actually properly licensed. So if you

Re: Missing license headers

2003-09-02 Thread Jeremy Arnold
Mike, Personally I find it easiest to use different workspaces for work projects vs other projects. This is one reason why. Similar reasoning applies to formatting settings. In addition, my current project at work has something on the order of 20-30 different projects in Eclipse

JDBC Connection Pool updates

2003-08-29 Thread Jeremy Arnold
Hello, As I've mentioned a couple times, I've been doing some work on the JDBC Connection Pool implementation. I have a new implementation based on Jakarta-Commons-Pool which seems to work fine, but it doesn't support the same configuration options as the original pool implementation, so

[Fwd: Re: monitoring with jmeter]

2003-08-28 Thread Jeremy Arnold
Hello, I'm moving this thread to jmeter-dev from jmeter-user so we can discuss some of the details. Some of the thoughts I mentioned earlier on the JMeter 2.0 thread seem to be related to what Peter is talking about doing. We need to have a way to collect statistics other than the

Re: Should JMeter 2.0 require JDK 1.4?

2003-08-27 Thread Jeremy Arnold
Hello, Jordi Salvat i Alabart wrote: Anyway, you've made me change my mind. +1 to drop 1.3 support. Rationale: at the current project stage, making the life of JMeter developers easy is a priority. And you were doing such a good job of making me reconsider the idea. :) But I still think the

Re: Should JMeter 2.0 require JDK 1.4?

2003-08-27 Thread Jeremy Arnold
[EMAIL PROTECTED] wrote: Peter, Sebastian, and Elan all got their accounts. Great. Welcome guys! (Sorry for not noticing earlier.) Regarding the 100 column line, I think most people are apathetic. What that means we should decide? I'm not sure :-) And, I wrote that bit about

Re: Code formatting

2003-08-25 Thread Jeremy Arnold
Hello, It looks like people were generally in favor of bumping up the 80 column width limit, but we didn't really make a decision. It can be rather difficult to come to an agreement when we are dealing with a sliding scale (80 columns? 100? 120? Personally I prefer 117.5.) So let's

Re: Should JMeter 2.0 require JDK 1.4?

2003-08-25 Thread Jeremy Arnold
Jordi, Thanks for pointing out those comments. It's good to have the discussion regardless of what the final outcome ends up being. First of all, I don't disagree with your points. But I'd like to dig in a bit deeper. So: Regarding #1: Are you aware of examples where this would be a

Correct logger

2003-08-18 Thread Jeremy Arnold
Hello, I mostly stayed on the side-lines a little while back when some of you guys were making changes to the logging system. So now I'd like to check: what is the correct way to define a logger. My guess is: private static Logger log = LoggingManager.getLoggerForClass( ); Am I close?

[Fwd: Re: License for timing library]

2003-08-16 Thread Jeremy Arnold
. <-Original Message-> From: Jeremy Arnold Sent: 7/5/2003 12:28:55 PM To: [EMAIL PROTECTED] Subject: Re: License for timing library Vladimir, Thank you for your response. I'm not a lawyer, but here's my understanding of the process: All you really need to do to allow us to use the

Re: moving jmeter 1.8 release to mirrored directories

2003-08-14 Thread Jeremy Arnold
Robert, It looks like you didn't get any replies (at least not copied to the list), so I would interpret this as no objections. Note that there is a vote for a 1.9 release underway, so you will probably want to either wait for that release, or add 1.9 as well once it is available. Thanks,

Re: Source dist build

2003-08-14 Thread Jeremy Arnold
Hello, In principle, I agree with everything Sebastian said...at least for the src versions. (I still have to think about his comments on the binary versions.) Mike is correct about JMeter having a different target audience than most Jakarta projects. However, I think that the

Should JMeter 2.0 require JDK 1.4?

2003-08-14 Thread Jeremy Arnold
Hello, A couple months ago we discussed the JDK requirements for JMeter, because some new code came in with dependencies on 1.4. At the time I pushed to continue supporting 1.3, largely because these dependencies were relatively easy to work around and requiring 1.4 did not give us a huge

Re: JMeter 2.0 [Re: Source dist build]

2003-08-12 Thread Jeremy Arnold
It's always nice to see other people thinking in the same general directions that I am. I think Jordi is on the right track about having a separate analysis component. I would like to keep the Visualizers out of the Test Plan -- leave the Test Plan with the job of describing the test. Make

Re: Source dist build

2003-08-11 Thread Jeremy Arnold
Mike, Jordi did all the work -- I just spent 5 minutes having Eclipse look for where methods were called from. Getting a dump of CVS sounds like a reasonable plan for this release. But this might be something to discuss for the next release. Moving to Maven might make it a moot point

Re: [VOTE] JMeter release, new contributors

2003-08-04 Thread Jeremy Arnold
1) (Jmeter release) +1 2) (Peter Lin) +0 -- I can't say that I've looked at any of Peter's work, so I don't feel like I can give a +1, but I certainly won't block it. 3) (Elan Chezhiyan) +1 4) (Sebastian Bazley) +1 Thanks for waiting until now to do the release -- I've been in Norway for the

[Fwd: Re: native timer]

2003-07-07 Thread Jeremy Arnold
suite [1]. In fact the JNI interface is also ready. BTW the suite provides more functionality which is useful in benchmarking e.g measuring of CPU load. [1] http://nenya.ms.mff.cuni.cz/~bench/ Tomas - Original Message - From: Jeremy Arnold [EMAIL PROTECTED] To: JMeter Users List [EMAIL

Scheduler code requires JDK 1.4

2003-06-08 Thread Jeremy Arnold
Hello, I just pulled down the latest JMeter code from CVS, and noticed that the ThreadGroupGui now uses JSpinner and related classes. These were not added until JDK 1.4. This dependency is only in the GUI code. As I've mentioned before, I would prefer to keep compatibility at least

Re: Logging suggestions

2003-06-06 Thread Jeremy Arnold
Hello, I would prefer the loggers to remain static if possible -- even if Logkit returns the same logger instance for each call, using a non-static reference will result in an object reference (to the logger) in each instance of a JMeter object. In a 64-bit JVM, this would generally make

Proxy cleanup

2003-06-02 Thread Jeremy Arnold
Hello, I've started taking a look at the HTTP Proxy code in order to understand it better. Along the way, I've started some reformatting and removing some old unused stuff. There shouldn't have been any functional changes, but there was quite a bit of this old unused stuff, so that makes

Re: Proxy cleanup

2003-06-02 Thread Jeremy Arnold
Hello, Don't get your hopes up too much. I admit that my motivation for looking at the proxy server is the numerous requests and questions about this feature on jmeter-user recently. However, I'm not convinced that this is possible. When a browser sets up an HTTPS connection, the data is

Re: Logging suggestions

2003-05-30 Thread Jeremy Arnold
Hello, I don't have a strong opinion about this, although personally I like Log4J. However, my general opinion is that using Commons Logging is great for library code, since this makes it possible to use the same logging setup for several libraries used by one application. But when

Re: Broken JavaSampler

2003-04-05 Thread Jeremy Arnold
it committed when my CVS access working. Jeremy Jeremy Arnold wrote: Mike, It looks like the problem that Chris Gardner was having with the JavaSampler (on the jmeter-user list) was that my patch from March 11 (http://www.mail-archive.com/[EMAIL PROTECTED]/msg03646.html) never got applied

Broken JavaSampler

2003-04-04 Thread Jeremy Arnold
Mike, It looks like the problem that Chris Gardner was having with the JavaSampler (on the jmeter-user list) was that my patch from March 11 (http://www.mail-archive.com/[EMAIL PROTECTED]/msg03646.html) never got applied. Actually, that's only half of the problem...the other half is that

[PATCH] More warning fixes

2003-03-30 Thread Jeremy Arnold
Hello, This patch fixes the remaining warnings reported in Eclipse 2.1. Most were due to calls to static methods through an instance variable. Fixing this uncovered one actual bug: in AllTests it was setting up a FileOutputStream in an instance of TestRunner, but then started the test

[PATCH]JavaSampler fix

2003-03-13 Thread Jeremy Arnold
Hello, Here is the second part of the JavaSampler fix. It builds on top of the previous fix which allowed individual AbstractSampler subclasses to decide whether to implement PerSampleClonable or PerThreadClonable. This second piece of the fix affects only the JavaSampler. I've

ListenerNotifier modifications

2003-03-09 Thread Jeremy Arnold
Hello, I've made some modifications to the org.apache.jmeter.threads.ListenerNotifier which make the code easier to understand and might have a bit less overhead. One important note: this patch uses the Buffer from Jakarta Commons Collections. I think that in this case there is a

[PATCH] NullPointerException in ResultCollector

2003-03-08 Thread Jeremy Arnold
before attempting to write to it. Jeremy Arnold [EMAIL PROTECTED] http://xirr.com/~jeremy_a Index: jakarta-jmeter/src/core/org/apache/jmeter/reporters/ResultCollector.java === RCS file: /home/cvspublic/jakarta-jmeter/src/core/org/apache

[PATCH] Removal of extra SampleResult fields

2003-03-05 Thread Jeremy Arnold
. As always, let me know if you have any questions. [Hopefully this is the right way to do a patch over multiple files -- let me know if I need to do something differently in the future.] Jeremy Jeremy Arnold [EMAIL PROTECTED] http://xirr.com/~jeremy_a Index: jakarta-jmeter/src/core/org

Java Sampler

2003-03-05 Thread Jeremy Arnold
. Then in the endRun event they could call teardownTest. I don't like this solution as much, although maybe it would be helpful for things other than Samplers. Other ideas? I'm happy to do the code, but I need a bit of guidance on the right way to implement it. Jeremy Jeremy Arnold [EMAIL PROTECTED] http

Re: Extra fields in SampleResult

2003-02-25 Thread Jeremy Arnold
Hello, My mail server seems to be bouncing everything that I receive...so I'm stuck getting responses from the archive right now. Responses below. Not sure what you mean by get rid of. If you mean prevent from being written to file, that's probably fine. The mark field is used, however

[PATCH] Throughput value not visible in Graph Visualizer

2003-02-06 Thread Jeremy Arnold
Hello, The Throughput value in the Graph Visualizer (the numbers shown beneath the graph) isn't always visible. The label shows up, but the value does not. This probably depends on factors like screen resolution, and also depends on the size of the JMeter window. But the layout should be

[PATCH] GraphModel calculates deviation incorrectly

2003-02-05 Thread Jeremy Arnold
Hello, I've evaluated using JMeter a couple of times in the past, but haven't actually used it for any real work until now. I've encountered (and fixed) a couple of bugs. Here's the first one -- I'll try to get the others cleaned up and posted in the next few days. I haven't contributed to