Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/#review53782 --- Ship it! Another reason to get rid of prefixes indeed. -

Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/#review53784 --- Ship it! Very nice. src/plugin/kpluginloader.h

Re: Review Request 116980: Update the kded5 man page

2014-03-23 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/#review53796 --- docs/kded5/man-kded5.8.docbook

Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/ --- (Updated March 23, 2014, 12:20 p.m.) Status -- This change has been

Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/#review53802 --- This review has been submitted with commit

Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/#review53800 --- This review has been submitted with commit

Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/#review53801 --- This review has been submitted with commit

Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/#review53805 --- This review has been submitted with commit

Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/#review53803 --- This review has been submitted with commit

Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/#review53804 --- This review has been submitted with commit

Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/ --- (Updated March 23, 2014, 12:23 p.m.) Status -- This change has been

Re: Review Request 116980: Update the kded5 man page

2014-03-23 Thread Alex Merry
On March 23, 2014, 12:15 p.m., Burkhard Lück wrote: docs/kded5/man-kded5.8.docbook, line 9 https://git.reviewboard.kde.org/r/116980/diff/1/?file=256194#file256194line9 All other docbook man pages in frameworks have kde; User's Manual here, why this change? To reflect the

Re: Review Request 116980: Update the kded5 man page

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 23, 2014, 1:02 p.m.) Review request for KDE Frameworks.

Review Request 116991: kded: Use a consistent configuration file name

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/ --- Review request for KDE Frameworks and David Faure. Repository: kded

Re: Review Request 116980: Update the kded5 man page

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 23, 2014, 1:37 p.m.) Review request for KDE Frameworks.

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-23 Thread Alex Merry
On March 22, 2014, 10:21 p.m., Nicolás Alvarez wrote: I can't test this because the kservice framework (dep of kinit) doesn't compile on Windows. Yeah... I was operating on the basis of this is probably less broken than before. kwrapper_win.cpp also has some defunct stuff in it, I guess

Re: Review Request 116934: Use KPluginLoader to find kioslaves

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/ --- (Updated March 23, 2014, 1:51 p.m.) Review request for KDE Frameworks

Re: Review Request 116980: Update the kded5 man page

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 23, 2014, 1:55 p.m.) Review request for Documentation and

Re: Review Request 116934: Use KPluginLoader to find kioslaves

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/#review53811 --- Ship it! Ship It! - David Faure On March 23, 2014, 1:51

Re: Review Request 116934: Use KPluginLoader to find kioslaves

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/ --- (Updated March 23, 2014, 2:11 p.m.) Status -- This change has been

Re: Review Request 116934: Use KPluginLoader to find kioslaves

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/#review53812 --- This review has been submitted with commit

Review Request 116993: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116993/ --- Review request for KDE Frameworks. Repository: kcmutils Description

Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/#review53813 --- Ship it! Ship It! - David Faure On March 21, 2014, 3:47

Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository:

Re: Review Request 116991: kded: Use a consistent configuration file name

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/#review53814 --- Ship it! src/kded.cpp

Re: Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/#review53815 --- Ship it! Ship It! - Christoph Cullmann On March 23, 2014,

Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- (Updated March 23, 2014, 2:46 p.m.) Status -- This change has been

Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/#review53816 --- This review has been submitted with commit

Re: Review Request 116991: kded: Use a consistent configuration file name

2014-03-23 Thread Alex Merry
On March 23, 2014, 2:32 p.m., David Faure wrote: src/kded.cpp, line 778 https://git.reviewboard.kde.org/r/116991/diff/1/?file=256350#file256350line778 To be honest I don't like this very much, the variable bCheckSycoca suddenly changes meaning, from being the default value to

Re: Review Request 116991: kded: Use a consistent configuration file name

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/#review53817 --- This review has been submitted with commit

Re: Review Request 116991: kded: Use a consistent configuration file name

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/ --- (Updated March 23, 2014, 2:50 p.m.) Status -- This change has been

Review Request 116995: Rename the kconfig_compiler_kf5 target to kconfig_compiler

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116995/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/ --- (Updated March 23, 2014, 2:53 p.m.) Status -- This change has been

Re: Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/#review53819 --- This review has been submitted with commit

Re: LXR

2014-03-23 Thread Alex Merry
On 20/03/14 08:13, David Faure wrote: On Thursday 20 March 2014 00:28:44 Alex Merry wrote: LXR says the only users are a couple of projects that haven't even made it onto projects.kde.org. Talking about LXR... I just finished setting up http://lxrnew.kde.org/ident Can you use it for your

Review Request 116997: Cleanup KDE 4 references in various comments and dox

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 116999: kparts: Remove/resolve old porting comments and TODOs

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116999/ --- Review request for KDE Frameworks. Repository: kparts Description

Review Request 117000: Rename kmimetypefactory.h to kmimetypefactory_p.h

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117000/ --- Review request for KDE Frameworks. Repository: kservice Description

Re: LXR

2014-03-23 Thread Alex Merry
On 23/03/14 14:55, Alex Merry wrote: On 20/03/14 08:13, David Faure wrote: On Thursday 20 March 2014 00:28:44 Alex Merry wrote: LXR says the only users are a couple of projects that haven't even made it onto projects.kde.org. Talking about LXR... I just finished setting up

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-23 Thread Alexander Richardson
On March 22, 2014, 11:21 p.m., Nicolás Alvarez wrote: I can't test this because the kservice framework (dep of kinit) doesn't compile on Windows. Alex Merry wrote: Yeah... I was operating on the basis of this is probably less broken than before. kwrapper_win.cpp also has some

Review Request 117003: Remove kde3 compatibility code for DocPath in desktop files

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117003/ --- Review request for KDE Frameworks. Repository: kconfig Description

Review Request 117004: Remove out-of-date design docs

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117004/ --- Review request for KDE Frameworks and Christoph Feck. Repository:

Review Request 117005: Remove KDE3 KParts compatibility code

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117005/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Review Request 117006: Remove kde3 compatibility code and comments

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117006/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Cleanup tasks

2014-03-23 Thread Alex Merry
http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation/KDE4_References lists a bunch of kde4 references that should be cleaned up. Any row that contains things that aren't review requests is up for grabs (including the ones that say in progress). Just put your email address in the

Re: Review Request 117005: Remove KDE3 KParts compatibility code

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117005/#review53829 --- Ship it! Ship It! - David Faure On March 23, 2014, 6:19

Re: Review Request 117006: Remove kde3 compatibility code and comments

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117006/#review53830 --- Ship it! Ship It! - David Faure On March 23, 2014, 6:25

Re: Review Request 116927: Fix kdeinit module lookup

2014-03-23 Thread Hrvoje Senjan
On March 21, 2014, 4:10 p.m., Hrvoje Senjan wrote: this seems to broke kded modules loading here: Cannot load library /usr/lib64/libkdeinit5_kio_file: (/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No such file or directory) Hrvoje Senjan wrote: err,

Re: Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/#review53833 --- Ship it! Ship It! - David Faure On March 21, 2014, 9:58

Re: LXR

2014-03-23 Thread David Faure
On Sunday 23 March 2014 17:33:46 Alex Merry wrote: On 23/03/14 14:55, Alex Merry wrote: On 20/03/14 08:13, David Faure wrote: On Thursday 20 March 2014 00:28:44 Alex Merry wrote: LXR says the only users are a couple of projects that haven't even made it onto projects.kde.org.

Re: Review Request 116936: Use QLibrary instead of KLibrary

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116936/#review53834 --- Ship it! src/html/kopenssl.cpp

Re: Review Request 116937: Use QLibrary instead of KLibrary in KOpenSSL

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116937/#review53835 --- Ship it! Ship It! - David Faure On March 20, 2014, 8:50

Re: Review Request 116930: Fix device not open warning messages at build time

2014-03-23 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116930/ --- (Updated March 23, 2014, 8:12 p.m.) Review request for KDE Frameworks

Re: Review Request 116958: Update comment referencing fake MIME types

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116958/#review53839 --- Hmm clearly the whole thing can be removed if there are no

Re: Review Request 116962: Clean up KDE4 references in kconfig

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116962/#review53841 --- Ship it! - David Faure On March 21, 2014, 6:15 p.m., Alex

Re: Review Request 117000: Rename kmimetypefactory.h to kmimetypefactory_p.h

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117000/#review53850 --- Ship it! Ship It! - David Faure On March 23, 2014, 4:45

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-23 Thread Matthew Dawson
On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: While I'm fine with the idea behind this optimization, I worry that this implementation could create situations were a configuration change is not picked up by the system. For instance, what happens if the user doesn't immediately

Re: Review Request 116967: Fix doc in KUrlPixmapProvider

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116967/#review53854 --- Ship it! Ship It! - David Faure On March 21, 2014, 10:20

Re: Review Request 116959: Remove KDE 4 references from kcmutils

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53855 --- Ship it! with one fix first src/kcmultidialog.cpp

Re: Review Request 116968: Fix doc in KToolBarLabelAction

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116968/#review53856 --- Ship it! Ship It! - David Faure On March 21, 2014, 10:27

Re: Review Request 116969: Remove private reset() and move the implementation to the public reset() in KHistoryComboBox

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/#review53857 --- I don't really get the point of this change? (it's mostly a

Re: Review Request 116970: Remove wish in KComboBox

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116970/#review53858 --- Ship it! Ship It! - David Faure On March 21, 2014, 11:06

Re: Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/#review53859 --- Ship it! Ship It! - David Faure On March 21, 2014, 11:16

Re: Review Request 116993: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116993/#review53860 --- Ship it! Ship It! - David Faure On March 23, 2014, 2:18

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-23 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/#review53862 --- Ship it! Everything seems fine for this to go in as is. The

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/ --- (Updated March 23, 2014, 10 p.m.) Status -- This change has been

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-23 Thread David Faure
On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: While I'm fine with the idea behind this optimization, I worry that this implementation could create situations were a configuration change is not picked up by the system. For instance, what happens if the user doesn't immediately

Re: Review Request 116995: Rename the kconfig_compiler_kf5 target to kconfig_compiler

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116995/#review53869 --- Ship it! Ship It! - David Faure On March 23, 2014, 2:52

Re: Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/#review53871 --- This review has been submitted with commit

Re: Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox

2014-03-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/ --- (Updated March 23, 2014, 11 p.m.) Status -- This change has been

Re: Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/#review53873 --- This review has been submitted with commit

Re: Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding

2014-03-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/ --- (Updated March 23, 2014, 11:04 p.m.) Status -- This change has been

Re: Review Request 116968: Fix doc in KToolBarLabelAction

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116968/#review53875 --- This review has been submitted with commit

Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-23 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/ --- Review request for KDE Frameworks and David Faure. Repository: kconfig

Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/#review53876 --- Ah, the old usrReadConfig still exists, OK, that solves my

Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- Review request for KDE Frameworks and kdewin. Repository: kdoctools

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53877 --- src/colors/kcolorutils.cpp

Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Alexander Richardson
On March 24, 2014, 12:51 a.m., Aleix Pol Gonzalez wrote: So what should happen so that we didn't need the workaround? QStandardPaths would have to look in %KDEROOT%\share and not just C:\ProgramData. - Alexander --- This is an

Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/#review53880 --- Please add kdewin too. Given the outcome of the other RR, I'm

Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Aleix Pol Gonzalez
On March 23, 2014, 11:51 p.m., Aleix Pol Gonzalez wrote: So what should happen so that we didn't need the workaround? Alexander Richardson wrote: QStandardPaths would have to look in %KDEROOT%\share and not just C:\ProgramData. So why aren't we adding this in Qt? Or even, why are

Re: Review Request 117004: Remove out-of-date design docs

2014-03-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117004/#review53884 --- Ship it! Ship It! - Christoph Feck On March 23, 2014,

Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

2014-03-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/ --- Review request for KDE Frameworks and kdewin. Repository: kjsembed

Build failed in Jenkins: krunner_master_qt5 #37

2014-03-23 Thread KDE CI System
See http://build.kde.org/job/krunner_master_qt5/37/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in

Jenkins build became unstable: kde4support_master_qt5 #85

2014-03-23 Thread KDE CI System
See http://build.kde.org/job/kde4support_master_qt5/85/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KIO / KWebView and PrivateBrowsing (Cookies)

2014-03-23 Thread Alexander Potashev
Hi Dawit, Are there any news on this? 2013-04-22 3:51 GMT+04:00 Dawit A ada...@kde.org: Started working on this to try and get it in for 4.11. Hopefully my solution will work out as intended and discussed in this thread. On Sat, Apr 13, 2013 at 5:10 PM, Àlex Fiestas afies...@kde.org wrote:

KF5: Parsing times with timezone abbreviations

2014-03-23 Thread Kevin Kofler
Hi, what is the recommended way to parse times with short timezone abbreviations, such as 16:00 CET, in Qt 5 / KF5 land? (I am asking because this is the format the BBC is using for weather observation times in their RSS files.) In kdelibs 4, this should do what we want: dateTime =

Re: KDM + ConsoleKit + Logind

2014-03-23 Thread Kevin Kofler
Sorry for digging up this 1-month-old thread, but: Martin Briza wrote: We're building KDM with the support (no real reason to put it away except getting rid of dependency on the library) but anyway, everything should run just fine if you don't really use any of the CK functionality... Not

Re: ksycoca4

2014-03-23 Thread mk-lists
On 22 Mar 2014, at 23:41 , Ian Wadham iandw...@gmail.com wrote: That is a normal message. It just tells you where KDE libs is looking for the SyCoCa. OK. Good to know. I see you are running your tutorial2 as if it was a UNIX or Linux app, i.e. by direct execution of the executable file which

Re: Missing application icons of many KDE apps on MacPorts/OSX

2014-03-23 Thread mk-lists
Hi Thomas, I indeed can’t find the needed statement in any CMakeLists.txt file in KDevelop’s sources: — $ find . -name CMakeLists.txt -exec grep -l KDE4_ADD_APP_ICON {} \; $ — I haven’t crosschecked with other apps from my long list, but I guess that explains it. Thanks again, Marko Visit

Re: Missing application icons of many KDE apps on MacPorts/OSX

2014-03-23 Thread mk-lists
And now I see that there is also this line in KMM’s cmake file: QT4_ADD_DBUS_ADAPTOR(kmymoney_SRCS org.kde.kmymoney.xml kmymoney.h KMyMoneyApp) which is most certainly also important for something… ;-) How would that have to be adapted to e.g. KDevelop? Visit

Re: Missing application icons of many KDE apps on MacPorts/OSX

2014-03-23 Thread mk-lists
On 23 Mar 2014, at 08:56 , mk-li...@email.de wrote: I haven’t crosschecked with other apps from my long list, but I guess that explains it. I have found that the ports with an app icon on OSX actually do have an ICNS file installed: — $ find /Applications/MacPorts/KDE4 -name *.icns

Re: Missing application icons of many KDE apps on MacPorts/OSX

2014-03-23 Thread mk-lists
On 23 Mar 2014, at 09:42 , mk-li...@email.de wrote: KDevelop is the only one missing the 128x128 icon, which seems to be the reason for displaying the generic icon in dock if the app is not started. Simply giving KDevelop the missing icon is not yet enough to make it work in the dock and

Re: Launch Bug Report Wizard failing on Apple OS X (was ksycoca4)

2014-03-23 Thread Ian Wadham
On 23/03/2014, at 6:38 PM, mk-li...@email.de wrote: On 22 Mar 2014, at 23:41 , Ian Wadham iandw...@gmail.com wrote: That is a normal message. It just tells you where KDE libs is looking for the SyCoCa. OK. Good to know. I see you are running your tutorial2 as if it was a UNIX or Linux

Re: Launch Bug Report Wizard failing on Apple OS X (was ksycoca4)

2014-03-23 Thread Thomas Lübking
On Sonntag, 23. März 2014 11:55:02 CEST, Ian Wadham wrote: In all three cases, an icon appears in the Dock (task bar equivalent) and vanishes too soon to see what it is. Additionally, I am finding messages on the Apple OS X Console log (see attached). Can a KDE guy tell Marko and me what is

Re: Missing application icons of many KDE apps on MacPorts/OSX

2014-03-23 Thread mk-lists
On 23 Mar 2014, at 12:09 , Thomas Lübking thomas.luebk...@gmail.com wrote: kdevelop/app/CMakeLists.txt *does* have kde4_add_app_icon(kdevelop_bin_SRCS ${CMAKE_CURRENT_SOURCE_DIR}/../pics/hi*-app-kdevelop.png”) Yep, thanks for pointing that out. I forgot option ‘-i’ in my find command call. :-(

Re: Missing application icons of many KDE apps on MacPorts/OSX

2014-03-23 Thread mk-lists
On 23 Mar 2014, at 12:09 , Thomas Lübking thomas.luebk...@gmail.com wrote: kdevelop/app/CMakeLists.txt *does* have kde4_add_app_icon(kdevelop_bin_SRCS ${CMAKE_CURRENT_SOURCE_DIR}/../pics/hi*-app-kdevelop.png”) Yep, thanks for pointing that out. I forgot option ‘-i’ in my find command call. :-(

Re: Launch Bug Report Wizard failing on Apple OS X (was ksycoca4)

2014-03-23 Thread mk-lists
On 23 Mar 2014, at 12:19 , Thomas Lübking thomas.luebk...@gmail.com wrote: kioclient exec 'http://www.kde.org/' $ kioclient exec 'http://www.kde.org/' kioclient(2672)/kdecore (KSycoca) KSycocaPrivate::openDatabase: Trying to open ksycoca from /private/var/tmp/kdecache-marko/ksycoca4

Re: Launch Bug Report Wizard failing on Apple OS X (was ksycoca4)

2014-03-23 Thread Thomas Lübking
On Sonntag, 23. März 2014 13:08:50 CEST, mk-li...@email.de wrote: Does this open kde.org in any browser? No, it didn’t open a browser. Do you get a dialog for kcmshell4 componentchooser $ kcmshell4 componentchooser -bash: kcmshell4: command not found Well, I seem to have to install some

Re: Launch Bug Report Wizard failing on Apple OS X (was ksycoca4)

2014-03-23 Thread mk-lists
Thanks Thomas, for your valuable hints! :-) On 23 Mar 2014, at 12:19 , Thomas Lübking thomas.luebk...@gmail.com wrote: Do you get a dialog for kcmshell4 componentchooser OK, I located the executable eventually: — $ /Applications/MacPorts/KDE4/kcmshell4.app/Contents/MacOS/kcmshell4

Re: Missing application icons of many KDE apps on MacPorts/OSX

2014-03-23 Thread mk-lists
I have put the code including some PNGs for testing on https://bitbucket.org/mkae/kde-tests/src/7ca075e847a2c0ba1d5e7a97f1a5a60a298fe0f9/AboutBoxCrash/?at=default This app does neither create the ICNS nor sets up the required Resources folder in Contents: — ./tutorial2.app

  1   2   >