Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/#review61256 --- src/kwindowinfo_x11.cpp

Re: Review Request 118960: Add a test to print out KLauncher's autostart files

2014-06-30 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118960/#review61258 --- ping? It's just a test. - Vishesh Handa On June 26, 2014,

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Ivan Čukić
On June 30, 2014, 9:01 a.m., Martin Gräßlin wrote: src/kwindowinfo_x11.cpp, line 301 https://git.reviewboard.kde.org/r/119008/diff/2/?file=285388#file285388line301 are you sure it's Latin1? Normally string properties are utf8. Well, since those are UUIDs, it does not make a

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/#review61260 --- Ship it! Ship It! - Martin Gräßlin On June 30, 2014,

KIconLoader problem with KFontInst

2014-06-30 Thread Marco Martin
Hi all, there is a weird problem with the kf5 version of the KFontInst kcm module. if you load it from SystemSettings, then going back all icons of systemsettings categories disappear. since kfontinst has some own icons, I see it's doing this in KCmFontInst.cpp:

Re: KIconLoader problem with KFontInst

2014-06-30 Thread Marco Martin
On Monday 30 June 2014, Martin Klapetek wrote: Maybe the KFontInst shouldn't use KIconLoader::global() and have its own instance? I think KFontInst should just get away with those personalized icons.. but still seems something is wrong in kiconloader anyways.. -- Marco Martin

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/ --- (Updated June 30, 2014, 9:57 a.m.) Status -- This change has been

Re: KIconLoader problem with KFontInst

2014-06-30 Thread Martin Klapetek
...or have the icons installed properly (hicolor?) and remove the custom addAppDir call altogether? -- Sent from my Nexus 7 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Thomas Lübking
On June 30, 2014, 9:01 a.m., Martin Gräßlin wrote: src/kwindowinfo_x11.cpp, line 301 https://git.reviewboard.kde.org/r/119008/diff/2/?file=285388#file285388line301 are you sure it's Latin1? Normally string properties are utf8. Ivan Čukić wrote: Well, since those are UUIDs,

Re: qt5 polkit-qt-1 and kdesrc-build

2014-06-30 Thread Vishesh Handa
On Sat, Jun 28, 2014 at 5:09 PM, Sune Vuorela nos...@vuorela.dk wrote: On 2014-06-27, David Faure fa...@kde.org wrote: This question is still open. We're releasing kauth as part of KF5 but polkit-qt-1 isn't getting released. Is there any maintainer for polkit-qt-1? For that matter,

Re: KIconLoader problem with KFontInst

2014-06-30 Thread Harald Sitter
On Mon, Jun 30, 2014 at 12:02 PM, Martin Klapetek martin.klape...@gmail.com wrote: ...or have the icons installed properly (hicolor?) and remove the custom addAppDir call altogether? Not that I grasp the issue, but if it is a general problem that could have impact on every application using

Re: KAuth and KF5

2014-06-30 Thread Milian Wolff
On Monday 30 June 2014 00:05:10 šumski wrote: On Thursday 26 of June 2014 12:14:49 Milian Wolff wrote: Hey, did you run it through valgrind? Here's what valgrind says: Sounds like a bug in Qt to me, I have to say. Looking at the code, QDBusConnectionPrivate::objectDestroyed looks

Re: Review Request 118960: Add a test to print out KLauncher's autostart files

2014-06-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118960/#review61278 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 26, 2014,

Re: Review Request 118960: Add a test to print out KLauncher's autostart files

2014-06-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118960/#review61279 --- This review has been submitted with commit

Re: Review Request 118960: Add a test to print out KLauncher's autostart files

2014-06-30 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118960/ --- (Updated June 30, 2014, 12:45 p.m.) Status -- This change has been

Re: Review Request 118985: KSharedConfig: move mainConfig and wasTestEnabled to the thread storage.

2014-06-30 Thread David Faure
On June 29, 2014, 3:31 a.m., Matthew Dawson wrote: I'm not sure about moving the warning about immutable files to only happen on the main thread, as it is possible that an application may use it KSharedConfig on an alternate thread only. As this is mainly an optimization, I think

Re: Review Request 118264: Switch to PolkitQt5-1

2014-06-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118264/#review61286 --- Hi, I tried the patch, it's not building. [10/64] Building

tagging date

2014-06-30 Thread David Faure
On Tuesday 24 June 2014 14:21:53 Jonathan Riddell wrote: Sorry for late cancellation but seems I can't chair and I can't find a replacement. Please prepare for final tagging this week, any last binary incompatibility must be in by the weekend. dfaure will tag for final release on Monday.

Re: Review Request 119005: Make desktoptojson include all values, not just the translated ones

2014-06-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119005/#review61287 --- This seems wrong to me. QSettings is not a desktop file

Re: Review Request 118264: Switch to PolkitQt5-1

2014-06-30 Thread Hrvoje Senjan
On June 30, 2014, 4:23 p.m., Aleix Pol Gonzalez wrote: Hi, I tried the patch, it's not building. [10/64] Building CXX object src/CMakeFiles/kauth_backend_plugin.dir/backends/polkit-1/Polkit1Backend.cpp.o FAILED: /usr/bin/c++ -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB

Review Request 119037: Fix KAuth backend loading

2014-06-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119037/ --- Review request for KDE Frameworks and Vishesh Handa. Repository: kauth

Re: Review Request 119005: Make desktoptojson include all values, not just the translated ones

2014-06-30 Thread Alexander Richardson
On June 30, 2014, 4:31 p.m., David Faure wrote: This seems wrong to me. QSettings is not a desktop file parser. It will get escaping wrong, compared to what the desktop entry spec says. Isn't the long term solution to write .json files directly anyway? Okay, after reading the desktop

Review Request 119038: Allow loading KCMs from QT_PLUGIN_PATH subdirectories

2014-06-30 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119038/ --- Review request for KDE Frameworks. Repository: kcmutils Description

Re: Review Request 118264: Switch to PolkitQt5-1

2014-06-30 Thread Aleix Pol Gonzalez
On May 28, 2014, 12:56 p.m., Aurélien Gâteau wrote: Building with polkit-qt-1 master (bac771e69887c9253f2b0973f6310810db0061f8) fails with this error: [ 55%] Building CXX object autotests/CMakeFiles/KAuthHelperTest.dir/HelperTest.cpp.o In file included from

Re: KAuth and KF5

2014-06-30 Thread Thiago Macieira
Em seg 30 jun 2014, às 14:14:10, Milian Wolff escreveu: On Monday 30 June 2014 00:05:10 šumski wrote: On Thursday 26 of June 2014 12:14:49 Milian Wolff wrote: Hey, did you run it through valgrind? Here's what valgrind says: Sounds like a bug in Qt to me, I have to say. Looking

Re: Review Request 119005: Make desktoptojson include all values, not just the translated ones

2014-06-30 Thread Alexander Richardson
On June 30, 2014, 4:31 p.m., David Faure wrote: This seems wrong to me. QSettings is not a desktop file parser. It will get escaping wrong, compared to what the desktop entry spec says. Isn't the long term solution to write .json files directly anyway? Alexander Richardson wrote:

Re: Review Request 118264: Switch to PolkitQt5-1

2014-06-30 Thread Hrvoje Senjan
On May 28, 2014, 2:56 p.m., Aurélien Gâteau wrote: Building with polkit-qt-1 master (bac771e69887c9253f2b0973f6310810db0061f8) fails with this error: [ 55%] Building CXX object autotests/CMakeFiles/KAuthHelperTest.dir/HelperTest.cpp.o In file included from

Re: Review Request 118985: KSharedConfig: move mainConfig and wasTestEnabled to the thread storage.

2014-06-30 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118985/#review61307 --- Ship it! Alright, LGTM. Just one final comment on the final

Review Request 119043: pollkit-qt-1 buildsystem adjustements

2014-06-30 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and

Re: Review Request 118264: Switch to PolkitQt5-1

2014-06-30 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118264/ --- (Updated June 30, 2014, 8:20 p.m.) Review request for KDE Frameworks and

Re: Review Request 118264: Switch to PolkitQt5-1

2014-06-30 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118264/ --- (Updated June 30, 2014, 8:20 p.m.) Review request for KDE Frameworks and

Re: Review Request 118264: Switch to PolkitQt5-1

2014-06-30 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118264/ --- (Updated June 30, 2014, 8:31 p.m.) Review request for KDE Frameworks and

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

2014-06-30 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- (Updated June 30, 2014, 10:28 p.m.) Review request for KDE Frameworks,

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

2014-06-30 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61326 --- agent/CMakeLists.txt

Re: KAuth and KF5

2014-06-30 Thread šumski
On Monday 30 of June 2014 17:31:39 Thiago Macieira wrote: Em seg 30 jun 2014, às 14:14:10, Milian Wolff escreveu: On Monday 30 June 2014 00:05:10 šumski wrote: On Thursday 26 of June 2014 12:14:49 Milian Wolff wrote: Hey, did you run it through valgrind? Here's what

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

2014-06-30 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- (Updated June 30, 2014, 10:51 p.m.) Review request for KDE Frameworks,

Translations are broken in KF5 apps

2014-06-30 Thread Alexander Potashev
Hi KDE Frameworks devs, I tried to run a couple of KF5-based KDE applications, namely Kate and Konsole (Russian and Ukrainian) and localization there looks very poor, even though from the translators' side the localization packages are complete or almost complete. One of the bugs that has been

Re: Translations are broken in KF5 apps

2014-06-30 Thread Chusslove Illich
[: Alexander Potashev :] What a non-English user can see is, many menu items still appear in English while they have translations in *.mo files installed [...] One thing I know is still not being translated, because I didn't implement it yet, is menu names coming from *.rc files. This also

Re: Translations are broken in KF5 apps

2014-06-30 Thread Albert Astals Cid
El Dilluns, 30 de juny de 2014, a les 23:18:18, Chusslove Illich va escriure: [: Alexander Potashev :] What a non-English user can see is, many menu items still appear in English while they have translations in *.mo files installed [...] One thing I know is still not being translated,

Re: Translations are broken in KF5 apps

2014-06-30 Thread Chusslove Illich
[: Chusslove Illich :] To note additionally, packaging of translations for Frameworks is still not resolved (to my knowledge?), so translations are actually not released right now. [: Albert Astals Cid :] I see the translations in the tarballs. Why do you say they are not released? My

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

2014-06-30 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- (Updated June 30, 2014, 11:53 p.m.) Review request for KDE Frameworks,

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

2014-06-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61334 --- CMakeLists.txt

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

2014-06-30 Thread Aleix Pol Gonzalez
On June 30, 2014, 8:37 p.m., Christophe Giboudeaux wrote: agent/CMakeLists.txt, line 10 https://git.reviewboard.kde.org/r/119043/diff/2/?file=285757#file285757line10 LINK_PUBLIC On June 30, 2014, 8:37 p.m., Christophe Giboudeaux wrote: core/CMakeLists.txt, line 13

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

2014-06-30 Thread Christophe Giboudeaux
On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: CMakeLists.txt, line 6 https://git.reviewboard.kde.org/r/119043/diff/4/?file=285775#file285775line6 Isn't it acceptable to depend on ECM here? not a wise choice. the master branch allows building both the Qt4 Qt5 variant

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

2014-06-30 Thread Aleix Pol Gonzalez
On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: PolkitQt-1Config.cmake.in, line 24 https://git.reviewboard.kde.org/r/119043/diff/4/?file=285776#file285776line24 Passing the include dir is not needed anymore, given that those will be pulled by the targets. I

Fwd: default wallpapers

2014-06-30 Thread Marco Martin
Forwarding here as I was reminded that is more a kde-core-devel topic. -- Forwarded Message -- Subject: default wallpapers Date: Monday 30 June 2014, 19:09:00 From: Marco Martin notm...@gmail.com To: plasma-de...@kde.org Hi all, besides the breeze wallpaper, there will be 3

Re: Review Request 106221: Mutex cleanup in KSharedDataCache

2014-06-30 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/106221/ --- (Updated July 1, 2014, 3:02 a.m.) Status -- This change has been

Re: Review Request 106174: Move checks for locking primitives in KSharedDataCache to CMake

2014-06-30 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/106174/ --- (Updated July 1, 2014, 3:02 a.m.) Status -- This change has been

Re: Review Request 106237: Add flock()/lockf()-based locking mechanizm to KSharedDataCache

2014-06-30 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/106237/ --- (Updated July 1, 2014, 3:03 a.m.) Status -- This change has been

Re: [ANNOUNCE] GammaRay 2.1.0

2014-06-30 Thread Tomaz Canabrava
On Fri, Jun 27, 2014 at 6:08 PM, Allen Winter win...@kde.org wrote: Announcing GammaRay 2.1.0 Now with the much requested support for QtQuick 2! Highlights of this Release: === * Aggregated property view combining static, dynamic and non-QObject property views. *

Re: Should KDED4 run all the time?

2014-06-30 Thread Sune Vuorela
On 2014-06-28, Ian Wadham iandw...@gmail.com wrote: Hi guys, When fixing some bugs in the KCrash-DrKonqi sequence on Apple OS X, I have come to a point where Dr Konqi attempts to call kded4, using DBus, and issues a message Failed to communicate with kded. Make sure it is running. In the

Re: Should KDED4 run all the time?

2014-06-30 Thread Ian Wadham
Hi Sune, Thanks for replying, Sune. On 30/06/2014, at 11:37 PM, Sune Vuorela wrote: On 2014-06-28, Ian Wadham iandw...@gmail.com wrote: When fixing some bugs in the KCrash-DrKonqi sequence on Apple OS X, I have come to a point where Dr Konqi attempts to call kded4, using DBus, and issues a