Re: Review Request 126724: Expose callingUser in HelperSupport if available

any issue (I strongly doubt it), it definitely makes sense to me. - Dario Freddi On Jan. 12, 2016, 9:36 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

Hi René, just thought I'd clarify some things as the creator/former maintainer of all this - which might also justify some of Martin's positions. The idea behind KIdleTime is that the framework shall be a lightweight, non-critical framework for those applications which want to know about the

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

Given I already stepped in... 2015-11-19 10:36 GMT+01:00 René J.V. : > > Now it's just bad code, eh? > > Just for the record: no one but Apple really knows what IOKit considers being > idle but it clearly involves absence of user input events. That's "user > idle", not

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-19 17:17 GMT+01:00 René J.V. <rjvber...@gmail.com>: > On Thursday November 19 2015 15:21:10 Dario Freddi wrote: > >> * KIdleTime strives to be as lightweight as possible. This is something >>which came from the old approach used in KDE3/4 powermanagement which w

Re: Review Request 113360: PolkitActionsKCM: Use a simple pointer for m_actionWidget.

- it's probably clearer if we put new PolkitKde::ActionWidget(this) as an initializer for m_actionWidget in the constructor. - Dario Freddi On Dec. 8, 2013, 10:45 a.m., Ivan Shapovalov wrote: --- This is an automatically generated e-mail

Re: Review Request 113851: Unbreak kauth-policy-gen

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113851/#review43705 --- Ship it! Ship It! - Dario Freddi On Nov. 15, 2013, 8:38

Re: Review Request 113851: Unbreak kauth-policy-gen

://git.reviewboard.kde.org/r/113851/ --- (Updated Nov. 15, 2013, 8:38 a.m.) Review request for KDE Frameworks and Dario Freddi. Repository: kdelibs Description --- This is a two-commit patch, it fixes a build failure

Re: [Kde-hardware-devel] Review Request 111707: Export the value of lidAction (in handleButtonEvents action)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111707/#review36530 --- Ship it! Ship It! - Dario Freddi On July 26, 2013, 2:58

Re: Bug 242648 assigned to unresponsive maintainer

) is assigned to Dario Freddi, but he has not commented since about 3 years, please assign it it somebody else or to Not Assigned. It has 160+ duplicates, 300+ comments, and 219 users in CC list. Regards d...@kde.org Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: Bug 242648 assigned to unresponsive maintainer

2013/6/10 Mustafa Muhammad mustafaa.alhamda...@gmail.com that bug is a well known nightmare which is/was pretty much unaddressable, as it depends on some lacking upstream features. Many other people had a look at it without success, and the fact I am the assignee doesn't prevent anyone from

Re: [Kde-hardware-devel] Backlight control support

Yo, 2013/5/25 Kai Uwe Broulik k...@privat.broulik.de I'm currently working on revamping the battery monitor and found that the algorithm that is supposed to hide brightness slider in case backlight controls are not supported in 4.11 doesn't work and always returns true leading the a sort of

Re: [Kde-hardware-devel] Review Request 110026: Stop searching for timeout once identifier found

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110026/#review32698 --- Ship it! Ship It! - Dario Freddi On April 15, 2013, 3:19

Re: [Kde-hardware-devel] Review Request 110384: Add isPowerSupply support to PowerDevil

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110384/#review32449 --- Ship it! Ship It! - Dario Freddi On May 13, 2013, 10:57

Re: [Kde-hardware-devel] Review Request 110135: Adjust to new suspend session handling

/kdelibs-apidocs/tier1/solid/html/classSolid_1_1PowerManagement_1_1Notifier.html#aad2c04c80d5dcb707a1f9098bc0262bf So we should definitely change this all over workspace (and, at the same time, make sure all applications do the same). - Dario Freddi On April 24, 2013, 11:47 a.m., Hrvoje Senjan

Re: [Kde-hardware-devel] Review Request 110135: Adjust to new suspend session handling

to master after fixing the small issue below. plasma/generic/dataengines/time/timeengine.cpp http://git.reviewboard.kde.org/r/110135/#comment23462 Watch out for whitespaces - Dario Freddi On April 24, 2013, 5:41 p.m., Hrvoje Senjan wrote

Re: [Kde-hardware-devel] Review Request 110135: Adjust Kickoff actions to latest Powerdevil changes

/ --- (Updated April 23, 2013, 5:28 p.m.) Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler. Description --- Suspend/hibernate are now longer are part of org.kde.Solid.PowerManagement interface, so adjusting to new one. This addresses bug 318737. http

Re: [Kde-hardware-devel] Review Request 110135: Adjust to new suspend session handling

an API for this to libsolid. ksmserver/shutdowndlg.cpp http://git.reviewboard.kde.org/r/110135/#comment23444 Same here, the service should be the same as before - Dario Freddi On April 23, 2013, 7:12 p.m., Hrvoje Senjan wrote

Re: Review Request 110102: Change 2 strings from Display to Screen for better consistency.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110102/#review31334 --- Ship it! Ship It! - Dario Freddi On April 20, 2013, 2:24

Re: [Kde-hardware-devel] old GSoC Solid project

same here... I guess it will be a hot topic in the forthcoming sprint 2013/4/5 Àlex Fiestas afies...@kde.org Really sorry for all this... lets try to make it right. Can you point us once again to a branch/repo building with latest master? I will review the code in the following days (I

Re: Review Request 109792: Update 'dim display' algorithm.

trip to the dentist last days. Allow me some hours/days to wash away the pain, and I'll be on this. - Dario Freddi On April 2, 2013, 1:52 p.m., Danny Baumann wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: [Kde-hardware-devel] Review Request 109351: Add hybrid suspend method to libsolid

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109351/#review28803 --- Ship it! Good job. - Dario Freddi On March 8, 2013, 1:25

Re: Review Request 109133: Allow async KAuth Action with helper (and disallow async without helper)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109133/#review28104 --- Ship it! Ship It! - Dario Freddi On Feb. 25, 2013, 11:25

Re: [Kde-hardware-devel] Review Request 109126: Cache whether screen powersaving is inhibited

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109126/#review28139 --- Ship it! Good move. - Dario Freddi On Feb. 24, 2013, 5:40

Re: [Kde-hardware-devel] Review Request 107698: Keep watching service until last inhibition goes

), which guarantees the returned key would be 0 if not existent; or .values().contains(service). I'd choose the second for clarity. - Dario Freddi On Dec. 13, 2012, 12:55 p.m., Oliver Henshaw wrote: --- This is an automatically

Re: [Kde-hardware-devel] Review Request 108407: systemd-login1 support for PowerDevil

the QDBusPendingCallWatcher, as that other patch wouldn't work. - Dario Freddi On Jan. 14, 2013, 2:24 p.m., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108407

Re: Review Request 108418: use system to suspend and hibernate in powerdevil

a look at this as well, but ideally you should probably talk to Lukas about it. - Dario Freddi On Jan. 15, 2013, midnight, Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: [Kde-hardware-devel] Review Request 106795: Avoid race during button-triggered DPMS

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106795/#review25439 --- Ship it! Ship It! - Dario Freddi On Oct. 11, 2012, 1:15

Re: [Kde-hardware-devel] Review Request 108407: systemd-login1 support for PowerDevil

: if () {... - Dario Freddi On Jan. 14, 2013, 12:12 p.m., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108407

Re: [Kde-hardware-devel] Review Request 108407: systemd-login1 support for PowerDevil

http://git.reviewboard.kde.org/r/108407/#comment19473 Watch out! If you are using a QWeakPointer, this check might be bogus. You should check instead if (!m_login1Interface.isNull()) - Dario Freddi On Jan. 14, 2013, 12:52 p.m., Lukáš Tinkl wrote

Re: [Kde-hardware-devel] Review Request 108407: systemd-login1 support for PowerDevil

generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108407/ --- (Updated Jan. 14, 2013, 2:24 p.m.) Review request for Solid and Dario Freddi. Description --- This patch adds support for systemd-login1

Re: [Kde-hardware-devel] Review Request 108407: systemd-login1 support for PowerDevil

which might require further discussion. Holding onto that for the final ship it. - Dario Freddi On Jan. 14, 2013, 2:24 p.m., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: [Kde-hardware-devel] Review Request 108407: systemd-login1 support for PowerDevil

which might require further discussion. Holding onto that for the final ship it. - Dario Freddi On Jan. 14, 2013, 2:24 p.m., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: [Kde-hardware-devel] Review Request 108407: systemd-login1 support for PowerDevil

which might require further discussion. Holding onto that for the final ship it. - Dario Freddi On Jan. 14, 2013, 2:24 p.m., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: [Kde-hardware-devel] Review Request 108416: Add turnOffScreen dbus method

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108416/#review25530 --- Ship it! Ship It! - Dario Freddi On Jan. 14, 2013, 7:50

Re: [Kde-hardware-devel] Review Request 108418: use system to suspend and hibernate in powerdevil

a look at this as well, but ideally you should probably talk to Lukas about it. - Dario Freddi On Jan. 15, 2013, midnight, Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: [Kde-hardware-devel] Planning the sprint, take 2 !

2013/1/2 Alex Fiestas afies...@kde.org On Wednesday 02 January 2013 12:15:36 Dario Freddi wrote: As my schedule is already filling for February, can we come up with a doodle soon to have a defined set of dates? Alex? You don't have to wait for me to create the doodle, if you are in a hurry

Re: [Kde-hardware-devel] Planning the sprint, take 2 !

ok for the dates, but what about the logistics? From what I see the airport has just a couple flights from london/amsterdam - the nearest option appears to be prague, but it's rather far away. Maybe some locals can give out some directions on this? 2012/12/30 Alex Fiestas afies...@kde.org So,

Re: [Kde-hardware-devel] Review Request: Handle unsupported actions quietly

unclear to me why you need this, since you're advertising only the last error occurred. In fact, you're just populating the hash without using it. - Dario Freddi On Nov. 21, 2012, 7:20 p.m., Oliver Henshaw wrote

Re: [Kde-hardware-devel] Review Request: Only add DPMS to the profile if it is supported

solution than having ifdefs in the generator, but for now it will do :) - Dario Freddi On Nov. 28, 2012, 2:14 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: [Kde-hardware-devel] Review Request: Prevent button action from enabling disabled DPMS

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106794/#review21290 --- Ship it! Ship It! - Dario Freddi On Oct. 12, 2012, 5:45

Re: [Kde-hardware-devel] Review Request: Emit battery low/critical notification when starting the session

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107117/#review21140 --- Ship it! Ship It! - Dario Freddi On Oct. 30, 2012, 7:56

Re: [Kde-hardware-devel] Review Request: Emit battery low/critical notification when starting the session

, I'd instead force calling the onBatteryPercentChanged everytime a new battery is added. This also adds a neat side-effect: not only it makes the feature available for multi-batteries, but also whenever a new battery is added to the system. - Dario Freddi On Oct. 29, 2012, 4:13 p.m., Kai Uwe

Re: [Kde-hardware-devel] Review Request: Don't set unwanted DPMS timeouts on inhibition change

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106793/#review21121 --- Ship it! - Dario Freddi On Oct. 12, 2012, 5:45 p.m., Oliver

Re: [Kde-hardware-devel] Review Request: Suggest a sane timeout in kcm when DPMS disabled

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107024/#review20802 --- Ship it! Ship It! - Dario Freddi On Oct. 24, 2012, 4:35

Re: [Kde-hardware-devel] Review Request: Fix bug: generateProfiles generates a config where lidClose event is turn of screen.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106859/#review20350 --- Ship it! Ship It! - Dario Freddi On Oct. 14, 2012, 11:20

Re: [Kde-hardware-devel] Review Request: Hide Battery levels config altogether (instead of disabling it) when there is no battery

if that's the case having the fields simply disabled might make more sense. What do you think? - Dario Freddi On Oct. 10, 2012, 2:36 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: [Kde-hardware-devel] Review Request: Hide Battery levels config altogether (instead of disabling it) when there is no battery

On Oct. 10, 2012, 2:46 p.m., Dario Freddi wrote: Besides the fact that I like the principle of the idea, I am not sure whether the approach of hiding works better than disabling. I am saying this since it's quite common to have people unplugging their battery at times to save some

Re: [Kde-hardware-devel] Review Request: Hide Battery levels config altogether (instead of disabling it) when there is no battery

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106783/#review20139 --- Ship it! Ship It! - Dario Freddi On Oct. 10, 2012, 2:36

Re: [Kde-hardware-devel] Review Request: Hide Battery levels config altogether (instead of disabling it) when there is no battery

On Oct. 10, 2012, 2:46 p.m., Dario Freddi wrote: Besides the fact that I like the principle of the idea, I am not sure whether the approach of hiding works better than disabling. I am saying this since it's quite common to have people unplugging their battery at times to save some

Re: [Kde-hardware-devel] Review Request: Don't prematurely unload suspendsession action

- Dario Freddi On Oct. 2, 2012, 6:11 p.m., Oliver Henshaw wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106692

Re: [Kde-hardware-devel] Review Request: Prevent button action from always enabling dpms

On Oct. 3, 2012, 9:30 a.m., Oliver Henshaw wrote: Actually, I don't think this works. Better to re-disable dpms on return from idle - I think disabling DPMS just wakes the screen. I know I should have tested this on the real desktop, but there was yet another dpms-related issue

Re: [Kde-hardware-devel] Review Request: Make threshold for when the battery is considered full configurable (like you can with crtiical/low)

/powerdevilcore.cpp http://git.reviewboard.kde.org/r/106677/#comment15696 That's the reason why your patch doesn't work :) - Dario Freddi On Oct. 1, 2012, 10:30 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply

Re: [Kde-hardware-devel] Review Request: Fix battery full notification not being emitted and make it watch for ChargeState rather than a charge percentage

previousCharged is false, currentCharged will never be true :) Maybe you meant: } else { m_batteriesCharged[udi] = true; currentCharged = true; } However, please follow the approach I mentioned in the other comment. - Dario Freddi On Oct. 2, 2012, 11:21 a.m

Re: [Kde-hardware-devel] Review Request: Tidy up PowerDevil notifyrc

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106689/#review19761 --- Ship it! Good to go, thanks :) - Dario Freddi On Oct. 2

Re: Notifications-future, a recap

2012/9/21 Aaron J. Seigo ase...@kde.org: if the new can be achieved by extending or building on galago, that would seem to me to be a much better thing. and no, galago is not perfect. it's not even great, but it is passable and widely used and that gives it a lot of value. if it turns out

Re: Notifications-future, a recap

2012/9/21 Mark mark...@gmail.com: On Tue, Sep 18, 2012 at 12:17 AM, Dario Freddi drf54...@gmail.com wrote: (putting back plasma-devel on CC, since the discussion is quite relevant) 2012/9/17 Sune Vuorela nos...@vuorela.dk: I know Sune already had some plans for the notification stack and I

Re: Notifications-future, a recap

2012/9/20 Sune Vuorela nos...@vuorela.dk: On 2012-09-17, Dario Freddi drf54...@gmail.com wrote: It really depends on what you want to achieve. If your goal is just cleaning up the API and implementing the existing standard it might work out, but for sure it won't just cut it for what I

Re: Notifications-future, a recap

(readded frameworks, the topic ping-pongs) 2012/9/18 Aaron J. Seigo ase...@kde.org: On Monday, September 17, 2012 20:40:33 Dario Freddi wrote: it's pretty much on the board :) just that 90% of this will happen in the background (server), whereas handlers will just take care of showing a model

Notifications-future, a recap

Hello everyone, you might or might not know by now of my intention of revamping the way we deal with notifications in KDE as I explained in my last blog post http://drfav.wordpress.com/2012/09/17/the-notifications-issue-part-3-the-possible-solution/ . I have been talking about this with many of

Re: Notifications-future, a recap

2012/9/17 David Faure fa...@kde.org: On Monday 17 September 2012 17:49:23 Dario Freddi wrote: a server API (so that the server can be put into runtime rather easily) Just a note on that: the plan with KDE Frameworks, is that there will be no more libs/runtime separation. A framework

[Kde-hardware-devel] Volunteers wanted for ALERT trial

Hello guys, as you might know, Solid is the main case study for the development of ALERT ( http://alert-project.eu/ ), a system which should allow a better and more efficient bug tracking and triaging. As the project reaches its final phase, ALERT is looking for 5 users for its trial. You do not

Re: dependency issue (KService* - KPluginLoader - KLocale)

2012/8/31 Kevin Ottens er...@kde.org: Hello, On Wednesday 29 August 2012 23:53:32 David Faure wrote: KService, KServiceTypeTrader and KMimeTypeTrader (all of which I moved to a new kservice framework), all have a template method (createInstance*) which uses KPluginLoader to load the plugin

Re: Review Request: fix for some typos

On June 16, 2012, 4:15 p.m., Lamarque Vieira Souza wrote: kdeui/actions/kaction.cpp, line 408 http://git.reviewboard.kde.org/r/105278/diff/1/?file=68027#file68027line408 Well, commit 3d789c9dcda0179aac40e2bcf58df06cccf84ed5 is the one that commented this line, but Dario did not

Re: [Kde-hardware-devel] Review Request: Make appShouldConserResources() reliable

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105310/#review14934 --- Ship it! Ship It! - Dario Freddi On June 20, 2012, 9:41

Re: GSoC: automatic brightness adjustment

so simple.  More importantly, it requires an additional piece of hardware, which is very inconvenient and cumbersome. On Thu, Apr 5, 2012 at 2:24 PM, Simon Oosthoek soml...@xs4all.nl wrote: On 05/04/12 16:39, Dario Freddi wrote: Any other engineers want to give out their opinion? :D

Re: GSoC: automatic brightness adjustment

Il 05 aprile 2012 07:32, Mike Dean miketd...@gmail.com ha scritto: As an electrical engineer, I find this idea sound. Allow me, as an information engineer and a computer scientist, to think you missed part of the picture :) I don't want to challenge your argument of the power consumption of the

Re: GSoC: automatic brightness adjustment

Il 05 aprile 2012 16:28, Christopher Blauvelt cblauv...@gmail.com ha scritto: On Thu, Apr 5, 2012 at 7:20 AM, Dario Freddi drf54...@gmail.com wrote: Il 05 aprile 2012 07:32, Mike Dean miketd...@gmail.com ha scritto: As an electrical engineer, I find this idea sound. Allow me

Re: GSoC: automatic brightness adjustment

Hi, Il 04 aprile 2012 03:12, Vadim Dombrowski pftb...@gmail.com ha scritto:  Hi! I'm a student of Belarusian State University and I would like to participate in GSoC 2012. The idea for my project is to create an automatic brightness adjustment mechanism using web-camera as light sensor.

Re: Review Request: Make KAuth ready for frameworks + API Changes

Il 31 marzo 2012 21:03, Stephen Kelly steve...@gmail.com ha scritto: Now I'm confused. Stephen Kelly wrote:     It was rebased onto some relatively recent commit, but not the tip of     the branch. You disagreed with what I said:  - Given that the branch was rebased on top of the last

Re: Review Request: Make KAuth ready for frameworks + API Changes

Il 01 aprile 2012 14:35, Stephen Kelly steve...@gmail.com ha scritto: Dario Freddi wrote: gitk indeed has a screwy visualization in there. You conclusion that the tool is screwy is interesting for a few reasons. Maybe some day you'll reconsider it. Wait - I was considering just this specific

Re: Review Request: Make KAuth ready for frameworks + API Changes

On March 30, 2012, 1:14 p.m., Dario Freddi wrote: April is upon us. If no objections arise in the time being, these changes will be merged on Sunday, after which I'll ask Kevin to move KAuth back to tier2/ for prime time. Stephen Kelly wrote: Thanks for making this happen

Re: Review Request: Make KAuth ready for frameworks + API Changes

On March 30, 2012, 1:14 p.m., Dario Freddi wrote: April is upon us. If no objections arise in the time being, these changes will be merged on Sunday, after which I'll ask Kevin to move KAuth back to tier2/ for prime time. Stephen Kelly wrote: Thanks for making this happen

Re: Review Request: Make KAuth ready for frameworks + API Changes

On March 30, 2012, 1:14 p.m., Dario Freddi wrote: April is upon us. If no objections arise in the time being, these changes will be merged on Sunday, after which I'll ask Kevin to move KAuth back to tier2/ for prime time. Stephen Kelly wrote: Thanks for making this happen

Re: Review Request: Make KAuth ready for frameworks + API Changes

, these changes will be merged on Sunday, after which I'll ask Kevin to move KAuth back to tier2/ for prime time. - Dario Freddi On March 18, 2012, 10:25 p.m., Dario Freddi wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request: Make KAuth ready for frameworks + API Changes

On March 30, 2012, 1:14 p.m., Dario Freddi wrote: April is upon us. If no objections arise in the time being, these changes will be merged on Sunday, after which I'll ask Kevin to move KAuth back to tier2/ for prime time. Stephen Kelly wrote: Thanks for making this happen

Re: QNetworkAccessManager and KDE's KIO

Il 23 marzo 2012 06:15, Weng Xuetian wen...@gmail.com ha scritto: On Fri, Mar 23, 2012 at 6:53 AM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 20 de març de 2012, a les 12:26:05, Weng Xuetian va escriure: Hi, Hi I'm currently implementing a library that require network access, and I

Re: Review Request: Make KAuth ready for frameworks + API Changes

On March 18, 2012, 11:04 p.m., Stephen Kelly wrote: Nice, thanks and sorry for the noise, and thanks for making the branch. Dario Freddi wrote: Np, hope you'll be able to have a quick look at it as well, it would be great :) Stephen Kelly wrote: Mostly it looks fine

Re: Review Request: Make KAuth ready for frameworks + API Changes

-mail. To reply, visit: http://git.reviewboard.kde.org/r/104337/#review11717 --- On March 18, 2012, 10:25 p.m., Dario Freddi wrote: --- This is an automatically generated e-mail

Re: unit testing a freeze

Il 21 marzo 2012 22:29, Dominik Haumann dhaum...@kde.org ha scritto: Moin, is there a simple way to unit test a freeze? Like if the test needs more than 5 seconds, fail? There's no straightforward way to check afaik and I don't really like the thread approach. What are you trying to verify?

Re: KF5 Volunteer day 2 next week?

Il 20 marzo 2012 17:53, Kevin Ottens er...@kde.org ha scritto: On Sunday 18 March 2012 20:11:20 Kevin Ottens wrote: So, doable? Any volunteers (aha) to drive the volunteer day? :-) Dario indicated to me he could be available part of the afternoon, that's nice but likely not enough. Screw

Re: Review Request: Make KAuth ready for frameworks + API Changes

On March 18, 2012, 11:04 p.m., Stephen Kelly wrote: Nice, thanks and sorry for the noise, and thanks for making the branch. Dario Freddi wrote: Np, hope you'll be able to have a quick look at it as well, it would be great :) Stephen Kelly wrote: Mostly it looks fine

Fwd: Review Request: Make KAuth ready for frameworks + API Changes

For interested people (hopefully many) -- Messaggio inoltrato -- Da: Dario Freddi d...@kde.org Date: 18 marzo 2012 23:25 Oggetto: Review Request: Make KAuth ready for frameworks + API Changes A: Kevin Ottens er...@kde.org, David Faure fa...@kde.org, Alexander Neundorf neund

Review Request: Make KAuth ready for frameworks + API Changes

/kauthexecutejob.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104337/diff/ Testing --- New unit tests pass 100% Thanks, Dario Freddi

Re: Review Request: Make KAuth ready for frameworks + API Changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104337/#review11594 --- On March 18, 2012, 10:25 p.m., Dario Freddi wrote

Re: Review Request: Make KAuth ready for frameworks + API Changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104337/#review11596 --- On March 18, 2012, 10:25 p.m., Dario Freddi wrote: --- This is an automatically

Re: Review Request: Make KAuth ready for frameworks + API Changes

. To reply, visit: http://git.reviewboard.kde.org/r/104337/#review11598 --- On March 18, 2012, 10:25 p.m., Dario Freddi wrote: --- This is an automatically generated e-mail. To reply

Re: Monitoring autotest coverage in frameworks

Hi, 2012/3/1 Frank Reininghaus frank7...@googlemail.com: Hi, Am 1. März 2012 00:44 schrieb Dario Freddi: I was wondering if we already had a way to generate reports on autotests coverage using lcov/gcov in frameworks. Looking at our cmake infrastructure, I spotted a build mode Profile which

Monitoring autotest coverage in frameworks

Hey guys, I was wondering if we already had a way to generate reports on autotests coverage using lcov/gcov in frameworks. Looking at our cmake infrastructure, I spotted a build mode Profile which should apparently set the correct compiler flags (but actually, at least for me, it didn't work), I

[Kde-hardware-devel] Some help for the ALERT Project

Hello guys, you might or might not know that I am part of the ALERT [1] effort on behalf of KDE. As such, I would like to ask you guys for a favor - if you are reading this and consider yourself a Solid developer, please take some time to fill out this survey: http://goo.gl/SxtFn The results

Re: [Kde-hardware-devel] Review Request: Make lid close explicit policy configurable

6f4560f powerdevil/kcmodule/global/GeneralPage.cpp b7039b8 powerdevil/kcmodule/global/generalPage.ui 0375e8f Diff: http://git.reviewboard.kde.org/r/104001/diff/ Testing --- Thanks, Dario Freddi ___ Kde-hardware-devel mailing list Kde

Re: Please avoid noisy merge commits in frameworks

2012/2/19 Stephen Kelly steve...@gmail.com: Stephen Kelly wrote: Hi there, I was reviewing the changes in the frameworks branch from yesterday. Something I noticed was that there are a lot of merge commits that don't need to exist. Ugh. Yet more of this just appeared... Recent history in

Re: Please avoid noisy merge commits in frameworks

2012/2/19 Ben Cooksley bcooks...@kde.org: First, our hooks are in python - so any changes would need to be in Python as well. I can speak a bit of python, would be a nice way for learning more :) Second, there is a legitimate use for pushing merge commits - namely integrating a seperate

Re: Please avoid noisy merge commits in frameworks

2012/2/19 Stephen Kelly steve...@gmail.com: Stephen Kelly wrote: Hi there, I was reviewing the changes in the frameworks branch from yesterday. Something I noticed was that there are a lot of merge commits that don't need to exist. Ugh. Yet more of this just appeared... Recent history in

Re: Please avoid noisy merge commits in frameworks

2012/2/19 Ben Cooksley bcooks...@kde.org: First, our hooks are in python - so any changes would need to be in Python as well. I can speak a bit of python, would be a nice way for learning more :) Second, there is a legitimate use for pushing merge commits - namely integrating a seperate

[Kde-hardware-devel] Review Request: Make lid close explicit policy configurable

/ Testing --- Thanks, Dario Freddi ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Forward porting policy

Howdy, I just pushed a fix to KDE/4.8 in workspace. Now, when trying to forward-port as usual, a variety of commits by scripty, and a commit from a fellow developer, were merged as well. Which raises two questions that boggle me since a while: 1. Should 4.x always be fully merged into master?

Re: hard-dep for Qt 4.8

2012/1/18 Thomas Zander zan...@kde.org: On Wednesday 18 January 2012 06.35.57 Martin Gräßlin wrote: I didn't say that this is a reason. I wanted to highlight the problem of not  depending on 4.8 and everybody using 4.8. I'm not going to start reviewing code for is this a Qt 4.8 change.

Re: hard-dep for Qt 4.8

2012/1/18 Thomas Zander zan...@kde.org: On Wednesday 18 January 2012 09.05.32 Dario Freddi wrote: if you remember there are a lot of people using KDE that are not 'core' developers. Typically they are one-time developers, they are artists, they are translators etc [] That said, I am

Re: Proposal: have Solid::beginSuppressingScreenPowerManagement inhibit screensaver as well

Cool :) If no objections arise within the next hours, I'll commit the change 2012/1/17 Alex Fiestas afies...@kde.org: On 01/17/2012 05:17 AM, Dario Freddi wrote: Howdy, this mail comes after a certain discussion on how to handle screen inhibition. At the moment, the aforementioned function

[Kde-hardware-devel] Review Request: Add screensaver to inhibition features of Solid::PM

the screensaver together with all the other screen power management when using *suppressingSleep. Diffs - solid/solid/powermanagement.cpp e146f34 solid/solid/powermanagement_p.h fac4450 Diff: http://git.reviewboard.kde.org/r/103720/diff/diff Testing --- Thanks, Dario Freddi

  1   2   >