Re: Moving akonadi from kdesupport and akonadi-search from playground

2015-07-24 Thread Milian Wolff
in the afternoon. Please let's get this done and end this painful release asap. \o/ Rock on guys, I'm a happy KF5 KDE PIM user. Let's get this beast released! -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-15 Thread Milian Wolff
here?), I stopped using private signals and instead do something like connect(foo, Foo::bar, this, [this] (...) { d-onBar(...); }); I quite like that, as it does not leak anything to the public header at all. - Milian Wolff On July 15, 2015, 8:59 a.m

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-14 Thread Milian Wolff
(factor of 2). src/kextracolumnsproxymodel.cpp (line 85) https://git.reviewboard.kde.org/r/124331/#comment56909 here and elsewhere: why not use the newstyle connect syntax? - Milian Wolff On July 14, 2015, 10:42 a.m., David Faure wrote

Re: KSyCoca, Thread safety, and Cache invalidation

2015-07-14 Thread Milian Wolff
on-disk meta data in the worst case, esp. on old rotary disks. Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

2015-07-10 Thread Milian Wolff
/r/124282/#comment56675 same as above, with the placement of the : - Milian Wolff On July 9, 2015, 10:41 p.m., Jesse Jaara wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

2015-07-09 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124304/#review82275 --- also +1 from my side - Milian Wolff On July 9, 2015, 11:48

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

2015-07-09 Thread Milian Wolff
(...)) { src/plugins/voikko/voikkodict.cpp (line 219) https://git.reviewboard.kde.org/r/124282/#comment56638 join next line - Milian Wolff On July 8, 2015, 5:10 p.m., Jesse Jaara wrote: --- This is an automatically generated e-mail

Re: Announcing heaptrack - a Heap Memory Profiler for Linux

2015-07-03 Thread Milian Wolff
On Friday, July 03, 2015 06:46:57 AM Burkhard Lück wrote: Am Donnerstag, 2. Juli 2015, 23:22:06 schrieb Milian Wolff: On Tuesday 09 December 2014 02:15:58 Milian Wolff wrote: [...] It's still in kdereview and I fixed and added more stuff in the meantime. Most notably, there is now

Re: Review Request 124239: Fix KMimeType::Ptr::isNull implementation.

2015-07-03 Thread Milian Wolff
://git.reviewboard.kde.org/r/124239/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 124239: Fix KMimeType::Ptr::isNull implementation.

2015-07-03 Thread Milian Wolff
c7db1cb64ec5470a5590b783d46fc97d1d2e89d8 src/kdecore/kmimetype.h 93bbddc8d9be8f8b6bdb3003dfbe9558d24aff9b Diff: https://git.reviewboard.kde.org/r/124239/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 124239: Fix KMimeType::Ptr::isNull implementation.

2015-07-03 Thread Milian Wolff
marked as submitted. Review request for KDE Frameworks, David Faure and Laurent Montel. Changes --- Submitted with commit 7ebe1d32c4704e8048dfb2579dd4f5fa2ba9dce1 by Milian Wolff to branch master. Repository: kdelibs4support Description --- The pointer is null if the contained data

Re: Announcing heaptrack - a Heap Memory Profiler for Linux

2015-07-03 Thread Milian Wolff
On Friday, July 03, 2015 11:58:11 AM Burkhard Lück wrote: Am Freitag, 3. Juli 2015, 10:01:55 schrieb Milian Wolff: They are, now :) Thanks for re-raising this, I forgot about your other mail. I also think that this is currently wrong in Massif-Visualizer, if I'm not mistaken. You

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

2015-07-02 Thread Milian Wolff
to deduplicate the data - it won't do that for lambdas and thus QStringLiteral. - Milian Wolff On July 2, 2015, 12:14 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Announcing heaptrack - a Heap Memory Profiler for Linux

2015-07-02 Thread Milian Wolff
On Tuesday 09 December 2014 02:15:58 Milian Wolff wrote: On Wednesday 03 December 2014 01:51:57 Aleix Pol wrote: On Tue, Dec 2, 2014 at 6:59 PM, Milian Wolff m...@milianw.de wrote: Hey all, I have just finished writing a lengthy introduction to heaptrack, an alternative to Massif

Re: QPA plugin like functionality in frameworks?

2015-07-01 Thread Milian Wolff
by using static QMetaMethod and invoking them). And, probably more important, there is no compile-time check that the invoked methods are available in the implementation side. Bye -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel

Re: KF5 KDevelop build problem

2015-07-01 Thread Milian Wolff
. Bye -- Milian Wolff m...@milianw.de http://milianw.de Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: Freeze on nested eventloops (QFileDialog::getOpen*)

2015-06-29 Thread Milian Wolff
On Friday 26 June 2015 03:17:49 Vishesh Handa wrote: On Wed, Jun 24, 2015 at 9:52 AM, Milian Wolff m...@milianw.de wrote: Hm, so maybe related to https://git.reviewboard.kde.org/r/124128/ ? Vishesh, did you also see similar freezes? I didn't actually get the freezes, but David Edmunson

Re: KF5 KDevelop build problem

2015-06-24 Thread Milian Wolff
::Iterator’ has no member named ‘ref’ ret += it.ref().toString(); I'll fix this later - I thought I test-compiled it properly, but apparently not. Please stay tuned and/or revert the last commit in KDevplatform locally to get it building again. Bye -- Milian Wolff m...@milianw.de http

Re: Freeze on nested eventloops (QFileDialog::getOpen*)

2015-06-24 Thread Milian Wolff
On Wednesday 24 June 2015 00:39:30 Andreas Hartmetz wrote: On Sunday 14 June 2015 15:00:57 Milian Wolff wrote: Hey all, in massif-visualizer's framework branch, and now also kate, I sometimes notice GUI lockups when I try to open files via Ctrl + O. The backtraces look like

Re: KSyCoca, Thread safety, and Cache invalidation

2015-06-14 Thread Milian Wolff
will still get potentially expensive sycoca rebuilding when something happens, but I'm not sure how expensive this is. Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Freeze on nested eventloops (QFileDialog::getOpen*)

2015-06-14 Thread Milian Wolff
compiled KF5-based stuff (e.g. KDEPlatformTheme.so) with kdesrc-build compiled KF5 libraries (/home/milian/projects/kf5/*)? The applications do not recover from this lockup. Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Application-specific color settings

2015-06-08 Thread Milian Wolff
On Monday 08 June 2015 23:40:58 Friedrich W. H. Kossebau wrote: Am Montag, 8. Juni 2015, 17:22:26 schrieb Milian Wolff: Hey all, sometimes I need to run applications that do not work properly with a dark system color scheme. Is there a way to set a different (bright) color scheme

Application-specific color settings

2015-06-08 Thread Milian Wolff
? Are those upstream in Qt or somewhere in our git? Bye -- Milian Wolff m...@milianw.de http://milianw.de Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread Milian Wolff
passes. also kate and the manual kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url requester. Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread Milian Wolff
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 36b558dbc9d739d5367366290d034cb05e1e8061 by Milian Wolff to branch master. Repository: kio Description --- BUG: 346920 REVIEW: 124032 Add unit test for user completion when

Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread Milian Wolff
://git.reviewboard.kde.org/r/124032/#review81277 --- On June 6, 2015, 8:58 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https

What environment variable defines where krunner looks for libkdeinit5_$app.so

2015-06-06 Thread Milian Wolff
environment variable do I need to set for KRunner to find it? Thanks -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread Milian Wolff
changes due to the QUrl-KUrl porting, you don't *have* to answer this one ;) Milian Wolff wrote: it still works and I also wonder why this has not happened before - I blame the KUrl/QUrl differences here. Who was the expert in that area again to ask? :P Is it OK if I just add a test

Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread Milian Wolff
d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef Diff: https://git.reviewboard.kde.org/r/124032/diff/ Testing --- added a unit test, it now passes. also kate and the manual kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url requester. Thanks, Milian Wolff

Re: What environment variable defines where krunner looks for libkdeinit5_$app.so

2015-06-06 Thread Milian Wolff
On Saturday 06 June 2015 23:31:52 David Faure wrote: On Saturday 06 June 2015 23:18:51 Milian Wolff wrote: Hey all, I try to configure my KF5 plasma environment similar to my old KDE4 plasma. There, I could open even applications build into my custom prefix via krunner. I think

How to port KGlobalSettings::fixedFont et. al?

2015-06-05 Thread Milian Wolff
Hey all, as the subject says - how should KGlobalSettings::fixedFont and the like be ported? QFont(monospace)? Thanks -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part. ___ Kde

Re: How to port KGlobalSettings::fixedFont et. al?

2015-06-05 Thread Milian Wolff
be ported? QFont(monospace)? Thanks -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Milian Wolff m

Re: Review Request 123989: Add index size to balooctl status

2015-06-03 Thread Milian Wolff
://git.reviewboard.kde.org/r/123989/#comment8 style: join with next line if () { ... } else { ... } - Milian Wolff On June 3, 2015, 6:08 p.m., Pinak Ahuja wrote

Re: Review Request 123930: Reduce temporary allocations.

2015-06-02 Thread Milian Wolff
marked as submitted. Review request for KDE Frameworks, David Faure, Laurent Montel, Martin Tobias Holmedahl Sandsmark, and Kåre Särs. Changes --- Submitted with commit 779a676d46567df4db29445e689ff9ddb6368616 by Milian Wolff to branch master. Repository: sonnet Description

Re: Review Request 123930: Reduce temporary allocations.

2015-05-30 Thread Milian Wolff
://git.reviewboard.kde.org/r/123930/#review80953 --- On May 30, 2015, 5:13 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 123930: Reduce temporary allocations.

2015-05-30 Thread Milian Wolff
/speller.cpp dcf98eccb2d82642dc2efe0145ad7ba9a814505f Diff: https://git.reviewboard.kde.org/r/123930/diff/ Testing --- ran katepart again - much quicker now, even with auto-language-detection enabled! unit test still work as well. Thanks, Milian Wolff

How to port kfiledialog:/// feature of KFileDialog?

2015-05-30 Thread Milian Wolff
Hey all, is there a utility function to port the memory effect of kfiledialog:/// URLs used in KFileDialog, when using QFileDialog now? If not, could we add it somewhere? Thanks -- Milian Wolff m...@milianw.de http://milianw.de Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub

Review Request 123930: WIP: Make the speller dict cache static.

2015-05-28 Thread Milian Wolff
anyways. Diffs - src/core/speller.cpp dcf98eccb2d82642dc2efe0145ad7ba9a814505f Diff: https://git.reviewboard.kde.org/r/123930/diff/ Testing --- ran katepart again - much quicker now, even with auto-language-detection enabled! unit test still work as well. Thanks, Milian Wolff

Re: Review Request 123924: Optimize KIconEngine::availableSizes()

2015-05-28 Thread Milian Wolff
://git.reviewboard.kde.org/r/123924/#comment55450 in KF6, this should also not use QList, but QVector instead. on 32bit platforms, a QListQSize is pretty damn slow - Milian Wolff On May 28, 2015, 2:41 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 123852: Optimize: Do not wipe dict cache when copying speller objects.

2015-05-25 Thread Milian Wolff
marked as submitted. Review request for KDE Frameworks, Laurent Montel, Martin Tobias Holmedahl Sandsmark, and Kåre Särs. Changes --- Submitted with commit 1334cdcbce2f355455faf0bf9693881462c20416 by Milian Wolff to branch master. Repository: sonnet Description --- This removes

Re: Review Request 123868: Avoid copying QByteArray

2015-05-21 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123868/#review80681 --- Ship it! Ship It! - Milian Wolff On May 21, 2015, 6:19

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

2015-05-21 Thread Milian Wolff
://git.reviewboard.kde.org/r/123867/#comment55313 shouldn't this be #include cmath - Milian Wolff On May 21, 2015, 5:50 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 123858: Fix memory leak in drags

2015-05-20 Thread Milian Wolff
, then put it into a QScopedPointer - Milian Wolff On May 20, 2015, 12:23 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123858

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-20 Thread Milian Wolff
://git.reviewboard.kde.org/r/123857/#comment55298 no need to change the indentation level of all the code if you'd do if (!str) { return; } instead - Milian Wolff On May 19, 2015, 10:11 p.m., David Edmundson wrote

Review Request 123852: Optimize: Do not wipe dict cache when copying speller objects.

2015-05-19 Thread Milian Wolff
/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

2015-05-19 Thread Milian Wolff
there is a unit test. anyone objects to getting it in? - Milian Wolff On May 12, 2015, 6:03 p.m., Kåre Särs wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

2015-05-19 Thread Milian Wolff
On May 19, 2015, 3:12 p.m., Vishesh Handa wrote: autotests/test_settings.cpp, line 43 https://git.reviewboard.kde.org/r/123341/diff/4/?file=362129#file362129line43 Minor thing, which is up to you. In this test you're allocating the `Speller` off the heap and having to

Re: Review Request 123679: Fix build with Qt 5.5

2015-05-08 Thread Milian Wolff
this is destroyed, leading to undefined behavior. - Milian Wolff On May 7, 2015, 11:31 p.m., Jan Kundrát wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679

Re: Review Request 123679: Fix build with Qt 5.5

2015-05-08 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/#review80082 --- Ship it! Ship It! - Milian Wolff On May 8, 2015, 10:42

Re: Review Request 123662: Remove code duplication in postingDB

2015-05-07 Thread Milian Wolff
like int just make it a value and it's as fast as it can only get. - Milian Wolff On May 7, 2015, 4:53 a.m., Pinak Ahuja wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662

Re: Review Request 123662: Remove code duplication in postingDB

2015-05-07 Thread Milian Wolff
://git.reviewboard.kde.org/r/123662/#comment54911 please also add a TODO to optimize this by QByteArray::fromRawData. - Milian Wolff On May 7, 2015, 4:53 a.m., Pinak Ahuja wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 123662: Remove code duplication in postingDB

2015-05-07 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review80057 --- Ship it! Ship It! - Milian Wolff On May 7, 2015, 11:43

Re: Review Request 123654: Improve performance of KFileItem and KDirSortFilterProxyModel

2015-05-06 Thread Milian Wolff
is this check required, i.e. shouldn't the collator code in Qt handle it and do a no-op if nothing changes? - Milian Wolff On May 6, 2015, 2:35 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 123662: Remove code duplication in postingDB

2015-05-06 Thread Milian Wolff
/#comment54869 sadly QByteArrayRef is still not there so yes this is what you'd need to do. and the performance impact can be big so definitey worth to d that in a follow-up. alternatively, couldn't you use qstrncmp or the stl/c alternative here? this is probably even faster - Milian

multiple kwallet windows after session login

2015-04-29 Thread Milian Wolff
at the code and fix this. Can someone point me into the right direction to add a DBUS lock? Also, on a related note: Is there any progress on getting PAM single-sign-on support for KWallet done? There was a blog post a few months ago, but apparently nothing got finished and merged? Thanks -- Milian

Re: Review Request 123567: Add an Arch Linux package search provider

2015-04-29 Thread Milian Wolff
? doesn't make much sense to have it on non-arch systems, no? - Milian Wolff On April 29, 2015, 1:21 p.m., Anthony Vital wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123567

Re: Review Request 123567: Add an Arch Linux package search provider

2015-04-29 Thread Milian Wolff
On April 29, 2015, 1:55 p.m., Milian Wolff wrote: shouldn't something like this be provided by the distribution? doesn't make much sense to have it on non-arch systems, no? Anthony Vital wrote: I don't know but there are search providers for debian and opensuse already. ah ok

Managing different build configurations with kdesrc-build

2015-04-24 Thread Milian Wolff
a different buildrc for the RelWithDebInfo configuration? I could not find a CLI parameter for this. Potentially I could do it via --set-module-option- value and changing the global settings for qtdir, build-dir and kdedir as well as the cmake-options. What do you suggest? -- Milian Wolff m

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-24 Thread Milian Wolff
like. - Milian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79415 --- On April 23, 2015, 5:19 p.m., Milian Wolff

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-24 Thread Milian Wolff
marked as submitted. Review request for KDE Frameworks, David Faure, Marc Mutz, and Volker Krause. Changes --- Submitted with commit ff964c0c42202228348213e7d5c10f5611a9ee54 by Milian Wolff to branch master. Repository: kcoreaddons Description --- The len in inotify_event

Exporting symbols to access them from tests

2015-04-24 Thread Milian Wolff
classes for tests don't need that - one can only decide whether something is private exported by checking whether the header file is installed or not in the CMakeLists.txt What do you think? -- Milian Wolff m...@milianw.de http://milianw.de Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub

Re: Managing different build configurations with kdesrc-build

2015-04-24 Thread Milian Wolff
that while looking at --help. Or I was looking for something different :) Thanks Jeremy! On Fri, Apr 24, 2015 at 5:39 AM, Milian Wolff m...@milianw.de wrote: Hey all, esp. Jeremy. I have a question regarding kdesrc-build: Is it possible to manage multiple build configurations with kdesrc

Re: Exporting symbols to access them from tests

2015-04-24 Thread Milian Wolff
On Friday 24 April 2015 14:31:27 Aleix Pol wrote: On Fri, Apr 24, 2015 at 2:17 PM, Milian Wolff m...@milianw.de wrote: Hey all, what's the best-practice to export symbols for tests only? In Qt, there is the Q_AUTOTEST_EXPORT macro: qglobal.h: /* No, this is not an evil

Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Milian Wolff
: 123479 Diffs - src/lib/io/kdirwatch.cpp a75fae012c59021996b46845db2e97abb5526930 Diff: https://git.reviewboard.kde.org/r/123479/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Milian Wolff
with this: https://paste.kde.org/pmoue241d Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Milian Wolff
this into some branch? There are none in kcoreaddons. This patch here should probably be put into a patch release (if we do this for kf5). - Milian Wolff On April 23, 2015, 4:50 p.m., Milian Wolff wrote: --- This is an automatically generated e

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Milian Wolff
://git.reviewboard.kde.org/r/123479/diff/ Testing --- I used the test and looked at the output and also ran it against a patched qtbase with this: https://paste.kde.org/pmoue241d Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde

Re: Distros and QtWebEngine

2015-04-21 Thread Milian Wolff
subject? I seem to have missed it, and also can't find it in my recent mails. Sorry for that. Thanks -- Milian Wolff m...@milianw.de http://milianw.de

Re: Distros and QtWebEngine

2015-04-21 Thread Milian Wolff
On Monday 20 April 2015 23:19:22 Luigi Toscano wrote: Milian Wolff ha scritto: I'm not a KDE PIM maintainer, but with my KDevelop hat on (that uses a web view to display documentation pages, currently QtWebKit), kio_man uses khtml (why don't you use it)? But anyway, also khtml

Re: branchGroup stable-qt4 Compile failures. Need dev assistance please.

2015-04-21 Thread Milian Wolff
in there are just historic artifacts. Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Distros and QtWebEngine

2015-04-20 Thread Milian Wolff
effort than supporting different implementations. Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

2015-04-17 Thread Milian Wolff
is empty or the list of sources is empty? the latter was recently added to kdevplatform afaik. as the initial author of this macro in kdev, a general +1 from my side for upstreaming it and many thanks! - Milian Wolff On April 17, 2015, 12:35 p.m., Aleix Pol Gonzalez wrote

Re: Kate .part files

2015-04-16 Thread Milian Wolff
on it. In general, this is not Kate/Kwrite specific, but rather something that is KIO specific and thus applies to all KDE applications. Please direct future questions to kde-devel@kde.org Thanks. -- Milian Wolff m...@milianw.de http://milianw.de Visit http://mail.kde.org/mailman/listinfo

Re: Review Request 122487: Reorder member variables to reduce memory usage.

2015-04-16 Thread Milian Wolff
or was this still requiring manual interpretation? - Milian Wolff On Feb. 9, 2015, 5:04 p.m., Volker Krause wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122487

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2015-02-08 Thread Milian Wolff
, kate and kdev* builds fine. Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KDE backward compatibility issue

2015-02-04 Thread Milian Wolff
this regularly anyways to benefit from the bug fixes and potential security fixes in Qt upstream. Bye -- Milian Wolff m...@milianw.de http://milianw.de Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: KDE backward compatibility issue

2015-02-04 Thread Milian Wolff
On Wednesday 04 February 2015 21:49:15 Vasily Khoruzhick wrote: Hi Milian, On Wed, Feb 4, 2015 at 9:04 PM, Milian Wolff m...@milianw.de wrote: If these apps link against Qt5 statically (which they can, assuming they pay the license fees to Digia), then they will need to recompile

Re: make uninstall

2015-02-04 Thread Milian Wolff
we'll get more homogeinity that way. This is now done (https://git.reviewboard.kde.org/r/122359/). Thank you Alex, much appreciated! -- Milian Wolff m...@milianw.de http://milianw.de

Re: Another proposal for modernization of our infrastructure

2015-02-02 Thread Milian Wolff
, this is something that kdesrc-build could automate for us. The rest of the above is independent of the actual tool. Even with reviewboard or phabricator, you'll need to know where to push your change. Bugfix? Latest stable release you want to support. New feature? dev. Bye -- Milian Wolff m

Re: Review Request 122330: Associate *.qmltypes and *.qmlproject files with the text/x-qml mime type

2015-02-02 Thread Milian Wolff
On Feb. 1, 2015, 8:32 p.m., David Faure wrote: -1 for not submitting this upstream for shared-mime-info. I took care of it, it's committed, will be in s-m-i 1.4. Could we add a comment to this file then, telling people to work on upstream smi instead then? - Milian

Re: Another proposal for modernization of our infrastructure

2015-02-02 Thread Milian Wolff
gerrit means using it exactly like Qt is using it! Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Review Request 122330: Associate *.qmltypes and *.qmlproject files with the text/x-qml mime type

2015-02-01 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122330/#review75164 --- Ship it! Ship It! - Milian Wolff On Jan. 31, 2015, 5:48

Re: Review Request 122330: Associate *.qmltypes and *.qmlproject files with the text/x-qml mime type

2015-02-01 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122330/#review75164 --- Ship it! Ship It! - Milian Wolff On Jan. 31, 2015, 5:48

Re: Feature matrix for future infrastructure

2015-01-30 Thread Milian Wolff
custom human review. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Another proposal for modernization of our infrastructure

2015-01-29 Thread Milian Wolff
so. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Another proposal for modernization of our infrastructure

2015-01-29 Thread Milian Wolff
, I think! tl;dr; please do not rule-out Gerrit just because you don't know it (yet)! Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Supporting MSVC2010 in ktexteditor framework

2015-01-29 Thread Milian Wolff
is still the same on this matter: VS2012 (aka MSVC11). +1 -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Another proposal for modernization of our infrastructure

2015-01-28 Thread Milian Wolff
by running rbt post and specifing the git hash manually all in all, this makes it /much/ simpler to use than rbt. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: reviving make uninstall?

2015-01-28 Thread Milian Wolff
On Wednesday 28 January 2015 20:08:41 Alex Merry wrote: On Wednesday 28 January 2015 17:10:41 Milian Wolff wrote: Hello all, why was the uninstall target removed from make files in frameworks? I cannot find any discussion regarding that on the web. As a developer, I find it highly

reviving make uninstall?

2015-01-28 Thread Milian Wolff
? -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: configuring cppcheck on the CI

2015-01-28 Thread Milian Wolff
On Wednesday 28 January 2015 18:18:51 Marko Käning wrote: Hi Milian, On 28 Jan 2015, at 16:59 , Milian Wolff m...@milianw.de wrote: OK, can you tell me how to tweak cppcheckExtraArgs for individual projects, e.g. kdevplatform for now? for this project currently exists this file

Re: configuring cppcheck on the CI

2015-01-28 Thread Milian Wolff
On Wednesday 28 January 2015 19:30:40 Milian Wolff wrote: On Wednesday 28 January 2015 18:18:51 Marko Käning wrote: Hi Milian, On 28 Jan 2015, at 16:59 , Milian Wolff m...@milianw.de wrote: OK, can you tell me how to tweak cppcheckExtraArgs for individual projects, e.g

Re: Review Request 122293: Use activate on single click setting from QPlatformTheme rather than duplicating it

2015-01-28 Thread Milian Wolff
, which it does even better than before if I understand you correctly. So +1 from my side, FWIW. - Milian Wolff On Jan. 28, 2015, 5:26 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https

configuring cppcheck on the CI

2015-01-27 Thread Milian Wolff
/ The first two errors are grantlee templates and should be ignored by cppcheck. The third is a missing define (where does cppcheck get those from?). Thanks -- Milian Wolff m...@milianw.de http://milianw.de Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2015-01-26 Thread Milian Wolff
/krecursivefilterproxymodel.cpp https://git.reviewboard.kde.org/r/122252/#comment51807 again, use iterators kdeui/itemviews/krecursivefilterproxymodel.cpp https://git.reviewboard.kde.org/r/122252/#comment51809 again, use iterators - Milian Wolff On Jan. 25, 2015, 6:51 p.m., David Faure wrote

Re: Review Request 122227: KRecursiveFilterProxyModel: many many more unittests, and fixing what they found.

2015-01-26 Thread Milian Wolff
://git.reviewboard.kde.org/r/17/#comment51801 is this still required in qt5? this should really be added upstream, imo... kdeui/tests/krecursivefilterproxymodeltest.cpp https://git.reviewboard.kde.org/r/17/#comment51803 style: { on newline? - Milian Wolff On Jan. 23, 2015, 6:11 p.m

Re: Review Request 122204: Mark results as required.

2015-01-25 Thread Milian Wolff
Diffs - src/klocalizedstring.h 8e8e84926b444150e00c80b3b77766ba16e03e25 Diff: https://git.reviewboard.kde.org/r/122204/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: [ki18n] src: small qstring optimizations

2015-01-25 Thread Milian Wolff
are bad: See also: http://neugierig.org/software/chromium/notes/2011/08/static-initializers.html -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Sysadmin report on the modernization of our infrastructure

2015-01-23 Thread Milian Wolff
important for us. snip Thanks again! -- Milian Wolff m...@milianw.de http://milianw.de

Feature matrix for future infrastructure

2015-01-23 Thread Milian Wolff
etc. pp. wherever possible. Bye -- Milian Wolff m...@milianw.de http://milianw.de

<    1   2   3   4   5   6   7   8   9   >