Re: [libav-devel] [PATCH 2/2] Eliminate _DARWIN_C_SOURCE.

2011-05-12 Thread Luca Barbato
On 5/11/11 6:46 PM, Diego Biurrun wrote: --- libavformat/os_support.c |1 - libavformat/udp.c|2 +- libswscale/utils.c |2 +- 3 files changed, 2 insertions(+), 3 deletions(-) Checked on amd64 macosx and works. ___ libav-

Re: [libav-devel] [PATCH 1/2] configure: Add -D_POSIX_C_SOURCE for each system individually.

2011-05-12 Thread Luca Barbato
On 5/11/11 6:46 PM, Diego Biurrun wrote: --- configure|4 ++-- doc/general.texi |8 ffmpeg.c |3 --- ffplay.c |2 -- ffserver.c |2 -- libavcodec/libxvidff.c |3

[libav-devel] [PATCH] make asfdec fallback to binary search internally

2011-05-12 Thread Vladimir Pantelic
Vladimir Pantelic wrote: atm the asf logic is: if( index_exists ) { index = search_by_index() if( index< 0 ) { return -1; } // index success } else { try binary search ... } maybe it should be: if( index_exists ) {

[libav-devel] [PATCH] reindent after previous commit 15f02f4d

2011-05-12 Thread Vladimir Pantelic
$subject >From 79b8b83dad63450e511961188337c8161df575d8 Mon Sep 17 00:00:00 2001 From: Vladimir Pantelic Date: Thu, 12 May 2011 10:23:22 +0200 Subject: [PATCH] reindent after previous commit 15f02f4d --- libavformat/asfdec.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-

Re: [libav-devel] [PATCH 4/5] oggdec: simplify ogg_probe

2011-05-12 Thread Måns Rullgård
Clément Bœsch writes: > --- > libavformat/oggdec.c |7 ++- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c > index ffc3b39..b5420f8 100644 > --- a/libavformat/oggdec.c > +++ b/libavformat/oggdec.c > @@ -631,12 +631,9 @@ stat

Re: [libav-devel] [PATCH 5/5] oggdec: use explicit AVInputFormat struct initializers

2011-05-12 Thread Måns Rullgård
Clément Bœsch writes: > --- > libavformat/oggdec.c | 22 +++--- > 1 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c > index b5420f8..6767805 100644 > --- a/libavformat/oggdec.c > +++ b/libavformat/oggdec.c > @@ -637,

Re: [libav-devel] [PATCH] tiff: add support to TIFF_SAMPLES_PER_PIXEL case in tiff_decode_tag()

2011-05-12 Thread Kostya
On Mon, May 09, 2011 at 12:51:24PM +0200, Stefano Sabatini wrote: > Format detection and internal frame initialization is moved to a > separate init_image() function, which is called when all the tags have > been read, and so both BitsPerSample and SamplesPerPixel information > has been collected.

Re: [libav-devel] [PATCH] ffmpeg.c: fix seting of decode_interrupt_cb().

2011-05-12 Thread Måns Rullgård
Anton Khirnov writes: > From: Michael Niedermayer This isn't his patch anymore, is it? > Signed-off-by: Anton Khirnov > --- > ffmpeg.c |5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/ffmpeg.c b/ffmpeg.c > index 5ab3c7a..afd4374 100644 > --- a/ffmpeg.c > +++

Re: [libav-devel] [PATCH 01/21] configure: sort filter deps entries

2011-05-12 Thread Måns Rullgård
Anton Khirnov writes: > From: Stefano Sabatini > > Signed-off-by: Anton Khirnov > --- > configure |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure b/configure > index 955a568..ac2a7eb 100755 > --- a/configure > +++ b/configure > @@ -1467,8 +1467,8 @@ dra

Re: [libav-devel] [PATCH 04/21] lavc: Mark MS-MPEG4v1 encoder as experimental.

2011-05-12 Thread Måns Rullgård
Anton Khirnov writes: > From: Carl Eugen Hoyos > > The encoder has never produced files that could be decoded > with any software. > > Signed-off-by: Anton Khirnov > --- > libavcodec/msmpeg4.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/msmpeg4.c b

Re: [libav-devel] [PATCH 06/21] mpegts: do not output known sized packet if an unbounded packet is already queued.

2011-05-12 Thread Luca Barbato
On 5/12/11 7:56 AM, Anton Khirnov wrote: Signed-off-by: Anton Khirnov --- libavformat/mpegts.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 3130eb9..e6779fe 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts

Re: [libav-devel] [PATCH 05/21] dfa: fix buffer overflow checks to avoid integer overflows.

2011-05-12 Thread Måns Rullgård
Anton Khirnov writes: > From: Reimar Döffinger > > Signed-off-by: Anton Khirnov > --- > libavcodec/dfa.c | 35 +++ > 1 files changed, 19 insertions(+), 16 deletions(-) Looks OK. -- Måns Rullgård m...@mansr.com ___

Re: [libav-devel] [PATCH 07/21] movenc: fix adpcm mono muxing.

2011-05-12 Thread Luca Barbato
On 5/12/11 7:56 AM, Anton Khirnov wrote: adpcm mono ok ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 17/21] matroskaenc: add missing new line in av_log() call

2011-05-12 Thread Måns Rullgård
Anton Khirnov writes: > From: Aurelien Jacobs > > Signed-off-by: Aurelien Jacobs > Signed-off-by: Anton Khirnov > --- > libavformat/matroskaenc.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 781121

Re: [libav-devel] [PATCH] MP3 file contains the string NSVs, the NSV probe will think it is a NSV file instead of a MP3 file. Check for 0xBEEF after a Video/Audio chunck for more accuracy

2011-05-12 Thread Benjamin Larsson
Looks ok. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 10/21] dnxhdenc: add AVClass in private context.

2011-05-12 Thread Måns Rullgård
Anton Khirnov writes: > From: Baptiste Coudurier > > Fixes private options. > > Signed-off-by: Anton Khirnov > --- > libavcodec/dnxhdenc.c |4 ++-- > libavcodec/dnxhdenc.h |1 + > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhd

Re: [libav-devel] [PATCH 08/21] movenc: fix yuv range in avid atoms used by dnxhd.

2011-05-12 Thread Luca Barbato
On 5/12/11 7:56 AM, Anton Khirnov wrote: -avio_wb32(pb, 1); /* yuv 1 / rgb 2 ? */ > +avio_wb32(pb, 2); /* yuv range: full 1 / normal 2 */ Ok I guess, maybe report the comment next to the line also in the commit message please. lu ___ libav-

Re: [libav-devel] [RFC] fix swscale for 9/10bit

2011-05-12 Thread Kostya
On Wed, May 11, 2011 at 01:20:26PM -0400, Ronald S. Bultje wrote: > Hi again, > > On Wed, May 11, 2011 at 12:07 PM, Ronald S. Bultje wrote: > > On Wed, May 11, 2011 at 11:59 AM, Ronald S. Bultje > > wrote: > >> On Wed, May 11, 2011 at 11:26 AM, Ronald S. Bultje > >> wrote: > >>> attached is a

[libav-devel] [PATCH] configure: Do not unconditionally add -D_POSIX_C_SOURCE to CPPFLAGS.

2011-05-12 Thread Diego Biurrun
Adding _POSIX_C_SOURCE to CPPFLAGS globally produces all sorts of problems since it causes certain system functions to be hidden on some (BSD) systems. The solution is to only add the flag on systems that really require it, i.e. glibc-based ones. This change makes BSD systems compile out-of-the-bo

Re: [libav-devel] [PATCH 01/21] configure: sort filter deps entries

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 07:56:05AM +0200, Anton Khirnov wrote: > From: Stefano Sabatini OK Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 02/21] patcheck: warn about assert usage

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 07:56:06AM +0200, Anton Khirnov wrote: > From: Peter Ross OK Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 03/21] ffprobe: tweak error message in open_input_file()

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 07:56:07AM +0200, Anton Khirnov wrote: > From: Stefano Sabatini OK Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] configure: Do not unconditionally add -D_POSIX_C_SOURCE to CPPFLAGS.

2011-05-12 Thread Måns Rullgård
Diego Biurrun writes: > Adding _POSIX_C_SOURCE to CPPFLAGS globally produces all sorts of problems > since it causes certain system functions to be hidden on some (BSD) systems. > The solution is to only add the flag on systems that really require it, i.e. > glibc-based ones. > > This change make

Re: [libav-devel] [PATCH] MP3 file contains the string NSVs, the NSV probe will think it is a NSV file instead of a MP3 file. Check for 0xBEEF after a Video/Audio chunck for more accuracy

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 10:51:31AM +0200, Benjamin Larsson wrote: > > Looks ok. Queued. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 4/5] oggdec: simplify ogg_probe

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 09:34:23AM +0100, Måns Rullgård wrote: > Clément Bœsch writes: > > --- a/libavformat/oggdec.c > > +++ b/libavformat/oggdec.c > > @@ -631,12 +631,9 @@ static int ogg_read_seek(AVFormatContext *s, int > > stream_index, > > > > static int ogg_probe(AVProbeData *p) > > { >

Re: [libav-devel] [PATCH 5/5] oggdec: use explicit AVInputFormat struct initializers

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 09:35:05AM +0100, Måns Rullgård wrote: > Clément Bœsch writes: > > --- a/libavformat/oggdec.c > > +++ b/libavformat/oggdec.c > > @@ -637,15 +637,15 @@ static int ogg_probe(AVProbeData *p) > > > > AVInputFormat ff_ogg_demuxer = { > > -"ogg", > > -NULL_IF_CONFIG_SM

Re: [libav-devel] [PATCH] tiff: add support to TIFF_SAMPLES_PER_PIXEL case in tiff_decode_tag()

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 10:35:20AM +0200, Kostya wrote: > On Mon, May 09, 2011 at 12:51:24PM +0200, Stefano Sabatini wrote: > > Format detection and internal frame initialization is moved to a > > separate init_image() function, which is called when all the tags have > > been read, and so both Bits

Re: [libav-devel] [PATCH 3/3] jfdct: Replace sized int_fast integer types with plain int/unsigned.

2011-05-12 Thread Kostya
On Fri, Apr 29, 2011 at 08:17:43PM +0200, Diego Biurrun wrote: > int/unsigned is the natural memory access type for CPUs, using sized types > for temporary variables, counters and similar just increases code size and > can possibly cause a slowdown. > --- > libavcodec/jfdctfst.c | 18 +--

Re: [libav-devel] [PATCH 2/2] Replace int_fast integer types with their sized standard posix counterparts.

2011-05-12 Thread Kostya
On Fri, Apr 29, 2011 at 04:08:20PM +0200, Diego Biurrun wrote: > The _fast integer types provide no realworld benefits, but may introduce > portability issues and are just plain ugly. > --- > libavcodec/cavs.h | 11 ++-- > libavcodec/cavsdata.h |8 +- > libavcodec/ffv1.c | 31 ++

Re: [libav-devel] [PATCH 1/5] oggdec: fix memleak with continuous streams.

2011-05-12 Thread Luca Barbato
On 5/11/11 8:43 PM, Clément Bœsch wrote: This avoids the creation of a new AVStream instead of replacing it when a stream reset occurs (track change with some webradios for example). --- libavformat/oggdec.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) I think it should

Re: [libav-devel] [RFC] fix swscale for 9/10bit

2011-05-12 Thread Ronald S. Bultje
Hi, On Thu, May 12, 2011 at 4:55 AM, Kostya wrote: > On Wed, May 11, 2011 at 01:20:26PM -0400, Ronald S. Bultje wrote: >> Hi again, >> >> On Wed, May 11, 2011 at 12:07 PM, Ronald S. Bultje >> wrote: >> > On Wed, May 11, 2011 at 11:59 AM, Ronald S. Bultje >> > wrote: >> >> On Wed, May 11, 2011

Re: [libav-devel] [PATCH 2/5] oggdec: reindent after previous commit

2011-05-12 Thread Diego Biurrun
On Wed, May 11, 2011 at 08:43:28PM +0200, Clément Bœsch wrote: > --- > libavformat/oggdec.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) OK Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/

Re: [libav-devel] [PATCH 3/5] Cosmetics: fix prototypes in oggdec

2011-05-12 Thread Diego Biurrun
On Wed, May 11, 2011 at 08:43:29PM +0200, Clément Bœsch wrote: > --- > libavformat/oggdec.c | 51 + > 1 files changed, 18 insertions(+), 33 deletions(-) OK Diego ___ libav-devel mailing list libav-devel

Re: [libav-devel] [PATCH] configure: Do not unconditionally add -D_POSIX_C_SOURCE to CPPFLAGS.

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 11:01:05AM +0200, Diego Biurrun wrote: > [...] Pushed after testing on glibc, FreeBSD and OS X. FATE will catch remaining issues. Experience tell me that there likely will be some... Diego ___ libav-devel mailing list libav-dev

Re: [libav-devel] [PATCH 1/5] oggdec: fix memleak with continuous streams.

2011-05-12 Thread Diego Biurrun
On Wed, May 11, 2011 at 08:43:27PM +0200, Clément Bœsch wrote: > [...] I will push the whole patchset in a moment. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] ffmpeg.c: fix seting of decode_interrupt_cb().

2011-05-12 Thread Måns Rullgård
Anton Khirnov writes: > On Thu, 12 May 2011 09:41:05 +0100, Måns Rullgård wrote: >> Anton Khirnov writes: >> >> > From: Michael Niedermayer >> >> This isn't his patch anymore, is it? >> >> > Signed-off-by: Anton Khirnov >> > --- >> > ffmpeg.c |5 ++--- >> > 1 files changed, 2 insertio

[libav-devel] [PATCH] configure: Enable libpostproc automatically if GPL code is enabled.

2011-05-12 Thread Diego Biurrun
Enabling libpostproc automatically should give it more compile coverage and save the FATE box maintainers some configuration hassles. --- configure |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure b/configure index d551379..f1037ee 100755 --- a/configure +++ b/co

Re: [libav-devel] [PATCH] configure: Enable libpostproc automatically if GPL code is enabled.

2011-05-12 Thread Måns Rullgård
Diego Biurrun writes: > Enabling libpostproc automatically should give it more compile coverage > and save the FATE box maintainers some configuration hassles. > --- > configure |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index d551379..

Re: [libav-devel] [PATCH] configure: Enable libpostproc automatically if GPL code is enabled.

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 01:21:49PM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > > Enabling libpostproc automatically should give it more compile coverage > > and save the FATE box maintainers some configuration hassles. > > > > --- a/configure > > +++ b/configure > > @@ -1802,6 +1802,8

[libav-devel] [PATCH] mov: Support edit list atom version 1.

2011-05-12 Thread Yusuke Nakamura
Attached patch fixes detecting wrong timestamps on large presentation indicated by edit list atom. 0001-mov-Support-edit-list-atom-version-1.patch Description: Binary data ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailma

Re: [libav-devel] [PATCH] configure: Enable libpostproc automatically if GPL code is enabled.

2011-05-12 Thread Måns Rullgård
Diego Biurrun writes: > On Thu, May 12, 2011 at 01:21:49PM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> >> > Enabling libpostproc automatically should give it more compile coverage >> > and save the FATE box maintainers some configuration hassles. >> > >> > --- a/configure >> > +++ b

Re: [libav-devel] [PATCH] ffmpeg: factorize quality calculation

2011-05-12 Thread Luca Barbato
On 5/12/11 7:07 AM, Anton Khirnov wrote: From: Michael Niedermayer Calculate quality value once per stream in print_report(). Also fix segfault, as coded_frame can be NULL. Seems ok ___ libav-devel mailing list libav-devel@libav.org https://lists.lib

Re: [libav-devel] [PATCH] mov: Support edit list atom version 1.

2011-05-12 Thread Benjamin Larsson
On 05/12/2011 02:32 PM, Yusuke Nakamura wrote: > Attached patch fixes detecting wrong timestamps on large presentation > indicated by edit list atom. > Patch OK MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.lib

Re: [libav-devel] [PATCH] configure: Enable libpostproc automatically if GPL code is enabled.

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 01:36:27PM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > > On Thu, May 12, 2011 at 01:21:49PM +0100, Måns Rullgård wrote: > >> Diego Biurrun writes: > >> > >> > Enabling libpostproc automatically should give it more compile coverage > >> > and save the FATE box

Re: [libav-devel] [PATCH] configure: Enable libpostproc automatically if GPL code is enabled.

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 02:48:06PM +0200, Diego Biurrun wrote: > On Thu, May 12, 2011 at 01:36:27PM +0100, Måns Rullgård wrote: > > Diego Biurrun writes: > > > > > On Thu, May 12, 2011 at 01:21:49PM +0100, Måns Rullgård wrote: > > >> Diego Biurrun writes: > > >> > > >> > Enabling libpostproc au

Re: [libav-devel] [PATCH] configure: Enable libpostproc automatically if GPL code is enabled.

2011-05-12 Thread Måns Rullgård
Diego Biurrun writes: > On Thu, May 12, 2011 at 01:36:27PM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> >> > On Thu, May 12, 2011 at 01:21:49PM +0100, Måns Rullgård wrote: >> >> Diego Biurrun writes: >> >> >> >> > Enabling libpostproc automatically should give it more compile cover

Re: [libav-devel] [PATCH] mov: Support edit list atom version 1.

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 02:46:54PM +0200, Benjamin Larsson wrote: > > On 05/12/2011 02:32 PM, Yusuke Nakamura wrote: > > Attached patch fixes detecting wrong timestamps on large presentation > > indicated by edit list atom. > > Patch OK Queued, will push if/when FATE passes. Diego _

Re: [libav-devel] [PATCH 21/21] mpegvideo: make FF_DEBUG_DCT_COEFF output coeffs via av_log() instead of just via AVFrame.

2011-05-12 Thread Ronald S. Bultje
Hi, On Thu, May 12, 2011 at 1:56 AM, Anton Khirnov wrote: > From: Michael Niedermayer > > This allows the values to be used without changing C code and is closer to how > the other DEBUG flags work. > > Signed-off-by: Anton Khirnov > --- >  libavcodec/mpegvideo.c |    9 +++-- >  1 files cha

Re: [libav-devel] [PATCH 14/21] lavf: fix function name in compute_pkt_fields2 av_dlog message

2011-05-12 Thread Ronald S. Bultje
Hi, On Thu, May 12, 2011 at 1:56 AM, Anton Khirnov wrote: > From: Stefano Sabatini > > Signed-off-by: Anton Khirnov > --- >  libavformat/utils.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) OK. Ronald ___ libav-devel mailing list li

Re: [libav-devel] [PATCH 20/21] srtdec: make sure we don't write past the end of buffer

2011-05-12 Thread Ronald S. Bultje
Hi, On Thu, May 12, 2011 at 1:56 AM, Anton Khirnov wrote: > From: Aurelien Jacobs > > Signed-off-by: Aurelien Jacobs > Signed-off-by: Anton Khirnov > --- >  libavcodec/srtdec.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) OK. Ronald __

[libav-devel] [PATCH] asfdec: fix possible overread on broken files.

2011-05-12 Thread Ronald S. Bultje
From: Uoti Urpala --- libavformat/asfdec.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index 77c8449..3dc104e 100644 --- a/libavformat/asfdec.c +++ b/libavformat/asfdec.c @@ -852,7 +852,10 @@ static int asf_read_frame_h

[libav-devel] [PATCH] Update pixdesc_be fate refs after adding 9/10bit YUV420P formats.

2011-05-12 Thread Ronald S. Bultje
--- tests/ref/lavfi/pixdesc_be |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/tests/ref/lavfi/pixdesc_be b/tests/ref/lavfi/pixdesc_be index 799507e..aa20a32 100644 --- a/tests/ref/lavfi/pixdesc_be +++ b/tests/ref/lavfi/pixdesc_be @@ -27,8 +27,12 @@ uyvy422

Re: [libav-devel] [PATCH 12/21] lavf: fix av_find_best_stream when decoder_ret is given and using a related stream.

2011-05-12 Thread Justin Ruggles
On 05/12/2011 01:56 AM, Anton Khirnov wrote: > From: Marton Balint > > Yet another fix for the code originally designed for use without > related_stream. > > Signed-off-by: Michael Niedermayer > Signed-off-by: Anton Khirnov > --- > libavformat/utils.c |2 +- > 1 files changed, 1 inserti

Re: [libav-devel] [PATCH 13/21] lavf: fix av_find_best_stream when providing a wanted stream.

2011-05-12 Thread Justin Ruggles
On 05/12/2011 01:56 AM, Anton Khirnov wrote: > From: Marton Balint > > In the main loop, stream_number is incremented after checking the stream type, > so the search usually will not find the wanted stream. > > This patch eliminates the useless stream_number variable and introduces a new > one,

[libav-devel] [PATCH] arm: properly mark external symbol call

2011-05-12 Thread Martin Aumüller
Surround ff_vp8_dct_cat_prob by X() in order to fix iOS build --- libavcodec/arm/vp8_armv6.S |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/arm/vp8_armv6.S b/libavcodec/arm/vp8_armv6.S index 88fa398..11d3521 100644 --- a/libavcodec/arm/vp8_armv6.S +++ b/libavc

[libav-devel] iOS/arm-macosx fixes

2011-05-12 Thread Martin Aumüller
I found another missing X() during a recent iOS build. BTW, what is the known bug in gas-preprocessor? At first, I also had· problems, but a small addition made it build - I didn't check the· correctness of the result, however. See http://github.com/yuvi/gas-preprocessor/pull/9 Regards, Martin _

Re: [libav-devel] [PATCH] Avoid divide by zero in compute_avg_bitrate()

2011-05-12 Thread Ronald S. Bultje
Hi, On Wed, May 11, 2011 at 8:25 AM, Tomas Härdin wrote: > The attached patch fixes a possibility for movenc.c to SIGFPE if > trackDuration is zero when writing esds. This can happen if the user manages > to mux a single AAC packet with dts = 0 and duration = 0. This patch does not apply to my l

Re: [libav-devel] [PATCH 16/21] matroskadec: check that pointers were initialized before accessing them

2011-05-12 Thread Justin Ruggles
On 05/12/2011 01:56 AM, Anton Khirnov wrote: > From: Aurelien Jacobs > > Signed-off-by: Aurelien Jacobs > Signed-off-by: Anton Khirnov > --- > libavformat/matroskadec.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavforma

Re: [libav-devel] [PATCH] Update pixdesc_be fate refs after adding 9/10bit YUV420P formats.

2011-05-12 Thread Måns Rullgård
"Ronald S. Bultje" writes: > --- > tests/ref/lavfi/pixdesc_be |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/tests/ref/lavfi/pixdesc_be b/tests/ref/lavfi/pixdesc_be > index 799507e..aa20a32 100644 > --- a/tests/ref/lavfi/pixdesc_be > +++ b/tests/ref/lavfi/pixdes

Re: [libav-devel] [PATCH] Update pixdesc_be fate refs after adding 9/10bit YUV420P formats.

2011-05-12 Thread Ronald S. Bultje
Hi, 2011/5/12 Måns Rullgård : > "Ronald S. Bultje" writes: > >> --- >>  tests/ref/lavfi/pixdesc_be |    4 >>  1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/tests/ref/lavfi/pixdesc_be b/tests/ref/lavfi/pixdesc_be >> index 799507e..aa20a32 100644 >> --- a/tests/ref/lavfi/

Re: [libav-devel] [PATCH 18/21] matroskaenc: make sure we don't produce invalid file with no codec ID

2011-05-12 Thread Justin Ruggles
On 05/12/2011 01:56 AM, Anton Khirnov wrote: > From: Aurelien Jacobs > > Signed-off-by: Aurelien Jacobs > Signed-off-by: Anton Khirnov > --- > libavformat/matroskaenc.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/ma

Re: [libav-devel] [PATCH 19/21] wmaenc: improve channel count and bitrate error handling in encode_init()

2011-05-12 Thread Justin Ruggles
On 05/12/2011 01:56 AM, Anton Khirnov wrote: > From: Tomas Härdin > > Signed-off-by: Michael Niedermayer > Signed-off-by: Anton Khirnov > --- > libavcodec/wmaenc.c | 16 +++- > 1 files changed, 11 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/wmaenc.c b/libavcodec/w

Re: [libav-devel] [PATCH] Avoid divide by zero in compute_avg_bitrate()

2011-05-12 Thread Tomas Härdin
Ronald S. Bultje skrev 2011-05-12 16:36: Hi, On Wed, May 11, 2011 at 8:25 AM, Tomas Härdin wrote: The attached patch fixes a possibility for movenc.c to SIGFPE if trackDuration is zero when writing esds. This can happen if the user manages to mux a single AAC packet with dts = 0 and duration =

Re: [libav-devel] [PATCH] arm: properly mark external symbol call

2011-05-12 Thread Luca Barbato
On 5/12/11 4:35 PM, Martin Aumüller wrote: Surround ff_vp8_dct_cat_prob by X() in order to fix iOS build --- libavcodec/arm/vp8_armv6.S |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/arm/vp8_armv6.S b/libavcodec/arm/vp8_armv6.S index 88fa398..11d3521 10064

Re: [libav-devel] iOS/arm-macosx fixes

2011-05-12 Thread Luca Barbato
On 5/12/11 4:34 PM, Martin Aumüller wrote: I found another missing X() during a recent iOS build. BTW, what is the known bug in gas-preprocessor? At first, I also had· problems, but a small addition made it build - I didn't check the· correctness of the result, however. See http://github.com/yuv

[libav-devel] [PATCH] ffmpeg: get rid of the 'q' key schizofrenia

2011-05-12 Thread Anton Khirnov
SIGINT for quitting should be enough for everybody. --- configure |2 -- ffmpeg.c | 39 +++ 2 files changed, 3 insertions(+), 38 deletions(-) diff --git a/configure b/configure index d551379..676cb57 100755 --- a/configure +++ b/configure @@ -1069,7 +106

Re: [libav-devel] [PATCH 01/21] configure: sort filter deps entries

2011-05-12 Thread Reinhard Tartler
On Thu, May 12, 2011 at 07:56:05 (CEST), Anton Khirnov wrote: > From: Stefano Sabatini > > Signed-off-by: Anton Khirnov > --- > configure |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure b/configure > index 955a568..ac2a7eb 100755 > --- a/configure > +++

[libav-devel] FATE review

2011-05-12 Thread Diego Biurrun
Now that I have finally fixed the BSD CPPFLAGS issues in a clean way I believe it is time to review our FATE configurations again and possibly unify them. First off, it would be great to have a Cygwin FATE configuration again. People do use Cygwin and we would profit from timely notification of br

Re: [libav-devel] [PATCH] ffmpeg: get rid of the 'q' key schizofrenia

2011-05-12 Thread Luca Barbato
On 5/12/11 5:24 PM, Anton Khirnov wrote: SIGINT for quitting should be enough for everybody. --- configure |2 -- ffmpeg.c | 39 +++ 2 files changed, 3 insertions(+), 38 deletions(-) Seems good. ___ libav

Re: [libav-devel] [PATCH] tiff: add support to TIFF_SAMPLES_PER_PIXEL case in tiff_decode_tag()

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 11:47:03AM +0200, Diego Biurrun wrote: > On Thu, May 12, 2011 at 10:35:20AM +0200, Kostya wrote: > > On Mon, May 09, 2011 at 12:51:24PM +0200, Stefano Sabatini wrote: > > > Format detection and internal frame initialization is moved to a > > > separate init_image() function,

Re: [libav-devel] [PATCH] ffmpeg: get rid of the 'q' key schizofrenia

2011-05-12 Thread Diego Biurrun
On Thu, May 12, 2011 at 05:24:46PM +0200, Anton Khirnov wrote: > SIGINT for quitting should be enough for everybody. I'm not opposed, this patch does get rid of some crufty code, but I would suggest you update the changelog to notify users and make sure the docs do not mention the key anywhere. D

[libav-devel] [PATCH] Announcement for 0.7_beta2

2011-05-12 Thread Reinhard Tartler
--- src/download | 18 +- src/index| 16 2 files changed, 25 insertions(+), 9 deletions(-) diff --git a/src/download b/src/download index 4a0adf5..4180b67 100644 --- a/src/download +++ b/src/download @@ -145,7 +145,7 @@ and much faster bug fixes such as ad

Re: [libav-devel] [PATCH] Announcement for 0.7_beta2

2011-05-12 Thread Rob
On 12 May 2011 18:14, Reinhard Tartler wrote: [...] > diff --git a/src/index b/src/index > index ffbad50..e841eab 100644 > --- a/src/index > +++ b/src/index > @@ -35,6 +35,22 @@ with the latest developments by subscribing to both the > >  News > > + > +May 12 2011 > + > + > +We are happy to anno

Re: [libav-devel] [PATCH 10/18] ffmpeg: use parse_number_and_die() when it makes sense

2011-05-12 Thread Ronald S. Bultje
Hi, On Thu, May 12, 2011 at 1:16 AM, Anton Khirnov wrote: > Prefer parse_number_or_die() over atoi()/atol() parsing for the options: > -pass, -top, -vc, and -qscale. > > Improve input validation. > > Signed-off-by: Stefano Sabatini > Signed-off-by: Anton Khirnov > --- >  ffmpeg.c |   39 +++

Re: [libav-devel] [PATCH/RFC] fps probsize

2011-05-12 Thread Aℓex Converse
2011/5/9 Aℓex Converse : > The attached patch adds a command line option "-fpsprobesize" to > specify the number of frames used in fps estimation. > > Currently some 29.97 fps FLV files are detected as 59.92 fps. > > Feel free to play with this spreadsheet to understand the issue: > > https://sprea

[libav-devel] FATE review

2011-05-12 Thread Sean McGovern
> * sparc64 + x86_32 / sunos > > Here --extra-libs=/usr/lib/64/values-xpg6.o gets added.  I wonder if this > is still necessary and/or if we can do it in configure. This is a subject of considerable controversy within the GCC team. Sun's documentation indicates the values-xpg6.o must be linked in

Re: [libav-devel] FATE review

2011-05-12 Thread Mike Melanson
> First off, it would be great to have a Cygwin FATE configuration again. > People do use Cygwin and we would profit from timely notification of > breakage. I just got a new Windows machine and I might be able to make this happen. I hope it's not too hard. -- -Mike Melanson _

Re: [libav-devel] [PATCH 09/21] movenc: always write esds descriptor length using 4 bytes.

2011-05-12 Thread Aℓex Converse
On Wed, May 11, 2011 at 10:56 PM, Anton Khirnov wrote: > From: Baptiste Coudurier > > ipod shuffle doesn't support anything else. > > Signed-off-by: Anton Khirnov > --- >  libavformat/movenc.c    |   14 +++--- >  tests/ref/lavf/mov      |    4 ++-- >  tests/ref/vsynth1/mpeg4 |    4 ++--

Re: [libav-devel] FATE review

2011-05-12 Thread Martin Storsjö
On Thu, 12 May 2011, Diego Biurrun wrote: > * freedos > > With a bit of luck '-U__STRICT_ANSI__' can be dropped now, please test. Don't think it can be dropped. I've got a djgpp setup and tested it now, and it fails on error codes. They define them like this: #ifndef __STRICT_ANSI__ #define EA

[libav-devel] [PATCH] rtpdec_qdm2: Don't try to parse data packet if no configuration is received

2011-05-12 Thread Martin Storsjö
The later parsing of payload data depends on the configuration being present. If it hasn't been configured properly yet, parsing a data packet may lead to a crash. --- libavformat/rtpdec_qdm2.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libavformat/rtpdec_qdm2.c b/li

Re: [libav-devel] [PATCH] rtpdec_qdm2: Don't try to parse data packet if no configuration is received

2011-05-12 Thread Ronald S. Bultje
Hi, On Thu, May 12, 2011 at 3:49 PM, Martin Storsjö wrote: > The later parsing of payload data depends on the configuration > being present. If it hasn't been configured properly yet, > parsing a data packet may lead to a crash. > --- >  libavformat/rtpdec_qdm2.c |    2 ++ >  1 files changed, 2 i

Re: [libav-devel] [PATCH] Update pixdesc_be fate refs after adding 9/10bit YUV420P formats.

2011-05-12 Thread Ronald S. Bultje
Hi, 2011/5/12 Måns Rullgård : > "Ronald S. Bultje" writes: >> --- >>  tests/ref/lavfi/pixdesc_be |    4 >>  1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/tests/ref/lavfi/pixdesc_be b/tests/ref/lavfi/pixdesc_be >> index 799507e..aa20a32 100644 >> --- a/tests/ref/lavfi/pi

Re: [libav-devel] FATE review

2011-05-12 Thread Brad
On 12/05/11 11:30 AM, Diego Biurrun wrote: * sparc64 / openbsd This configuration adds --disable-pthreads to the configure line. Why? OpenBSD ports has never built any arch without pthreads and this is definitely not necessary. Also I'm not sure how to contact the person whom maintains th

[libav-devel] [PATCH 1/2] svq3: only allocate tables after size is known.

2011-05-12 Thread Ronald S. Bultje
The size could not be specified, as is the case in RTP/SVQ3, in which case they don't init at the right size, leading to crashes later. --- libavcodec/svq3.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index 1e4c

[libav-devel] [PATCH 2/2] h264: fix loopfilter with slice-threading enabled.

2011-05-12 Thread Ronald S. Bultje
If deblock_mode==2, we should deblock slice edges also. This can obviously only be done once all slices have finished decoding. --- libavcodec/h264.c | 23 +-- 1 files changed, 17 insertions(+), 6 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 616d0a4.

Re: [libav-devel] [FFmpeg-devel] [PATCH] tiff: print warning in case of unknown / unsupported tag

2011-05-12 Thread Stefano Sabatini
On date Monday 2011-05-09 22:38:55 +0200, Michael Niedermayer encoded: > On Mon, May 09, 2011 at 10:27:55PM +0200, Stefano Sabatini wrote: > > --- > > libavcodec/tiff.c |2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > LGTM Updated, added libav-devel to recipients. >From ba93fc

Re: [libav-devel] [FFmpeg-devel] [PATCH] tiff: fix linesize for mono-pixel formats

2011-05-12 Thread Stefano Sabatini
On date Tuesday 2011-05-10 02:58:40 +0200, Michael Niedermayer encoded: > On Mon, May 09, 2011 at 10:28:17PM +0200, Stefano Sabatini wrote: > > Fix decoding of file Test_1bpp.tif, trac issue #171. > > --- > > libavcodec/tiff.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > LG

Re: [libav-devel] [PATCH 3/3] Restructure video filter implementation in ffmpeg.c.

2011-05-12 Thread Aℓex Converse
On Wed, May 11, 2011 at 4:39 PM, Alex Converse wrote: > > From: Michael Niedermayer > > This fixes several bugs like multiple outputs and -aspect mixed with -vf > > (cherry picked from commit 1762d9ced70ccc46c5d3e5d64e56a48d0fbbd4f7) > (cherry picked from commit a7844c580d83d8466c161a0e3979b3902d

[libav-devel] [PATCH 4/3] ffmpeg: fix -aspect cli option

2011-05-12 Thread Alex Converse
From: Baptiste Coudurier Redesign the way -aspect option is handled. This is done by making ffmpeg read the sample aspect ratio set in the corresponding input stream by default, and overriding it using the value specified by -aspect. If the output display aspect ratio is specified with -aspect,

Re: [libav-devel] [FFmpeg-devel] [PATCH] tiff: print warning in case of unknown / unsupported tag

2011-05-12 Thread Stefano Sabatini
On date Friday 2011-05-13 00:19:07 +0200, Stefano Sabatini encoded: > On date Monday 2011-05-09 22:38:55 +0200, Michael Niedermayer encoded: > > On Mon, May 09, 2011 at 10:27:55PM +0200, Stefano Sabatini wrote: > > > --- > > > libavcodec/tiff.c |2 ++ > > > 1 files changed, 2 insertions(+), 0

Re: [libav-devel] [PATCH 2/2] h264: fix loopfilter with slice-threading enabled.

2011-05-12 Thread Ronald S. Bultje
Hi, On Thu, May 12, 2011 at 5:53 PM, Ronald S. Bultje wrote: > If deblock_mode==2, we should deblock slice edges also. This > can obviously only be done once all slices have finished > decoding. > --- >  libavcodec/h264.c |   23 +-- >  1 files changed, 17 insertions(+), 6 dele

Re: [libav-devel] [FFmpeg-devel] [Announcement] FFmtech board of directors election

2011-05-12 Thread compn
On Mon, 09 May 2011 23:50:49 +0200, Benjamin Larsson wrote: >Hi, it's time to elect a new board for the FFmtech foundation. If you >want to candidate or participate in electing the new board then please >respond to this email. To be eligible for this you must fulfil the >following. > >"People who h

Re: [libav-devel] [PATCH] Add an aac sample which uses LTP to fate-aac.

2011-05-12 Thread Aℓex Converse
On Mon, May 9, 2011 at 3:42 PM, Ronald S. Bultje wrote: > Hi, > > 2011/5/9 Måns Rullgård : >> "Ronald S. Bultje" writes: >> >>> Hi, >>> >>> 2011/4/26 Måns Rullgård : Justin Ruggles writes: > --- > Sample and reference uploaded to fate-suite.libav.org today. My samples

Re: [libav-devel] FATE review

2011-05-12 Thread Dave Yeo
On 05/12/11 08:30 am, Diego Biurrun wrote: Now that I have finally fixed the BSD CPPFLAGS issues in a clean way I believe it is time to review our FATE configurations again and possibly unify them. [...] There are some FATE configurations that use --disable-debug and some that use --enable-shar

Re: [libav-devel] [PATCH 2/2] h264: fix loopfilter with slice-threading enabled.

2011-05-12 Thread Ronald S. Bultje
Hi, On Thu, May 12, 2011 at 8:39 PM, Ronald S. Bultje wrote: > On Thu, May 12, 2011 at 5:53 PM, Ronald S. Bultje wrote: >> If deblock_mode==2, we should deblock slice edges also. This >> can obviously only be done once all slices have finished >> decoding. >> --- >>  libavcodec/h264.c |   23 +++

[libav-devel] [PATCH] lavc: remove msmpeg4v1 encoder.

2011-05-12 Thread Anton Khirnov
The encoder has never produced files that could be decoded with any software and there should be no reason to create such files anyway. --- libavcodec/Makefile|2 -- libavcodec/allcodecs.c |2 +- libavcodec/mpegvideo_enc.c | 21 - libavcodec/msmpeg4.h