http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode1304
scripts/build/output-distance.py:1304: if len (args) % 2 == 1:
why is there a
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode1304
scripts/build/output-distance.py:1304: if len (args) % 2 == 1:
On 2011/11/07
On 2011/11/07 09:15:04, dak wrote:
Uh, yes? See line 1313: the argument list consists of an arbitrary
number of _pairs_.
Right - it's comparing (baseline, check) pairs. I didn't introduce the
modulo, I just made it explicit which is more legible than relying on
Python's interpretation of 0
On 2011/11/07 00:15:48, Graham Percival wrote:
On Sun, Nov 06, 2011 at 03:52:15PM +, mailto:adam.spi...@gmail.com
wrote:
I've done a corresponding patch for changes.tely but I don't have
permissions to upload it to this issue
that's because Janek uploaded the original issue. Could
Thanks Carl, I've made these changes, and I've also made a corresponding
patch for changes.tely, but I don't think I have permission to upload
new patch sets for either to this issue since it says Can't Edit at
the top-left - can you give me permission? (If not, this is yet another
reason
On Mon, Nov 07, 2011 at 11:56:42AM +, adam.spi...@gmail.com wrote:
Thanks Carl, I've made these changes, and I've also made a corresponding
patch for changes.tely, but I don't think I have permission to upload
new patch sets for either to this issue since it says Can't Edit at
the top-left
m...@apollinemike.com m...@apollinemike.com writes:
I guess because we are not indicating a grob i.e.
c-\autoFootnote #'(1 . -1.25)
vs
\autoFootnote #'NoteHead #'(1 . -1.25)
c4
Which does the same thing.
Mike any comment on this?
On Mon, Nov 7, 2011 at 12:12 PM, Graham Percival
gra...@percival-music.ca wrote:
On Mon, Nov 07, 2011 at 11:56:42AM +, adam.spi...@gmail.com wrote:
Thanks Carl, I've made these changes, and I've also made a corresponding
patch for changes.tely, but I don't think I have permission to upload
On Nov 7, 2011, at 5:34 AM, Adam Spiers adam.spi...@gmail.com wrote:
On Mon, Nov 7, 2011 at 12:12 PM, Graham Percival
gra...@percival-music.ca wrote:
On Mon, Nov 07, 2011 at 11:56:42AM +, adam.spi...@gmail.com wrote:
Thanks Carl, I've made these changes, and I've also made a
On Mon, Nov 07, 2011 at 12:44:42PM +, Carl Sorensen wrote:
I'll get the update posted today. For this patch, I'm serving as
adam's frog meister since last Thursday.
Adam is a very experienced developer, and he already knows how to
use git-cl. He's even patched it! He's not a frog, so
On Mon, Nov 7, 2011 at 2:11 PM, Graham Percival
gra...@percival-music.ca wrote:
On Mon, Nov 07, 2011 at 12:34:15PM +, Adam Spiers wrote:
On Mon, Nov 7, 2011 at 12:12 PM, Graham Percival
gra...@percival-music.ca wrote:
I doubt it. Just upload a new issue.
So then we would have *three*
On Mon, Nov 7, 2011 at 2:13 PM, Graham Percival
gra...@percival-music.ca wrote:
On Mon, Nov 07, 2011 at 12:44:42PM +, Carl Sorensen wrote:
I'll get the update posted today. For this patch, I'm serving as
adam's frog meister since last Thursday.
Adam is a very experienced developer, and he
On Mon, Nov 07, 2011 at 02:44:01PM +, Adam Spiers wrote:
On Mon, Nov 7, 2011 at 2:11 PM, Graham Percival
gra...@percival-music.ca wrote:
The google code issue is our pointer. Rietveld is our memory. We
Sure, but it's the de-referencing which worries me for two reasons:
1. These
Only stylistic comments:
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode8
scripts/build/output-distance.py:8: from cgi import
The below error was caused by 'make -j2 doc' on a fresh build tree -
any ideas?
/home/adam/.GIT/3rd-party/lilypond/build/scripts/build/out/extract_texi_filenames
-I ./out-www -I /home/adam/music/software/lilypond.git/Documentation
-I /home/adam/music/software/lilypond.git/Documentation -o
- Original Message -
From: Adam Spiers lilypond-de...@adamspiers.org
To: lilypond-devel@gnu.org
Sent: Monday, November 07, 2011 5:00 PM
Subject: make doc failure on fresh build tree
The below error was caused by 'make -j2 doc' on a fresh build tree -
any ideas?
Hello,
On Mon, Nov 7, 2011 at 5:14 PM, Phil Holmes m...@philholmes.net wrote:
- Original Message - From: Adam Spiers
lilypond-de...@adamspiers.org
To: lilypond-devel@gnu.org
Sent: Monday, November 07, 2011 5:00 PM
Subject: make doc failure on fresh build tree
The below error was
On 2011/11/06 21:30:18, adam.spiers wrote:
I disagree - there is no way to be sure that the cause of the
StopIteration
really was the user failing to run make test-baseline first. For
example he
could have run it but then something else accidentally (or
deliberately) deleted
those
- Original Message -
From: Peekay Ex pkx1...@gmail.com
To: Phil Holmes m...@philholmes.net; Adam Spiers
lilypond-de...@adamspiers.org
Cc: lilypond-devel@gnu.org
Sent: Monday, November 07, 2011 5:26 PM
Subject: Re: make doc failure on fresh build tree
Hello,
On Mon, Nov 7, 2011 at
On Sun, 06 Nov 2011 23:34:37 -0800, mts...@gmail.com wrote:
http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc#newcode96
lily/pure-from-neighbor-interface.cc:96: (grace == LEFT ? has_grace :
!has_grace))
On 2011/11/07 01:25:30, Keith wrote:
In fact, why even
Please close this issue as it's now superceded by
http://codereview.appspot.com/5343050/ - thanks!
http://codereview.appspot.com/5320074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
New version attached.
http://codereview.appspot.com/5361042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Mon, Nov 07, 2011 at 05:00:23PM +, Adam Spiers wrote:
extract_texi_filenames.py: Processing out-www/snippets.texi
Traceback (most recent call last):
File
/home/adam/.GIT/3rd-party/lilypond/build/scripts/build/out/extract_texi_filenames,
line 304, in module
Traceback (most recent
On 7 November 2011 19:32, Graham Percival gra...@percival-music.ca wrote:
Failing either of these, I guess we're into git bisect time, which
of course sucks for doc-building if you're not Phil or James. I
know that Phil can build the docs, but hopefully James' computer
will fail in this same
On Nov 7, 2011, at 10:46 AM, Keith OHara wrote:
This is saying if the closest column is a grace-note-column, include
the next-closest column as well. This gets rid of any accidental
overlap problems at the expense of potentially adding a little extra
vertical space to the page-spacer
On Mon, Nov 7, 2011 at 7:34 PM, Neil Puttock n.putt...@gmail.com wrote:
On 7 November 2011 19:32, Graham Percival gra...@percival-music.ca wrote:
Failing either of these, I guess we're into git bisect time, which
of course sucks for doc-building if you're not Phil or James. I
know that Phil
I am not in favor of the tab-to-space change in
scm/chord-ignatzek-names.scm, since we don't yet have agreement on
removing tabs from .scm files, AFAICS.
However, if nobody else is worried about it, I won't complain. I'd
prefer to have the tabs gone. And if we can do it through the backdoor,
Passes make but two reg test diffs - see
http://code.google.com/p/lilypond/issues/detail?id=1503#c32
James
http://codereview.appspot.com/5343050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Passes Make and no reg test diffs.
James
http://codereview.appspot.com/5361042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
passes make and no reg test diffs.
james
http://codereview.appspot.com/5342042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Passes make but lots of reg test diffs as usual
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-7-Nov-2011-td4962666.html
Jame
http://codereview.appspot.com/5323062/
___
lilypond-devel mailing list
On Mon, Nov 07, 2011 at 08:13:46PM +, carl.d.soren...@gmail.com wrote:
I am not in favor of the tab-to-space change in
scm/chord-ignatzek-names.scm, since we don't yet have agreement on
removing tabs from .scm files, AFAICS.
True, but I assume that other parts of the patch set depend on
On Mon, Nov 7, 2011 at 9:13 PM, Graham Percival
gra...@percival-music.ca wrote:
On Mon, Nov 07, 2011 at 08:13:46PM +, carl.d.soren...@gmail.com wrote:
I am not in favor of the tab-to-space change in
scm/chord-ignatzek-names.scm, since we don't yet have agreement on
removing tabs from .scm
New patchset uploaded
http://codereview.appspot.com/4941041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Adam Spiers adam.spi...@gmail.com writes:
On Mon, Nov 7, 2011 at 9:13 PM, Graham Percival
gra...@percival-music.ca wrote:
On Mon, Nov 07, 2011 at 08:13:46PM +, carl.d.soren...@gmail.com wrote:
I am not in favor of the tab-to-space change in
scm/chord-ignatzek-names.scm, since we don't
On Mon, Nov 7, 2011 at 10:11 PM, David Kastrup d...@gnu.org wrote:
In this case, the damage is already done, so there seems little point in
investing the effort for trying to get back again.
Especially considering my first patch submission did *not* have
gratuitous whitespace changes, and I
Make passes but make check fails on
\sourcefilename
/home/jlowe/lilypond-git/input/regression/beamlet-point-toward-beat.ly
\sourcefileline 0
\version 2.15.17
\header {
\texidoc =
Beamlets should point in the direction of the beat to which they
belong.
}
\relative c' {
b16. b32 b32 b16.
New patch set
http://codereview.appspot.com/4941041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 11/7/11 2:48 PM, Adam Spiers adam.spi...@gmail.com wrote:
On Mon, Nov 7, 2011 at 9:13 PM, Graham Percival
gra...@percival-music.ca wrote:
On Mon, Nov 07, 2011 at 08:13:46PM +, carl.d.soren...@gmail.com
wrote:
I am not in favor of the tab-to-space change in
scm/chord-ignatzek-names.scm,
On Sun, Nov 6, 2011 at 5:11 PM, Ian Hulin i...@hulin.org.uk wrote:
Hi all,
A couple of questions in case someone with more internal code-fu than me
can save me rummaging around in the guts of the C++ code, just so I can
get a handle on some behaviour I've noted trying to get LilyPond to fire
On 11-11-07 12:08 PM, adam.spi...@gmail.com wrote:
Please close this issue as it's now superceded by
http://codereview.appspot.com/5343050/ - thanks!
http://codereview.appspot.com/5320074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
I think the number is way off. AFAICS at
http://www.ohloh.net/p/lilypond/enlistments?page=2, they counted all
stable branches as separate.
Last time I looked lilypond was around 100k lines of code (a quick
look says it 200k now; I suspect the GNU headers as a cause). 390 man
years looks
On 11-11-07 12:46 PM, Adam Spiers wrote:
On Mon, Nov 7, 2011 at 7:34 PM, Neil Puttockn.putt...@gmail.com wrote:
On 7 November 2011 19:32, Graham Percivalgra...@percival-music.ca wrote:
Failing either of these, I guess we're into git bisect time, which
of course sucks for doc-building if
Han-Wen Nienhuys hanw...@gmail.com writes:
I think the number is way off. AFAICS at
http://www.ohloh.net/p/lilypond/enlistments?page=2, they counted all
stable branches as separate.
Last time I looked lilypond was around 100k lines of code (a quick
look says it 200k now; I suspect the GNU
On Mon, Nov 7, 2011 at 11:38 PM, David Kastrup d...@gnu.org wrote:
I think the number is way off. AFAICS at
http://www.ohloh.net/p/lilypond/enlistments?page=2, they counted all
stable branches as separate.
Last time I looked lilypond was around 100k lines of code (a quick
look says it 200k
Han-Wen Nienhuys hanw...@gmail.com writes:
On Mon, Nov 7, 2011 at 11:38 PM, David Kastrup d...@gnu.org wrote:
I think the number is way off. AFAICS at
http://www.ohloh.net/p/lilypond/enlistments?page=2, they counted all
stable branches as separate.
Last time I looked lilypond was around
Han-Wen Nienhuys hanw...@gmail.com writes:
On Mon, Nov 7, 2011 at 11:38 PM, David Kastrup d...@gnu.org wrote:
I think the number is way off. AFAICS at
http://www.ohloh.net/p/lilypond/enlistments?page=2, they counted all
stable branches as separate.
Last time I looked lilypond was around
Reviewers: ,
Message:
I am replacing this review by a new one.
Description:
Let #{ ... #} pass its $ handling to environment cloning
Permit ly:parser-clone to receive an environment
lexer.ll: add $ for immediate export.
Please review this at http://codereview.appspot.com/5340053/
Affected
On Mon, 07 Nov 2011 11:36:09 -0800, m...@apollinemike.com
m...@apollinemike.com wrote:
On Nov 7, 2011, at 10:46 AM, Keith OHara wrote:
I had not realized that the results of the pure-from-neighbor system influence
the page-spacing.
I misspoke - in this case, it does not. But it does
Mike,
Now that we understand that we can adjust 'extra-spacing-height
for note-spacing, without messing up line-breaking or page-spacing,
let's revisit the big picture.
On Fri, 04 Nov 2011 00:12:01 -0700, m...@apollinemike.com
m...@apollinemike.com wrote:
On Nov 3, 2011, at 11:39 PM,
On Nov 7, 2011, at 8:19 PM, Keith OHara wrote:
Mike,
Now that we understand that we can adjust 'extra-spacing-height
for note-spacing, without messing up line-breaking or page-spacing,
let's revisit the big picture.
On Fri, 04 Nov 2011 00:12:01 -0700, m...@apollinemike.com
On Mon, 07 Nov 2011 20:51:14 -0800, m...@apollinemike.com
m...@apollinemike.com wrote:
I'm OK with getting rid of all of this pure-from-neighbor and span-bar-stub
stuff and just create several SpanBars instead of one SpanBar with gaps in its
stencil. I can reuse code I've already written,
Hello,
On Tue, Nov 8, 2011 at 1:35 AM, Colin Campbell c...@shaw.ca wrote:
On 11-11-07 12:46 PM, Adam Spiers wrote:
On Mon, Nov 7, 2011 at 7:34 PM, Neil Puttockn.putt...@gmail.com wrote:
On 7 November 2011 19:32, Graham Percivalgra...@percival-music.ca
wrote:
Failing either of these, I
git shortlog -ns|awk '{n+=$1;if(NR20)print};END{print n}'
6381Han-Wen Nienhuys
3092Graham Percival
2474Jan Nieuwenhuizen
1270John Mandereau
1224Francisco Vila
910Reinhold Kainhofer
782Joe Neeman
574Werner
54 matches
Mail list logo
