This was pushed as 18dda6b2f5fbea91a174b60eb22bbb73591b9b64
Thanks, Aleksandr and all reviewers!
Janek
http://codereview.appspot.com/4951062/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
When I go to make the regression tests, I get the following error
message:
texi2html --I=/home/sasha/lilypond-git/input/regression/lilypond-book
--I=./out-test -I /home/sasha/lilypond-git/Documentation
--I=/home/sasha/lilypond-git/build/./out-test/xref-maps
...@apollinemike.com; m...@philholmes.net;
bordage.bertr...@gmail.com
Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com
Sent: Tuesday, January 24, 2012 3:39 PM
Subject: Re: Glyphs for Kievan Notation (issue 4951062)
When I go to make the regression tests, I get the following error
message
On 2012/01/24 15:39:22, aleksandr.andreev wrote:
Looks like it's complaining about a Top node in collated-files.texi
and
another Top node in papersize-docs.texi.
This is reported here:
http://code.google.com/p/lilypond/issues/detail?id=2223#c3
I fix for this is in review.
Regards,
Julien
only one change left.
On 2012/01/23 01:02:13, aleksandr.andreev wrote:
Regarding comments by Jan:
I guess it should be 2.5 staff_space or something
I changed the depth and height parameters as you suggested.
However, I do not see any difference, in the reg tests
or in my test files. Are
There is a difference, compare the position of kievan markups in
pdfs
Ah, OK, I see it now.
You've forgotten about one char_box, see below.
I fixed this one as well as the char_box for the clef.
I've run make and regtests from scratch on a freshly-updated source.
I'm getting the error
On 2012/01/25 00:01:16, aleksandr.andreev wrote:
I'm getting the error described above by Julien when running make
test. I guess
I have to wait for that patch to be pushed.
If you time `texi2html --help' in your terminal, what do you see next to
the --error-limit line? For me, it says 1000,
On 23 January 2012 01:02, aleksandr.andr...@gmail.com wrote:
Regarding comments by Neil and Bertrand:
I rewrote Stem::is_normal_stem the way Neil suggested. Looking at the
code in Stem.cc, it appears that both ways are being used to check the
style property. I don't know which is the more
http://codereview.appspot.com/4951062/diff/99002/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4951062/diff/99002/lily/stem.cc#newcode284
lily/stem.cc:284: string style = robust_symbol2string
(heads[0]-get_property (style), default);
I think Aleksandr is right.
See
Regarding comments by Jan:
I guess it should be 2.5 staff_space or something
I changed the depth and height parameters as you suggested. However, I
do not see any difference, in the reg tests or in my test files. Are we
sure that the entire glyph has to fit within the char_box, including the
http://codereview.appspot.com/4951062/diff/99002/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4951062/diff/99002/lily/stem.cc#newcode284
lily/stem.cc:284: string style = robust_symbol2string
(heads[0]-get_property (style), default);
A bit fussy. You can safely check
Aleksandr,
i apologize for not replying so long.
I've tested your patch and i see only one problem, see below.
When you fix it, could you merge all changes into one commit (using 'git
rebase -i origin/master'), make a patch and send it to James? I guess
he has to check it manually since Patchy
On 2012/01/11 21:37:36, Neil Puttock wrote:
Add a check for kievan style in Stem::is_normal_stem ().
Unfortunately, that doesn't seem to do anything. Unless I'm not
accessing the property correctly ... see the latest patch.
Aleks
http://codereview.appspot.com/4951062/
On 12 January 2012 15:43, aleksandr.andr...@gmail.com wrote:
Unfortunately, that doesn't seem to do anything. Unless I'm not
accessing the property correctly ... see the latest patch.
You're trying to access style from the Stem instead of the NoteHead.
Cheers,
Neil
On 2012/01/12 16:24:13, Neil Puttock wrote:
You're trying to access style from the Stem instead of the NoteHead.
Got it. Thanks, Neil.
http://codereview.appspot.com/4951062/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
something like stems, which should be hidden, stick from notes.
The problem here is that we're not using KievanVoice in
note-head-style.ly.
I've posted a potential solution to get rid of the stems, but it's not
very elegant because it breaks the pattern.
Perhaps someone else has a better
On 11 January 2012 17:13, aleksandr.andr...@gmail.com wrote:
I've posted a potential solution to get rid of the stems, but it's not
very elegant because it breaks the pattern.
Perhaps someone else has a better idea.
Add a check for kievan style in Stem::is_normal_stem ().
Cheers,
Neil
http://codereview.appspot.com/4951062/diff/91002/input/regression/note-head-style.ly
File input/regression/note-head-style.ly (right):
http://codereview.appspot.com/4951062/diff/91002/input/regression/note-head-style.ly#newcode101
input/regression/note-head-style.ly:101:
add break here
Merged Kievan patch with existing source code and fixed an issue in
output-lib.scm
http://codereview.appspot.com/4951062/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
2011/12/27 Aleksandr Andreev aleksandr.andr...@gmail.com:
Hi Janek,
Good to hear that you are back.
The issues that Bertrand and others were raising have all been addressed.
In addition, I've been able to implement a few other features
(Parentheses to offset optional melisma, different
Hi Aleksandr,
2011/11/9 aleksandr.andr...@gmail.com:
That is done, but before updating I wanted to resolve a few other
issues. However, I cannot figure out how to control the amount of
spacing between notes (I need the notes in a phrasing slur to be closer
together). Also, I can't get the
On 2011/10/18 17:46:23, Bertrand Bordage wrote:
LGTM. Two tiny changes and it'll be ready to push.
That was three weeks ago. Is this done? I still see the tracker open,
Janek owns that
http://code.google.com/p/lilypond/issues/detail?id=1873
but he is away so I am chasing the state of this.
That is done, but before updating I wanted to resolve a few other
issues. However, I cannot figure out how to control the amount of
spacing between notes (I need the notes in a phrasing slur to be closer
together). Also, I can't get the beams to show properly.
Fixed the issues addressed by Bertrand.
What still remains:
1. Implementing beams
2. Changing the spacing so that notes in a phrasing slur are closer
together.
3. Remove extra space after final note.
Comments much appreciated.
http://codereview.appspot.com/4951062/
LGTM. Two tiny changes and it'll be ready to push.
http://codereview.appspot.com/4951062/diff/78001/ly/engraver-init.ly
File ly/engraver-init.ly (right):
http://codereview.appspot.com/4951062/diff/78001/ly/engraver-init.ly#newcode1107
ly/engraver-init.ly:1107: \remove Stem_engraver
Sorry, I
Here's the second part of my review. I saw that kievan notation has
beams, contrary to what I thought. If you're intrepid, you can also try
to implement the kievan beaming parameters in you KievanVoice.
Hold on, it's the end!
Bertrand
I'm trying to implement beams, but I get this message:
must have Item for spanner bound of Beam
What does this refer to?
A
On Fri, Oct 7, 2011 at 6:29 AM, bordage.bertr...@gmail.com wrote:
Here's the second part of my review. I saw that kievan notation has
beams, contrary to what I
You can't solve the Kievan bar line problem without calculate every dot
position. I made a pure MetaFont version of the Kievan bar line:
fet_beginchar (kievan end of piece (slash), barline.kievan);
% this draws the end of piece figure
% this figure is placed at the end of the
I've taken care of the issues Bertrand points out in #46. There are
still some issues outstanding. The code in output-lib.scm is probably
not the best way of doing this. Also, the Kievan bar line does not
appear correctly.
http://codereview.appspot.com/4951062/
I've begun working on improving the MetaFont code. Please take a
look at the code for the final note, the recitative, and the whole
note and let me know if I'm on the right track.
This is definitely the right track. Currently, I don't have the time
to actually apply your patches, but it
2011/9/28 aleksandr.andr...@gmail.com:
Per comments by Bertrand, I have moved the Kievan glyphs to Parmesan. I
have also changed the names of the glyphs as he suggested.
I've begun working on improving the MetaFont code. Please take a look at
the code for the final note, the recitative, and
I've uploaded changes to output-lib.scm. The problem I have is that
output-lib does not allow access to noteheads of log-duration greater
than 2.
I've temporarily changed a few lines of the file. However, I'm not sure
this is the best way of doing this. Please let me know what the right
approach
Per comments by Bertrand, I have moved the Kievan glyphs to Parmesan. I
have also changed the names of the glyphs as he suggested.
I've begun working on improving the MetaFont code. Please take a look at
the code for the final note, the recitative, and the whole note and let
me know if I'm on
...@apollinemike.com
Cc: re...@codereview.appspotmail.com; lilypond-devel@gnu.org
Sent: Friday, September 23, 2011 9:00 PM
Subject: Re: Glyphs for Kievan Notation (issue 4951062)
make doc problem solved on my system. I can confirm that make and make
doc run successfully with this patch.
What did you
What did you do to get make doc going?
I nuked my entire lilypond-git directory, reinstalled the source and
ran make and make doc.
Then, I ran the Kievan patch and recompiled.
A
___
lilypond-devel mailing list
lilypond-devel@gnu.org
This is a great work, but it doesn't fit correctly into LilyPond:
OK, I will merge with Parmesan and work on the Scheme stuff.
I also agree with Werner, there's also a lot of cleanup to do inside
your MetaFont stuff.
I'm new to MetaFont, so right now I'm using it like a GUI-less
outline
make doc problem solved on my system. I can confirm that make and make
doc run successfully with this patch.
http://codereview.appspot.com/4951062/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
;
lilypond-devel@gnu.org; percival.music...@gmail.com
Sent: Thursday, September 22, 2011 5:31 AM
Subject: Re: Glyphs for Kievan Notation (issue 4951062)
On Thu, Sep 22, 2011 at 06:22:13AM +0200, Janek Warchoł wrote:
Overnight i tried making doc on current master and it failed too
2011/9/22 Phil Holmes m...@philholmes.net:
On Thu, Sep 22, 2011 at 06:22:13AM +0200, Janek Warchoł wrote:
Overnight i tried making doc on current master and it failed too.
ef8dd3eaee73588faf1a6687407a6fda60cff591
worked perfectly in ubuntu 10.04 (not quite lilydev) for me a few
hours ago.
Janek
2011/9/22 Janek Warchoł janek.lilyp...@gmail.com:
I know that Aleks uses Ubuntu Natty (not Lilydev).
I use Lilydev - probably not the newest version, how can i check it?
System - Administration - System Monitor click on the first tab : )
That's the GUI way.
You can also do some
Hi Phil,
Janek, Aleksandr - could you confirm what system you're getting make doc
failing on?
Yes, I'm running Ubuntu Natty (not Lilydev).
More specifically, Linux sasha-desktop 2.6.38-11-generic #48-Ubuntu
x86_64 GNU/Linux
Aleks
___
2011/9/22 Peekay Ex pkx1...@gmail.com:
Janek
2011/9/22 Janek Warchoł janek.lilyp...@gmail.com:
I use Lilydev - probably not the newest version, how can i check it?
System - Administration - System Monitor click on the first tab : )
It says
janek-lilydev5 (that's my username and virtual
FWIW, I updated my kernel by installing the latest Ubuntu updates. I
also did a git rebase. I still get the same problem.
A
2011/9/22 Janek Warchoł janek.lilyp...@gmail.com:
2011/9/22 Peekay Ex pkx1...@gmail.com:
Janek
2011/9/22 Janek Warchoł janek.lilyp...@gmail.com:
I use Lilydev -
2011/9/21 Graham Percival gra...@percival-music.ca:
On Tue, Sep 20, 2011 at 10:27:02PM -0400, Aleksandr Andreev wrote:
/home/sasha/lilypond-git/build/out/lybook-db/snippet-names-5304161007275961614.ly
Does anyone have any idea what could be going on?
What's in the above file? It'll probably
On Sep 21, 2011, at 8:02 AM, Janek Warchoł wrote:
2011/9/21 Graham Percival gra...@percival-music.ca:
On Tue, Sep 20, 2011 at 10:27:02PM -0400, Aleksandr Andreev wrote:
/home/sasha/lilypond-git/build/out/lybook-db/snippet-names-5304161007275961614.ly
Does anyone have any idea what could be
Hello,
2011/9/21 m...@apollinemike.com m...@apollinemike.com:
On Sep 21, 2011, at 8:02 AM, Janek Warchoł wrote:
2011/9/21 Graham Percival gra...@percival-music.ca:
On Tue, Sep 20, 2011 at 10:27:02PM -0400, Aleksandr Andreev wrote:
2011/9/21 Peekay Ex pkx1...@gmail.com:
Hello,
2011/9/21 m...@apollinemike.com m...@apollinemike.com:
On Sep 21, 2011, at 8:02 AM, Janek Warchoł wrote:
Out of curiosity i searched for snippet-names-5304161007275961614.ly
file in build/out/lybook-db/ and... it doesn't exist. In fact i
Am Wednesday, 21. September 2011, 04:27:02 schrieb Aleksandr Andreev:
Unfortunately, I cannot get my documentation to build. As was
suggested earlier, I nuked my build folder and redid everything from
the beginning (configure.sh, make all, touch, make doc). However, make
doc errors out with
What's in the above file? It'll probably contain 5-10 other
filename
Yes. All the different snippets seem to have something to do with percussion.
Aleks
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Hello,
On Wed, Sep 21, 2011 at 1:09 PM, Aleksandr Andreev
aleksandr.andr...@gmail.com wrote:
What's in the above file? It'll probably contain 5-10 other
filename
Yes. All the different snippets seem to have something to do with percussion.
Aleks
- Original Message -
From: Janek Warchoł janek.lilyp...@gmail.com
[snip]
It's the first time i tried compiling docs, so i may have screwed
something. Here's what i did:
rm -r build
sh autogen.sh --noconfigure
mkdir -p build/
cd build/
../configure
make
make doc
2011/9/21 Peekay Ex pkx1...@gmail.com:
Hello,
On Wed, Sep 21, 2011 at 1:09 PM, Aleksandr Andreev
aleksandr.andr...@gmail.com wrote:
What's in the above file? It'll probably contain 5-10 other
filename
Yes. All the different snippets seem to have something to do with percussion.
You did
Updated Documentation/notation/notation-appendices.itely to show new
glyphs, reflecting comments by Neil.
http://codereview.appspot.com/4951062/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Yet another rm -fdr build/ and re-run of make, etc., eliminated my
original problem with snippets.
Now, my make doc command crashes with the same error message that
Janek is getting.
Looks like there's a missing file web.texi.
Aleks
___
2011/9/21 Phil Holmes m...@philholmes.net:
- Original Message - From: Janek Warchoł
janek.lilyp...@gmail.com
[snip]
It's the first time i tried compiling docs, so i may have screwed
something. Here's what i did:
rm -r build
sh autogen.sh --noconfigure
mkdir -p build/
On Thu, Sep 22, 2011 at 06:22:13AM +0200, Janek Warchoł wrote:
Overnight i tried making doc on current master and it failed too.
ef8dd3eaee73588faf1a6687407a6fda60cff591
worked perfectly in ubuntu 10.04 (not quite lilydev) for me a few
hours ago.
63cfd5548c42a98c7dae43f1f92e67772969e53c
worked
2011/9/22 Graham Percival gra...@percival-music.ca:
On Thu, Sep 22, 2011 at 06:22:13AM +0200, Janek Warchoł wrote:
Overnight i tried making doc on current master and it failed too.
ef8dd3eaee73588faf1a6687407a6fda60cff591
worked perfectly in ubuntu 10.04 (not quite lilydev) for me a few
Hi Neil,
2011/9/14 n.putt...@gmail.com:
http://codereview.appspot.com/4951062/diff/11001/input/regression/kievan-notes.ly
File input/regression/kievan-notes.ly (right):
http://codereview.appspot.com/4951062/diff/11001/input/regression/kievan-notes.ly#newcode11
2011/9/20 Janek Warchoł janek.lilyp...@gmail.com:
I'm not sure what is your opinion on this patch currently. Do you
agree to push it if it doesn't break make, make doc and regtests? Do
you agree with my comment no.7
http://code.google.com/p/lilypond/issues/detail?id=1873#c7 ?
Yes.
I'm
2011/9/20 Neil Puttock n.putt...@gmail.com:
I'm running make doc with the patch applied at the moment. Will
report any problems.
There's nothing wrong with the patch as far as I can tell. Make doc
completes successfully here.
The only thing that's missing is an entry in
Unfortunately, I cannot get my documentation to build. As was
suggested earlier, I nuked my build folder and redid everything from
the beginning (configure.sh, make all, touch, make doc). However, make
doc errors out with the following message:
Calculating line breaks... Segmentation fault
On Tue, Sep 20, 2011 at 10:27:02PM -0400, Aleksandr Andreev wrote:
/home/sasha/lilypond-git/build/out/lybook-db/snippet-names-5304161007275961614.ly
Does anyone have any idea what could be going on?
What's in the above file? It'll probably contain 5-10 other
filenames; one of those is the
Fixed alignment issue based on comments by lemzwerg.
http://codereview.appspot.com/4951062/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
http://codereview.appspot.com/4951062/diff/24001/mf/feta-kievan.mf
File mf/feta-kievan.mf (right):
http://codereview.appspot.com/4951062/diff/24001/mf/feta-kievan.mf#newcode52
mf/feta-kievan.mf:52: fill z1{dir 8.6} .. z2 .. z3
A minor thing: Please align this vertically (and at similar
Werner,
2011/9/9 lemzw...@googlemail.com:
I'm not really happy with the MF code: It looks like a direct
translation of PostScript points into MF points. This definitely works
but is quite clumsy. If you look at the design of other LilyPond
glyphs, you can see that all coordinates rely on
what do you mean by let's treat this as a temporary solution? Do
you mean that: 1) it can be pushed in this state so that Aleksandr
can proceed on getting Kievan notation to work (by adding
KievanStaff, KievanVoice and so on), but when support for Kievan
notation is established, the
http://codereview.appspot.com/4951062/diff/11001/input/regression/kievan-notes.ly
File input/regression/kievan-notes.ly (right):
http://codereview.appspot.com/4951062/diff/11001/input/regression/kievan-notes.ly#newcode11
input/regression/kievan-notes.ly:11: \override NoteHead #'stencil =
OK. What is noteheight# equal to and how is that determined?
A quick grep on the MF files shows that noteheight# is defined in
feta-params.mf.
http://codereview.appspot.com/4951062/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 2011/09/10 12:47:18, J_lowe wrote:
I created
https://code.google.com/p/lilypond/issues/detail?id=1873
and called it
'Added glyphs for Kievan Notation'
so when this issue is changed can we use the same title?
I changed the name of the issue.
On 2011/09/10 10:20:45, lemzwerg wrote:
Simply have a look how other note heads are implemented, and watch how
the shape
changes for different design sizes.
OK. What is noteheight# equal to and how is that determined?
http://codereview.appspot.com/4951062/
passes make and reg tests
http://codereview.appspot.com/4951062/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM.
Only some minor style nitpicks; you may also wish to change commit's
message (currently it says that there is only one glyph added). You can
modify commit messages using
git rebase -i origin/master
http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf
File mf/feta-kievan.mf
Reviewers: ,
Message:
Publishing for review Metafont code for support of Kievan square notes
plus a very basic regression file to test the implementation.
Description:
Added glyphs for Kievan Notation
Added Kievan glyphs and a basic test file
add basic infrastructure for kievan font
First
Good job! I'm not very familiar with the fetafont stuff, but this looks
like exactly the right thing to do. :)
http://codereview.appspot.com/4951062/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
74 matches
Mail list logo
