Re: [Patch V2] i2c: imx: init bus recovery info before adding i2c adapter

2015-12-08 Thread Uwe Kleine-König
c_imx_init_recovery_info() before > i2c_register_adapter(). > > Signed-off-by: Gao Pan <b54...@freescale.com> > Signed-off-by: Fugang Duan <b38...@freescale.com> Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> I wonder why your S-o-b line isn't below Fugang Duan's. Th

Re: [Patch V9] i2c: imx: add runtime pm support to improve the performance

2015-11-30 Thread Uwe Kleine-König
do this. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a mess

Re: [PATCH] i2c: imx: make bus recovery through pinctrl optional

2015-11-19 Thread Uwe Kleine-König
Hello, Cc += Linus Walleij, linux-gpio On Wed, Nov 18, 2015 at 04:59:11PM -0600, Li Yang wrote: > On Wed, Nov 18, 2015 at 1:24 AM, Uwe Kleine-König > <u.kleine-koe...@pengutronix.de> wrote: > > On Tue, Nov 17, 2015 at 06:02:59PM -0600, Li Yang wrote: > >> @@ -11

Re: [PATCH] i2c: imx: make bus recovery through pinctrl optional

2015-11-17 Thread Uwe Kleine-König
l)) { ret = PTR_ERR(i2c_imx->pinctrl); goto errorhandling; } if (i2c_imx->pinctrl) i2c_imx_init_recovery_info(i2c_imx, pdev); else dev_info(>dev, "can't get pinctrl, bus recovery feature disabled\n"); right

Re: [PATCH] i2c: rcar: fix a possible NULL dereference

2015-11-12 Thread Uwe Kleine-König
Hello Wolfram, On Thu, Nov 12, 2015 at 08:52:38AM +0100, Wolfram Sang wrote: > On Thu, Nov 12, 2015 at 08:44:47AM +0100, Uwe Kleine-König wrote: > > Other than that, the NULL pointer dereference should only happen if the > > device was bound using the driver name. That might be wor

Re: [PATCH] i2c: rcar: fix a possible NULL dereference

2015-11-12 Thread Uwe Kleine-König
On Thu, Nov 12, 2015 at 09:48:37AM +0100, Wolfram Sang wrote: > On Thu, Nov 12, 2015 at 09:09:26AM +0100, Uwe Kleine-König wrote: > > Hello Wolfram, > > > > On Thu, Nov 12, 2015 at 08:52:38AM +0100, Wolfram Sang wrote: > > > On Thu, Nov 12, 2015 at 08:44:47AM

Re: [PATCH] i2c: tegra: fix a possible NULL dereference

2015-11-12 Thread Uwe Kleine-König
_device(dev, drv)) > return 1; > > return 0; > } That's equivalent to if (dev->of_node) return of_driver_match_device(dev, drv); and was already suggested in the thread referenced from my reply to http

Re: [PATCH] i2c: taos-evm: replace simple_strtoul by kstrtou8

2015-11-11 Thread Uwe Kleine-König
- data->byte = simple_strtol(p + 1, NULL, 16); > + err = kstrtou8(p + 1, 16, >byte); > + if (err) > + return -EPROTO; > return 0; This is nearly equivalent to the probably m

Re: [PATCH] i2c: rcar: fix a possible NULL dereference

2015-11-11 Thread Uwe Kleine-König
e using priv->devtype = (enum rcar_i2c_type)of_device_get_match_data(dev) if good enough? Other than that, the NULL pointer dereference should only happen if the device was bound using the driver name. That might be worth to point out in the commit log. So maybe make (in a separate

Re: [Patch V1] i2c: imx: improve code readability

2015-11-02 Thread Uwe Kleine-König
t; + rinfo->sda_gpio = of_get_named_gpio(pdev->dev.of_node, "sda-gpios", 0); > + rinfo->scl_gpio = of_get_named_gpio(pdev->dev.of_node, "scl-gpios", 0); Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> Best regards Uwe -- Pengutronix

Re: [GIT PULL] On-demand device probing

2015-10-19 Thread Uwe Kleine-König
thout following all that fwnode discussion: gpiod_get et al. should work for you here, doesn't it? It just takes a struct device * and I'm happy with it. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http:/

Re: [Patch V8] i2c: imx: add runtime pm support to improve the performance

2015-10-13 Thread Uwe Kleine-König
registration failed\n"); > - goto clk_disable; > + goto rpm_disable; Is it right, that here the same error path is taken as when pm_runtime_get_sync fails above? Even if it works now, not having the error cleanup path undo all things in reverse order is a danger to

Re: [Patch V5] i2c: imx: implement bus recovery

2015-09-21 Thread Uwe Kleine-König
;pins.sda); > goto clk_disable; > } > > if (IS_ERR(i2c_imx->pins.scl)) { > ret = PTR_ERR(i2c_imx->pins.scl); > goto clk_disable; > } As said above, here you need an

Re: [Patch v2] i2c: imx: implement bus recovery

2015-09-08 Thread Uwe Kleine-König
Hello, On Tue, Sep 08, 2015 at 04:18:41PM +0200, Linus Walleij wrote: > On Mon, Sep 7, 2015 at 10:00 AM, Uwe Kleine-König > <u.kleine-koe...@pengutronix.de> wrote: > > [Me] > > >> If the use case is around the i2c traffic, it is a mode related to I2C, > >>

Re: [Patch v2] i2c: imx: implement bus recovery

2015-09-07 Thread Uwe Kleine-König
Hallo Linus, On Tue, Aug 25, 2015 at 04:18:16PM +0200, Linus Walleij wrote: > On Wed, Aug 19, 2015 at 9:02 AM, Uwe Kleine-König > <u.kleine-koe...@pengutronix.de> wrote: > > On Wed, Aug 19, 2015 at 03:44:49AM +, Gao Pandy wrote: > >> From: Uwe Kleine

Re: [Patch V7] i2c: imx: add runtime pm support to improve the performance

2015-09-07 Thread Uwe Kleine-König
ch clue about runtime pm this doesn't mean much. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in

Re: [Patch v4] i2c: imx: implement bus recovery

2015-09-07 Thread Uwe Kleine-König
;adapter.nr = pdev->id; > + i2c_imx->adapter.dev.of_node = pdev->dev.of_node; > + i2c_imx->adapter.bus_recovery_info = _imx_bus_recovery_info; In a former review round I suggested to only do this assignment after the two gpios were aquired successfully. Then the above che

Re: [Patch v2] i2c: imx: implement bus recovery

2015-08-19 Thread Uwe Kleine-König
Hello, Cc += Linus Walleij On Wed, Aug 19, 2015 at 03:44:49AM +, Gao Pandy wrote: From: Uwe Kleine-König mailto:u.kleine-koe...@pengutronix.de Sent: Thursday, August 13, 2015 4:15 PM +static void i2c_imx_prepare_recovery(struct i2c_adapter *adap) { + struct imx_i2c_struct *i2c_imx

Re: [Patch v3] i2c: imx: implement bus recovery

2015-08-19 Thread Uwe Kleine-König
= + devm_gpiod_get_optional(pdev-dev, scl-gpio, GPIOD_OUT_HIGH); As already noticed in the v2 thread: I think GPIOD_OUT_HIGH is wrong. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de

Re: [Patch v2] i2c: imx: implement bus recovery

2015-08-19 Thread Uwe Kleine-König
-- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [Patch v2] i2c: imx: implement bus recovery

2015-08-13 Thread Uwe Kleine-König
there is no justification to ignore the error code. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c

Re: [Patch v1] i2c: imx: implement bus recovery

2015-07-14 Thread Uwe Kleine-König
, recover-scl, 0); I'd use devm_gpiod_get_optional here. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c

Re: [PATCH-v3 04/11] i2c: pxa: Remove compile warnning in 64bit mode

2015-07-10 Thread Uwe Kleine-König
Hello, $Subject ~= s/warnning/warning/ and I'd rather write Fix instead of Remove. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send

Re: [PATCH v2 5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery

2015-07-07 Thread Uwe Kleine-König
Hello, On Tue, Jul 07, 2015 at 03:37:49PM +0200, Jan Lübbe wrote: On Mi, 2014-11-26 at 19:05 +0200, Grygorii Strashko wrote: On 11/26/2014 06:04 PM, Uwe Kleine-König wrote: On Wed, Nov 26, 2014 at 03:59:53PM +0200, Grygorii Strashko wrote: Having a board where the I2C bus locks up

Re: [Patch v1] i2c: imx: add runtime pm support to improve the performance

2015-06-17 Thread Uwe Kleine-König
regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-20 Thread Uwe Kleine-König
Hello, On Wed, May 20, 2015 at 09:03:40PM +0800, Yingjoe Chen wrote: On Wed, 2015-05-20 at 10:57 +0200, Uwe Kleine-König wrote: On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: + if (i2c-speed_hz MAX_HS_MODE_SPEED) + return -EINVAL; According to the plan to tune

Re: [PATCH] i2c: axxia: Add bus recovery functionality

2015-05-13 Thread Uwe Kleine-König
Hello, On Wed, May 13, 2015 at 09:20:48AM +0200, Michael Lawnick wrote: Am 13.05.2015 um 08:55 schrieb ext Uwe Kleine-König: On Wed, May 13, 2015 at 08:19:59AM +0200, Michael Lawnick wrote: Am 12.05.2015 um 21:12 schrieb Wolfram Sang: Doesn't look right. -EAGAIN means arbitration lost which

Re: How to encode being an I2C slave in DT?

2015-05-06 Thread Uwe Kleine-König
Hello Stephen, On Wed, May 06, 2015 at 09:57:37AM -0600, Stephen Warren wrote: On 05/06/2015 02:09 AM, Uwe Kleine-König wrote: On Wed, May 06, 2015 at 09:53:55AM +0200, Marc Dietrich wrote: Am Mittwoch, 6. Mai 2015, 08:59:28 schrieb Uwe Kleine-König: On Tue, May 05, 2015 at 12:55:13PM +0200

Re: [PATCH] i2c: i2c-gpio: fix some of gpio sleep issues

2015-04-22 Thread Uwe Kleine-König
by timing? A sleeping gpio is probably slower, but this shouldn't affect correctness of the protocol implementation, should it? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCH v2 2/4] Documentation: i2c: describe the new slave mode

2015-03-23 Thread Uwe Kleine-König
to -speak a custom protocol or to emulate some other device. \o/ Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 4/4] i2c: slave-eeprom: add more info when to increase the pointer

2015-03-23 Thread Uwe Kleine-König
Sang wsa+rene...@sang-engineering.com Acked-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line

Re: [PATCH 1/3] i2c: slave: rework the slave API

2015-03-20 Thread Uwe Kleine-König
Moin Wolfram, On Fri, Mar 20, 2015 at 08:15:04AM +0100, Wolfram Sang wrote: On Thu, Mar 19, 2015 at 09:17:51PM +0100, Uwe Kleine-König wrote: Hello Wolfram, On Thu, Mar 12, 2015 at 01:42:01PM +0100, Wolfram Sang wrote: From: Wolfram Sang wsa+rene...@sang-engineering.com After

Re: [PATCH 1/3] i2c: slave: rework the slave API

2015-03-20 Thread Uwe Kleine-König
to only need a single call to the slave callback when an action by the backend is required. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe

Re: [PATCH 2/3] Documentation: i2c: describe the new slave mode

2015-03-20 Thread Uwe Kleine-König
for managing a position pointer from the slave-eeprom driver. Then, we'd have only one trusted implementation of EEPROM-alike behaviour and people can concentrate on reacting to reads/writes. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial

Re: [PATCH 1/3] i2c: slave: rework the slave API

2015-03-19 Thread Uwe Kleine-König
Kleine-König u.kleine-koe...@pengutronix.de Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body

Re: [PATCH v3 2/2] i2c: Support for Netlogic XLP9XX/5XX I2C controller.

2015-03-17 Thread Uwe Kleine-König
Hello, On Tue, Mar 17, 2015 at 08:00:40PM +0530, Jayachandran C. wrote: On Sat, Mar 14, 2015 at 09:01:24PM +0100, Uwe Kleine-König wrote: On Sat, Mar 14, 2015 at 05:18:37PM +0530, Jayachandran C. wrote: On Fri, Mar 13, 2015 at 11:24:06AM +0100, Uwe Kleine-König wrote: On Fri, Mar 13

Re: [PATCH v3 2/2] i2c: Support for Netlogic XLP9XX/5XX I2C controller.

2015-03-14 Thread Uwe Kleine-König
Hello, On Sat, Mar 14, 2015 at 05:18:37PM +0530, Jayachandran C. wrote: On Fri, Mar 13, 2015 at 11:24:06AM +0100, Uwe Kleine-König wrote: On Fri, Mar 13, 2015 at 11:59:58AM +0530, Jayachandran C wrote: diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c new

Re: [PATCH v3 2/2] i2c: Support for Netlogic XLP9XX/5XX I2C controller.

2015-03-13 Thread Uwe Kleine-König
); + xlp9xx_write_i2c_reg(priv, XLP9XX_I2C_DIV, prescale); + xlp9xx_write_i2c_reg(priv, XLP9XX_I2C_INTEN, 0); + + return 0; +} Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http

Re: [PATCH v2 2/2] i2c: Support for Netlogic XLP9XX/5XX I2C controller.

2015-03-06 Thread Uwe Kleine-König
. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] i2c: pca954x: Defer probing due to reset GPIO

2015-03-05 Thread Uwe Kleine-König
...@ideasonboard.com I sent the same patch with a slightly different motivation two weeks ago: http://article.gmane.org/gmane.linux.drivers.i2c/21972 Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http

Re: Bug in i2c-core?

2015-02-27 Thread Uwe Kleine-König
-- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Bug in i2c-core?

2015-02-27 Thread Uwe Kleine-König
Hello, On Fri, Feb 27, 2015 at 09:46:11AM -0800, Dmitry Torokhov wrote: On Fri, Feb 27, 2015 at 06:05:45PM +0100, Uwe Kleine-König wrote: On Fri, Feb 27, 2015 at 07:29:30AM -0800, Dmitry Torokhov wrote: On February 27, 2015 6:37:25 AM PST, Thomas Petazzoni thomas.petazz...@free

[PATCH] i2c: pca954x: improve usage of gpiod API

2015-02-17 Thread Uwe Kleine-König
is slightly changed here by using it. Now if a reset gpio is specified and getting hold on it fails, pca954x_probe fails, too. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/i2c/muxes/i2c-mux-pca954x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v4 2/2] I2C: mediatek: Add driver for MediaTek I2C controller

2015-01-21 Thread Uwe Kleine-König
the driver. Then i2c_del_adapter is called which frees the resources managed by the core, then the device's completion irq triggers and the freed adapter is used which probably results in an oops. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König

Re: [PATCH v4 2/2] I2C: mediatek: Add driver for MediaTek I2C controller

2015-01-21 Thread Uwe Kleine-König
mtk_i2c and add a struct i2c_msg *msg instead. Up to you to decide. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v4 2/2] I2C: mediatek: Add driver for MediaTek I2C controller

2015-01-21 Thread Uwe Kleine-König
Hello, On Wed, Jan 21, 2015 at 08:49:40PM +0800, Yingjoe Chen wrote: On Wed, 2015-01-21 at 09:15 +0100, Uwe Kleine-König wrote: On Wed, Jan 21, 2015 at 02:30:09PM +0800, Yingjoe Chen wrote: On Wed, 2015-01-21 at 11:13 +0800, Eddie Huang wrote: ... + ret = -EINVAL

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Uwe Kleine-König
over the other in this case. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Uwe Kleine-König
Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote: On 01/17/15 00:42, Ray Jui wrote: +complete_all(iproc_i2c-done

Re: [PATCH v4 2/2] I2C: mediatek: Add driver for MediaTek I2C controller

2015-01-18 Thread Uwe Kleine-König
(mtk_i2c_of_match), + }, +}; + +module_platform_driver(mtk_i2c_driver); + +MODULE_LICENSE(GPL); MODULE_LICENSE(GPL v2); +MODULE_DESCRIPTION(MediaTek I2C Bus Driver); +MODULE_AUTHOR(Xudong Chen xudong.c...@mediatek.com); Best regards Uwe -- Pengutronix e.K. | Uwe Kleine

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Uwe Kleine-König
Hello, On Sun, Jan 18, 2015 at 12:46:51PM +0100, Arend van Spriel wrote: On 01/18/15 12:17, Uwe Kleine-König wrote: Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: On Sun, Jan 18, 2015 at 10:14

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Uwe Kleine-König
Hello, On Fri, Jan 16, 2015 at 02:09:28PM -0800, Ray Jui wrote: On 1/15/2015 12:41 AM, Uwe Kleine-König wrote: On Wed, Jan 14, 2015 at 02:23:32PM -0800, Ray Jui wrote: + */ + val = 1 M_CMD_START_BUSY_SHIFT; + if (msg-flags I2C_M_RD) { + val |= (M_CMD_PROTOCOL_BLK_RD

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Uwe Kleine-König
Hello, On Sat, Jan 17, 2015 at 11:58:33AM -0800, Ray Jui wrote: On 1/17/2015 8:01 AM, Uwe Kleine-König wrote: On Fri, Jan 16, 2015 at 02:09:28PM -0800, Ray Jui wrote: On 1/15/2015 12:41 AM, Uwe Kleine-König wrote: On Wed, Jan 14, 2015 at 02:23:32PM -0800, Ray Jui wrote

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Uwe Kleine-König
Hello, On Sat, Jan 17, 2015 at 12:51:50PM -0800, Ray Jui wrote: On 1/17/2015 12:18 PM, Uwe Kleine-König wrote: Hello, On Sat, Jan 17, 2015 at 11:58:33AM -0800, Ray Jui wrote: On 1/17/2015 8:01 AM, Uwe Kleine-König wrote: On Fri, Jan 16, 2015 at 02:09:28PM -0800, Ray Jui wrote: On 1

Re: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus

2015-01-16 Thread Uwe Kleine-König
-iproc-i2c }, {}, }; No, there is no need, see above. If something is still unclear, don't hesitate to ask. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-15 Thread Uwe Kleine-König
. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-15 Thread Uwe Kleine-König
this is specified to be a must, but I'd add spaces after { and before }. + {}, It's a good habit to write this as { /* sentinel */ } without trailing comma. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions

Re: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus

2015-01-15 Thread Uwe Kleine-König
this: compatible = brcm,$mysoc-iproc-i2c, brcm,iproc-i2c; (or maybe s/$mysoc-iproc-i2c/$mysoc-i2c/). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list

Re: [PATCH v3 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-13 Thread Uwe Kleine-König
cinoptions=(,: if has(autocmd) filetype plugin indent on endif to your .vimrc. Then while typing vim does the indention right and consistent, and with the = command you can reindent. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König

Re: [PATCH v3 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-13 Thread Uwe Kleine-König
= bcm_iproc_i2c_remove, +}; +module_platform_driver(bcm_iproc_i2c_driver); + +MODULE_AUTHOR(Ray Jui r...@broadcom.com); +MODULE_DESCRIPTION(Broadcom iProc I2C Driver); +MODULE_LICENSE(GPL v2); -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions

Re: [PATCH] i2c: exynos5: Move initialization code to subsys_initcall()

2015-01-11 Thread Uwe Kleine-König
to stop the next person converting it to that. (And if not, please fix accordingly to use deferred probing.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from

Re: [PATCHv1 1/7] dt-bindings: use isil prefix for Intersil

2014-12-16 Thread Uwe Kleine-König
Serial Interface Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord

Re: [PATCH v4] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C specification

2014-12-10 Thread Uwe Kleine-König
. If not available use the default maximum timing from the specification. (Otherwise I think the comma needs to go after there in your sentence.) Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http

Re: [PATCH v3] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec

2014-12-08 Thread Uwe Kleine-König
it would be good to check for these limits, too. strlcpy(i2c-adap.name, rk3x-i2c, sizeof(i2c-adap.name)); i2c-adap.owner = THIS_MODULE; i2c-adap.algo = rk3x_i2c_algorithm; Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial

Re: [PATCH v3] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec

2014-12-08 Thread Uwe Kleine-König
should debate in a followup patch. Sounds all reasonable. I'd not address 3 and 4 in this patch, but do this in separate one. (That's what I intended from the beginning, just failed to point that out explicitly.) Uwe -- Pengutronix e.K. | Uwe Kleine-König

Re: How should dev_[gs]et_drvdata be used?

2014-11-28 Thread Uwe Kleine-König
Hi Jean, On Fri, Nov 28, 2014 at 02:48:13PM +0100, Jean Delvare wrote: On Tue, 25 Nov 2014 22:14:32 +0100, Uwe Kleine-König wrote: On Wed, Jan 08, 2014 at 02:28:49PM +0100, Jean Delvare wrote: Having looked at the code in deeper detail, I think I understand what is going on. The problem

Re: [PATCH v2 5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery

2014-11-26 Thread Uwe Kleine-König
. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/5] i2c: davinci: query STP always when NACK is received

2014-11-26 Thread Uwe Kleine-König
Hello Grygorii, On Wed, Nov 26, 2014 at 06:31:22PM +0200, Grygorii Strashko wrote: On 11/26/2014 05:57 PM, Uwe Kleine-König wrote: I don't understand your use of query in the subject and later in the commit log. Do you mean send? will change to generate. Ok? yes that would be better

Re: How should dev_[gs]et_drvdata be used?

2014-11-25 Thread Uwe Kleine-König
adapter.algo_data instead of calling dev_set/get_drvdata(). This would let us fix all the drivers at once. I'll bring the topic upstream for discussion. -- Jean Delvare -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http

Re: [PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK

2014-11-24 Thread Uwe Kleine-König
that fails to compile can even start probing ... :-) Anyhow, it would be nice to quote the compiler error you fix here and point out the patch that failed to add the needed dependency. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux

Re: [PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK

2014-11-24 Thread Uwe Kleine-König
Hey Wolfram, On Mon, Nov 24, 2014 at 10:31:16AM +0100, Wolfram Sang wrote: On Mon, Nov 24, 2014 at 09:05:09AM +0100, Uwe Kleine-König wrote: Hello Max, On Mon, Nov 24, 2014 at 01:32:27AM +0100, Max Schwarz wrote: Now that we are using the clk notifier framework we get compile errors

Re: [PATCH v2] i2c: rk3x: add Kconfig dependency on COMMON_CLK

2014-11-24 Thread Uwe Kleine-König
with better commit msg in case you still want to take that instead of my quick fix. Thanks for your quick turn around. Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from

Re: [PATCH v3] i2c: rk3x: add Kconfig dependency on COMMON_CLK

2014-11-24 Thread Uwe Kleine-König
. Fixes: 5a6f1566f6a0 (i2c: rk3x: handle dynamic clock rate changes correctly) Signed-off-by: Max Schwarz max.schw...@online.de --- Wolfram, here is a version with *even* better commit msg in case you still want to take that instead of my quick fix. Acked-by: Uwe Kleine-König u.kleine-koe

Re: [PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK

2014-11-24 Thread Uwe Kleine-König
. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery

2014-11-24 Thread Uwe Kleine-König
Hi Grygorii, On Mon, Nov 24, 2014 at 03:15:58PM +0200, Grygorii Strashko wrote: On 11/23/2014 07:04 PM, Uwe Kleine-König wrote: On Thu, Nov 20, 2014 at 12:03:08PM +0200, Grygorii Strashko wrote: @@ -664,6 +759,7 @@ static int davinci_i2c_probe(struct platform_device *pdev

Re: [2/5] i2c: davinci: query STP always when NACK is received

2014-11-24 Thread Uwe Kleine-König
Hello Grygorii, On Mon, Nov 24, 2014 at 03:34:35PM +0200, Grygorii Strashko wrote: On 11/23/2014 10:33 PM, Uwe Kleine-König wrote: A call to .master_xfer with a message sequence implicitly expects ACKs from the slave and doesn't tell anything about what should be done on a NAK. So IMHO you

Re: [4/5] i2c: davinci: use bus recovery infrastructure

2014-11-24 Thread Uwe Kleine-König
Hi Grygorii, On Mon, Nov 24, 2014 at 03:26:10PM +0200, Grygorii Strashko wrote: On 11/23/2014 10:36 PM, Uwe Kleine-König wrote: On Fri, Nov 21, 2014 at 09:33:22PM +0200, Grygorii Strashko wrote: On 11/21/2014 09:07 PM, Uwe Kleine-König wrote: On Thu, Nov 20, 2014 at 12:03:07PM +0200

Re: [5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery

2014-11-23 Thread Uwe Kleine-König
Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] i2c: slave-eeprom: add eeprom simulator driver

2014-11-23 Thread Uwe Kleine-König
a comment. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord

Re: [PATCH 2/3] i2c: slave-eeprom: add eeprom simulator driver

2014-11-23 Thread Uwe Kleine-König
, but starting to get experience with byte banging is probably OK. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux

Re: [2/5] i2c: davinci: query STP always when NACK is received

2014-11-23 Thread Uwe Kleine-König
Hello Grygorii, On Fri, Nov 21, 2014 at 05:33:37PM +0200, Grygorii Strashko wrote: On 11/21/2014 03:10 PM, Uwe Kleine-König wrote: On Fri, Nov 21, 2014 at 02:48:57PM +0200, Grygorii Strashko wrote: On 11/21/2014 12:19 AM, Uwe Kleine-König wrote: diff --git a/drivers/i2c/busses/i2c

Re: [4/5] i2c: davinci: use bus recovery infrastructure

2014-11-23 Thread Uwe Kleine-König
Hello Grygorii, On Fri, Nov 21, 2014 at 09:33:22PM +0200, Grygorii Strashko wrote: On 11/21/2014 09:07 PM, Uwe Kleine-König wrote: On Thu, Nov 20, 2014 at 12:03:07PM +0200, Grygorii Strashko wrote: Just another general comment about the driver that doesn't influence the correctness

Re: [2/5] i2c: davinci: query STP always when NACK is received

2014-11-21 Thread Uwe Kleine-König
Hello, On Fri, Nov 21, 2014 at 02:48:57PM +0200, Grygorii Strashko wrote: On 11/21/2014 12:19 AM, Uwe Kleine-König wrote: diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c index 9bbfb8f..2cef115 100644 --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers

Re: [PATCH 2/3] i2c: slave-eeprom: add eeprom simulator driver

2014-11-21 Thread Uwe Kleine-König
On Fri, Nov 21, 2014 at 08:19:41AM +0100, Uwe Kleine-König wrote: Hello Wolfram, this mail is thematically more a reply to patch 1 and maybe just serves my understanding of the slave support. On Tue, Nov 18, 2014 at 05:04:54PM +0100, Wolfram Sang wrote: From: Wolfram Sang wsa+rene

Re: [3/5] i2c: recovery: change input parameter to i2c_adapter for prepare/unprepare_recovery

2014-11-21 Thread Uwe Kleine-König
Karicheri m-kariche...@ti.com Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com Sounds and looks sensible Acked-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http

Re: [4/5] i2c: davinci: use bus recovery infrastructure

2014-11-21 Thread Uwe Kleine-König
wonder how often this reset triggers. Is the bus in question less stable than others? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send

Re: [1/5] i2c: i2c-davinci: switch to use platform_get_irq

2014-11-20 Thread Uwe Kleine-König
an error if irq=-EPROBE_DEFER. + return irq; } -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body

Re: [2/5] i2c: davinci: query STP always when NACK is received

2014-11-20 Thread Uwe Kleine-König
?) Best regards Uwe return -EREMOTEIO; } return -EIO; -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 2/3] i2c: slave-eeprom: add eeprom simulator driver

2014-11-20 Thread Uwe Kleine-König
. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] i2c: axxia: Add I2C driver for AXM55xx

2014-09-22 Thread Uwe Kleine-König
. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFC 0/4] i2c: slave support framework for Linux devices

2014-09-12 Thread Uwe Kleine-König
wouldn't need device tree stuff, the driver would just offer the device if supported. Userspace then could care about the rest (slave address, functionality, ...). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions

Re: [PATCH] i2c: imx: double check IIF in case interrupt lost

2014-08-15 Thread Uwe Kleine-König
-- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] i2c: imx: double check IIF in case interrupt lost

2014-08-14 Thread Uwe Kleine-König
. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] i2c: imx: double check IIF in case interrupt lost

2014-08-14 Thread Uwe Kleine-König
Hello, On Thu, Aug 14, 2014 at 10:09:42AM +, fugang.d...@freescale.com wrote: From: Uwe Kleine-König u.kleine-koe...@pengutronix.de Sent: Thursday, August 14, 2014 5:42 PM On Thu, Aug 14, 2014 at 04:29:14PM +0800, Fugang Duan wrote: diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers

Re: [PATCH 1/14] i2c: mpc: delete unneeded test before of_node_put

2014-08-08 Thread Uwe Kleine-König
Hello, On Fri, Aug 08, 2014 at 12:07:42PM +0200, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. Thanks for picking up my suggestion. The semantic patch that fixes

Re: [PATCH v2] i2c: efm32: correct namespacing of location property

2014-07-17 Thread Uwe Kleine-König
On Thu, Jul 17, 2014 at 03:40:00PM +0200, Wolfram Sang wrote: On Fri, Jul 11, 2014 at 10:50:14AM +0200, Uwe Kleine-König wrote: Olof Johansson pointed out that usually the company name is picked as namespace prefix to specific properties. So expect energymicro,location but fall back

[PATCH] i2c: efm32: correct namespacing of location property

2014-07-11 Thread Uwe Kleine-König
Olof Johansson pointed out that usually the company name is picked as namespace prefix to specific properties. So expect energymicro,location but fall back to the previously introduced name efm32,location. Cc: Olof Johansson o...@lixom.net Signed-off-by: Uwe Kleine-König u.kleine-koe

[PATCH v2] i2c: efm32: correct namespacing of location property

2014-07-11 Thread Uwe Kleine-König
Olof Johansson pointed out that usually the company name is picked as namespace prefix to specific properties. So expect energymicro,location but fall back to the previously introduced name efm32,location. Cc: Olof Johansson o...@lixom.net Signed-off-by: Uwe Kleine-König u.kleine-koe

Re: [PATCH 06/16] i2c: imx: remove unnecessary OOM messages

2014-05-07 Thread Uwe Kleine-König
On Wed, May 07, 2014 at 01:20:31PM +0900, Jingoo Han wrote: The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han jg1@samsung.com Acked-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Thanks Uwe

Re: [PATCH] i2c: cadence: fix Kconfig dependency

2014-04-07 Thread Uwe Kleine-König
mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from

Re: [PATCH] i2c: cadence: fix Kconfig dependency

2014-04-07 Thread Uwe Kleine-König
Hello, On Mon, Apr 07, 2014 at 10:37:36AM +0400, Alexander Shiyan wrote: Mon, 7 Apr 2014 08:31:00 +0200 от Uwe Kleine-König u.kleine-koe...@pengutronix.de: Hello, On Sun, Apr 06, 2014 at 09:07:07PM +0200, Wolfram Sang wrote: During development, the driver first really needed

  1   2   >