Re: [PATCH v6 3/4] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2021-01-26 Thread Bjorn Andersson
On Mon 25 Jan 22:32 CST 2021, Wesley Cheng wrote: > On 1/25/2021 5:55 PM, Bjorn Andersson wrote: > > On Mon 25 Jan 19:14 CST 2021, Wesley Cheng wrote: > > > >> > >> > >> On 1/22/2021 9:12 AM, Bjorn Andersson wrote: > >>> On Thu 21 Jan 22:01

Re: [PATCH 3/4] phy: qcom-qmp: Add UFS v4 registers found in SM8350

2021-01-26 Thread Bjorn Andersson
; Reviewed-by: Bjorn Andersson > Signed-off-by: Vinod Koul > --- > drivers/phy/qualcomm/phy-qcom-qmp.h | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.h > b/drivers/phy/qualcomm/phy-qcom-qmp.h >

Re: [PATCH v2 6/9] clk: qcom: mmcc-msm8996: Migrate gfx3d clock to clk_rcg2_gfx3d

2021-01-26 Thread Bjorn Andersson
On Wed 13 Jan 12:38 CST 2021, AngeloGioacchino Del Regno wrote: > In commit 734bdefdb043 ("clk: qcom: rcg2: Stop hardcoding gfx3d > pingpong parent numbers") the gfx3d ping-pong ops (clk_gfx3d_ops) I believe you're referring to patch 5 here, which when merged won't have this hash. So you'd need t

Re: [PATCH v4 4/5] dt-bindings: clock: Add SM8350 GCC clock bindings

2021-01-26 Thread Bjorn Andersson
On Tue 26 Jan 02:00 CST 2021, Vinod Koul wrote: > On 25-01-21, 11:25, Bjorn Andersson wrote: > > On Sun 17 Jan 22:43 CST 2021, Vinod Koul wrote: > > > > > Add device tree bindings for global clock controller on SM8350 SoCs. > > > > > > Reviewed-by: Ro

Re: [PATCH] media: firmware: qcom_scm: Simplify the calculation of variables

2021-01-26 Thread Bjorn Andersson
On Tue 26 Jan 02:52 CST 2021, Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./drivers/firmware/qcom_scm.c:324:20-22: WARNING !A || A && B is > equivalent to !A || B. > Reviewed-by: Bjorn Andersson > Reported-by: Abaci Robot >

Re: [PATCH 18/21] clk: qcom: clk-rpm: Remove a bunch of superfluous code

2021-01-26 Thread Bjorn Andersson
On Tue 26 Jan 06:45 CST 2021, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/clk/qcom/clk-rpm.c:453:29: warning: ‘clk_rpm_branch_ops’ defined but > not used [-Wunused-const-variable=] > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc:

Re: [PATCH 16/21] clk: qcom: mmcc-msm8974: Remove unused static const tables 'mmcc_xo_mmpll0_1_2_gpll0{map}'

2021-01-26 Thread Bjorn Andersson
:77:32: warning: > ‘mmcc_xo_mmpll0_1_2_gpll0_map’ defined but not used [-Wunused-const-variable=] > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-arm-...@vger.kernel.org > Cc: linux-...@vger.kernel.org Reviewed-by: Bjorn Andersson >

Re: [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret'

2021-01-26 Thread Bjorn Andersson
riable] > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-arm-...@vger.kernel.org > Cc: linux-...@vger.kernel.org Reviewed-by: Bjorn Andersson > Signed-off-by: Lee Jones > --- > drivers/clk/qcom/gcc-ipq4019.c | 7

Re: [PATCH 04/21] clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param

2021-01-26 Thread Bjorn Andersson
On Tue 26 Jan 06:45 CST 2021, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/clk/qcom/clk-regmap.c:97: warning: Function parameter or member > 'dev' not described in 'devm_clk_register_regmap' > > Cc: Andy Gross > Cc:

[PATCH v2 1/2] dt-bindings: clock: Add SC8180x GCC binding

2021-01-26 Thread Bjorn Andersson
Add devicetree binding for the global clock controller found in the Qualcomm SC8180x platform. Signed-off-by: Bjorn Andersson --- Changes since v1: - None .../bindings/clock/qcom,gcc-sc8180x.yaml | 76 + include/dt-bindings/clock/qcom,gcc-sc8180x.h | 309 ++ 2 files

[PATCH v2 2/2] clk: qcom: gcc: Add global clock controller driver for SC8180x

2021-01-26 Thread Bjorn Andersson
Add clocks, resets and some of the GDSC provided by the global clock controller found in the Qualcomm SC8180x platform. Signed-off-by: Bjorn Andersson --- Changes since v1: - Fixes all gdsc addresses (missed to fold the fixup that subtracted gcc base in v1) drivers/clk/qcom/Kconfig

[PATCH v2 3/3] pinctrl: qcom: Add sc8180x TLMM driver

2021-01-26 Thread Bjorn Andersson
Add pinctrl driver for the sc8180x TLMM block. A noteworthy difference from previous TLMM blocks is that the registers for GPIO 177 through 189 are for some reason offset from the typical layout. Other than that the driver is same old... Signed-off-by: Bjorn Andersson --- drivers/pinctrl/qcom

[PATCH v2 1/3] dt-bindings: pinctrl: qcom: Define common TLMM binding

2021-01-26 Thread Bjorn Andersson
Several properties are shared between all TLMM bindings. By providing a common binding to define these properties each platform's binding can be reduced to just listing which of these properties should be checked for - or further specified. Reviewed-by: Vinod Koul Signed-off-by: Bjorn Ande

[PATCH v2 2/3] dt-bindings: pinctrl: qcom: Add sc8180x binding

2021-01-26 Thread Bjorn Andersson
Add binding for the TLMM block in the Qualcomm SC8180X platform. Signed-off-by: Bjorn Andersson --- .../pinctrl/qcom,sc8180x-pinctrl.yaml | 152 ++ 1 file changed, 152 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml

Re: [PATCH v6 3/4] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2021-01-26 Thread Bjorn Andersson
On Mon 25 Jan 19:14 CST 2021, Wesley Cheng wrote: > > > On 1/22/2021 9:12 AM, Bjorn Andersson wrote: > > On Thu 21 Jan 22:01 CST 2021, Wesley Cheng wrote: > > > > Hi Bjorn, > > > > Under what circumstances should we specify this? And in particular a

Re: [PATCH 4/4] phy: qcom-qmp: Add support for SM8350 UFS phy

2021-01-26 Thread Bjorn Andersson
On Mon 25 Jan 04:09 CST 2021, Vinod Koul wrote: > Add the tables for init sequences for UFS QMP phy found in SM8350 SoC. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Vinod Koul > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 127 +++

Re: [PATCH v3 2/6] drivers: crypto: qce: sha: Hold back a block of data to be transferred as part of final

2021-01-25 Thread Bjorn Andersson
ied to the > destination result buffer. qce_ahash_final cannot be made to alter this > behavior and allowed to proceed if rctx->buflen is 0 because the crypto > engine BAM does not allow for zero length transfers. > Please drop "drivers: " from $subject. Apart from th

Re: [PATCH 3/4] ARM: dts: qcom: msm8974-klte: add support for display

2021-01-25 Thread Bjorn Andersson
On Mon 25 Jan 09:47 CST 2021, Konrad Dybcio wrote: > > > I know how bad it is, so I understand your desire to not have to rebase > > that, but I will merge things as they become ready on the list. > > > > So please post your change (perhaps it's posted and I'm failing to find > > it in my inbox?)

Re: [PATCH 1/2] media: venus: core: Add sdm660 DT compatible and resource struct

2021-01-25 Thread Bjorn Andersson
On Mon 25 Jan 08:51 CST 2021, AngeloGioacchino Del Regno wrote: > Il 25/01/21 11:40, Hans Verkuil ha scritto: > > On 18/01/2021 18:45, AngeloGioacchino Del Regno wrote: > > > Il 18/01/21 18:21, Stanimir Varbanov ha scritto: > > > > > diff --git a/drivers/media/platform/qcom/venus/core.c > > > > >

Re: [PATCH 3/4] ARM: dts: qcom: msm8974-klte: add support for display

2021-01-25 Thread Bjorn Andersson
On Sun 24 Jan 11:33 CST 2021, Konrad Dybcio wrote: > > > All msm8974 dts(i) files use this style. Deviating from it for this doesn't > > make sense. And yes msm8974 should probably be converted to the newer label > > style (as was done with msm8916 a while ago). > > I have a >3k lines commit f

Re: [Linux-stm32] [PATCH] rpmsg: char: return an error if device already open

2021-01-25 Thread Bjorn Andersson
On Fri 15 Jan 03:13 CST 2021, Arnaud POULIQUEN wrote: > Hi Mathieu, > > > On 1/14/21 8:05 PM, Mathieu Poirier wrote: > > On Wed, Jan 06, 2021 at 02:37:14PM +0100, Arnaud Pouliquen wrote: > >> The rpmsg_create_ept function is invoked when the device is opened. > >> As only one endpoint must be cr

Re: [PATCH] [net-next] ipa: add remoteproc dependency

2021-01-25 Thread Bjorn Andersson
On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > Compile-testing without CONFIG_REMOTEPROC results in a build failure: > > >>> referenced by ipa_main.c > >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a > ld.lld: error: undefined symbol:

Re: [PATCH v4 5/5] clk: qcom: gcc: Add clock driver for SM8350

2021-01-25 Thread Bjorn Andersson
Vinod Koul Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/clk/qcom/Kconfig |8 + > drivers/clk/qcom/Makefile |1 + > drivers/clk/qcom/gcc-sm8350.c | 3790 + > 3 files changed, 3799 insertions(+) > create mode 1006

Re: [PATCH v4 1/5] clk: qcom: clk-alpha-pll: replace regval with val

2021-01-25 Thread Bjorn Andersson
On Sun 17 Jan 22:43 CST 2021, Vinod Koul wrote: > Driver uses regval variable for holding register values, replace with a > shorter one val > Reviewed-by: Bjorn Andersson Regards, Bjorn > Suggested-by: Stephen Boyd > Signed-off-by: Vinod Koul > --- > drivers/clk/qcom

Re: [PATCH v4 4/5] dt-bindings: clock: Add SM8350 GCC clock bindings

2021-01-25 Thread Bjorn Andersson
13 > +#define GCC_AGGRE_UFS_CARD_AXI_CLK 14 > +#define GCC_AGGRE_UFS_CARD_AXI_HW_CTL_CLK15 > +#define GCC_AGGRE_UFS_PHY_AXI_CLK16 > +#define GCC_AGGRE_UFS_PHY_AXI_HW_CTL_CLK

Re: [PATCH v4 3/5] clk: qcom: clk-alpha-pll: Add support for Lucid 5LPE PLL

2021-01-25 Thread Bjorn Andersson
On Sun 17 Jan 22:43 CST 2021, Vinod Koul wrote: > From: Vivek Aknurwar > > Lucid 5LPE is a slightly different Lucid PLL with different offsets and > porgramming sequence so add support for these > > Signed-off-by: Vivek Aknurwar > Signed-off-by: Jeevan Shriram > [vkoul: rebase and tidy up for

Re: [PATCH v4 2/5] clk: qcom: clk-alpha-pll: modularize alpha_pll_trion_set_rate()

2021-01-25 Thread Bjorn Andersson
On Sun 17 Jan 22:43 CST 2021, Vinod Koul wrote: > Trion 5LPE set rate uses code similar to alpha_pll_trion_set_rate() but > with different registers. Modularize these by moving out latch and latch > ack bits so that we can reuse the function. > Reviewed-by: Bjorn Andersson Re

Re: [PATCH 2/4] dt-bindings: phy: qcom,qmp: Add SM8350 UFS PHY bindings

2021-01-25 Thread Bjorn Andersson
On Mon 25 Jan 04:09 CST 2021, Vinod Koul wrote: > Add the compatible strings for the UFS PHY found on SM8350 SoC. > Reviewed-by: Bjorn Andersson > Signed-off-by: Vinod Koul > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 + > 1 file changed, 1 inse

Re: [PATCH 1/4] scsi: dt-bindings: ufs: Add sm8250, sm8350 compatible strings

2021-01-25 Thread Bjorn Andersson
ound in SM8350 SoC. > This can/should be picked up independently of the other patches, so would have been better sent solo. Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Vinod Koul > --- > Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 2 ++ >

Re: [PATCH v2 4/4] arm: dts: add 8devices Habanero DVK

2021-01-25 Thread Bjorn Andersson
On Mon 25 Jan 04:59 CST 2021, Robert Marko wrote: > On Fri, Jan 22, 2021 at 7:56 PM Bjorn Andersson > wrote: > > > On Fri 02 Oct 12:41 CDT 2020, Robert Marko wrote: > > > > > On Wed, Sep 9, 2020 at 9:56 PM Robert Marko > > wrote: > > > >

Re: [PATCH] arm: dts: IPQ4019: add SDHCI VQMMC LDO node

2021-01-25 Thread Bjorn Andersson
On Mon 07 Sep 05:19 CDT 2020, Robert Marko wrote: > Since we now have driver for the SDHCI VQMMC LDO needed > for I/0 voltage levels lets introduce the necessary node for it. > > Signed-off-by: Robert Marko > Cc: Luka Perkov > --- > arch/arm/boot/dts/qcom-ipq4019.dtsi | 10 ++ > 1 file

Re: [PATCH v3 6/6] drivers: crypto: qce: Remove totallen and offset in qce_start

2021-01-25 Thread Bjorn Andersson
thentication transformations and is always 0. > Remove these two redundant parameters in qce_start. > Please drop "drivers: " from $subject. Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/common.c | 17 +++

Re: [PATCH v3 5/6] drivers: crypto: qce: Remover src_tbl from qce_cipher_reqctx

2021-01-25 Thread Bjorn Andersson
On Wed 20 Jan 12:48 CST 2021, Thara Gopinath wrote: > src_table is unused and hence remove it from struct qce_cipher_reqctx > > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/cipher.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/crypto/qce/cipher.h b/drivers/crypto

Re: [PATCH v3 4/6] drivers: crypto: qce: common: Set data unit size to message length for AES XTS transformation

2021-01-25 Thread Bjorn Andersson
gone away in the newer chips. I am however not able to find anything about it, so I'm in favor of merging this patch and if anyone actually uses the driver on the older hardware we'd have to go back and quirk it somehow. Acked-by: Bjorn Andersson Regards, Bjorn > - qce_write(qce,

Re: [PATCH v3 3/6] drivers: crypto: qce: skcipher: Fix regressions found during fuzz testing

2021-01-25 Thread Bjorn Andersson
On Wed 20 Jan 12:48 CST 2021, Thara Gopinath wrote: > This patch contains the following fixes for the supported encryption > algorithms in the Qualcomm crypto engine(CE) > 1. Return unsupported if key1 = key2 for AES XTS algorithm since CE > does not support this and the operation causes the engin

Re: [PATCH v3 1/6] drivers: crypto: qce: sha: Restore/save ahash state with custom struct in export/import

2021-01-25 Thread Bjorn Andersson
On Wed 20 Jan 12:48 CST 2021, Thara Gopinath wrote: Please drop "drivers: " from $subject. > Export and import interfaces save and restore partial transformation > states. The partial states were being stored and restored in struct > sha1_state for sha1/hmac(sha1) transformations and sha256_state

Re: [PATCH] bus: qcom: Put child node before return

2021-01-22 Thread Bjorn Andersson
On Fri 22 Jan 16:47 CST 2021, Linus Walleij wrote: > On Thu, Jan 21, 2021 at 12:49 PM Pan Bian wrote: > > > Put child node before return to fix potential reference count leak. > > Generally, the reference count of child is incremented and decremented > > automatically in the macro for_each_avail

Re: [PATCH] ARM: dts: qcom: add prng definition to ipq806x

2021-01-22 Thread Bjorn Andersson
On Sun 29 Nov 12:50 CST 2020, Jonathan McDowell wrote: > Gentle poke; did this just get missed or is there some reason not to > apply it? > There's no reason why this wasn't applied. I've picked it up now. Thank you, Bjorn > On Sun, Jul 05, 2020 at 03:25:44PM +0100, Jonathan McDowell wrote: >

Re: [PATCH v2 4/4] arm: dts: add 8devices Habanero DVK

2021-01-22 Thread Bjorn Andersson
On Fri 02 Oct 12:41 CDT 2020, Robert Marko wrote: > On Wed, Sep 9, 2020 at 9:56 PM Robert Marko wrote: > > > > 8devices Habanero DVK is a dual-band SoM development kit based on Qualcomm > > IPQ4019 + QCA8075 platform. > > > > Specs are: > > CPU: QCA IPQ4019 > > RAM: DDR3L 512MB > > Storage: 32MB

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add gpu support

2021-01-22 Thread Bjorn Andersson
On Wed 30 Dec 09:51 CST 2020, Iskren Chernev wrote: > From: Brian Masney > > Add support for the a3xx GPU > > Signed-off-by: Brian Masney As discussed on IRC I'm waiting for a respin of this with your S-o-b added after Brian's. Thanks, Bjorn > --- > arch/arm/boot/dts/qcom-msm8974.dtsi | 45

Re: [PATCH v6 3/4] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2021-01-22 Thread Bjorn Andersson
On Thu 21 Jan 22:01 CST 2021, Wesley Cheng wrote: > Some devices have USB compositions which may require multiple endpoints > that support EP bursting. HW defined TX FIFO sizes may not always be > sufficient for these compositions. By utilizing flexible TX FIFO > allocation, this allows for endp

Re: [PATCH v5 2/2] pinctrl: qcom: Add SM8350 pinctrl driver

2021-01-21 Thread Bjorn Andersson
m:, but based on the changes you've done I don't think he has certified the origin of this patch anymore. So the line crediting his work above and your alone S-o-b seems more reasonable. For the content of the patch: Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Jeeva

Re: [PATCH v5 1/2] dt-bindings: pinctrl: qcom: Add SM8350 pinctrl bindings

2021-01-21 Thread Bjorn Andersson
On Thu 21 Jan 11:17 CST 2021, Vinod Koul wrote: > Add device tree binding Documentation details for Qualcomm SM8350 > pinctrl driver. > Reviewed-by: Bjorn Andersson Although that's dependent on the acceptance of the common binding in a state similar its current one. Regards, B

Re: [PATCH 1/3] dt-bindings: pinctrl: qcom: Define common TLMM binding

2021-01-21 Thread Bjorn Andersson
On Thu 21 Jan 07:20 CST 2021, Linus Walleij wrote: > On Wed, Jan 20, 2021 at 11:21 PM Bjorn Andersson > wrote: > > > Several properties are shared between all TLMM bindings. By providing a > > common binding to define these properties each platform's binding can be &

Re: [PATCH] pinctrl: qcom: spmi-gpio: Assign boolean values to a bool variable

2021-01-20 Thread Bjorn Andersson
On Wed 20 Jan 01:29 CST 2021, Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c:340:3-15: WARNING: > Assignment of 0/1 to bool variable. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong Reviewe

Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for SC8180x

2021-01-20 Thread Bjorn Andersson
On Wed 20 Jan 16:35 CST 2021, Bjorn Andersson wrote: > diff --git a/drivers/clk/qcom/gcc-sc8180x.c b/drivers/clk/qcom/gcc-sc8180x.c [..] > +static struct gdsc emac_gdsc = { > + .gdscr = 0x106004, Seems like I missed squashing the fixup where I subtract the gcc base address after

[PATCH 2/2] iommu/arm-smmu-qcom: Add Qualcomm SC8180X impl

2021-01-20 Thread Bjorn Andersson
The primary SMMU found in Qualcomm SC8180X platform needs to use the Qualcomm implementation, so add a specific compatible for this. Signed-off-by: Bjorn Andersson --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/arm/arm-smmu/arm

[PATCH 1/2] dt-bindings: arm-smmu-qcom: Add Qualcomm SC8180X compatible

2021-01-20 Thread Bjorn Andersson
Add compatible for the ARM SMMU found in the Qualcomm SC8180x platform. Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree

[PATCH 1/2] dt-bindings: mailbox: qcom: Add SC8180X APCS compatible

2021-01-20 Thread Bjorn Andersson
Add compatible for the Qualcomm SC8180x APCS block to the Qualcomm APCS binding. Signed-off-by: Bjorn Andersson --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss

[PATCH 2/2] mailbox: qcom: Add SC8180X apcs compatible

2021-01-20 Thread Bjorn Andersson
The Qualcomm SC8180X platform has a APSS block exposing the usual IPC bits, add a compatible for this. Signed-off-by: Bjorn Andersson --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom

[PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SC8180X adsp, cdsp and mpss

2021-01-20 Thread Bjorn Andersson
Add compatibles for the Audio DSP, Compute DSP and Modem subsystem found in the Qualcomm SC8180x to the Peripheral Authentication Service remoteproc binding. Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt | 3 +++ 1 file changed, 3 insertions

[PATCH 1/2] dt-bindings: phy: qcom,qmp: Add SC8180X USB phy

2021-01-20 Thread Bjorn Andersson
Add compatibles for the Qualcomm QMP PHY binding for the SuperSpeed USB phys found in the SC8180x platform. Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/qcom

[PATCH 1/2] dt-bindings: soc: qcom: aoss: Add SC8180X compatible

2021-01-20 Thread Bjorn Andersson
Add compatible for the Qualcomm SC8180x platform to the AOSS QMP binding. Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt b

[PATCH 2/2] remoteproc: qcom: pas: Add SC8180X adsp, cdsp and mpss

2021-01-20 Thread Bjorn Andersson
The Qualcomm SC8180X has the typical ADSP, CDSP and MPSS remote processors operated using the PAS interface, add support for these. Attempts to configuring mss.lvl is failing, so a new adsp_data is provided that skips this resource, for now. Signed-off-by: Bjorn Andersson --- drivers

[PATCH 2/2] soc: qcom: aoss: Add SC8180X compatible

2021-01-20 Thread Bjorn Andersson
The Qualcomm SC8180X platform has an AOSS that needs to be communicated with, add a compatible for this. Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/qcom_aoss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c index

[PATCH 2/2] phy: qcom-qmp: Add SC8180X USB phy

2021-01-20 Thread Bjorn Andersson
The Qualcomm SC8180X has two QMP phys used for SuperSpeed USB, which are either the same or very similar to the same found in SM8150. Add a compatible for this, reusing the existing SM8150 USB phy config. Signed-off-by: Bjorn Andersson --- drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++ 1 file

[PATCH 2/2] clk: qcom: rpmhcc: Add sc8180x rpmh clocks

2021-01-20 Thread Bjorn Andersson
Add clocks provides by RPMH in the Qualcomm SC8180x platform. Signed-off-by: Bjorn Andersson --- drivers/clk/qcom/clk-rpmh.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index 6a2a13c5058e..e356291f3ce7

[PATCH 1/2] dt-bindings: power: rpmpd: Add SC8180X to rpmpd binding

2021-01-20 Thread Bjorn Andersson
Add compatible and constants for the power domains exposed by the RPMH in the Qualcomm SC8180X platform. Signed-off-by: Bjorn Andersson --- .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 + include/dt-bindings/power/qcom-rpmpd.h | 13 + 2 files changed, 14

[PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for SC8180x

2021-01-20 Thread Bjorn Andersson
Add clocks, resets and some of the GDSC provided by the global clock controller found in the Qualcomm SC8180x platform. Signed-off-by: Bjorn Andersson --- drivers/clk/qcom/Kconfig |9 + drivers/clk/qcom/Makefile |1 + drivers/clk/qcom/gcc-sc8180x.c | 4629

[PATCH 1/2] dt-bindings: phy: qcom,qmp: Add SC8180X UFS to the QMP binding

2021-01-20 Thread Bjorn Andersson
Add compatible for the SC8180x UFS PHY to the QMP binding. Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings

[PATCH 2/2] regulator: qcom-rpmh: Add pmc8180 and pmc8180c

2021-01-20 Thread Bjorn Andersson
The regulators from PMC8180 and PMC8180C exposed by the RPMH in the Qualcomm SC8180X seems to be the same as PM8150 and PM8150L. Add compatibles for the two new PMICs and reuse the definition of the existing PMICs. Signed-off-by: Bjorn Andersson --- drivers/regulator/qcom-rpmh-regulator.c | 8

[PATCH 1/2] dt-bindings: clock: Add SC8180x GCC binding

2021-01-20 Thread Bjorn Andersson
Add devicetree binding for the global clock controller found in the Qualcomm SC8180x platform. Signed-off-by: Bjorn Andersson --- .../bindings/clock/qcom,gcc-sc8180x.yaml | 76 + include/dt-bindings/clock/qcom,gcc-sc8180x.h | 309 ++ 2 files changed, 385 insertions

[PATCH 1/2] dt-bindings: regulator: qcom-rpmh: Add pmc8180 and pmc8180c

2021-01-20 Thread Bjorn Andersson
Add RPMH regulator compatibles for two of the PMIC variants used on the SC8180x platform. Signed-off-by: Bjorn Andersson --- .../devicetree/bindings/regulator/qcom,rpmh-regulator.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/qcom

[PATCH 2/2] phy: qcom-qmp: Add SC8180X UFS phy

2021-01-20 Thread Bjorn Andersson
The UFS phy found in the Qualcomm SC8180X is either the same or very similar to the phy present in SM8150, so add a compatible and reuse the SM8150 configuration. Signed-off-by: Bjorn Andersson --- drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a

[PATCH 2/2] soc: qcom: rpmhpd: Add SC8180X

2021-01-20 Thread Bjorn Andersson
Add the power domains exposed by RPMH in the Qualcomm SC8180X platform. Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/rpmhpd.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c index 7ce06356d24c..18d5180c0ca0

Re: [PATCH V1] clk: qcom: gcc-sc7180: Mark the MM XO clocks to be always ON

2021-01-20 Thread Bjorn Andersson
On Wed 20 Jan 01:47 CST 2021, Taniya Das wrote: > There are intermittent GDSC power-up failures observed for titan top > gdsc, which requires the XO clock. Thus mark all the MM XO clocks always > enabled from probe. > But if this is the reason for keeping all these {ahb,xo}_clks critical (or ups

[PATCH 1/2] dt-bindings: clock: qcom: rpmhcc: Add sc8180x rpmh clocks

2021-01-20 Thread Bjorn Andersson
Add Qualcomm SC8180x to the list of compatibles for the RPMHCC binding. Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml b/Documentation

[PATCH 2/3] dt-bindings: pinctrl: qcom: Add sc8180x binding

2021-01-20 Thread Bjorn Andersson
Add binding for the TLMM block in the Qualcomm SC8180X platform. Signed-off-by: Bjorn Andersson --- .../pinctrl/qcom,sc8180x-pinctrl.yaml | 153 ++ 1 file changed, 153 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml

[PATCH 3/3] pinctrl: qcom: Add sc8180x TLMM driver

2021-01-20 Thread Bjorn Andersson
Add pinctrl driver for the sc8180x TLMM block. A noteworthy difference from previous TLMM blocks is that the registers for GPIO 177 through 189 are for some reason offset from the typical layout. Other than that the driver is same old... Signed-off-by: Bjorn Andersson --- drivers/pinctrl/qcom

[PATCH 0/3] pinctrl: qcom: TLMM driver for SC8180x

2021-01-20 Thread Bjorn Andersson
These patches introduces a binding documenting the shared properties of all TLMM blocks, then defines the binding for the SC8180x specifically, followed by the actual driver. Bjorn Andersson (3): dt-bindings: pinctrl: qcom: Define common TLMM binding dt-bindings: pinctrl: qcom: Add sc8180x

[PATCH 1/3] dt-bindings: pinctrl: qcom: Define common TLMM binding

2021-01-20 Thread Bjorn Andersson
Several properties are shared between all TLMM bindings. By providing a common binding to define these properties each platform's binding can be reduced to just listing which of these properties should be checked for - or further specified. Signed-off-by: Bjorn Andersson --- .../bin

Re: [PATCH v4 5/7] cpufreq: qcom-hw: Implement CPRh aware OSM programming

2021-01-20 Thread Bjorn Andersson
On Wed 20 Jan 12:25 CST 2021, Taniya Das wrote: > The CPUFREQ-HW driver is intended to be used only for CPUFREQ HW designs > where the firmware programs the look up tables. > It's obvious that this is the intended target for the current version of the driver, but what are your technical argument

[PATCH] dt-bindings: dma: intel-ldma: Fix $ref specifier

2021-01-20 Thread Bjorn Andersson
The $ref for "intel,dma-poll-cnt" is missing an '/', causing dt_binding_check to fail. Fix this. Fixes: afd4df85602d ("dt-bindings: dma: Add bindings for Intel LGM SoC") Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/dma/intel,ldma.yaml | 2 +

[PATCH] media: dt-bindings: media: i2c: Fix $id of renamed ov5647.yaml

2021-01-20 Thread Bjorn Andersson
The recent rename of ov5647.yaml missed to update the $id, resulting in a binding check error. Fix this. Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml") Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml | 2

[PATCH] dt-bindings: dp-connector: Drop maxItems from -supply

2021-01-20 Thread Bjorn Andersson
The meta-schema recently gained a definition for the common -supply$ property, which denotes that maxItems is not a valid property. Drop this to clear up the binding validation error. Fixes: a46c112512de ("dt-bindings: dp-connector: add binding for DisplayPort connector") Signed-off

Re: [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add SM8350 pinctrl bindings

2021-01-19 Thread Bjorn Andersson
On Tue 12 Jan 20:56 CST 2021, Rob Herring wrote: > On Thu, Jan 07, 2021 at 11:17:22AM -0600, Bjorn Andersson wrote: > > On Tue 05 Jan 23:49 CST 2021, Vinod Koul wrote: > > > > > Add device tree binding Documentation details for Qualcomm SM8350 > > > pinctrl d

Re: [PATCH v2 3/4] dt-bindings: phy: qcom,usb-snps-femto-v2: Add SM8250 and SM8350 bindings

2021-01-17 Thread Bjorn Andersson
On Fri 15 Jan 11:47 CST 2021, Jack Pham wrote: > Add the compatible strings for the USB2 PHYs found on QCOM > SM8250 & SM8350 SoCs. > > Note that the SM8250 compatible is already in use in the dts and > driver implementation but was missing from the documentation. >

Re: [PATCH v2 4/4] dt-bindings: usb: qcom,dwc3: Add bindings for SM8150, SM8250, SM8350

2021-01-17 Thread Bjorn Andersson
On Fri 15 Jan 11:47 CST 2021, Jack Pham wrote: > Add compatible strings for the USB DWC3 controller on QCOM SM8150, > SM8250 and SM8350 SoCs. > > Note the SM8150 & SM8250 compatibles are already being used in the > dts but was missing from the documentation. > Review

Re: [PATCH v2 2/4] phy: qcom-qmp: Add SM8350 USB QMP PHYs

2021-01-17 Thread Bjorn Andersson
common and QPHY PCS blocks' register > offsets are largely unchanged from V4 so some of the existing > macros can be reused. > I didn't review the programming sequences, but the rest looks good to me. Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Jack Pham

Re: [PATCH v2 1/4] dt-bindings: phy: qcom,qmp: Add SM8150, SM8250 and SM8350 USB PHY bindings

2021-01-17 Thread Bjorn Andersson
place in > the dts as well as the driver implementation but were missing from > the documentation. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Jack Pham > --- > .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 67 +++ > 1 file changed

Re: [PATCH 1/2] iio:adc:qcom-spmi-vadc: add default scale to LR_MUX2_BAT_ID channel

2021-01-15 Thread Bjorn Andersson
; > qcom,hw-settle-time = <0xb>; > qcom,fast-avg-setup = <0>; > }; > > Change LR_MUX2_BAT_ID scaling accordingly. > Acked-by: Bjorn Andersson Not entirely sure, but looking at the history I think this used to work - but it's obvious that no one h

Re: [PATCH 1/3] dt-bindings: power: Introduce 'assigned-performance-states' property

2021-01-15 Thread Bjorn Andersson
On Thu 24 Dec 05:12 CST 2020, Roja Rani Yarubandi wrote: > While most devices within power-domains which support performance states, > scale the performance state dynamically, some devices might want to > set a static/default performance state while the device is active. > These devices typically

Re: [PATCH 3/3] i2c: i2c-qcom-geni: Add support for 'assigned-performance-states'

2021-01-15 Thread Bjorn Andersson
On Thu 24 Dec 05:12 CST 2020, Roja Rani Yarubandi wrote: > @@ -629,6 +658,16 @@ static int __maybe_unused > geni_i2c_runtime_suspend(struct device *dev) > struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); > > disable_irq(gi2c->irq); > + > + /* Drop the assigned performance state

Re: [PATCH v4 1/2] arm64: dts: sdm845: add oneplus6/6t devices

2021-01-15 Thread Bjorn Andersson
On Fri 15 Jan 06:28 CST 2021, Konrad Dybcio wrote: > > Please move gpio-keys before reserved-memory to keep things sorted. > > > > + vreg_l25a_3p3: ldo25 { > > + regulator-min-microvolt = <330>; > > + regulator-max-microvolt = <3312000>; > > +

Re: [PATCH v2 7/7] arm64: dts: pmi8998: Add the right interrupts for LAB/IBB SCP and OCP

2021-01-14 Thread Bjorn Andersson
d the OCP interrupt in order to be able to > enable the Over-Current Protection feature, if requested. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: AngeloGioacchino Del Regno > > --- > arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 ++-- > 1 file ch

Re: [PATCH v2 6/7] dt-bindings: regulator: qcom-labibb: Document SCP/OCP interrupts

2021-01-14 Thread Bjorn Andersson
On Wed 13 Jan 13:42 CST 2021, AngeloGioacchino Del Regno wrote: > Short-Circuit Protection (SCP) and Over-Current Protection (OCP) are > now implemented in the driver: document the interrupts. > This also fixes wrong documentation about the SCP interrupt for LAB. > Reviewed-by: Bjo

Re: [PATCH v2 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-14 Thread Bjorn Andersson
On Wed 13 Jan 13:42 CST 2021, AngeloGioacchino Del Regno wrote: > Short-Circuit Protection (SCP) and Over-Current Protection (OCP) are > very important for regulators like LAB and IBB, which are designed to > provide from very small to relatively big amounts of current to the > device (normally, a

Re: [PATCH v2 4/7] dt-bindings: regulator: qcom-labibb: Document soft start properties

2021-01-14 Thread Bjorn Andersson
On Wed 13 Jan 13:42 CST 2021, AngeloGioacchino Del Regno wrote: > Document properties to configure soft start and discharge resistor > for LAB and IBB respectively. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: AngeloGioacchino Del Regno > > --- > .

Re: [PATCH v2 3/7] regulator: qcom-labibb: Implement pull-down, softstart, active discharge

2021-01-14 Thread Bjorn Andersson
const struct regulator_desc *desc, > +struct regulator_config *config) > +{ > + struct labibb_regulator *vreg = config->driver_data; > + u32 dischg_kohms, soft_start_time; > + int ret; > + > + ret = of_property_read_u32(np,

Re: [PATCH v2 1/7] regulator: qcom-labibb: Implement voltage selector ops

2021-01-14 Thread Bjorn Andersson
, the supported ranges are the following: > - LAB (pos): 4600mV to 6100mV with 100mV stepping, > - IBB (neg): -7700mV to -1400mV with 100mV stepping. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: AngeloGioacchino Del Regno > > --- > drivers/re

Re: [PATCH v2 2/7] regulator: qcom-labibb: Implement current limiting

2021-01-14 Thread Bjorn Andersson
On Wed 13 Jan 13:42 CST 2021, AngeloGioacchino Del Regno wrote: > LAB and IBB regulators can be current-limited by setting the > appropriate registers, but this operation is granted only after > sending an unlock code for secure access. > > Besides the secure access, it would be possible to use t

Re: [PATCH v3 1/2] arm64: dts: sdm845: add oneplus6/6t devices

2021-01-14 Thread Bjorn Andersson
On Thu 14 Jan 14:33 CST 2021, Konrad Dybcio wrote: > > > The device definitely doesn't support USB3, although downstream does > > leave the USB3 phy enabled the hardware doesn't support it. So it made > > sense to disable it here. > > > Sure. > > > > OnePlus' bootloader doesn't seem to care

Re: [PATCH v2 3/3] dt-bindings: i2c: qcom,i2c-qup: Document noise rejection properties

2021-01-14 Thread Bjorn Andersson
On Thu 14 Jan 11:49 CST 2021, AngeloGioacchino Del Regno wrote: > Document the new noise rejection properties "qcom,noise-reject-sda" > and "qcom,noise-reject-scl". > I presume these are unit-less levels? Reviewed-by: Bjorn Andersson Regards, Bjorn > Sig

Re: [PATCH v2 2/3] i2c: qup: Introduce SCL/SDA noise rejection

2021-01-14 Thread Bjorn Andersson
On Thu 14 Jan 11:49 CST 2021, AngeloGioacchino Del Regno wrote: > Some I2C devices may be glitchy due to electrical noise coming > from the device itself or because of possible board design issues. > To overcome this issue, the QUP's I2C in Qualcomm SoCs supports > a noise rejection setting for bo

Re: [PATCH 2/3] phy: qcom-qusb2: Add configuration for SDM660

2021-01-14 Thread Bjorn Andersson
in the TCSR for clk scheme detection. > Reviewed-by: Bjorn Andersson > Signed-off-by: AngeloGioacchino Del Regno > > --- > drivers/phy/qualcomm/phy-qcom-qusb2.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-q

Re: [PATCH 3/3] dt-bindings: phy: qcom-qusb2: Document SDM660 compatible

2021-01-14 Thread Bjorn Andersson
On Thu 14 Jan 11:47 CST 2021, AngeloGioacchino Del Regno wrote: > Support for the SDM630/660 series of SoCs was added to the driver: > document the qcom,sdm660-qusb2-phy compatible here. > Reviewed-by: Bjorn Andersson > Signed-off-by: AngeloGioacchino Del Regno > > --

Re: [PATCH 1/3] phy: qcom-qusb2: Allow specifying default clock scheme

2021-01-14 Thread Bjorn Andersson
ry and declare it to true for all currently > supported SoCs (retaining the previous defaults. > > This patch brings no functional changes. > Reviewed-by: Bjorn Andersson > Signed-off-by: AngeloGioacchino Del Regno > > --- > drivers/phy/qualcomm/phy-qcom-qusb2.

Re: [PATCH 3/3] soc: qcom: mdt_loader: Read hash from firmware blob

2021-01-14 Thread Bjorn Andersson
On Wed 13 Jan 17:01 CST 2021, Siddharth Gupta wrote: > > On 1/7/2021 4:21 PM, Bjorn Andersson wrote: > > On Wed 06 Jan 15:23 CST 2021, Siddharth Gupta wrote: > > > > > Since the split elf blobs will always contain the hash segment, we rely on > > I think it wil

Re: [PATCH v5 4/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2021-01-14 Thread Bjorn Andersson
On Thu 14 Jan 01:14 CST 2021, Stephen Boyd wrote: > Quoting Douglas Anderson (2021-01-08 09:35:16) > > Let's deal with the problem like this: > > * When we mux away, we'll mask our interrupt. This isn't necessary in > > the above case since the client already masked us, but it's a good > > id

Re: [PATCH v5 4/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2021-01-14 Thread Bjorn Andersson
On Thu 14 Jan 01:14 CST 2021, Stephen Boyd wrote: > Quoting Douglas Anderson (2021-01-08 09:35:16) > > Let's deal with the problem like this: > > * When we mux away, we'll mask our interrupt. This isn't necessary in > > the above case since the client already masked us, but it's a good > > id

<    1   2   3   4   5   6   7   8   9   10   >