On Mon, 22 Oct 2018 11:43:40 +
Yogesh Narayan Gaur wrote:
> + Mark Brown
>
> Complete patch series[1]
> [1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=70210
Please resend the patch series with a "PATCH RESEND v4" prefix and
explain why you resend it in the cover letter.
>
On Mon, 22 Oct 2018 11:43:40 +
Yogesh Narayan Gaur wrote:
> + Mark Brown
>
> Complete patch series[1]
> [1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=70210
Please resend the patch series with a "PATCH RESEND v4" prefix and
explain why you resend it in the cover letter.
>
On Mon, 22 Oct 2018 11:03:09 +
Yogesh Narayan Gaur wrote:
> Hi,
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Monday, October 22, 2018 4:23 PM
> > To: Yogesh Narayan Gaur ;
> > cristian.bir...
On Mon, 22 Oct 2018 11:03:09 +
Yogesh Narayan Gaur wrote:
> Hi,
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Monday, October 22, 2018 4:23 PM
> > To: Yogesh Narayan Gaur ;
> > cristian.bir...
On Mon, 22 Oct 2018 12:46:27 +0200
Boris Brezillon wrote:
> On Mon, 22 Oct 2018 10:39:48 +
> Yogesh Narayan Gaur wrote:
>
> >
> > [1.632190] Start [addr_width:, read_dumy:08,
> > read_opcode:]
On Mon, 22 Oct 2018 12:46:27 +0200
Boris Brezillon wrote:
> On Mon, 22 Oct 2018 10:39:48 +
> Yogesh Narayan Gaur wrote:
>
> >
> > [1.632190] Start [addr_width:, read_dumy:08,
> > read_opcode:]
On Mon, 22 Oct 2018 10:39:48 +
Yogesh Narayan Gaur wrote:
>
> [1.632190] Start [addr_width:, read_dumy:08,
> read_opcode:]
> [1.639148] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc
>
On Mon, 22 Oct 2018 10:39:48 +
Yogesh Narayan Gaur wrote:
>
> [1.632190] Start [addr_width:, read_dumy:08,
> read_opcode:]
> [1.639148] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc
>
On Mon, 22 Oct 2018 10:03:55 +
Yogesh Narayan Gaur wrote:
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -2863,26 +2863,36 @@ static u8 spi_nor_smpt_read_dummy(const struct
> spi_nor *nor, const u32 settings)
> * @nor: pointer to a 'struct spi_nor'
On Mon, 22 Oct 2018 10:03:55 +
Yogesh Narayan Gaur wrote:
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -2863,26 +2863,36 @@ static u8 spi_nor_smpt_read_dummy(const struct
> spi_nor *nor, const u32 settings)
> * @nor: pointer to a 'struct spi_nor'
On Mon, 22 Oct 2018 10:17:58 +
Yogesh Narayan Gaur wrote:
> It works,
Not really.
> [1.628162] m25p80 spi0.0: found s25fl512s, expected m25p80
>
> [1.633854] Start [addr_width:, read_dumy:08,
>
On Mon, 22 Oct 2018 10:17:58 +
Yogesh Narayan Gaur wrote:
> It works,
Not really.
> [1.628162] m25p80 spi0.0: found s25fl512s, expected m25p80
>
> [1.633854] Start [addr_width:, read_dumy:08,
>
On Mon, 22 Oct 2018 10:03:55 +
Yogesh Narayan Gaur wrote:
> [1.624684] m25p80 spi0.0: found s25fl512s, expected m25p80
> [1.630377] Start [addr_width:, read_dumy:08, read_opcode:]
> [1.637335] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc
> [1.642641]
On Mon, 22 Oct 2018 10:03:55 +
Yogesh Narayan Gaur wrote:
> [1.624684] m25p80 spi0.0: found s25fl512s, expected m25p80
> [1.630377] Start [addr_width:, read_dumy:08, read_opcode:]
> [1.637335] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc
> [1.642641]
On Mon, 22 Oct 2018 10:03:55 +
Yogesh Narayan Gaur wrote:
> Hi,
>
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Monday, October 22, 2018 2:46 PM
> > To: Yogesh Narayan Gaur
> > Cc: Tudor A
On Mon, 22 Oct 2018 10:03:55 +
Yogesh Narayan Gaur wrote:
> Hi,
>
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Monday, October 22, 2018 2:46 PM
> > To: Yogesh Narayan Gaur
> > Cc: Tudor A
On Mon, 22 Oct 2018 06:04:13 +
Yogesh Narayan Gaur wrote:
> - /* Find the matching configuration map */
> - while (SMPT_MAP_ID(smpt[i]) != map_id) {
> - if (smpt[i] & SMPT_DESC_END)
> - goto out;
> + if (map_id_is_valid)
> +
On Mon, 22 Oct 2018 06:04:13 +
Yogesh Narayan Gaur wrote:
> - /* Find the matching configuration map */
> - while (SMPT_MAP_ID(smpt[i]) != map_id) {
> - if (smpt[i] & SMPT_DESC_END)
> - goto out;
> + if (map_id_is_valid)
> +
On Mon, 22 Oct 2018 08:32:21 +
Yogesh Narayan Gaur wrote:
> HI,
>
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Monday, October 22, 2018 1:32 PM
> > To: Yogesh Narayan Gaur
> > Cc: Cyrille
On Mon, 22 Oct 2018 08:32:21 +
Yogesh Narayan Gaur wrote:
> HI,
>
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Monday, October 22, 2018 1:32 PM
> > To: Yogesh Narayan Gaur
> > Cc: Cyrille
On Mon, 22 Oct 2018 06:04:13 +
Yogesh Narayan Gaur wrote:
> -static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const u32
> *smpt)
> +static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const u32
> *smpt, u32 smpt_len)
> {
> const u32 *ret = NULL;
> -
On Mon, 22 Oct 2018 06:04:13 +
Yogesh Narayan Gaur wrote:
> -static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const u32
> *smpt)
> +static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const u32
> *smpt, u32 smpt_len)
> {
> const u32 *ret = NULL;
> -
On Mon, 22 Oct 2018 06:04:13 +
Yogesh Narayan Gaur wrote:
> Hi Boris, Tudor,
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Wednesday, October 17, 2018 3:23 PM
> > To: Yogesh Narayan Gaur
> >
On Mon, 22 Oct 2018 06:04:13 +
Yogesh Narayan Gaur wrote:
> Hi Boris, Tudor,
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Wednesday, October 17, 2018 3:23 PM
> > To: Yogesh Narayan Gaur
> >
On Fri, 19 Oct 2018 16:29:40 +0800
Liang Yang wrote:
> On 2018/10/19 4:50, Boris Brezillon wrote:
> > On Thu, 18 Oct 2018 13:09:05 +0800
> > Jianxin Pan wrote:
> >
> >> +static int meson_nfc_buffer_init(struct mtd_info *mtd)
> >> +{
> >
On Fri, 19 Oct 2018 16:29:40 +0800
Liang Yang wrote:
> On 2018/10/19 4:50, Boris Brezillon wrote:
> > On Thu, 18 Oct 2018 13:09:05 +0800
> > Jianxin Pan wrote:
> >
> >> +static int meson_nfc_buffer_init(struct mtd_info *mtd)
> >> +{
> >
On Fri, 19 Oct 2018 15:29:05 +0800
Liang Yang wrote:
> > How about defining that the HW returns an array of __le64 instead and then
> > define the following macros which you can use after converting in the
> > CPU endianness
> >
> > #define ECC_GET_PROTECTED_OOB_BYTE(x, y)(((x) >> (8 * (1 +
On Fri, 19 Oct 2018 15:29:05 +0800
Liang Yang wrote:
> > How about defining that the HW returns an array of __le64 instead and then
> > define the following macros which you can use after converting in the
> > CPU endianness
> >
> > #define ECC_GET_PROTECTED_OOB_BYTE(x, y)(((x) >> (8 * (1 +
On Thu, 18 Oct 2018 13:09:05 +0800
Jianxin Pan wrote:
> +static int meson_nfc_buffer_init(struct mtd_info *mtd)
> +{
> + struct nand_chip *nand = mtd_to_nand(mtd);
> + struct meson_nfc *nfc = nand_get_controller_data(nand);
> + static int max_page_bytes, max_info_bytes;
> + int
On Thu, 18 Oct 2018 13:09:05 +0800
Jianxin Pan wrote:
> +static int meson_nfc_buffer_init(struct mtd_info *mtd)
> +{
> + struct nand_chip *nand = mtd_to_nand(mtd);
> + struct meson_nfc *nfc = nand_get_controller_data(nand);
> + static int max_page_bytes, max_info_bytes;
> + int
On Thu, 18 Oct 2018 13:09:05 +0800
Jianxin Pan wrote:
> +static int meson_nfc_calc_set_timing(struct meson_nfc *nfc,
> + const struct nand_sdr_timings *timings)
> +{
> + struct nand_timing *timing = >timing;
> + int div, bt_min, bt_max, bus_timing;
> +
On Thu, 18 Oct 2018 13:09:05 +0800
Jianxin Pan wrote:
> +static int meson_nfc_calc_set_timing(struct meson_nfc *nfc,
> + const struct nand_sdr_timings *timings)
> +{
> + struct nand_timing *timing = >timing;
> + int div, bt_min, bt_max, bus_timing;
> +
On Thu, 18 Oct 2018 13:09:05 +0800
Jianxin Pan wrote:
> +static int meson_nand_bch_mode(struct nand_chip *nand)
> +{
> + struct meson_nfc_nand_chip *meson_chip = to_meson_nand(nand);
> + struct meson_nand_ecc meson_ecc[] = {
> + MESON_ECC_DATA(NFC_ECC_BCH8_1K, 8),
> +
On Thu, 18 Oct 2018 13:09:05 +0800
Jianxin Pan wrote:
> +static int meson_nand_bch_mode(struct nand_chip *nand)
> +{
> + struct meson_nfc_nand_chip *meson_chip = to_meson_nand(nand);
> + struct meson_nand_ecc meson_ecc[] = {
> + MESON_ECC_DATA(NFC_ECC_BCH8_1K, 8),
> +
On Thu, 18 Oct 2018 13:09:05 +0800
Jianxin Pan wrote:
> From: Liang Yang
>
> Add initial support for the Amlogic NAND flash controller which found
> in the Meson-GXBB/GXL/AXG SoCs.
>
> Signed-off-by: Liang Yang
> Signed-off-by: Yixun Lan
> Signed-off-by: Jianxin Pan
> ---
>
On Thu, 18 Oct 2018 13:09:05 +0800
Jianxin Pan wrote:
> From: Liang Yang
>
> Add initial support for the Amlogic NAND flash controller which found
> in the Meson-GXBB/GXL/AXG SoCs.
>
> Signed-off-by: Liang Yang
> Signed-off-by: Yixun Lan
> Signed-off-by: Jianxin Pan
> ---
>
On Thu, 18 Oct 2018 13:09:05 +0800
Jianxin Pan wrote:
> +static int meson_nfc_exec_op(struct nand_chip *chip,
> + const struct nand_operation *op, bool check_only)
> +{
> + struct mtd_info *mtd = nand_to_mtd(chip);
> + struct meson_nfc *nfc =
On Thu, 18 Oct 2018 13:09:05 +0800
Jianxin Pan wrote:
> +static int meson_nfc_exec_op(struct nand_chip *chip,
> + const struct nand_operation *op, bool check_only)
> +{
> + struct mtd_info *mtd = nand_to_mtd(chip);
> + struct meson_nfc *nfc =
On Wed, 17 Oct 2018 07:46:30 +
Yogesh Narayan Gaur wrote:
> Hi Boris,
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Wednesday, October 17, 2018 1:00 PM
> > To: Yogesh Narayan Gaur
> >
On Wed, 17 Oct 2018 07:46:30 +
Yogesh Narayan Gaur wrote:
> Hi Boris,
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Wednesday, October 17, 2018 1:00 PM
> > To: Yogesh Narayan Gaur
> >
On Wed, 17 Oct 2018 08:20:19 +
Yogesh Narayan Gaur wrote:
> Hi Tudor,
>
> > -Original Message-
> > From: Tudor Ambarus [mailto:tudor.amba...@microchip.com]
> > Sent: Wednesday, October 17, 2018 1:31 PM
> > To: Yogesh Narayan Gaur ; Boris Brezillo
On Wed, 17 Oct 2018 08:20:19 +
Yogesh Narayan Gaur wrote:
> Hi Tudor,
>
> > -Original Message-
> > From: Tudor Ambarus [mailto:tudor.amba...@microchip.com]
> > Sent: Wednesday, October 17, 2018 1:31 PM
> > To: Yogesh Narayan Gaur ; Boris Brezillo
On Wed, 17 Oct 2018 09:10:45 +0200
Boris Brezillon wrote:
> On Wed, 17 Oct 2018 09:07:24 +0200
> Boris Brezillon wrote:
>
> > On Wed, 17 Oct 2018 02:07:43 +
> > Yogesh Narayan Gaur wrote:
> >
> > > >
> > > Actually there is
On Wed, 17 Oct 2018 09:10:45 +0200
Boris Brezillon wrote:
> On Wed, 17 Oct 2018 09:07:24 +0200
> Boris Brezillon wrote:
>
> > On Wed, 17 Oct 2018 02:07:43 +
> > Yogesh Narayan Gaur wrote:
> >
> > > >
> > > Actually there is
On Wed, 17 Oct 2018 09:10:45 +0200
Boris Brezillon wrote:
> On Wed, 17 Oct 2018 09:07:24 +0200
> Boris Brezillon wrote:
>
> > On Wed, 17 Oct 2018 02:07:43 +
> > Yogesh Narayan Gaur wrote:
> >
> > > >
> > > Actually there is
On Wed, 17 Oct 2018 09:10:45 +0200
Boris Brezillon wrote:
> On Wed, 17 Oct 2018 09:07:24 +0200
> Boris Brezillon wrote:
>
> > On Wed, 17 Oct 2018 02:07:43 +
> > Yogesh Narayan Gaur wrote:
> >
> > > >
> > > Actually there is
On Wed, 17 Oct 2018 09:07:24 +0200
Boris Brezillon wrote:
> On Wed, 17 Oct 2018 02:07:43 +
> Yogesh Narayan Gaur wrote:
>
> > >
> > Actually there is no entry of s25fs512s in current spi-nor.c file.
> > For my connected flash part, jedec ID read points
On Wed, 17 Oct 2018 09:07:24 +0200
Boris Brezillon wrote:
> On Wed, 17 Oct 2018 02:07:43 +
> Yogesh Narayan Gaur wrote:
>
> > >
> > Actually there is no entry of s25fs512s in current spi-nor.c file.
> > For my connected flash part, jedec ID read points
On Wed, 17 Oct 2018 02:07:43 +
Yogesh Narayan Gaur wrote:
> >
> Actually there is no entry of s25fs512s in current spi-nor.c file.
> For my connected flash part, jedec ID read points to s25fl512s. I
> have asked my board team to confirm the name of exact connected flash
> part. When I
On Wed, 17 Oct 2018 02:07:43 +
Yogesh Narayan Gaur wrote:
> >
> Actually there is no entry of s25fs512s in current spi-nor.c file.
> For my connected flash part, jedec ID read points to s25fl512s. I
> have asked my board team to confirm the name of exact connected flash
> part. When I
On Wed, 17 Oct 2018 10:08:11 +0800
masonccy...@mxic.com.tw wrote:
> From: Mason Yang
>
> Add a driver for Macronix SPI controller IP.
>
> Signed-off-by: Mason Yang
Reviewed-by: Boris Brezillon
> ---
> drivers/spi/Kconfig| 6 +
> drivers/spi/Makefile |
On Wed, 17 Oct 2018 10:08:11 +0800
masonccy...@mxic.com.tw wrote:
> From: Mason Yang
>
> Add a driver for Macronix SPI controller IP.
>
> Signed-off-by: Mason Yang
Reviewed-by: Boris Brezillon
> ---
> drivers/spi/Kconfig| 6 +
> drivers/spi/Makefile |
gt; +- reg-names: should contain "regs" and "dirmap"
> +- interrupts: interrupt line connected to the SPI controller
> +- clock-names: should contain "ps_clk", "send_clk" and "send_dly_clk"
The _clk suffix is unnecessary in my opinion. How abo
gt; +- reg-names: should contain "regs" and "dirmap"
> +- interrupts: interrupt line connected to the SPI controller
> +- clock-names: should contain "ps_clk", "send_clk" and "send_dly_clk"
The _clk suffix is unnecessary in my opinion. How abo
On Tue, 16 Oct 2018 14:04:11 +0200
Boris Brezillon wrote:
> On Tue, 16 Oct 2018 09:51:47 +
> Yogesh Narayan Gaur wrote:
>
> > Hi Tudor,
> >
> > This patch is breaking the 1-4-4 Read protocol for the spansion flash
> > "s25fl512s".
> >
>
On Tue, 16 Oct 2018 14:04:11 +0200
Boris Brezillon wrote:
> On Tue, 16 Oct 2018 09:51:47 +
> Yogesh Narayan Gaur wrote:
>
> > Hi Tudor,
> >
> > This patch is breaking the 1-4-4 Read protocol for the spansion flash
> > "s25fl512s".
> >
>
On Tue, 16 Oct 2018 09:51:47 +
Yogesh Narayan Gaur wrote:
> Hi Tudor,
>
> This patch is breaking the 1-4-4 Read protocol for the spansion flash
> "s25fl512s".
>
> Without this patch read request command for Quad mode, 4-byte enable, is
> coming as 0xEC i.e. SPINOR_OP_READ_1_4_4_4B.
> But
On Tue, 16 Oct 2018 09:51:47 +
Yogesh Narayan Gaur wrote:
> Hi Tudor,
>
> This patch is breaking the 1-4-4 Read protocol for the spansion flash
> "s25fl512s".
>
> Without this patch read request command for Quad mode, 4-byte enable, is
> coming as 0xEC i.e. SPINOR_OP_READ_1_4_4_4B.
> But
time macros.
>
> Signed-off-by: Masahiro Yamada
Reviewed-by: Boris Brezillon
> ---
>
> drivers/mtd/nand/raw/denali.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/denali.h b/drivers/mtd/nand/raw/denali.h
> index 57a549
time macros.
>
> Signed-off-by: Masahiro Yamada
Reviewed-by: Boris Brezillon
> ---
>
> drivers/mtd/nand/raw/denali.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/denali.h b/drivers/mtd/nand/raw/denali.h
> index 57a549
On Tue, 16 Oct 2018 18:26:34 +0800
Hou Tao wrote:
> On 2018/10/16 14:41, Richard Weinberger wrote:
> > On Tue, Oct 16, 2018 at 7:53 AM Hou Tao wrote:
> >>
> >> ping ?
> >>
> >> On 2018/10/6 17:09, Hou Tao wrote:
> >>> When an invalid mount option is passed to jffs2, jffs2_parse_options()
>
On Tue, 16 Oct 2018 18:26:34 +0800
Hou Tao wrote:
> On 2018/10/16 14:41, Richard Weinberger wrote:
> > On Tue, Oct 16, 2018 at 7:53 AM Hou Tao wrote:
> >>
> >> ping ?
> >>
> >> On 2018/10/6 17:09, Hou Tao wrote:
> >>> When an invalid mount option is passed to jffs2, jffs2_parse_options()
>
Hi Yogesh,
On Mon, 15 Oct 2018 11:47:55 +
Yogesh Narayan Gaur wrote:
> Add support for octal mode IO data transfer.
> Micron flash, mt35xu512aba, supports octal mode data transfer and
> NXP FlexSPI controller supports 8 data lines for data transfer (Rx/Tx).
>
> Patch series
> * Add support
Hi Yogesh,
On Mon, 15 Oct 2018 11:47:55 +
Yogesh Narayan Gaur wrote:
> Add support for octal mode IO data transfer.
> Micron flash, mt35xu512aba, supports octal mode data transfer and
> NXP FlexSPI controller supports 8 data lines for data transfer (Rx/Tx).
>
> Patch series
> * Add support
Hi Mason,
On Mon, 15 Oct 2018 16:26:15 +0800
masonccy...@mxic.com.tw wrote:
> +
> +static int mxic_spi_setup(struct spi_device *spi)
> +{
> + return 0;
> +}
Drop this empty function and leave ->setup to NULL.
> +
> +static int mxic_spi_probe(struct platform_device *pdev)
> +{
> +
Hi Mason,
On Mon, 15 Oct 2018 16:26:15 +0800
masonccy...@mxic.com.tw wrote:
> +
> +static int mxic_spi_setup(struct spi_device *spi)
> +{
> + return 0;
> +}
Drop this empty function and leave ->setup to NULL.
> +
> +static int mxic_spi_probe(struct platform_device *pdev)
> +{
> +
calculations based on
^ with
> priv->io_base.
Can we do that in 2 steps?
1/ Stop using .IO_ADDR_R/W
2/ Convert the driver to ->exec_op()
>
> Suggested-by: Boris Brezillon
> Signed-off-by: Janusz Krzysztofik
> ---
[...]
> -static int ams_delta_nand_r
calculations based on
^ with
> priv->io_base.
Can we do that in 2 steps?
1/ Stop using .IO_ADDR_R/W
2/ Convert the driver to ->exec_op()
>
> Suggested-by: Boris Brezillon
> Signed-off-by: Janusz Krzysztofik
> ---
[...]
> -static int ams_delta_nand_r
Hi Janusz,
On Fri, 12 Oct 2018 22:41:00 +0200
Janusz Krzysztofik wrote:
> Each controller driver with access to NAND R/B pin over GPIO would have
> to reimplement the polling loop otherwise.
>
> Signed-off-by: Janusz Krzysztofik
> ---
> Changelog:
> v2:
> New patch - v1 consisted of only one
Hi Janusz,
On Fri, 12 Oct 2018 22:41:00 +0200
Janusz Krzysztofik wrote:
> Each controller driver with access to NAND R/B pin over GPIO would have
> to reimplement the polling loop otherwise.
>
> Signed-off-by: Janusz Krzysztofik
> ---
> Changelog:
> v2:
> New patch - v1 consisted of only one
On Tue, 28 Aug 2018 22:32:57 +0800
Liu Xiang wrote:
> If the size of spi-nor flash is larger than 16MB, the read_opcode
> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
> cause read operation fail.
>
> Fixes:
On Tue, 28 Aug 2018 22:32:57 +0800
Liu Xiang wrote:
> If the size of spi-nor flash is larger than 16MB, the read_opcode
> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
> cause read operation fail.
>
> Fixes:
On Fri, 12 Oct 2018 11:19:52 +0200
Arnd Bergmann wrote:
> On Fri, Oct 12, 2018 at 11:16 AM Boris Brezillon
> wrote:
> >
> > Hi Arnd,
> >
> > On Wed, 10 Oct 2018 20:44:50 +0200
> > Arnd Bergmann wrote:
> >
> > > Enabling -Wvla found another
On Fri, 12 Oct 2018 11:19:52 +0200
Arnd Bergmann wrote:
> On Fri, Oct 12, 2018 at 11:16 AM Boris Brezillon
> wrote:
> >
> > Hi Arnd,
> >
> > On Wed, 10 Oct 2018 20:44:50 +0200
> > Arnd Bergmann wrote:
> >
> > > Enabling -Wvla found another
Hi Arnd,
On Wed, 10 Oct 2018 20:44:50 +0200
Arnd Bergmann wrote:
> Enabling -Wvla found another variable-length array with randconfig
> testing:
>
> drivers/mtd/maps/sa1100-flash.c: In function 'sa1100_setup_mtd':
> drivers/mtd/maps/sa1100-flash.c:224:10: error: ISO C90 forbids variable
>
Hi Arnd,
On Wed, 10 Oct 2018 20:44:50 +0200
Arnd Bergmann wrote:
> Enabling -Wvla found another variable-length array with randconfig
> testing:
>
> drivers/mtd/maps/sa1100-flash.c: In function 'sa1100_setup_mtd':
> drivers/mtd/maps/sa1100-flash.c:224:10: error: ISO C90 forbids variable
>
Hi Vignesh,
On Mon, 8 Oct 2018 21:06:02 +0530
Vignesh R wrote:
> Hi Boris,
>
> Sorry I missed this mail.
>
> On Thursday 04 October 2018 04:47 PM, Boris Brezillon wrote:
> > On Thu, 4 Oct 2018 16:05:36 +0530
> > Vignesh R wrote:
> >
> >>>
Hi Vignesh,
On Mon, 8 Oct 2018 21:06:02 +0530
Vignesh R wrote:
> Hi Boris,
>
> Sorry I missed this mail.
>
> On Thursday 04 October 2018 04:47 PM, Boris Brezillon wrote:
> > On Thu, 4 Oct 2018 16:05:36 +0530
> > Vignesh R wrote:
> >
> >>>
Arnd Bergmann (1):
lib/bch: fix possible stack overrun
lib/Makefile | 1 -
lib/bch.c| 17 +
2 files changed, 13 insertions(+), 5 deletions(-)
--
Boris Brezillon, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Arnd Bergmann (1):
lib/bch: fix possible stack overrun
lib/Makefile | 1 -
lib/bch.c| 17 +
2 files changed, 13 insertions(+), 5 deletions(-)
--
Boris Brezillon, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
On Fri, 12 Oct 2018 02:23:08 +
Yogesh Narayan Gaur wrote:
> Some MICRON related macros in spi-nor domain were ST.
> Rename entries related to STMicroelectronics under macro SNOR_MFR_ST.
>
> Added entry of MFR Id for Micron flashes, 0x002C.
>
> Signed-off-by: Yogesh Gaur
> Reviewed-by:
On Fri, 12 Oct 2018 02:23:08 +
Yogesh Narayan Gaur wrote:
> Some MICRON related macros in spi-nor domain were ST.
> Rename entries related to STMicroelectronics under macro SNOR_MFR_ST.
>
> Added entry of MFR Id for Micron flashes, 0x002C.
>
> Signed-off-by: Yogesh Gaur
> Reviewed-by:
On Fri, 28 Sep 2018 16:21:25 -0700
Eric Anholt wrote:
> Since this is UAPI, it's good to document what exactly the guarantees
> we're providing are.
>
> Signed-off-by: Eric Anholt
Reviewed-by: Boris Brezillon
> ---
> include/uapi/drm/v3d_drm.h | 10 ++
>
On Fri, 28 Sep 2018 16:21:25 -0700
Eric Anholt wrote:
> Since this is UAPI, it's good to document what exactly the guarantees
> we're providing are.
>
> Signed-off-by: Eric Anholt
Reviewed-by: Boris Brezillon
> ---
> include/uapi/drm/v3d_drm.h | 10 ++
>
a slow clock, not that the driver was slow.
>
> Signed-off-by: Eric Anholt
Reviewed-by: Boris Brezillon
> ---
> drivers/gpu/drm/v3d/v3d_debugfs.c | 35 +++
> drivers/gpu/drm/v3d/v3d_regs.h| 30 ++
> 2 files changed, 65 insertions(+)
>
a slow clock, not that the driver was slow.
>
> Signed-off-by: Eric Anholt
Reviewed-by: Boris Brezillon
> ---
> drivers/gpu/drm/v3d/v3d_debugfs.c | 35 +++
> drivers/gpu/drm/v3d/v3d_regs.h| 30 ++
> 2 files changed, 65 insertions(+)
>
On Tue, 9 Oct 2018 09:52:23 +
Chuanhua Han wrote:
> 1. In the dspi driver (spi controller), bits_per_word
> (dspi->bits_per_word = transfer->bits_per_word) passed from the upper
> layer (spi-mem.c) is used. In this way, I can only assign the
> appropriate value of transfer->bits_per_word
On Tue, 9 Oct 2018 09:52:23 +
Chuanhua Han wrote:
> 1. In the dspi driver (spi controller), bits_per_word
> (dspi->bits_per_word = transfer->bits_per_word) passed from the upper
> layer (spi-mem.c) is used. In this way, I can only assign the
> appropriate value of transfer->bits_per_word
On Mon, 8 Oct 2018 16:41:39 +0530
Yogesh Gaur wrote:
> +/* Registers used by the driver */
> +#define FSPI_MCR00x00
> +#define FSPI_MCR0_AHB_TIMEOUT_MASK GENMASK(31, 24)
> +#define FSPI_MCR0_IP_TIMEOUT_MASKGENMASK(23, 16)
You never mask the IP_TIMEOUT val, so you
On Mon, 8 Oct 2018 16:41:39 +0530
Yogesh Gaur wrote:
> +/* Registers used by the driver */
> +#define FSPI_MCR00x00
> +#define FSPI_MCR0_AHB_TIMEOUT_MASK GENMASK(31, 24)
> +#define FSPI_MCR0_IP_TIMEOUT_MASKGENMASK(23, 16)
You never mask the IP_TIMEOUT val, so you
On Mon, 8 Oct 2018 11:21:13 +
Yogesh Narayan Gaur wrote:
> > > +static void nxp_fspi_read_ahb(struct nxp_fspi *f, const struct
> > > +spi_mem_op *op) {
> > > + u32 len = op->data.nbytes;
> > > +
> > > + /* Read out the data directly from the AHB buffer. */
> > > +
On Mon, 8 Oct 2018 11:21:13 +
Yogesh Narayan Gaur wrote:
> > > +static void nxp_fspi_read_ahb(struct nxp_fspi *f, const struct
> > > +spi_mem_op *op) {
> > > + u32 len = op->data.nbytes;
> > > +
> > > + /* Read out the data directly from the AHB buffer. */
> > > +
On Mon, 8 Oct 2018 09:40:09 +0200
Ricardo Ribalda Delgado wrote:
> Hi Boris
> On Fri, Oct 5, 2018 at 9:32 PM Boris Brezillon
> wrote:
> >
> > On Fri, 5 Oct 2018 20:12:43 +0200
> > Ricardo Ribalda Delgado wrote:
> >
> > >
> > > I think
On Mon, 8 Oct 2018 09:40:09 +0200
Ricardo Ribalda Delgado wrote:
> Hi Boris
> On Fri, Oct 5, 2018 at 9:32 PM Boris Brezillon
> wrote:
> >
> > On Fri, 5 Oct 2018 20:12:43 +0200
> > Ricardo Ribalda Delgado wrote:
> >
> > >
> > > I think
Hi Mason,
On Mon, 8 Oct 2018 10:25:31 +0800
masonccy...@mxic.com.tw wrote:
> +static int mxic_spi_clk_enable(struct mxic_spi *mxic)
> +{
> + int ret;
> +
> + ret = clk_prepare_enable(mxic->send_clk);
> + if (ret)
> + goto out;
Please don't use gotos when it's not
Hi Mason,
On Mon, 8 Oct 2018 10:25:31 +0800
masonccy...@mxic.com.tw wrote:
> +static int mxic_spi_clk_enable(struct mxic_spi *mxic)
> +{
> + int ret;
> +
> + ret = clk_prepare_enable(mxic->send_clk);
> + if (ret)
> + goto out;
Please don't use gotos when it's not
On Fri, 5 Oct 2018 20:12:43 +0200
Ricardo Ribalda Delgado wrote:
>
> I think I know what might be the issue. on cfi_cmdset_002.c
> cfi_amdstd_reset can be called in parrallel to cfi_amdstd_destroy.
>
> maybe we should call
> unregister_reboot_notifier(>reboot_notifier);
> before
>
On Fri, 5 Oct 2018 20:12:43 +0200
Ricardo Ribalda Delgado wrote:
>
> I think I know what might be the issue. on cfi_cmdset_002.c
> cfi_amdstd_reset can be called in parrallel to cfi_amdstd_destroy.
>
> maybe we should call
> unregister_reboot_notifier(>reboot_notifier);
> before
>
On Fri, 5 Oct 2018 17:56:51 +0200
Arnd Bergmann wrote:
> The previous patch introduced very large kernel stack usage and a Makefile
> change to hide the warning about it.
>
> From what I can tell, a number of things went wrong here:
>
> - The BCH_MAX_T constant was set to the maximum value
On Fri, 5 Oct 2018 17:56:51 +0200
Arnd Bergmann wrote:
> The previous patch introduced very large kernel stack usage and a Makefile
> change to hide the warning about it.
>
> From what I can tell, a number of things went wrong here:
>
> - The BCH_MAX_T constant was set to the maximum value
801 - 900 of 10969 matches
Mail list logo
