Re: [RFT PATCH v3 18/27] tty: serial: samsung_tty: Separate S3C64XX ops structure

2021-03-05 Thread Krzysztof Kozlowski
rivers/tty/serial/samsung_tty.c | 71 > 1 file changed, 54 insertions(+), 17 deletions(-) Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/2] usb: gadget: s3c: Fix the error handling path in 's3c2410_udc_probe()'

2021-03-05 Thread Krzysztof Kozlowski
134b98bb94d60cad9a46ec1ffbe372 > the commit ID looks correct to me. Maybe something should be tweaked somewhere > before applying, but I don't know what! > --- > drivers/usb/gadget/udc/s3c2410_udc.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > Afte

Re: [PATCH 1/2] usb: gadget: s3c: Fix incorrect resources releasing

2021-03-05 Thread Krzysztof Kozlowski
s/usb/gadget/udc/s3c2410_udc.c?id=188db4435ac64f0918def7ba0593d408700ecc4b > the commit ID looks correct to me. Maybe something should be tweaked somewhere > before applying, but I don't know what! > --- > drivers/usb/gadget/udc/s3c2410_udc.c | 14 +++--- > 1 file changed, 3 in

Re: A note on the 5.12-rc1 tag

2021-03-04 Thread Krzysztof Kozlowski
On 04/03/2021 13:43, Pavel Machek wrote: >> One additional reason for this note is that I want to not just warn >> people to not run this if you have a swapfile - even if you are >> personally not impacted (like I am, and probably most people are - >> swap partitions all around) - I want to make

[PATCH] MAINTAINERS: use Krzysztof Kozlowski's Canonical address

2021-03-04 Thread Krzysztof Kozlowski
Since I plan to use my Canonical address for reviews and other maintenance activities, reflect this in MAINTAINERS to avoid any confusion. Cc: Krzysztof Kozlowski Cc: Arnd Bergmann Cc: Olof Johansson Signed-off-by: Krzysztof Kozlowski --- MAINTAINERS | 26 +- 1 file

[PATCH v2] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type

2021-03-03 Thread Krzysztof Kozlowski
. Signed-off-by: Krzysztof Kozlowski Tested-by: Marek Szyprowski --- Changes since v1: 1. Mention in commit msg that this fixes TM2e RTC alarm. 2. Add Marek's tested-by. --- drivers/mfd/sec-irq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/sec-irq.c b/drivers

Re: [PATCH 01/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on GT-I9100

2021-03-03 Thread Krzysztof Kozlowski
On Thu, Dec 10, 2020 at 10:25:17PM +0100, Krzysztof Kozlowski wrote: > The Maxim fuel gauge datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU. The falling edge > interrupt will mostly work but it's not correct. > > Fixes: 862

Re: [PATCH 03/11] arm64: dts: intel: socfpga: override clocks by label

2021-03-03 Thread Krzysztof Kozlowski
On 10/02/2021 18:18, Krzysztof Kozlowski wrote: Using full paths to extend or override a device tree node is error prone. If there was a typo error, a new node will be created instead of extending the existing node. This will lead to run-time errors that could be hard to detect. A mistyped

Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent

2021-03-03 Thread Krzysztof Kozlowski
On 03/03/2021 17:49, Krzysztof Kozlowski wrote: And "new drivers" are almost always not really "new" as everyone uses much the same IP blocks.  As proof of this patch where the DWC3 IP block is being used by multiple SoC vendors.  To handle that, you split out the SoC-specif

Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent

2021-03-03 Thread Krzysztof Kozlowski
On 03/03/2021 17:43, Greg Kroah-Hartman wrote: I don't think that will work in practice. Many ARCH_ symbols for various architectures contradict with each other. Almost all watchdog drivers only _build_ for specific platforms/architectures. Great, that's horrible to hear, so much for a

Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent

2021-03-03 Thread Krzysztof Kozlowski
On 03/03/2021 16:09, Greg Kroah-Hartman wrote: On Wed, Mar 03, 2021 at 06:56:38AM -0800, Guenter Roeck wrote: On 3/3/21 6:05 AM, Greg Kroah-Hartman wrote: [ ... ] Anyway, that's the convention or consensus so far for entire SoC. If we want to change it - sure, but let's make it for everyone,

Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent

2021-03-03 Thread Krzysztof Kozlowski
On 03/03/2021 15:05, Greg Kroah-Hartman wrote: On Wed, Mar 03, 2021 at 11:38:39AM +0100, Krzysztof Kozlowski wrote: This is so far component of a SoC, so it cannot be re-used outside of SoC. Unless it appears in a new SoC (just like recent re-use of Samsung serial driver for Apple M1). Because

Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent

2021-03-03 Thread Krzysztof Kozlowski
On 03/03/2021 11:38, Krzysztof Kozlowski wrote: On Wed, Mar 03, 2021 at 11:30:38AM +0100, Greg Kroah-Hartman wrote: Just let any arch pick any driver if it can be built, you never know what it might be run on. Removing ARCH_ dependencies in Kconfig files is a good thing, please do

Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent

2021-03-03 Thread Krzysztof Kozlowski
On Wed, Mar 03, 2021 at 11:30:38AM +0100, Greg Kroah-Hartman wrote: > On Wed, Mar 03, 2021 at 11:24:01AM +0100, Krzysztof Kozlowski wrote: > > On 03/03/2021 03:26, taehyun cho wrote: > > > 'ARCH_EXYNOS' is not suitable for DWC3_EXYNOS config. > > > 'USB_DWC3_EXYNOS' is g

Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent

2021-03-03 Thread Krzysztof Kozlowski
On 03/03/2021 03:26, taehyun cho wrote: 'ARCH_EXYNOS' is not suitable for DWC3_EXYNOS config. 'USB_DWC3_EXYNOS' is glue layer which can be used with Synopsys DWC3 controller on Exynos SoCs. USB_DWC3_EXYNOS' can be used from Exynos5 to Exynos9. Signed-off-by: taehyun cho NACK because you

Re: [PATCH 2/3] ARM: dts: exynos: Add charger supply for I9100

2021-03-02 Thread Krzysztof Kozlowski
On Sat, Jan 30, 2021 at 05:29:31PM +, Timon Baetz wrote: > The regulator is used for charging control by max8997_charger driver. > > Signed-off-by: Timon Baetz > --- > arch/arm/boot/dts/exynos4210-i9100.dts | 2 ++ > 1 file changed, 2 insertions(+) Thanks, applied. Best regards, Krzysztof

Re: (subset) [PATCH] arm64: dts: exynos: re-order Slim SSS clocks to match dtschema

2021-03-02 Thread Krzysztof Kozlowski
On Fri, 12 Feb 2021 17:37:29 +0100, Krzysztof Kozlowski wrote: > The dtschema expects pclk (APB clock) followed by aclk (AXI/AHB clock): > > arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: > slim-sss@1114: clock-names:0: 'pclk' was expected > arch/arm64/boot/dts/ex

Re: [PATCH] memory: tegra: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-03-02 Thread Krzysztof Kozlowski
On Thu, Feb 25, 2021 at 05:05:58PM +0800, Yang Li wrote: > Fix the following coccicheck warning: > ./drivers/memory/tegra/tegra124-emc.c:1207:0-23: WARNING: > tegra_emc_debug_min_rate_fops should be defined with > DEFINE_DEBUGFS_ATTRIBUTE > ./drivers/memory/tegra/tegra124-emc.c:1237:0-23: WARNING:

Re: [PATCH] memory: gpmc: fix out of bounds read and dereference on gpmc_cs[]

2021-03-02 Thread Krzysztof Kozlowski
On Tue, Feb 23, 2021 at 07:38:21PM +, Colin King wrote: > From: Colin Ian King > > Currently the array gpmc_cs is indexed by cs before it cs is range checked > and the pointer read from this out-of-index read is dereferenced. Fix this > by performing the range check on cs before the read and

Re: [PATCH 1/3] crypto: sa2ul - Hide pointer and fix -Wpointer-to-int-cast in dev_dbg()

2021-02-28 Thread Krzysztof Kozlowski
On Mon, 1 Mar 2021 at 07:36, Herbert Xu wrote: > > On Sat, Feb 27, 2021 at 05:37:49PM +0100, Krzysztof Kozlowski wrote: > > > > I think this patch was lost, although you replied that the entire set > > is applied. > > > > Can you pick it up? > > I think i

Re: [PATCH 1/3] crypto: sa2ul - Hide pointer and fix -Wpointer-to-int-cast in dev_dbg()

2021-02-27 Thread Krzysztof Kozlowski
On Fri, 4 Sept 2020 at 10:28, Herbert Xu wrote: > > On Wed, Aug 26, 2020 at 06:29:52PM +0200, Krzysztof Kozlowski wrote: > > Pointers should not be printed because they might leak important > > information about address space layout. Use %p to hash the value. This > >

Re: [PATCH] devfreq: rk3399_dmc: Simplify with dev_err_probe()

2021-02-27 Thread Krzysztof Kozlowski
On Sat, 29 Aug 2020 at 15:10, Chanwoo Choi wrote: > > On Sat, Aug 29, 2020 at 12:31 AM Krzysztof Kozlowski wrote: > > > > Common pattern of handling deferred probe can be simplified with > > dev_err_probe(). Less code and the error value gets printed. > > > >

Re: [PATCH v4 4/5] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit

2021-02-27 Thread Krzysztof Kozlowski
for v2: > - update commit message > > Documentation/devicetree/bindings/arm/fsl.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 3/5] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2021-02-27 Thread Krzysztof Kozlowski
gt; i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > i.Core MX8M Mini needs to mount on top of this Carrier board for > creating complete i.Core MX8M Mini C.TOUCH 2.0 board. > > Add support for it. > > Signed-off-by: Matteo Lisi > Signed-off-by

Re: [PATCH v2] i2c: exynos5: Preserve high speed master code

2021-02-26 Thread Krzysztof Kozlowski
On Fri, 26 Feb 2021 at 11:34, Wolfram Sang wrote: > > On Tue, Feb 16, 2021 at 11:25:38PM +0100, Mårten Lindahl wrote: > > From: Mårten Lindahl > > > > When the driver starts to send a message with the MASTER_ID field > > set (high speed), the whole I2C_ADDR register is overwritten including > >

Re: [PATCH v2] media: exynos4-is: add missing call to of_node_put()

2021-02-26 Thread Krzysztof Kozlowski
On Fri, 26 Feb 2021 at 02:28, Yang Li wrote: > > In one of the error paths of the for_each_child_of_node() loop in > fimc_md_parse_one_endpoint, add missing call to of_node_put(). > > Fix the following coccicheck warning: > ./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING: >

Re: [PATCH] media: exynos4-is: add missing call to of_node_put()

2021-02-25 Thread Krzysztof Kozlowski
On Thu, 25 Feb 2021 at 10:04, Yang Li wrote: > > In one of the error paths of the for_each_child_of_node() loop in > fimc_md_parse_one_endpoint, add missing call to of_node_put(). > > Fix the following coccicheck warning: > ./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING: >

Re: [PATCH] dt-bindings: media: Use graph and video-interfaces schemas, round 2

2021-02-24 Thread Krzysztof Kozlowski
2b47517a6 ("media: dt-bindings: media: i2c: Add OV8865 bindings > documentation") > Fixes: 29a202fa7acc ("media: dt-bindings: media: i2c: Add OV5648 bindings > documentation") > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab > Cc: Dave Stevenson > Cc: Jacopo Mondi

Re: [PATCH] memory: gpmc: fix out of bounds read and dereference on gpmc_cs[]

2021-02-24 Thread Krzysztof Kozlowski
On Wed, Feb 24, 2021 at 10:55:52AM +0300, Dan Carpenter wrote: > On Tue, Feb 23, 2021 at 07:38:21PM +, Colin King wrote: > > From: Colin Ian King > > > > Currently the array gpmc_cs is indexed by cs before it cs is range checked > > and the pointer read from this out-of-index read is

Re: [PATCH] Revert "ARM: dts: exynos: Remove 'opp-shared' from Exynos4412 bus OPP-tables"

2021-02-23 Thread Krzysztof Kozlowski
On Tue, Feb 23, 2021 at 10:24:41AM +0100, Marek Szyprowski wrote: > Hi Markus, > > On 22.02.2021 10:54, Markus Reichl wrote: > > This reverts commit a23beead41a18c3be3ca409cb52f35bc02e601b9. > > > > I'm running an Odroid-X2 as headless 24/7 server. > > With plain stable 5.10.1 I had 54 up days

Re: [PATCH v4 01/10] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip

2021-02-23 Thread Krzysztof Kozlowski
ns(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] memory: gpmc: fix out of bounds read and dereference on gpmc_cs[]

2021-02-23 Thread Krzysztof Kozlowski
On Tue, Feb 23, 2021 at 07:38:21PM +, Colin King wrote: > From: Colin Ian King > > Currently the array gpmc_cs is indexed by cs before it cs is range checked > and the pointer read from this out-of-index read is dereferenced. Fix this > by performing the range check on cs before the read and

Re: [PATCH v2 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip

2021-02-23 Thread Krzysztof Kozlowski
On Tue, 23 Feb 2021 at 11:45, Adrien Grassein wrote: > > > > > > > > I would assume this goes from PMIC, so check your schematics. There is > > > > little point in adding a fixed regulator which is non-controllable. > > > > > > No, the 1.8V is issued directly from the alimentation stage. > > > So

Re: [PATCH v2 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip

2021-02-22 Thread Krzysztof Kozlowski
On Mon, 22 Feb 2021 at 00:47, Adrien Grassein wrote: > > Le sam. 20 févr. 2021 à 20:19, Krzysztof Kozlowski a écrit : > > > > On Fri, Feb 19, 2021 at 03:03:55PM +0100, Adrien Grassein wrote: > > > Le ven. 19 févr. 2021 à 14:18, Krzysztof Kozlowski a > > > éc

Re: [PATCH 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board

2021-02-22 Thread Krzysztof Kozlowski
On Mon, 22 Feb 2021 at 10:09, Heiko Thiery wrote: > > > > > + > > > > > + pcie0_refclk: pcie0-refclk { > > > > > > > > Generic node names (from the dt spec candidate is "clock"). > > > > > > Should I simply set the node name to pcie0-clock? And pcie1-clock for > > > the next one? > > > > I am

Re: [PATCH v2 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board

2021-02-22 Thread Krzysztof Kozlowski
sai2 and pinctrl_spdfif1 since it is not used yet > > Thanks to Michael Walle: > - add pinctrl for regulator-v-3v3-sd > - add name for regulator swbst > - add comment about currently unused audio codec > - put usb_phy entry in correct alphabetical order > > Thank

Re: [PATCH v2 1/2] dt-bindings: arm: fsl: add Kontron pITX-imx8m board

2021-02-22 Thread Krzysztof Kozlowski
d, 1 insertion(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board

2021-02-22 Thread Krzysztof Kozlowski
On Mon, Feb 22, 2021 at 08:46:52AM +0100, Heiko Thiery wrote: > Hi Krysztof, > > Am So., 21. Feb. 2021 um 13:11 Uhr schrieb Krzysztof Kozlowski > : > > > > On Thu, Feb 18, 2021 at 01:33:29PM +0100, Heiko Thiery wrote: > > > The Kontron pitx-imx8m

Re: [RFC 15/19] arm64: dts: imx8mq: Add all pl301 nodes

2021-02-21 Thread Krzysztof Kozlowski
On Fri, 19 Feb 2021 at 17:04, Abel Vesa wrote: > > Add all the pl301s found on i.MX8MQ, according to the bus diagram. > Each pl301 has its own clock, icc id and opp table. They are probed > by the imx-bus driver. > > Signed-off-by: Abel Vesa > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi |

Re: [PATCH v2 25/25] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-21 Thread Krzysztof Kozlowski
On Sun, Feb 21, 2021 at 11:43:52PM +0900, Hector Martin wrote: > On 16/02/2021 04.29, Krzysztof Kozlowski wrote: > > On Mon, Feb 15, 2021 at 09:17:13PM +0900, Hector Martin wrote: > > > + memory@8 { > > > + device_type = "memory"; > > &

[PATCH] ASoC: constify of_phandle_args in snd_soc_get_dai_name()

2021-02-21 Thread Krzysztof Kozlowski
The pointer to of_phandle_args passed to snd_soc_get_dai_name() and of_xlate_dai_name() implementations is not modified. Since it is being used only to translate passed OF node to a DAI name, it should not be modified, so mark it as const for correctness and safer code. Signed-off-by: Krzysztof

Re: [PATCH 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board

2021-02-21 Thread Krzysztof Kozlowski
On Thu, Feb 18, 2021 at 01:33:29PM +0100, Heiko Thiery wrote: > The Kontron pitx-imx8m board is based on an i.MX8MQ soc. > > Signed-off-by: Heiko Thiery > --- > arch/arm64/boot/dts/freescale/Makefile| 1 + > .../freescale/imx8mq-kontron-pitx-imx8m.dts | 675 ++ > 2

Re: [PATCH v3 5/9] arm64: dts: imx8mm-nitrogen-r2: rework UART 2

2021-02-20 Thread Krzysztof Kozlowski
On Fri, Feb 19, 2021 at 03:30:24PM +0100, Adrien Grassein wrote: > Remove useless clocks in UART 2 > > Signed-off-by: Adrien Grassein > --- > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 4/9] arm64: dts: imx8mm-nitrogen-r2: add UARTs

2021-02-20 Thread Krzysztof Kozlowski
On Fri, Feb 19, 2021 at 03:30:23PM +0100, Adrien Grassein wrote: > Add description and pin muxing for UARTs. > > Signed-off-by: Adrien Grassein > --- > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 48 +++ > 1 file changed, 48 insertions(+) > Reviewed-by

Re: [PATCH v3 1/9] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip

2021-02-20 Thread Krzysztof Kozlowski
On Fri, Feb 19, 2021 at 03:30:20PM +0100, Adrien Grassein wrote: > Add usdhc3 description which corresponds to the wifi/bt chip > > Signed-off-by: Adrien Grassein > --- > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 38 +++ > 1 file changed, 38 insertions(+) > > diff --git

Re: [PATCH v2 3/8] arm64: dts: imx8mm-nitrogen-r2: add espi2 support

2021-02-20 Thread Krzysztof Kozlowski
On Fri, Feb 19, 2021 at 03:02:35PM +0100, Adrien Grassein wrote: > Le ven. 19 févr. 2021 à 14:19, Krzysztof Kozlowski a écrit : > > > > On Wed, Feb 17, 2021 at 05:10:47PM +0100, Adrien Grassein wrote: > > > Add the description for espi support. > > > >

Re: [PATCH v2 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip

2021-02-20 Thread Krzysztof Kozlowski
On Fri, Feb 19, 2021 at 03:03:55PM +0100, Adrien Grassein wrote: > Le ven. 19 févr. 2021 à 14:18, Krzysztof Kozlowski a écrit : > > > > On Wed, Feb 17, 2021 at 05:10:45PM +0100, Adrien Grassein wrote: > > > Add usdhc3 description which corresponds to the wifi/bt chi

Re: [PATCH v3 4/5] arm64: dts: librem5: protect some partitions of the nor-flash

2021-02-20 Thread Krzysztof Kozlowski
q-librem5.dtsi | 17 + > 1 file changed, 17 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource

2021-02-20 Thread Krzysztof Kozlowski
On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: > On 16/02/2021 03.51, Krzysztof Kozlowski wrote: > > > Also fix a bug checking the return value, which should use IS_ERR(). > > > > No, no, no. We never, never combine fixing bugs with some rework. > >

Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework

2021-02-20 Thread Krzysztof Kozlowski
On Thu, Feb 18, 2021 at 10:53:10PM +0900, Hector Martin wrote: > > Separate patch for trivial renaming. > > I think it makes sense to do this rename together with the first change > above, as it keeps both functions symmetric. Otherwise we end up with an > inconsistent function naming between

Re: [PATCH v2 4/8] arm64: dts: imx8mm-nitrogen-r2: add UARTs

2021-02-19 Thread Krzysztof Kozlowski
On Wed, Feb 17, 2021 at 05:10:48PM +0100, Adrien Grassein wrote: > Add description and pin muxing for UARTs. > > Signed-off-by: Adrien Grassein > --- > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 50 ++- > 1 file changed, 48 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v2 3/8] arm64: dts: imx8mm-nitrogen-r2: add espi2 support

2021-02-19 Thread Krzysztof Kozlowski
On Wed, Feb 17, 2021 at 05:10:47PM +0100, Adrien Grassein wrote: > Add the description for espi support. > > Signed-off-by: Adrien Grassein > Reviewed-by: Krzysztof Kozlowski > --- > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 30 +++ > 1 file c

Re: [PATCH v2 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip

2021-02-19 Thread Krzysztof Kozlowski
On Wed, Feb 17, 2021 at 05:10:45PM +0100, Adrien Grassein wrote: > Add usdhc3 description which corresponds to the wifi/bt chip > > Signed-off-by: Adrien Grassein > --- > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git

Re: [PATCH 8/8] arm64: defconfig: Enable wm8960 audio driver.

2021-02-17 Thread Krzysztof Kozlowski
On Tue, Feb 16, 2021 at 12:19:43AM +0100, Adrien Grassein wrote: > This driver is used by the Nitrogen8m Mini SBC. > > Signed-off-by: Adrien Grassein > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 6/8] arm64: dts: imx8mm-nitrogen-r2: add flexspi

2021-02-17 Thread Krzysztof Kozlowski
On Tue, Feb 16, 2021 at 12:19:41AM +0100, Adrien Grassein wrote: > Add flexspi description an pinmuxing. FlexSPI, pin muxing (with a space). Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 5/8] arm64: dts: imx8mm-nitrogen-r2: add pwms

2021-02-17 Thread Krzysztof Kozlowski
On Tue, Feb 16, 2021 at 12:19:40AM +0100, Adrien Grassein wrote: > Add description for the four pwms. In title and msg: PWM is an acronym, so "four PWMs", "add PWMs". Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 4/8] arm64: dts: imx8mm-nitrogen-r2: add uarts

2021-02-17 Thread Krzysztof Kozlowski
On Tue, Feb 16, 2021 at 12:19:39AM +0100, Adrien Grassein wrote: > Add description and pinmuxing for uarts. > > Signed-off-by: Adrien Grassein > --- > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 53 ++- > 1 file changed, 52 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH 3/8] arm64: dts: imx8mm-nitrogen-r2: add espi2 support

2021-02-17 Thread Krzysztof Kozlowski
t; @@ -10,6 +10,14 @@ / { > model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > > + clocks { > + clk16m: clk16m { Node name: clock or clock-16m. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/8] arm64: dts: imx8mm-nitrogen-r2: add USB support

2021-02-17 Thread Krzysztof Kozlowski
On Tue, Feb 16, 2021 at 12:19:37AM +0100, Adrien Grassein wrote: > add description of USB. s/add/Add/ Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip

2021-02-17 Thread Krzysztof Kozlowski
On Tue, Feb 16, 2021 at 12:19:36AM +0100, Adrien Grassein wrote: > Add usdhc3 description which corresponds to the wifi/bt chip > > Signed-off-by: Adrien Grassein > --- > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git

Re: [PATCH v2 4/5] arm64: dts: librem5: protect some partitions of the nor-flash

2021-02-17 Thread Krzysztof Kozlowski
On Wed, Feb 17, 2021 at 12:19:43PM +0100, Martin Kepplinger wrote: > From: Angus Ainslie > > These sections should be read only as they contain important data. > > Signed-off-by: Angus Ainslie > Signed-off-by: Martin Kepplinger > --- > .../arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 16

Re: [PATCH] i2c: exynos5: Preserve high speed master code

2021-02-17 Thread Krzysztof Kozlowski
On Wed, Feb 17, 2021 at 09:32:11AM +0100, Jesper Nilsson wrote: > On Wed, Feb 17, 2021 at 09:07:47AM +0100, Krzysztof Kozlowski wrote: > > On Tue, Feb 16, 2021 at 11:09:33PM +0100, Marten Lindahl wrote: > > > > Any reason why not "|= MASTER_ID(i2c->adap.nr)" here

Re: [PATCH v2] i2c: exynos5: Preserve high speed master code

2021-02-17 Thread Krzysztof Kozlowski
k register contents. > > drivers/i2c/busses/i2c-exynos5.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] i2c: exynos5: Preserve high speed master code

2021-02-17 Thread Krzysztof Kozlowski
On Tue, Feb 16, 2021 at 11:09:33PM +0100, Marten Lindahl wrote: > > Any reason why not "|= MASTER_ID(i2c->adap.nr)" here instead of more > > expensive IO read? It's quite important because your current code will > > bitwise-or old I2C slave address with a new one... This should break > > during

Re: [PATCH v2 23/25] tty: serial: samsung_tty: Add earlycon support for Apple UARTs

2021-02-16 Thread Krzysztof Kozlowski
On Tue, 16 Feb 2021 at 11:19, Arnd Bergmann wrote: > > > + return samsung_early_console_setup(device, opt); > > > > Don't you need to handle the error code - set PROT_DEFAULT() or whatever > > was there before? > > __set_fixmap() has no return value, it just writes a page table entry and >

Re: [PATCH] i2c: exynos5: Preserve high speed master code

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 08:03:21PM +0100, Mårten Lindahl wrote: > From: Mårten Lindahl > > When the controller starts to send a message with the MASTER_ID field > set (high speed), the whole I2C_ADDR register is overwritten including > MASTER_ID as the SLV_ADDR_MAS field is set. Are you here

Re: [PATCH v2 25/25] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 01:00:58PM -0800, Randy Dunlap wrote: > On 2/15/21 11:29 AM, Krzysztof Kozlowski wrote: > >> diff --git a/arch/arm64/boot/dts/apple/apple-j274.dts > >> b/arch/arm64/boot/dts/apple/apple-j274.dts > >> new file mode 100644 > >> index 0

Re: [PATCH v2 25/25] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-15 Thread Krzysztof Kozlowski
+ > +/ { > + compatible = "apple,m1", "apple,arm-platform"; > + > + #address-cells = <2>; > + #size-cells = <2>; > + > + cpus { > + #address-cells = <2>; > + #size-cells = <0>; > + > + cpu0: cpu@0 { > + compatible = "apple,icestorm"; > + device_type = "cpu"; > + reg = <0x0 0x0>; > + enable-method = "spin-table"; > + cpu-release-addr = <0 0>; /* To be filled by loader */ > + }; New line after every device node, please. With this minor changes, fine for me: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 23/25] tty: serial: samsung_tty: Add earlycon support for Apple UARTs

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:17:11PM +0900, Hector Martin wrote: > Earlycon support is identical to S3C2410, but Apple SoCs also need > MMIO mapped as nGnRnE. This is handled generically for normal drivers > including the normal UART path here, but earlycon uses fixmap and > runs before that

Re: [PATCH v2 22/25] tty: serial: samsung_tty: Add support for Apple UARTs

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:17:10PM +0900, Hector Martin wrote: > Apple SoCs are a distant descendant of Samsung designs and use yet > another variant of their UART style, with different interrupt handling. > > In particular, this variant has the following differences with existing > ones: > > *

Re: [PATCH v2 21/25] dt-bindings: serial: samsung: Add apple,s5l-uart compatible

2021-02-15 Thread Krzysztof Kozlowski
-off-by: Hector Martin > --- > Documentation/devicetree/bindings/serial/samsung_uart.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:17:08PM +0900, Hector Martin wrote: > This picks up the non-posted I/O mode needed for Apple platforms to > work properly. > > This removes the request/release functions, which are no longer > necessary, since devm_ioremap_resource takes care of that already. Most >

Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:17:07PM +0900, Hector Martin wrote: > * Split out s3c24xx_serial_tx_chars from s3c24xx_serial_tx_irq, > where only the latter acquires the port lock. I miss here information why you do all this. > > * For S3C64xx, return IRQ_NONE if no flag bits were set, so the >

Re: [PATCH v2 18/25] tty: serial: samsung_tty: add s3c24xx_port_type

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:17:06PM +0900, Hector Martin wrote: > This decouples the TTY layer PORT_ types, which are exposed to > userspace, from the driver-internal flag of what kind of port this is. > > This removes s3c24xx_serial_has_interrupt_mask, which was just checking > for a specific

Re: [PATCH v2 17/25] tty: serial: samsung_tty: Separate S3C64XX ops structure

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:17:05PM +0900, Hector Martin wrote: > Instead of patching a single global ops structure depending on the port > type, use a separate s3c64xx_serial_ops for the S3C64XX type. This > allows us to mark the structures as const. > > Also split out s3c64xx_serial_shutdown

Re: [PATCH v2 02/25] dt-bindings: arm: apple: Add bindings for Apple ARM platforms

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:16:50PM +0900, Hector Martin wrote: > This introduces bindings for all three 2020 Apple M1 devices: > > * apple,j274 - Mac mini (M1, 2020) > * apple,j293 - MacBook Pro (13-inch, M1, 2020) > * apple,j313 - MacBook Air (M1, 2020) > > Signed-off-by: Hector Martin > --- >

Re: [PATCH v2 01/25] dt-bindings: vendor-prefixes: Add apple prefix

2021-02-15 Thread Krzysztof Kozlowski
-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 00/25] Apple M1 SoC platform bring-up

2021-02-15 Thread Krzysztof Kozlowski
On Tue, Feb 16, 2021 at 01:54:25AM +0900, Hector Martin wrote: > On 16/02/2021 01.12, gregkh wrote: > > On Tue, Feb 16, 2021 at 12:57:27AM +0900, Hector Martin wrote: > > > On 15/02/2021 22.22, gregkh wrote: > > > > On Mon, Feb 15, 2021 at 01:57:39PM +0100, Arnd Bergmann wrote: > > > > > (adding

Re: [PATCH] dt-bindings: iio: samsung,exynos-adc: add common clock properties

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 10:01:48AM +0100, Marek Szyprowski wrote: > Hi Krzysztof, > > On 12.02.2021 17:38, Krzysztof Kozlowski wrote: > > Add common properties appearing in DTSes (assigned-clocks and similar) > > to fix dtbs_check warnings like: > > > >ar

Re: [PATCH] MAINTAINERS: cpuidle: exynos: include header in file pattern

2021-02-12 Thread Krzysztof Kozlowski
On Fri, Feb 12, 2021 at 04:56:53PM +0100, Rafael J. Wysocki wrote: > On Wed, Feb 10, 2021 at 6:23 PM Krzysztof Kozlowski wrote: > > > > Inclue the platform data header in Exynos cpuidle maintainer entry. > > > > Cc: Bartlomiej Zolnierkiewicz > > Cc: Daniel L

[PATCH 1/2] dt-bindings: serial: samsung: add DMA properties

2021-02-12 Thread Krzysztof Kozlowski
The Samsung SoC UART nodes have usually DMA so dtschema has to reflect this to fix dtbs_check warnings like: arch/arm/boot/dts/exynos4210-smdkv310.dt.yaml: serial@1380: 'dma-names', 'dmas' do not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski

[PATCH 2/2] dt-bindings: serial: samsung: include generic dtschema to match bluetooth child

2021-02-12 Thread Krzysztof Kozlowski
Include the generic serial.yaml dtschema so the child node like "bluetooh" will be properly matched: arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml: serial@1380: 'bluetooth' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- ..

[PATCH] dt-bindings: iio: samsung,exynos-adc: add common clock properties

2021-02-12 Thread Krzysztof Kozlowski
@126c: assigned-clocks: [[7, 238]] is not of type 'object' Signed-off-by: Krzysztof Kozlowski --- .../bindings/iio/adc/samsung,exynos-adc.yaml | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation

[PATCH] dt-bindings: input: atmel,maxtouch: add wakeup-source

2021-02-12 Thread Krzysztof Kozlowski
The touchscreen can be a wake up source and it's being used in DTS: arch/arm/boot/dts/exynos5250-spring.dt.yaml: trackpad@4b: 'wakeup-source' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/input/atmel

[PATCH] arm64: dts: exynos: re-order Slim SSS clocks to match dtschema

2021-02-12 Thread Krzysztof Kozlowski
Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 6433f9ee35e1..18a912eee360 100644 --- a/arch

[RFT PATCH] crypto: s5p-sss - initialize APB clock after the AXI bus clock for SlimSSS

2021-02-12 Thread Krzysztof Kozlowski
sed names for lookup of these clocks from devicetree, so effectively the "pclk" was enabled first. Although it might not matter in reality, the correct order is to enable first main/high speed bus clock - "aclk". Also this was the intention of the actual code. Signed-off-by: Krzys

[PATCH v4] MAINTAINERS: move Milo Kim to credits

2021-02-12 Thread Krzysztof Kozlowski
and regulator) drivers. Signed-off-by: Krzysztof Kozlowski Cc: Mark Brown Cc: Jonathan Cameron Cc: Jingoo Han Cc: Lee Jones Cc: Pavel Machek Cc: Thierry Reding Cc: Sebastian Reichel Cc: Daniel Thompson --- Dear Lee, Could you take care about this patch? Best regards, Krzysztof Changes since v3

[RESEND PATCH] dt-bindings: writing-schema: install from PyPI repository

2021-02-12 Thread Krzysztof Kozlowski
$ make dt_binding_check ERROR: dtschema minimum version is v2020.8.1 Reported-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/writing-schema.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/writing

Re: [RESEND PATCH v3] MAINTAINERS: add Dan Murphy as TI LP8xxx drivers maintainer

2021-02-11 Thread Krzysztof Kozlowski
On Thu, Feb 11, 2021 at 09:03:27AM +, Lee Jones wrote: > On Wed, 10 Feb 2021, Krzysztof Kozlowski wrote: > > > On Wed, Feb 10, 2021 at 11:33:49AM -0600, Dan Murphy wrote: > > > Krzysztof > > > > > > On 2/10/21 11:29 AM, Krzysztof Kozlowski wrote:

Re: [PATCH 2/3] ARM: dts: exynos: Add charger supply for I9100

2021-02-10 Thread Krzysztof Kozlowski
On Thu, Feb 11, 2021 at 05:59:04AM +, Timon Baetz wrote: > On Sat, 30 Jan 2021 17:29:31 +, Timon Baetz wrote: > > The regulator is used for charging control by max8997_charger driver. > > > > Signed-off-by: Timon Baetz > > --- > > arch/arm/boot/dts/exynos4210-i9100.dts | 2 ++ > > 1

Re: [PATCH v2 2/2] power: supply: bq25980: Move props from battery node

2021-02-10 Thread Krzysztof Kozlowski
On Wed, Feb 10, 2021 at 04:56:46PM -0600, Ricardo Rivera-Matos wrote: > Currently POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT and > > POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE are exposed on the battery node > > and this is incorrect. > > This patch exposes

Re: [PATCH v2 1/2] power: supply: bq25980 Apply datasheet revision changes

2021-02-10 Thread Krzysztof Kozlowski
On Wed, Feb 10, 2021 at 04:56:45PM -0600, Ricardo Rivera-Matos wrote: > The latest datasheet revision for BQ25980, BQ25975, and BQ25960 changed > > various register step sizes and offset values. > > This patch changes the following header file > > values for POWER_SUPPLY_PROP_CURRENT_NOW, >

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-10 Thread Krzysztof Kozlowski
On Wed, Feb 10, 2021 at 09:10:38AM -0800, Matthias Kaehlcke wrote: > Check during probe() if a hub supported by the onboard_usb_hub > driver is connected to the controller. If such a hub is found > create the corresponding platform device. This requires the > device tree to have a node for the hub

Re: [PATCH v5 0/4] USB: misc: Add onboard_usb_hub driver

2021-02-10 Thread Krzysztof Kozlowski
On Wed, Feb 10, 2021 at 09:10:35AM -0800, Matthias Kaehlcke wrote: > This series adds the onboard_usb_hub_driver, the corresponding > device tree bindings and creation of onboard_usb_hub platform in > the xhci-plat driver during probe(). > > The main issue the driver addresses is that a USB hub

Re: [EXTERNAL] Re: [PATCH 1/2] power: supply: bq25980: Applies multiple fixes brought on

2021-02-10 Thread Krzysztof Kozlowski
On Wed, Feb 10, 2021 at 01:50:03PM -0600, Ricardo Rivera-Matos wrote: > Krzysztof, > > On 2/10/21 2:20 AM, Krzysztof Kozlowski wrote: > > On Wed, 10 Feb 2021 at 00:52, Ricardo Rivera-Matos > > wrote: > > > fix: corrects various register step size and offset val

Re: [RESEND PATCH v3] MAINTAINERS: add Dan Murphy as TI LP8xxx drivers maintainer

2021-02-10 Thread Krzysztof Kozlowski
On Wed, Feb 10, 2021 at 11:33:49AM -0600, Dan Murphy wrote: > Krzysztof > > On 2/10/21 11:29 AM, Krzysztof Kozlowski wrote: > > Milo Kim's email in TI bounces with permanent error (550: Invalid > > recipient). Last email from him on LKML was in 2017. Move Milo Kim to &g

[RESEND PATCH v3] MAINTAINERS: add Dan Murphy as TI LP8xxx drivers maintainer

2021-02-10 Thread Krzysztof Kozlowski
) drivers. Signed-off-by: Krzysztof Kozlowski Cc: Dan Murphy Acked-by: Dan Murphy Acked-by: Jonathan Cameron Acked-by: Sebastian Reichel Acked-by: Daniel Thompson Acked-by: Mark Brown Acked-by: Jingoo Han --- Dear Lee, Could you take care about this patch? Best regards, Krzysztof

[PATCH] MAINTAINERS: cpuidle: exynos: include header in file pattern

2021-02-10 Thread Krzysztof Kozlowski
Inclue the platform data header in Exynos cpuidle maintainer entry. Cc: Bartlomiej Zolnierkiewicz Cc: Daniel Lezcano Cc: Rafael J. Wysocki Signed-off-by: Krzysztof Kozlowski --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 674f42375acf

[PATCH 3/3] power: supply: s3c_adc_battery: remove unused pdata in suspend/resume

2021-02-10 Thread Krzysztof Kozlowski
ry.c:405:28: warning: unused variable ‘pdata’ [-Wunused-variable] drivers/power/supply/s3c_adc_battery.c: In function ‘s3c_adc_bat_resume’: drivers/power/supply/s3c_adc_battery.c:422:28: warning: unused variable ‘pdata’ [-Wunused-variable] Signed-off-by: Krzysztof Kozlowski ---

[PATCH 2/3] power: supply: s3c_adc_battery: add SPDX license identifier

2021-02-10 Thread Krzysztof Kozlowski
Add SPDX license identifier and replace license boilerplate. Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/s3c_adc_battery.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/power/supply/s3c_adc_battery.c b/drivers/power/supply

<    1   2   3   4   5   6   7   8   9   10   >