Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning

2014-11-26 Thread Hans Verkuil
...@atomide.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Mauro Carvalho Chehab mche...@osg.samsung.com Signed-off-by: Felipe Balbi ba...@ti.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch

[PATCH 1/2] mach-omap2: remove deprecated VIDEO_OMAP2 support

2014-11-14 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The omap2 camera driver has been deprecated for a year and is now going to be removed. It is unmaintained and it uses an internal API that has long since been superseded by a much better API. Worse, that internal API has been abused by out-of-kernel trees

Re: [RFCv2 1/8] [media] si4713: switch to devm regulator API

2014-11-11 Thread Hans Verkuil
Hi Mauro, On 11/11/2014 12:07 PM, Mauro Carvalho Chehab wrote: Em Tue, 21 Oct 2014 17:07:00 +0200 Sebastian Reichel s...@kernel.org escreveu: This switches back to the normal regulator API (but use managed variant) in preparation for device tree support. This patch broke compilation.

Re: [RFCv2 0/8] [media] si4713 DT binding

2014-11-10 Thread Hans Verkuil
Hi Sebastian, I've tested the whole 8-part patch series with my si4713 USB dev board, and it is working fine. I've accepted patches 1-4. The others need to be reposted since patch 5 had a change request. Regards, Hans On 11/07/2014 01:49 PM, Hans Verkuil wrote: On 10/21/14 17:06

Re: [RFCv2 0/8] [media] si4713 DT binding

2014-11-07 Thread Hans Verkuil
) Changes since RFCv1 (requested by Hans Verkuil): - splitted the patchset into more patches - replaced dev_info with dev_dbg for missing regulators - check for ENOSYS value from devm_gpiod_get (disabled GPIOLIB) -- Sebastian Sebastian Reichel (8): [media] si4713: switch to devm regulator

Re: [PATCH v3 04/14] v4l: ti-vpe: Allow DMABUF buffer type support

2014-03-11 Thread Hans Verkuil
pipeline. Add VB2_DMABUF flag to the io_modes of the vb2 output and capture queues. This allows the driver to import dma shared buffers. Signed-off-by: Archit Taneja arc...@ti.com Reviewed-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/ti-vpe/vpe.c | 4 ++-- 1 file

Re: [PATCH v3 05/14] v4l: ti-vpe: Allow usage of smaller images

2014-03-11 Thread Hans Verkuil
-interlace qcif content. A smaller image size than 32x32 didn't make much sense, so stopped at this. Signed-off-by: Archit Taneja arc...@ti.com Reviewed-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/ti-vpe/vpe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH v3 03/14] v4l: ti-vpe: Use video_device_release_empty

2014-03-11 Thread Hans Verkuil
-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/ti-vpe/vpe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index f1eae67..0363df6 100644 --- a/drivers/media/platform/ti-vpe

Re: [PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

2014-03-11 Thread Hans Verkuil
Hi Archit, A few small comments below... On 03/11/14 09:33, Archit Taneja wrote: Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense only for the output of VPE(or

Re: [PATCH v3 09/14] v4l: ti-vpe: report correct capabilities in querycap

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: querycap currently returns V4L2_CAP_VIDEO_M2M as a capability, this should be V4L2_CAP_VIDEO_M2M_MPLANE instead, as the driver supports multiplanar formats. Signed-off-by: Archit Taneja arc...@ti.com Reviewed-by: Hans Verkuil hans.verk...@cisco.com

Re: [PATCH v3 10/14] v4l: ti-vpe: Use correct bus_info name for the device in querycap

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: The bus_info parameter in v4l2_capabilities expects a 'platform_' prefix. This wasn't done in the driver and hence was breaking compliance. Update the bus_info parameter accordingly. Signed-off-by: Archit Taneja arc...@ti.com Reviewed-by: Hans

Re: [PATCH v3 11/14] v4l: ti-vpe: Fix initial configuration queue data

2014-03-11 Thread Hans Verkuil
. This breaks compliance when as we get 'TRY_FMT(G_FMT) != G_FMT'. Fix the initial queue configuration such that it wouldn't need to be fixed by try_fmt. Signed-off-by: Archit Taneja arc...@ti.com Reviewed-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/ti-vpe/vpe.c | 6

Re: [PATCH v3 12/14] v4l: ti-vpe: zero out reserved fields in try_fmt

2014-03-11 Thread Hans Verkuil
by the driver, and ensures compliance. Signed-off-by: Archit Taneja arc...@ti.com Reviewed-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/ti-vpe/vpe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti

Re: [PATCH v3 13/14] v4l: ti-vpe: Set correct field parameter for output and capture buffers

2014-03-11 Thread Hans Verkuil
-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/ti-vpe/vpe.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 970408a..c884910 100644 --- a/drivers/media

Re: [PATCH v3 14/14] v4l: ti-vpe: retain v4l2_buffer flags for captured buffers

2014-03-11 Thread Hans Verkuil
-off-by: Archit Taneja arc...@ti.com Reviewed-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/ti-vpe/vpe.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index c884910

Re: [PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

2014-03-11 Thread Hans Verkuil
On 03/11/14 13:46, Archit Taneja wrote: On Tuesday 11 March 2014 05:51 PM, Hans Verkuil wrote: Hi Archit, A few small comments below... On 03/11/14 09:33, Archit Taneja wrote: Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-10 Thread Hans Verkuil
On 03/10/2014 01:12 PM, Archit Taneja wrote: Hi Hans, On Friday 07 March 2014 07:17 PM, Archit Taneja wrote: On Friday 07 March 2014 07:02 PM, Hans Verkuil wrote: On 03/07/2014 02:22 PM, Archit Taneja wrote: Disregard what I said, it's OK to upstream it. But if you could just spend

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-07 Thread Hans Verkuil
On 03/07/2014 12:50 PM, Archit Taneja wrote: Hi Hans, On Tuesday 04 March 2014 05:05 PM, Hans Verkuil wrote: On 03/04/14 12:25, Archit Taneja wrote: I had a minor question about the selection API: Are the V4L2_SET_TGT_CROP/COMPOSE_DEFAULT and the corresponding 'BOUNDS' targets supposed

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-07 Thread Hans Verkuil
On 03/07/2014 02:22 PM, Archit Taneja wrote: Hi, On Friday 07 March 2014 06:29 PM, Hans Verkuil wrote: Do you think I can go ahead with posting the v3 patch set for 3.15, and work on fixing the compliance issue for the -rc fixes? It's fine to upstream this in staging, but while not all

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-04 Thread Hans Verkuil
Hi Archit, On 03/04/14 09:49, Archit Taneja wrote: Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense only for the output of VPE(or V4L2_BUF_TYPE_VIDEO_CAPTURE/MPLANE buffers). For the

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-04 Thread Hans Verkuil
On 03/04/14 12:25, Archit Taneja wrote: I had a minor question about the selection API: Are the V4L2_SET_TGT_CROP/COMPOSE_DEFAULT and the corresponding 'BOUNDS' targets supposed to be used with VIDIOC_S_SELECTION? If so, what's the expect behaviour? No, those are read only in practice. So

Re: [PATCH 7/7] v4l: ti-vpe: Add crop support in VPE driver

2014-03-03 Thread Hans Verkuil
On 03/04/2014 08:38 AM, Archit Taneja wrote: Hi Hans, On Monday 03 March 2014 01:20 PM, Hans Verkuil wrote: Hi Archit! On 03/03/2014 08:33 AM, Archit Taneja wrote: Add crop ioctl ops. For VPE, cropping only makes sense with the input to VPE, or the V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE

Re: [PATCH 7/7] v4l: ti-vpe: Add crop support in VPE driver

2014-03-02 Thread Hans Verkuil
Hi Archit! On 03/03/2014 08:33 AM, Archit Taneja wrote: Add crop ioctl ops. For VPE, cropping only makes sense with the input to VPE, or the V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE buffer type. For the CAPTURE type, a S_CROP ioctl results in setting the crop region as the whole image itself,

Re: [PATCH 0/8] v4l: ti-vpe: Add support for scaling and color conversion

2013-12-17 Thread Hans Verkuil
/csc.c create mode 100644 drivers/media/platform/ti-vpe/csc.h create mode 100644 drivers/media/platform/ti-vpe/sc.c create mode 100644 drivers/media/platform/ti-vpe/sc.h create mode 100644 drivers/media/platform/ti-vpe/sc_coeff.h For this patch series: Acked-by: Hans Verkuil hans.verk

Re: [PATCH 0/2] v4l: ti-vpe: Some VPE fixes

2013-12-17 Thread Hans Verkuil
On 12/17/2013 08:52 AM, Hans Verkuil wrote: On 12/03/2013 12:51 PM, Archit Taneja wrote: This series fixes 2 issues in the VPE driver. The first fix allows us to use UYVY color format for source and destination buffers. The second fix makes sure we don't set pixel format widths which

Re: [PATCH 0/8] v4l: ti-vpe: Add support for scaling and color conversion

2013-12-17 Thread Hans Verkuil
On 12/17/13 12:19, Archit Taneja wrote: Hi Hans, On Tuesday 17 December 2013 01:30 PM, Hans Verkuil wrote: On 12/12/2013 09:35 AM, Archit Taneja wrote: The VPE and VIP IPs in DRA7x contain common scaler and color conversion hardware blocks. We create libraries for these components

Re: [PATCH 0/2] v4l: ti-vpe: Some VPE fixes

2013-12-16 Thread Hans Verkuil
/platform/ti-vpe/vpdma.h | 5 ++- drivers/media/platform/ti-vpe/vpdma_priv.h | 2 +- drivers/media/platform/ti-vpe/vpe.c| 53 ++ 4 files changed, 47 insertions(+), 17 deletions(-) For this patch series: Acked-by: Hans Verkuil hans.verk...@cisco.com

Re: [PATCH v5 3/4] v4l: ti-vpe: Add VPE mem to mem driver

2013-10-15 Thread Hans Verkuil
Kamil, Can you take this driver as m2m maintainer or should I take it? Regards, Hans On 10/15/2013 03:47 PM, Archit Taneja wrote: Hi Hans, On Friday 11 October 2013 01:16 PM, Hans Verkuil wrote: On 10/09/2013 04:29 PM, Archit Taneja wrote: VPE is a block which consists

Re: [PATCH v5 3/4] v4l: ti-vpe: Add VPE mem to mem driver

2013-10-11 Thread Hans Verkuil
v4l2 ioctls as the HW support coplanar formats. Signed-off-by: Archit Taneja arc...@ti.com Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v4 1/4] v4l: ti-vpe: Create a vpdma helper library

2013-10-07 Thread Hans Verkuil
it's own VPDMA instance. Signed-off-by: Archit Taneja arc...@ti.com Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans --- drivers/media/platform/ti-vpe/vpdma.c | 578 + drivers/media/platform/ti-vpe/vpdma.h | 155

Re: [PATCH v4 3/4] v4l: ti-vpe: Add VPE mem to mem driver

2013-10-07 Thread Hans Verkuil
Hi Archit, I've got a few comments below... On 09/06/2013 12:12 PM, Archit Taneja wrote: VPE is a block which consists of a single memory to memory path which can perform chrominance up/down sampling, de-interlacing, scaling, and color space conversion of raster or tiled YUV420 coplanar,

Re: [PATCH v4 2/4] v4l: ti-vpe: Add helpers for creating VPDMA descriptors

2013-10-07 Thread Hans Verkuil
in the correct format. Add debug functions to dump the descriptors in a way such that it's easy to see the values of different fields in the descriptors. Signed-off-by: Archit Taneja arc...@ti.com Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans --- drivers/media

Re: [PATCH v4 4/4] v4l: ti-vpe: Add de-interlacer support in VPE

2013-10-07 Thread Hans Verkuil
like frame start event and line mode are configured for the 2 extra sets of input ports. Signed-off-by: Archit Taneja arc...@ti.com Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans --- drivers/media/platform/ti-vpe/vpe.c | 392 1

Re: [PATCH v4 3/4] v4l: ti-vpe: Add VPE mem to mem driver

2013-10-07 Thread Hans Verkuil
On 10/07/2013 11:16 AM, Archit Taneja wrote: On Monday 07 October 2013 01:25 PM, Hans Verkuil wrote: Hi Archit, I've got a few comments below... On 09/06/2013 12:12 PM, Archit Taneja wrote: VPE is a block which consists of a single memory to memory path which can perform chrominance up

Re: [PATCH v4 3/4] v4l: ti-vpe: Add VPE mem to mem driver

2013-10-07 Thread Hans Verkuil
On 10/07/2013 12:22 PM, Archit Taneja wrote: On Monday 07 October 2013 03:04 PM, Hans Verkuil wrote: On 10/07/2013 11:16 AM, Archit Taneja wrote: On Monday 07 October 2013 01:25 PM, Hans Verkuil wrote: Hi Archit, I've got a few comments below... On 09/06/2013 12:12 PM, Archit Taneja wrote

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-09-30 Thread Hans Verkuil
On 09/19/2013 11:44 PM, Russell King wrote: Replace the following sequence: dma_set_mask(dev, mask); dma_set_coherent_mask(dev, mask); with a call to the new helper dma_set_mask_and_coherent(). Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Hans Verkuil

Re: [PATCH v3 3/6] v4l: ti-vpe: Add VPE mem to mem driver

2013-08-30 Thread Hans Verkuil
On 08/30/2013 08:47 AM, Archit Taneja wrote: On Thursday 29 August 2013 06:58 PM, Hans Verkuil wrote: On Thu 29 August 2013 14:32:49 Archit Taneja wrote: VPE is a block which consists of a single memory to memory path which can perform chrominance up/down sampling, de-interlacing, scaling

Re: [PATCH v3 3/6] v4l: ti-vpe: Add VPE mem to mem driver

2013-08-30 Thread Hans Verkuil
On Fri 30 August 2013 12:05:11 Archit Taneja wrote: Hi, On Friday 30 August 2013 12:37 PM, Hans Verkuil wrote: On 08/30/2013 08:47 AM, Archit Taneja wrote: On Thursday 29 August 2013 06:58 PM, Hans Verkuil wrote: On Thu 29 August 2013 14:32:49 Archit Taneja wrote: VPE is a block which

Re: [PATCH v3 3/6] v4l: ti-vpe: Add VPE mem to mem driver

2013-08-29 Thread Hans Verkuil
On Thu 29 August 2013 14:32:49 Archit Taneja wrote: VPE is a block which consists of a single memory to memory path which can perform chrominance up/down sampling, de-interlacing, scaling, and color space conversion of raster or tiled YUV420 coplanar, YUV422 coplanar or YUV422 interleaved

Re: [PATCH 4/6] v4l: ti-vpe: Add de-interlacer support in VPE

2013-08-02 Thread Hans Verkuil
More comments... On 08/02/2013 04:03 PM, Archit Taneja wrote: Add support for the de-interlacer block in VPE. For de-interlacer to work, we need to enable 2 more sets of VPE input ports which fetch data from the 'last' and 'last to last' fields of the interlaced video. Apart from that, we

Re: [PATCH 3/6] v4l: ti-vpe: Add VPE mem to mem driver

2013-08-02 Thread Hans Verkuil
Hi Archit, I've got a few comments: On 08/02/2013 04:03 PM, Archit Taneja wrote: VPE is a block which consists of a single memory to memory path which can perform chrominance up/down sampling, de-interlacing, scaling, and color space conversion of raster or tiled YUV420 coplanar, YUV422

Re: [PATCH 3/8] tvp514x: Migrate to media-controller framework

2011-09-26 Thread Hans Verkuil
(Sorry for the late reply, I'm plowing through weeks of backlog...) On Thursday, September 08, 2011 15:35:00 Deepthy Ravi wrote: From: Vaibhav Hiremath hvaib...@ti.com Migrate tvp5146 driver to media controller framework. The driver registers as a sub-device entity to MC framwork and

Re: [PATCH v6 00/10] OMAP3 ISP driver

2011-02-14 Thread Hans Verkuil
This patch series is Acked-by: Hans Verkuil hverk...@xs4all.nl Regards, Hans On Monday, February 14, 2011 13:21:27 Laurent Pinchart wrote: Hi everybody, Here's the sixth version of the OMAP3 ISP driver patches, updated to 2.6.38-rc4 and the latest changes in the media controller

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-21 Thread Hans Verkuil
On Wednesday, December 15, 2010 00:50:44 Laurent Pinchart wrote: Hi Clemens, On Tuesday 14 December 2010 14:49:15 Clemens Ladisch wrote: Laurent Pinchart wrote: On Tuesday 14 December 2010 13:40:21 Hans Verkuil wrote: On Monday 13 December 2010 17:10:51 Clemens Ladisch wrote

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-14 Thread Hans Verkuil
instances of the same chip (a video sensor, audio mixer, ...) on the same board ? Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-07 Thread Hans Verkuil
On Friday, December 03, 2010 15:54:08 Mark Brown wrote: On Fri, Dec 03, 2010 at 02:50:58PM +0100, Laurent Pinchart wrote: On Friday 03 December 2010 13:06:18 Hans Verkuil wrote: Just to confirm thinks, Mark's proposal is to replace 'connected' by 'linked' and 'active' by 'connected

Re: [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-07 Thread Hans Verkuil
On Tuesday, December 07, 2010 18:55:05 Mark Brown wrote: On Tue, Dec 07, 2010 at 06:13:35PM +0100, Hans Verkuil wrote: Personally I think this is perfectly clear. The original confusion came from the word 'active', which I understand means 'streaming' in alsa. By adding a 'streaming' flag

Re: [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-11-28 Thread Hans Verkuil
a good option. Hans, do you want to comment on this ? Fine by me! It's better than 'active'. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [RFC/PATCH v6 11/12] v4l: Make video_device inherit from media_entity

2010-11-25 Thread Hans Verkuil
); + if (ret 0) + printk(KERN_ERR error\n); /* TODO */ Was this forgotten, or will this be fixed in the next version? It looks out-of-place... + } +#endif Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe

Re: [RFC 0/8] TI TILER-DMM driver

2010-07-24 Thread Hans Verkuil
create mode 100644 drivers/media/video/tiler/tmm.h -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Hans Verkuil - video4linux developer

Linux Plumbers Conference 2009: V4L2 API discussions

2009-08-04 Thread Hans Verkuil
all the new SoCs. So the more input we get, the better the end-result will be. Early-bird registration is still possible up to August 5th (that's tomorrow :-) ). Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send

Re: Linux Plumbers Conference 2009: V4L2 API discussions

2009-08-04 Thread Hans Verkuil
On Tuesday 04 August 2009 09:12:24 Hans Verkuil wrote: Hi all, During this years Plumbers Conference I will be organizing a session (or possibly more than one) on what sort of new V4L2 APIs are needed to support the new SoC devices. These new APIs should also solve the problem of how

Re: v4l2_int_device vs v4l2_subdev?

2009-06-27 Thread Hans Verkuil
in particular: once all drivers use v4l2_subdev we will have a very powerful foundation to build on. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: v4l2_int_device vs v4l2_subdev?

2009-06-26 Thread Hans Verkuil
://vger.kernel.org/majordomo-info.html -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: Did I miss any other patches or RFCs that need to be reviewed?

2009-06-15 Thread Hans Verkuil
email: m-kariche...@ti.com -Original Message- From: davinci-linux-open-source-bounces+m- karicheri2=ti@linux.davincidsp.com [mailto:davinci-linux-open-source- bounces+m-karicheri2=ti@linux.davincidsp.com] On Behalf Of Hans Verkuil Sent: Sunday, June 14, 2009 10:37 AM To: linux

Re: Did I miss any other patches or RFCs that need to be reviewed?

2009-06-15 Thread Hans Verkuil
will allow it to be merged. It's a pretty tight schedule, I'm afraid. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH (V2)] TVP514x: Migration to sub-device framework

2009-06-14 Thread Hans Verkuil
video/core functionality like, .g_chip_ident .reset .g_input_status - Migration master driver to validate this driver. - validate on Davinci and OMAP boards. Reviewed By Hans Verkuil. Signed-off-by: Brijesh Jadav brijes...@ti.com Signed-off-by: Hardik Shah

Re: [PATCH (V2)] TVP514x: Migration to sub-device framework

2009-06-14 Thread Hans Verkuil
On Sunday 14 June 2009 12:14:38 Hans Verkuil wrote: On Wednesday 06 May 2009 20:31:33 hvaib...@ti.com wrote: From: Vaibhav Hiremath hvaib...@ti.com This patch converts TVP514x driver to sub-device framework from V4L2-int framework. NOTE: Please note that this patch has not been

Did I miss any other patches or RFCs that need to be reviewed?

2009-06-14 Thread Hans Verkuil
Hi all, I think I've finally finished reviewing all the pending patches. Are there any that I've missed? Or are there other postings that need my attention? Please let me know, otherwise I assume that I'm (finally!) up to date. Regards, Hans -- Hans Verkuil - video4linux developer

tcm825x.c: migrating to sub-device framework? (was: TVP514x: Migration to sub-device framework)

2009-06-14 Thread Hans Verkuil
On Sunday 14 June 2009 14:44:53 Hans Verkuil wrote: On Sunday 14 June 2009 12:14:38 Hans Verkuil wrote: On Wednesday 06 May 2009 20:31:33 hvaib...@ti.com wrote: From: Vaibhav Hiremath hvaib...@ti.com This patch converts TVP514x driver to sub-device framework from V4L2-int framework

RE: [Review PATCH 3/3] OMAP2/3 V4L2 Display Driver

2009-04-21 Thread Hans Verkuil
Hi Hardik, Just a few comments on your comments :-) Hi Hans, My Comments inlined, Most of the comments are taken care off. Thanks for review. Hardik, -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Saturday, April 18, 2009 7:29 PM To: Shah, Hardik Cc

Re: [RFC] Stand-alone Resizer/Previewer Driver support under V4L2 framework

2009-04-20 Thread Hans Verkuil
On Monday 20 April 2009 12:31:53 Hiremath, Vaibhav wrote: Thanks, Vaibhav Hiremath -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Saturday, April 18, 2009 9:24 PM To: Hiremath, Vaibhav Cc: linux-me...@vger.kernel.org; Aguirre Rodriguez, Sergio Alberto

RE: [PATCH 3/3] V4L2 Driver for OMAP3/3 DSS.

2009-04-06 Thread Hans Verkuil
foo-rotate != 0 || foo-mirror; } I think this is much more understandable. It's up to you, though. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 1/3] Documentation for new V4L2 CIDs added.

2009-03-30 Thread Hans Verkuil
are exactly opposite same structfieldchromakey/structfield Typo: 'opposite same' - 'opposite the same' +field of v4l2-window; can be used to set the chroma key for source +keying also./entry + /row /tbody /tgroup /table -- 1.5.6 Regards, Hans -- Hans Verkuil

Re: [PATCH 2/3] New V4L2 CIDs for OMAP class of Devices.

2009-03-30 Thread Hans Verkuil
-- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] Stand-alone Resizer/Previewer Driver support under V4L2 framework

2009-03-30 Thread Hans Verkuil
on the capture side. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Some possible missing v4l2_subdev IOCTLs.

2009-03-20 Thread Hans Verkuil
. And in video_ops there is already an enum_fmt. Feel free to add crop and the enum_frame* ops. If you mail me a patch, then I'll commit it. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH 0/3] V4L2 driver for OMAP2/3 with new CIDs.

2009-03-20 Thread Hans Verkuil
at http://vger.kernel.org/majordomo-info.html -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: Embedded Linux Conference

2009-03-17 Thread Hans Verkuil
On Tuesday 17 March 2009 01:14:28 Steve Sakoman wrote: On Mon, Mar 16, 2009 at 3:56 PM, Tony Lindgren t...@atomide.com wrote: * Kevin Hilman khil...@deeprootsystems.com [090316 15:52]: Hans Verkuil hverk...@xs4all.nl writes: Just FYI: I'll be attending the Embedded Linux Conference

[PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

2009-03-11 Thread Hans Verkuil
|1 - radio/radio-terratec.c |1 - radio/radio-trust.c |1 - radio/radio-typhoon.c|1 - radio/radio-zoltrix.c|1 - video/omap24xxcam.c |1 - 15 files changed, 15 deletions(-) -- Hans Verkuil - video4linux developer - sponsored by TANDBERG

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-10 Thread Hans Verkuil
Hans Verkuil wrote: Sergio has posted earlier a patchset containing a driver for using the ISP to process images from memory to memory. The ISP driver is used roughly the same way as with the omap34xxcam and real sensors. The interface towards the userspace offered by the driver, however

Re: [PATCH 3/9] omap3isp: Add userspace header

2009-03-06 Thread Hans Verkuil
them unless they are really needed. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Embedded Linux Conference

2009-03-05 Thread Hans Verkuil
-- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-05 Thread Hans Verkuil
On Thursday 05 March 2009 21:11:02 Sakari Ailus wrote: Hans Verkuil wrote: Situation 1 - Instance1: Select sensor 1, and Do queue/dequeue of buffers. - Instance2: If sensor 1 is currently selected, Begin loop requesting internally collected OMAP3ISP statistics (with V4L2 private based

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Hans Verkuil
On Wednesday 04 March 2009 09:39:48 ext Hans Verkuil wrote: BTW, do I understand correctly that e.g. lens drivers also get their own /dev/videoX node? Please tell me I'm mistaken! Since that would be so very wrong. You're mistaken :) With the v4l2-int-interface/omap34xxcam camera driver

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Hans Verkuil
On Wednesday 04 March 2009 20:22:04 Sakari Ailus wrote: Hans Verkuil wrote: On Wednesday 04 March 2009 01:42:13 DongSoo(Nathaniel) Kim wrote: Thank you for your kind explanation Hans. Problem is omap3 camera subsystem is making device node for every int device attached to it. That's

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Hans Verkuil
On Wednesday 04 March 2009 22:46:07 Aguirre Rodriguez, Sergio Alberto wrote: -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Wednesday, March 04, 2009 3:06 PM To: sakari.ai...@maxwell.research.nokia.com Cc: DongSoo(Nathaniel) Kim; Hiremath, Vaibhav

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Hans Verkuil
On Thursday 05 March 2009 00:30:24 Aguirre Rodriguez, Sergio Alberto wrote: -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Wednesday, March 04, 2009 4:45 PM To: Aguirre Rodriguez, Sergio Alberto Cc: sakari.ai...@maxwell.research.nokia.com; DongSoo

Re: [RFC 0/5] Sensor drivers for OMAP3430SDP and LDP camera

2009-03-03 Thread Hans Verkuil
On Wednesday 04 March 2009 00:16:47 Aguirre Rodriguez, Sergio Alberto wrote: -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Tuesday, March 03, 2009 4:47 PM To: Aguirre Rodriguez, Sergio Alberto Cc: linux-me...@vger.kernel.org; linux-omap@vger.kernel.org

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-03 Thread Hans Verkuil
right, except that this info should come from the platform. I hope that the conversion to v4l2_subdev will take place soon. You are basically stuck in a technological dead-end :-( Regards, Hans Cheers, Nate On Tue, Mar 3, 2009 at 4:36 PM, Hans Verkuil hverk...@xs4all.nl wrote

Re: [RFC] How to pass camera Orientation to userspace

2009-02-22 Thread Hans Verkuil
On Sunday 22 February 2009 12:17:58 Hans de Goede wrote: Hans Verkuil wrote: Cons: Would require polling to support the case of a camera being turned toward / away from the user while streaming. Polling applies only to the bits that tell the orientation of the camera. See below

Re: [RFC] How to pass camera Orientation to userspace

2009-02-22 Thread Hans Verkuil
0x2000 V4L2_IN_ST_PIVOT_1800x4000 V4L2_IN_ST_PIVOT_2700x6000 V4L2_IN_ST_PIVOT_MSK0x6000 Actually, that's not too bad. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send

Re: [RFC] How to pass camera Orientation to userspace

2009-02-22 Thread Hans Verkuil
On Monday 23 February 2009 00:56:40 Trent Piepho wrote: On Mon, 23 Feb 2009, Hans Verkuil wrote: On Sunday 22 February 2009 23:54:42 Hans de Goede wrote: Trent Piepho wrote: On Sun, 22 Feb 2009, Hans de Goede wrote: Yes that is what we are talking about, the camera having a gravity

Re: [RFC] How to pass camera Orientation to userspace

2009-02-21 Thread Hans Verkuil
we need it there as well. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2

2009-02-06 Thread Hans Verkuil
! I'd be happy to help you with that. It's an internal API, so changes are possible and almost certainly necessary for omap anyway. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-01-12 Thread Hans Verkuil
core for 2.6.29, so this patch will not apply there. The file_operations struct is replaced by a v4l2_file_operations struct and the inode pointer was dropped from the various ops. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list

Re: [REVIEW PATCH 08/14] OMAP: CAM: Add ISP Core

2009-01-12 Thread Hans Verkuil
On Monday 12 January 2009 21:16:28 Aguirre Rodriguez, Sergio Alberto wrote: Hi, From: Hans Verkuil [mailto:hverk...@xs4all.nl] snip + { + .id = V4L2_CID_PRIVATE_ISP_COLOR_FX, + .type = V4L2_CTRL_TYPE_INTEGER

Re: Extended driver private controls?

2008-12-19 Thread Hans Verkuil
functions in v4l2-common.c! These might prove useful. -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [REVIEW PATCH 13/14] OMAP: CAM: Add Lens Driver

2008-12-16 Thread Hans Verkuil
-- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Add Omnivision OV9640 sensor support.

2008-12-07 Thread Hans Verkuil
/ov9640.h: what part of this header needs to be visible to other parts of the kernel? A lot seems to be internal to the driver and so should be moved to the driver source (or a ov9640_regs.h headers next to the driver source). Regards, Hans -- Hans Verkuil - video4linux developer

[PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

2008-12-05 Thread Hans Verkuil
, 5114 insertions(+) -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-ng

2008-12-02 Thread Hans Verkuil
Mauro's review back, just in case there are more changes for me to do. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] Add OMAP2 camera driver

2008-12-02 Thread Hans Verkuil
On Wednesday 03 December 2008 08:05:08 Hiremath, Vaibhav wrote: Thanks, Vaibhav Hiremath -Original Message- From: Trilok Soni [mailto:[EMAIL PROTECTED] Sent: Wednesday, December 03, 2008 12:18 PM To: Hiremath, Vaibhav Cc: Hans Verkuil; Sakari Ailus; linux-omap@vger.kernel.org

[PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-ng

2008-12-01 Thread Hans Verkuil
++-- linux/drivers/media/video/wm8775.c | 217 +++- linux/include/media/v4l2-common.h| 41 40 files changed, 4098 insertions(+), 2682 deletions(-) -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-ng

2008-12-01 Thread Hans Verkuil
On Monday 01 December 2008 13:27:07 Mauro Carvalho Chehab wrote: On Mon, 1 Dec 2008 12:46:08 +0100 Hans Verkuil [EMAIL PROTECTED] wrote: Hi Mauro, Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-ng for the following: - v4l2: add v4l2_device and v4l2_subdev structs

Re: [PATCH] Add Omnivision OV9640 sensor support.

2008-12-01 Thread Hans Verkuil
, but experience has shown us that the advantages regarding reuse far outweigh this initial cost. I noticed that the tcm825x.c driver takes exactly the same wrong approach, BTW. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-ng

2008-12-01 Thread Hans Verkuil
On Monday 01 December 2008 13:31:25 Laurent Pinchart wrote: On Monday 01 December 2008, Hans Verkuil wrote: Hi Mauro, Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-ng for the following: - v4l2: add v4l2_device and v4l2_subdev structs to the v4l2 framework. - v4l2

Re: [PATCH] Add OMAP2 camera driver

2008-12-01 Thread Hans Verkuil
/~hverkuil/v4l-dvb Is it OK for me to issue a pull request for that it can be merged in the v4l-dvb master? Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-ng

2008-12-01 Thread Hans Verkuil
On Monday 01 December 2008 14:29:53 Laurent Pinchart wrote: Hi Hans, On Monday 01 December 2008, Hans Verkuil wrote: On Monday 01 December 2008 13:31:25 Laurent Pinchart wrote: On Monday 01 December 2008, Hans Verkuil wrote: Hi Mauro, Please pull from http://www.linuxtv.org/hg

[PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

2008-12-01 Thread Hans Verkuil
++ b/linux/drivers/media/video/omap24xxcam.h | 593 linux/drivers/media/video/Kconfig |7 linux/drivers/media/video/Makefile|3 5 files changed, 3112 insertions(+) -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe

  1   2   >