[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

bulbazord added inline comments. Comment at: lldb/examples/python/crashlog.py:1165-1168 +if os.path.isdir(obj_dir.name): +for file in os.listdir(obj_dir.name): +os.unlink(os.path.join(obj_dir.name, file)) +os.rmdir(obj_dir.name)

[Lldb-commits] [PATCH] D150709: [lldb][NFCI] Change return type of Language::GetInstanceVariableName

This revision was automatically updated to reflect the committed changes. Closed by commit rGef73ea6cf691: [lldb][NFCI] Change return type of Language::GetInstanceVariableName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151120: [lldb][NFCI] Merge implementations of ObjectFileMachO::GetMinimumOSVersion and ObjectFileMachO::GetSDKVersion

bulbazord created this revision. bulbazord added reviewers: jasonmolenda, JDevlieghere. Herald added a subscriber: tschuett. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These functions do the

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Ok, looks good to me now. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 ___

[Lldb-commits] [PATCH] D151002: [lldb] Fix process pid parsing issue

bulbazord added a comment. You probably encountered this somewhere, is there a simple test we could add here? The change looks fine to me nonetheless. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151002/new/ https://reviews.llvm.org/D151002

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

bulbazord added a comment. Looks good! A few minor comments. Comment at: lldb/examples/python/crashlog.py:628-629 +description = "" +# Since images are parsed after threads, we need to build a +# map for every image with a list of all the

[Lldb-commits] [PATCH] D150954: [lldb][cmake] Allow specifying custom libcxx for tests in standalone builds

bulbazord accepted this revision. bulbazord added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150954/new/ https://reviews.llvm.org/D150954 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

bulbazord added a comment. Bug fixes look good to me, the perf and code simplifications are also great to see. A few nits and I have one concern. Otherwise looks fine to me, I think. Comment at: lldb/include/lldb/Target/DynamicLoader.h:270-273 +

[Lldb-commits] [PATCH] D150914: [lldb][NFCI] Pre-allocate storage in ObjCLanguage::MethodName::GetFullNameWithoutCategory

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8d3f061ba41: [lldb][NFCI] Pre-allocate storage in ObjCLanguage::MethodName… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + bulbazord wrote: > aprantl

[Lldb-commits] [PATCH] D150914: [lldb][NFCI] Pre-allocate storage in ObjCLanguage::MethodName::GetFullNameWithoutCategory

bulbazord created this revision. bulbazord added a reviewer: aprantl. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The size of a full ObjC MethodName can vary somewhat, but it is computable ahead

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

This revision was automatically updated to reflect the committed changes. Closed by commit rG41714c959d65: [lldb] Guarantee the lifetimes of all strings returned from SBAPI (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

bulbazord updated this revision to Diff 523578. bulbazord marked an inline comment as done. bulbazord added a comment. Update SBModule::GetUUIDString -- I slightly changed behavior. Now the behavior matches the previous implementation exactly. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + aprantl wrote: > bulbazord wrote: > > aprantl wrote: > > > Using an llvm

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

This revision was automatically updated to reflect the committed changes. bulbazord marked an inline comment as done. Closed by commit rG915256388f86: [lldb] Refactor ObjCLanguage::MethodName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/API/SBFunction.cpp:181 + + return variable_sp->GetName().GetCString(); } mib wrote: > nit: This threw me off, I thought you forgot to create a `ConsString` but

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + aprantl wrote: > Using an llvm

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG16eb14806d1e: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

bulbazord updated this revision to Diff 523500. bulbazord marked 2 inline comments as done. bulbazord added a comment. Redo include order in DWARFDebugAbbrev.h to match project guidelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150716/new/

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

bulbazord marked 2 inline comments as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp:27 lldb::offset_t *offset_ptr) { + llvm::DataExtractor llvm_data = data.GetAsLLVM();

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150826/new/ https://reviews.llvm.org/D150826

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

bulbazord added a comment. Where do you plan on using this? Downstream I assume? Comment at: lldb/source/Core/Value.cpp:134-135 + return Value::ValueType::Invalid; + } +} + This switch is exhaustive, could you add an `llvm_unreachable` somewhere to

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

bulbazord created this revision. bulbazord added reviewers: jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB should guarantee that the strings returned by SBAPI methods live forever.

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

bulbazord accepted this revision. bulbazord added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150621/new/ https://reviews.llvm.org/D150621 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

bulbazord created this revision. bulbazord added reviewers: aprantl, JDevlieghere, fdeazeve, rastogishubham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Both LLVM and LLDB implement

[Lldb-commits] [PATCH] D150630: [lldb][docs] Update SB API design document

This revision was automatically updated to reflect the committed changes. Closed by commit rGec388adbbcbf: [lldb][docs] Update SB API design document (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150630/new/

[Lldb-commits] [PATCH] D150709: [lldb][NFCI] Change return type of Language::GetInstanceVariableName

bulbazord created this revision. bulbazord added a reviewer: kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I don't think this needs to be a ConstString. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D150630: [lldb][docs] Update SB API design document

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The documentation should have been updated in

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

bulbazord added a comment. In D150621#4344243 , @JDevlieghere wrote: > You can do this simpler with a single `std::once_flag`. +1 I like the idea of this patch a lot! LGTM otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

This revision was automatically updated to reflect the committed changes. Closed by commit rG692ae97ae71d: [lldb] Fix lua build after 27b6a4e63afe (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150624/new/

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

bulbazord requested review of this revision. bulbazord added a comment. So, I agree that we should definitely unify this or else we end up doing this for **every** scripting language that we add support for. That being said, I think this is actually better than what we had before because now

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

bulbazord added a comment. This broke Lua support, so I am fixing it in D150624 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150157/new/ https://reviews.llvm.org/D150157

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

bulbazord created this revision. bulbazord added reviewers: kparzysz, JDevlieghere, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This applies the same trick for Lua that I did for python in

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. In D149914#4335858 , @aprantl wrote: > I'm not opposed to using this implementation, but have you considered using > something like the stdlib regex library to do the heavy lifting? I talked to Jonas and did a little

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. Some more numbers: % hyperfine -w 3 -- "$lldb -x -b -o 'b main' -o 'r' -o 'c' -o 'b $Selector' -o 'b $NonExistentSelector' -o 'b $FullObjCName' $App" Benchmark 1: $lldb -x -b -o 'b main' -o 'r' -o 'c' -o 'b $Selector' -o 'b $NonExistentSelector' -o 'b

[Lldb-commits] [PATCH] D150235: [lldb] Change definition of DisassemblerCreateInstance

This revision was automatically updated to reflect the committed changes. Closed by commit rGf464b7c764bc: [lldb] Change definition of DisassemblerCreateInstance (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150235/new/

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord added a comment. Ok, after looking at this more closely, it's a little clearer to me why `SBFileSpec::GetDirectory` was written this way to begin with. The method itself requires its return value to be denormalized (something not explicitly documented in the header nor the SWIG

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord added a comment. > AssertionError: > 'C:\\Users\\tcwg\\llvm-worker\\lldb-aarch64-windows\\build\\lldb-test-build.noindex\\functionalities\\process_save_core\\TestProcessSaveCore.test_save_windows_mini_dump_dwarf\\a.out' > not found in >

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

bulbazord added a comment. This is going to need some tests... And because you're adding templates to the SBAPI we'll need multiple tests -- Not just on the python side but I think we should add some actual C++ tests here in `test/API/api/` Comment at:

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG050c09f0bed6: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl (authored by bulbazord). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

bulbazord updated this revision to Diff 521771. bulbazord added a comment. - Use emplace_back - llvm::SmallVector size 8 -> 4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150418/new/ https://reviews.llvm.org/D150418 Files:

[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGc909b491cb5f: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/D150402?vs=521453=521757#toc Repository:

[Lldb-commits] [PATCH] D150299: [lldb][NFCI] Redefine dw_attr_t typedef with llvm::dwarf::Attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG64f1fda29e2d: [lldb][NFCI] Redefine dw_attr_t typedef with llvm::dwarf::Attribute (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

bulbazord added a comment. In D150402#4337400 , @fdeazeve wrote: > Thanks for doing this! In particular, all the early returns are very welcome > :) > > I suspect you already have this in your radar, but `ExtractFormValueAtIndex` > could probably

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

bulbazord added a comment. In D150418#4337243 , @JDevlieghere wrote: > Given the numbers I'm surprised you decided to stick with 8 rather than 4? > Unless I'm reading them wrong, it seems that despite the number of > allocations, it's about as fast

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

bulbazord added a comment. I previously uploaded a similar patch that I've since abandoned. It contains valuable context so I'm linking it here for other contributors to read: D149214 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord abandoned this revision. bulbazord added a comment. Thanks for the reviews and suggestions. I took a step back and looked at DWARFAbbreviationDeclaration and DWARFAttribute in more detail and I've decided I'm going to take this in a slightly different direction. I don't want to

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, mib, jingham, labath, kastiglione, rastogishubham, fdeazeve, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber:

[Lldb-commits] [PATCH] D150366: [lldb][NFCI] Use llvm's libDebugInfo for DebugRanges

bulbazord added a comment. Ok, this looks like it's doing the same thing to me which is good. My understanding of this change is that you're changing `lldb::DWARFDebugRanges::Extract` to use `llvm::DWARFDebugRangeList` instead of `lldb::DWARFRangeList`. Out of curiosity, do you have an idea

[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

bulbazord created this revision. bulbazord added reviewers: aprantl, JDevlieghere, clayborg, jingham, rastogishubham, fdeazeve. Herald added a subscriber: arphaman. Herald added a reviewer: shafik. Herald added a project: All. bulbazord requested review of this revision. Herald added a project:

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:61 uint8_t m_has_children = 0; - DWARFAttribute::collection m_attributes; }; kastiglione wrote: > With this change, can the following be

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. In D149914#4335858 , @aprantl wrote: > I'm not opposed to using this implementation, but have you considered using > something like the stdlib regex library to do the heavy lifting? I had not considered it actually... I don't

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord updated this revision to Diff 521414. bulbazord added a comment. Update documentation for clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149914/new/ https://reviews.llvm.org/D149914 Files:

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. Ok, I'm back with actual data on this patch. I have a test ObjC app with some UI, it loads a couple hundred modules. I place a breakpoint on main, I run until we hit main, and then I continue. My app will stop at `-[NSBlockOperation main]` after loading all the

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

bulbazord accepted this revision. bulbazord added a comment. LGTM! I know we have this pattern in many places in LLDB. It's good to see this work being done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150363/new/

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

bulbazord added a comment. In D150303#4333215 , @rriddle wrote: > Could we switch the RTTI to use the llvm RTTI extension mechanism, instead of > enums? Other classes have started doing this, and it'd be really nice if > users can write REPLS without

[Lldb-commits] [PATCH] D150299: [lldb][NFCI] Redefine dw_attr_t typedef with llvm::dwarf::Attribute

bulbazord created this revision. bulbazord added reviewers: aprantl, jingham, clayborg, rastogishubham, fdeazeve. Herald added a subscriber: arphaman. Herald added a reviewer: shafik. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ec334dc7b73: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord updated this revision to Diff 521047. bulbazord added a comment. Fix a warning in HashedNameToDIE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/ https://reviews.llvm.org/D150228 Files: lldb/include/lldb/Core/dwarf.h

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord added a comment. In D150228#4331943 , @fdeazeve wrote: > Do you have plans to do something similar for the attribute typedef? Yes I would like to do that too! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

bulbazord added inline comments. Comment at: lldb/include/lldb/Target/StackFrameList.h:103-104 - void GetFramesUpTo(uint32_t end_idx); + /// Gets frames up to end_idx (which can be greater than the actual number of + /// frames.) Returns true if the function was

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. In D149914#4331048 , @jingham wrote: > Most of this is fine. I wonder about avoiding caching the full name and name > w/o category & selector name. One of the main uses of this class is to take > incoming ObjC names from

[Lldb-commits] [PATCH] D150235: [lldb] Change definition of DisassemblerCreateInstance

bulbazord created this revision. bulbazord added reviewers: jingham, mib, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DissassemblerCreateInstance is a function pointer whos return

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord updated this revision to Diff 520854. bulbazord added a comment. Remove unused include in header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/ https://reviews.llvm.org/D150228 Files: lldb/include/lldb/Core/dwarf.h

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord updated this revision to Diff 520853. bulbazord added a comment. Do a typedef in dwarf.h (like llvm::dwarf::Tag) instead of explicitly writing the type out everywhere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord added a reviewer: JDevlieghere. bulbazord added a comment. In D150228#4330798 , @jingham wrote: > Apparently a similar change was made with dw_tag_t, in the line below your > first deletion I see: > > typedef llvm::dwarf::Tag dw_tag_t; > > It

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord created this revision. bulbazord added reviewers: aprantl, rastogishubham, fdeazeve, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB currently defines `dw_form_t` as a

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

bulbazord added inline comments. Comment at: lldb/unittests/API/SBCommandInterpreterTest.cpp:24 SBDebugger::Initialize(); m_dbg = SBDebugger::Create(/*source_init_files=*/false); } jingham wrote: > It isn't clear to me how the changes in this file

[Lldb-commits] [PATCH] D150222: [lldb][NFCI] Remove custom dwarf LEB128 types

This revision was automatically updated to reflect the committed changes. Closed by commit rGb77e41f2886a: [lldb][NFCI] Remove custom dwarf LEB128 types (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150222/new/

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

bulbazord added inline comments. Comment at: lldb/include/lldb/API/SBBreakpoint.h:18-19 class ScriptInterpreter; +namespace python { +class SWIGBridge; } mib wrote: > We've talked about this offline, but I think we should stay language agnostic > in the

[Lldb-commits] [PATCH] D150222: [lldb][NFCI] Remove custom dwarf LEB128 types

bulbazord created this revision. bulbazord added reviewers: aprantl, rastogishubham, fdeazeve, JDevlieghere, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The LEB128 type defined by the

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

bulbazord accepted this revision. bulbazord added a comment. I like this. :) Comment at: lldb/source/Utility/Broadcaster.cpp:392 } -m_event_map.erase(iter); +iter = m_event_map.erase(iter); } I don't think you need to actually capture the

[Lldb-commits] [PATCH] D150168: [lldb] Simplify predicates of find_if in BroadcastManager

This revision was automatically updated to reflect the committed changes. Closed by commit rGec77d1f3d9fc: [lldb] Simplify predicates of find_if in BroadcastManager (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150168/new/

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I have no problem with removing mod_date since you're only removing the requirement in the Darwin-specific code. Also, be sure to remove the portion of the commit message that says this

[Lldb-commits] [PATCH] D150168: [lldb] Simplify predicates of find_if in BroadcastManager

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We had some custom classes that were used as the predicate for

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

bulbazord added a comment. This looks good to me. > This patch does have a regression on > API/macosx/unregistered-macho/TestUnregisteredMacho.py that I wrote last > summer; I have the patch generate JSON for a binary that it had an address > for, but could not read the mach-o headers. This

[Lldb-commits] [PATCH] D150160: [lldb] Simplify Log::PutString (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Utility/Log.cpp:135 -void Log::PutCString(const char *cstr) { Printf("%s", cstr); } -void Log::PutString(llvm::StringRef str) {

[Lldb-commits] [PATCH] D149702: [LLDB] Add minimal support for the new Mojo language

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Don't forget to come back and update it when you get an official designation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149702/new/

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149987/new/ https://reviews.llvm.org/D149987

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

bulbazord added inline comments. Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:103-104 + + return new ObjectFileCOFF(module_sp, data_sp, data_offset, file, file_offset, +length); +} compnerd wrote: > bulbazord

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

bulbazord added a comment. We're definitely going to want a test for this, either a shell test or a unit test. Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:103-104 + + return new ObjectFileCOFF(module_sp, data_sp, data_offset, file, file_offset, +

[Lldb-commits] [PATCH] D149900: [lldb] Expose a const iterator for SymbolContextList

bulbazord added a comment. Looks like this may have broken the Debian buildbot: https://lab.llvm.org/buildbot/#/builders/68/builds/52162/steps/6/logs/stdio I'm taking a look and will try to fix forward. If I can't figure it out quickly, I will revert. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D149900: [lldb] Expose a const iterator for SymbolContextList

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04aa943be8ed: [lldb] Expose a const iterator for SymbolContextList (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D149900: [lldb] Expose a const iterator for SymbolContextList

bulbazord updated this revision to Diff 519690. bulbazord added a comment. Explicitly write out type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149900/new/ https://reviews.llvm.org/D149900 Files:

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, mib, jingham, kastiglione. Herald added a subscriber: arphaman. Herald added a reviewer: shafik. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a

[Lldb-commits] [PATCH] D149804: [lldb][NFCI] Add unittests for ObjCLanguage::MethodName

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc39d98c3faa: [lldb][NFCI] Add unittests for ObjCLanguage::MethodName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149804/new/

[Lldb-commits] [PATCH] D149900: [lldb] Expose a const iterator for SymbolContextList

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, aprantl. Herald added a project: All. bulbazord requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, jplehr, sstefan1. Herald added a project: LLDB.

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149717/new/ https://reviews.llvm.org/D149717

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

bulbazord added inline comments. Comment at: lldb/include/lldb/Expression/REPL.h:124 +const lldb::ValueObjectSP _valobj_sp, +const Status ) { +return llvm::Error::success(); Do you still need the `Status`

[Lldb-commits] [PATCH] D149803: Use the `addressing_bits` kv in the stop packet from the remote stub, if present

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Makes sense to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149803/new/ https://reviews.llvm.org/D149803

[Lldb-commits] [PATCH] D149804: [lldb][NFCI] Add unittests for ObjCLanguage::MethodName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, Michael137, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I have a patch to refactor this class and I'd like a

[Lldb-commits] [PATCH] D149774: [lldb] Use templates to simplify {Get, Set}PropertyAtIndex (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I quite like the idea. Probably want to wait for others to look over it but I think it's good! Comment at: lldb/source/Core/Debugger.cpp:394 const uint32_t idx =

[Lldb-commits] [PATCH] D149697: [lldb] Remove distribution_id from ArchSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd05ffdbb2c3: [lldb] Remove distribution_id from ArchSpec (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149697/new/

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

bulbazord added inline comments. Comment at: lldb/include/lldb/Expression/REPL.h:115-120 + virtual void + OnExpressionEvaluated(const ExecutionContext _ctx, llvm::StringRef code, +const EvaluateExpressionOptions _options, +

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

bulbazord added a reviewer: JDevlieghere. bulbazord added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:503-504 + /// Manually start the global event handler thread. It should be used by + /// programs that use LLDB as a library. + bool

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4f3f5225df7: [lldb] Remove FileSpec::GetLastPathComponent (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149663/new/

[Lldb-commits] [PATCH] D149671: [lldb] Minor cleanups at callsites of FileSpec::GetFileNameExtension

This revision was automatically updated to reflect the committed changes. Closed by commit rG50e79d725c10: [lldb] Minor cleanups at callsites of FileSpec::GetFileNameExtension (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

bulbazord added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:493 eLanguageTypeAda2012 = 0x002f, + eLanguageTypeMojo = 0x0030, These values correspond to DWARF5's official language codes and `0x0030` is technically already taken. LLDB

[Lldb-commits] [PATCH] D149096: [lldb] Speed up looking for dSYM next to executable

bulbazord abandoned this revision. bulbazord added a comment. I'm going to see how we could potentially improve FileSpec's performance rather than go with this approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149096/new/

[Lldb-commits] [PATCH] D149697: [lldb] Remove distribution_id from ArchSpec

bulbazord created this revision. bulbazord added reviewers: jasonmolenda, labath, DavidSpickett. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The qHostInfo packet in the gdb-remote communication

<    1   2   3   4   5   6   7   8   9   10   >