[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

teemperor added a comment. I think, given the support for multi-line expressions, updating the test case is IMHO the right call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://reviews.llvm.org/D150772

[Lldb-commits] [PATCH] D139740: [lldb] Disable macro redefinition warnings in expression wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f3a3e1f3f97: [lldb] Disable macro redefinition warnings in expression wrapper (authored by teemperor). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D139740: [lldb] Disable macro redefinition warnings in expression wrapper

teemperor updated this revision to Diff 497440. teemperor added a comment. - Address builtin redefining (Thanks Michael!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139740/new/ https://reviews.llvm.org/D139740 Files:

[Lldb-commits] [PATCH] D139740: [lldb] Disable macro redefinition warnings in expression wrapper

teemperor created this revision. teemperor added a reviewer: Michael137. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. GCC emits macro definitions into

[Lldb-commits] [PATCH] D126057: [lldb] Fix that empty target.run-args are not actually used when launching process

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8bec6117998: [lldb] Fix that empty target.run-args are not actually used when launching… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

teemperor added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 + "The breakpoint was set for queue %s, but the breakpoint's queue name is %s" % (queue_breakpoint.GetQueueName(), queue1.GetName())) +

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

teemperor added a comment. import-std-module test changes look good to me, thanks for fixing that up. And yes, ideally the tests should never use any libc++ internal names (and LLDB should never print them for those tests). So I think not having those in the here is a step in the right

[Lldb-commits] [PATCH] D126668: LLDB: Fix resolving nested template parameters

teemperor added a comment. > I don't really have the full context here, but I am wondering if we shouldn't > somehow take the DW_AT_declaration attribute into account here. It seems like > that should give a more definitive answer as to whether we can expect to see > a full set of template

[Lldb-commits] [PATCH] D126057: [lldb] Fix that empty target.run-args are not actually used when launching process

teemperor added a comment. Don't have access to a macOS machine that can run the tests, so maybe someone should give this a spin before landing :) Comment at: lldb/source/Interpreter/OptionValueProperties.cpp:257 const OptionValueArray *array = value->GetAsArray(); - if

[Lldb-commits] [PATCH] D126057: [lldb] Fix that empty target.run-args are not actually used when launching process

teemperor created this revision. teemperor added reviewers: JDevlieghere, kastiglione. teemperor added a project: LLDB. Herald added a project: All. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. `GetPropertyAtIndexAsArgs` returns true on success and false

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

teemperor accepted this revision. teemperor added a comment. This is beautiful CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91835/new/ https://reviews.llvm.org/D91835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D121064: [lldb] Add a setting to change the autosuggestion ANSI escape codes

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! FWIW, if you have `fish` installed you might wanna check what they are doing on your terminal for its autosuggestions (and we might wanna steal their default, even though

[Lldb-commits] [PATCH] D85719: Initialize static const fields in the AST for expression evaluation

teemperor added a comment. Btw, that patch that I referenced hasn't landed yet (it just lacks the tests and probably rebasing), but I'm OOO for an unknown duration so feel free to land it yourself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this! Comment at: lldb/source/Plugins/ExpressionParser/Clang/CppModuleConfiguration.cpp:86 - // Check for /usr/include. On Linux this might

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

teemperor added a comment. In D113498#3131336 , @werat wrote: > In D113498#3124525 , @teemperor > wrote: > >> I really like the solution, but I think by fixing the `CanInterpret` you >> also made the test case

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

teemperor added a subscriber: labath. teemperor added a comment. @labath raised some concerns in IRC about the setup code being run in a potential multithreaded env (which makes sense). Feel free to revert (not sure when/if I'll get around to address the issues) Repository: rG LLVM Github

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcef1e07cc6d0: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT (authored by teemperor). Herald added a subscriber:

[Lldb-commits] [PATCH] D113687: [lldb][NFC] Inclusive language: replace master/slave names for ptys

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113687/new/ https://reviews.llvm.org/D113687

[Lldb-commits] [PATCH] D113673: [lldb] Unwrap the type when dereferencing the value

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks a lot for fixing this, could you point to D103532 as the cause for the regression in the commit message? This LGTM in general, but I think

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

teemperor added a reviewer: LLDB. teemperor added a comment. I really like the solution, but I think by fixing the `CanInterpret` you also made the test case no longer reach the actual changed interpreting logic? So, `CanInterpret` says "we can't interpret this" (which is correct), but then

[Lldb-commits] [PATCH] D113605: [lldb] Fix documentation for EncodingDataType

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/include/lldb/Symbol/Type.h:69 enum EncodingDataType { +/// Invalid encoding eEncodingInvalid, nit: LLVM

[Lldb-commits] [PATCH] D113634: [lldb] Add support for DW_TAG_immutable_type

teemperor added a comment. In D113634#3124401 , @ljmf00 wrote: > In D113634#3124042 , @teemperor > wrote: > >> Are the DWARFASTParserClang changes meant as a step towards making it parse >> D? > > Yes, not only

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

teemperor added a comment. In D111409#3124194 , @labath wrote: > In D111409#3124075 , @teemperor > wrote: > >>> Are you asking for dedicated physical resources for running nightly builds? >> >> I don't think any

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

teemperor added a comment. > Are you asking for dedicated physical resources for running nightly builds? I don't think any of the current bots have a Java installation so I think it's either that or we get someone with a bot to setup the required Java installation. FWIW, if no one wants to

[Lldb-commits] [PATCH] D113634: [lldb] Add support for DW_TAG_immutable_type

teemperor added a comment. Are the DWARFASTParserClang changes meant as a step towards making it parse D? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113634/new/ https://reviews.llvm.org/D113634 ___

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

teemperor added a comment. I changed the commit name from "Add support for D programming language" to "[lldb] Add support for demangling D symbols" when landing (which is more accurate). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110578/new/

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

This revision was automatically updated to reflect the committed changes. Closed by commit rG96a735990839: [lldb] Add support for demangling D symbols (authored by ljmf00, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

teemperor added inline comments. Comment at: lldb/include/lldb/Symbol/Type.h:86 eEncodingIsAtomicUID, ///< This type is the type whose UID is /// m_encoding_uid as an atomic type. eEncodingIsSyntheticUID

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I guess that's just clang-format ran over the file? If yes, then LGTM Comment at: lldb/include/lldb/Symbol/Type.h:86 eEncodingIsAtomicUID, ///< This type

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

teemperor added a comment. I actually didn't see that the patch deleted the TestCppReferenceToOuterClass test. Could you just add a `@skipIf # Crashes` or so above its `def test...` method? The test itself is still valid user code that we shouldn't crash on. I left some nits and the test

[Lldb-commits] [PATCH] D113533: [LLDB] Remove access check of decl in TypeSystemClang.cpp

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I'm pretty sure you're trying to solve the same problem as here: D85993 In short: You're calling `CreateFunctionDeclaration` to create a

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

teemperor added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/PR52257.cpp:21 +}; +B b; FWIW, I think probably should be an API test (for a bunch of reasons from not relying on formatting output to remote device testing), but given this is just

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113449/new/ https://reviews.llvm.org/D113449

[Lldb-commits] [PATCH] D113175: [lldb][NFC] Remove a bunch of unnecessary nullptr checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG7323d07483f2: [lldb][NFC] Remove a bunch of unnecessary nullptr checks (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D113176: [lldb][NFC] StringRef-ify the name parameter in CreateEnumerationType

This revision was automatically updated to reflect the committed changes. Closed by commit rGb738a69ab8e3: [lldb][NFC] StringRef-ify the name parameter in CreateEnumerationType (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/test/API/python_api/file_handle/TestFileHandle.py:920 +self.assertTrue(re.search(r'Show a list of all debugger commands',

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

teemperor added a comment. In D112439#3102752 , @xujuntwt95329 wrote: > Thanks a lot for your comments, they are very useful and I learned a lot > about C++ by talking with you. > > I'll address these comments and submit a patch and request your

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

teemperor added a comment. Fixed in 58dd658583eec9af24ca1262e1bce9f884d65487 (Also left some nits in the test because I anyway looked over the code.) Comment at: lldb/unittests/Target/FindFileTest.cpp:27 +

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

teemperor added a comment. In D112439#3102559 , @xujuntwt95329 wrote: > In D112439#3102548 , @teemperor > wrote: > >> In D112439#3102533 , >> @xujuntwt95329 wrote: >>

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

teemperor added a comment. In D112439#3102533 , @xujuntwt95329 wrote: > In D112439#3102506 , @teemperor > wrote: > >> In D112439#3098307 , >> @xujuntwt95329 wrote: >>

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

teemperor added a comment. In D112439#3098307 , @xujuntwt95329 wrote: > Seems that patch can't build by CI because it is based on this patch. In my > understanding we need to merge this patch firstly and rebase that NFC patch > to let CI work, right?

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

teemperor added a comment. I think this was just fixed by 48677f58b06cfb8715902173c5bc3d1764d7c8c6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

teemperor added a subscriber: labath. teemperor added a comment. In D112165#3100929 , @dblaikie wrote: > In D112165#3100608 , @teemperor > wrote: > >> Small note: gmodules test are never run on Linux, so you

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

teemperor added a comment. Small note: gmodules test are never run on Linux, so you actually have to run them on macOS (or I think FreeBSD) to know whether the tests work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112165/new/

[Lldb-commits] [PATCH] D112856: [lldb] Only specify LLVM_ENABLE_RUNTIMES in the libcxx error message.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112856/new/ https://reviews.llvm.org/D112856 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D112379: [lldb][NFC] Modernize for-loops in ModuleList

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cf9d1e4492f: [lldb][NFC] Modernize for-loops in ModuleList (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112615: [lldb] Make SBType::IsTypeComplete more consistent by forcing the loading of definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rG85bcc1eb2f56: [lldb] Make SBType::IsTypeComplete more consistent by forcing the loading of… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D112697: [lldb] Update field offset/sizes when encountering artificial members such as vtable pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2ede1715d41: [lldb] Update field offset/sizes when encountering artificial members such as… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D112802: [lldb/test] Replace shlex.join with shlex.quote

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks! Comment at: lldb/packages/Python/lldbsuite/support/seven.py:54 + +def join_for_shell(split_command): +return " ".join([shlex.quote(part) for part in

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

This revision was automatically updated to reflect the committed changes. Closed by commit rGac73f567cffb: [lldb] Remove forgotten FIXME on CPlusPlus formatters (authored by ljmf00, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

teemperor added a comment. In D112586#3094519 , @ljmf00 wrote: > In D112586#3093490 , @teemperor > wrote: > >> LGTM, thanks. > > Note: I can't land it I can land it for you tomorrow (unless someone beats me to

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Apologies for the delay, this slipped out of my review queue by accident. The patch looks in general pretty much ready, I just have a few nits here and there. (Also just to

[Lldb-commits] [PATCH] D112708: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D112708#3093318 , @labath wrote: > In D112708#3093252 , @teemperor > wrote: > >> LGTM, could you

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

teemperor added subscribers: labath, teemperor. teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112586/new/

[Lldb-commits] [PATCH] D112708: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. LGTM, could you also extend a non-unit test to test the change within the whole FormatManager/etc. setup? I think `TestDataFormatterAdv.py` already has a very similar section

[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks. On a more general note: I wish we would just kill off inline tests instead of trying to make them usable. But I think that's a discussion for the mailing lists...

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

teemperor added a comment. Given that `shlex.join` is only used for making the diagnostics copy-pastable into the terminal, we could probably get away by just making it use the normal string conversion of list or something like `" ".join(...)`. I don't think we have anyone that really debugs

[Lldb-commits] [PATCH] D112379: [lldb][NFC] Modernize for-loops in ModuleList

teemperor added a comment. Straightforward but looking for a second set of eyes Comment at: lldb/source/Core/ModuleList.cpp:204 +bool ModuleList::AppendIfNeeded(const ModuleSP _module, bool notify) { + if (new_module) { std::lock_guard guard(m_modules_mutex);

[Lldb-commits] [PATCH] D112379: [lldb][NFC] Modernize for-loops in ModuleList

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. https://reviews.llvm.org/D112379 Files: lldb/include/lldb/Core/ModuleList.h

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks! This is looking pretty good, I just have some final minor comments about some code that I think we can also drop/split-out. Comment at:

[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

teemperor added a comment. In D112340#3081532 , @dblaikie wrote: > Sorry I missed this - are these tested anywhere/should I have been able to > discover if these needed to be changed before I made the change? TestCompactVectors tests this but its

[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Please also remove the FIXME, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112340/new/ https://reviews.llvm.org/D112340

[Lldb-commits] [PATCH] D112325: [lldb] Pass the target triple to the compiler when determining the DWARF version

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Some nits but otherwise LGTM Comment at: lldb/packages/Python/lldbsuite/test/builders/builder.py:26 +"""Returns the triple for the given architecture or an

[Lldb-commits] [PATCH] D112147: [lldb] Fix lookup for global constants in namespaces

teemperor added reviewers: clayborg, jankratochvil. teemperor added a comment. LGTM, but I have never touched this function so +Greg and Jan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112147/new/ https://reviews.llvm.org/D112147

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

teemperor added a comment. This LGTM, but `shlex.join` is actually Py3 exclusive and I don't think there is a good Py2 replacement. I think we're just in time for the Py2->3 migration according to the timeline Jonas posted last year

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

teemperor added a comment. In D111686#3079248 , @clayborg wrote: > So there is a buildbot failure due to an expression which succeeds, but > because the "expression" command options don't apply cleanly to the > expression result the "expression"

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

teemperor added a comment. In D112212#3078681 , @dblaikie wrote: > Does this sort of thing itself get tested? (like this one had a test: > https://reviews.llvm.org/D111978 but not sure how much that > generalizes/whether there are different parts of

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

teemperor added a comment. In D11#3077988 , @puremourning wrote: > I'm happy to revert/split out the change for empty strings, as this is > perhaps contentious (and not exactly minimal for this patch). I would actually prefer if we could split

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for working on this! Some notes/nits: - nit: The patch seems to have a bunch of unrelated clang-format changes for CPlusPlusLanguage.cpp in it. You can prevent that by

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

teemperor added a comment. There is one on Green Dragon with a few Clang versions and I there is my Linux one with a all GCC/Clang versions Repository: rG LLVM Github

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Tests with libc++ as a category are not run on Windows or when GCC is the test compiler, so those decorators are redundant. Removing the Clang XFAIL also seems fine, I

[Lldb-commits] [PATCH] D112061: [lldb] Remove ConstString from GetPluginNameStatic of some plugins

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112061/new/ https://reviews.llvm.org/D112061

[Lldb-commits] [PATCH] D111936: [lldb] Allow dumping the state of all scratch TypeSystems

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a57d1e52680: [lldb] Allow dumping the state of all scratch TypeSystems (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D111931: [lldb] Filter duplicates in Target::GetScratchTypeSystems

This revision was automatically updated to reflect the committed changes. Closed by commit rGcfaa5c344d5b: [lldb] Filter duplicates in Target::GetScratchTypeSystems (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D111989: [lldb] Reduce code duplication around inferior building

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111989/new/ https://reviews.llvm.org/D111989

[Lldb-commits] [PATCH] D111981: [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin platforms

teemperor added a comment. In D111981#3071349 , @dblaikie wrote: > So this'll add the right test dependency, if the libcxx project is enabled in > the build? (& if the build hasn't enabled libcxx, the tests will run, but > against the system compiler -

[Lldb-commits] [PATCH] D111981: [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rG366fb539485a: [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

teemperor added a comment. In D111715#3068412 , @thakis wrote: > I don't have an opinion on this change and I don't mind the demangler change, > but isn't the type information helpful? The mangled itanium name doesn't > include type information which

[Lldb-commits] [PATCH] D111632: [lldb] Split ParseSingleMember into Obj-C property and normal member/ivar parsing code.

This revision was automatically updated to reflect the committed changes. Closed by commit rG60b96aa65e59: [lldb] Split ParseSingleMember into Obj-C property and normal member/ivar… (authored by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D111877: [lldb] Return StringRef from PluginInterface::GetPluginName

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I'm wondering if some of those should be `std::string` instead, but this is in any case a step in the right direction so LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D111816: [lldb] Remove logging from Platform::~Platform

teemperor added a comment. Fixed, thanks! In D111816#3064923 , @thakis wrote: > http://45.33.8.238/mac/37050/step_4.txt > > In file included from > ../../lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:9: > In file included from >

[Lldb-commits] [PATCH] D111816: [lldb] Remove logging from Platform::~Platform

This revision was automatically updated to reflect the committed changes. Closed by commit rGe632e900ac10: [lldb] Remove logging from Platform::~Platform (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

teemperor added reviewers: mstorsjo, rnk. teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Herald added a subscriber: JDevlieghere. This looks in general good to me. You probably want to add a test for this

[Lldb-commits] [PATCH] D111634: [lldb] Print embedded nuls in char arrays (PR44649)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:40 +//% self.expect_var_path("c.data", summary=r'"F\0O"') //%

[Lldb-commits] [PATCH] D111494: [lldb][NFCI] Refactor out attribute parsing from DWARFASTParserClang::ParseSingleMember

This revision was automatically updated to reflect the committed changes. Closed by commit rGf110999bf6b5: [lldb][NFCI] Refactor out attribute parsing from DWARFASTParserClang… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D108629: [lldb] Add support for DW_AT_calling_convention to the DWARF parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3256aa8fe6fd: [lldb] Add support for DW_AT_calling_convention to the DWARF parser (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D111149: [lldb] Don't print to stderr in TypeSystemClang::GetBuiltinTypeForDWARFEncodingAndBitSize

This revision was automatically updated to reflect the committed changes. Closed by commit rG592e89cc4e9a: [lldb] Dont print to stderr in TypeSystemClang… (authored by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D111399: [lldb] Make char[N] formatters respect the end of the array (PR44649)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, but maybe give the test comment a FIXME. Comment at: lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:39 + //%

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

teemperor added a comment. No problem, first time using Phabricator is always a bit confusing. You can just do a `git diff -U99 > ~/java-patch.diff`, click the "Update Diff" button on the top right of this website and then select *just* this diff file that contains your changes.

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

teemperor added a comment. In D111409#3051110 , @d-millar wrote: > Apologies for the inclusion of that last file "patch" - that is the "git diff > -U999" result, should that be useful. You can just upload that diff file and Phabricator will display

[Lldb-commits] [PATCH] D111402: [lldb] [test] Use secondary pty end for testing Terminal

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. If Green Dragon was still with us this would make it happy (and green), so LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111402/new/ https://reviews.llvm.org/D111402

[Lldb-commits] [PATCH] D111387: [NFC] [Clang] Remove pre-computed complex float types

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Would be nice to have the motivation for this in the commit message (IIUC this is based on the suggestion from D109948

[Lldb-commits] [PATCH] D110696: [lldb][import-std-module] Prefer the non-module diagnostics when in fallback mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fcb857746c1: [lldb][import-std-module] Prefer the non-module diagnostics when in fallback… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D111052: [lldb] [gdb-remote] Correct st_dev values in vFile:fstat packet

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. Could you maybe add a `FIXME:` at the end of that comment to point out that the whole 'console' thing isn't implemented/supported. Probably wait and see if Pavel has any

[Lldb-commits] [PATCH] D108228: Fix error handling in the libcxx std::string formatter

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D108228#2961132 , @jingham wrote: > Raphael's analysis of what the test needs is right. We always check pointers > for validity before we

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

teemperor added a comment. Thanks for the patch! Out of curiosity: What distribution is using target-specific include paths? I can take a look at this tomorrow, but just from scrolling over I think the general direction of this patch seems fine, so I think I only have a few nits here and

[Lldb-commits] [PATCH] D110804: Add a new command "target metrics".

teemperor added inline comments. Comment at: lldb/include/lldb/Core/Module.h:940 + /// ElapsedTime + double () { return m_symtab_parse_time; } + double () { return m_symtab_names_time; } labath wrote: > teemperor wrote: > > Could the `double` and `uint64_t`

[Lldb-commits] [PATCH] D110804: Add a new command "target metrics".

teemperor added subscribers: vsk, teemperor. teemperor added a comment. +Vedant who had/has some plans with the statistics command at some point IIRC. FWIW, I wanted to throw away the current statistics implementation for quite a while but I didn't have anything to replace it with. If we can

[Lldb-commits] [PATCH] D110693: [lldb] [Host] Remove TerminalStateSwitcher

teemperor accepted this revision. teemperor added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110693/new/ https://reviews.llvm.org/D110693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

teemperor added a comment. In D110578#3027707 , @ljmf00 wrote: > In D110578#3027692 , @teemperor > wrote: > >> Do you have commit access or should someone land this for you? > > I don't have commit access,

  1   2   3   4   5   6   7   8   9   10   >