Re: [Discuss][VOTE] Combine the project user and dev mailing lists into user@ and dev@

2017-03-28 Thread Paul Benedict
Yes, I think combining the "user@" and "dev@" variants into two are appropriate. +1 (non-binding) for me. Furthermore --- and this has always been a scratch of mine to itch (and I raise this about once a year!) -- I would like a dedicated "issues@" mailing list like other Apache projects. The trad

Re: logging-log4j2 git commit: Use the standard US English spelling for "behavior".

2016-08-04 Thread Paul Benedict
I don't think a mix of English dialects helps comprehension. I see it as detracting from the usability of the documentation. Theoretically, if I was asked to vote on the matter, I would vote for American English. Why? This code base is being written for a corporation based in America (Apache incor

Re: Log4j should manage it's own threads

2016-07-14 Thread Paul Benedict
t; and non-JEE environments. > > Ralph > > On Jul 14, 2016, at 1:07 PM, Paul Benedict wrote: > > In an EE environment, don't create your own threads. If you do create your > own threads, the EE server has no way to shut them down when an application > gets undeployed. You

Re: Log4j should manage it's own threads

2016-07-14 Thread Paul Benedict
wrote: > On Thu, Jul 14, 2016 at 1:07 PM, Paul Benedict > wrote: > >> In an EE environment, don't create your own threads. If you do create >> your own threads, the EE server has no way to shut them down when an >> application gets undeployed. You'd want to ha

Re: Log4j should manage it's own threads

2016-07-14 Thread Paul Benedict
In an EE environment, don't create your own threads. If you do create your own threads, the EE server has no way to shut them down when an application gets undeployed. You'd want to have the EE server manage the thread creations. Cheers, Paul On Thu, Jul 14, 2016 at 2:41 PM, Gary Gregory wrote:

Re: Log4J 1.x and JDK 9

2016-07-14 Thread Paul Benedict
a Linux >> VM. I think Gary might have built Log4j 1 in the past. >> >> Ralph >> >> On Jul 14, 2016, at 8:52 AM, Paul Benedict wrote: >> >> Matt, I guess you need JDK 1.4.2 on your machine to have artifact >> "sun.jdk:tools:jar:1.4.2".

Re: Log4J 1.x and JDK 9

2016-07-14 Thread Paul Benedict
? We need to make sure that Log4j 2 works >> well with Java 9, but otherwise I think this is an excellent opportunity >> for users to upgrade to Log4j 2. >> >> Remko >> >> >> On Thu, Jul 14, 2016 at 11:56 PM, Paul Benedict >> wrote: >> >>&

Log4J 1.x and JDK 9

2016-07-14 Thread Paul Benedict
According to this poster, it appears 1.x is not compatible with JDK 9: http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-July/008654.html I told them I would notify our development community. So here's the notification. :-) Given how widely used 1.x is still, what do you guys think of one mo

Thoughts on Log4J 3.0 branding

2016-06-29 Thread Paul Benedict
Regarding 3.0, I think it's going to be a bit of an image problem to get there -- a little uphill battle. Right now the entire website is branded as a "2" site to separate it from the decades long fandom of the 1.x site. I am not blaming anyone for that decision. It was necessary to differentia

Re: I can see! (colors)

2016-06-29 Thread Paul Benedict
addresses, hex data, char data, and separators in >>> different colors. For example, nicer than >>> http://mynixworld.info/wp-content/uploads/2012/09/boot-loader-hexdump1.png >>> >>> Gary >>> >>> On Tue, Jun 28, 2016 at 8:22 AM,

Re: I can see! (colors)

2016-06-28 Thread Paul Benedict
That's very nice looking! Cheers, Paul On Tue, Jun 28, 2016 at 1:03 AM, Gary Gregory wrote: > For fun: https://ibin.co/2mBev3ns9FJz.png > > Gary > > On Wed, Jun 15, 2016 at 10:50 PM, Gary Gregory > wrote: > >> Hi All, >> >> See color messages in Maven 3.4.0-SNAPSHOT made me think of the follow

Re: I can see! (colors)

2016-06-25 Thread Paul Benedict
e/ >> >> More general: >> >> Add to PatternLayout a %styledMessage, use that instead of %m and: >> - A console appends rewrites the message as an ANSI message. >> - An HTML layout rewrites the message as an HTML fragment. >> >> The message syntax is TD

Re: I can see! (colors)

2016-06-25 Thread Paul Benedict
think the Maven folks are experiencing growing pains now that they have >>>>> enabled color within Maven messages. I think a StyledMessage would be the >>>>> way to go. >>>>> >>>>> When a StyledMessage goes to a Console appender, JAnsi is u

Re: Lock pattern

2016-06-24 Thread Paul Benedict
That may be the one! Thanks for searching for it. I can't believe it's from three years ago! :-) Anyway, it goes on for some time and provides good arguments to consider from both sides. Cheers, Paul On Fri, Jun 24, 2016 at 4:10 AM, Gary Gregory wrote: > On Thu, Jun 23, 2016 at 4:51 PM, Greg Th

Re: Lock pattern

2016-06-23 Thread Paul Benedict
If my memory serves me right, there is a whole thread on OpenJDK message boards on this design. I will find it and send it, time permitting. On Jun 23, 2016 9:07 PM, "Matt Sicker" wrote: > Any locks that don't use wait/notify could be converted to Object monitors > instead. Using the Lock interf

Re: I can see! (colors)

2016-06-21 Thread Paul Benedict
ny dependency on Jansi at > the API level. (But things like RED etc can be inner classes of > JansiMessage. Static imports can make this painless to use.) > > > On Tue, Jun 21, 2016 at 3:59 AM, Paul Benedict > wrote: > >> It's pretty cool. Yes, a generalized syntax

Re: I can see! (colors)

2016-06-20 Thread Paul Benedict
r. > > Gary > > On Thu, Jun 16, 2016 at 12:59 PM, Gary Gregory > wrote: > >> On Thu, Jun 16, 2016 at 12:48 PM, Paul Benedict >> wrote: >> >>> I imagine parsing the placeholder is going to be expensive (relatively >>> speaking). It is an extra c

Re: I can see! (colors)

2016-06-16 Thread Paul Benedict
appender as a callback for it to make the necessary modifications -- such as setting the color. Cheers, Paul On Thu, Jun 16, 2016 at 1:53 PM, Gary Gregory wrote: > > On Jun 16, 2016 11:25 AM, "Paul Benedict" wrote: > > > > Are you asking me for blue sky thinking,

Re: I can see! (colors)

2016-06-16 Thread Paul Benedict
, Jun 16, 2016 at 11:04 AM, Paul Benedict > wrote: > >> I think color falls into the category of formatting. By that, I mean to >> state that colors shouldn't be hardcoded into messages :-) That should >> belong to the actual formatter... template string or appender confi

Re: I can see! (colors)

2016-06-16 Thread Paul Benedict
I think color falls into the category of formatting. By that, I mean to state that colors shouldn't be hardcoded into messages :-) That should belong to the actual formatter... template string or appender configuration. Cheers, Paul On Thu, Jun 16, 2016 at 12:58 PM, Gary Gregory wrote: > On Thu

Re: Location performance

2016-05-12 Thread Paul Benedict
now slower. >> >> Ralph >> >> On May 10, 2016, at 9:47 AM, Ralph Goers >> wrote: >> >> No. On the openjdk list Mandy said that walking the Throwable as we are >> doing should be faster due to improvements made in JDK-8150778. >> >> Ralph &g

Re: Better mailing list interface

2016-05-12 Thread Paul Benedict
wrote: > >> Would you still not subscribe to JIRA? >> >> G >> >> On Thu, May 12, 2016 at 11:03 AM, Matt Sicker wrote: >> >>> I'd like that mainly because I keep getting two emails for every bit of >>> JIRA activity as it is right now.

Re: Better mailing list interface

2016-05-12 Thread Paul Benedict
That's nice!! I'll take this opportunity to raise an old preference of mine. I'd still like to separate out JIRA traffic from dev discussions into separate mailing lists. Last time I raised this, there was no agreement with me -- worth trying again? ;-) Cheers, Paul On Thu, May 12, 2016 at 12:46

Re: Location performance

2016-05-11 Thread Paul Benedict
he >>> Throwable, but that doesn’t mean much if that is now slower. >>> >>> Ralph >>> >>> On May 10, 2016, at 9:47 AM, Ralph Goers >>> wrote: >>> >>> No. On the openjdk list Mandy said that walking the Throwable as we are

Re: Location performance

2016-05-10 Thread Paul Benedict
Are you using the new JDK 9 APIs to walk the stack? Cheers, Paul On Tue, May 10, 2016 at 11:20 AM, Ralph Goers wrote: > Supposedly Java 9 was supposed to improve the performance of walking the > stack trace. However, the numbers I get below indicate to me that they are > moving in the opposite

Re: Gary's on-line presence...

2016-04-25 Thread Paul Benedict
May all your broadband dreams come true. Cheers, Paul On Mon, Apr 25, 2016 at 3:23 PM, Gary Gregory wrote: > ... will be on/off until 2016-05-04 due to ISP incompetence (moving house > and switching from Frontier to Time Warner). > > Please be patient if you expect something from me ;-) > > Gar

Re: Time for release?

2016-04-20 Thread Paul Benedict
I am subscribed to the OpenJDK Jigsaw mailing list. I've been in discussions there over several months. I can provide you some help/information if you need to know something about modules. Cheers, Paul On Wed, Apr 20, 2016 at 12:50 PM, Gary Gregory wrote: > Yeah, I do not think we need to do an

Re: One Include to rule them all

2016-03-02 Thread Paul Benedict
rocessing this document" unless you get in the guts of the > private Xerces copy which is in Oracle Java 7 (but not in Java 8), which we > do not want to do. Also XInclude does not work with JSON and YAML. > > G > > On Wed, Mar 2, 2016 at 10:52 AM, Paul Benedict > wrote

Re: One Include to rule them all

2016-03-02 Thread Paul Benedict
PS: Are we talking the same thing? Document inclusion is NOT the same as watching an external file. The former creates one seamless document; the second one is aware that the referenced file is distinct. Cheers, Paul On Wed, Mar 2, 2016 at 12:52 PM, Paul Benedict wrote: > I agree with

Re: One Include to rule them all

2016-03-02 Thread Paul Benedict
I agree with the initial assessment that XInclude is the way to go. If someone wants to use XInclude, they should provide the right parser implementation to make it available. I wouldn't bend over backward to do your own inclusion mechanism; put it on the consumer to provide the appropriate parser.

Re: traceExit and auto-boxing

2016-02-16 Thread Paul Benedict
hen I started Log4j 2. >>>>> >>>>> The more I think about this I am wondering if the effort shouldn’t >>>>> just be spent on implementing the annotations rather than arguing about >>>>> this stuff. The annotations don’t actually require t

Re: traceExit and auto-boxing

2016-02-16 Thread Paul Benedict
I messed up the code example. Sorry. Let all supported logging interfaces come from an empty marker interface. public interface LogManager { T getLogger(Class clz); } Cheers, Paul On Tue, Feb 16, 2016 at 10:27 AM, Paul Benedict wrote: > Maybe it's something worth discussing for

Re: traceExit and auto-boxing

2016-02-16 Thread Paul Benedict
r methods to LogManager. > > Which is better? > On Feb 15, 2016 7:58 PM, "Paul Benedict" wrote: > >> You could create special interfaces for these sets of special methods. >> There is not a design rule that says Logger must be the interface that does >> all thing

Re: traceExit and auto-boxing

2016-02-15 Thread Paul Benedict
You could create special interfaces for these sets of special methods. There is not a design rule that says Logger must be the interface that does all things. Yep, that's definitely one of the candidates for a solution. Sent from my iPhone On 2016/02/16, at 9:43, Gary Gregory wrote: Which is on

Re: New traceEntry code

2016-02-09 Thread Paul Benedict
es or doesn’t want. I could > envision using a proxy for this that should perform fairly well. I believe > It could inject method names and line numbers where appropriate, saving the > overhead of walking the stack. > > Ralph > > On Feb 9, 2016, at 9:07 AM, Paul Benedict wrot

Re: New traceEntry code

2016-02-09 Thread Paul Benedict
@Log(format=“json”) Request request) { > // do something > } > } > > I could imagine that this could be made to be even more flexible. > > Ralph > > > > On Feb 8, 2016, at 2:39 PM, Gary Gregory wrote: > > On Mon, Feb 8, 2016 at 12:30 PM, Paul Benedict > wr

Re: New traceEntry code

2016-02-08 Thread Paul Benedict
rpose. Gary, if you can proxy your object and encapsulate your method entry/exit code, that would be ideal. Cheers, Paul On Mon, Feb 8, 2016 at 2:26 PM, Gary Gregory wrote: > On Mon, Feb 8, 2016 at 12:22 PM, Paul Benedict > wrote: > >> Gary, anything you want tied to a thread can

Re: New traceEntry code

2016-02-08 Thread Paul Benedict
. Cheers, Paul On Mon, Feb 8, 2016 at 2:19 PM, Gary Gregory wrote: > On Mon, Feb 8, 2016 at 12:09 PM, Paul Benedict > wrote: > >> Since tracing is orthogonal to speed, >> > > Sure, but we should strive to avoid sub-optimal design choices. Tracing > will be slower a

Re: New traceEntry code

2016-02-08 Thread Paul Benedict
Since tracing is orthogonal to speed, I think logging method entry/exit points should be done in a stack push/pop fashion. Rather than have traceEntry() return the string, the logger should keep track of the entry so it can pop it. Otherwise, there isn't much use at all, I think, to what's being pr

Re: Apache Struts now uses Log4j 2

2016-01-27 Thread Paul Benedict
Gary, maybe someone will make a Log4JCXX2 :-) Cheers, Paul On Wed, Jan 27, 2016 at 12:39 PM, Gary Gregory wrote: > Except that MS is now porting it to C++ it seems (for the edu version) > > Gary > > On Wed, Jan 27, 2016 at 10:37 AM, Matt Sicker wrote: > >> Sweet! I recently discovered that Min

Re: List vs. Set

2016-01-11 Thread Paul Benedict
Thu can only use Set if you have a notion of equality and comparison. Do you for this collection? On Jan 11, 2016 9:48 PM, "Gary Gregory" wrote: > Well, not really, I'd like to express whether the collection allows for > duplicates or not, if not, use a set. > > Gary > > On Mon, Jan 11, 2016 at 7

Re: Any interest in a fat jar?

2015-12-10 Thread Paul Benedict
ite a POM to >> be used from Ant... >> >> Gary >> >> On Thu, Dec 10, 2015 at 11:17 AM, Gary Gregory >> wrote: >> >>> The whole point here is to provide a jar... >>> >>> Gary >>> >>> On Thu, Dec 10, 2015 at 10:40 A

Re: Any interest in a fat jar?

2015-12-10 Thread Paul Benedict
You can also achieve the same thing by creating a "fat POM" that lists all the dependencies (or the ones you're interested in). My point is you don't have to build another jar; you can achieve this by building another POM. Cheers, Paul On Thu, Dec 10, 2015 at 12:38 PM, Gary Gregory wrote: > To

Re: unsubscribe

2015-12-09 Thread Paul Benedict
To unsubscribe, please see this page: https://logging.apache.org/log4j/2.0/mail-lists.html Cheers, Paul On Wed, Dec 9, 2015 at 9:23 AM, Francis Lalonde wrote: > >

[jira] [Commented] (LOG4J2-435) Feature request: auto-delete older log files

2015-12-03 Thread Paul Benedict (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038613#comment-15038613 ] Paul Benedict commented on LOG4J2-435: -- JUEL is just a type of script: h

[jira] [Commented] (LOG4J2-435) Feature request: auto-delete older log files

2015-12-03 Thread Paul Benedict (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038607#comment-15038607 ] Paul Benedict commented on LOG4J2-435: -- Would you be willing to consider making

[jira] [Commented] (LOG4J2-435) Feature request: auto-delete older log files

2015-12-03 Thread Paul Benedict (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038030#comment-15038030 ] Paul Benedict commented on LOG4J2-435: -- [~mikaelstaldal] I amended my post to

[jira] [Comment Edited] (LOG4J2-435) Feature request: auto-delete older log files

2015-12-03 Thread Paul Benedict (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037914#comment-15037914 ] Paul Benedict edited comment on LOG4J2-435 at 12/3/15 3:3

[jira] [Commented] (LOG4J2-435) Feature request: auto-delete older log files

2015-12-03 Thread Paul Benedict (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037914#comment-15037914 ] Paul Benedict commented on LOG4J2-435: -- It's a very interesting id

[jira] [Commented] (LOG4J2-435) Feature request: auto-delete older log files

2015-12-02 Thread Paul Benedict (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036147#comment-15036147 ] Paul Benedict commented on LOG4J2-435: -- For clarity, could you kindly pos

[jira] [Commented] (LOG4J2-435) Feature request: auto-delete older log files

2015-12-02 Thread Paul Benedict (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036083#comment-15036083 ] Paul Benedict commented on LOG4J2-435: -- I strongly disagree XML logic tags sh

[jira] [Comment Edited] (LOG4J2-435) Feature request: auto-delete older log files

2015-12-02 Thread Paul Benedict (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036051#comment-15036051 ] Paul Benedict edited comment on LOG4J2-435 at 12/2/15 4:1

[jira] [Commented] (LOG4J2-435) Feature request: auto-delete older log files

2015-12-02 Thread Paul Benedict (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036051#comment-15036051 ] Paul Benedict commented on LOG4J2-435: -- I advise not to construct boolean logic

Re: Builder class naming consistency

2015-11-30 Thread Paul Benedict
ink that you are using a builder and you cannot just do > set/auto-complete. In addition, when foo is a verb, it's misleading, since > the call does not perform anything but merely sets a value. > > Gary > > On Mon, Nov 30, 2015 at 11:49 AM, Paul Benedict > wrote: >

Re: Builder class naming consistency

2015-11-30 Thread Paul Benedict
I actually had an interesting discussion lately with builders; so this topic interests me. Since builders are inherently mutable (and they should be right? it's a process of constructing an object), it's okay to use "set" methods. For example, see Spring's BeanDefinitionBuilder [1]. But you don't h

Re: Commit stats

2015-11-23 Thread Paul Benedict
Ralph, it says "rgoers" did 809 commits. Is that still too low? Cheers, Paul On Mon, Nov 23, 2015 at 12:45 AM, Ralph Goers wrote: > I am looking at > https://github.com/apache/logging-log4j2/graphs/contributors?from=2010-05-09&to=2015-11-22&type=c. > Can someone explain to me why it thinks I h

Re: [ANNOUNCEMENT] Welcome Ralph Goers as the new Apache Logging Chair

2015-11-20 Thread Paul Benedict
Congrats Ralph!!! Cheers, Paul On Fri, Nov 20, 2015 at 9:36 AM, Matt Sicker wrote: > Welcome, Ralph! > > On 20 November 2015 at 09:33, Christian Grobmeier > wrote: > >> Hello all, >> >> I was the chair of the Apache Logging Services project for 3 1/2 years. >> Thank you, it was a great time.

[jira] [Commented] (LOG4J2-435) Feature request: auto-delete older log files

2015-11-16 Thread Paul Benedict (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006766#comment-15006766 ] Paul Benedict commented on LOG4J2-435: -- FWIW, if you are in a Linux/Unix environ

Re: Out of date team list

2015-11-12 Thread Paul Benedict
That's all generated content. I believe you use this to manage it: http://people.apache.org/foaf/index.html Cheers, Paul On Thu, Nov 12, 2015 at 2:00 PM, Matt Sicker wrote: > Not even sure where you update that. > > On 12 November 2015 at 13:45, Gary Gregory wrote: > >> This contains the curr

Re: Get a new issues mailing list?

2015-10-21 Thread Paul Benedict
although I don’t for Log4j for some reason. To be honest I don’t know which > have a separate Jira email or not as I use a filter to route it to the > appropriate mailbox (or delete it if I really don’t care). As such I > really don’t care either way. > > Ralph > > On Oct 21,

Re: Get a new issues mailing list?

2015-10-21 Thread Paul Benedict
ficial here too. Cheers, Paul On Wed, Oct 21, 2015 at 11:41 AM, Gary Gregory wrote: > The fewer lists the better IMO. That's what email client rules/filters are > for, no? > > Gary > > On Wed, Oct 21, 2015 at 8:26 AM, Paul Benedict > wrote: > >> Committers, >> &

Get a new issues mailing list?

2015-10-21 Thread Paul Benedict
Committers, I like subscribing to different mailing lists for JIRA notifications vs. development discussions. Most Apache lists have an "issues" list dedicated to ticket updates. That's not the case for LOG4J so it can get quite noisy when JIRA heats up. What are your thoughts? Do you think we sh

Re: Re[2]: [VOTE][RESULT] Log4j 2.4.1 rc1

2015-10-14 Thread Paul Benedict
Lord Mayton, to remove yourself from the mailing list is a self-service function. You can do that with the link below. Make sure you send from the email address you subscribed from. https://logging.apache.org/log4j/2.0/mail-lists.html Cheers, Paul On Wed, Oct 14, 2015 at 10:31 AM, Lord Mayton

Re: [jira] [Comment Edited] (LOG4J2-599) Support lambda functions (or similar) for log message parameters

2015-08-07 Thread Paul Benedict
With Java 8 you can add default methods. It won't hurt any implementations as long as you provide a default implementation in Logger's interface. Cheers, Paul On Fri, Aug 7, 2015 at 12:58 PM, Gary Gregory (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/LOG4J2-599?page=com.atlas

JEP for efficient stack walking

2015-08-04 Thread Paul Benedict
http://openjdk.java.net/jeps/259 Cheers, Paul

[jira] [Commented] (LOG4J2-891) AbstractLifecycle should not implement equals() and hashCode()

2014-11-04 Thread Paul Benedict (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196895#comment-14196895 ] Paul Benedict commented on LOG4J2-891: -- The question of implementing equals(

Re: Logger and small message arguments

2014-11-04 Thread Paul Benedict
Sounds like something for me to hack at =o) Thanks for the tip. Cheers, Paul On Mon, Nov 3, 2014 at 11:07 PM, Ralph Goers wrote: > You will see TODOs in the Logger class that mention doing exactly that. > > Patches are welcome! > > Ralph > > > On Nov 3, 2014, at 9:03

Logger and small message arguments

2014-11-03 Thread Paul Benedict
One thing I want out of log4j2 is the ability to do pass small-in-number message parameters without paying the expense of constructing an object array. I was a bit surprised not to see trace/debug/info/warn/fatal methods that would accept 1, 2, and 3 message parameters. I think only after there are

Re: Fwd: No for each loop comment?

2014-09-29 Thread Paul Benedict
n, Sep 29, 2014 at 11:21 AM, Andrew Haley wrote: > >> On 09/29/2014 03:29 PM, Paul Benedict wrote: >> > Open JDKers, I am forwarding an email to get some clarification. It's >> been >> > a common understanding that foreach should perform no differently t

Fwd: No for each loop comment?

2014-09-29 Thread Paul Benedict
Open JDKers, I am forwarding an email to get some clarification. It's been a common understanding that foreach should perform no differently than the equivalent for-loop . However, some fellow developers claim there is a noticable difference in their microbenchmarking. Can you help explain what is

Re: No for each loop comment?

2014-09-26 Thread Paul Benedict
14 27.815 ns/op >>>> o.a.l.l.p.j.LoopsBenchmark.intArray10ForEachLoop sample 130826 >>>> 1980.301 30.818 ns/op >>>> o.a.l.l.p.j.LoopsBenchmark.intArray10ForLoop sample 132654 >>>> 1589.1208.449 ns/op >&

Re: No for each loop comment?

2014-09-25 Thread Paul Benedict
: > You can think that, but the testing in the testing I did at the time the > difference was quite noticeable. I would have left it as a foreach if it > wasn’t. > > Ralph > > On Sep 25, 2014, at 8:51 AM, Paul Benedict wrote: > > I would be surprised if foreach over an arr

Re: No for each loop comment?

2014-09-25 Thread Paul Benedict
I would be surprised if foreach over an array makes a speed difference. AFAIK, foreach is synatic sugar. There is no iterator for an array so it has to be desugared using a for/index loop like you have there. I don't think this code is saving anything. Cheers, Paul On Thu, Sep 25, 2014 at 10:47

Re: On serializability

2014-08-25 Thread Paul Benedict
I wouldn't even care about a stable format. I'd take an all or nothing approach to caches. Either you can correctly read out the objects, or throw away your storage upon error and rebuild from scratch. Cheers, Paul On Mon, Aug 25, 2014 at 2:45 PM, Gary Gregory wrote: > Right now I'm intereste

Re: [VOTE] Switch Log4j2 to Git

2014-08-05 Thread Paul Benedict
FYI, I've seen every other Apache project make their SVN location read-only after moving to GIT. Cheers, Paul On Tue, Aug 5, 2014 at 10:18 AM, Gary Gregory wrote: > If we switch to Git, we should make SVN read-only to avoid any confusion. > > Gary > > > On Tue, Aug 5, 2014 at 11:08 AM, Remko

Re: 2.0.1 and Android

2014-07-25 Thread Paul Benedict
I noticed you guys are not taking advantage of JIRA labels to informally categorize tickets. Go create an "android" label so you guys can track which issues belong to that ecosystem. On Jul 25, 2014 8:06 PM, "Gary Gregory" wrote: > It's not clear to me if we've cleared up all of the Android issue

Re: CamelCase wrap up

2014-06-17 Thread Paul Benedict
You might be running an older version of Eclipse or Windows 7? I used to have that problem in older versions: it doesn't understand the change of case. But you can accomplish it by renaming it to something totally different and then to the name you want. NoSQL --> YesSQL --> NoSql. Cheers, Paul

Re: debug output

2014-06-16 Thread Paul Benedict
I vote for setFoo() Cheers, Paul On Mon, Jun 16, 2014 at 10:16 AM, Matt Sicker wrote: > On 16 June 2014 10:11, Gary Gregory wrote: > >> Curious: how long do you think it would take you to convert all plugins? >> > > Longer than I'd like to wait for 2.0 to be released, but in the grand > sche

Re: debug output

2014-06-16 Thread Paul Benedict
ly >> invoked dynamically so you wouldn’t be looking at the code that calls them. >> They are primarily called in the open in unit tests. >> >> Ralph >> >> On Jun 16, 2014, at 6:49 AM, Paul Benedict wrote: >> >> I don't know why the Spring

Re: debug output

2014-06-16 Thread Paul Benedict
>> I believe I've demonstrated several ways in which such JUnit test code >>>> can be improved. >>>> Are you okay with removing the builders and reverting back to the >>>> factory methods? >>>> >>>> >>>> >>

Re: debug output

2014-06-16 Thread Paul Benedict
ch JUnit test code >>> can be improved. >>> Are you okay with removing the builders and reverting back to the >>> factory methods? >>> >>> >>> >>> On Mon, Jun 16, 2014 at 10:23 PM, Matt Sicker wrote: >>> >>>> I&#x

Re: debug output

2014-06-16 Thread Paul Benedict
> builder pattern), that would be less tightly coupled. >> >> Wouldn't it also make sense for the factory methods to be private or >> similar? That way they're only accessible through reflection. >> >> >> On Sunday, 15 June 2014, Paul Benedict wrote

Re: debug output

2014-06-15 Thread Paul Benedict
You don't want factory methods that take umpteen arguments. That's no way to make your builder extensible for future enhancements. Instead, you want a builder object that has a fluent API. http://docs.spring.io/spring/docs/3.2.8.RELEASE/javadoc-api/org/springframework/beans/factory/support/BeanDef

Re: Working on support for the properties file format.

2014-06-09 Thread Paul Benedict
t I use my 1.2 .properties file > with 2.0. Even if we do not support 1.2 files, we need to document how to > port I would think. > > Gary > > > On Mon, Jun 9, 2014 at 9:46 AM, Paul Benedict > wrote: > >> I remember a ticket (dunno which one) being closed out as &quo

Re: Working on support for the properties file format.

2014-06-09 Thread Paul Benedict
6 >> >> Damn quick fingers. >> >> >> On 8 June 2014 15:57, Matt Sicker wrote: >> >> Actually, what I'm trying to do first is convert the log4j-test1 file >> into a properties file before going anywhere with this. Basically, it'll >>

Re: Working on support for the properties file format.

2014-06-08 Thread Paul Benedict
roperties file format. However, plenty of people still do, so it seems > beneficial to allow it in some form. > > Do you mean an XSL file? > > > On 8 June 2014 14:21, Paul Benedict wrote: > >> I still think XML is a better format. But if you do allow property files, &g

Re: Working on support for the properties file format.

2014-06-08 Thread Paul Benedict
I still think XML is a better format. But if you do allow property files, consider first an XSD file that converts XML to properties. Because if you can accomplish that, you will have proven to yourself that the property file can represent everything an XML file can. On Jun 8, 2014 2:00 PM, "Matt S

Re: [VOTE Results] Log4j 2 logo

2014-06-06 Thread Paul Benedict
By nonbonding, Ralph means to say there is no secured money behind my vote. Cheers, Paul On Fri, Jun 6, 2014 at 3:10 PM, Ralph Goers wrote: > I should also add that the results below do not include Paul’s nonbonding > vote. He selected A as his top choice which would have given it the most >

Re: [VOTE] Log4j 2 logo

2014-06-03 Thread Paul Benedict
Nonbinding vote: ABGFDECHI Cheers, Paul On Tue, Jun 3, 2014 at 3:08 PM, Ralph Goers wrote: > It is time to select a logo. The list of candidates can be found at > https://wiki.apache.org/logging/Log4jLogoNominations as those having at > least two supporters and are arbitrarily identified as

Re: PluginAttribute choice

2014-06-02 Thread Paul Benedict
I go back and forth with the need to have plugin attributes be strongly typed. First, I am not a fan of it because annotations don't support multiple types well (as Ralph said) and string expressions can be pretty powerful if you want to allow script expressions (as Ralph said). That is my real opi

Re: PluginAttribute#defaultEnum()?

2014-05-30 Thread Paul Benedict
Totally cleaner. On May 30, 2014 8:58 PM, "Gary Gregory" wrote: > On Fri, May 30, 2014 at 9:39 PM, Paul Benedict > wrote: > >> I think you guys are better off doing separate annotations to do strong >> typing. You could use a stereotyping pattern like Bea

Re: PluginAttribute#defaultEnum()?

2014-05-30 Thread Paul Benedict
I think you guys are better off doing separate annotations to do strong typing. You could use a stereotyping pattern like Bean Validation spec. public @interface PluginAttribute ... Then annotate other annotations with that: @PluginAttribute public @interface IntPluginAttribute See how the Been

Re: org.apache.logging.log4j.core.config.plugins.PluginAttribute.value()

2014-05-30 Thread Paul Benedict
I don't see the added value in having defaultStringValue/defaultBooleanValue/defaultXYZValue. The complexity isn't justified, I think. Using a literal string is still much easier to comprehend; the type safety seems overkill. Cheers, Paul On Fri, May 30, 2014 at 3:25 PM, Matt Sicker wrote: >

Re: log rotation and compression questions

2014-05-28 Thread Paul Benedict
t; thanks, > David > > > On Wed, May 28, 2014 at 11:00 AM, Paul Benedict wrote: > >> I would definitely think if the file is too large, it should be rolled >> more frequently. At least with log4j 1, you could set to roll not only >> daily, but half-day, and hour

Re: log rotation and compression questions

2014-05-28 Thread Paul Benedict
I would definitely think if the file is too large, it should be rolled more frequently. At least with log4j 1, you could set to roll not only daily, but half-day, and hourly (and maybe finer). That's the ideal way to handle this. Personally, I don't like the idea of writing directly to a compressed

Re: SensitivePluginAttribute vs. PluginAttribute

2014-05-27 Thread Paul Benedict
I think "masked" implies printing where as "sensitive" is more abstract. If this attribute is only for printing, then "masked" makes sense. Cheers, Paul On Tue, May 27, 2014 at 7:10 PM, Remko Popma wrote: > Is this for passwords? If so, then how about "masked" for the attrib name? > > Sent fr

Re: [ANNOUNCEMENT] Welcome Bruce Brouwer

2014-05-22 Thread Paul Benedict
Bruce, congratulations! Welcome to the community. Cheers, Paul On Thu, May 22, 2014 at 12:01 PM, Remko Popma wrote: > Hi, > > it is my pleasure to announce to the community > that Bruce Brouwer has joined our ranks. > > He made remarkable contributions to log4j 2 > and we all believe he is a

Re: Scheduler

2014-05-21 Thread Paul Benedict
> I definitely don’t want to be dependent on JEE for a timer service. >> >> Ralph >> >> >> On May 21, 2014, at 9:40 AM, Paul Benedict wrote: >> >> You may want to provide a standard Java EE solution using the Timer >> service: >> http://docs.orac

Re: Scheduler

2014-05-21 Thread Paul Benedict
You may want to provide a standard Java EE solution using the Timer service: http://docs.oracle.com/javaee/6/tutorial/doc/bnboy.html Cheers, Paul On Wed, May 21, 2014 at 11:33 AM, Gary Gregory wrote: > We embed Quartz at work for scheduling. Instead of inventing our own, > perhaps we could mak

Re: Unified JVM Logging project at OpenJDK

2014-05-21 Thread Paul Benedict
>> just fix JUL to be a useful logging system and then use it. >> >> Ralph >> >> On May 20, 2014, at 12:24 PM, Paul Benedict wrote: >> >> http://openjdk.java.net/jeps/158 >> >> Cheers, >> Paul >> >> >> > > > -- > Matt Sicker >

  1   2   3   >