Angus Leeming [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
| Put it in please.
| Maintrunk first and then merge the revision to the branch.
|
| Now I know I should go and read the subversion docs, but is this merge to the
| branch actually:
|
| cd head
|
Georg Baum wrote:
However, this issue happens with or without the patch, so the patch
basically works for what it is advertised.
So it is not related to the patch.
It would have been very unlikely that it is, because we're in math. However, I
suppose that LFUN_MATH_MODE in
Martin Vermeer wrote:
Actually a simple fix that comes to my mind is to simply strip out all
internal dollar signs before trying to parse the string.
Something even simpler would be to do the mutate call only if there are no
dollar signs, but I am not sure whether we should do anything here at
Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
svn merge -r prev:rev svn+ssh://svn.lyx.org/lyx/lyx-devel/trunk .
In reality it won't give much more than what diff + patch does, but in
the (near) future subversion will get real merge tracking. Then it
gets really important.
Thanks, Lars.
On Fri, 2006-03-03 at 11:05 +0100, Georg Baum wrote:
Martin Vermeer wrote:
Actually a simple fix that comes to my mind is to simply strip out all
internal dollar signs before trying to parse the string.
Something even simpler would be to do the mutate call only if there are no
dollar
Martin Vermeer wrote:
Something even simpler would be to do the mutate call only if there are
no dollar signs,
That will still pass through non-latexable stuff.
Yes. But if we want to prevent that we have to disable C-M with a selection
completely (and also unknown commands in mathed).
Georg == Georg Baum [EMAIL PROTECTED] writes:
Georg Martin Vermeer wrote:
Actually a simple fix that comes to my mind is to simply strip out
all internal dollar signs before trying to parse the string.
Georg Something even simpler would be to do the mutate call only if
Georg there are no
Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
| > Put it in please.
| > Maintrunk first and then merge the revision to the branch.
|
| Now I know I should go and read the subversion docs, but is this "merge to the
| branch" actually:
|
| cd
Georg Baum wrote:
> > However, this issue happens with or without the patch, so the patch
> > basically works for what it is advertised.
>
> So it is not related to the patch.
It would have been very unlikely that it is, because we're in math. However, I
suppose that LFUN_MATH_MODE in
Martin Vermeer wrote:
> Actually a simple fix that comes to my mind is to simply strip out all
> internal dollar signs before trying to parse the string.
Something even simpler would be to do the mutate call only if there are no
dollar signs, but I am not sure whether we should do anything here
Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
> svn merge -r : svn+ssh://svn.lyx.org/lyx/lyx-devel/trunk .
> In reality it won't give much more than what diff + patch does, but in
> the (near) future subversion will get real merge tracking. Then it
> gets really important.
Thanks, Lars.
On Fri, 2006-03-03 at 11:05 +0100, Georg Baum wrote:
> Martin Vermeer wrote:
>
> > Actually a simple fix that comes to my mind is to simply strip out all
> > internal dollar signs before trying to parse the string.
>
> Something even simpler would be to do the mutate call only if there are no
>
Martin Vermeer wrote:
>> Something even simpler would be to do the mutate call only if there are
>> no dollar signs,
>
> That will still pass through non-latexable stuff.
Yes. But if we want to prevent that we have to disable C-M with a selection
completely (and also unknown commands in
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> Martin Vermeer wrote:
>> Actually a simple fix that comes to my mind is to simply strip out
>> all internal dollar signs before trying to parse the string.
Georg> Something even simpler would be to do the mutate call only if
Georg>
Lars Gullik Bjønnes wrote:
This is still not resolved as fixed in bugzilla, shouldn't it be?
No, since the fix is not applied (2315 is not about the mathbb problem, but
about converting stuff to math by C-M). I had no time to test the fix
thoroughly, the current state is that Jürgen tested
Georg Baum [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
|
|
| This is still not resolved as fixed in bugzilla, shouldn't it be?
|
| No, since the fix is not applied (2315 is not about the mathbb problem, but
| about converting stuff to math by C-M). I had no time to test the fix
|
Lars Gullik Bjønnes wrote:
Then someone have to test it promptly or this will not be in 1.4.0.
OK, here is an updated patch for testing (nothing had changed, I only moved
the ChangeLog entry). Any takers?
GeorgIndex: src/ChangeLog
Georg Baum [EMAIL PROTECTED] writes:
Lars Gullik Bjønnes wrote:
Then someone have to test it promptly or this will not be in 1.4.0.
OK, here is an updated patch for testing (nothing had changed, I only moved
the ChangeLog entry). Any takers?
With this patch the behavior is as in 1.3.7,
Lars Gullik Bjønnes wrote:
Then someone have to test it promptly or this will not be in 1.4.0.
Actually I think that John set the 1.4.0 target because at that time we
thought that math-insert was broken in general. Fortunately thsi has now
been resolved.
For me it is not too important to have
Enrico Forestieri wrote:
With this patch the behavior is as in 1.3.7, including that when selecting
a math inset and pasting it outside of LyX, the delimiters are still left
out.
Given that, I don't know why this patch is needed...
try this:
1. write \text{test} in text mode
2. select it
3.
Georg Baum [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
|
| Then someone have to test it promptly or this will not be in 1.4.0.
|
| Actually I think that John set the 1.4.0 target because at that time we
| thought that math-insert was broken in general. Fortunately thsi has now
|
Juergen Spitzmueller wrote:
Enrico Forestieri wrote:
With this patch the behavior is as in 1.3.7, including that when
selecting a math inset and pasting it outside of LyX, the delimiters are
still left out.
Enrico, could you file the paste outside of LyX bug in bugzilla, please (or
si it
Juergen Spitzmueller [EMAIL PROTECTED] writes:
try this:
1. write \text{test} in text mode
2. select it
3. hit C-M
you get an ampty text inset. The patch fixes that.
Yes, I was missing that. Then I would say that the patch works, even if
it is a small nuisance that now you have to
Georg Baum wrote:
Jürgen, Enrico, it would be nice if you could test this one again, so that
it can go in 1.4.0. For me it does work.
I'll test intensely now. Lars, I agree with Georg that this should be applied,
given that it proves good (and it's not too late yet).
Jürgen
Lars Gullik Bjønnes wrote:
To make thing trot along I'll move this (2315) to 1.4.1.
Please do not commit the 2315 patch.
OK. Since Jürgen has pointed out that there was a bigger problem than I
thought (sorry again for the confusion), I would really like an entry in
the release notes.
May I
Georg Baum [EMAIL PROTECTED] writes:
Enrico, could you file the paste outside of LyX bug in bugzilla, please (or
si it alreday there?)
I'll do that.
Here is a better patch (only two code lines were changed), that does allow
all these cases:
\text{test}
$\text{test}$
\[\text{test}\]
Georg Baum [EMAIL PROTECTED] writes:
| Juergen Spitzmueller wrote:
|
| Enrico Forestieri wrote:
| With this patch the behavior is as in 1.3.7, including that when
| selecting a math inset and pasting it outside of LyX, the delimiters are
| still left out.
|
| Enrico, could you file the
Juergen Spitzmueller [EMAIL PROTECTED] writes:
| Georg Baum wrote:
| Jürgen, Enrico, it would be nice if you could test this one again, so that
| it can go in 1.4.0. For me it does work.
|
| I'll test intensely now. Lars, I agree with Georg that this should be
applied,
| given that it proves
Lars Gullik Bjønnes wrote:
Please all, make up your mind about this bug. Required for 1.4.0 or
not.
I did already (required for 1.4.0)
Just testing ...
Jürgen
Georg Baum [EMAIL PROTECTED] writes:
Jürgen, Enrico, it would be nice if you could test this one again, so that
it can go in 1.4.0. For me it does work.
The new patch seems to work. However, if the selection does not include
any delimiter I get some messages on the terminal. For example,
On Thursday 02 March 2006 17:37, Enrico Forestieri wrote:
To be honest I don't know if this can be regarded as a bug, as I have
no opinions on what should have happened. Anyway, the generated latex
is incorrect.
This is not a regression either because this happened for 1.3.x as well,
IIRC.
Jose' Matos wrote:
To be honest I don't know if this can be regarded as a bug, as I have
no opinions on what should have happened. Anyway, the generated latex
is incorrect.
This is not a regression either because this happened for 1.3.x as well,
IIRC. At least for now that is the major
Georg Baum [EMAIL PROTECTED] writes:
Juergen Spitzmueller wrote:
Enrico Forestieri wrote:
With this patch the behavior is as in 1.3.7, including that when
selecting a math inset and pasting it outside of LyX, the delimiters are
still left out.
Enrico, could you file the paste
Georg Baum wrote:
Jürgen, Enrico, it would be nice if you could test this one again, so that
it can go in 1.4.0. For me it does work.
It works for me, except for the glitch Enrico reported, and the following
issue of which I'm not sure if it is related:
1. Insert formula
2. type foo
3. mark
Juergen Spitzmueller wrote:
Georg Baum wrote:
Jürgen, Enrico, it would be nice if you could test this one again, so
that it can go in 1.4.0. For me it does work.
It works for me, except for the glitch Enrico reported, and the following
issue of which I'm not sure if it is related:
1.
Georg Baum [EMAIL PROTECTED] writes:
| Juergen Spitzmueller wrote:
|
| Georg Baum wrote:
| Jürgen, Enrico, it would be nice if you could test this one again, so
| that it can go in 1.4.0. For me it does work.
|
| It works for me, except for the glitch Enrico reported, and the following
|
Am Donnerstag, 2. März 2006 20:22 schrieb Lars Gullik Bjønnes:
Put it in please.
Maintrunk first and then merge the revision to the branch.
Done. I had to look up the options of svn merge because I don't use it
that often, but it looks like it has worked.
Georg
Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
Put it in please.
Maintrunk first and then merge the revision to the branch.
Now I know I should go and read the subversion docs, but is this merge to the
branch actually:
cd head
svn diff head.diff
svn commit
cd ../14x
patch
Am Donnerstag, 2. März 2006 21:12 schrieb Angus Leeming:
Now I know I should go and read the subversion docs, but is this merge
to the
branch actually:
cd head
svn diff head.diff
svn commit
cd ../14x
patch -p0 ../head/head.diff
svn commit
(which is what I've
On Thu, Mar 02, 2006 at 08:04:33PM +0100, Georg Baum wrote:
Juergen Spitzmueller wrote:
Georg Baum wrote:
...
2) It produces invalid results for things that are not really _one_ formula,
e.g. the mentioned $a$ foo $b$.
Actually a simple fix that comes to my mind is to simply strip out
Lars Gullik Bjønnes wrote:
>
> This is still not resolved as fixed in bugzilla, shouldn't it be?
No, since the fix is not applied (2315 is not about the mathbb problem, but
about converting stuff to math by C-M). I had no time to test the fix
thoroughly, the current state is that Jürgen tested
Georg Baum <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
|
| >
| > This is still not resolved as fixed in bugzilla, shouldn't it be?
|
| No, since the fix is not applied (2315 is not about the mathbb problem, but
| about converting stuff to math by C-M). I had no time to test the
Lars Gullik Bjønnes wrote:
> Then someone have to test it promptly or this will not be in 1.4.0.
OK, here is an updated patch for testing (nothing had changed, I only moved
the ChangeLog entry). Any takers?
GeorgIndex: src/ChangeLog
Georg Baum <[EMAIL PROTECTED]> writes:
>
> Lars Gullik Bjønnes wrote:
>
> > Then someone have to test it promptly or this will not be in 1.4.0.
>
> OK, here is an updated patch for testing (nothing had changed, I only moved
> the ChangeLog entry). Any takers?
With this patch the behavior is as
Lars Gullik Bjønnes wrote:
> Then someone have to test it promptly or this will not be in 1.4.0.
Actually I think that John set the 1.4.0 target because at that time we
thought that math-insert was broken in general. Fortunately thsi has now
been resolved.
For me it is not too important to have
Enrico Forestieri wrote:
> With this patch the behavior is as in 1.3.7, including that when selecting
> a math inset and pasting it outside of LyX, the delimiters are still left
> out.
>
> Given that, I don't know why this patch is needed...
try this:
1. write \text{test} in text mode
2. select
Georg Baum <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
|
| > Then someone have to test it promptly or this will not be in 1.4.0.
|
| Actually I think that John set the 1.4.0 target because at that time we
| thought that math-insert was broken in general. Fortunately thsi has now
|
Juergen Spitzmueller wrote:
> Enrico Forestieri wrote:
>> With this patch the behavior is as in 1.3.7, including that when
>> selecting a math inset and pasting it outside of LyX, the delimiters are
>> still left out.
Enrico, could you file the paste outside of LyX bug in bugzilla, please (or
si
Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
>
> try this:
> 1. write \text{test} in text mode
> 2. select it
> 3. hit C-M
>
> you get an ampty text inset. The patch fixes that.
Yes, I was missing that. Then I would say that the patch works, even if
it is a small nuisance that now you have
Georg Baum wrote:
> Jürgen, Enrico, it would be nice if you could test this one again, so that
> it can go in 1.4.0. For me it does work.
I'll test intensely now. Lars, I agree with Georg that this should be applied,
given that it proves good (and it's not too late yet).
Jürgen
Lars Gullik Bjønnes wrote:
> To make thing trot along I'll move this (2315) to 1.4.1.
>
> Please do not commit the 2315 patch.
OK. Since Jürgen has pointed out that there was a bigger problem than I
thought (sorry again for the confusion), I would really like an entry in
the release notes.
May
Georg Baum <[EMAIL PROTECTED]> writes:
>
> Enrico, could you file the paste outside of LyX bug in bugzilla, please (or
> si it alreday there?)
I'll do that.
> Here is a better patch (only two code lines were changed), that does allow
> all these cases:
>
> \text{test}
> $\text{test}$
>
Georg Baum <[EMAIL PROTECTED]> writes:
| Juergen Spitzmueller wrote:
|
| > Enrico Forestieri wrote:
| >> With this patch the behavior is as in 1.3.7, including that when
| >> selecting a math inset and pasting it outside of LyX, the delimiters are
| >> still left out.
|
| Enrico, could you file
Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
| Georg Baum wrote:
| > Jürgen, Enrico, it would be nice if you could test this one again, so that
| > it can go in 1.4.0. For me it does work.
|
| I'll test intensely now. Lars, I agree with Georg that this should be
applied,
| given that it
Lars Gullik Bjønnes wrote:
> Please all, make up your mind about this bug. Required for 1.4.0 or
> not.
I did already (required for 1.4.0)
Just testing ...
Jürgen
Georg Baum <[EMAIL PROTECTED]> writes:
>
> Jürgen, Enrico, it would be nice if you could test this one again, so that
> it can go in 1.4.0. For me it does work.
The new patch seems to work. However, if the selection does not include
any delimiter I get some messages on the terminal. For example,
On Thursday 02 March 2006 17:37, Enrico Forestieri wrote:
> To be honest I don't know if this can be regarded as a bug, as I have
> no opinions on what should have happened. Anyway, the generated latex
> is incorrect.
This is not a regression either because this happened for 1.3.x as well,
Jose' Matos wrote:
> > To be honest I don't know if this can be regarded as a bug, as I have
> > no opinions on what should have happened. Anyway, the generated latex
> > is incorrect.
>
> This is not a regression either because this happened for 1.3.x as well,
> IIRC. At least for now that is
Georg Baum <[EMAIL PROTECTED]> writes:
>
> Juergen Spitzmueller wrote:
>
> > Enrico Forestieri wrote:
> >> With this patch the behavior is as in 1.3.7, including that when
> >> selecting a math inset and pasting it outside of LyX, the delimiters are
> >> still left out.
>
> Enrico, could you
Georg Baum wrote:
> Jürgen, Enrico, it would be nice if you could test this one again, so that
> it can go in 1.4.0. For me it does work.
It works for me, except for the glitch Enrico reported, and the following
issue of which I'm not sure if it is related:
1. Insert formula
2. type "foo"
3.
Juergen Spitzmueller wrote:
> Georg Baum wrote:
>> Jürgen, Enrico, it would be nice if you could test this one again, so
>> that it can go in 1.4.0. For me it does work.
>
> It works for me, except for the glitch Enrico reported, and the following
> issue of which I'm not sure if it is related:
Georg Baum <[EMAIL PROTECTED]> writes:
| Juergen Spitzmueller wrote:
|
| > Georg Baum wrote:
| >> Jürgen, Enrico, it would be nice if you could test this one again, so
| >> that it can go in 1.4.0. For me it does work.
| >
| > It works for me, except for the glitch Enrico reported, and the
Am Donnerstag, 2. März 2006 20:22 schrieb Lars Gullik Bjønnes:
> Put it in please.
>
> Maintrunk first and then merge the revision to the branch.
Done. I had to look up the options of svn merge because I don't use it
that often, but it looks like it has worked.
Georg
Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
> Put it in please.
> Maintrunk first and then merge the revision to the branch.
Now I know I should go and read the subversion docs, but is this "merge to the
branch" actually:
cd head
svn diff > head.diff
svn commit
cd ../14x
Am Donnerstag, 2. März 2006 21:12 schrieb Angus Leeming:
> Now I know I should go and read the subversion docs, but is this "merge
to the
> branch" actually:
>
> cd head
> svn diff > head.diff
> svn commit
> cd ../14x
> patch -p0 < ../head/head.diff
> svn commit
>
>
On Thu, Mar 02, 2006 at 08:04:33PM +0100, Georg Baum wrote:
> Juergen Spitzmueller wrote:
>
> > Georg Baum wrote:
...
> 2) It produces invalid results for things that are not really _one_ formula,
> e.g. the mentioned $a$ foo $b$.
Actually a simple fix that comes to my mind is to simply strip
This is still not resolved as fixed in bugzilla, shouldn't it be?
--
Lgb
This is still not resolved as fixed in bugzilla, shouldn't it be?
--
Lgb
68 matches
Mail list logo
