On 2008/12/01 00:28, Marc Pavot [EMAIL PROTECTED] wrote:
11 other patches available on my repository:
Add unit tests to libmpclient
No recursive makefiles, please. The patch contains 1 whitespace error.
Fix glib include
Change include guards
Convert MPD_INFO_ENTITY_
11 other patches available on my repository:
Add unit tests to libmpclient
Fix glib include
Change include guards
Convert MPD_INFO_ENTITY_ to enum
Fix currentsong test
Cosmetic
Improve calls to mpd_executeCommand
Small performance improvements
- I saw that your idle patch introduced inconsistent indentation
(e.g. mpd_glibStartIdle); please configure your editor to indent
with tabs.
I don't want to start a 'religion war' on this point but don't you think it
would be better to use spaces everywhere instead of tabs?
This discussion
On 2008/11/27 12:10, Marc Pavot [EMAIL PROTECTED] wrote:
I don't want to start a 'religion war' on this point but don't you
think it would be better to use spaces everywhere instead of tabs?
Personally, I prefer spaces, too, but let's just focus on important
technical problems. The current
Hi,
There are some commits on my repository that you may find interesting to
integrate.
Marc Pavot:
Use tabs instead of spaces
Split libmpdclient: status
Set local includes first for idle.c
Split libmpdclient: stats
Merge branch 'master' of
On 2008/11/28 00:49, Marc Pavot [EMAIL PROTECTED] wrote:
There are some commits on my repository that you may find interesting to
integrate.
Thanks, I've merged all.
New disconnect event
+ IDLE_DISCONNECT = 0x80,
This is a clumsy choice, since it will conflict with the next
- portability - even Windows? There's no good C99 compiler on
Windows.. mingw32?
Just a quick remark about this point: I compile Ario and libmpdclient on
windows with mingw32 and it works fine. (I distribute .exe files for Ario).
Some of you already promised to help me with that. From now on, I
will accept patches (git pull requests preferred). Please keep your
git repository rebased on mine.
I have created a git repository to help you on this project:
http://repo.or.cz/w/libmpdclient/marc.git
It is based on your
On 2008/11/27 00:33, Marc Pavot [EMAIL PROTECTED] wrote:
It is based on your repository and I have done one commit to continue the
split of libmpdclient.
It creates three new files: connection, idle and return_element. The
separation is not perfect (for example some structures and methods in
