Re: RFR [11] 8208391: Need to differentiate response and connect timeouts in HTTP Client API

Thanks for the updates, Chris. This looks fine to me (I'm not a reviewer). -Jaikiran On 07/08/18 3:22 PM, Chris Hegarty wrote: >> On 4 Aug 2018, at 14:08, Jaikiran Pai wrote: >> >> ... >> >> Do you think this can be reworded a bit? Although I understand what's >> being said here, the wording

Re: RFR [11] 8208391: Need to differentiate response and connect timeouts in HTTP Client API

The updated webrev looks fine to me, Chris. Thanks, Michael On 07/08/2018, 10:52, Chris Hegarty wrote: On 4 Aug 2018, at 14:08, Jaikiran Pai wrote: ... Do you think this can be reworded a bit? Although I understand what's being said here, the wording doesn't seem right. Maybe something

Re: RFR [11] 8208391: Need to differentiate response and connect timeouts in HTTP Client API

> On 4 Aug 2018, at 14:08, Jaikiran Pai wrote: > > ... > > Do you think this can be reworded a bit? Although I understand what's > being said here, the wording doesn't seem right. Maybe something like: > > * In the case where a new connection needs to be > established, if >

Re: RFR [11] 8208391: Need to differentiate response and connect timeouts in HTTP Client API

Hi Chris, src/java.net.http/share/classes/java/net/http/HttpClient.java + * In the case where a new connection needs to be established, if + * the connection cannot be established within the given {@code + * duration}, then an {@link HttpConnectTimeoutException} is

RFR [11] 8208391: Need to differentiate response and connect timeouts in HTTP Client API

Hi, This is a code review to add connection specific timeout support to the new HTTP Client, as discussed recently over on another thread [1]. The connection timeout duration is proposed to be added at the level of the client, and if specified applies to all requests sent by that client. The

JEP 110 HTTP client API

Hi, I just want to confirm the plans for the HTTP client API in JDK 9 that were hinted at previously. There is a new feature called "incubator modules" which has just been proposed for JDK 9. The idea is to accommodate new APIs in JDK which are not quite ready to be standardize

RE: HTTP client API

dules". These are modules that can be delivered with the JDK, but are not standard parts of the platform (Java SE). So, they do not resolve by default and will have runtime/compile time warnings to indicate that the contained APIs are potentially subject to change. The plan is to make this new http

Re: HTTP client API

dules". These are modules that can be delivered with the JDK, but are not standard parts of the platform (Java SE). So, they do not resolve by default and will have runtime/compile time warnings to indicate that the contained APIs are potentially subject to change. The plan is to make this new http

Re: HTTP client API

Hi Michael - Some follow-up/updates on items from my previous email inline below: On Mon, Oct 31, 2016 at 6:13 PM, Tobias Thierer wrote: > > On Fri, Oct 28, 2016 at 12:28 PM, Michael McMahon < > michael.x.mcma...@oracle.com> wrote: > >> >> The intention behind those

Re: HTTP client API

On Mon, Oct 31, 2016 at 6:13 PM, Tobias Thierer wrote: > On Fri, Oct 28, 2016 at 12:28 PM, Michael McMahon < > michael.x.mcma...@oracle.com> wrote: >> >> 2.) HttpHeaders: I love that there is a type for this abstraction! But: >> >>- >> >>Why is the type an interface

Re: HTTP client API

Hi Michael - thanks a lot for your response! Further comments below. How would you rank simplicity, versatility and performance as goals for the HTTP Client API? For example the blocking vs. non-blocking API choices will largely depend on trade-offs, so I'd like to understand the target

Re: HTTP client API

Hi Tobias Thanks for the feedback (and thanks to Anthony for answering some of the questions) My thoughts are below. On 24/10/2016, 20:33, Tobias Thierer wrote: Hi Michael and others - Thanks for publishing the latest HTTP client API docs <http://cr.openjdk.java.net/%7Emicha

Re: HTTP client API

n 24/10/2016 21:33, Tobias Thierer wrote: Hi Michael and others - Thanks for publishing the latest HTTP client API docs <http://cr.openjdk.java.net/%7Emichaelm/httpclient/api/>(already slightly outdated again), as well as for publishing the current draft code in the sandbox repository!

Re: HTTP client API

On 22/09/16 08:54, Chris Hegarty wrote: On 22 Sep 2016, at 00:14, Michael McMahon wrote: Martin The source is available in the JDK 9 sandbox (http-client-branch) at http://hg.openjdk.java.net/jdk9/sandbox/ I think it has been updated to reflect the API as

Re: HTTP client API

On 22 Sep 2016, at 00:14, Michael McMahon wrote: > > Martin > > The source is available in the JDK 9 sandbox (http-client-branch) at > http://hg.openjdk.java.net/jdk9/sandbox/ > > I think it has been updated to reflect the API as described below. Apologies, it

Re: HTTP client API

Martin The source is available in the JDK 9 sandbox (http-client-branch) at http://hg.openjdk.java.net/jdk9/sandbox/ I think it has been updated to reflect the API as described below. Michael. On 21/09/2016, 14:14, Martin Buchholz wrote: On Wed, Sep 7, 2016 at 10:15 AM, Michael McMahon

Re: HTTP client API

On Wed, Sep 7, 2016 at 10:15 AM, Michael McMahon < michael.x.mcma...@oracle.com> wrote: > > [1] http://cr.openjdk.java.net/~michaelm/httpclient/api.1/ > > [2] http://cr.openjdk.java.net/~michaelm/httpclient/ > specdiffout.1/package-summary.html > Could we have actual source code for

Re: HTTP client API

flow-control is very hard to get right). Attached is a feedback doc on this new version. One specific idea to discuss is whether it's possible to release the new HTTP client API as a standalone library (that works on JDK 9). Thanks, Wenbo On Mon, Aug 22, 2016 at 12:56 AM, Michael McMahon

Re: HTTP client API

6/08/2016, 07:59, Wenbo Zhu wrote: Hi Michael, Thanks for the update! The adoption of the Flow API is indeed a big improvement (async flow-control is very hard to get right). Attached is a feedback doc on this new version. One specific idea to discuss is whether it's possible to release the new HTTP c

Re: HTTP client API

t right). Attached is a feedback doc on this new version. One specific idea to discuss is whether it's possible to release the new HTTP client API as a standalone library (that works on JDK 9). Thanks, Wenbo On Mon, Aug 22, 2016 at 12:56 AM, Michael McMahon <michael.x.mcma...@oracle.com

Re: HTTP client API

Martin, Wenbo, We are considering the feedback, will take it under advisement, and reply in due course. -Chris. > On 26 Aug 2016, at 22:14, Martin Buchholz wrote: > > I don't know much about http, but I believe those who say that it's very hard > to get the API right.

Re: HTTP client API

I don't know much about http, but I believe those who say that it's very hard to get the API right. Perhaps it would be best to deliver a http client library as an independent beta package for use with jdk 8+ with a final version becoming part of jdk 10? Perhaps there can be a productive

Re: HTTP client API

http://cr.openjdk.java.net/~chegar/docs/sandbox.html > On 23 Aug 2016, at 21:20, Martin Buchholz wrote: > > I tried this: > > (Install mercurial trees extension.) > hg tclone http://hg.openjdk.java.net/jdk9/sandbox jdk9-sandbox > hg tupdate -r http-client-branch > > Is

Re: HTTP client API

On Tue, Aug 23, 2016 at 12:57 PM, Wenbo Zhu wrote: > >> We are currently working in the sandbox repository again and will have >> these changes >> in the main JDK9 dev forest soon. >> > Is it possible to access the API code somewhere before then, mainly as a > convenience for

Re: HTTP client API

On Mon, Aug 22, 2016 at 12:56 AM, Michael McMahon < michael.x.mcma...@oracle.com> wrote: > There is an updated version of the HTTP client API doc [1] and a specdiff > [2] showing the changes > proposed from the current version in JDK9 dev. > > The main changes are: > >

HTTP client API

There is an updated version of the HTTP client API doc [1] and a specdiff [2] showing the changes proposed from the current version in JDK9 dev. The main changes are: 1) The request and response processors are now based on Flow.Publisher and Flow.Subscriber 2) Response bodies are retrieved

revision 0.4 Http client API

Hello, I have just posted the javadoc for v 0.4 of the Http client API [1] This draft takes into account almost all of the feedback from the last round of reviews. There are a small number of issues still outstanding however. For those who are not aware, the development work done so far has

Re: Review of new Http client API

) We have just published a draft of a proposed new Http client API [1] for JDK 8. This message has been cc'd to jdk8-dev so that as many people as possible know about it, but the discussion will be on the net-dev list (net-dev@openjdk.java.net). So, folks will have to join that list [2], in order

Re: Review of new Http client API

is failing me on how to improve on such matters. Perhaps something better may come out of fluent-based API? Paul. On Aug 14, 2012, at 2:01 PM, Michael McMahon michael.x.mcma...@oracle.com wrote: Hi, (apologies for sending this again) We have just published a draft of a proposed new Http client API

Re: Review of new Http client API

of a proposed new Http client API [1] for JDK 8. This message has been cc'd to jdk8-dev so that as many people as possible know about it, but the discussion will be on the net-dev list (net-dev@openjdk.java.net). So, folks will have to join that list [2], in order to take part. Thanks, Michael. [1

Re: Review of new Http client API

for sending this again) We have just published a draft of a proposed new Http client API [1] for JDK 8. This message has been cc'd to jdk8-dev so that as many people as possible know about it, but the discussion will be on the net-dev list (net-dev@openjdk.java.net). So, folks will have to join

Re: Review of new Http client API

On Aug 23, 2012, at 5:05 PM, Chris Hegarty chris.hega...@oracle.com wrote: Paul, All good feedback, and I will leave it to Michael to reply to the specifics. On thought I had on separation of modes is something list this: interface HeaderHandler { onHeaders(HttpResponse); }

Re: Review of new Http client API

for sending this again) We have just published a draft of a proposed new Http client API [1] for JDK 8. This message has been cc'd to jdk8-dev so that as many people as possible know about it, but the discussion will be on the net-dev list (net-dev@openjdk.java.net). So, folks will have

Re: Review of new Http client API

McMahon michael.x.mcma...@oracle.com wrote: Hi, (apologies for sending this again) We have just published a draft of a proposed new Http client API [1] for JDK 8. This message has been cc'd to jdk8-dev so that as many people as possible know about it, but the discussion will be on the net-dev list

Re: Review of new Http client API

? Thanks Michael. Sam On Tue, Aug 14, 2012 at 5:01 AM, Michael McMahon michael.x.mcma...@oracle.com wrote: Hi, (apologies for sending this again) We have just published a draft of a proposed new Http client API [1] for JDK 8. This message has been cc'd to jdk8-dev so that as many people as possible

Re: Review of new Http client API

new Http client API [1] for JDK 8. This message has been cc'd to jdk8-dev so that as many people as possible know about it, but the discussion will be on the net-dev list (net-dev@openjdk.java.net). So, folks will have to join that list [2], in order to take part. Thanks, Michael. [1]http

Re: Review of new Http client API

michael.x.mcma...@oracle.com wrote: Hi, (apologies for sending this again) We have just published a draft of a proposed new Http client API [1] for JDK 8. This message has been cc'd to jdk8-dev so that as many people as possible know about it, but the discussion will be on the net-dev list (net-dev

Re: Http client API

On 17.08.2012 14:30, Michael McMahon wrote: On 09/08/12 19:15, Chris Hegarty wrote: Michael, Looking good, some comments. 1) Why the use of CookieManager, rather than CookieHandler? I would expect that CookieHandler would be a cleaner API CookieHandler is a very low level API, which

Re: Http client API

until the 100 continue is received, before being allowed to send the body. An asynchronous application will just not be called back to get the body until the 100 is received. Thanks Michael -Chris. On 08/08/12 00:09, Michael McMahon wrote: Hi, A new revision of the Http client API planned for jdk

Re: Http client API

On 17 August 2012 11:30, Michael McMahon michael.x.mcma...@oracle.com wrote: 2) What is the impact on the sendHeader, setBody for HEAD requests? Ah yes, HEAD needs special treatment - though not with respect to the methods above as HEAD is identical to GET except with respect to any returned

Re: Http client API

On 17/08/12 11:59, Frank Carver wrote: On 17 August 2012 11:30, Michael McMahonmichael.x.mcma...@oracle.com wrote: 2) What is the impact on the sendHeader, setBody for HEAD requests? Ah yes, HEAD needs special treatment - though not with respect to the methods above as HEAD is identical to

Re: Http client API

extend. - getCache() to return the client provider. On Aug 7 2012, at 16:09 , Michael McMahon wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api

Re: Use Builder pattern ( was: Re: Http client API)

On 09/08/12 10:50, Chris Hegarty wrote: On 09/08/12 00:00, Jed Wesley-Smith wrote: Michael McMahon michael.x.mcmahon@... writes: A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like

Re: Http client API

- HttpClient createClient() -- is this the same as HttpClientProvider.provider().createAsynchronousHttpClient()? yes, and that needs to be documented. Just on this one, the method name createAsynchronousHttpClient() looks like a remnant of our previous API iterations, and I think this should

Re: Http client API

client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list. So, all comments are welcome. Thanks Michael McMahon.

Re: Http client API

On 09/08/12 01:49, David M. Lloyd wrote: On 08/07/2012 06:09 PM, Michael McMahon wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list

Re: Http client API

On Aug 15 2012, at 09:06 , Michael McMahon wrote: HttpClientProvider:: - HttpClientProvider JavaDoc uses inconsistent capitalization of HTTP. - createAsynchronousHttpClient() Since there's only one create method why bother to mention that it's Asynchronous? - It's not clear how

Review of new Http client API

Hi, (apologies for sending this again) We have just published a draft of a proposed new Http client API [1] for JDK 8. This message has been cc'd to jdk8-dev so that as many people as possible know about it, but the discussion will be on the net-dev list (net-dev@openjdk.java.net). So

Re: cross protocol redirects ( was:Re: Http client API )

On 08/08/12 21:35, Chris Hegarty wrote: Great suggestion Anthony, This is something that comes up from time to time. With the clear distinction between java.net.HttpURLConnection and javax.net.ssl.HttpsURLConnection API's then it was a little difficult to do in the existing API, but there is

Re: Http client API

. Thanks, Xuelei On 8/8/2012 7:09 AM, Michael McMahon wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list. So, all comments

Re: Http client API

. Thanks again, Michael. On 08/08/12 00:09, Michael McMahon wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list. So, all comments are welcome

Review of new Http client API

Hi, We have just published a draft of a proposed new Http client API [1] for JDK 8. This message has been bcc'd to jdk8-dev so that as many people as possible know about it, but the discussion will be on the net-dev list (net-dev@openjdk.java.net). So, folks will have to join that list [2

Re: Http client API

On 09/08/2012 01:49, David M. Lloyd wrote: On 08/07/2012 06:09 PM, Michael McMahon wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list

Use Builder pattern ( was: Re: Http client API)

On 09/08/12 00:00, Jed Wesley-Smith wrote: Michael McMahon michael.x.mcmahon@... writes: A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list. So

Re: Http client API

mailto:michael.x.mcma...@oracle.com wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ http://cr.openjdk.java.net/~__michaelm/httpclient/v0.3

Re: Http client API

rather than an iterable? HttpConnectionCache.CachedConnection:: - I would expect this to be abstract and that client providers would extend. - getCache() to return the client provider. On Aug 7 2012, at 16:09 , Michael McMahon wrote: Hi, A new revision of the Http client API planned for jdk 8

Re: Http client API

/proxy/etc 10) Missing fluent style return from HttpRequest.setRequestBodyLimit 11) Should sendHeaders be specified to allow a null return value. I'm thinking about when setSendExpectContinue is set. -Chris. On 08/08/12 00:09, Michael McMahon wrote: Hi, A new revision of the Http client

Re: Http client API

Is it possible to have methods like public abstract HTMLDocument getResponse(String request) in class HttpClient ? On Wed, Aug 8, 2012 at 7:09 AM, Michael McMahon michael.x.mcma...@oracle.com wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed

Re: Http client API

the point of your proposal? Maybe others have a different view... -Chris. On Wed, Aug 8, 2012 at 7:09 AM, Michael McMahon michael.x.mcma...@oracle.com mailto:michael.x.mcma...@oracle.com wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed

Re: Http client API

On 08/08/2012 07:25, Sean Chou wrote: Is it possible to have methods like public abstract HTMLDocument getResponse(String request) in class HttpClient ? I see Chris has replied to this. One other point is that we also need to consider JDK modularization and I don't think we should have

Re: Http client API

, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list. So, all comments are welcome. Thanks Michael McMahon.

Re: Http client API

Instead of HttpRequest having void setBody(IterableByteBuffer buffers, boolean isRestartable) what about having two methods: void setBody(IterableByteBuffer buffers) // presumed restartable void setBody(IteratorByteBuffer buffers) // clearly not restartable Not only does this avoid a

Re: Http client API

? HttpConnectionCache.CachedConnection:: - I would expect this to be abstract and that client providers would extend. - getCache() to return the client provider. On Aug 7 2012, at 16:09 , Michael McMahon wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http

Re: Http client API

Michael McMahon michael.x.mcmahon@... writes: A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list. So, all comments are welcome. Can you

Re: Http client API

... -Chris. On Wed, Aug 8, 2012 at 7:09 AM, Michael McMahon michael.x.mcma...@oracle.com mailto:michael.x.mcmahon@**oracle.commichael.x.mcma...@oracle.com wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http

Http client API

Hi, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list. So, all comments are welcome. Thanks Michael McMahon.