On 8/6/05, Harald Welte <[EMAIL PROTECTED]> wrote:
> On Sat, Aug 06, 2005 at 11:26:14AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Sat, Aug 06, 2005 at 06:24:35AM -0700, David S. Miller escreveu:
> > > From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
> > > Date: Sat, 6 Aug 2005 10:01:05 -0300
On Sat, Aug 06, 2005 at 04:53:08PM -0400, Jeff Garzik wrote:
>
> It is certainly preferred that someone write a document describing the
> hardware, and then a totally separate team write the driver, based on
> that document.
No question to that. However, I think it largely depends on _where_ the
On Sat, Aug 06, 2005 at 11:26:14AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sat, Aug 06, 2005 at 06:24:35AM -0700, David S. Miller escreveu:
> > From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
> > Date: Sat, 6 Aug 2005 10:01:05 -0300
> >
> > > + /* Be more specific, e.g. net-
On Sat, Aug 06, 2005 at 05:57:20AM -0400, Steven Rostedt wrote:
> On Sat, 2005-08-06 at 02:46 -0700, David S. Miller wrote:
> > Can you guys stop peeing your pants over this, put aside
> > your differences, and work on a mutually acceptable fix
> > for these bugs?
> >
> > Much appreciated, thanks
On Sat, Aug 06, 2005 at 09:58:27AM +0200, Ingo Molnar wrote:
>
> btw., the current NR_SKBS 32 in netpoll.c seems quite low, especially
> e1000 can have a whole lot more skbs queued at once. Might be more
> robust to increase it to 128 or 256?
Not sure that the card's queueing really makes a dif
Hi,
This patch fills in some missing pieces:
* Support v4 udp: same as v4 tcp, when in reserve, drop packets on
noncritical sockets
* Support v4 icmp: when in reserve, drop icmp traffic
* Add reserve skb support to e1000 driver
* API for dropping packets before delivery (dev_d
On Sat, Aug 06, 2005 at 06:17:56PM +0200, Harald Welte wrote:
> Ok, I re-thought. Given the following assumptions (combined from your
> three mails):
>
> 1) tcp/udp packets are matched by NOTRACK
> 2) icmp errors for packets in '1' are matched by NOTRACK
> 3) there are no NAT rules that affect th
Kalle Valo <[EMAIL PROTECTED]> wrote:
|
| This is great news. An open source Atheros driver which could be
| included to Linux is really needed.
|
| But how was the reverse engineering done? I noticed that forcedeth
| driver was implemented using the clean room design[1] and Linux
| Broadcom 4301
On 8/6/05, Harald Welte <[EMAIL PROTECTED]> wrote:
> Hi Arnaldo!
>
> The protocol header files in are usually structured in a
> way to be included by userspace code. The top section consists of
> general protocol structure definitions, typedefs, enums - followed by an
> #ifdef __KERNEL__ section
Hi Arnaldo!
The protocol header files in are usually structured in a
way to be included by userspace code. The top section consists of
general protocol structure definitions, typedefs, enums - followed by an
#ifdef __KERNEL__ section.
Currently doesn't follow that convention and can
therefore
On Sat, Aug 06, 2005 at 06:57:15AM -0300, Arnaldo Carvalho de Melo wrote:
> Hi Guys,
>
> I'm very pleased to announce that the Linux 2.6 DCCP implementation
> has been merged in David Miller's net-2.6.14.git tree, and should appear
> shortly on Andrew Morton's 2.6.13-rcLATEST-mm tree and fin
On Sat, Aug 06, 2005 at 01:25:43PM +0400, Vladimir B. Savkin wrote:
> On Sat, Aug 06, 2005 at 11:13:37AM +0200, Harald Welte wrote:
> > On Sat, Aug 06, 2005 at 02:08:15AM +0400, Vladimir B. Savkin wrote:
> > > I found that it really is NOTRACK who cause? bogus ICMP errors.
> >
> > Well, this means
It is certainly preferred that someone write a document describing the
hardware, and then a totally separate team write the driver, based on
that document.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majord
On Sunday 07 August 2005 06:26, Patrick McHardy wrote:
> > Anyway, do we not want BUG_ON(!atomic_read(&skb->users)) at the beginning
> > of kfree_skb, since we rely on it?
>
> Why do you care if skb->users is 0 or 1 in __kfree_skb()?
Because I am a neatness freak and I like to check things that in
Daniel Phillips wrote:
Hi,
The way I read this, __kfree_skb will sometimes be called with ->users = 1 and
sometimes with ->users = 0, is that right?
Yes.
static inline void kfree_skb(struct sk_buff *skb)
{
if (likely(atomic_read(&skb->users) == 1))
smp_rmb();
On Sat, Aug 06, 2005 at 10:13:29PM +0200, Patrick McHardy ([EMAIL PROTECTED])
wrote:
> Evgeniy Polyakov wrote:
> >On Sat, Aug 06, 2005 at 09:37:00PM +0200, Patrick McHardy
> >([EMAIL PROTECTED]) wrote:
> >
> >>I'm working on extending netlink to work with an arbitary number
> >>of groups and stum
Hi,
The way I read this, __kfree_skb will sometimes be called with ->users = 1 and
sometimes with ->users = 0, is that right?
static inline void kfree_skb(struct sk_buff *skb)
{
if (likely(atomic_read(&skb->users) == 1))
smp_rmb();
else if (likely(!atomic_dec_an
Evgeniy Polyakov wrote:
On Sat, Aug 06, 2005 at 09:37:00PM +0200, Patrick McHardy ([EMAIL PROTECTED])
wrote:
I'm working on extending netlink to work with an arbitary number
of groups and stumbled over this in the w1 driver:
dev->groups = 23
NETLINK_CB(skb).dst_group = dev->gro
On Sat, Aug 06, 2005 at 09:37:00PM +0200, Patrick McHardy ([EMAIL PROTECTED])
wrote:
> I'm working on extending netlink to work with an arbitary number
> of groups and stumbled over this in the w1 driver:
>
> dev->groups = 23
>
> NETLINK_CB(skb).dst_group = dev->groups;
>
Mateusz Berezecki <[EMAIL PROTECTED]> writes:
> The driver is not yet fully working because I didn't finish kernel
> integration yet. Almost all
> driver I/O ops are reverse engineered independently of openbsd openhal
> which is missing just too much.
>
>
> Ok, enough talking. Most of the atheros
I'm working on extending netlink to work with an arbitary number
of groups and stumbled over this in the w1 driver:
dev->groups = 23
NETLINK_CB(skb).dst_group = dev->groups;
netlink_broadcast(dev->nls, skb, 0, dev->groups, GFP_ATOMIC);
Apparently it wants to send to mult
On Sat, Aug 06, 2005 at 04:58:46PM +0200, Patrick McHardy wrote:
> Harald Welte wrote:
> >On Sat, Aug 06, 2005 at 02:08:15AM +0400, Vladimir B. Savkin wrote:
> >
> >>I found that it really is NOTRACK who cause? bogus ICMP errors.
>
> Good work tracking this down. I've seen reports of this before,
On Saturday 06 August 2005 18:40, David S. Miller wrote:
> From: Daniel Phillips <[EMAIL PROTECTED]>
> Date: Sat, 6 Aug 2005 04:52:07 +1000
>
> > So then there is no choice but to throttle the per-cpu ->input_pkt
> > queues.
>
> Make the driver support NAPI if you want device fairness.
This will c
On Sunday 07 August 2005 02:07, Jeff Garzik wrote:
> > +static inline struct sk_buff *__dev_memalloc_skb(struct net_device *dev,
> > + unsigned length, int gfp_mask)
> > +{
> > + struct sk_buff *skb = __dev_alloc_skb(length, gfp_mask);
> > + if (skb)
> > + goto done;
> > + if (dev
On Sat, Aug 06, 2005 at 05:12:01PM +0200, Harald Welte wrote:
> > > Well, this means that your ICMP errors need to be NAT'ed but they
> > > cannot, since the original connection causing the ICMP error did not go
> > > through connection tracking.
> >
> > How so, when there are no NAT rules that ca
On Sat, Aug 06, 2005 at 05:22:23PM +1000, Daniel Phillips wrote:
> Daniel
>
> diff -up --recursive 2.6.12.3.clean/include/linux/gfp.h
> 2.6.12.3/include/linux/gfp.h
> --- 2.6.12.3.clean/include/linux/gfp.h2005-07-15 17:18:57.0
> -0400
> +++ 2.6.12.3/include/linux/gfp.h 2005-
Harald Welte wrote:
As soon as you load NAT, _all_ connections need to be tracked, since
those with no NAT configured need to "allocate a null binding".
NAT needs to know about all connections, since otherwise it would not be
able to learn about all already-used port/ip tuples.
So independant o
On Sat, Aug 06, 2005 at 01:25:43PM +0400, Vladimir B. Savkin wrote:
> On Sat, Aug 06, 2005 at 11:13:37AM +0200, Harald Welte wrote:
> > On Sat, Aug 06, 2005 at 02:08:15AM +0400, Vladimir B. Savkin wrote:
> > > I found that it really is NOTRACK who cause? bogus ICMP errors.
> >
> > Well, this means
OK. Thanks for the comments. I'll get back soon.
Regards,
Trent.
Trent Jaeger
IBM T.J. Watson Research Center
19 Skyline Drive, Hawthorne, NY 10532
(914) 784-7225, FAX (914) 784-7225
Herbert Xu <[EMAIL PROTECTED]>
08/06/2005 03:45
Harald Welte wrote:
On Sat, Aug 06, 2005 at 02:08:15AM +0400, Vladimir B. Savkin wrote:
I found that it really is NOTRACK who cause? bogus ICMP errors.
Good work tracking this down. I've seen reports of this before, but
never found the reason.
Well, this means that your ICMP errors need to
Em Sat, Aug 06, 2005 at 06:24:35AM -0700, David S. Miller escreveu:
> From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
> Date: Sat, 6 Aug 2005 10:01:05 -0300
>
> > + /* Be more specific, e.g. net-pf-2-132-1
> > (net-pf-PF_INET-IPPROTO_SCTP-SOCK_STREAM) */
> > +
Michael, I've added all 6 patches to my net-2.6.14 tree.
It should show up on the kernel.org GIT mirrors shortly.
I decided against sticking this into 2.6.13, as these changes
can introduce regressions and the space of users effected by
this problem is decidedly small compared to how many could b
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Sat, 6 Aug 2005 17:57:17 +1000
> Hang on a second, the original poster mentioned rc5. Is this really
> pristine rc5 with the one netpoll patch? If so then it can't be the
> patches we're talking about because they only went in days later.
This seems to
Em Sat, Aug 06, 2005 at 06:24:35AM -0700, David S. Miller escreveu:
> From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
> Date: Sat, 6 Aug 2005 10:01:05 -0300
>
> > + /* Be more specific, e.g. net-pf-2-132-1
> > (net-pf-PF_INET-IPPROTO_SCTP-SOCK_STREAM) */
> > +
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
Date: Sat, 6 Aug 2005 10:01:05 -0300
> + /* Be more specific, e.g. net-pf-2-132-1
> (net-pf-PF_INET-IPPROTO_SCTP-SOCK_STREAM) */
> + if (++try_loading_module == 1)
> + request_mo
David,
Please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git
This is the only outstanding changeset in this tree.
- Arnaldo
tree 6962214b5b17c517f0021cac043f57e853dd47a6
parent 16963c77a4472768f6c04d1
Steven Rostedt wrote:
In my last email, I stated that this discussion seems to have
demonstrated that the e1000 driver's netpoll is indeed broken, and needs
to be fixed. I submitted eariler a patch for this, but it's untested
and someone who owns an e1000 needs to try it.
I can test this, but
Hang on a second, the original poster mentioned rc5. Is this really
pristine rc5 with the one netpoll patch? If so then it can't be the
patches we're talking about because they only went in days later.
Yes, I have no other patches in, so if it was not in -RC5, I was not
running it.
---
John
On Sat, Aug 06, 2005 at 09:45:03AM +0200, Ingo Molnar wrote:
>
> * Andi Kleen <[EMAIL PROTECTED]> wrote:
>
> > On Fri, Aug 05, 2005 at 01:01:57PM -0700, Matt Mackall wrote:
> > > The netpoll philosophy is to assume that its traffic is an absolute
> > > priority - it is better to potentially hang
KOVACS Krisztian wrote:
Hi,
On Friday 05 August 2005 12.50, Patrick McHardy wrote:
Is there already userspace code which uses this feature somewhere?
AFAIK Ulrich has a patch for OpenSWAN, and we (Balabit) have a patch
for racoon. Unfortunately this racoon version is available onl
On Sat, 2005-08-06 at 02:46 -0700, David S. Miller wrote:
> Can you guys stop peeing your pants over this, put aside
> your differences, and work on a mutually acceptable fix
> for these bugs?
>
> Much appreciated, thanks :-)
In my last email, I stated that this discussion seems to have
demonstra
Hi Guys,
I'm very pleased to announce that the Linux 2.6 DCCP implementation
has been merged in David Miller's net-2.6.14.git tree, and should appear
shortly on Andrew Morton's 2.6.13-rcLATEST-mm tree and finally in mainline
when Linus starts 2.6.14.
There is still a lot of work t
Can you guys stop peeing your pants over this, put aside
your differences, and work on a mutually acceptable fix
for these bugs?
Much appreciated, thanks :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at h
On 8/6/05, David S. Miller <[EMAIL PROTECTED]> wrote:
>
> All pulled, as well as your dccp-2.6.14 tree, into net-2.6.14
>
> It should show up on the kernel.org mirrors shortly.
WOW, that was fast, thank you! I'll be just one e-mail away to work
right away on fixing any bug introduced by these c
All pulled, as well as your dccp-2.6.14 tree, into net-2.6.14
It should show up on the kernel.org mirrors shortly.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Aug 06, 2005 at 11:13:37AM +0200, Harald Welte wrote:
> On Sat, Aug 06, 2005 at 02:08:15AM +0400, Vladimir B. Savkin wrote:
> > I found that it really is NOTRACK who cause? bogus ICMP errors.
>
> Well, this means that your ICMP errors need to be NAT'ed but they
> cannot, since the original
David,
First set of changesets, please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git
- Arnaldo
tree 74a7900b3b8a414e7bd2703d46ab098cb3058c97
parent 31c00831e34dd1da084057326655a0a080ba5fb2
author Arnaldo Carv
David,
First set of changesets, please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git
- Arnaldo
tree 7095737bc15a06613ef809457f95847e88a66550
parent f48ce924d611ea239cc3527235c2d926715564bb
author Arnaldo Carv
David,
First set of changesets, please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git
- Arnaldo
tree c8aedcbeb9862a688670c00fcd8c7e48f19f
parent f671625976474d7001c3e360b395312645d3d81a
author Arnaldo Carv
David,
First set of changesets, please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git
- Arnaldo
tree 78478707b3b759be0eccebbfc339e64ee0ebe7a1
parent 530583a4f943847e59125dced8b55eba8d12c690
author Arnaldo Carv
David,
First set of changesets, please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git
- Arnaldo
tree 2e9cad130641d65dc4130af6cb258bfdcd5f9743
parent 7d3cecee43811f9493bff3fa794bf30b77e4e3cd
author Arnaldo Carv
David,
First set of changesets, please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git
- Arnaldo
tree 9aa5861dbb13c5086b0f69140fa69b05331d37df
parent 971bbf10d13041e9734b9365ec078bb3c3911d08
author Arnaldo Carv
On Sat, Aug 06, 2005 at 02:08:15AM +0400, Vladimir B. Savkin wrote:
> I found that it really is NOTRACK who cause? bogus ICMP errors.
Well, this means that your ICMP errors need to be NAT'ed but they
cannot, since the original connection causing the ICMP error did not go
through connection trackin
From: Daniel Phillips <[EMAIL PROTECTED]>
Date: Sat, 6 Aug 2005 04:52:07 +1000
> So then there is no choice but to throttle the per-cpu ->input_pkt queues.
Make the driver support NAPI if you want device fairness.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body o
Simply do the pci_save_state before the register_netdev()
call, no need to mess around with the locking.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Aug 06, 2005 at 12:24:35PM +1000, herbert wrote:
> On Fri, Aug 05, 2005 at 09:32:08AM -0700, David S. Miller wrote:
> >
> > It therefore may be desirable to keep Herbert's fix in there, but
> > back out my changes until they can be reimplemented correctly.
> >
> > Herbert?
>
> Sure. Let
btw., the current NR_SKBS 32 in netpoll.c seems quite low, especially
e1000 can have a whole lot more skbs queued at once. Might be more
robust to increase it to 128 or 256?
Ingo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTE
On Tue, Aug 02, 2005 at 02:04:41PM -0400, jaegert wrote:
> Resend of 20 July patch that repaired the flow_cache_lookup
> authorization (now for 2.6.13-rc4-git4).
Thanks Trent. I'm happy with the flow cache stuff now.
However, there are still some technical details to take
care of.
> diff -puN i
* Andi Kleen <[EMAIL PROTECTED]> wrote:
> On Fri, Aug 05, 2005 at 01:01:57PM -0700, Matt Mackall wrote:
> > The netpoll philosophy is to assume that its traffic is an absolute
> > priority - it is better to potentially hang trying to deliver a panic
> > message than to give up and crash silently.
On Saturday 06 August 2005 12:32, Steven Rostedt wrote:
> > > If you need to really get the data out, then the design should be
> > > changed. Have some return value showing the failure, check for
> > > oops_in_progress or whatever, and try again after turning interrupts
> > > back on, and getting
Hi,
This version does not do blatantly stupid things in hardware irq context, is
more efficient, and... wow the patch is smaller! (That never happens.)
I don't mark skbs as being allocated from reserve any more. That works, but
it is slightly bogus, because it doesn't matter which skb came from
On Sunday 07 August 2005 03:54, Daniel Phillips wrote:
> On Saturday 06 August 2005 18:40, David S. Miller wrote:
> > From: Daniel Phillips <[EMAIL PROTECTED]>
> > Date: Sat, 6 Aug 2005 04:52:07 +1000
> >
> > > So then there is no choice but to throttle the per-cpu ->input_pkt
> > > queues.
> >
> >
62 matches
Mail list logo
