Re: [I] Dashboard without a chart fails when generating thumbnail at screenshot step by celery worker [superset]

2024-04-10 Thread via GitHub
amolsr commented on issue #25237: URL: https://github.com/apache/superset/issues/25237#issuecomment-2048967516 Hi, we are facing similar issue. caching the dashboard before the report is generated should help in these type of scenario. -- This is an automated message from the Apache Git

[I] there is a bug about mixed chart [superset]

2024-04-10 Thread via GitHub
sandbury opened a new issue, #27984: URL: https://github.com/apache/superset/issues/27984 ### Bug description use mixed chat ,when the X-axis is number ,The histogram goes beyond the end of the x-axis like

Re: [PR] feat: add option to disable rendering of html in sql lab and table chart [superset]

2024-04-10 Thread via GitHub
soniagtm commented on code in PR #27969: URL: https://github.com/apache/superset/pull/27969#discussion_r1560407047 ## superset-frontend/src/SqlLab/components/ResultSet/index.tsx: ## @@ -579,6 +580,10 @@ const ResultSet = ({ const expandedColumns =

Re: [I] Error on embedded dashboard after upgrading to 3.1.1: "Guest user cannot modify chart payload" [superset]

2024-04-10 Thread via GitHub
Attachai77 commented on issue #27177: URL: https://github.com/apache/superset/issues/27177#issuecomment-2048878760 Hello @enzo-dechaene , Thank you for your reply, the below is my permissions which no any "datasource access on table..." , Could you please show me your guest permissions

Re: [PR] chore(ci): make pre-commit step faster by skipping superset install [superset]

2024-04-10 Thread via GitHub
mistercrunch merged PR #27979: URL: https://github.com/apache/superset/pull/27979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Superset API return 401 Access Denied: Invalid Credential even when using admin account [superset]

2024-04-10 Thread via GitHub
EuphoriaCelestial commented on issue #27961: URL: https://github.com/apache/superset/issues/27961#issuecomment-2048797879 > A few diagnostic questions: > > 1. Does it work via the UI, or is it throwing errors there, too? > > 2. Are _all_ POST endpoints not working, or

[PR] chore: remove no-op.yml as it's not needed anymore [superset]

2024-04-10 Thread via GitHub
mistercrunch opened a new pull request, #27980: URL: https://github.com/apache/superset/pull/27980 ### SUMMARY After merging https://github.com/apache/superset/pull/27906, we shouldn't need this no-op file that was a bit of a hack in the first place. For more information as to why

Re: [PR] docs: deploy docs when merging to master [superset]

2024-04-10 Thread via GitHub
mistercrunch merged PR #27956: URL: https://github.com/apache/superset/pull/27956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat: disable chromium downloads by default in docker-compose [superset]

2024-04-10 Thread via GitHub
mistercrunch commented on PR #27953: URL: https://github.com/apache/superset/pull/27953#issuecomment-2048593853 @supersetbot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] feat: disable chromium downloads by default in docker-compose [superset]

2024-04-10 Thread via GitHub
mistercrunch commented on PR #27953: URL: https://github.com/apache/superset/pull/27953#issuecomment-2048589684 @supersetbot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] feat: disable chromium downloads by default in docker-compose [superset]

2024-04-10 Thread via GitHub
mistercrunch commented on PR #27953: URL: https://github.com/apache/superset/pull/27953#issuecomment-2048582776 @supersetbot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] feat: disable chromium downloads by default in docker-compose [superset]

2024-04-10 Thread via GitHub
mistercrunch commented on PR #27953: URL: https://github.com/apache/superset/pull/27953#issuecomment-2048579948 @supersetbot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] fix(models.core:Database): Allocate a SQLA engine once per process per URL. [superset]

2024-04-10 Thread via GitHub
eschutho commented on PR #27899: URL: https://github.com/apache/superset/pull/27899#issuecomment-2048563314 @pedro-r-marques I restarted CI and fixed the formatting issue. We'll see if it passes now. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] fix(models.core:Database): Allocate a SQLA engine once per process per URL. [superset]

2024-04-10 Thread via GitHub
eschutho commented on code in PR #27899: URL: https://github.com/apache/superset/pull/27899#discussion_r1560137955 ## superset/models/core.py: ## @@ -376,9 +407,7 @@ def get_effective_user(self, object_url: URL) -> str | None: return ( username

Re: [PR] fix(models.core:Database): Allocate a SQLA engine once per process per URL. [superset]

2024-04-10 Thread via GitHub
eschutho commented on code in PR #27899: URL: https://github.com/apache/superset/pull/27899#discussion_r1560137869 ## superset/models/core.py: ## @@ -376,9 +407,7 @@ def get_effective_user(self, object_url: URL) -> str | None: return ( username

[PR] chore(ASF): adds DOAP file [superset]

2024-04-10 Thread via GitHub
rusackas opened a new pull request, #27978: URL: https://github.com/apache/superset/pull/27978 ### SUMMARY ASF has requested we add this DOAP (Definition of a Project) file that they include in various platforms. Instructions/tooling to create and update these are

Re: [PR] feat: new CSV upload form and API [superset]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #27840: URL: https://github.com/apache/superset/pull/27840#issuecomment-2048542268 @eschutho Ephemeral environment spinning up at http://54.214.102.139:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.

Re: [PR] feat: new CSV upload form and API [superset]

2024-04-10 Thread via GitHub
eschutho commented on PR #27840: URL: https://github.com/apache/superset/pull/27840#issuecomment-2048531023 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] feat: add option to disable rendering of html in sql lab and table chart [superset]

2024-04-10 Thread via GitHub
justinpark commented on code in PR #27969: URL: https://github.com/apache/superset/pull/27969#discussion_r1560110186 ## superset-frontend/src/SqlLab/components/SqlEditor/index.tsx: ## @@ -284,6 +284,9 @@ const SqlEditor: React.FC = ({ const [autocompleteEnabled,

Re: [PR] feat: add option to disable rendering of html in sql lab and table chart [superset]

2024-04-10 Thread via GitHub
justinpark commented on code in PR #27969: URL: https://github.com/apache/superset/pull/27969#discussion_r1560109576 ## superset-frontend/src/SqlLab/components/ResultSet/index.tsx: ## @@ -579,6 +580,10 @@ const ResultSet = ({ const expandedColumns =

Re: [PR] chore: [proposal] de-matrix python-version in GHAs [superset]

2024-04-10 Thread via GitHub
mistercrunch merged PR #27906: URL: https://github.com/apache/superset/pull/27906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore: [proposal] de-matrix python-version in GHAs [superset]

2024-04-10 Thread via GitHub
mistercrunch commented on code in PR #27906: URL: https://github.com/apache/superset/pull/27906#discussion_r1560082354 ## .github/actions/setup-backend/action.yml: ## @@ -13,22 +13,39 @@ inputs: description: 'Type of requirements to install. Options: base, development,

Re: [PR] chore: [proposal] de-matrix python-version in GHAs [superset]

2024-04-10 Thread via GitHub
rusackas commented on code in PR #27906: URL: https://github.com/apache/superset/pull/27906#discussion_r1560036976 ## .github/workflows/no-op.yml: ## @@ -0,0 +1,96 @@ +# no-op.yml +# +# Purpose: +# This workflow provides a workaround for the "required status checks" feature in

Re: [PR] chore(docs): remove seemingly unused unpkg domain from CSPs [superset]

2024-04-10 Thread via GitHub
rusackas merged PR #27976: URL: https://github.com/apache/superset/pull/27976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore: [proposal] de-matrix python-version in GHAs [superset]

2024-04-10 Thread via GitHub
rusackas commented on code in PR #27906: URL: https://github.com/apache/superset/pull/27906#discussion_r1560023314 ## .github/actions/setup-backend/action.yml: ## @@ -13,22 +13,39 @@ inputs: description: 'Type of requirements to install. Options: base, development,

Re: [PR] chore: [proposal] de-matrix python-version in GHAs [superset]

2024-04-10 Thread via GitHub
mistercrunch commented on code in PR #27906: URL: https://github.com/apache/superset/pull/27906#discussion_r1560016912 ## .github/workflows/no-op.yml: ## @@ -0,0 +1,96 @@ +# no-op.yml Review Comment: I'll be able to delete this file after we merge this -- This is an

Re: [PR] chore(docs): removing Superset Community Newsletter archive [superset]

2024-04-10 Thread via GitHub
rusackas merged PR #27977: URL: https://github.com/apache/superset/pull/27977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix(alerts/reports): removing duplicate notification method options [superset]

2024-04-10 Thread via GitHub
rusackas merged PR #27239: URL: https://github.com/apache/superset/pull/27239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] chore(docs): removing Superset Community Newsletter archive [superset]

2024-04-10 Thread via GitHub
rusackas opened a new pull request, #27977: URL: https://github.com/apache/superset/pull/27977 ### SUMMARY Removing the iframe hosting archives of the Superset Community Newsletter, and the corresponding CSP entry. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

[PR] chore(docs): remove seemingly unused unpkg domain from CSPs [superset]

2024-04-10 Thread via GitHub
rusackas opened a new pull request, #27976: URL: https://github.com/apache/superset/pull/27976 ### SUMMARY ASF isn't happy with this being in here, and I can't figure out if/where unpkg is even being referenced, so I'll scrap it here. ### BEFORE/AFTER SCREENSHOTS OR

Re: [PR] chore(docs): adding ASF Privacy Link. [superset]

2024-04-10 Thread via GitHub
rusackas merged PR #27975: URL: https://github.com/apache/superset/pull/27975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Installing latest superset via helm, cant connect to azure redis service via ssl [superset]

2024-04-10 Thread via GitHub
simaolucio commented on issue #25375: URL: https://github.com/apache/superset/issues/25375#issuecomment-2048236099 I'm having an issue similar to @manneym. I'm upgrading to 3.1.1, from 2.1.0. Deploy through Helm chart version 0.12.7. Connection to Azure Cache for Redis now fails with

[PR] chore(docs): adding ASF Privacy Link. [superset]

2024-04-10 Thread via GitHub
rusackas opened a new pull request, #27975: URL: https://github.com/apache/superset/pull/27975 ### SUMMARY The ASF requests that all project sites have this link, so I'm adding it to the footer here. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING

Re: [PR] fix(node): bump node version in nvmrc files [superset]

2024-04-10 Thread via GitHub
rusackas merged PR #27974: URL: https://github.com/apache/superset/pull/27974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore: [proposal] de-matrix python-version in GHAs [superset]

2024-04-10 Thread via GitHub
mistercrunch commented on PR #27906: URL: https://github.com/apache/superset/pull/27906#issuecomment-2048103643 Capturing the conversation from the **Release Strategy Group** this morning: - let's support a single python version officially per release, and run CI against that one

Re: [PR] chore(料): bump python flask-caching subpackage(s) [superset]

2024-04-10 Thread via GitHub
mistercrunch closed pull request #27958: chore(料): bump python flask-caching subpackage(s) URL: https://github.com/apache/superset/pull/27958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] chore(料): bump python flask-wtf subpackage(s) [superset]

2024-04-10 Thread via GitHub
mistercrunch closed pull request #27971: chore(料): bump python flask-wtf subpackage(s) URL: https://github.com/apache/superset/pull/27971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] chore(料): bump python paramiko subpackage(s) [superset]

2024-04-10 Thread via GitHub
mistercrunch closed pull request #27972: chore(料): bump python paramiko subpackage(s) URL: https://github.com/apache/superset/pull/27972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] fix(node): bump node version in nvmrc files [superset]

2024-04-10 Thread via GitHub
rusackas opened a new pull request, #27974: URL: https://github.com/apache/superset/pull/27974 ### SUMMARY @geido noticed I missed the `.nvmrc` files in [this PR](https://github.com/apache/superset/pull/27198). This corrects that! ### BEFORE/AFTER SCREENSHOTS OR

[I] Alias Not Applying for Simple Column on Raw Records Table [superset]

2024-04-10 Thread via GitHub
mtrentz opened a new issue, #27973: URL: https://github.com/apache/superset/issues/27973 ### Bug description When I edit a column name/alias that is just a "simple column" on the `CUSTOM SQL` tab the alias will not apply to the visualization. If I add a custom sql that is

Re: [I] Calendar Heatmap - Shows unexpected null dates [superset]

2024-04-10 Thread via GitHub
vankeer commented on issue #21870: URL: https://github.com/apache/superset/issues/21870#issuecomment-2047950984 I just stumbled upon this when installing & using the latest version from master. This is still an issue. > It is working as expected please recheck the issue and close

Re: [PR] chore(料): bump python paramiko subpackage(s) [superset]

2024-04-10 Thread via GitHub
mistercrunch closed pull request #27972: chore(料): bump python paramiko subpackage(s) URL: https://github.com/apache/superset/pull/27972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] build(deps): bump deck.gl from 8.8.27 to 9.0.6 in /superset-frontend/plugins/legacy-preset-chart-deckgl [superset]

2024-04-10 Thread via GitHub
mistercrunch commented on PR #27965: URL: https://github.com/apache/superset/pull/27965#issuecomment-2047937370 Putting a hold label here as deck.gl has been tricky to upgrade in the past and requires special care. This is also a major version -- This is an automated message from the

Re: [PR] chore(料): bump python flask-wtf subpackage(s) [superset]

2024-04-10 Thread via GitHub
mistercrunch closed pull request #27971: chore(料): bump python flask-wtf subpackage(s) URL: https://github.com/apache/superset/pull/27971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [SIP-123] Proposal replacement of data table components with ag-grid [superset]

2024-04-10 Thread via GitHub
rusackas commented on issue #27645: URL: https://github.com/apache/superset/issues/27645#issuecomment-2047926942 > We've also received confirmation from the ag-Grid team regarding the use of the community version in Superset. Indeed. It looks like I forgot to mention that here, so

Re: [I] Superset API return 401 Access Denied: Invalid Credential even when using admin account [superset]

2024-04-10 Thread via GitHub
rusackas commented on issue #27961: URL: https://github.com/apache/superset/issues/27961#issuecomment-2047874630 A few diagnostic questions: 1) Does it work via the UI, or is it throwing errors there, too? 2) Are _all_ POST endpoints not working, or is it just this one? I'm not

Re: [PR] chore(料): bump python paramiko subpackage(s) [superset]

2024-04-10 Thread via GitHub
github-actions[bot] closed pull request #27972: chore(料): bump python paramiko subpackage(s) URL: https://github.com/apache/superset/pull/27972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] chore(料): bump python flask-wtf subpackage(s) [superset]

2024-04-10 Thread via GitHub
github-actions[bot] opened a new pull request, #27971: URL: https://github.com/apache/superset/pull/27971 Updates the python "flask-wtf" library version from null to null. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the

[PR] chore(料): bump python paramiko subpackage(s) [superset]

2024-04-10 Thread via GitHub
github-actions[bot] opened a new pull request, #27972: URL: https://github.com/apache/superset/pull/27972 Updates the python "paramiko" library version from null to null. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] chore(料): bump python flask-wtf subpackage(s) [superset]

2024-04-10 Thread via GitHub
github-actions[bot] closed pull request #27971: chore(料): bump python flask-wtf subpackage(s) URL: https://github.com/apache/superset/pull/27971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] feat: custom refresh frequency [superset]

2024-04-10 Thread via GitHub
rusackas commented on PR #24449: URL: https://github.com/apache/superset/pull/24449#issuecomment-2047857845 @geido can you check your requested changes to (potentially) unblock the merge when you have a chance, please? -- This is an automated message from the Apache Git Service. To

Re: [PR] build(deps): bump deck.gl from 8.8.27 to 9.0.6 in /superset-frontend/plugins/legacy-preset-chart-deckgl [superset]

2024-04-10 Thread via GitHub
rusackas closed pull request #27965: build(deps): bump deck.gl from 8.8.27 to 9.0.6 in /superset-frontend/plugins/legacy-preset-chart-deckgl URL: https://github.com/apache/superset/pull/27965 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] build(deps): bump deck.gl from 8.8.27 to 9.0.6 in /superset-frontend/plugins/legacy-preset-chart-deckgl [superset]

2024-04-10 Thread via GitHub
dependabot[bot] commented on PR #27965: URL: https://github.com/apache/superset/pull/27965#issuecomment-2047853470 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

Re: [PR] feat: new CSV upload form and API [superset]

2024-04-10 Thread via GitHub
dpgaspar commented on code in PR #27840: URL: https://github.com/apache/superset/pull/27840#discussion_r1559608941 ## superset/migrations/versions/2024-04-08_15-43_5ad7321c2169_mig_new_csv_upload_perm.py: ## @@ -0,0 +1,85 @@ +# Licensed to the Apache Software Foundation (ASF)

Re: [I] api login with ldap account ,returns error [superset]

2024-04-10 Thread via GitHub
schoenbl-plwr commented on issue #27964: URL: https://github.com/apache/superset/issues/27964#issuecomment-2047791181 I'm receiving the same error. I'm cloning the repo. I'm adding to the default my superset_config.py: ``` TALISMAN_ENABLED = False ENABLE_CORS = True

Re: [PR] chore: Fix/remove hardcode of admin role [superset]

2024-04-10 Thread via GitHub
rusackas commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2047774826 The main thing I'm wondering about this PR now that I look more closely at the code, is if there's a better place to store this information. I'm a little nervous about storing

Re: [PR] docs(k8s): making it clear users MUST update secrets for prod instances. [superset]

2024-04-10 Thread via GitHub
rusackas merged PR #27954: URL: https://github.com/apache/superset/pull/27954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Error when using "TIME COLUMN" along with "X-AXIS" for same value for Clickhouse [superset]

2024-04-10 Thread via GitHub
rusackas commented on issue #23384: URL: https://github.com/apache/superset/issues/23384#issuecomment-2047699347 Thanks @kovitals - if anyone else on this thread finds this to be a sufficient answer (or even a sufficient workaround), this would be a great documentation update on the

Re: [PR] fix(asf): removing google hosted analytics and fonts [superset]

2024-04-10 Thread via GitHub
rusackas merged PR #27963: URL: https://github.com/apache/superset/pull/27963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat: new CSV upload form and API [superset]

2024-04-10 Thread via GitHub
michael-s-molina commented on code in PR #27840: URL: https://github.com/apache/superset/pull/27840#discussion_r1559499209 ## superset/migrations/versions/2024-04-08_15-43_5ad7321c2169_mig_new_csv_upload_perm.py: ## @@ -0,0 +1,85 @@ +# Licensed to the Apache Software Foundation

Re: [PR] feat: new CSV upload form and API [superset]

2024-04-10 Thread via GitHub
dpgaspar commented on code in PR #27840: URL: https://github.com/apache/superset/pull/27840#discussion_r1559489636 ## superset/migrations/versions/2024-04-08_15-43_5ad7321c2169_mig_new_csv_upload_perm.py: ## @@ -0,0 +1,85 @@ +# Licensed to the Apache Software Foundation (ASF)

Re: [PR] feat: new CSV upload form and API [superset]

2024-04-10 Thread via GitHub
dpgaspar commented on code in PR #27840: URL: https://github.com/apache/superset/pull/27840#discussion_r1559476034 ## superset-frontend/src/pages/DatabaseList/index.tsx: ## @@ -230,6 +233,16 @@ function DatabaseList({ { label: t('Upload file to database'),

Re: [PR] feat: new CSV upload form and API [superset]

2024-04-10 Thread via GitHub
dpgaspar commented on code in PR #27840: URL: https://github.com/apache/superset/pull/27840#discussion_r1559474828 ## superset-frontend/src/features/home/SubMenu.tsx: ## @@ -162,6 +162,7 @@ const StyledHeader = styled.div` const styledDisabled = (theme: SupersetTheme) =>

Re: [PR] feat: new CSV upload form and API [superset]

2024-04-10 Thread via GitHub
dpgaspar commented on PR #27840: URL: https://github.com/apache/superset/pull/27840#issuecomment-2047587867 @michael-s-molina @kasiazjc I've addressed basically all your comments: @michael-s-molina 1 - Fixed the display disabled at the component level 2 - fixed the width, did

Re: [I] Horizontal bar chart: too much space above the chart [superset]

2024-04-10 Thread via GitHub
michael-s-molina closed issue #27966: Horizontal bar chart: too much space above the chart URL: https://github.com/apache/superset/issues/27966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Horizontal bar chart: too much space above the chart [superset]

2024-04-10 Thread via GitHub
visharavana commented on issue #27966: URL: https://github.com/apache/superset/issues/27966#issuecomment-2047511167 @michael-s-molina Sorry, it's my mistake. I didn't see the margin. Now it's working well. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] feat: Tooltip renderer [superset]

2024-04-10 Thread via GitHub
michael-s-molina commented on PR #27950: URL: https://github.com/apache/superset/pull/27950#issuecomment-2047454607 @justinpark @villebro @rusackas Thank you for the comments. I'm still working on the component's API and implementation as I continue to iterate on each plugin. I'm still not

Re: [I] Error on embedded dashboard after upgrading to 3.1.1: "Guest user cannot modify chart payload" [superset]

2024-04-10 Thread via GitHub
enzo-dechaene commented on issue #27177: URL: https://github.com/apache/superset/issues/27177#issuecomment-2047453303 Hi @Attachai77, I don't know if this is a solution but I solved the problem by removing the "datasource access on table..." right on my specific role. -- This is an

Re: [I] Error when using "TIME COLUMN" along with "X-AXIS" for same value for Clickhouse [superset]

2024-04-10 Thread via GitHub
kovitals commented on issue #23384: URL: https://github.com/apache/superset/issues/23384#issuecomment-2047447780 Can be fixed on ClickHouse side, with user setting for default profile ``` **1** ... ``` -- This is an automated message from the Apache

Re: [I] [value-filter] After text search only showing values corresponding to the search before [superset]

2024-04-10 Thread via GitHub
michael-s-molina commented on issue #27949: URL: https://github.com/apache/superset/issues/27949#issuecomment-2047421561 Hi @PowerDinosaur. I was not able to reproduce the error in 3.1.2 and 4.0.0. Am I missing any step?

Re: [I] Horizontal bar chart: too much space above the chart [superset]

2024-04-10 Thread via GitHub
michael-s-molina commented on issue #27966: URL: https://github.com/apache/superset/issues/27966#issuecomment-2047371102 Hi @visharavana. Do you have a margin configured? Using the [4.0.0 test environment](http://18.246.209.142:8080/), I'm not able to reproduce this issue.

Re: [PR] fix: docker-release GHA fails with pathspec error [superset]

2024-04-10 Thread via GitHub
michael-s-molina commented on PR #27925: URL: https://github.com/apache/superset/pull/27925#issuecomment-2047355046 @mistercrunch I was able to successfully run [Docker Publish Release](https://github.com/apache/superset/actions/runs/8603829061) after merging this PR but for some reason it

Re: [I] [SIP-123] Proposal replacement of data table components with ag-grid [superset]

2024-04-10 Thread via GitHub
michael-s-molina commented on issue #27645: URL: https://github.com/apache/superset/issues/27645#issuecomment-2047276381 > We've also received confirmation from the ag-Grid team regarding the use of the community version in Superset. In light of this, this proposal suggests replacing all

Re: [PR] docs(k8s): making it clear users MUST update secrets for prod instances. [superset]

2024-04-10 Thread via GitHub
margorczynski commented on PR #27954: URL: https://github.com/apache/superset/pull/27954#issuecomment-2047214372 Hey @rusackas, yep, I think this more stronly suggests that the config needs to be overwritten for this to work, thank you for the update :) -- This is an automated message

Re: [PR] fix(Dashboard): Add aria-label to filters and search forms [superset]

2024-04-10 Thread via GitHub
geido merged PR #27968: URL: https://github.com/apache/superset/pull/27968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore: Fix/remove hardcode of admin role [superset]

2024-04-10 Thread via GitHub
Always-prog commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2046954495 @rusackas Test cases has beed passed without rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] feat: add option to disable rendering of html in sql lab and table chart [superset]

2024-04-10 Thread via GitHub
soniagtm opened a new pull request, #27969: URL: https://github.com/apache/superset/pull/27969 ### SUMMARY Currently, the platform renders any HTML command in the result table, which can sometimes obscure the full HTML in the request body. To address this, an option button that

[PR] fix(Dashboard): Add aria-label to filters and search forms [superset]

2024-04-10 Thread via GitHub
geido opened a new pull request, #27968: URL: https://github.com/apache/superset/pull/27968 ### SUMMARY This PR improves accessibility of the Dashboard by adding aria-label to filters' forms and table search. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N.A. ### TESTING

Re: [I] Error on embedded dashboard after upgrading to 3.1.1: "Guest user cannot modify chart payload" [superset]

2024-04-10 Thread via GitHub
Attachai77 commented on issue #27177: URL: https://github.com/apache/superset/issues/27177#issuecomment-2046856658 I got same issue https://github.com/apache/superset/assets/15119618/4797bbcb-a5d9-491d-8bd3-e70e53c07847;>

[I] Horizontal bar chart: too much space above the chart [superset]

2024-04-10 Thread via GitHub
visharavana opened a new issue, #27966: URL: https://github.com/apache/superset/issues/27966 ### Bug description When I use the horizontal bar chart, it shows correctly, but when I enable the legend option, it does not show correctly, like there is too much space between the legend

Re: [PR] fix: Data zoom with horizontal orientation [superset]

2024-04-10 Thread via GitHub
visharavana commented on PR #27291: URL: https://github.com/apache/superset/pull/27291#issuecomment-2046614658 @michael-s-molina when you use this code to align the Data Zoom slide perfectly. yAxisIndex: isHorizontal ? 60 : undefined, ![new-chart-2024-04-10T06-08-11

Re: [PR] refactor: add "button" role to clickable UI elements for improved accessibility [superset]

2024-04-10 Thread via GitHub
eulloa10 commented on code in PR #26602: URL: https://github.com/apache/superset/pull/26602#discussion_r1558772499 ## superset-frontend/src/explore/components/controls/FixedOrMetricControl/index.jsx: ## @@ -127,7 +127,7 @@ export default class FixedOrMetricControl extends