Opened OAK-4640 to track this
Chetan Mehrotra
On Wed, Aug 3, 2016 at 9:36 PM, Michael Dürig wrote:
>
>
> On 3.8.16 5:58 , Chetan Mehrotra wrote:
>>
>> On Wed, Aug 3, 2016 at 8:57 PM, Michael Dürig wrote:
>>>
>>> I would suggest to add an new, in
On Wed, Aug 3, 2016 at 8:57 PM, Michael Dürig wrote:
> I would suggest to add an new, internal mechanism to CommitInfo for your
> purpose.
So introduce a new CommitAttributes instance which would be returned
by CommitInfo ... ?
Chetan Mehrotra
That would depend on the CommitHook impl which client code would not
be aware of. And commit hook would also know only as commit traversal
is done. So it needs to be some mutable state
Chetan Mehrotra
On Wed, Aug 3, 2016 at 8:27 PM, Michael Dürig wrote:
>
> Couldn't we keep the ma
On Wed, Aug 3, 2016 at 7:52 PM, Alex Parvulescu
wrote:
> sounds interesting, this looks like a good option.
>
Now comes the hard part ... what should be the name of this new
interface ;) ContextualIndexEditorProvider?
Chetan Mehrotra
So would it be ok to make the map within CommitInfo mutable ?
Chetan Mehrotra
On Wed, Aug 3, 2016 at 7:29 PM, Michael Dürig wrote:
>
>>
>> #A -Probably we can introduce a new type CommitAttributes which can be
>> attached to CommitInfo and which can be modified by th
ew interface would have the extra params passed in. And
there we introduce something like IndexingContext which folds in
IndexUpdateCallback, indexing mode, index path, CommitInfo etc
Chetan Mehrotra
e accessed by Observer
OR
#B - We can just add a mutable attribute map to the CommitInfo
instance and that can be populated by CommitHooks
Thoughts on which approach to go forward
Chetan Mehrotra
a new interface for IndexEditorProvider.
So looking for thoughts on how this can be implemented!
Chetan Mehrotra
[1]
https://issues.apache.org/jira/browse/OAK-4412?focusedCommentId=15405340&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15405340
[2] Naming
leVerionable change to NOT referenceable
mix:versionable change to referenceable
nt:frozenNode property jcr:frozenUuid change to NOT mandatory
===
Chetan Mehrotra
[1] https://java.net/jira/browse/JSR_283-428
ure if API semantics require that nodes lookedup by UUID have to
be referenceable.
For now I think oak:Resource is safest way. But just exploring other
options if possible!
Chetan Mehrotra
d only on new node.
Chetan Mehrotra
[1]
https://issues.apache.org/jira/browse/JCR-2170?focusedCommentId=12754941&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12754941
e should be quick and non blocking though.
All other task are much more critical for repository to function
properly. Hence thoughts to go for #B where we have a dedicated pool
for those 'n' tasks. Where n is much small i.e. number of async lanes
+ 2 from DocumentNodeStore so far. So its ea
un in dedicated pool and each using same pool.
Pool name would be 'oak'. Also see OAK-4563 for the patch
While for #4 default pool would be used as those are non blocking and
short tasks
Chetan Mehrotra
On Tue, Jul 19, 2016 at 12:54 PM, Michael Dürig wrote:
> For blocking or time intensive tasks I would go for a dedicated thread pool.
So wrt current issue that means option #B ?
Chetan Mehrotra
should we use
A - one single pool for all of the above
B - use the pool only for 1-3. The default pool would be of 5. So even
if #2 #3 are running
it would not hamper #1
Assuming #4 is not that critical to run and may consist of lots of jobs.
My suggestion would be to go for #B
Chetan
nging the
current putFile implementation. Have it use oak:Resource is present
otherwise fallback to nt:resource. This can lead to compatibility
issue though as javadoc of putFile says it would use nt:resource
Chetan Mehrotra
oak:Resource nodetype which is same as
nt:resource but not referenceable. This would be similar to
oak:Unstructured.
Also what should we do for [1]. Should we provide an overloaded method
which also accepts a nodetype for jcr:content node as it cannot use
oak:Resource
Chetan Mehrotra
[1]
https
On Thu, Jul 14, 2016 at 2:04 PM, wrote:
>
> +commons-math3
commons-math is a 2.1 MB jar. Would it be possible to avoid embedding
it whole and only have some parts embedded/copied. (See [1] for an
example)
Chetan Mehrotra
[1]
to create an index
>> definition if you add a new language tree.
Another way would be to have your index definition under each node
/content/en/oak:index/fooIndex
/content/jp/oak:index/fooIndex
And have each index config analyzer configured as per the language.
Chetan Mehrotra
reak this requirement
Chetan Mehrotra
d one in pom.xml is
ignored. That would explain why settings in pom.xml are not used for
fixture
So what should we opt for #A?
My vote would be for A1!
Chetan Mehrotra
[1]
https://github.com/apache/jackrabbit-oak/commit/319433e9400429592065d4b3997dd31f93b6c549
[2] https://github.com/apache/jac
unk (2 week) I do not think
it should be a big problem and holding of commits break the continuity
and increases work. But then that might be just an issue for me!
For now I have reverted the changes from oak-segment-tar
Chetan Mehrotra
rsion once JR2 release is done. That has worked
fine so far and we did not had to hold the feature work for that. So
want to understand why it should be different here
Chetan Mehrotra
feedback on the issue.
Chetan Mehrotra
[1]
https://github.com/rombert/jackrabbit-oak/tree/features/docstore-multiplex/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/mount
Thanks for the link. Would followup on the issue and have it fixed in branches
Chetan Mehrotra
On Mon, Jun 27, 2016 at 5:11 PM, Julian Reschke wrote:
> On 2016-06-27 13:31, Chetan Mehrotra wrote:
>>
>> On Sat, Jun 25, 2016 at 10:24 AM, Apache Jenkins Server
>> wro
; at
> org.apache.jackrabbit.oak.commons.FixturesHelper$Fixture.valueOf(FixturesHelper.java:45)
> at
> org.apache.jackrabbit.oak.commons.FixturesHelper.(FixturesHelper.java:58)
The test are failing due to above issue. Is this related to presence
of new segment-tar module in trunk but not in branch?
Chetan Mehrotra
On Mon, Jun 27, 2016 at 10:43 AM, Amit Jain wrote:
[X] +1 Release this package as Apache Jackrabbit Oak 1.4.4
Chetan Mehrotra
extension point
Chetan Mehrotra
On Wed, Jun 22, 2016 at 4:44 PM, Stefan Egli wrote:
> On 22/06/16 12:21, "Chetan Mehrotra" wrote:
>
>>On Tue, Jun 21, 2016 at 4:52 PM, Julian Sedding
>>wrote:
>>> Not exposing the secondary NodeStore in the service registry would be
client to select correct one
Thoughts?
Chetan Mehrotra
ry instance may get bound untill primary comes up
Looking for feedback on what approach to take
Chetan Mehrotra
I have started a new mail thread around "Usecases around Binary handling in
Oak" so as to first collect the kind of usecases we need to support. Once
we decide that we can discuss the possible solution.
So lets continue the discussion on that thread
Chetan Mehrotra
On Tue, May 17, 201
your feedback!
Chetan Mehrotra
[1] http://markmail.org/thread/6mq4je75p64c5nyn
[2] https://wiki.apache.org/jackrabbit/JCR%20Binary%20Usecase
ases then we implement them.
Let me know if more details are required. If required I can put it up on a
wiki page also.
Chetan Mehrotra
[1]
http://markmail.org/thread/6mq4je75p64c5nyn#query:+page:1+mid:zv5dzsgmoegupd7l+state:results
k/jcr/Jcr.java#L190
Chetan Mehrotra
we can safely expose this file which would allow layers above to
avoid spooling the content again locally for processing. And with callback
boundary we can later do required cleanup
Chetan Mehrotra
On Mon, May 9, 2016 at 7:15 PM, Chetan Mehrotra
wrote:
> Had an offline discussion with Mich
allow Oak to enforce some safeguards (more
on that in next mail) and still allows the user to perform optimal binary
processing
Chetan Mehrotra
ile handle for
later use
Hopefully this should address some of the concerns raised in this thread.
Looking forward to feedback :)
Chetan Mehrotra
On Mon, May 9, 2016 at 6:24 PM, Michael Dürig wrote:
>
>
> On 9.5.16 11:43 , Chetan Mehrotra wrote:
>
>> To highlight - As m
oach that I can then suggest it people
implement there own BlobStore (may be by extending ours) and provide this
API there i.e. say which takes Blob id and provide the required details.
This way we "outsource" the problem. Would that be acceptable?
Chetan Mehrotra
On Mon, May 9, 2016 at 2:28 PM
the
attack vector which we are defending against.
Chetan Mehrotra
ns that customer implements its very own DataStore like
solution and all the application code do not make use of JCR Binary and
instead use another service to resolve the references. This would greatly
reduce the usefulness of JCR for asset heavy application which use JCR to
manage binary content along with its metadata
Chetan Mehrotra
original proposed approach in OAK-1963 was like that i.e. introduce
this access method on BlobStore which works on reference. But in that case
client code would need to deal with BlobStore API. In either case access to
actual binary storage data would be required
Chetan Mehrotra
On Thu, May 5, 2016 a
is need for
other place that can be introduced as a first class api
Chetan Mehrotra
On Wed, May 4, 2016 at 10:07 PM, Ian Boston wrote:
> If the File or URL is writable, will writing to the location cause issues
> for Oak ?
>
Yes that would cause problem. Expectation here is that code using a direct
location needs to behave responsibly.
Chetan Mehrotra
it
at Oak level as Blob instance are currently not bound to any session. So
proposal is to place this in 'org.apache.jackrabbit.oak.api' package
Kindly provide your feedback! Also any suggestion/guidance around how the
access control be implemented
Chetan Mehrotra
[1] http://www.ibm.com/de
Missed sending nomination on earlier thread. If not late then one more
proposal
oak-segment-v2
This is somewhat similar to names used in Mongo mmapv1 and mmapv2.
Chetan Mehrotra
On Tue, Apr 26, 2016 at 2:32 PM, Tommaso Teofili
wrote:
> oak-segment-store +1
>
> Regards,
> To
On Wed, Apr 20, 2016 at 10:25 AM, Amit Jain wrote:
> [ ] +1 Release this package as Apache Jackrabbit Oak 1.2.14
All checks ok
Chetan Mehrotra
matter much as remote call would have much more overhead.
Suggestion here was more to have a consistent way of doing such things
but not a hard requirement per se ...
Chetan Mehrotra
= PERFLOG.start();
Connection c = getDataSource().getConnection();
PERFLOG.end(start, 100, "Obtaining a new connection from {} ", ds);
---
This would also avoid the call to System.currentTimeMillis() if debug
log is not enabled
Chetan Mehrotra
you would not need to rely on
Document details
Chetan Mehrotra
[1] https://jackrabbit.apache.org/oak/docs/migration.html
On Thu, Mar 24, 2016 at 8:02 PM, Davide Giannella wrote:
> [ ] +1 Release this package as Apache Jackrabbit Oak 1.4.1
+1 (ALL CHECKS OK)
Chetan Mehrotra
On Tue, Mar 22, 2016 at 9:49 PM, Davide Giannella wrote:
> I can't really recall why and if we use this.
Its referred to in main README.md so as to allow a developer to always
enable running of integration test
Chetan Mehrotra
On Mon, Mar 7, 2016 at 4:21 PM, Davide Giannella wrote:
> [ ] +1 Release this package as Apache Jackrabbit Oak 1.4.0
All check ok including integration tes [1]
Chetan Mehrotra
[1] Run check-release.sh with following mvn command
mvn verify -fn -PintegrationTesting,unittesting,rdb-de
Cool stuff Tomek! This was something which was discussed in last
Oakathon so great to have a way to do resilience testing
programatically. Would give it a try
Chetan Mehrotra
On Mon, Mar 7, 2016 at 1:49 PM, Stefan Egli wrote:
> Hi Tomek,
>
> Would also be interesting to see the effe
is get rid of oak.version and make use of
project.version. Such a way should be similar to how oak-lucene
depends on oak-core and hence should work
Chetan Mehrotra
raid that it would not work as
expected. In JackrabbitNodeState#createBlob determining the
contentIdentity involves determining the length. You can give
org.apache.jackrabbit.oak.upgrade.blob.LengthCachingDataStore a try
(See OAK-2882 for details)
Chetan Mehrotra
the war access repository
instance
Chetan Mehrotra
[1] https://github.com/apache/jackrabbit-oak/tree/trunk/oak-examples/webapp
On Fri, Feb 5, 2016 at 2:54 PM, Michael Dürig wrote:
> There's always another library ;-)
For utility stuff well almost !
Chetan Mehrotra
ntStackTrace(pw);
> +return sw.toString();
> +} finally {
> +pw.close();
> +}
> }
> +
May be use com.google.common.base.Throwables#getStackTraceAsString
Chetan Mehrotra
On Fri, Jan 29, 2016 at 4:08 PM, Michael Dürig wrote:
>
> Shouldn't we make this volatile?
Ack. Would do that
Chetan Mehrotra
To make use of FileDataStore you would need to configure a
SegmentNodeStore as MemoryNodeStore does not allow plugging in custom
BlobStore
Have a look at snippet [1] for a possible approach
Chetan Mehrotra
[1] https://gist.github.com/chetanmeh/6242d0a7fe421955d456
On Wed, Jan 27, 2016 at 6:42
ld not be added. The primary aim was to
speed up indexing time in migration.
Chetan Mehrotra
Oak uses
1.1 and CSVFormat.withIgnoreSurroundingSpaces is added in v1.1. We
tested it earlier with Tika 1.6. So you can try adding commons-csv jar
as the first one in the classpath
java -cp commons-csv-1.1.jar:tika-app-1.11.jar:oak-run-1.2.4.jar
Chetan Mehrotra
[1]http://svn.apache.org/viewvc/tika/ta
iting the changes over there make things faster.
I mostly do partial commit i.e. only the modified page and it ha
worked well. Changing of left side menu is not a very frequent task
and for that I think doing full deploy of site is fine for now
Chetan Mehrotra
et();
> +}
> +};
> +}
Just curious about use of above approach. Is it for keeping the
dependencies as non static or using final instance variable? If you
mark references as static then all those bind and unbind method would
not be required as by the time component is active the dependencies
would be set.
Chetan Mehrotra
oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/BinaryImpl.java
I see some changes to Blob/BinaryImpl. Are those change related to
this issue? Most likely look like a noise but just wanted to confirm
Chetan Mehrotra
available in oak-jcr. Added it as a
test dependency to see if this gets resolved
Chetan Mehrotra
s because `getDefinition(parent).isProtected()` has a side of
effect of triggering an exception. With above code change that call is not
made if 'pnImporter' is null and thus causes a change in behaviour. So
better to revert that change.
Chetan Mehrotra
got lost.
Chetan Mehrotra
ion
involve
Chetan Mehrotra
[1]
https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/634/jdk=jdk1.8.0_11,label=Ubuntu,nsfixtures=SEGMENT_MK,profile=unittesting/console
t failures are in new Facet tests
@Tommaso - Can you have a look
Chetan Mehrotra
Hi Marc,
Thanks for reporting this. It looks like a regression due to changes
done for OAK-3477 (affect 1.3.11). Opened OAK-3802 for that.
Chetan Mehrotra
On Wed, Dec 16, 2015 at 9:51 PM, Marc Pfaff wrote:
> Hi
>
> Using oak-1.3.11.r1716789, I have a situation, where I see th
On Thu, Dec 10, 2015 at 7:43 PM, Davide Giannella wrote:
> Can any of you please file an issue and assign it to myself?
Done with OAK-3768
Chetan Mehrotra
pted key is created and managed is not a concern for
Oak logic. For Oak it just need a way to get plain text credential
given some opaque key data. Any method related to encrypting would not
be used by other part of Oak so need not be part of API which we
expose as extension point
Chetan Mehrotra
be performed
(say some change which touch all indexes)
Thoughts?
Chetan Mehrotra
t as part of API which needs to be used by Oak code.
The encryption method can be part of implementation such that testcase
can make use of that to create test data. Depending on embedding
application how the encrypted data is created might vary so making
that method part of API may pose some prob
> +}
> +
May be use com.google.common.base.Strings#repeat?
Chetan Mehrotra
e some of us follow is to add label
candidate_oak_1_0 or candidate_oak_1_2. See [1] for some earlier
discussion around this
Chetan Mehrotra
[1] http://markmail.org/thread/7sbse6lpgxaqgplv
On Tue, Dec 8, 2015 at 10:43 AM, Amit Jain wrote:
> [X] +1 Release this package as Apache Jackrabbit Oak 1.0.25
Chetan Mehrotra
; me that they should.
Checkpoint are not meant to prevent contention. AsyncIndexer has an
inbuilt "lease" support to prevent concurrent runs but there have been
some issues like OAK-3436 which can result in complete reindexing at
times! They should be addressed soon
Chetan Mehrotra
[1]
ts own (@Stefan thoughts?).
But as of now this is not possible. So only way out currently is to
provide your own Whiteboard implementation which can handle such kind
of singleton scheduled jobs. Doing this is certainly non trivial!
Chetan Mehrotra
[1]
https://github.com/apache/jackrabbit-oak/blob/tru
es for
sleep again. Such retry can be done for 'n' times before giving up
Chetan Mehrotra
[1]
https://jackrabbit.apache.org/api/2.1/org/apache/jackrabbit/api/observation/JackrabbitEvent.html#isExternal()
a message queue) and then other cluster nodes reacts to that
then there is a chance that such a change would not have became
visible on that cluster node.
Currently there is no deterministic way other than introducing polling
as part of queue consumer logic
Chetan Mehrotra
On Mon, Dec 7, 2015
it can be
looked into
Chetan Mehrotra
Hi Jim,
How does the indexing performs if you say just run a single webapp node?
Chetan Mehrotra
On Sat, Dec 5, 2015 at 7:18 AM, Jim.Tully wrote:
> We are using Oak embedded in a web application, and are now experiencing
> significant delays in async indexing. New nodes added are som
Does the above setup involves multiple Oak instances (say in separate
JVM) or message producer and consumer of queue are use same Oak
instance?
Chetan Mehrotra
On Thu, Dec 3, 2015 at 8:33 PM, wrote:
> I am using Oak with a DocumentNodeStore. I am storing content then adding a
> messag
The failure was in the execution of test in new oak-standalone module
as some of the dependencies are only compatible with JDK 7. Skipped
execution of test with 1717897
Chetan Mehrotra
On Fri, Dec 4, 2015 at 10:14 AM, Apache Jenkins Server
wrote:
> The Apache Jenkins build system has bu
, Integrated with Felix WebConsole and Script Console
Kindly give the example a try and provide your valuable feedback!
Chetan Mehrotra
[1] https://github.com/apache/jackrabbit-oak/tree/trunk/oak-examples/standalone
at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> org.apache.jackrabbit.oak.plugins.document.ManyChildNodesTest.manyChildNodes(ManyChildNodesTest.java:63)
Apart from intermittent Solr test failure the above is a new one.
Opened OAK-3719 for that
Chetan Mehrotra
aware
of multiplexing logic. May be I am missing something here?
Chetan Mehrotra
ntNodeStore the multiplexing breaks down.
> Code that reads and writes to /jcr:system/** does this.
Can you provide a testcase on Robert's branch illustrating the
problem? That would help to understand the problem you are facing
better
Chetan Mehrotra
On Fri, Oct 30, 2015 at 4:32 PM, Ian Bost
On Tue, Dec 1, 2015 at 3:26 PM, Rino van Wijngaarden
wrote:
> But this gives problems in osgi, so how do i do this with oak?
What is the problem and how are you running Oak. Is it via Sling?
Chetan Mehrotra
try would be fetched
from cache itself. Now with above change the cache actually gets
invalidated and hence the issue surfaces. So may be a real issue
Chetan Mehrotra
On Thu, Nov 26, 2015 at 4:35 PM, Robert Munteanu wrote:
> Hi,
>
> I get consistent test failures on MongoDB ( 2.6
e also in mind
Chetan Mehrotra
id using File based approach.
This would reduce operational complexity
Chetan Mehrotra
On Wed, Nov 25, 2015 at 6:23 PM, Stefan Egli wrote:
> Right, I'm not sure it is indeed a requirement. But without automatic
> support it might get forgotten and thus the cluster id would
cases we can allow passing the id as a system/framework property also
Chetan Mehrotra
Removed the method with 1716101
Chetan Mehrotra
On Tue, Nov 24, 2015 at 2:45 PM, Michael Dürig wrote:
>
>
> On 24.11.15 10:09 , Chetan Mehrotra wrote:
>>
>> On Tue, Nov 24, 2015 at 2:35 PM, Michael Dürig wrote:
>>>
>>> I'd rather remove the method
Looks like on JDK 8 the MBean interface has to be public for MBean
registration to work. Done that with 1716110
@Francesco - Can you try again with updated trunk?
Chetan Mehrotra
On Tue, Nov 24, 2015 at 4:58 PM, Chetan Mehrotra
wrote:
> On Tue, Nov 24, 2015 at 4:36 PM, Francesco Mari
>
On Tue, Nov 24, 2015 at 4:36 PM, Francesco Mari
wrote:
> Maven home: /usr/local/Cellar/maven32/3.2.5/libexec
> Java version: 1.8.0_65, vendor: Oracle Corporation
I am on JDK 1.7.0_55 and there it passes. Would try it on JDK 8
Chetan Mehrotra
On Tue, Nov 24, 2015 at 2:55 PM, Marcel Reutegger wrote:
> I quickly checked JIRA and it seems we can also 'unrelease'
> a version if needed.
>
> What do others think? Should we changed the release process [0]
> accordingly?
+1
Chetan Mehrotra
deprecated so would that needs to be done.
Chetan Mehrotra
201 - 300 of 773 matches
Mail list logo
