On Tue, 23 Aug 2022 18:38:48 GMT, Andy Goryachev wrote:
> This change affects eclipse projects only - all eclipse projects are
> configured to use JUnit5.
I don't see why the base project needs a `.classpath` file at all considering
that it doesn't contain sources.
-
PR:
On Tue, 23 Aug 2022 17:36:24 GMT, Kevin Rushforth wrote:
> The patch from `jfx17u` applied partially cleanly, but I had to skip several
> files that don't exist in `jfx11u`, and there were a few trivial merge
> conflicts. Additionally, the following two files had to be fixed up manually:
>
>
On Tue, 23 Aug 2022 17:36:24 GMT, Kevin Rushforth wrote:
> The patch from `jfx17u` applied partially cleanly, but I had to skip several
> files that don't exist in `jfx11u`, and there were a few trivial merge
> conflicts. Additionally, the following two files had to be fixed up manually:
>
>
On Tue, 2 Aug 2022 17:38:06 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed method
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/vs2ps.h line 26:
>
>> 24: */
>> 25:
>> 26:
> Refactoring and renaming changes to some of the D3D pipeline files and a few
> changes on the Java side. These are various "leftovers" from previous issues
> that we didn't want to touch at the time in order to confine the scope of the
> changes. They will make future work easier.
>
> Since
> Setting a null selection model in TableView and TreeTableView produce NPE on
> sorting (and probably in some other situations) because the check for null is
> missing in several places.
>
> Setting a null selection model is a valid way to disable selection in a
> (tree)table.
>
> There is
> Setting a null selection model in TableView and TreeTableView produce NPE on
> sorting (and probably in some other situations) because the check for null is
> missing in several places.
>
> Setting a null selection model is a valid way to disable selection in a
> (tree)table.
>
> There is
On Tue, 23 Aug 2022 10:39:24 GMT, Jeanette Winzenburg
wrote:
>> Andy Goryachev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8292353: typo
>> - 8292353: typo
>
> Fix looks good (left a minor inline comment which you might follow
On Tue, 2 Aug 2022 15:10:50 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed method
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/Mtl1VS.hlsl line 32:
>
>> 30: //float2
On Tue, 23 Aug 2022 08:09:10 GMT, danielpeintner wrote:
>> Andy Goryachev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8292353: typo
>> - 8292353: typo
>
>
On Mon, 15 Aug 2022 15:37:15 GMT, Jeanette Winzenburg
wrote:
>>> A quick PoC is in [my fork off Andy's
>>> PR](https://github.com/kleopatra/jfx/tree/exp-skin-install-supportsInstall)
>>
>> @kleopatra :
>> Thank you so much for your effort to research the alternatives.
>>
>> The main issue
On Tue, 23 Aug 2022 18:38:48 GMT, Andy Goryachev wrote:
> This change affects eclipse projects only - all eclipse projects are
> configured to use JUnit5.
@kleopatra or @nlisker - please review if you can. thanks!
-
PR: https://git.openjdk.org/jfx/pull/883
This change affects eclipse projects only - all eclipse projects are configured
to use JUnit5.
-
Commit messages:
- 8292678 junit5 in all eclipse projects
Changes: https://git.openjdk.org/jfx/pull/883/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=883=00
Issue:
On Tue, 23 Aug 2022 18:07:57 GMT, Kevin Rushforth wrote:
> Merge `jfx19` branch into `master`.
This pull request has now been integrated.
Changeset: 6d6726c3
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx/commit/6d6726c3d69379559c4d66681726adc4e794899c
Stats: 91 lines
> Merge `jfx19` branch into `master`.
Kevin Rushforth has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 31 commits:
- Merge jfx19
- 8235491: Tree/TableView: implementation of isSelected(int) violates contract
Reviewed-by:
Merge `jfx19` branch into `master`.
-
Commit messages:
- Merge jfx19
- 8286678: Fix mistakes in FX API docs
- 8291906: Bindings.createXxxBinding inherit incorrect method docs
The merge commit only contains trivial merges, so no merge-specific webrevs
have been generated.
On Tue, 23 Aug 2022 17:37:08 GMT, Kevin Rushforth wrote:
> Clean backport.
This pull request has now been integrated.
Changeset: 53d18fc5
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx11u/commit/53d18fc535d4426ec604c0e0d1b5138b5f36dde5
Stats: 6943 lines in 3 files
Clean backport.
-
Commit messages:
- 8288450: Update attribution in gstreamer.md file
Changes: https://git.openjdk.org/jfx11u/pull/111/files
Webrev: https://webrevs.openjdk.org/?repo=jfx11u=111=00
Issue: https://bugs.openjdk.org/browse/JDK-8288450
Stats: 6943 lines in 3 files
On Tue, 23 Aug 2022 17:36:24 GMT, Kevin Rushforth wrote:
> The patch from `jfx17u` applied partially cleanly, but I had to skip several
> files that don't exist in `jfx11u`, and there were a few trivial merge
> conflicts. Additionally, the following two files had to be fixed up manually:
>
>
The patch from `jfx17u` applied partially cleanly, but I had to skip several
files that don't exist in `jfx11u`, and there were a few trivial merge
conflicts. Additionally, the following two files had to be fixed up manually:
doc-files/release-notes-11.0.1.md
doc-files/release-notes-11.0.2.md
On Thu, 18 Aug 2022 23:52:48 GMT, Nir Lisker wrote:
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
This pull request has now been integrated.
Changeset: 8b967765
Author:Nir Lisker
URL:
On Tue, 23 Aug 2022 16:34:59 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comment
Marked as reviewed
On Tue, 23 Aug 2022 15:36:35 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
Looks good with
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comment
-
Changes:
- all: https://git.openjdk.org/jfx/pull/880/files
-
> The issue is caused by TreeTableRow incorrectly selected when cell selection
> mode is enabled.
>
> Changes:
> - modified TreeTableRow.updateSelection()
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 10 commits:
On Tue, 23 Aug 2022 15:36:35 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
> When looking at
> The issue is caused by TreeTableRow incorrectly selected when cell selection
> mode is enabled.
>
> Changes:
> - modified TreeTableRow.updateSelection()
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
8292353: spelling
On Tue, 23 Aug 2022 15:36:35 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
When looking at
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/880/files
-
On Tue, 19 Jul 2022 22:08:19 GMT, Andy Goryachev wrote:
> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect
> statement "Is functionally equivalent to calling
> getSelectedIndices().contains(index)."
> 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method
On Tue, 23 Aug 2022 11:37:38 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/concurrent/ScheduledService.java
>> line 130:
>>
>>> 128: * will treat that duration as if it were Duration.ZERO. Likewise, any
>>> Duration which answers true
>>> 129: * to {@link
On Tue, 23 Aug 2022 11:46:47 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/880/files
-
On Mon, 22 Aug 2022 22:21:29 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>
> modules/javafx.graphics/src/main/java/javafx/concurrent/ScheduledService.java
> line 130:
>
>> 128: *
On Tue, 16 Aug 2022 21:14:42 GMT, Kevin Rushforth wrote:
> This PR enables an optional signing step inserted into the build right after
> the step to strip binaries that was added by
> [JDK-8278260](https://bugs.openjdk.org/browse/JDK-8278260). As is the case
> with the `strip` step, the
On Fri, 12 Aug 2022 17:21:24 GMT, Andy Goryachev wrote:
>> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect
>> statement "Is functionally equivalent to calling
>> getSelectedIndices().contains(index)."
>> 2. reimplement TableView.TableViewSelectionModel.isSelected(int)
On Mon, 22 Aug 2022 21:08:39 GMT, Andy Goryachev wrote:
>> The issue is caused by TreeTableRow incorrectly selected when cell selection
>> mode is enabled.
>>
>> Changes:
>> - modified TreeTableRow.updateSelection()
>
> Andy Goryachev has updated the pull request incrementally with two
On Tue, 16 Aug 2022 21:14:42 GMT, Kevin Rushforth wrote:
> This PR enables an optional signing step inserted into the build right after
> the step to strip binaries that was added by
> [JDK-8278260](https://bugs.openjdk.org/browse/JDK-8278260). As is the case
> with the `strip` step, the
When setting the tab drag policy on a TabPane to REORDER, undesirable
behaviour is introduced where a tab occasionally "jumps" or slides to the
right on selection, by about 20px. I cannot determine what causes this, but
it seems to occur more often when clicking rapidly between tabs. After
sliding
On Mon, 22 Aug 2022 21:08:39 GMT, Andy Goryachev wrote:
>> The issue is caused by TreeTableRow incorrectly selected when cell selection
>> mode is enabled.
>>
>> Changes:
>> - modified TreeTableRow.updateSelection()
>
> Andy Goryachev has updated the pull request incrementally with two
40 matches
Mail list logo
