On Wed, 29 Nov 2023 02:44:31 GMT, Nir Lisker wrote:
> What each class brings with itself is a list of its own metadata properties.
> That's all it should declare. This list should automatically be added to the
> one of its parent, recursively, forming the final list. This part shouldn't
> be
On Mon, 27 Nov 2023 19:57:30 GMT, Thorsten Fischer wrote:
>> I have put this in D3DContext.java (as per customer suggestion). Just
>> wondering if I should just reinitialize directly and not wait loop: in
>> testLostStateAndReset in D3DContext.java (D3DERR_DEVICEREMOVED is handled
>> further
On Tue, 28 Nov 2023 23:34:30 GMT, Andy Goryachev wrote:
>> Provides a public utility method for use by the skins (core and custom) to
>> simplify initialization of styleable properties.
>>
>>
>> + /**
>> + * Utility method which combines CssMetaData items in one unmodifiable list
>> with the
On Tue, 28 Nov 2023 22:15:19 GMT, Thiago Milczarek Sayao
wrote:
> Copying and pasting Chinese characters on a JavaFX app on 23.10 is also broken
is this an ubuntu or javafx problem?
-
PR Comment: https://git.openjdk.org/jfx/pull/1080#issuecomment-1830961803
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote:
> The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at
> least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent
> alters its state in some way that confuses NSTextInputContext.handleEvent.
> The
> Provides a public utility method for use by the skins (core and custom) to
> simplify initialization of styleable properties.
>
>
> + /**
> + * Utility method which combines CssMetaData items in one unmodifiable list
> with the size equal to the number
> + * of items it holds (i.e. with no
On Tue, 28 Nov 2023 20:34:31 GMT, Andy Goryachev wrote:
>> Provides a public utility method for use by the skins (core and custom) to
>> simplify initialization of styleable properties.
>>
>>
>> + /**
>> + * Utility method which combines CssMetaData items in one unmodifiable list
>> with the
On Mon, 27 Nov 2023 20:22:40 GMT, Thorsten Fischer wrote:
>> Hi,
>>
>> I did open the bug report. Some notes to this PR:
>>
>> My colleagues and I are able to reproduce this bug regularly, even though it
>> takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows
>> up. We
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote:
> The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at
> least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent
> alters its state in some way that confuses NSTextInputContext.handleEvent.
> The
On Tue, 28 Nov 2023 22:41:31 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 31:
>>
>>> 29: import java.util.List;
>>> 30: import javafx.scene.Node;
>>> 31: import com.sun.javafx.UnmodifiableArrayList;
>>
>> KCR: this is a dummy comment.
On Mon, 27 Nov 2023 20:22:40 GMT, Thorsten Fischer wrote:
>> Hi,
>>
>> I did open the bug report. Some notes to this PR:
>>
>> My colleagues and I are able to reproduce this bug regularly, even though it
>> takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows
>> up. We
On Tue, 28 Nov 2023 20:34:31 GMT, Andy Goryachev wrote:
>> Provides a public utility method for use by the skins (core and custom) to
>> simplify initialization of styleable properties.
>>
>>
>> + /**
>> + * Utility method which combines CssMetaData items in one unmodifiable list
>> with the
On Tue, 28 Nov 2023 20:14:13 GMT, Andy Goryachev wrote:
>> Nir was probably referring to the type of the `list` parameter.
>> As for the return value, not only must this be a `List`, it should also be
>> mandated to be `RandomAccess`. Any implementation that doesn't support
>> random access
On Tue, 28 Nov 2023 18:45:01 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 333:
>>
>>> 331: /**
>>> 332: * Utility method which combines {@code CssMetaData} items in one
>>> unmodifiable list with size equal
>>> 333: * to the
On Tue, 28 Nov 2023 22:21:29 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> javadoc
>
> modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 31:
>
>> 29: import
On Tue, 28 Nov 2023 15:49:27 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 332:
>>
>>> 330:
>>> 331: /**
>>> 332: * Utility method which combines {@code CssMetaData} items in one
>>> unmodifiable list with size equal
>>
>> Did
On Tue, 28 Nov 2023 20:34:31 GMT, Andy Goryachev wrote:
>> Provides a public utility method for use by the skins (core and custom) to
>> simplify initialization of styleable properties.
>>
>>
>> + /**
>> + * Utility method which combines CssMetaData items in one unmodifiable list
>> with the
On Tue, 28 Nov 2023 21:53:19 GMT, Andy Goryachev wrote:
> > But I've already explained the rationale: a subclass **cannot** hide its
> > inherited JavaFX properties.
>
> It can, but only from the CSS subsystem. Whether it makes sense or not is a
> different topic, but it can - by not
On Tue, 26 Sep 2023 08:46:33 GMT, Florian Kirmaier
wrote:
>> @FlorianKirmaier this one fell off my radar. The updated fix seems fine as
>> long the check for null `runs` isn't making some other problem. Btw, the
>> title of the bug doesn't match the problem being fixed, so I recommend
>>
On Tue, 17 Oct 2023 09:23:16 GMT, Florian Kirmaier
wrote:
>> The Method javafx.print.getWidth and getHeight returns a double of points.
>> But the values are always rounded to full integers. This causes especially
>> problems,
>> with mm based Papers.
>>
>> I asked in the mailing list, with
On Tue, 28 Nov 2023 22:09:37 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
> This replaces obsolete XIM and uses gtk api for IME.
> Gtk uses [ibus](https://github.com/ibus/ibus)
>
> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
> positioning on `InputMethodRequest`.
>
> [Screencast from 17-09-2023
>
On Tue, 28 Nov 2023 21:30:38 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
On Tue, 28 Nov 2023 20:38:25 GMT, Martin Fox wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make it a default method for compatibility
>
>
> This replaces obsolete XIM and uses gtk api for IME.
> Gtk uses [ibus](https://github.com/ibus/ibus)
>
> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
> positioning on `InputMethodRequest`.
>
> [Screencast from 17-09-2023
>
> This replaces obsolete XIM and uses gtk api for IME.
> Gtk uses [ibus](https://github.com/ibus/ibus)
>
> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
> positioning on `InputMethodRequest`.
>
> [Screencast from 17-09-2023
>
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote:
> With the help of debug build which pinpointed the crash, I found the commit
> in upstream WebKit core that caused the crash. That commit was subsequently
> reverted not long after it was initially committed. This reverted commit
>
On Tue, 28 Nov 2023 19:06:42 GMT, Jose Pereda wrote:
>> With the help of debug build which pinpointed the crash, I found the commit
>> in upstream WebKit core that caused the crash. That commit was subsequently
>> reverted not long after it was initially committed. This reverted commit
>>
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote:
> With the help of debug build which pinpointed the crash, I found the commit
> in upstream WebKit core that caused the crash. That commit was subsequently
> reverted not long after it was initially committed. This reverted commit
>
With the help of debug build which pinpointed the crash, I found the commit in
upstream WebKit core that caused the crash. That commit was subsequently
reverted not long after it was initially committed. This reverted commit wasn't
in the stabilization branch we picked up for WebKit 616.1. It
On Thu, 28 Sep 2023 01:05:20 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
> Provides a public utility method for use by the skins (core and custom) to
> simplify initialization of styleable properties.
>
>
> + /**
> + * Utility method which combines CssMetaData items in one unmodifiable list
> with the size equal to the number
> + * of items it holds (i.e. with no
On Tue, 28 Nov 2023 19:12:14 GMT, Nir Lisker wrote:
> which is required for new features.
There will be a CSR filed since it's an addition to a public API. It's a small
change, and usually there are changes to javadoc and method signatures that
make it more time consuming to keep two tickets
On Tue, 28 Nov 2023 19:20:18 GMT, Michael Strauß wrote:
>> It should have been a Set maybe, or indeed a Collection.
>>
>> But it is too late: Node codifies the List return values:
>>
>>
>> public static List>
>> getClassCssMetaData();
>>
>> public List> getCssMetaData();
>
> Nir was
On Tue, 28 Nov 2023 19:14:51 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 342:
>>
>>> 340: */
>>> 341: public static List> combine(
>>> 342: List> list,
>>
>> Any reason this is specifically a `List`? Can it not be a
On Tue, 28 Nov 2023 18:58:57 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> combine
>
> modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 342:
>
>> 340: */
>> 341:
On Tue, 28 Nov 2023 00:51:36 GMT, Andy Goryachev wrote:
>> Provides a public utility method for use by the skins (core and custom) to
>> simplify initialization of styleable properties.
>>
>>
>> + /**
>> + * Utility method which combines CssMetaData items in one unmodifiable list
>> with the
On Tue, 28 Nov 2023 16:36:31 GMT, Andy Goryachev wrote:
>> A short test appears to have solved the problem caused by side effects.
>> I also found a known IME related issue, but am concerned that this fix will
>> not complicate it.
>>
>> Steps to reproduce:
>>
>> Click on another TextInput
On Tue, 28 Nov 2023 18:46:54 GMT, Andy Goryachev wrote:
> > 1. I wouldn't frame this as introducing a new requirement, but merely
> > clarifying the specification.
>
> I'd rather leave this as is. If it is a requirement, then a) there should be
> a rationale and b) it has to be tested, at
On Tue, 28 Nov 2023 00:51:36 GMT, Andy Goryachev wrote:
>> Provides a public utility method for use by the skins (core and custom) to
>> simplify initialization of styleable properties.
>>
>>
>> + /**
>> + * Utility method which combines CssMetaData items in one unmodifiable list
>> with the
On Tue, 28 Nov 2023 18:07:34 GMT, Michael Strauß wrote:
> 2. Not that I know, but there's nothing to be gained from allowing controls
> to mix up the order of their properties. This is performance-critical code,
> and we might want to benefit from a stable and predictable order at some
>
On Tue, 28 Nov 2023 00:51:36 GMT, Andy Goryachev wrote:
>> Provides a public utility method for use by the skins (core and custom) to
>> simplify initialization of styleable properties.
>>
>>
>> + /**
>> + * Utility method which combines CssMetaData items in one unmodifiable list
>> with the
On Tue, 28 Nov 2023 18:18:09 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> combine
>
> modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 333:
>
>> 331: /**
>> 332:
On Tue, 28 Nov 2023 00:51:36 GMT, Andy Goryachev wrote:
>> Provides a public utility method for use by the skins (core and custom) to
>> simplify initialization of styleable properties.
>>
>>
>> + /**
>> + * Utility method which combines CssMetaData items in one unmodifiable list
>> with the
On Tue, 28 Nov 2023 15:29:06 GMT, Andy Goryachev wrote:
> > 1. A derived class must include the metadata of its base class.
> > 2. The inherited metadata must come before the new metadata in the list.
>
> 1. what if the intent is to disallow certain parent properties from being
> modified by
> I don't quite understand how you would want to do this, and also, isn't a
> SkinInputMap a contradiction? Skins are about visuals, input is about
> behavior.
Right, sorry. More detailed proposal to follow.
-andy
From: John Hendrikx
Date: Tuesday, November 28, 2023 at 00:44
To: Andy
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that
On Tue, 28 Nov 2023 09:50:10 GMT, yosbits wrote:
> I also found a known IME related issue
Thank you for noticing the issue! I've created
[JDK-8320912](https://bugs.openjdk.org/browse/JDK-8320912), feel free to add or
correct any details.
Is the expected behavior in this case that IME should
Perhaps the review should continue for
https://github.com/openjdk/jfx/pull/1232. Then try to continue to the maven
publication part of the build file as discussed on that issue by consulting
with the author (who is very helpful).
On Tue, Nov 28, 2023 at 11:21 AM Johan Vos wrote:
> Hi Sarang,
>
On Tue, 28 Nov 2023 06:37:45 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> combine
>
> modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 332:
>
>> 330:
>> 331: /**
On Tue, 28 Nov 2023 07:00:36 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> combine
>
> modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 344:
>
>> 342: List>
On Tue, 28 Nov 2023 00:55:58 GMT, Michael Strauß wrote:
> 1. A derived class must include the metadata of its base class.
> 2. The inherited metadata must come before the new metadata in the list.
1. what if the intent is to disallow certain parent properties from being
modified by CSS? I
I'm really curious about how this is supposed to work without the Maven
Build.
Nowadays, most projects use maven artifacts for their build - instead of
copying jars. How do you test your own build - without publishing maven
artifacts?
The jars created in the distributions folder are useful - but
These are all good points. One thing we can do is make sure that there
are open JBS Enhancement issues tracking the features that are being
asked for. Prioritizing them, and eventually implementing some of them,
will be a discussion for a different day. As Johan said, we don't want
to
Hi Sarang
In case that helps, I used these steps recently to publish jars to local
maven repo. (I dont know if it is the proper way, but it did the job for
me, on linux)
in build.gradle change line 546:
defineProperty("MAVEN_PUBLISH", "true")
and line 1730: (add brackets)
artifact
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote:
> The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at
> least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent
> alters its state in some way that confuses NSTextInputContext.handleEvent.
> The
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that
Hi Sarang,
Yes, the maven publication parts in the build.gradle are not working with
the latest gradle anymore. I believe we discussed this before, and at least
my personal opinion is that those parts need to be removed from the
build.gradle. Frequent changes in gradle are causing lots of
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote:
> The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at
> least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent
> alters its state in some way that confuses NSTextInputContext.handleEvent.
> The
On 27/11/2023 23:02, Andy Goryachev wrote:
Dear John:
Thank you for further development of this idea, especially defining
the separation between Control, Skin, and Behavior.
Do I read correctly that semantic events are currently off the table?
Or, at least, either an implementation detail
60 matches
Mail list logo
