My Eclipse never had this long filename problem, and I reviewed the fluent
bindings PR when it was written so I would have seen it. You can try the
most basic version of Eclipse (
https://download.eclipse.org/eclipse/downloads/) to see if it still happens
if you want to dig into it.
On Tue, Jul 9,
>
> * in some cases, tests are always prefixed with `test` (e.g. `testFoo()`)
> * in some cases, tests have a concise but somehow meaningful name (e.g.
> `testScrollBarStaysVisible`)
Prefixing 'test' was an old convention for testing frameworks. I have been
dropping that prefix in my projects sin
Yeah, I thought that it might be possible to define properties for sizes
similarly to colors, and some earlier attempts seemed to indicate that it might
work.
It does not, unless the sizes are fixed (e.g. -fx-size-1px: 1px; )
The real solution, as you mentioned, would be to add capability t
.. one more reason to use the CSS variable spec that I forgot to mention:
5 - It's a spec that has been thoroughly thought of before it was added to
CSS and it has stood the test of time.
On Tue, Jul 9, 2024 at 11:04 PM Pedro Duque Vieira <
pedro.duquevie...@gmail.com> wrote:
> Andy, if I unders
Andy, if I understand the suggestion correctly, you want to set the Modena
sizes using variables that can be easily overridden. To that effect
variables must first be able to hold numeric values as, as it stands today
JavaFX only allows colors to be used for CSS variables.
So, you're also suggestin
Yes, you're right.
Need to find time to file those issues. Though I want to finish the theme
conversion to user agent stylesheets and then be sure it is a javafx bug.
On Tue, Jul 9, 2024 at 8:34 PM Andy Goryachev
wrote:
> Thank you for clarification!
>
>
>
> Glad you were able to do what you wa
My reading of this is that the fix for the caching bug, JDK-8245919 [1]
via PR #1072 [2], has inadvertently exposed previously hidden behavior
that is at best an undesirable feature and at worst a bug (I'd call it a
bug). It seems quite unexpected to me that overriding a variable defined
in a u
Since we touched the modena.css, I would like to ask the group's opinion on
whether we should fix the way modena.css sizes UI elements. Please see
https://bugs.openjdk.org/browse/JDK-8314683 for reference, where changing the
font size also unexpectedly changed the scrollbar.
What do you think
Thank you for clarification!
Glad you were able to do what you wanted. But really, if there are bugs, I
would rather have them filed and fixed.
-andy
From: Pedro Duque Vieira
Date: Tuesday, July 9, 2024 at 12:26
To: Andy Goryachev
Cc: openjfx-dev@openjdk.org
Subject: Re: [External] : Re:
Perhaps I should have been clearer. I mentioned that example merely to make
a point on how having a stylesheet set as an AUTHOR stylesheet can be a
problem (Modena or a custom theme library like JMetro) :-) .
It wasn't actually to create a new separate discussion.
As for the other discussion not
If your stylesheet defines the necessary variables, the "users" should be able
to redefine them, correct?
Or maybe allow for programmatic control of the stylesheet, similar to
https://github.com/andy-goryachev/AppFramework/blob/7f74f58ecd4de239be923c4384e10142e48ade7c/src/goryachev/fx/FxFramework
>> That's why now in the new theme I'm creating I'm setting everything to
be an user agent stylesheet.
> and this is probably the right approach.
Correct. That's why I agree with John and why the current behavior is
likely undesired. :-)
On Tue, Jul 9, 2024 at 7:40 PM Andy Goryachev
wrote:
> That's why now in the new theme I'm creating I'm setting everything to be an
> user agent stylesheet.
and this is probably the right approach.
-andy
From: openjfx-dev on behalf of Pedro Duque
Vieira
Date: Tuesday, July 9, 2024 at 11:28
To: openjfx-dev@openjdk.org
Subject: Re: [External
Yes, sorry, I read it as if you were proposing to change the behavior. My
mistake. I still think this is a good discussion to have. Perhaps we ought to
clarify the behavior somewhere?
My understanding of CSS is that it does not work as a pre-processor. Rather,
it's a single set of global th
On Mon, 8 Jul 2024 13:39:49 GMT, Ambarish Rapte wrote:
> The parameter "offset" is not validated in the 2 native methods getRGBImpl()
> and setRGBImpl() of com.sun.pisces.AbstractSurface (in JAbstractSurface.c).
> The PR adds the "offset < 0" check to both the methods.
This pull request has now
Hi guys,
I agree with John Hendrikx on this.
The thing is not that you override the "css variable" value but that you
end up overriding the priority of the rules in Modena which the developer
won't likely want to.
One other thing I'd add is that developers also like to use css themselves.
If mod
On Tue, 9 Jul 2024 17:10:07 GMT, Andy Goryachev wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> const vars
>
> modules/javafx.graphics/src/main/native-prism-sw/JAbstractSurface.c line 70:
>
>> 68: jint x
Hi Andy,
I'm confused, nowhere do I propose to remove or otherwise make the CSS
reference system implemented by FX unusable.
I'm first trying to ascertain if this would be expected behavior (it is
indeed unspecified, and the default currently seems to have been chosen
for implementation ease
On Tue, 9 Jul 2024 18:06:55 GMT, Andy Goryachev wrote:
>> I can see if I can externalize this or if that would run into issues. Also
>> please note, although technically an API change, it is NOT an accessible API
>> (and so can be removed at any time) because only the permitted types can
>> a
On Tue, 9 Jul 2024 17:58:30 GMT, John Hendrikx wrote:
>> it looks to me readBinary should be static, and writeBinary an instance
>> method - this is a normal pattern. the asymmetry is dictated by the fact
>> that we don't have an instance when reading, so typically read() methods
>> read the
I wonder what other filesystems do? I just want our code to compile in Eclipse
on Linux Mint.
-andy
From: John Hendrikx
Date: Tuesday, July 9, 2024 at 11:04
To: Andy Goryachev , Johan Vos
, openjfx-dev
Subject: Re: [External] : Re: consistent naming for tests
Perhaps, and I guess we're lu
Perhaps, and I guess we're lucky the classes don't fully overlap then...
if encfs just cuts off too long names when reading/writing, then as long
as the filename is still unique enough that is going to work. As soon
as two file names would overlap, they would overwrite each other and
there's n
On Tue, 9 Jul 2024 17:32:29 GMT, Andy Goryachev wrote:
>> I missed something in my above evaluation. The counterpart method
>> `writeBinary` is not `static`. Although that makes sense as in that case
>> you do have an instance you wish to write, it does make the read/write API
>> asymmetric.
1) a buggy implementation coupled with lack of specification creates a certain
expectation
2) bug gets fixed
3) people complain because the feature now works as it should?
I think (and this is my personal opinion, in the absence of a formal
specification) that this works as expected now. The st
> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>
> This can be done with only a minor API break, as `SimpleSelector` and
> `CompoundSelector` were public before. However, these classes could not be
> constructed by 3rd parties. The only way to access them was by doing a
or gradle may not be verifying that the file is actually deleted.
Eclipse allows for online replacement (? or whatever that feature is called
when it can recompile and replace classes in a running vm), so perhaps it is
more diligent when it comes to deleting.
-andy
From: John Hendrikx
Date: T
Then I can't explain why it doesn't fail on Gradle; it must be
generating similar named classes then, but perhaps at a different
location (not on encfs) ?.
--John
On 09/07/2024 19:35, Andy Goryachev wrote:
Anonymous classes are named $1. Nested classes retain their name.
From the ticket:
Well, it is coming as a surprise to many. With the fix for the CSS
caching bug since JavaFX 21, this "normal" behavior is becoming much
more obvious.
Let me repeat one more time:
If I have a Label, and I manually set its text fill with a setter to
YELLOW. In JavaFX 17, when I now add a styles
On Thu, 18 Jan 2024 23:57:05 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' of https://git.openjdk.org/jfx into
>> feature/selectors-to-p
On Fri, 19 Jan 2024 09:33:15 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/Selector.java line 102:
>>
>>> 100:
>>> 101: return new Match(this, s.getPseudoClassStates(), idCount,
>>> styleClassCount);
>>> 102: }
>>
>> I presume you are moving
On Fri, 19 Jan 2024 10:36:57 GMT, John Hendrikx wrote:
>> I'll add the `@since 23`, however it can't be called by anyone except FX
>> itself.
>>
>> Some background: the readBinary/writeBinary methods are ultimately called
>> via the publicly accessible methods `loadBinary` and `saveBinary` in
Anonymous classes are named $1. Nested classes retain their name.
>From the ticket:
https://bugs.openjdk.org/browse/JDK-8334497
Could not delete:
/home/ag/Projects/jfx-2/jfx/rt/modules/javafx.base/testbin/test/javafx/beans/value/ObservableValueFluentBindingsTest$When_flatMap_Called$WithNotNull
Perhaps it is something Eclipse does differently. Normally nested
classed are numbered ($1, $2), so perhaps ecj is compiling these with
differently filenames.
--John
On 09/07/2024 17:37, Andy Goryachev wrote:
Have you tried building in Eclipse on the latest Linux Mint? Or
building on an En
On Tue, 9 Jul 2024 07:23:09 GMT, Ambarish Rapte wrote:
>> The parameter "offset" is not validated in the 2 native methods getRGBImpl()
>> and setRGBImpl() of com.sun.pisces.AbstractSurface (in JAbstractSurface.c).
>> The PR adds the "offset < 0" check to both the methods.
>
> Ambarish Rapte has
On Mon, 8 Jul 2024 13:31:03 GMT, Ambarish Rapte wrote:
> A quick fix to correct the created copyright year.
> The created year in the header was unintentionally modified previously from
> 2021 to 2017.
This pull request has now been integrated.
Changeset: dbda2cce
Author:Ambarish Rapte
U
I know - very few people would like that solution. I would welcome other
suggestions.
The only thing I can say in my defense is that this is only a test, so as long
as the intent is clear we should be fine.
-andy
From: openjfx-dev on behalf of Kevin Rushforth
Date: Tuesday, July 9, 2024 at
https://github.com/andy-goryachev-oracle/jfx/pull/9
Hmm. I don't really like the abbreviations. They would change something
that is self-explanatory to something completely opaque, although I see
you did leave the descriptive name as a comment.
-- Kevin
On 7/9/2024 8:37 AM, Andy Goryache
On Wed, 26 Jun 2024 21:23:34 GMT, Andy Goryachev wrote:
> This might be controversial. I am proposing to remove the Gradle integration
> in the Eclipse config files.
>
> Problem
> ===
> Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle
> cleanly. Every time the
> all styles used in Modena that rely on -fx-base directly or indirectly
> suddenly have a higher priority
I think it works as designed (and as expected).
-andy
From: John Hendrikx
Date: Tuesday, July 9, 2024 at 08:25
To: Andy Goryachev , openjfx-dev
Subject: [External] : Re: CSS Lookups a
On Tue, 9 Jul 2024 12:25:07 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructed
Have you tried building in Eclipse on the latest Linux Mint? Or building on an
EncFS mount?
I don't know why Mint decided to use EncFS knowing its issues, and I suppose I
can try fixing my setup (it's a default Mint installation), but I was quite
surprised myself and thought that it might be j
This might be a combination of Eclipse and eCryptfs. I agree that 143
chars is very short for a max length.
-- Kevin
On 7/9/2024 8:22 AM, John Hendrikx wrote:
On 09/07/2024 16:52, Andy Goryachev wrote:
Two test files consistently generate an error in Eclipse
- ObservableValueFluentBindin
It's not that you can't use -fx-base, but that as it is currently that
all styles used in Modena that rely on -fx-base directly or indirectly
suddenly have a higher priority (above setters) even though you didn't
specifically specify them in your own stylesheet. All such styles are
being eleva
On 09/07/2024 16:52, Andy Goryachev wrote:
Two test files consistently generate an error in Eclipse
- ObservableValueFluentBindingsTest
- LazyObjectBindingTest
I admit I have a weird setup (EncFS on Linux Mint running on MacBook
Pro), and it only manifests itself in Eclipse and not in the gr
On Fri, 28 Jun 2024 10:34:58 GMT, Florian Kirmaier
wrote:
>> In some situations, a part of the SG is no longer rendered.
>> I created a test program that showcases this problem.
>>
>> Explanation:
>>
>> This can happen, when a part of the SG, is covered by another Node.
>> In this part, one no
I generally like descriptive names for test methods (and classes) rather
than encoding the bug ID in the name. A comment with the bug ID is very
helpful, and I would support making that a best practice. If the purpose
of a test is non-obvious, a comment explaining it is a good idea.
-- Kevin
I've used this feature in the past to change the colors in all the controls, so
to me this is the expected behavior.
So in your case (if I got it right), you need to set the direct style on the
label (.setStyle("-fx-text-fill:yellow")) instead of setting the text fill
programmatically. Right?
On Wed, 19 Jun 2024 14:25:52 GMT, Ambarish Rapte wrote:
>> Johan Vos has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - process more reviewer comments
>> - Process reviewer comments
>
> tests/system/src/test/java/test/com/sun/javafx/tk/q
On Tue, 9 Jul 2024 09:13:13 GMT, Johan Vos wrote:
>> tests/system/src/test/java/test/com/sun/javafx/tk/quantum/SystemMenuBarTest.java
>> line 1:
>>
>>> 1: /*
>>
>> This test file is moved from a different location, could do `git mv` instead
>> removing and adding.
>
> I manually reverted the
+1 for comments, links to the JS tickets, and descriptive names.
Speaking of the test names, I wanted to bring up an issue that I've encountered
recently which concerns the use of @Nested -
https://bugs.openjdk.org/browse/JDK-8334497
Two test files consistently generate an error in Eclipse
- Obs
On Tue, 9 Jul 2024 13:03:18 GMT, John Hendrikx wrote:
> I think this is ready for a closer inspection again
I'll put it on my review queue for after Thursday's fork.
> in a strict sense there are API additions in this PR, but because of how
> `sealed` works, they're not accessible except to pe
On Fri, 2 Feb 2024 17:22:22 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add since tags
>
> This PR should probably be moved to draft. Now that the deprecation for
> removal is targeted fo
On Wed, 26 Jun 2024 21:23:34 GMT, Andy Goryachev wrote:
> This might be controversial. I am proposing to remove the Gradle integration
> in the Eclipse config files.
>
> Problem
> ===
> Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle
> cleanly. Every time the
On Mon, 6 May 2024 14:14:05 GMT, eduardsdv wrote:
> This is an alternative solution to the PR:
> https://github.com/openjdk/jfx/pull/1310.
>
> This solution is based on the invariant that if a node is marked as dirty,
> all ancestors must also be marked as dirty and that if an ancestor is mark
> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>
> This can be done with only a minor API break, as `SimpleSelector` and
> `CompoundSelector` were public before. However, these classes could not be
> constructed by 3rd parties. The only way to access them was by doing a
On 09/07/2024 11:33, Johan Vos wrote:
Hi,
An interesting question from John Hendrikx
(https://github.com/openjdk/jfx/pull/1283/#discussion_r1637684395)
probably needs some general discussion on this list.
Afaik, we don't have guidelines for how to name tests (in
https://github.com/openjdk/j
On Tue, 9 Jul 2024 07:23:09 GMT, Ambarish Rapte wrote:
>> The parameter "offset" is not validated in the 2 native methods getRGBImpl()
>> and setRGBImpl() of com.sun.pisces.AbstractSurface (in JAbstractSurface.c).
>> The PR adds the "offset < 0" check to both the methods.
>
> Ambarish Rapte has
On Mon, 8 Jul 2024 22:53:24 GMT, Andy Goryachev wrote:
>> We have many tests that will occasionally fail with a heavily loaded system.
>>
>> The question is whether we can come up with a max delta that we can reliably
>> use that is less than the difference between the default value and the tes
On Tue, 9 Jul 2024 09:09:30 GMT, Johan Vos wrote:
>> tests/system/src/test/java/test/com/sun/javafx/tk/quantum/SystemMenuBarTest.java
>> line 287:
>>
>>> 285:
>>> 286: @Test
>>> 287: public void testJDK8309935() {
>>
>> minor: Not sure what our policies are, but I find test names like
On Tue, 9 Jul 2024 09:06:58 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with one additiona
On Thu, 4 Jul 2024 08:06:39 GMT, eduardsdv wrote:
>> This is an alternative solution to the PR:
>> https://github.com/openjdk/jfx/pull/1310.
>>
>> This solution is based on the invariant that if a node is marked as dirty,
>> all ancestors must also be marked as dirty and that if an ancestor is
On Thu, 4 Jul 2024 08:06:39 GMT, eduardsdv wrote:
>> This is an alternative solution to the PR:
>> https://github.com/openjdk/jfx/pull/1310.
>>
>> This solution is based on the invariant that if a node is marked as dirty,
>> all ancestors must also be marked as dirty and that if an ancestor is
Hi,
An interesting question from John Hendrikx (
https://github.com/openjdk/jfx/pull/1283/#discussion_r1637684395) probably
needs some general discussion on this list.
Afaik, we don't have guidelines for how to name tests (in
https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md#coding-style-
On Mon, 8 Jul 2024 22:51:47 GMT, Kevin Rushforth wrote:
> Bump the version number of JavaFX to 24. I will integrate this to `master` as
> part of forking the `jfx23` stabilization branch, which is scheduled for
> Thursday, July 11, 2024 at 16:00 UTC.
Marked as reviewed by jvos (Reviewer).
---
On Wed, 19 Jun 2024 14:25:52 GMT, Ambarish Rapte wrote:
>> Johan Vos has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - process more reviewer comments
>> - Process reviewer comments
>
> tests/system/src/test/java/test/com/sun/javafx/tk/q
On Wed, 19 Jun 2024 12:39:11 GMT, Ambarish Rapte wrote:
>> Johan Vos has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - process more reviewer comments
>> - Process reviewer comments
>
> tests/system/src/test/java/test/com/sun/javafx/tk/q
On Thu, 13 Jun 2024 07:17:01 GMT, John Hendrikx wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add more type info
>
> tests/system/src/test/java/test/com/sun/javafx/tk/quantum/SystemMenuBarTest.java
> line 287:
>
>
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
Johan Vos has updated the pull request incrementally with one additional commit
since the last revision:
Allow scheduled runn
On Mon, 8 Jul 2024 22:51:47 GMT, Kevin Rushforth wrote:
> Bump the version number of JavaFX to 24. I will integrate this to `master` as
> part of forking the `jfx23` stabilization branch, which is scheduled for
> Thursday, July 11, 2024 at 16:00 UTC.
Marked as reviewed by arapte (Reviewer).
-
> The parameter "offset" is not validated in the 2 native methods getRGBImpl()
> and setRGBImpl() of com.sun.pisces.AbstractSurface (in JAbstractSurface.c).
> The PR adds the "offset < 0" check to both the methods.
Ambarish Rapte has updated the pull request incrementally with one additional
com
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
Johan Vos has updated the pull request incrementally with three additional
commits since the last revision:
- Add changes back
71 matches
Mail list logo
