On Wed, 17 Aug 2022 22:22:02 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
On Wed, 17 Aug 2022 22:22:02 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
On Wed, 17 Aug 2022 22:31:05 GMT, Nir Lisker wrote:
>>> For lucene, you'd need to run
>>>
>>> ```
>>> /bin/sh gradlew getLucene
>>> ```
>>>
>>> to bring in the dependencies which are not a part of the repository.
>>
>> Btw, `gradle apps` will also work.
>
> If there are folders that aren't
On Wed, 17 Aug 2022 22:22:02 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
On Wed, 17 Aug 2022 22:17:30 GMT, Kevin Rushforth wrote:
>> For lucene, you'd need to run
>
>> For lucene, you'd need to run
>>
>> ```
>> /bin/sh gradlew getLucene
>> ```
>>
>> to bring in the dependencies which are not a part of the repository.
>
> Btw, `gradle apps` will also work.
If
On Wed, 17 Aug 2022 22:05:24 GMT, Andy Goryachev wrote:
>> apps/samples/.classpath line 21:
>>
>>> 19: >> path="Ensemble8/lib/lucene-core-7.7.3.jar"/>
>>> 20: >> path="Ensemble8/lib/lucene-grouping-7.7.3.jar"/>
>>> 21: >>
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request
On Wed, 17 Aug 2022 20:30:10 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 additional
>> commits
On Tue, 9 Aug 2022 21:43:04 GMT, Andy Goryachev wrote:
> Thank you all! If there are no more objections, I'd like to get this
> integrated, as it will save me from duplicate branches and continuous
> cherry-picking.
You don't need to do that. Unless 2 branches work on the same code, there
On Tue, 16 Aug 2022 15:58:38 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request with
On Mon, 15 Aug 2022 15:19:38 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request with
On Fri, 12 Aug 2022 23:23:46 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request
On Tue, 9 Aug 2022 17:17:12 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
On Tue, 9 Aug 2022 17:17:12 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request
On Tue, 9 Aug 2022 15:14:15 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>>
On Mon, 8 Aug 2022 20:30:01 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
On Tue, 9 Aug 2022 15:11:49 GMT, Kevin Rushforth wrote:
>> This is up to Kevin. It's changing the build file specifically to remove a
>> warning for Eclipse Mac users. I don't mind. Might need to do the same for
>> the other OS-specific folders.
>
> While not ideal, I suppose it's OK. I'm
On Tue, 9 Aug 2022 00:52:36 GMT, Nir Lisker wrote:
>> I respectfully disagree.
>> I see no harm in creating empty directories in this case if it solves the
>> problem.
>> We can log a bug against eclipse, and it will be fixed in several years, if
>> ever.
>
> This is up to Kevin. It's
On Mon, 8 Aug 2022 15:38:35 GMT, Andy Goryachev wrote:
>> On Linux there is no such warning., neither is there on Windows if I add a
>> non-existing folder (to simulate the ones for other OS's). I posted the
>> screenshots on the mailing list. If Eclipse for Mac is the only one
>> producing
On Sat, 6 Aug 2022 13:23:05 GMT, Kevin Rushforth wrote:
>>> i was thinking of merely creating these two dirs in a new task 'initDirs'
>>> and make 'sdk' depend on that task, in the top level build.gradle. Any
>>> objections
>>
>> I suppose that would be OK. I presume you'll check that the
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request
On Sat, 6 Aug 2022 02:35:10 GMT, Nir Lisker wrote:
>> It probably does not, the file was added in 2013 as a part of
>> RT-31216: Ensure NetBeans development in Gradle build works [Eclipse files]
>>
>> Turns out, eclipse can work with nested projects. Shows multiple hits when
>> looking for
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request
On Mon, 8 Aug 2022 15:31:49 GMT, Nir Lisker wrote:
>> @kevinrushforth :
>> Eclipse does not support conditionals in the .classpath files. The warning
>> cannot be turned off. I see no other way but to create empty folders.
>
> On Linux there is no such warning., neither is there on Windows
On Mon, 8 Aug 2022 15:21:58 GMT, Andy Goryachev wrote:
>> I agree that an optional dependency for a platform-specific generated source
>> directory is a much better solution than creating an empty dir.
>
> @kevinrushforth :
> Eclipse does not support conditionals in the .classpath files. The
On Sat, 6 Aug 2022 13:33:09 GMT, Nir Lisker wrote:
>> I agree that an optional dependency for a platform-specific generated source
>> directory is a much better solution than creating an empty dir.
>
> I don't know what the platform-specific ones are for Mac. I can check on
> Linux if there's
On Sat, 6 Aug 2022 13:22:17 GMT, Kevin Rushforth wrote:
>> As @kleopatra noted below, you need to add the hlsl folders that are built
>> on Windows. Add them as an optional source to avoid errors on other OS's:
>>
>>
>>
>>
>>
>>
>>
>> And the same for
>> ``
>>
On Sat, 6 Aug 2022 13:22:17 GMT, Kevin Rushforth wrote:
>> As @kleopatra noted below, you need to add the hlsl folders that are built
>> on Windows. Add them as an optional source to avoid errors on other OS's:
>>
>>
>>
>>
>>
>>
>>
>> And the same for
>> ``
>>
On Fri, 5 Aug 2022 18:55:15 GMT, Kevin Rushforth wrote:
>> thank you for checking!
>>
>> it looks like there is no way around creating these directories before the
>> 'sdk' task in build.gradle, to silence the missing path warning in eclipse
>> (and adding them back to the .classpath)
>>
>>
On Sat, 6 Aug 2022 02:28:27 GMT, Nir Lisker wrote:
>> As with any multi-stage project, we need to run 'gradle sdk' (or perhaps
>> 'gradle sdk apps' for good measure) to build these directories. Then, in
>> Eclipse, clean all projects. These steps produce a working configuration.
>>
>> I do
On Mon, 1 Aug 2022 19:34:11 GMT, Andy Goryachev wrote:
>> buildSrc/.classpath line 10:
>>
>>> 8: >> path="../build/libs/antlr-runtime-3.1.3.jar"/>
>>> 9: >> path="../build/libs/stringtemplate-3.2.jar"/>
>>> 10: >> path="../build/libs/swt-debug.jar"/>
>>
>> Why does buildSrc need to be a
On Mon, 1 Aug 2022 19:30:28 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/.classpath line 5:
>>
>>> 3:
>>> 4:
>>> 5:
>>
>> How do you not get errors on these on Mac/Linux if they are not declared
>> optional?
>>
>> Additionally, you need the hlsl folders as shown in the mailing
On Fri, 5 Aug 2022 18:25:50 GMT, Andy Goryachev wrote:
> i was thinking of merely creating these two dirs in a new task 'initDirs' and
> make 'sdk' depend on that task, in the top level build.gradle. Any objections
I suppose that would be OK. I presume you'll check that the presence of the
On Fri, 5 Aug 2022 12:01:27 GMT, Jeanette Winzenburg
wrote:
>> hmm .. that's indeed weird - here (on win) both graphics/build/hlsl/Prism
>> and graphics/build/hlsl/Decora are created by running ./gradlew sdk ...
>> will re-check
>
> did re-check (added your fork as remote, checkout this
On Fri, 5 Aug 2022 11:02:50 GMT, Jeanette Winzenburg
wrote:
>> This is puzzling, @kleopatra .
>> I don't see a reference to [hlsl/]Prism or [hlsl/]Decora anywhere. Not in
>> any gradle.build file, not in every file. I don't think these two
>> directories are being built, though I can only
On Thu, 4 Aug 2022 17:07:53 GMT, Andy Goryachev wrote:
>> the tests are fine - it happens if I have a separate project and let that
>> depend on the controls, basic, graphics projects (just the same setup as
>> described on the mailinglist)
>
> This is puzzling, @kleopatra .
> I don't see a
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request with
On Thu, 4 Aug 2022 16:41:20 GMT, Jeanette Winzenburg
wrote:
>> @kleopatra :
>> thank you for your feedback! a couple of questions:
>> 1. which tests are failing?
>> 2. are you testing on windows?
>
> the tests are fine - it happens if I have a separate project and let that
> depend on the
On Thu, 4 Aug 2022 15:33:11 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/.classpath line 5:
>>
>>> 3:
>>> 4:
>>> 5:
>>
>> these two seem not enough for running projects that depend on the graphics
>> project, without the other two (from the original before the [PR
>>
On Thu, 4 Aug 2022 10:53:07 GMT, Jeanette Winzenburg
wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in
On Mon, 1 Aug 2022 18:47:14 GMT, Nir Lisker wrote:
>> - updated .classpath entries in apps/
>> - added utf-8 prefs in .settings/
>
> buildSrc/.classpath line 10:
>
>> 8: > path="../build/libs/antlr-runtime-3.1.3.jar"/>
>> 9: > path="../build/libs/stringtemplate-3.2.jar"/>
>> 10: >
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
One quick comment. Compiling or running the apps should not need any additional
`--add-exports`, `--add-reads`, or `--add-opens` arguments, and they should not
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
@nlisker :
could you please take a look at this draft PR?
with these changes, I get no errors in eclipse, I can run tests and standalone
applications.
I still
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
I'm don't think that this is the right approach with the apps. I think that
each app should be its own project. See the branch I linked in the previous PR.
I
- updated .classpath entries in apps/
- added utf-8 prefs in .settings/
-
Commit messages:
- 8290473: added ColorCube project
- 8290473: eclipse config for apps
Changes: https://git.openjdk.org/jfx/pull/858/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=858=00
Issue:
55 matches
Mail list logo
