[opensc-devel] [PATCH] buffer overflow fix

2012-10-22 Thread Emmanuel Dreyfus
Hi Please check in the fix below. --- src/pkcs11/pkcs11-global.c.orig 2012-10-22 09:11:56.0 +0200 +++ src/pkcs11/pkcs11-global.c 2012-10-22 09:12:14.0 +0200 @@ -43,9 +43,9 @@ #if defined(HAVE_PTHREAD) && defined(PKCS11_THREAD_LOCKING) #include CK_RV mutex_create(void **mu

Re: [opensc-devel] Patch for pkcs15init/pkcs15-lib

2012-09-01 Thread Viktor Tarasov
Hello, Le 31/08/2012 16:59, Andreas Schwier (ML) a écrit : > while we are working on write support for the SmartCard-HSM we've come > across some issues in pkcs15-lib. The issues are mostly related to the > isolation between the pkcs15 framework and the emulation layer. We've > authored a patch for

[opensc-devel] Patch for pkcs15init/pkcs15-lib

2012-08-31 Thread Andreas Schwier (ML)
Dear all, while we are working on write support for the SmartCard-HSM we've come across some issues in pkcs15-lib. The issues are mostly related to the isolation between the pkcs15 framework and the emulation layer. We've authored a patch for the issues. Because we can not oversee the impact of o

Re: [opensc-devel] patch base in gerrit

2012-03-27 Thread Ludovic Rousseau
Le 27 mars 2012 10:50, "Magosányi, Árpád" a écrit : > Hi! > > We have the following symptoms: > - some modifications come as a set of patches. Gerrit lets you review a > patch a time. > - sometimes it is not even clear what are really the changes > - sometimes approved patches fail to apply > > It

[opensc-devel] patch base in gerrit

2012-03-27 Thread Magosányi, Árpád
Hi! We have the following symptoms: - some modifications come as a set of patches. Gerrit lets you review a patch a time. - sometimes it is not even clear what are really the changes - sometimes approved patches fail to apply It would be nice if - all patches in gerrit would be shown as relative

Re: [opensc-devel] patch quality standards?

2012-03-24 Thread Magosányi, Árpád
On 03/24/2012 09:45 AM, Ludovic Rousseau wrote: > Most of your remarks were already in > https://www.opensc-project.org/opensc/wiki/DevelopmentPolicy#Movingmasterforward > I added what was missing. Thanks Thank you, I added the link to the CodeReview page.

Re: [opensc-devel] patch quality standards?

2012-03-24 Thread Ludovic Rousseau
Le 24 mars 2012 00:43, "Magosányi, Árpád" a écrit : > Looking at https://www.opensc-project.org/codereview/#/c/150/ , which is > a patch which is overwritten by a later patch in gerrit, I started to > wonder again about quality standards. And this: > http://lwn.net/Articles/328438/ > And there sho

[opensc-devel] patch quality standards?

2012-03-23 Thread Magosányi, Árpád
Looking at https://www.opensc-project.org/codereview/#/c/150/ , which is a patch which is overwritten by a later patch in gerrit, I started to wonder again about quality standards. And this: http://lwn.net/Articles/328438/ And there should be others. This is what I have gathered so far: - whitespac

[opensc-devel] [PATCH] OpenCT: IFD for non-CCID iKey4000

2012-03-01 Thread Andy Walls
On Sun, 2012-02-26 at 19:15 -0500, Andy Walls wrote: > Anthony Foiani wrote: > > >Greetings! > > > >I found your message from last fall on the OpenSC devel list: > > > >http://www.opensc-project.org/pipermail/opensc-devel/2011-October/017307.html > > > >Have you been able to make any progress wit

Re: [opensc-devel] Patch: parsing prKDF - linking PIN to Private Key

2012-01-06 Thread Viktor Tarasov
Le 04/01/2012 15:30, Viktor Tarasov a écrit : > Le 04/01/2012 11:30, Hunter William a écrit : > My first suggestion is to set authId when parsing the contents of PrKDF. Ok, for now that should work fine, although longer term a better solution may be needed. Note that the AuthID may al

Re: [opensc-devel] Patch: AT_SIGNATURE/AT_KEYEXCHANGE issues with minidriver

2012-01-06 Thread Viktor Tarasov
Le 04/01/2012 17:07, Viktor Tarasov a écrit : > Le 04/01/2012 16:38, Hunter William a écrit : >> Secondly, I can't see the purpose of allowing one key to be available both as an AT_SIGNATURE and as an AT_KEYEXCHANGE key. In fact, in my testing, if this is done, only signatures work,

Re: [opensc-devel] Patch: AT_SIGNATURE/AT_KEYEXCHANGE issues with minidriver

2012-01-04 Thread Viktor Tarasov
Le 04/01/2012 16:38, Hunter William a écrit : > Hi Viktor, > > Thanks for your response. > >>> The first issue is that as per the IAS/ECC specifications, my key >>> is enabled for KeyDecipher or Unwrap usage, and not Decrypt. However, >>> it should still be made available as an AT_KEYEXCHANGE key

Re: [opensc-devel] Patch: AT_SIGNATURE/AT_KEYEXCHANGE issues with minidriver

2012-01-04 Thread Hunter William
Hi Viktor, Thanks for your response. > > The first issue is that as per the IAS/ECC specifications, my key > > is enabled for KeyDecipher or Unwrap usage, and not Decrypt. However, > > it should still be made available as an AT_KEYEXCHANGE key, so that > > the unwrap is possible. > > Sorry, i

Re: [opensc-devel] Patch: AT_SIGNATURE/AT_KEYEXCHANGE issues with minidriver

2012-01-04 Thread Viktor Tarasov
Hello William, Le 04/01/2012 11:44, Hunter William a écrit : > The commit made on the 25 Dec - "minidriver: allow double key usage", on the > secure-messaging > branch introduced some issues for my testing of an IAS/ECC card. > > The first issue is that as per the IAS/ECC specifications, my key

Re: [opensc-devel] Patch: parsing prKDF - linking PIN to Private Key

2012-01-04 Thread Viktor Tarasov
Le 04/01/2012 11:30, Hunter William a écrit : My first suggestion is to set authId when parsing the contents of PrKDF. >>> Ok, for now that should work fine, although longer term a better solution >>> may be needed. Note that the AuthID may also be specified in terms of a >>> security environm

Re: [opensc-devel] Patch: SHA1 hash for GUID

2012-01-04 Thread Viktor Tarasov
Hello William, Le 04/01/2012 11:22, Hunter William a écrit : > As previously discussed (see thread - > http://www.opensc-project.org/pipermail/opensc-devel/2011-December/017486.html), > please find > attached an internal public domain implementation of the SHA1 algorithm in > order to calculat

[opensc-devel] Patch: AT_SIGNATURE/AT_KEYEXCHANGE issues with minidriver

2012-01-04 Thread Hunter William
Hi Viktor/all The commit made on the 25 Dec - "minidriver: allow double key usage", on the secure-messaging branch introduced some issues for my testing of an IAS/ECC card. The first issue is that as per the IAS/ECC specifications, my key is enabled for KeyDecipher or Unwrap usage, and not De

[opensc-devel] Patch: parsing prKDF - linking PIN to Private Key

2012-01-04 Thread Hunter William
> >> My first suggestion is to set authId when parsing the contents of PrKDF. > > Ok, for now that should work fine, although longer term a better solution > > may be needed. Note that the AuthID may also be specified in terms of a > > security environment, which makes things a lot more complicated

[opensc-devel] Patch: SHA1 hash for GUID

2012-01-04 Thread Hunter William
Hi Viktor/all As previously discussed (see thread - http://www.opensc-project.org/pipermail/opensc-devel/2011-December/017486.html), please find attached an internal public domain implementation of the SHA1 algorithm in order to calculate key GUID's for the minidriver without depending on Open

Re: [opensc-devel] [PATCH 0/5] Remove libltdl

2011-12-14 Thread Peter Stuge
Alon Bar-Lev wrote: > libltdl is linked against opensc long before I touched the build system. I was a strong proponent back in the day. > I suggest the following patchset to completely remove libltdl. Looks fine to me. //Peter ___ opensc-devel mail

[opensc-devel] [PATCH 1/5] Remove libltdl: Remove ltld references

2011-12-09 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev --- configure.ac | 18 -- src/common/Makefile.am |1 - src/common/libpkcs11.c |6 src/common/libscdl.c | 57 +-- src/libopensc/Makefile.am |5 +-- src/libopensc/ctx.c

[opensc-devel] [PATCH 2/5] Remove libltdl: Detect libdl

2011-12-09 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev --- configure.ac |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 4e01231..d871657 100644 --- a/configure.ac +++ b/configure.ac @@ -268,6 +268,14 @@ AC_CHECK_LIB( ) if test "${WIN32}" = "no"; then +

[opensc-devel] [PATCH 4/5] Remove libltdl: Cleanup libscdl

2011-12-09 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev --- src/common/libscdl.c |9 ++--- src/common/libscdl.h |3 +++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/common/libscdl.c b/src/common/libscdl.c index e4746ab..b66dbd5 100644 --- a/src/common/libscdl.c +++ b/src/common/libscdl.c @

[opensc-devel] [PATCH 5/5] Remove libltdl: Cleanup libscdl usage at Microsoft VC build

2011-12-09 Thread Alon Bar-Lev
Untested, I don't have the environment, Martin, please test. Signed-off-by: Alon Bar-Lev --- src/common/Makefile.mak |2 +- src/pkcs11/Makefile.mak |2 +- src/tools/Makefile.mak |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/common/Makefile.mak b/src/commo

[opensc-devel] [PATCH 3/5] Remove libltdl: Use libscdl

2011-12-09 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev --- src/common/Makefile.am |3 +-- src/libopensc/Makefile.am|1 + src/libopensc/ctx.c |1 + src/libopensc/internal.h |1 - src/libopensc/pkcs15-syn.c |1 + src/libopensc/pkcs15.c |1 + src/libopensc/reader-ctapi.c

[opensc-devel] [PATCH 0/5] Remove libltdl

2011-12-09 Thread Alon Bar-Lev
libltdl is linked against opensc long before I touched the build system. There are some minor advantages of using libltdl, the most relevant one is the common usage at Windows and *NIX. The other advantages relates to systems that do not support dynamic loading at all. I don't think that OpenSC i

[opensc-devel] [PATCH] Fix CT_Init with wrong params while using 2 tokens Aladdin eToken PRO 64

2011-09-20 Thread Iuri Diniz
On Mon, Sep 19, 2011 at 6:14 PM, Iuri Diniz wrote: > I've found that ct_card_lock is returning -7 (IFD_ERROR_LOCKED) for the > second card 'CT_init (ctn=1, pn=0)' > while is returning IFD_SUCCESS for the first one 'CT_init (ctn=0, pn=0)' > (why?) > I've found the error :D and I did a dummy patch

[opensc-devel] PATCH: serbian national EID

2011-09-13 Thread Viktor Gal
Hi, ::: here are two little patches that add basic support for the serbian national EID. I've just committed them as well to my opensc repository fork at github (https://github.com/vigsterkr/OpenSC). any comments/remarks are more than welcome! ::: there's still a lot to debug and implement, e.

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-08-26 Thread Ludovic Rousseau
2011/8/26 Viktor Tarasov : > Le 26/08/2011 16:40, Ludovic Rousseau a écrit : >> >> 2011/8/25 Viktor Tarasov: >>> >>> In the OpenSC context the detached reader/token is unknown before the >>> SCardGetStatusChange() called. >>> In windows, XP or Vista, the ScardGetStatusChange called for unknown >>>

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-08-26 Thread Viktor Tarasov
Le 26/08/2011 16:40, Ludovic Rousseau a écrit : > 2011/8/25 Viktor Tarasov: >> In the OpenSC context the detached reader/token is unknown before the >> SCardGetStatusChange() called. >> In windows, XP or Vista, the ScardGetStatusChange called for unknown reader >> returns SCARD_E_NO_READERS_AVAILAB

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-08-26 Thread Ludovic Rousseau
2011/8/25 Viktor Tarasov : > In the OpenSC context the detached reader/token is unknown before the > SCardGetStatusChange() called. > In windows, XP or Vista, the ScardGetStatusChange called for unknown reader > returns SCARD_E_NO_READERS_AVAILABLE. > > The last revision of pcsc-lite, in such a cas

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-08-25 Thread Viktor Tarasov
Le 11/08/2011 13:29, Ludovic Rousseau a écrit : > 2011/8/11 Viktor Tarasov: >> Le 08/08/2011 16:31, Ludovic Rousseau a écrit : >>> 2011/7/19 Viktor Tarasov: Le 18/07/2011 14:52, Ludovic Rousseau a écrit : > 2011/7/10 Viktor Tarasov: >> Hi, > Hello, > >> there is patch propo

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-08-11 Thread Ludovic Rousseau
2011/8/11 Viktor Tarasov : > Le 08/08/2011 16:31, Ludovic Rousseau a écrit : >> >> 2011/7/19 Viktor Tarasov: >>> >>> Le 18/07/2011 14:52, Ludovic Rousseau a écrit : 2011/7/10 Viktor Tarasov: > > Hi, Hello, > there is patch proposal to treat properly the 'detach

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-08-11 Thread Viktor Tarasov
Le 08/08/2011 16:31, Ludovic Rousseau a écrit : > 2011/7/19 Viktor Tarasov: >> Le 18/07/2011 14:52, Ludovic Rousseau a écrit : >>> 2011/7/10 Viktor Tarasov: Hi, >>> Hello, >>> there is patch proposal to treat properly the 'detach token(reader)' event and to remove the slots asso

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-08-08 Thread Ludovic Rousseau
2011/7/19 Viktor Tarasov : > Le 18/07/2011 14:52, Ludovic Rousseau a écrit : >> >> 2011/7/10 Viktor Tarasov: >>> >>> Hi, >> >> Hello, >> >>> there is patch proposal to treat properly the 'detach token(reader)' >>> event >>> and to remove the slots associated to the removed token. >>> >>> Tested in

[opensc-devel] Patch: Install a config file so that opensc pkcs11 module works with p11-kit

2011-08-01 Thread Stef Walter
Hi all, p11-kit [1] has now has stabilized and is used by gnutls, gnome-keyring, and soon glib. Among other things, it helps by setting up a standard PkCS#11 configuration format. I'd like to suggest that OpenSC installs a config file in the right place so that it works with p11-kit. The config f

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-07-22 Thread Ludovic Rousseau
2011/7/22 Viktor Tarasov : > In attachment there are parts of the debug logs coming from the 'hot-plug' > pkcs#11 tests. > The logs are extracted around the test of C_WaitForSlotEvent(), slightly > modified to allow blocking mode . > > For windows there are traces of two tests: detachment of unique

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-07-22 Thread Viktor Tarasov
Le 20/07/2011 19:30, Viktor Tarasov a écrit : Le 20/07/2011 19:04, Ludovic Rousseau a écrit : 2011/7/19 Viktor Tarasov: Le 18/07/2011 14:52, Ludovic Rousseau a écrit : 2011/7/10 Viktor Tarasov: Hi, Hello, there is patch proposal to treat properly the 'detach token(reader)' event and to rem

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-07-20 Thread Viktor Tarasov
Le 20/07/2011 19:04, Ludovic Rousseau a écrit : > 2011/7/19 Viktor Tarasov: >> Le 18/07/2011 14:52, Ludovic Rousseau a écrit : >>> 2011/7/10 Viktor Tarasov: Hi, >>> Hello, >>> there is patch proposal to treat properly the 'detach token(reader)' event and to remove the slots asso

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-07-20 Thread Ludovic Rousseau
2011/7/19 Viktor Tarasov : > Le 18/07/2011 14:52, Ludovic Rousseau a écrit : >> >> 2011/7/10 Viktor Tarasov: >>> >>> Hi, >> >> Hello, >> >>> there is patch proposal to treat properly the 'detach token(reader)' >>> event >>> and to remove the slots associated to the removed token. >>> >>> Tested in

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-07-19 Thread Viktor Tarasov
Le 18/07/2011 14:52, Ludovic Rousseau a écrit : > 2011/7/10 Viktor Tarasov: >> Hi, > Hello, > >> there is patch proposal to treat properly the 'detach token(reader)' event >> and to remove the slots associated to the removed token. >> >> Tested in Linux and windows. >> 'SCardGetStatusChange' have d

Re: [opensc-devel] Patch: remove slots of detached reader(token)

2011-07-18 Thread Ludovic Rousseau
2011/7/10 Viktor Tarasov : > Hi, Hello, > there is patch proposal to treat properly the 'detach token(reader)' event > and to remove the slots associated to the removed token. > > Tested in Linux and windows. > 'SCardGetStatusChange' have different behavior in Linux and Windows. > Needs to be stu

[opensc-devel] PATCH: fix size_t/int in utils.c::util_hex_dump()

2011-07-17 Thread Juan Antonio Martinez
A tiny patch that fixes several warnings on signedess and lost of precision: --- diff --git a/src/tools/util.c b/src/tools/util.c index b146567..53989f3 100644 --- a/src/tools/util.c +++ b/src/tools/util.c @@ -136,9 +136,9 @@ void util_print_

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-12 Thread Thomas Grenman
Hi The attached patch works! Is this now something you could agree to commit to upcoming versions of OpenSC? And I will try to find someone at VRK who could tell me why the returned SW is violating the specifications for the SELECT command. br, Thomas On Tue, 12 Jul 2011, Martin Paljak wrote:

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-12 Thread Martin Paljak
Hello, On Jul 11, 2011, at 10:53 , Thomas Grenman wrote: > > I emailed the patch to Martin and CC to the list. The email never got > through to the list tough. Do not know why... You sent the e-mail from an address which was not subscribed and where messages bounced back from (like the notifica

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-12 Thread Martin Paljak
Hello, On Jul 11, 2011, at 14:46 , Viktor Tarasov wrote: > Hello, > > Le 11/07/2011 09:53, Thomas Grenman a écrit : >> One additional solution would be to patch the card specific select_file() > > Probably it would be the best solution . Attached is a version of the setcos specific select file

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-11 Thread Viktor Tarasov
Hello, Le 11/07/2011 09:53, Thomas Grenman a écrit : > One additional solution would be to patch the card specific select_file() Probably it would be the best solution . Kind regards, Viktor. ___ opensc-devel mailing list opensc-devel@lists.opensc-p

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-11 Thread Thomas Grenman
Hi! > As for me, > the cheap and close to the actual logic would be, inside the sc_enum_apps, > replace any error of selection of 2F00 by the SC_ERROR_FILE_NOT_FOUND. > Something like this: Patching dir.c alone is not enough. The same error (-1216) will come back at the next stage when pkcs15-

[opensc-devel] Patch: remove slots of detached reader(token)

2011-07-10 Thread Viktor Tarasov
Hi, there is patch proposal to treat properly the 'detach token(reader)' event and to remove the slots associated to the removed token. Tested in Linux and windows. 'SCardGetStatusChange' have different behavior in Linux and Windows. Needs to be studied and validated for Mac. https://github.com/

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-09 Thread Viktor Tarasov
Hello, Le 08/07/2011 08:56, Martin Paljak a écrit : > Viktor, any comments? As for me the 'most rigorous' solution would be the one proposed by Juan Antonio -- card specific SW checking. Checking for error SC_ERROR_FILE_NOT_FOUND and it's special treatment are frequently used in OpenSC, especia

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-07 Thread Martin Paljak
Hello, Viktor, any comments? Does the change make sense ? On Jul 7, 2011, at 09:01 , Thomas Grenman wrote: > Hi > > I just tested [2] and it works. Thanks! > > - Thomas > > On Wed, 6 Jul 2011, Martin Paljak wrote: > >> Hello, >> >> >> Here's an alternative approach [1]: requiring that sc_s

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-06 Thread Thomas Grenman
Hi I just tested [2] and it works. Thanks! - Thomas On Wed, 6 Jul 2011, Martin Paljak wrote: > Hello, > > > Here's an alternative approach [1]: requiring that sc_select_file > invocations would explicitly be successful for continuing. > > Does this work for you? To be honest the binding procedu

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-06 Thread Martin Paljak
Hello, Here's an alternative approach [1]: requiring that sc_select_file invocations would explicitly be successful for continuing. Does this work for you? To be honest the binding procedure could be improved further, it is somewhat difficult to follow. Look for builds with commit ID 9bcda91808

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my?? FINEID-card work

2011-07-06 Thread Martin Paljak
Hello, On Thu, Jun 30, 2011 at 22:13, Frank Morgner wrote: > Hi! > >> sc_enum_apps fails because sc_select_file returns an "unknown" SW 6A88 >> which gets translated to SC_ERROR_DATA_OBJECT_NOT_FOUND in iso7816.c. >> Looking at ISO7816-4, it is not listed as a "relevant SW" for SELECT >> command

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my?? FINEID-card work

2011-06-30 Thread Juan Antonio Martinez
El jue, 30-06-2011 a las 20:58 +0200, Frank Morgner escribió: > On Thursday, June 30 at 07:08PM, Juan Antonio Martinez wrote: > > In OpenDNIe[1] we had a similar problem: on SM establishment we need to > > override default meaning of some error codes, to get a common SM error > > and parse it. I so

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my?? FINEID-card work

2011-06-30 Thread Frank Morgner
Hi! > sc_enum_apps fails because sc_select_file returns an "unknown" SW 6A88 > which gets translated to SC_ERROR_DATA_OBJECT_NOT_FOUND in iso7816.c. > Looking at ISO7816-4, it is not listed as a "relevant SW" for SELECT > command, which is failing (which also makes sense to me) Regarding the erro

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my?? FINEID-card work

2011-06-30 Thread Frank Morgner
On Thursday, June 30 at 07:08PM, Juan Antonio Martinez wrote: > In OpenDNIe[1] we had a similar problem: on SM establishment we need to > override default meaning of some error codes, to get a common SM error > and parse it. I solved it by mean of providing own check_sw() at > card_ops function poi

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-06-30 Thread Juan Antonio Martinez
El jue, 30-06-2011 a las 19:58 +0300, Thomas Grenman escribió: > Hi > > > It seems to me that the card (or the relevant applet) is programmed to > > return 6A88 instead of 6A82. Just to be sure: what happens if you try > > opensc-explorer and try to cd to any non-existent DF with debug on, > > Ye

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-06-30 Thread Thomas Grenman
Hi > It seems to me that the card (or the relevant applet) is programmed to > return 6A88 instead of 6A82. Just to be sure: what happens if you try > opensc-explorer and try to cd to any non-existent DF with debug on, Yes, the error code comes from the card. And just as you expected, opensc-expl

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-06-30 Thread Martin Paljak
Hello, So this is the interesting part from the log: On Thu, Jun 30, 2011 at 17:21, Thomas Grenman wrote: > 0xb779b8d0 16:59:59.149 [pkcs15-tool] dir.c:141:sc_enum_apps: called > 0xb779b8d0 16:59:59.149 [pkcs15-tool] card.c:571:sc_select_file: called; > type=2, path=3f002f00 > 0xb779b8d0 16:59:5

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-06-30 Thread Martin Paljak
Moi, On Thu, Jun 30, 2011 at 08:11, Thomas Grenman wrote: > Hello > > Please consider including the patch below into upcoming versions of > OpenSC. This patch will make OpenSC work with my fairly new FINEID-card > (http://www.opensc-project.org/opensc/wiki/FinnishEid). My particular card > is not

[opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-06-29 Thread Thomas Grenman
Hello Please consider including the patch below into upcoming versions of OpenSC. This patch will make OpenSC work with my fairly new FINEID-card (http://www.opensc-project.org/opensc/wiki/FinnishEid). My particular card is not for private citizens but for organisations. I have only modified 'l

Re: [opensc-devel] Patch for libp11 to fix compatibility with AET SafeSign PKCS#11 library

2011-06-17 Thread Alon Bar-Lev
Right. But you forgot to free the memory. I've applied similar solution at r201. On Fri, Jun 17, 2011 at 2:55 PM, Jonathan Giannuzzi wrote: > Hello, > When using libp11 to wrap around the AET SafeSign PKCS#11 library, C_GetInfo > fails with CKR_MUTEX_BAD. This is because an empty CK_C_INITIALIZE_

[opensc-devel] Patch for libp11 to fix compatibility with AET SafeSign PKCS#11 library

2011-06-17 Thread Jonathan Giannuzzi
Hello, When using libp11 to wrap around the AET SafeSign PKCS#11 library, C_GetInfo fails with CKR_MUTEX_BAD. This is because an empty CK_C_INITIALIZE_ARGS structure is passed to C_Initialize. I made a change in PKCS11_CTX_load so that when no init_args have been set, no CK_C_INITIALIZE_ARGS is g

[opensc-devel] Patch series for pkcs15-profile documentation

2011-06-04 Thread Peter Marschall
Hi, please find my latest patches for the pkcs15-profile documentation on: https://github.com/marschap/OpenSC/commits/doctools-20110604 Here's what they do: [PATCH 1/2] pkcs15-profile.xml: remove empty SYNOPSIS section This makes the man page look better by removing the empty SYNOPSIS section

[opensc-devel] Patch series for OpenPGP card driver

2011-06-03 Thread Peter Marschall
Hi, please find my latest patches for the OpenGP card driver on: https://github.com/marschap/OpenSC/commits/OpenPGP-20110603 Here's what they do: [PATCH 1/8] OpenPGP: fix algorithms & key lengths calculation Also include forgotten DO C3 in keylength calculation. It contains the parameters for

[opensc-devel] Patch series for opensc-tool & opensc-explorer

2011-06-03 Thread Peter Marschall
Hi, please find my latest patches for opensc-tool & opensc-explorer on: https://github.com/marschap/OpenSC/commits/tools-20110603 I am not attaching them here as they may be too big for the mailing list, and according to other posts on the mailing list, OpenSC is slowly migrating to git anyway

[opensc-devel] [PATCH ] Re: eidenv: a proposal

2011-04-21 Thread Juan Antonio Martinez
El mar, 19-04-2011 a las 18:26 +0300, Martin Paljak escribió: > Hello, > On Apr 19, 2011, at 18:08 , Juan Antonio Martinez wrote: > > Studing eidenv code and how I did it in opendnie, I suggest a change to > > make eidenv.c card independent, and rely in each card driver the work of > > get (when av

Re: [opensc-devel] [PATCH] [libp11] pkcs11_init_slot: Do not fail if a slot can't be initialized

2010-11-29 Thread Camille Moncelier
On Thu, 18 Nov 2010 11:34:30 +0100 Ludovic Rousseau wrote: > New patch proposed attached. > > Since I am not the maintainer of libp11 I do not want to commit a > patch with possible bad side effects. The news patch looks fine for me, I didn't had the time to test it yet (I'm quite busy right now

Re: [opensc-devel] [PATCH] [libp11] pkcs11_init_slot: Do not fail if a slot can't be initialized

2010-11-18 Thread Ludovic Rousseau
2010/11/16 Ludovic Rousseau : > 2010/11/4 Camille Moncelier : >> On Thu, 4 Nov 2010 09:37:30 +0100 >> Ludovic Rousseau wrote: >> >>> 2010/11/3 Camille Moncelier : >>> > In some case readers can be wired to always return >>> > CKF_TOKEN_PRESENT even when there's no card (Because there's no >>> > me

Re: [opensc-devel] [PATCH] [libp11] pkcs11_init_slot: Do not fail if a slot can't be initialized

2010-11-16 Thread Ludovic Rousseau
2010/11/4 Camille Moncelier : > On Thu, 4 Nov 2010 09:37:30 +0100 > Ludovic Rousseau wrote: > >> 2010/11/3 Camille Moncelier : >> > In some case readers can be wired to always return >> > CKF_TOKEN_PRESENT even when there's no card (Because there's no >> > mechanical contacts for card insertion, l

Re: [opensc-devel] [PATCH] [libp11] pkcs11_init_slot: Do not fail if a slot can't be initialized

2010-11-04 Thread Camille Moncelier
On Thu, 4 Nov 2010 09:37:30 +0100 Ludovic Rousseau wrote: > 2010/11/3 Camille Moncelier : > > In some case readers can be wired to always return > > CKF_TOKEN_PRESENT even when there's no card (Because there's no > > mechanical contacts for card insertion, like some SIMcard readers). > > So why

Re: [opensc-devel] [PATCH] [libp11] pkcs11_init_slot: Do not fail if a slot can't be initialized

2010-11-04 Thread Ludovic Rousseau
2010/11/3 Camille Moncelier : > In some case readers can be wired to always return > CKF_TOKEN_PRESENT even when there's no card (Because there's no > mechanical contacts for card insertion, like some SIMcard readers). So why connect the SIM card reader without any smart card inside? The smart car

[opensc-devel] [PATCH] [libp11] pkcs11_init_slot: Do not fail if a slot can't be initialized

2010-11-03 Thread Camille Moncelier
In some case readers can be wired to always return CKF_TOKEN_PRESENT even when there's no card (Because there's no mechanical contacts for card insertion, like some SIMcard readers). This patch fix the issue of PKCS11_enumerate_slots() failing because one of the readers reported a token present bu

Re: [opensc-devel] [PATCH ] About SM and wrapping of sc_transmit_apdu()

2010-10-30 Thread Viktor TARASOV
Juan Antonio Martinez wrote: > El mar, 26-10-2010 a las 12:52 +0200, Juan Antonio Martinez escribió: > > >> No need to change iso7816, just check for hooks in card driver >> I'll think some way to encode this. >> > > Attached comes my patch proposal > I've tried to be as less intrussive as

Re: [opensc-devel] [PATCH ] About SM and wrapping of sc_transmit_apdu()

2010-10-28 Thread Juan Antonio Martinez
El jue, 28-10-2010 a las 09:08 +0200, Peter Stuge escribió: > Juan Antonio Martinez wrote: > > > No need to change iso7816, just check for hooks in card driver > > > I'll think some way to encode this. > > > > Attached comes my patch proposal > > I've tried to be as less intrussive as posible > >

Re: [opensc-devel] [PATCH ] About SM and wrapping of sc_transmit_apdu()

2010-10-28 Thread Peter Stuge
Juan Antonio Martinez wrote: > > No need to change iso7816, just check for hooks in card driver > > I'll think some way to encode this. > > Attached comes my patch proposal > I've tried to be as less intrussive as posible I think this approach is really clean and simple. Nice! > +++ src/libopen

[opensc-devel] [PATCH ] About SM and wrapping of sc_transmit_apdu()

2010-10-26 Thread Juan Antonio Martinez
El mar, 26-10-2010 a las 12:52 +0200, Juan Antonio Martinez escribió: > No need to change iso7816, just check for hooks in card driver > I'll think some way to encode this. Attached comes my patch proposal I've tried to be as less intrussive as posible Comments, suggestions and blames are wellco

Re: [opensc-devel] Patch to MyEID profile

2010-09-26 Thread Aventra development
Hi, > -Original Message- > From: Viktor TARASOV > > Hi, > > Aventra development wrote: > > > > Here is a small patch that modifies the MyEID profile. This profile > > now initializes the cards like we want them (users are of course free > > to modify the profile to get cards like they wa

Re: [opensc-devel] Patch to MyEID profile

2010-09-25 Thread Viktor TARASOV
Hi, Aventra development wrote: Here is a small patch that modifies the MyEID profile. This profile now initializes the cards like we want them (users are of course free to modify the profile to get cards like they want, but we think this should be the default). I suppose the ACL for card i

[opensc-devel] Patch to MyEID profile

2010-09-24 Thread Aventra development
Hi, Here is a small patch that modifies the MyEID profile. This profile now initializes the cards like we want them (users are of course free to modify the profile to get cards like they want, but we think this should be the default). I suppose the ACL for card initialization (clearing car

Re: [opensc-devel] Patch to let carmod working after multiple reader system removal.

2010-09-24 Thread francois . leblanc
De : Martin Paljak A: François Leblanc Cc : opensc-devel@lists.opensc-project.org Date: 24/09/2010 10:14 Objet : Re: [opensc-devel] Patch to let carmod working after multiple reader system removal. >Hello François, > >Can you please configure you mail client to not send HTML messag

Re: [opensc-devel] Patch to let carmod working after multiple reader system removal.

2010-09-24 Thread Martin Paljak
Hello François, Can you please configure you mail client to not send HTML messages to the list? On Sep 24, 2010, at 9:08 AM, francois.lebl...@cev-sa.com wrote: > >Please describe how the driver is used by the minidriver, how it differs > >from "normal" OpenSC use, what are the biggest and most

[opensc-devel] Patch to let carmod working after multiple reader system removal.

2010-09-23 Thread francois . leblanc
De : Martin Paljak A: francois.lebl...@cev-sa.com Cc : opensc-devel@lists.opensc-project.org Date: 23/09/2010 15:37 Objet : Re: [opensc-devel] Patch to let carmod working after multiple reader system removal. >Hello, > >On Sep 23, 2010, at 3:37 PM, francois.lebl...@cev-sa.

Re: [opensc-devel] Patch to let carmod working after multiple reader system removal.

2010-09-23 Thread Martin Paljak
Hello, On Sep 23, 2010, at 3:37 PM, francois.lebl...@cev-sa.com wrote: > #ifdef ENABLE_PCSC > ctx->reader_driver = sc_get_pcsc_driver(); > +#ifdef ENABLE_CARDMOD > +if(strcmp(ctx->app_name, "cardmod") == 0) { > +ctx->reader_driver = sc_get_cardmod_driv

[opensc-devel] Patch to let carmod working after multiple reader system removal.

2010-09-23 Thread francois . leblanc
Hello, I've this patch to fix issue after 4709 changeset, The main impact on trunk libopensc is in hadding following code #ifdef ENABLE_PCSC ctx->reader_driver = sc_get_pcsc_driver(); + #ifdef ENABLE_CARDMOD + if(strcmp(ctx->app_name, "cardmod") == 0) { + ctx

Re: [opensc-devel] [PATCH] fix buffer overflow in pkcs15-itacns.c

2010-08-16 Thread Ludovic Rousseau
2010/8/16 Emanuele Pucciarelli : > Hi Kalev, > >> gcc warns about a potential buffer overflow: > > […] > > Thanks! I'll fix that in both places (lines 540 and 552). > > To be honest, no overflow should ever happen, as the label is always a > static string; nevertheless, those lines are ugly, and I

Re: [opensc-devel] [PATCH] fix buffer overflow in pkcs15-itacns.c

2010-08-16 Thread Emanuele Pucciarelli
Hi Kalev, > gcc warns about a potential buffer overflow: […] Thanks! I'll fix that in both places (lines 540 and 552). To be honest, no overflow should ever happen, as the label is always a static string; nevertheless, those lines are ugly, and I think gcc is right in complaining about that. :)

[opensc-devel] [PATCH] fix buffer overflow in pkcs15-itacns.c

2010-08-16 Thread Kalev Lember
gcc warns about a potential buffer overflow: In file included from /usr/include/string.h:642:0, from pkcs15-itacns.c:38: In function 'strncat', inlined from 'itacns_add_keyset.clone.3' at pkcs15-itacns.c:540:9: /usr/include/bits/string3.h:154:3: warning: call to __builtin___

Re: [opensc-devel] Patch to display correct EF ACLs in opensc-explorer

2010-08-14 Thread Martin Paljak
Hello, On Aug 8, 2010, at 9:50 PM, Emanuele Pucciarelli wrote: > Hello, > > it seems to me that ACL handling in opensc-explorer is wrong. It > assumes SC_AC_OP_* flags are numbered in the same order as in > opensc-explorer.c:436 (used to display DF ACLs), which is correct. But > then, a few line

[opensc-devel] Patch to display correct EF ACLs in opensc-explorer

2010-08-09 Thread Emanuele Pucciarelli
Hello, it seems to me that ACL handling in opensc-explorer is wrong. It assumes SC_AC_OP_* flags are numbered in the same order as in opensc-explorer.c:436 (used to display DF ACLs), which is correct. But then, a few lines later, it employs a different label list for EF ACLs, which IMHO is wrong.

Re: [opensc-devel] [PATCH] change int to CK_RV to match prototype declaration

2010-06-16 Thread Ludovic Rousseau
2010/6/13 Martin Vogt : > Hello, > > attached are three patches against: > > pkcs11-global.c > pkcs11-object.c > pkcs11-session.c > > the function prototype is usually CK_RV func(..) but > the implementation uses an int. > > Is it possible to apply these? Done in revision 4415. Thanks -- Dr. Lu

[opensc-devel] [PATCH] change int to CK_RV to match prototype declaration

2010-06-13 Thread Martin Vogt
Hello, attached are three patches against: pkcs11-global.c pkcs11-object.c pkcs11-session.c the function prototype is usually CK_RV func(..) but the implementation uses an int. Is it possible to apply these? regards, Martin Index: pkcs11-global.c ==

Re: [opensc-devel] [patch 0/3] [RFC] Adding an 'in system' SmartCard interface

2010-05-30 Thread Andreas Jellinghaus
Am Donnerstag 27 Mai 2010, um 10:57:58 schrieb Juergen Beisert: > > what is missing are some small issues: > > * license: LGPL-2.1+? or 3-BSD? or some other license? > > In my next version I replaced the license information by a link to > the 'LGPL-2.1' file. Okay? ok. best use the template in th

Re: [opensc-devel] [patch 0/3] [RFC] Adding an 'in system' SmartCard interface

2010-05-27 Thread Jean-Michel Pouré - GOOZE
On Thu, 2010-05-27 at 11:05 +0200, Juergen Beisert wrote: > And my current hardware > incarnation only supports the Mini SIM format. We offer mini SIM format. Kind regards, -- Jean-Michel Pouré - Gooze - http://www.gooze.eu ___ ope

Re: [opensc-devel] [patch 0/3] [RFC] Adding an 'in system' SmartCard interface

2010-05-27 Thread Juergen Beisert
Jean-Michel Pouré - GOOZE wrote: > On Wed, 2010-05-26 at 22:17 +0200, Andreas Jellinghaus wrote: > > do you have some card and app for testing? > > I contacted you and suggested that you ask for a free Feitian PKI card > and reader for testing: > http://www.gooze.eu/feitian-pki-free-software-develo

Re: [opensc-devel] [patch 0/3] [RFC] Adding an 'in system' SmartCard interface

2010-05-27 Thread Juergen Beisert
Hi Andreas, Andreas Jellinghaus wrote: > the code looks good to me. very clean, nice! Thanks. > what is missing are some small issues: > * license: LGPL-2.1+? or 3-BSD? or some other license? In my next version I replaced the license information by a link to the 'LGPL-2.1' file. Okay? > * the

Re: [opensc-devel] [patch 0/3] [RFC] Adding an 'in system' SmartCard interface

2010-05-27 Thread Jean-Michel Pouré - GOOZE
On Wed, 2010-05-26 at 22:17 +0200, Andreas Jellinghaus wrote: > do you have some card and app for testing? I contacted you and suggested that you ask for a free Feitian PKI card and reader for testing: http://www.gooze.eu/feitian-pki-free-software-developer-card Kind regards, --

Re: [opensc-devel] [patch 0/3] [RFC] Adding an 'in system' SmartCard interface

2010-05-26 Thread Peter Stuge
Andreas Jellinghaus wrote: > [power management] .. > however is some app keeps a connection open, it must stay active, > so that a "verified" state (pin confirmed) isn't lost due to a > power down. Then that app can get a bug report filed. It would be a good first step if OpenCT and OpenSC do not

Re: [opensc-devel] [patch 0/3] [RFC] Adding an 'in system' SmartCard interface

2010-05-26 Thread Andreas Jellinghaus
the code looks good to me. very clean, nice! what is missing are some small issues: * license: LGPL-2.1+? or 3-BSD? or some other license? * the whole picture: if someone has a patched kernel and openct with these changes: how does he get it to work? "mknod" to create a device and a static con

  1   2   3   4   >