Re: [ovs-dev] [ovs-dev, patch_v1] db-ctl-base: Use boolean variable values.

0-day Robot writes: > Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing Co-authored-by

[ovs-dev] [PATCH] xlate: use const struct in6_addr in linklocal check

error: member reference base type 'const uint8_t' (aka 'const unsigned char') is not a structure or union Fixes: 83c2757bd16e ("xlate: Move tnl_neigh_snoop() to terminate_native_tunnel()") Cc: Zoltan Balogh Cc: Jan Scheurich Signed-off-by: Aaron Conole --- ofproto/ofpr

Re: [ovs-dev] [ovs-dev, RFC, 5 of 9] ovn-nbctl: Don't dup the error message just to report it.

0-day Robot writes: > Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > Okay - I *think* I enabled the RFC series detection. Sorry about

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Check the right IPv6 address in is_nd_dst_correct().

Ben Pfaff writes: > Fixes test 815 "tunnel_push_pop_ipv6 - action". > > CC: Aaron Conole > Fixes: 6f231f7c3a9e ("xlate: use const struct in6_addr in linklocal check") > Signed-off-by: Ben Pfaff > --- D'oh! The names killed

Re: [ovs-dev] [PATCH] sparse: Make IN6_IS_ADDR_MC_LINKLOCAL and IN6_ARE_ADDR_EQUAL pickier.

ckier so that we catch any introduced > problems more quickly. > > CC: Aaron Conole > Signed-off-by: Ben Pfaff > --- LGTM Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] bot suggestion

Ben Pfaff writes: > The bot couldn't apply this patch presumably because it tried to apply > it against master. Maybe the bot should notice version numbers in [] in > subject lines and try against that branch. Good call. I'm at a conference at the moment, but will try to get that integrated

Re: [ovs-dev] [PATCH] tests: Ignore recirc_id in "MPLS xlate action" test.

ts applied, I'll wait a bit and see if the tests consistently pass. If that's so, I'll re-enable the make distcheck in the bot for output. Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] configure: Enable GCC relevant new 8.x warning options.

ned-off-by: Ben Pfaff > --- LGTM. Sorry it took so long to review. Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [ovs-dev, PATCHv3] datapath: work around the single GRE receive limitation.

0-day Robot writes: > Bleep bloop. Greetings William Tu, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing Co-authored-by

Re: [ovs-dev] [ovs-dev, 01 of 15] table: Allow default style to be used in an assignment.

Jakub Sitnicki writes: > Hey Aaron, > > On Wed, 11 Jul 2018 15:55:34 -0400 > 0-day Robot wrote: > >> Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out >> your patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the

Re: [ovs-dev] [ovs-dev, 12 of 15] ovn-nbctl: Initial support for daemon mode.

Jakub Sitnicki writes: > On Wed, 11 Jul 2018 16:04:32 -0400 > 0-day Robot wrote: > >> Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have >> tried out your patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >>

Re: [ovs-dev] [PATCH] ofproto: Return error codes for Rule insertions

Aravind Prasad S writes: > Currently, rule_insert() API doesnot have return value. There are some > possible /doesnot/doesn't/ or /doesnot/does not/ Or maybe even just remove that sentence. :) > scenarios where rule insertions can fail at run-time even though the static > checks during

Re: [ovs-dev] [PATCH 1/3] ipsec: reintroduce IPsec support for tunneling

Ben Pfaff writes: > On Wed, Jun 27, 2018 at 04:00:00PM -0400, Aaron Conole wrote: >> Thanks for the patch. It's really cool to see IPSec being >> re-integrated. Just a few quick comments inline. >> >> Qiuyu Xiao writes: >> >> > From: Ansis Att

Re: [ovs-dev] [RFC] Federating the 0-day robot, and improving the testing

"Eelco Chaudron" writes: > On 6 Sep 2018, at 10:56, Aaron Conole wrote: > >> As of June, the 0-day robot has tested over 450 patch series. >> Occasionally it spams the list (apologies for that), but for the >> majority of the time it has caught issues before the

Re: [ovs-dev] [PATCH] netlink-socket: don't check for namespace id under Windows

<aserd...@ovn.org> writes: >> -Mesaj original- >> De la: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> În numele Flavio Leitner >> Trimis: Tuesday, April 3, 2018 2:48 AM >> Către: Aaron Conole <acon...@redhat.com> >> Cc: d

[ovs-dev] [RFC 1/2] dpdk: allow init to fail

. With this change, a failed dpdk initialization attempt will no longer trigger a SIGABRT. Instead, the failure will be logged, and OvS will continue to operate sans dpdk. A restart of OvS would still be required to re-attempt initialization. Signed-off-by: Aaron Conole <acon...@redhat.com> --

[ovs-dev] [RFC 2/2] dpdk: reflect status and version in the database

initialization status. Signed-off-by: Aaron Conole <acon...@redhat.com> --- lib/dpdk-stub.c| 10 ++ lib/dpdk.c | 13 + lib/dpdk.h | 3 ++- vswitchd/bridge.c | 5 + vswitchd/vswitch.ovsschema | 11 --- vswitchd/vswit

[ovs-dev] [RFC 0/2] dpdk: minor refactor of the initialization step

. Presented here as a boolean - however, it might be more interesting to be a 'string' and have more elaborate details (ex: 'failed - ovs_strerror(rte_errno)' or 'uninitialized' or 'initialized'). Aaron Conole (2): dpdk: allow init to fail dpdk: reflect status and version in the database lib

Re: [ovs-dev] [PATCH] stopwatch: Explicitly ignore write() return value.

quot;. In the current stopwatch implementation, data packets are written to >> >>the pipe and that data is then read by another thread. The actual data is >> >>important in this case. >> >> >> >>You're 100% right that this needs to handle the Windows case. O

Re: [ovs-dev] [RFC 0/2] dpdk: minor refactor of the initialization step

e it would either have to be defaulted to 'dpdk-init-is-fatal=true' to abort on failure (which most users would want to change making it an undesirable default), or the Kolla ansible scripts (and other detection mechanisms for dpdk failure - if they exist) would need to change. Maybe there's anot

[ovs-dev] [PATCH] rhel: user/group openvswitch does not exist

Signed-off-by: Alan Pevec <alan.pe...@redhat.com> Co-authored-by: Aaron Conole <acon...@redhat.com> Signed-off-by: Aaron Conole <acon...@redhat.com> --- NOTE: This differs from the pull request upstream as I've also moved the dpdk section to %pre, after talking with

Re: [ovs-dev] [PATCH] rhel/systemd: Prevent deletion of runtime directory.

Gurucharan Shetty writes: > Currently, when we do a 'service openvswitch stop', > '/var/run/openvswitch' gets deleted. This is a problem > if you have other users (like OVN) using the same > runtime directory since we delete all the files > related to ovsdb-server backing OVN's

Re: [ovs-dev] [RFC 0/2] dpdk: minor refactor of the initialization step

"Mooney, Sean K" <sean.k.moo...@intel.com> writes: >> -Original Message- >> From: Aaron Conole [mailto:acon...@redhat.com] >> Sent: Monday, April 9, 2018 4:32 PM >> To: Mooney, Sean K <sean.k.moo...@intel.com> >> Cc: d...@openvs

Re: [ovs-dev] [PATCH 1/2] dpdk docs: Drop qemu-kvm for qemu-system-x86_64.

On the other hand, on my RHEL7.4 system, I don't have qemu-system-x86_64, but I do have qemu-kvm. I do like cookbook examples, but it seems that sometimes the care and feeding of these sections gets cumbersome. Maybe there's a way of including just the xml portions we need for a vhost

Re: [ovs-dev] [PATCH 2/2] dpdk docs: Drop file share in libvirt config.

Tiago Lam writes: > When explaining on how to add vhost-user ports to a guest, using > libvirt, the following piece of configuration is used: > > > > > > > > This is used to facilitate sharing of a DPDK directory between the host > and

Re: [ovs-dev] [PATCH 2/2] dpdk docs: Drop file share in libvirt config.

Stephen Finucane <step...@that.guru> writes: > On Wed, 2018-04-11 at 09:54 -0400, Aaron Conole wrote: >> Tiago Lam <tiago@intel.com> writes: >> >> > When explaining on how to add vhost-user ports to a guest, using >> > libvirt,

Re: [ovs-dev] [PATCH v2] Edit Open vSwitch license info so that GitHub recognizes it.

; > --- According to the Licensee[1] code, it should be good enough to put the exact text of the Apache 2.0 license into the COPYING file. Then again COPYING is a GNU-ism, afaik. So either way: Acked-by: Aaron Conole <acon...@redhat.com> As a side note, as I start editing files, I'll add

[ovs-dev] [PATCH v2] rhel: user/group openvswitch does not exist

Signed-off-by: Alan Pevec <alan.pe...@redhat.com> Co-authored-by: Aaron Conole <acon...@redhat.com> Signed-off-by: Aaron Conole <acon...@redhat.com> --- v2: * Removed the requires(post) lines * Removed 'exit 0' rhel/openvswitch-fedora.spec.in | 20 1 fil

Re: [ovs-dev] [PATCH] rhel: Fix literal dollar sign usage in systemd service files

as non-root user. > > From man 5 systemd.service: > > To pass a literal dollar sign, use "$$". Variables whose value is not known > at expansion time are treated as empty strings. Note that the first argument > (i.e. the program to execute) may not be a

Re: [ovs-dev] [PATCH v2] rhel: user/group openvswitch does not exist

Markos Chandras <mchand...@suse.de> writes: > Hi Aaron, > > On 18/04/18 15:51, Aaron Conole wrote: >> v2: >> * Removed the requires(post) lines >> * Removed 'exit 0' > > I realize that I was the one suggested to drop 'exit 0', but right at > the

[ovs-dev] [RFC v2 0/2] dpdk: minor refactor of the initialization step

' or 'initialized'). v2: - changed to allow dpdk-init to be set to 'try' Aaron Conole (2): dpdk: allow init to fail dpdk: reflect status and version in the database Documentation/faq/configuration.rst | 8 +--- Documentation/intro/install/dpdk.rst | 27 ++--- lib/dpdk

[ovs-dev] [RFC v2 1/2] dpdk: allow init to fail

, the failure details will be logged, and a user or administrator may have more information to correct the issue. A restart of OvS would still be required to re-attempt initialization. The refactor to propagate the init error will be used in an upcoming commit. Signed-off-by: Aaron Conole <a

[ovs-dev] [RFC v2 2/2] dpdk: reflect status and version in the database

initialization status. To support this, the other_config:dpdk-init configuration block supports the 'true' and 'try' keywords now, instead of just 'true'. Signed-off-by: Aaron Conole <acon...@redhat.com> --- Documentation/faq/configuration.rst | 8 +--- Documentation/intro/install/dpdk.rs

Re: [ovs-dev] [PATCH] rhel/systemd: Prevent deletion of runtime directory.

Guru Shetty <g...@ovn.org> writes: > On 4 April 2018 at 08:13, Aaron Conole <acon...@redhat.com> wrote: > > Gurucharan Shetty <g...@ovn.org> writes: > > > Currently, when we do a 'service openvswitch stop', > > '/var/run/openvswitch' gets deleted. This

[ovs-dev] [PATCH v3] rhel: user/group openvswitch does not exist

Signed-off-by: Alan Pevec <alan.pe...@redhat.com> Co-authored-by: Aaron Conole <acon...@redhat.com> Signed-off-by: Aaron Conole <acon...@redhat.com> --- v3: * re-introduce 'exit 0' in %pre after discussion with Marcos and Alan v2: * Removed the requires(post) lines * Removed 'ex

Re: [ovs-dev] [PATCH] poc: Automate building of Fedora rpm packages

Ansis Atteka <ansisatt...@gmail.com> writes: > On 24 April 2018 at 13:10, Aaron Conole <acon...@redhat.com> wrote: >> Ansis Atteka <aatt...@ovn.org> writes: >> >>> This patch automates building of Fedora rpm packages (Just >>> like

Re: [ovs-dev] [PATCH] poc: Automate building of Fedora rpm packages

Ansis Atteka writes: > This patch automates building of Fedora rpm packages (Just > like we are already doing this for for CentOS and Ubuntu). > > Signed-off-by: Ansis Atteka > --- Maybe it's something wrong with my setup - but for the fedorabuilder image I

[ovs-dev] [PATCH] poc: update the documentation

Misc. fixes to the Proof of Concepts section to help render the information a bit nicer. Signed-off-by: Aaron Conole <acon...@redhat.com> --- Documentation/topics/testing.rst | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/Documentation/

Re: [ovs-dev] [RFC v2 0/2] dpdk: minor refactor of the initialization step

Aaron Conole <acon...@redhat.com> writes: > Sometimes, DPDK initialization can fail, but ovs-vswitchd will abort in > that case. When that occurs, ovs-vswitchd will be restarted by the > monitor and immediately abort. This is rather unfriendly to users, who > would prefer t

Re: [ovs-dev] [PATCH v2] checkpatch: Don't do line length or whitespace checks on debian/rules.

Ben Pfaff <b...@ovn.org> writes: > debian/rules is a Makefile with a funny name. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- Reviewed-by: Aaron Conole <acon...@redhat.com> ___ dev mailing list d...@openvswitch.or

Re: [ovs-dev] [PATCHv2] poc: Automate building of Fedora rpm packages

Ansis Atteka <aatt...@ovn.org> writes: > This patch automates building of Fedora rpm packages (Just > like we are already doing this for for CentOS and Ubuntu). > > Signed-off-by: Ansis Atteka <aatt...@ovn.org> > --- Super cool! Acked-by: Aaron

Re: [ovs-dev] [RFC v2 2/2] dpdk: reflect status and version in the database

Kevin Traynor <ktray...@redhat.com> writes: Thanks for the review, Kevin! > On 04/18/2018 07:30 PM, Aaron Conole wrote: >> The normal way of retrieving the running DPDK status involves parsing >> log files and issuing various incantations of ovs-vsctl and ovs-appctl >

Re: [ovs-dev] [RFC v2 1/2] dpdk: allow init to fail

Kevin Traynor <ktray...@redhat.com> writes: Thanks, Kevin! > On 04/18/2018 07:30 PM, Aaron Conole wrote: >> It's possible for dpdk initialization to fail either due to an internal >> error or an invalid configuration. When that happens, it's rather >> impolite to im

Re: [ovs-dev] [PATCH] rhel: don't drop capabilities when running as root

Aaron Conole <acon...@redhat.com> writes: > Currently, regardless of which user is being set as the running user, > Open vSwitch daemons on RHEL systems drop capabilities. This means the > very powerful CAP_SYS_ADMIN is dropped, even when the user is 'root'. > > For the

Re: [ovs-dev] [PATCH] rhel: Stop managing the /run/openvswitch directory with systemd.

.pid.tmp: create failed (Permission denied) > Mar 19 16:37:20 susetest ovs-ctl[3045]: Starting ovsdb-server ... failed! > > The ovs-lib code can already manage that directory for us so we can > remove these entries from the systemd file and let ovs-vsctl do it. > > Cc: Aaron

Re: [ovs-dev] [PATCH 4/4] rhel: selinux-policy to invoke proper label macros

Ansis Atteka <ansisatt...@gmail.com> writes: > On 20 March 2018 at 14:05, Aaron Conole <acon...@redhat.com> wrote: >> The rpm doesn't invoke all of the required selinux helpers to enact labeling >> or relabeling on all versions of Fedora/RHEL. According to: >>

Re: [ovs-dev] [PATCH 3/4] selinux: introduce domain transitioned kmod helper

Ansis Atteka <ansisatt...@gmail.com> writes: > On 20 March 2018 at 14:05, Aaron Conole <acon...@redhat.com> wrote: >> This commit uses the previously defined selinux label to transition >> from the openvswitch_t to openvswitch_load_module_t domain, by way of >>

Re: [ovs-dev] [PATCH 2/4] selinux: create a transition type for module loading

Ansis Atteka <ansisatt...@gmail.com> writes: > On 20 March 2018 at 14:05, Aaron Conole <acon...@redhat.com> wrote: >> Defines a type 'openvswitch_load_module_t' used exclusively for loading >> modules. This means that the 'openvswitch_t' domain won't require

Re: [ovs-dev] [PATCH] rhel: Stop managing the /run/openvswitch directory with systemd.

Markos Chandras <mchand...@suse.de> writes: > On 27/03/18 14:34, Aaron Conole wrote: >> >> Systemd has fixed this with commit: >> >> 30c81ce2cef9 ("pid1: when creating service directories, don't chown existing >> files") >> >> Wh

[ovs-dev] [PATCH v2 2/3] checkpatch: filter comment contents

to test each case). Signed-off-by: Aaron Conole <acon...@redhat.com> --- utilities/checkpatch.py | 56 - 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 2bc34db62..5ed

[ovs-dev] [PATCH v2 1/3] checkpatch: introduce constants for the parse states

It's just easier to read. Should be no functional change. Signed-off-by: Aaron Conole <acon...@redhat.com> --- utilities/checkpatch.py | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 8a3

[ovs-dev] [PATCH v2 3/3] checkpatch: add a comment spell-checker

is fairly comprehensive at this point. Signed-off-by: Aaron Conole <acon...@redhat.com> --- utilities/checkpatch.py | 108 ++-- 1 file changed, 105 insertions(+), 3 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 5ed

[ovs-dev] [PATCH v2 0/3] checkpatch: the comment years!

to understand then. v1->v2: * Fixed flake8 errors. * Fixed the comment state machine (since it missed a number of edge cases). * Although it's submitted on April 1, it's not an april fools joke.. Aaron Conole (3): checkpatch: introduce constants for the parse states checkpatch: fil

Re: [ovs-dev] [PATCH] rhel: don't drop capabilities when running as root

Russell Bryant <russ...@ovn.org> writes: > On Tue, Mar 27, 2018 at 9:26 AM, Aaron Conole <acon...@redhat.com> wrote: >> Aaron Conole <acon...@redhat.com> writes: >> >>> Currently, regardless of which user is being set as the running user, >>> Ope

Re: [ovs-dev] [PATCH] rhel/systemd: Prevent deletion of runtime directory.

Gurucharan Shetty writes: > Currently, when we do a 'service openvswitch stop', > '/var/run/openvswitch' gets deleted. This is a problem > if you have other users (like OVN) using the same > runtime directory since we delete all the files > related to ovsdb-server backing OVN's

Re: [ovs-dev] [PATCH 0/3] checkpatch: the comment years!

Aaron Conole <acon...@redhat.com> writes: > This series tries to get checkpatch a little better at skipping > stylistic things within comments, as well as growing a new feature > to actually spell check words in the comments. > > Patch 1 just cleans up the patch line-type s

Re: [ovs-dev] [PATCH v2 0/3] checkpatch: the comment years!

Ben Pfaff <b...@ovn.org> writes: > On Sun, Apr 01, 2018 at 11:06:51AM -0400, Aaron Conole wrote: >> This series tries to get checkpatch a little better at skipping >> stylistic things within comments, as well as growing a new feature >> to actually spell check words in

Re: [ovs-dev] [PATCH] ovs-lib: Ensure Emacs identifies the file type properly.

ell function library sourced by some Open vSwitch scripts. > # It is not intended to be invoked on its own. Acked-by: Aaron Conole <acon...@redhat.com> I might also suggest folding in the following (for our vim brethren). NB: I at first thought vim was correctly detecting the file ty

[ovs-dev] [PATCH] netlink-socket: don't check for namespace id under Windows

: 'Control' : is not a member of 'msghdr' Fixes: a86bd14 ("netlink: provide network namespace id from a msg.") Cc: Flavio Leitner <f...@redhat.com> Signed-off-by: Aaron Conole <acon...@redhat.com> --- lib/netlink-socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [ovs-dev] [PATCH] checkpatch: Fix mis-flagging of division operators as lacking whitespace.

Ben Pfaff <b...@ovn.org> writes: > The regular expression here would flag any slash that wasn't adjacent to > an asterisk as missing whitespace. This fixes the problem. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- Tested-by: Aaron Conole <acon...@redhat.com>

Re: [ovs-dev] [PATCH v10 2/3] dpif-netdev: Detailed performance stats for PMDs

Hi Jan, Some stylistic type comments follow. Sorry to jump in at the end - but you asked for checkpatch changes, so I improved and ran it against your patch and found some stuff for which I have an opinion. :) Maybe nothing to hold up merging but cleanup stuff. Jan Scheurich

Re: [ovs-dev] [PATCH 1/4] ovs-kmod-ctl: introduce a kernel module load script

Thanks for the review, Ansis! Ansis Atteka <ansisatt...@gmail.com> writes: > On 20 March 2018 at 14:05, Aaron Conole <acon...@redhat.com> wrote: >> Currently, Open vSwitch on linux embeds the logic of loading and unloading >> kernel modules into the ovs-ctl and ovs-li

Re: [ovs-dev] [PATCH] checkpatch: Avoid warnings for /* or */.

Ben Pfaff <b...@ovn.org> writes: > checkpatch would sometimes confuse comment markers for operators. This > fixes the problem. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- Looks good to me. Acked-by: Aaron Conole <acon...@redhat.com> __

[ovs-dev] [PATCH 3/4] selinux: introduce domain transitioned kmod helper

This commit uses the previously defined selinux label to transition from the openvswitch_t to openvswitch_load_module_t domain, by way of a specially labelled ovs-kmod-ctl helper. Signed-off-by: Aaron Conole <acon...@redhat.com> --- selinux/.gitignore | 4 selinux/autom

[ovs-dev] [PATCH 4/4] rhel: selinux-policy to invoke proper label macros

in the .fc.in file are applied properly. Signed-off-by: Aaron Conole <acon...@redhat.com> --- rhel/openvswitch-fedora.spec.in | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 8fbc985ce..b60

[ovs-dev] [PATCH 0/4] selinux: introduce a transition domain for loading kmods

*. I've tried to keep it as restricted as possible. If there are any useful selinux interfaces that would simplify the permission grants needed for the new domain, I'm happy to spin a v2. Aaron Conole (4): ovs-kmod-ctl: introduce a kernel module load script selinux: create a transition type

[ovs-dev] [PATCH 1/4] ovs-kmod-ctl: introduce a kernel module load script

utility 'ovs-kmod-ctl' will be used in an upcoming commit for RHEL-based distributions to have a separate transition domain that will allow module loading to be given to a separate selinux domain from the openvswitch_t domain. Signed-off-by: Aaron Conole <acon...@redhat.com> --- debian/openv

[ovs-dev] [PATCH 2/4] selinux: create a transition type for module loading

. A future commit will label the appropriate script with extended attributes to make use of this new domain. Signed-off-by: Aaron Conole <acon...@redhat.com> --- selinux/openvswitch-custom.te.in | 79 +--- 1 file changed, 74 insertions(+), 5 deletions(-) diff

Re: [ovs-dev] [PATCH] netdev-dpdk: Limit rate of DPDK logs.

lya Maximets <i.maxim...@samsung.com> > --- LGTM. Acked-by: Aaron Conole <acon...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v9 2/3] dpif-netdev: Detailed performance stats for PMDs

"Stokes, Ian" writes: >> -Original Message- >> From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] >> Sent: Sunday, March 18, 2018 5:38 PM >> To: Stokes, Ian ; d...@openvswitch.org >> Cc: i.maxim...@samsung.com >> Subject: RE: [ovs-dev]

[ovs-dev] [PATCH 2/3] checkpatch: filter comment contents

to test each case). Suggested-by: Jan Scheurich <jan.scheur...@ericsson.com> Signed-off-by: Aaron Conole <acon...@redhat.com> --- utilities/checkpatch.py | 50 - 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/utilities/che

[ovs-dev] [PATCH 0/3] checkpatch: the comment years!

in reducing any mispellings. I sent something like this before, but it wasn't opt-in at the time and it was probably a bit harder to understand then. Aaron Conole (3): checkpatch: introduce constants for the parse states checkpatch: filter comment contents checkpatch: add a comment spell

[ovs-dev] [PATCH 1/3] checkpatch: introduce constants for the parse states

It's just easier to read. Should be no functional change. Signed-off-by: Aaron Conole <acon...@redhat.com> --- utilities/checkpatch.py | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 8a3

[ovs-dev] [PATCH 3/3] checkpatch: add a comment spell-checker

is fairly comprehensive at this point. Signed-off-by: Aaron Conole <acon...@redhat.com> --- utilities/checkpatch.py | 107 ++-- 1 file changed, 104 insertions(+), 3 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 469

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Limit rate of DPDK logs.

rnings in case of intensive debug > enabled in DPDK. > > Signed-off-by: Ilya Maximets <i.maxim...@samsung.com> > --- > Still good to me. Acked-by: Aaron Conole <acon...@redhat.com> Probably worth backporting this to 2.9 at least.

Re: [ovs-dev] [patch v5 00/11] Userspace datapath: Add fragmentation support.

Darrell Ball <dlu...@gmail.com> writes: > Hi Aaron > > I totally missed this response - sorry! > > On Thu, Feb 22, 2018 at 10:24 AM, Aaron Conole <acon...@redhat.com> wrote: > > Darrell Ball <dlu...@gmail.com> writes: > > > On Fri, Feb 9, 2018 at

Re: [ovs-dev] [PATCH] selinux: allow dpdkvhostuserclient sockets with newer libvirt

Guoshuai Li writes: >> diff --git a/selinux/openvswitch-custom.te.in >> b/selinux/openvswitch-custom.te.in >> index c1a774f0e..7b9c1c7a0 100644 >> --- a/selinux/openvswitch-custom.te.in >> +++ b/selinux/openvswitch-custom.te.in >> @@ -14,6 +14,7 @@ require { >> type

[ovs-dev] [PATCH] selinux: include the svirt_t type

The dpdk policy adds support for interacting with libvirt, but failed to include the appropriate svirt_t type. This results in an error like: openvswitch-custom.te:53:ERROR 'unknown type svirt_t' at token ';' on line 1060: Reported-by: Guoshuai Li <l...@dtdream.com> Signed-off-by:

[ovs-dev] [PATCH 2/2] travis: build the selinux policy under linux

When performing a linux build, create the selinux policy. This ensures that the selinux policy files are at least 'compile' tested when changes occur. Signed-off-by: Aaron Conole <acon...@redhat.com> --- .travis.yml| 1 + .travis/linux-build.sh | 2 ++ 2 files changed, 3 inse

[ovs-dev] [PATCH 1/2] selinux: drop autogenerated files

When running a make clean, it is desirable for the autogenerated files to be removed. Signed-off-by: Aaron Conole <acon...@redhat.com> --- NOTE: these changes are currently being checked with a travis build at: https://travis-ci.org/orgcandman/ovs/builds/346814418 selinux/automake.

Re: [ovs-dev] [PATCH 4/4] rhel: selinux-policy to invoke proper label macros

Aaron Conole <acon...@redhat.com> writes: > Ansis Atteka <ansisatt...@gmail.com> writes: > >> On 20 March 2018 at 14:05, Aaron Conole <acon...@redhat.com> wrote: >>> The rpm doesn't invoke all of the required selinux helpers to enact labeling >>&

Re: [ovs-dev] This patch adds a new oss-fuzz target for OVN lexer

0-day Robot writes: > Bleep bloop. Greetings Bhargava Shastry, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Author Bhargava Shastry needs to sign off. >

Re: [ovs-dev] ofproto: Handle OpenFlow version mismatch for requestforward with groups.

0-day Robot writes: > Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > build: > /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99

Re: [ovs-dev] ofproto: Handle OpenFlow version mismatch for requestforward with groups.

Ben Pfaff writes: > On Thu, Sep 27, 2018 at 08:57:23AM -0400, Aaron Conole wrote: >> I think the issue here on the bot side is that the compiler is not able >> to deal with this initialization semantic. I'll follow up and get it >> fixed. > > I sent a fix

Re: [ovs-dev] ossfuzz: Speed up flow extract fuzzing by refactoring

Bhargava Shastry writes: > Hello, > > I can take a look at these on Monday. In any case, they look easily fixable. > > P.S. I wonder why the build bot did not complain on the exact same > code that has now been refactored out of flow_extract_target.c. As far > as I can remember, that code also

Re: [ovs-dev] Suggestion for 0-day robot.

Ilya Maximets writes: > Hi Aaron. > > What do you think about adding BSD build check to 0-day robot? > It'll be cool to run, for example, FreeBSD VM for checking to > cover bugs like this: > https://patchwork.ozlabs.org/patch/984844/ > > netdev-bsd and many other BSD related code is not

Re: [ovs-dev] [PATCH] OVN: introduce mac_prefix support to IPAM

Hi Lorenzo, Lorenzo Bianconi writes: > Add the possibility to specify a given mac address prefix for > dynamically generated mac address. Mac address prefix can be > specified in nbdb NB_Global table, options:mac_prefix= > This patch fix a possible issue of L2 address duplication if > multiple

Re: [ovs-dev] [PATCH] OVN: introduce mac_prefix support to IPAM

Aaron Conole writes: > Hi Lorenzo, > > Lorenzo Bianconi writes: > >> Add the possibility to specify a given mac address prefix for >> dynamically generated mac address. Mac address prefix can be >> specified in nbdb NB_Global table, options:mac_prefix= >> T

[ovs-dev] [PATCH] rhel: hugetlbfs group should be added as a system group.

Reported-by: Edgar Hoch Signed-off-by: Aaron Conole --- rhel/openvswitch-fedora.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index ba55fb55c..7a3fcf93a 100644 --- a/rhel/openvswitch-fedora.spec.in

Re: [ovs-dev] [PATCH] ovn-sb.ovsschema: Avoid duplicated IPs in Encap table.

Hi Han, Han Zhou writes: > From: Han Zhou > > When adding a new chassis, if there is an old chassis with same IP > existed in Encap table, it is allowed to be added today. However, > allowing it to be added results in problems: > > 1. The new chassis cannot work because none of the other

Re: [ovs-dev] [PATCH] ovs-ctl: Add new option to use short hostname.

Han Zhou writes: > From: Han Zhou > > Current ovs-ctl forces to set full hostname in external-ids. In > some situation users may want to set short hostname. For example, > in OpenStack - OVN integration, Neutron uses the host-id provided > by Nova, which is usually short hostname, to set

Re: [ovs-dev] [patch v4] conntrack: Add rcu support.

Darrell Ball writes: > Below is the recent private commit message I have for the patch: > > However, I plan to split out to 3 main patches, with probably a few minor > cosmetic patches. > > 1/ cmap performance and code simplification. > 2/ Eliminating exporting private datastructures to outside

Re: [ovs-dev] [PATCH] acinclude.m4: Really check whether GCC support -Wno-null-pointer-arithmetic.

tic Clang > warning.") > Signed-off-by: Ben Pfaff > --- I didn't get a chance to test this out, but the change looks sane. Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] OVN/OVS split document: Feedback requested

Mark Michelson writes: > What's below the dashed line was originally a Google Doc, which I have > copy-pasted into text form. Some of the formatting has been lost as a > result, but it should still be readable. > > There are quite a few open points of discussion below, including > 1) Ideal repo

Re: [ovs-dev] [ovs-dev, net-next, 01 of 22] net: micrel: fix return type of ndo_start_xmit function

0-day Robot writes: > Bleep bloop. Greetings YueHaibing, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. Whoops - sorry for the noise. I will add patches to netdev to the list of

Re: [ovs-dev] [PATCH] Fix bug in oss-fuzz options file

bshas...@sect.tu-berlin.de writes: > From: Bhargava Shastry > > oss-fuzz options file must begin with a [libfuzzer] header. > This was missing in the expr_parse_target.options file which this patch > fixes. > > Signed-off-by: Bhargava Shastry > --- Just wanted to let you know that the bot is

Re: [ovs-dev] [PATCH] Fix bug in oss-fuzz options file

ch will include the From: field). They even just subscribe to the list and then you offer it to them freely. It might be best to keep with the well formatted signed-off-by lines for now, and try to improve your spam filter technology. > Regards, > Bhargava > > On 09/28/2018 05:20 PM, Aar

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

"Stokes, Ian" writes: >> Dpdk port representors were introduced in dpdk versions 18.xx. >> Prior to port representors there was a one-to-one relationship between an >> rte device (e.g. PCI bus) and an eth device (referenced as dpdk port id in >> OVS). With port representors the relationship

Re: [ovs-dev] Fix OpenFlow v1.3.4 Conformance test failures: 430.500, 430.510

"Iyengar, Prashanth" writes: > From fc0a9e1329573692c04438370f85e87125a268b0 Mon Sep 17 00:00:00 2001 > From: Prashanth Iyengar > Date: Mon, 14 Jan 2019 12:53:11 -0800 > Subject: [PATCH] Fix OpenFlow v1.3.4 Conf test failures: 430.500, 430.510 > > This commit adds additional verification to

[ovs-dev] [PATCH RFC] stt: fix return code during xmit

/linux/stt.c: In function ‘ovs_stt_xmit’: /home/travis/build/ovsrobot/ovs/datapath/linux/stt.c:1005:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] int err; ^ If not used, then consider alternatively just dropping the variable. Signed-off-by: Aaron Conole

<    1   2   3   4   5   6   7   8   9   10   >