d
>
> Signed-off-by: Eelco Chaudron
Thanks Eelco,
this looks very nice.
A few minor nits from my side, but that not withstanding.
Acked-by: Simon Horman
...
> +#
> +# event_to_dict()
> +#
> +def event_to_dict(event):
> +event_dict = {}
> +
> +for field, _ in event
Hi Han Ding,
On Thu, Jan 05, 2023 at 02:15:03PM +0800, Han Ding wrote:
> Function is_gratuitous_arp() and function is_garp() are all used to judge
> whether the flow is gratuitous arp. It is not necessary to use two functions
> to do the same thing and just keep one.
I agree it is nice to consoli
On Thu, Jan 05, 2023 at 12:39:18PM +0100, Ales Musil wrote:
> Add simple script that allows user to run tests and builds
> using container. At the same time add example Dockerfile for
> Fedora 37.
>
> Basic usage is:
> ./utilities/containers/ci.sh
>
> This will compile the project with GCC, it ex
On Thu, Jan 05, 2023 at 06:55:03PM +0530, Hemanth Aramadaka via dev wrote:
> Issue:
>
> The src-port for UDP is based on RSS hash in the packet metadata.
> In case of packets coming from VM it will be 5-tuple, if available,
> otherwise just IP addresses.If the VM fragments a large IP packet
> and
te the loads during a dry-run.
>
> Signed-off-by: Cheng Li
Makes sense to me.
Reviewed-by: Simon Horman
> ---
> Documentation/topics/dpdk/pmd.rst | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/topics/dpdk/pmd.rst
> b/Documentation/topics/d
On Fri, Jan 13, 2023 at 04:51:51PM -0500, Mark Michelson wrote:
> Using a bitmap makes the id-pool use less memory and be more
> cache-friendly. It theoretically should be faster since hashes do not
> have to be computed.
>
> This takes the approach of expanding the bitmap when necessary rather
>
On Sat, Jan 21, 2023 at 07:49:11PM +0300, Vladislav Odintsov wrote:
> Please check out the v2:
> https://patchwork.ozlabs.org/project/ovn/patch/20230121164609.3625347-1-odiv...@gmail.com/
Thanks, done :)
___
dev mailing list
d...@openvswitch.org
https://
dates relevant testcases to check the changed flows
> generation and port_binding:options:always-redirect logic.
>
> Signed-off-by: Vladislav Odintsov
Thanks for the updates since v1, they look good to me.
FWIIW,
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Jan 23, 2023 at 11:28:45AM +0100, Eelco Chaudron wrote:
>
>
> On 19 Jan 2023, at 11:38, Simon Horman wrote:
>
> > On Tue, Jan 17, 2023 at 10:19:23AM +0100, Eelco Chaudron wrote:
> >> This patch adds a Python script that can be used to analyze the
> &g
d
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Adrian Moreno
> Acked-by: Simon Horman
LGTM, thanks.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
16e24c ("System Tests: Enhance NAT tests.")
> > Signed-off-by: Ilya Maximets
>
> Reviewed-by: David Marchand
FWIIW,
Reviewed-by: Simon Horman
> Some notes:
> - in system-offloads-traffic.at, there is a similar issue,
> 5660b89a309d ("dpif-netlink: Offloading mete
On Tue, Jan 24, 2023 at 05:15:53PM +0100, David Marchand wrote:
> On Mon, Jan 23, 2023 at 3:50 PM Simon Horman
> wrote:
> >
> > On Mon, Jan 23, 2023 at 03:29:50PM +0100, David Marchand wrote:
> > > On Mon, Jan 23, 2023 at 3:05 PM Ilya Maximets wrote:
> > >
:9
>10 0x6cf6ea in udpif_upcall_handler ofproto/ofproto-dpif-upcall.c:801:13
>11 0xb6d7ea in ovsthread_wrapper lib/ovs-thread.c:423:12
>12 0x7f5ccf017801 in start_thread
>13 0x7f5ccefb744f in __GI___clone3
>
> Fixes: 9221c721bec0 ("netdev-offload-tc: Add conntrac
On Tue, Jan 24, 2023 at 08:21:28PM +0100, Adrián Moreno wrote:
> From: Adrian Moreno
>
> IPFIX templates have to be sent for each Observation Domain ID.
> Currently, a timer is kept at each dpif_ipfix_exporter to send them.
> This works fine for per-bridge sampling where there is only one
> Obser
On Tue, Jan 24, 2023 at 12:22:43PM +0100, Ilya Maximets wrote:
...
> I did some research that might answer or maybe clarify the questions above.
> Namely reading ARP-related RFCs - 826 and 5227. From these I carried
> following:
>
> - Gratuitous ARP / ARP Announcement messages are generally li
put: recirc_id sharing not supported
An alternate approach would be to probe for recirc_id sharing support.
[*] These tests fail, presumably mixing TC and OVS kernel datapath
flows breaks things. This feels like a bug.
As a work-around this patch disables these tests via the
OVS_TEST_SK
On Tue, Jan 24, 2023 at 02:01:19PM +0100, Eelco Chaudron wrote:
> With some datapaths, read TC, it takes a bit longer to update the
> OpenFlow statistics. Rather than adding an additional delay, try
> to read the counters multiple times until we get the desired value.
>
> Signed-off-by: Eelco Chau
On Thu, Jan 26, 2023 at 06:29:44PM +0100, Eelco Chaudron wrote:
>
>
> On 26 Jan 2023, at 17:52, Simon Horman wrote:
>
> > On Tue, Jan 24, 2023 at 01:42:57PM +0100, Eelco Chaudron wrote:
> >> This series makes it possible to include system-traffic.at tests into
>
On Thu, Jan 26, 2023 at 06:21:34PM +0100, Eelco Chaudron wrote:
>
>
> On 26 Jan 2023, at 17:58, Simon Horman wrote:
>
> > On Tue, Jan 24, 2023 at 02:01:19PM +0100, Eelco Chaudron wrote:
> >> With some datapaths, read TC, it takes a bit longer to update the
> >&
meter to tc police action")
Reported-by: David Marchand
Reviewed-by: Louis Peens
Signed-off-by: Simon Horman
---
tests/system-offloads-traffic.at | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/system-offloads-traffic.at b/tests/system-offloads-traffic.at
index 1a60570801e1..1
This series addresses an unnecessary and missing dependency on 'nc' in
system tests.
Patch 1/2: Remove unnecessary dependency on nc
Patch 2/2: Add necessary dependency on nc
As reported by David Marchand
Ref: https://mail.openvswitch.org/pipermail/ovs-dev/2023-January/401399.html
Si
The conntrack - ICMP related to original direction" test does not
use nc and therefore does not need to be skipped if nc is not present.
Fixes: d0e4206230b3 ("tests: ICMP related to original direction test.")
Reported-by: David Marchand
Reviewed-by: Louis Peens
Signed-off-b
On Fri, Jan 27, 2023 at 05:52:41PM +0100, Ilya Maximets wrote:
> On 1/25/23 13:50, Simon Horman wrote:
> > On Tue, Jan 24, 2023 at 05:15:53PM +0100, David Marchand wrote:
> >> On Mon, Jan 23, 2023 at 3:50 PM Simon Horman
> >> wrote:
> >>>
> >>&
On Fri, Jan 27, 2023 at 06:05:57PM +0100, Ilya Maximets wrote:
> On 1/27/23 14:34, Simon Horman wrote:
> > This series addresses an unnecessary and missing dependency on 'nc' in
> > system tests.
> >
> > Patch 1/2: Remove unnecessary dependency on nc
> >
This series provides a mechanism to allow the revalidator to retry
deletion of tc police action instances. Without such a technique
action instances created independent of flows, for metering, may be left
dangling if deletion fails when they are still used by flows.
Change since v2:
* Only apply m
From: Tianyu Yuan
Expose id_node structure for external use. F.e., the
hash_node could be directly accessed by this structure.
Signed-off-by: Tianyu Yuan
Signed-off-by: Simon Horman
---
lib/id-pool.c | 7 ---
lib/id-pool.h | 7 +++
2 files changed, 7 insertions(+), 7 deletions
supports revalidator to delete remaining polices
in tc datapath by storing meter_id deleted unsuccessfully in
a hmap and continuously deleting them in revalidator until
success.
Signed-off-by: Tianyu Yuan
Signed-off-by: Simon Horman
---
lib/dpif-netdev.c | 1 +
lib/dpif-netlink.c
From: Tianyu Yuan
Add helper function to add id_node in hmap directly and
expose this function for external use.
Signed-off-by: Tianyu Yuan
Signed-off-by: Simon Horman
---
lib/id-pool.c | 12 ++--
lib/id-pool.h | 1 +
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a
On Tue, Jan 31, 2023 at 05:22:11PM +0800, Faicker Mo wrote:
> Hi, a curious ovsrobot/intel-ovs-compilation test fail,
>
>
> 88: conntrack - IPv6 fragmentation + cvlan FAILED
> (system-traffic.at:3939)
>
>
> ./system-traffic.at:3939: ip netns exec at_ns0 sh << NS_EXEC_HEREDOC
> ping6 -
On Tue, Jan 31, 2023 at 10:19:39PM +0300, Fedor Pchelkin wrote:
> Syzkaller reports a memory leak of new_flow in ovs_flow_cmd_new() as it is
> not freed when an allocation of a key fails.
>
> BUG: memory leak
> unreferenced object 0x888116668000 (size 632):
> comm "syz-executor231", pid 1090
On Wed, Feb 01, 2023 at 07:28:09PM +0300, Fedor Pchelkin wrote:
> On 2/1/23 6:45 PM, Simon Horman wrote:
> > I see this would work by virtue of kfree(key) doing nothing
> > of key is NULL, the error case in question. And that otherwise key is
> > non-NULL if this path is hit.
4abfdcf4>] entry_SYSCALL_64_after_hwframe+0x61/0xc6
> >
> > To fix this the patch rearranges the goto labels to reflect the order of
> > object allocations and adds appropriate goto statements on the error
> > paths.
> >
> >
On Thu, Feb 02, 2023 at 12:09:37PM +0100, Eelco Chaudron wrote:
> This series makes it possible to include system-traffic.at tests into
> "make check-offloads" tests.
>
> The last patch of the series explains which tests are still not passing
> and might need some more work.
>
> I'll try to work
On Thu, Feb 02, 2023 at 12:09:47PM +0100, Eelco Chaudron wrote:
> Include and run the system-traffic.at tests as part of the system offload
> testsuite. Exclude all the tests that will not run without any special
> modifications.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
...
> di
On Fri, Feb 03, 2023 at 08:36:12PM +0100, Ilya Maximets wrote:
> On 2/3/23 17:48, Simon Horman wrote:
> > On Thu, Feb 02, 2023 at 12:09:47PM +0100, Eelco Chaudron wrote:
> >> Include and run the system-traffic.at tests as part of the system offload
> >> testsuite. Excl
g_helpers: Move string_is_valid()
That notwithstanding,
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ld
appear in the patch subject:
[PATCH v1 net-next 1/3] genetlink: Use string_is_valid() helper
That notwithstanding,
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ld
appear in the patch subject:
[PATCH v1 net-next 3/3] openvswitch: Use string_is_valid()
That notwithstanding,
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Feb 03, 2023 at 11:42:45PM +0800, Eddy Tao wrote:
> Use actual CPU number instead of hardcoded value to decide the size
> of 'cpu_used_mask' in 'struct sw_flow'. Below is the reason.
>
> 'struct cpumask cpu_used_mask' is embedded in struct sw_flow.
> Its size is hardcoded to CONFIG_NR_CPUS
ecessary rather
> than allocating the entire space at once. This makes the approach less
> memory-intensive for id pools with a large theoretical maximum number of
> values.
>
> Signed-off-by: Mark Michelson
Reviewed-by: Simon Horman
On Tue, Feb 07, 2023 at 01:04:41PM +0800, Han Ding wrote:
>
> Function is_gratuitous_arp() and function is_garp() are all used to judge
> whether the flow is gratuitous arp. It is not necessary to use two functions
> to do the same thing and just keep one.
>
> Signed-off-by: Han Ding
> ---
> li
oo :)
Reviewed-by: Simon Horman
> diff --git a/lib/conntrack.c b/lib/conntrack.c
> index 550b2be9b..3162924ca 100644
> --- a/lib/conntrack.c
> +++ b/lib/conntrack.c
...
> static void
> -reverse_nat_packet(struct dp_packet *pkt, const struct conn *conn)
> +nat_inner_packet
when caching routes from
> Kernel FIB with Netlink, but are not dealt with in this patch.
>
> Signed-off-by: Nobuhiro MIKI
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
t; calculated with its own logic. This patch resolves the difference
> between kernel FIB and OVS route table cache by retrieving the
> RTA_PREFSRC attribute of Netlink messages.
>
> Signed-off-by: Nobuhiro MIKI
Reviewed-by: Simon Horman
On Tue, Feb 07, 2023 at 12:31:33PM +0800, Eddy Tao wrote:
> Redefine clear_vlan to initialize one struct vlan_head
> Define clear_vlans to initialize key.eth.vlan and key.eth.cvlan
> Calls the revised functions accurately
>
> Reasoning:
>
> For vlan packet, current code calls clear_vlan unneces
On Wed, Feb 08, 2023 at 07:29:27AM +0100, Ales Musil wrote:
> On Tue, Feb 7, 2023 at 11:54 AM Simon Horman
> wrote:
>
> > On Mon, Feb 06, 2023 at 12:46:10PM +0100, Ales Musil wrote:
> > > The inner header was not handled properly.
> > > Simplify the code which al
t; There are nf_ct_helper() and nf_ct_add_helper() from nf_conntrak_helper
> in this patch, and will be more in the following patches.
>
> Signed-off-by: Xin Long
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mai
ff-by: Xin Long
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> Signed-off-by: Xin Long
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
e
> done only when defrag returns 0, as it does in other places
> in kernel.
>
> Signed-off-by: Xin Long
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ned-off-by: Xin Long
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
t supported" message, so tests
> will not fail with older kernels. This is not an error level message, but
> should be debug, like all other, EOPNOTSUPP, related log messages.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
Reviewed-b
t supported" message, so tests
> will not fail with older kernels. This is not an error level message, but
> should be debug, like all other, EOPNOTSUPP, related log messages.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
Reviewed-b
On Tue, Feb 07, 2023 at 03:04:17PM +0100, Eelco Chaudron wrote:
> TC flower does not allow the push of the implicit null labels (RFC3032).
> Avoid the use of such labels in the MPLS test cases.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
Reviewed-by: Simon Horman
T
-by: Eelco Chaudron
> Acked-by: Roi Dayan
Reviewed-by: Simon Horman
Tested-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Feb 07, 2023 at 03:05:07PM +0100, Eelco Chaudron wrote:
> Flush datapath flows as TC flows take some more time to be flushed out.
> The flush speeds this up.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
Reviewed-by: Simon Horman
Tested-b
; the kernel module, return traffic might flow through a tc conntrack
> rule, and it will not invoke the ALG helper.
>
> Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack support")
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
Reviewed-by:
related test by overriding the support macro.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
Reviewed-by: Simon Horman
Tested-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
tc-offload.rst.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
Reviewed-by: Simon Horman
Tested-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
e order for all datapath.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
Reviewed-by: Simon Horman
Tested-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
y is also present
> in other ICMP/IGMP tests.
>
> f98e418fbdb6 ("tc: Add tc flower functions")
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
Reviewed-by: Simon Horman
Tested-by: Simon Horman
___
dev mailing list
d...@openv
On Tue, Feb 07, 2023 at 03:07:24PM +0100, Eelco Chaudron wrote:
> With some datapaths, read TC, it takes a bit longer to update the
> OpenFlow statistics. Rather than adding an additional delay, try
> to read the counters multiple times until we get the desired value.
>
> Signed-off-by: Eelco Chau
On Wed, Feb 08, 2023 at 05:32:30PM +0100, Simon Horman wrote:
> On Tue, Feb 07, 2023 at 03:03:57PM +0100, Eelco Chaudron wrote:
> > Include and run the system-traffic.at tests as part of the system offload
> > testsuite. Exclude all the tests that will not run without any special
&g
On Thu, Feb 09, 2023 at 09:42:03AM +0100, Eelco Chaudron wrote:
>
>
> On 8 Feb 2023, at 17:50, Simon Horman wrote:
>
> > On Tue, Feb 07, 2023 at 03:07:24PM +0100, Eelco Chaudron wrote:
> >> With some datapaths, read TC, it takes a bit longer to update the
> >&
; investigation. They are:
>
> datapath - truncate and output to gre tunnel
> datapath - truncate and output to gre tunnel by simulated packets
>
> These tests where executed on a Fedora37 machine with the kernel
> 6.1.5-200.fc37.x86_64 installed.
>
> Signed-off-by:
On Thu, Feb 09, 2023 at 05:32:40PM +0800, Hangyu Hua wrote:
> old_meter needs to be free after it is detached regardless of whether
> the new meter is successfully attached.
>
> Fixes: c7c4c44c9a95 ("net: openvswitch: expand the meters supported number")
> Signed-off-by: Hangyu Hua
> ---
>
> v2:
c9a95 ("net: openvswitch: expand the meters supported number")
> > Signed-off-by: Hangyu Hua
>
> Thanks for doing a v3. The change looks good to me!
>
> Acked-by: Eelco Chaudron
Reviewed-by: Simon Horman
___
dev mailin
On Fri, Feb 10, 2023 at 12:30:58PM +0100, Adrian Moreno wrote:
>
>
> On 1/25/23 16:35, Simon Horman wrote:
> > On Tue, Jan 24, 2023 at 08:21:28PM +0100, Adrián Moreno wrote:
> > > From: Adrian Moreno
> > >
> > > IPFIX templates have to be sent for each
On Sat, Feb 18, 2023 at 02:53:29PM +0800, Eddy Tao wrote:
> Add 2 performance revisions for ovs_packet_cmd_execute
I think that in general it's nicer to do one change per patch:
i.e. split this into two patches.
> 1.Stores mainbody of sw_flow(600+ bytes) in stack
> Benifit: avoid kmem cache all
On Mon, Feb 20, 2023 at 03:11:17PM +0800, Eddy Tao wrote:
> Hi, Simon:
>
>
> About your concern for the stack size, it leads to more room for
> improvement.
>
> I will file a new version which will have smaller stack occupation and
> better performance
>
>
> The new revision is invoked by
t; Fix per-flow sampling by using an hmap to keep a timer for each
> Observation Domain ID.
>
> Signed-off-by: Adrian Moreno
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
tests which generate errors in Intel CI. Will submit in
> independent series.
> - v2:
> - Fixed a potential race condition in unit test.
> - v1:
> - Added unit test.
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvsw
ue_packet(dev, reply, NULL, 0);
}
}
I wonder if it would be appropriate to add a break; after
the call to netdev_dummy_queue_packet(). I don't think we expect
multiple hits. And it would save spinning over the loop unnecessarily,
though perhaps we don't expect the list of
On Tue, Feb 14, 2023 at 12:39:05PM +0900, Nobuhiro MIKI wrote:
> When adding a route with ovs/route/add command, the source address
> in "ovs_router_entry" structure is always the FIRST address that the
> interface has. See "ovs_router_get_netdev_source_address"
> function for more information.
>
t; calculated with its own logic. This patch resolves the difference
> between kernel FIB and OVS route table cache by retrieving the
> RTA_PREFSRC attribute of Netlink messages.
>
> Signed-off-by: Nobuhiro MIKI
Reviewed-by: Simon Horman
On Tue, Feb 21, 2023 at 05:41:59PM +0900, Nobuhiro MIKI wrote:
> On 2023/02/21 1:35, Simon Horman wrote:
> > On Tue, Feb 14, 2023 at 12:39:04PM +0900, Nobuhiro MIKI wrote:
> >> This is useful in test cases where multiple IPv4/IPv6 addresses
> >> are assigned togeth
On Tue, Feb 21, 2023 at 06:33:32PM +0900, Nobuhiro MIKI wrote:
> On 2023/02/21 2:23, Simon Horman wrote:
> > On Tue, Feb 14, 2023 at 12:39:05PM +0900, Nobuhiro MIKI wrote:
> >> When adding a route with ovs/route/add command, the source address
> >> in "ovs_route
On Thu, Feb 16, 2023 at 03:05:08PM -0500, Mike Pattrick wrote:
> Currently OVS keeps track of which mirrors that each packet has been
> sent to for the purpose of deduplication. However, this doesn't consider
> that openflow rules can make significant changes to packets after
> ingress.
>
> For ex
lem with min-revalidate-pps, as old statistic values are used
> during this period.
>
> This fix will wait for at least 2 seconds, by default, before assuming no
> packets where received during this period.
>
> Signed-off-by: Eelco Chaudron
Some minor nits inline, but this looks g
On Fri, Feb 03, 2023 at 12:12:12PM +0100, Eelco Chaudron wrote:
> When the ukey's action set changes, it could caus the flow to use a
nit: s/caus/cause/
> different datapath, for example, when it moves from tc to kernel.
> This will cause the the cached previous datapath statistics to be used.
>
On Wed, Feb 15, 2023 at 09:15:04PM +0100, Ilya Maximets wrote:
> On 2/14/23 14:54, Eelco Chaudron wrote:
> > Run "make check-offloads" as part of the GitHub actions tests.
> >
> > This test was run 25 times using GitHub actions, and the
> > failing rerun test cases where excluded. There are quite
On Wed, Feb 01, 2023 at 10:49:22AM +0800, Faicker Mo wrote:
> The device may be deleted and added with ifindex changed.
> The tc rules on the device will be deleted if the device is deleted.
> The func tc_del_filter will fail when flow del. The mapping of
> ufid to tc will not be deleted.
> The tra
On Tue, Feb 21, 2023 at 10:11:27AM -0500, Mike Pattrick wrote:
> On Tue, Feb 21, 2023 at 5:35 AM Simon Horman
> wrote:
> >
> > On Thu, Feb 16, 2023 at 03:05:08PM -0500, Mike Pattrick wrote:
> > > Currently OVS keeps track of which mirrors that each packet has been
&g
pecification is used. Also, pkt_mark and gw have separate prefix
> strings so they can be parsed in any order.
>
> Signed-off-by: Nobuhiro MIKI
Thanks, looks good.
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
http
On Wed, Feb 22, 2023 at 05:12:36PM +0900, Nobuhiro MIKI wrote:
> When adding a route with ovs/route/add command, the source address
> in "ovs_router_entry" structure is always the FIRST address that the
> interface has. See "ovs_router_get_netdev_source_address"
> function for more information.
>
this mailing list.
And could you please look at my comment regarding
the test you have added in this patch.
Thanks!
> From: Simon Horman
> Date: 2023-02-21 23:09:05
> To: Faicker Mo
> Cc: d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mappi
On Wed, Feb 22, 2023 at 09:02:10AM +0100, Ales Musil wrote:
> Nothing is being freed wherever we are calling
> ctl_fatal which is fine because the program is
> about to shutdown anyway however one of the
> leaks was caught by address sanitizer.
> Fix most of the leaks that are happening before
> ca
On Wed, Feb 22, 2023 at 06:31:55PM +0900, Nobuhiro MIKI wrote:
> On 2023/02/22 18:04, Simon Horman wrote:
> > On Wed, Feb 22, 2023 at 05:12:36PM +0900, Nobuhiro MIKI wrote:
...
> >> diff --git a/ofproto/ofproto-tnl-unixctl.man
> >> b/ofproto/ofproto-tnl-unixctl.
On Wed, Feb 22, 2023 at 11:24:04AM +0100, Ales Musil wrote:
> On Wed, Feb 22, 2023 at 10:59 AM Simon Horman
> wrote:
...
Hi Ales,
> Hi Simon,
> thank you for your review.
you are welcome.
> > > ---
> > > utilities/ovn-dbctl.c | 76 +++
I think this needs an ack from Eelco (CCed).
But it looks good to me.
Reviewed-by: Simon Horman
> ---
> lib/netdev-offload-tc.c | 7 ---
> lib/tc.c| 4 +++-
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/lib/netdev-offload-tc.c b/li
On Wed, Feb 22, 2023 at 07:29:50PM +0900, Nobuhiro MIKI wrote:
> These commands already support both IPv4 and IPv6.
>
> Signed-off-by: Nobuhiro MIKI
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvs
when caching routes from
> Kernel FIB with Netlink, but are not dealt with in this patch.
>
> Signed-off-by: Nobuhiro MIKI
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
pace/ovn/utilities/ovn-dbctl.c:132:20
> #7 0x5b58c7 in main /workspace/ovn/utilities/ovn-nbctl.c:7943:12
>
> Signed-off-by: Ales Musil
> ---
> v2: Address comments from Simon:
> - Rearrange the cleanup according to suggestion.
>
th the C-code change I am yet to see the test fail,
so far I'm up to 80 attempts.
I do wonder if this warrants a Fixes tag.
And if so, if it should be:
Fixes: 262a07956fab ("netdev-tc-offloads: Delete ufid tc mapping in the right
place")
That notwithstanding, I am ha
On Wed, Feb 22, 2023 at 04:19:37PM +0100, Simon Horman wrote:
> On Wed, Feb 22, 2023 at 06:33:50PM +0800, Faicker Mo wrote:
> > It's not easy to add a fail test without the changed code.
> > But I test it failed with the old code manually following these steps,
> > 1. App
On Thu, Feb 23, 2023 at 10:24:54AM +0800, Faicker Mo wrote:
> I can run the fail-test more easier.
> There exists a flow in verbose log like this,
> recirc_id(0),in_port(2),eth(src=aa:1a:54:e9:c5:56,dst=86:29:2a:05:94:90),eth_type(0x0800),ipv4(frag=no),
> packets:1, bytes:84, used:12.240s, action
On Thu, Feb 23, 2023 at 08:24:50PM +0800, Eddy Tao wrote:
> Sorry, there is a typo in the mail, i will resend shortly, please ignore it
> for now
net-next is now closed.
You'll need to repost this patch after v6.3-rc1 has been tagged.
Or post it as an RFC.
Ref: https://www.kernel.org/doc/html/l
check seems to execute for many make targets.
And it attempts to temporarily modify system state.
This seems inappopriate.
All these problems are addressed by this patch.
Signed-off-by: Simon Horman
Reviewed-by: Louis Peens
---
tests/atlocal.in | 11 ---
tests/system
On Thu, Feb 23, 2023 at 03:19:37PM +0100, Ilya Maximets wrote:
> On 2/23/23 14:02, Simon Horman wrote:
> > Move check for tc ingress pps support to from aclocal to test script
> >
> > This has several problems:
> >
> > 1. Stderror from failing commands is out
On Thu, Feb 23, 2023 at 04:09:10PM +0100, Ilya Maximets wrote:
> On 2/23/23 15:19, Ilya Maximets wrote:
> > On 2/23/23 14:02, Simon Horman wrote:
...
> >> +AT_CHECK([
> >> +if ! tc qdisc add dev veth0 handle : ingress; then
> >> +i
1401 - 1500 of 1623 matches
Mail list logo
