Re: [HACKERS] PL contribution guidelines?

>On Saturday 27 September 2003 19:46, Peter Eisentraut wrote: >> mlg7 writes: >> > Is there a centralized list of pgsql PL's ? >> >> I'm not aware of one. > >http://techdocs.postgresql.org/guides/PLLanguages > >Josh posted it on advocacy few days back. > > Shridhar > That does not work: : Proxy E

Re: [HACKERS] 2-phase commit

Kevin Brown wrote: > Bruce Momjian wrote: > > Marc G. Fournier wrote: > > > > > > > > > On Sat, 27 Sep 2003, Bruce Momjian wrote: > > > > > > > I have been thinking it might be time to start allowing external > > > > programs to be called when certain events occur that require > > > > administra

Re: [SQL] [HACKERS] plpgsql doesn't coerce boolean expressions to

Tom Lane wrote: Jan Wieck <[EMAIL PROTECTED]> writes: Tom Lane wrote: 4. Use the parser's coerce_to_boolean procedure, so that nonbooleans will be accepted in exactly the same cases where they'd be accepted in a boolean-requiring SQL construct (such as CASE). (By default, none are, so this isn't

Re: [HACKERS] 2-phase commit

Bruce Momjian wrote: > Marc G. Fournier wrote: > > > > > > On Sat, 27 Sep 2003, Bruce Momjian wrote: > > > > > I have been thinking it might be time to start allowing external > > > programs to be called when certain events occur that require > > > administrative attention --- this would be a go

[HACKERS] Open 7.4 items

P O S T G R E S Q L 7 . 4 O P E NI T E M S Current at ftp://momjian.postgresql.org/pub/postgresql/open_items. Changes --- Fix REVOKE ALL ON FUNCTION error when removing owner permissions Fix plpgsql handling of boolean tests on n

Re: [HACKERS] [COMMITTERS] pgsql-server/src/backend/executor execScan.c

Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> tlist_matches_tupdesc() needs to defend itself against dropped columns. > Tom, does this duplicate a patch in the patch queue, or is it separate? No, it was not from the patch queue. Joe's patch addresses some other issues.

Re: [SQL] [HACKERS] plpgsql doesn't coerce boolean expressions to boolean

Jan Wieck <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >>> 4. Use the parser's coerce_to_boolean procedure, so that nonbooleans >>> will be accepted in exactly the same cases where they'd be accepted >>> in a boolean-requiring SQL construct (such as CASE). (By default, >>> none are, so this isn't

Re: [HACKERS] Problem with function permission test in a view

Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I am documenting this behavior in the CREATE VIEW manual page, diff > > attached. > > > + > > + While access to tables in the view is controlled entirely by permissions > > + on the view, functions called by the view are c

Re: [HACKERS] [COMMITTERS] pgsql-server/src/backend/executor execScan.c

Tom Lane wrote: > CVSROOT: /cvsroot > Module name: pgsql-server > Changes by: [EMAIL PROTECTED] 03/09/25 16:41:49 > > Modified files: > src/backend/executor: execScan.c > > Log message: > tlist_matches_tupdesc() needs to defend itself against dropped columns. Tom, does

Re: [HACKERS] old pgindent change

Great. Patch applied. Nice to see someone else using pgindent. --- Nigel J. Andrews wrote: > > On Mon, 22 Sep 2003, Nigel J. Andrews wrote: > > > > > There was a simple change commited in revision 1.47 of pgindent, list

Re: [HACKERS] old pgindent change

I have applied the following patch to allow newer BSD indents to work with pgindent. Thanks. --- Nigel J. Andrews wrote: > > There was a simple change commited in revision 1.47 of pgindent, listed as > being "More updates

Re: [HACKERS] Improving REINDEX for system indexes (long)

Tom Lane wrote: > > What about creating a separate filenode anyway and renaming the files > > afterwards? It would not be an atomic operation anyway, but it would be > > better than the current setup IMHO. > > I think it would be difficult to persuade the buffer manager and storage > manager to w

Re: [HACKERS] Improving REINDEX for system indexes (long)

Alvaro Herrera <[EMAIL PROTECTED]> writes: > On Sat, Sep 27, 2003 at 06:37:22PM -0400, Tom Lane wrote: >> I don't see any way to avoid that, though, since we cannot change the >> relfilenode value for a shared index. > What about creating a separate filenode anyway and renaming the files > afterwa

Re: [HACKERS] Improving REINDEX for system indexes (long)

On Sat, Sep 27, 2003 at 06:37:22PM -0400, Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom, would you summarize what REINDEX currently _doesn't_ do? > > As of CVS tip I think the only deficiency is that indexes on the shared > catalogs (pg_database, pg_shadow, pg_group) have to

Re: [HACKERS] Improving REINDEX for system indexes (long)

Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom, would you summarize what REINDEX currently _doesn't_ do? > > As of CVS tip I think the only deficiency is that indexes on the shared > catalogs (pg_database, pg_shadow, pg_group) have to be reindexed in > place, rather than being

Re: ADD FOREIGN KEY (was Re: [HACKERS] [GENERAL] 7.4Beta)

[ continuing a discussion from mid-August ] Stephan Szabo <[EMAIL PROTECTED]> writes: >> I assume what you have in mind is to replace >> validateForeignKeyConstraint() with something that does a join of the >> two tables via an SPI command. > It'd probably be: > MATCH unspecified: > SELECT keyco

Re: [HACKERS] pg_dump doesn't dump binary compatible casts

Hello, Don't know if my vote counts here, but ANYTHING that makes pg_dump more correct should be backpatched. It is one thing to have index bloat, it is entirely another to not be able to correctly backup and restore. Also did you guys patch the create schema bug? I have a patch I can submit

Re: [HACKERS] Improving REINDEX for system indexes (long)

Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom, would you summarize what REINDEX currently _doesn't_ do? As of CVS tip I think the only deficiency is that indexes on the shared catalogs (pg_database, pg_shadow, pg_group) have to be reindexed in place, rather than being rebuilt with a new relfilen

Re: [HACKERS] 2-phase commit

> -Original Message- (B> From: Tom Lane (B> (B> Bruce Momjian <[EMAIL PROTECTED]> writes: (B> > Tom Lane wrote: (B> >> You're not considering the possibility of a transient communication (B> >> failure. (B> (B> > Can't the master re-send the request after a timeout? (B> (B> Not

Re: [HACKERS] Improving REINDEX for system indexes (long)

Tom, would you summarize what REINDEX currently _doesn't_ do? --- Tom Lane wrote: > I've been looking at the issues involved in reindexing system tables, > and I now have what I think is a fairly defensible set of proposals.

Re: [HACKERS] [GENERAL] pgindented tsearch2 for 7.3.4

Nigel J. Andrews wrote: > It was a far more basic problem than that! I'd have been pleased if I'd got as > far as that. You developers of today don't know you're born. Back in my day we > used to have to get up before noon just to turn the computer on... > > Actually, I had a problem in that I onl

Re: [HACKERS] getaddrinfo() for threading instead of gethostbyname()

Thanks. That's what I needed. Yes, I left the stuff enabled becuase the new test is pretty much the same as the old one, but some OS's might pass the tests if they only failed on gethostbyname(). --- Nigel J. Andrews wrote

Re: [HACKERS] Memory buffer alignment

Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > it certainly seems like it would be a good idea to have the 8k buffers > > aligned on 4k offsets. > > Why? What mechanism do you expect would find that more efficient? There was the idea that some OS's can swap the pages in from ker

Re: [HACKERS] Memory buffer alignment

Bruce Momjian <[EMAIL PROTECTED]> writes: > it certainly seems like it would be a good idea to have the 8k buffers > aligned on 4k offsets. Why? What mechanism do you expect would find that more efficient? regards, tom lane ---(end of broadcast)--

Re: [HACKERS] getaddrinfo() for threading instead of gethostbyname()

On Sat, 27 Sep 2003, Bruce Momjian wrote: > > OK, the thread test program is read for platform testing, > src/tools/thread_test. You will find the README, Makefile tests, and > program output to be very clear and almost error-proof. > > Please run it on platforms we support and report back. Th

Re: [HACKERS] Memory buffer alignment

I found this very interested, and realize we have shared buffers aligned at 8-bytes in CVS. However, I know if I allocate an 8k block, it will usually be aligned on an 8k boundary, right? I know the i386 uses 4k memory pages, and it certainly seems like it would be a good idea to have the 8k buf

Re: [HACKERS] PostgreSQL 7.4beta3 does not compile on AIX 5 ...

Peter Eisentraut <[EMAIL PROTECTED]> writes: > The compatlib doesn't appear to use libpq though. What is the error if > you leave it off? gcc -no-cpp-precomp -g -O2 -g -Wall -Wmissing-prototypes -Wmissing-declarations -bundle informix.o -L../../../../src/port -L../ecpglib -lecpg -L../pgtypeslib

Re: [HACKERS] "is_superuser" parameter creates inconsistencies

This item has been added to the 7.4 open items list: ftp://momjian.postgresql.org/pub/postgresql/open_items Allow SET SESSION AUTHORIZATION to update the psql %n user display --- Tom Lane wrote: > Peter Ei

Re: [HACKERS] initdb failure (was Re: [GENERAL] sequence's plpgsql)

Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Peter Eisentraut wrote: > >> Maybe instead we can change the COPY command to read the file directly and > >> not via stdin? Then we don't need the \. marker. > > I like that idea too. > > > Yes, we need a temp table then. The singl

Re: [HACKERS] 2-phase commit

Marc G. Fournier wrote: > > > On Sat, 27 Sep 2003, Bruce Momjian wrote: > > > I have been thinking it might be time to start allowing external > > programs to be called when certain events occur that require > > administrative attention --- this would be a good case for that. > > Administrators

Re: [HACKERS] PostgreSQL 7.4beta3 does not compile on AIX 5 ...

Tom Lane writes: > =?ISO-8859-1?Q?Hans-J=FCrgen_Sch=F6nig?= <[EMAIL PROTECTED]> writes: > > i have added -lm to ecpglib/Makefile > > in addition to that i had to add > > -lm -L../../libpq -lpq > > to compatlib/Makefile > > now it seems to compile properly. > > Okay, I have added these things as pa

Re: [HACKERS] [GENERAL] Can't Build 7.3.4 on OS X

"Eric B. Ridge" <[EMAIL PROTECTED]> writes: > Were you ever able to figure out why 7.3.4 wouldn't build? Didn't really look, since the 7.4 inlined version of TAS is a better solution anyway. regards, tom lane ---(end of broadcast)--

Re: [HACKERS] [GENERAL] Can't Build 7.3.4 on OS X

Marko Karppinen <[EMAIL PROTECTED]> writes: > While we're on a Mac-related note, I managed to compile PostgreSQL on > Mac OS X 10.2 Jaguar with two-level namespace support. > TwoLevelNamespaces.html> This is quite useful,

Re: [HACKERS] [GENERAL] Can't Build 7.3.4 on OS X

Eric Ridge <[EMAIL PROTECTED]> writes: > I don't think the OS X 10.3 betas are readily available (I've payed to > be in Apple's developer program), so if you don't have access to 10.3 > but have some idea as to what would cause this problem with tas, I'll > do whatever I can to help test. I hav

Re: [HACKERS] PostgreSQL 7.4beta3 does not compile on AIX 5 ...

=?ISO-8859-1?Q?Hans-J=FCrgen_Sch=F6nig?= <[EMAIL PROTECTED]> writes: > i have added -lm to ecpglib/Makefile > in addition to that i had to add > -lm -L../../libpq -lpq > to compatlib/Makefile > now it seems to compile properly. Okay, I have added these things as part of the Darwin makefile fixes I

Re: [HACKERS] 2-phase commit

On Sat, 27 Sep 2003, Bruce Momjian wrote: > I have been thinking it might be time to start allowing external > programs to be called when certain events occur that require > administrative attention --- this would be a good case for that. > Administrators could configure shell scripts to be run

Re: [HACKERS] pg_dump doesn't dump binary compatible casts

Jan Wieck <[EMAIL PROTECTED]> writes: > I have more precisely defined "builtin" as "belongs to a schema who's > name starts with pg_", as that is how we distinguish what namespaces get > dumped in the first place. Check. > The patch is applied to 7.4 according to being a bug. The same patch >

Re: [HACKERS] initdb failure (was Re: [GENERAL] sequence's plpgsql)

Peter Eisentraut <[EMAIL PROTECTED]> writes: > Jon Jensen writes: >> I hate to mention it, but would it be useful/non-overkill to make either >> of those things (context message maximum length and funny character >> escaping) configurable somehow? > I'm thinking the same. We have conflicting need

Re: [HACKERS] initdb failure (was Re: [GENERAL] sequence's plpgsql)

Bruce Momjian <[EMAIL PROTECTED]> writes: > Peter Eisentraut wrote: >> Maybe instead we can change the COPY command to read the file directly and >> not via stdin? Then we don't need the \. marker. I like that idea too. > Yes, we need a temp table then. The single-line fix seemed easier. Why a

Re: [HACKERS] initdb failure (was Re: [GENERAL] sequence's plpgsql)

On Sat, Sep 27, 2003 at 01:08:37PM -0400, Bruce Momjian wrote: > Peter Eisentraut wrote: > > That is all besides the point. If adding -f to the command line is for > > some reason prohibitive, then the same applies to -e. That is all. > > Seems we should recommend -f rather than "<" for restore

Re: [HACKERS] initdb failure (was Re: [GENERAL] sequence's plpgsql)

Peter Eisentraut wrote: > Bruce Momjian writes: > > > OK, I have applied a patch to make initdb create a COPY file with > > consistent end-of-line termination, so it passes the COPY EOL checking. > > Maybe instead we can change the COPY command to read the file directly and > not via stdin? Then

Re: [HACKERS] initdb failure (was Re: [GENERAL] sequence's plpgsql)

Peter Eisentraut wrote: > Bruce Momjian writes: > > > You are assuming it is easy to find what is on a specific line of the > > dump file. I am not sure that is always easy for people with limited > > Unix skills, or MSWin folks. I am not sure I would have thought to add > > the file offset to f

Re: [HACKERS] initdb failure (was Re: [GENERAL] sequence's plpgsql)

Bruce Momjian writes: > OK, I have applied a patch to make initdb create a COPY file with > consistent end-of-line termination, so it passes the COPY EOL checking. Maybe instead we can change the COPY command to read the file directly and not via stdin? Then we don't need the \. marker. -- Pet

Re: [HACKERS] initdb failure (was Re: [GENERAL] sequence's plpgsql)

Bruce Momjian writes: > You are assuming it is easy to find what is on a specific line of the > dump file. I am not sure that is always easy for people with limited > Unix skills, or MSWin folks. I am not sure I would have thought to add > the file offset to find the problem COPY line. I guess

Re: [HACKERS] initdb failure (was Re: [GENERAL] sequence's plpgsql)

Peter Eisentraut wrote: > Oliver Elphick writes: > > > + > > + With a large dump, it may be difficult to identify where any errors are > > + occurring. You may use the -e option to psql to print the SQL commands > > + as they are run, so that it is easy to see precisely which comm

Re: [HACKERS] 2-phase commit

On Saturday 27 September 2003 15:47, Bruce Momjian wrote: > Richard Huxton wrote: [snip] > > I might be (well, am actually) a bit out of my depth here, but surely > > what happens is if you have machines A,B,C and *any* of them thinks > > machine C has a problem then it does. If C can still communi

Re: [HACKERS] initdb failure (was Re: [GENERAL] sequence's plpgsql)

Bruce Momjian wrote: > Peter Eisentraut wrote: > > Tom Lane writes: > > > > > so it appears that cygwin's "echo" generates a different newline style > > > than what got put into sql_features.txt. A possible way to fix this is > > > to put the "\." line into sql_features.txt, but maybe there's a c

Re: [HACKERS] getaddrinfo() for threading instead of gethostbyname()

OK, the thread test program is read for platform testing, src/tools/thread_test. You will find the README, Makefile tests, and program output to be very clear and almost error-proof. Please run it on platforms we support and report back. Thanks.

Re: [HACKERS] pg_dump doesn't dump binary compatible casts

Tom Lane wrote: Jan Wieck <[EMAIL PROTECTED]> writes: That eliminated, a cast should be dumped if one or more of the three objects (source, target and function) are not builtin AND all the non-builtin objects belong to namespaces included in the dump. Where "builtin" is defined as "belongs to p

Re: [HACKERS] FreeBSD Thread-safe functions ...

Bruce Momjian wrote: > Marc G. Fournier wrote: > > > > After hearing that FreeBSD wasn't thread safe, I posted to the FreeBSD > > lists to find out what is up ... > > > > FreeBSD 5.x has a getpwuid_r function that should be used ... and, the > > word I got from one of the developers was that geta

Re: [HACKERS] FreeBSD Thread-safe functions ...

Marc G. Fournier wrote: > > After hearing that FreeBSD wasn't thread safe, I posted to the FreeBSD > lists to find out what is up ... > > FreeBSD 5.x has a getpwuid_r function that should be used ... and, the > word I got from one of the developers was that getaddrinfo(3) should be > used instead

Re: [HACKERS] PL contribution guidelines?

On Saturday 27 September 2003 19:46, Peter Eisentraut wrote: > mlg7 writes: > > Is there a centralized list of pgsql PL's ? > > I'm not aware of one. http://techdocs.postgresql.org/guides/PLLanguages Josh posted it on advocacy few days back. Shridhar ---(end of broadca

Re: [HACKERS] 2-phase commit

On Saturday 27 September 2003 20:17, Bruce Momjian wrote: > Richard Huxton wrote: > I have been thinking it might be time to start allowing external > programs to be called when certain events occur that require > administrative attention --- this would be a good case for that. > Administrators cou

Re: [HACKERS] 2-phase commit

Richard Huxton wrote: > > [itch...] But you surely cannot guarantee that the slave and the master > > time out at exactly the same femtosecond. What happens when the comm > > link comes back online just when one has timed out and the other not? > > (Hint: in either order, it ain't good. Double p

Re: [HACKERS] PL contribution guidelines?

mlg7 writes: > Is there a centralized list of pgsql PL's ? I'm not aware of one. > At that URL, I see: > pgplsh-1.0-7.3.tar.gz 17-Dec-2002 19:17 244k GZIP compressed docume> > pgplsh-20010821.tar.gz 23-Sep-2002 18:0899k GZIP compressed docume> > pgplsh-20010914

Re: [HACKERS] PL contribution guidelines?

Peter Eisentraut wrote: > > mlg3 writes: > > > I understand that pgsql uses autoconf but not other autotools. > > The best location for such contribution is in > > src/pl/pl > > > > Now, how do I include my PL into the build list? > > What files must I provide? (preferrably, by borrowing > > them

Re: [HACKERS] 2-phase commit

On Sat, 27 Sep 2003, Tom Lane wrote: > Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > >> ... You can make this work, but the resource costs > >> are steep. > > > So, after 'n' seconds of waiting, we abandon the slave and the slave > > abandons the master. > > [itch...] But you surely can

Re: [HACKERS] initdb failure (was Re: [GENERAL] sequence's plpgsql)

Oliver Elphick writes: > + > + With a large dump, it may be difficult to identify where any errors are > + occurring. You may use the -e option to psql to print the SQL commands > + as they are run, so that it is easy to see precisely which commands are > + causing errors. >

Re: [HACKERS] invalid tid errors in latest 7.3.4 stable.

Stephan Szabo wrote: > > The problem in the scenario you described should be solved if we mark any > > rows that are selected with the "for update" option (either implicitly, > > as with RI triggers, or explicitly) as having been modified by the > > selecting transaction, the equivalent of (in the

Re: [HACKERS] 2-phase commit

On Saturday 27 September 2003 06:59, Tom Lane wrote: > Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > >> ... You can make this work, but the resource costs > >> are steep. > > > > So, after 'n' seconds of waiting, we abandon the slave and the slave > > abandons the master. > > [itch...] But

Re: [HACKERS] initdb failure (was Re: [GENERAL] sequence's plpgsql)

Jon Jensen writes: > I hate to mention it, but would it be useful/non-overkill to make either > of those things (context message maximum length and funny character > escaping) configurable somehow? I'm thinking the same. We have conflicting needs of different groups: Users on "real" Unix platfor

Re: [HACKERS] invalid tid errors in latest 7.3.4 stable.

On Fri, 26 Sep 2003, Kevin Brown wrote: > Stephan Szabo wrote: > > The case at hand (with *'s on the ri queries) assuming pk already > > has an id=1 row would be. > > T1: begin; > > T1: set transaction isolation level serializable; > > T1 ... (something that does a select, not necessarily on eith