On 29 May 2011 14:04, Tom Lane t...@sss.pgh.pa.us wrote:
Anything that even pretends to be a bug tracker will do that. The
real question is, who is going to keep it up to date? GSM has the
right point of view here: we need at least a couple of people who
are willing to invest substantial
On 9 April 2011 00:41, Alvaro Herrera alvhe...@commandprompt.com wrote:
Excerpts from Brendan Jurd's message of vie abr 08 06:00:22 -0300 2011:
Memtest didn't report any errors. I intend to try swapping out the
RAM tomorrow, but in the meantime we got a *different* assertion
failure today.
On 10 April 2011 04:23, Joshua Berkus j...@agliodbs.com wrote:
If I have the following line in pg_hba.conf:
host replication replication all md5
pg_basebackup -x -v -P -h master1 -U replication -D $PGDATA
pg_basebackup: could not connect to server:
On 7 April 2011 16:56, Tom Lane t...@sss.pgh.pa.us wrote:
Brendan Jurd dire...@gmail.com writes:
TRAP: FailedAssertion(!((data - start) == data_size), File:
heaptuple.c, Line: 255)
[ scratches head ... ] That implies that heap_fill_tuple came to a
different conclusion about a tuple's data
Hi folks,
I am running a 9.0.3 Hot Standy + Streaming Replication slave which
occasionally segfaults (every 1-2 days). I rebuilt Postgres with
--enable-cassert and --enable-debug, switched on core dumping and
waited for some results.
The first crash since enabling debugging was a failed assert
On 7 April 2011 16:56, Tom Lane t...@sss.pgh.pa.us wrote:
Brendan Jurd dire...@gmail.com writes:
TRAP: FailedAssertion(!((data - start) == data_size), File:
heaptuple.c, Line: 255)
[ scratches head ... ] That implies that heap_fill_tuple came to a
different conclusion about a tuple's data
On 8 April 2011 00:16, Alvaro Herrera alvhe...@commandprompt.com wrote:
Excerpts from Brendan Jurd's message of jue abr 07 03:07:32 -0300 2011:
I am running a 9.0.3 Hot Standy + Streaming Replication slave which
occasionally segfaults (every 1-2 days). I rebuilt Postgres with
--enable-cassert
On 1 April 2011 02:00, Adrian Klaver adrian.kla...@gmail.com wrote:
On Wednesday, March 30, 2011 8:39:25 pm Brendan Jurd wrote:
If we wanted to make it work, then I think the thing to do would be
to add a new set of formatting tokens IDY, IDAY etc. I don't like the
idea of interpreting DY
On 1 April 2011 02:35, Marc Munro m...@bloodnok.com wrote:
Just to be clear, the reason I was mixing things in this way was that I
wanted to validate that the dayname being passed was valid for the
current locale, and I could find no easier way of doing it.
Ah, I see. In that case I think
On 1 April 2011 03:32, Adrian Klaver adrian.kla...@gmail.com wrote:
Now I am confused the docs say:
D day of the week, Sunday(1) to Saturday(7)
ID ISO day of the week, Monday(1) to Sunday(7)
This would seem to say they both are one-based but differ on the day that is
1.
That's
On 1 April 2011 04:16, Steve Crawford scrawf...@pinpointresearch.com wrote:
This whole discussion opens a #10 sized can o' worms. Admittedly, I don't
have good knowledge of any SQL-mandated interpretations of an ISO date - but
based on my reading of ISO formatting I see the following issues:
On 1 April 2011 05:16, Steve Crawford scrawf...@pinpointresearch.com wrote:
Well, to return to the original issue, should we allow the day to be spelled
out and fix it (as noted in this thread it is non-standard but also
unambiguous and we already allow plenty of non-standard formats) or throw
On 29 October 2010 09:59, Brendan Jurd dire...@gmail.com wrote:
On 18 October 2010 01:19, Tom Lane t...@sss.pgh.pa.us wrote:
Brendan Jurd dire...@gmail.com writes:
On 17 October 2010 09:59, Tom Lane t...@sss.pgh.pa.us wrote:
Good point. Maybe the correct fix is to remember whether each token
On 31 March 2011 03:15, Steve Crawford scrawf...@pinpointresearch.com wrote:
On 03/29/2011 04:24 PM, Adrian Klaver wrote:
...
Well the strange part is only fails for SUN:...
test(5432)aklaver=select to_date('2011-13-SUN', 'IYYY-IW-DY');
to_date
2011-03-28
...
You
On 18 March 2011 01:57, hom obsidian...@gmail.com wrote:
I try to known how a database is implemented
This objective is so vast and so vague that it's difficult to give
meaningful help.
I'd emphasise Kevin Grittner's very worthwhile advice. Try to break
your question down into smaller, more
On 26 February 2011 18:06, Bruce Momjian br...@momjian.us wrote:
Any progress on this?
I ended up doing most of the work, but never got around to finishing
it off. Thanks for the reminder, though. I'll get that one ready and
drop it onto the next CF.
Cheers,
BJ
--
Sent via pgsql-hackers
On 3 February 2011 10:54, Bruce Momjian br...@momjian.us wrote:
It seems LIKE is considering the trailing CHAR(10) field spaces as
significant, even though our documentations says:
-- snip --
It says trailing spaces are not significant for character comparisons
--- the real question is
On 6 November 2010 05:46, Josh Berkus j...@agliodbs.com wrote:
I'm continuing in my efforts now to document how to deploy and manage
replication on our wiki. One of the things a DBA needs to do is to use
pg_current_xlog_location() (and related functions) to check how far
behind the master the
On 18 October 2010 01:19, Tom Lane t...@sss.pgh.pa.us wrote:
Brendan Jurd dire...@gmail.com writes:
On 17 October 2010 09:59, Tom Lane t...@sss.pgh.pa.us wrote:
Good point. Maybe the correct fix is to remember whether each token was
quoted or not, so that keyword detection can be done safely
On 25 October 2010 07:36, Tom Lane t...@sss.pgh.pa.us wrote:
Brendan Jurd dire...@gmail.com writes:
I have encountered a reproducible segfault in Postgres ...
Looks like the invalItems list has been clobbered:
(gdb) p *root-glob-invalItems
$6 = {type = 2139062143, length = 2139062143, head
On 26 October 2010 03:42, Tom Lane t...@sss.pgh.pa.us wrote:
Brendan Jurd dire...@gmail.com writes:
Thanks for the hint; I found that the attached patch resolved my
specific segfault, but I am wondering whether it goes far enough.
Well, it definitely doesn't go far enough, because
Hi folks,
I have encountered a reproducible segfault in Postgres, and confirmed
it in 9.0.1 and HEAD on three separate machines. The bug was not
present in 8.4. I've attached a copy of the SQL script I have been
using to induce the segfault.
With asserts enabled, I get a failed assertion:
On 25 October 2010 07:36, Tom Lane t...@sss.pgh.pa.us wrote:
Looks like the invalItems list has been clobbered:
(gdb) p *root-glob-invalItems
$6 = {type = 2139062143, length = 2139062143, head = 0x7f7f7f7f,
tail = 0x7f7f7f7f}
I'm guessing it was modified in the temporary memory context and
Hi folks,
In my own databases, I've been using a couple of C functions that
might be useful to the wider community.
They are very simple date/timestamp constructors that take integers as
their arguments. Nothing fancy, but very convenient and *much* faster
than using a SQL or PL/pgSQL
On 23 October 2010 05:58, Peter Geoghegan peter.geoghega...@gmail.com wrote:
On 22 October 2010 19:45, Brendan Jurd dire...@gmail.com wrote:
Without these functions (or some variation), a user wishing to
construct a date from integers can only assemble the date into a
string and then put
On 23 October 2010 06:15, Josh Berkus j...@agliodbs.com wrote:
a) you'd need to rename these.
I'm open to that. What names would you propose?
b) we'd also want the inverse of these, which would be extremely useful.
Not a problem.
Cheers,
BJ
--
Sent via pgsql-hackers mailing list
On 19 October 2010 11:16, Josh Berkus j...@agliodbs.com wrote:
4. I can start a new replica off the master by running a single command-line
utility on the standby and giving it connection information to the master.
Using this connection, it should be able to start a backup snapshot, copy
the
On 13 October 2010 00:28, Fujii Masao masao.fu...@gmail.com wrote:
On Sat, Oct 9, 2010 at 11:13 AM, Brendan Jurd dire...@gmail.com wrote:
I understand that 'replication' is a keyword as far as the database
name is concerned, but I was surprised to find that it was treated as
a keyword
On 17 October 2010 01:52, Brendan Jurd dire...@gmail.com wrote:
Per the above discussion, I've prepared a patch to make keywords in
pg_hba.conf field-specific.
Try New and Improved This Message (tm), now with attachment!
Cheers,
BJ
*** a/src/backend/libpq/hba.c
--- b/src/backend/libpq/hba.c
On 16 October 2010 21:56, Peter Eisentraut pete...@gmx.net wrote:
As a small addition to the pg_hba.conf host name feature, I figured it
would be useful to allow all in the host column, instead of having to
write 0.0.0.0/0 and ::/0. Patch attached.
Cool. And, for what it's worth, this
On 17 October 2010 02:27, Alvaro Herrera alvhe...@commandprompt.com wrote:
Hmm. Would it be possible to list keywords _applicable_ to each field,
and have these passed down to next_token by the caller instead? This
seems backwards, but I'm not sure if the other way is really workable.
Short
On 17 October 2010 09:59, Tom Lane t...@sss.pgh.pa.us wrote:
Brendan Jurd dire...@gmail.com writes:
At the time that next_token gets called, we have no way of knowing
which field is currently being tokenised, at least not without doing
some serious rearrangement of hba.c, so that it tokenises
On 14 October 2010 08:45, Robert Haas robertmh...@gmail.com wrote:
Is someone working on a patch?
Yes, I will prepare a patch to get us started.
Cheers,
BJ
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
On 12 October 2010 23:28, Fujii Masao masao.fu...@gmail.com wrote:
On Sat, Oct 9, 2010 at 10:04 AM, Brendan Jurd dire...@gmail.com wrote:
I have just set up HS+SR for the first time, and for the most part,
the docs were excellent. The one exception for me was the discussion
On 15 October 2010 05:33, Simon Riggs si...@2ndquadrant.com wrote:
On Fri, 2010-10-15 at 02:24 +1100, Brendan Jurd wrote:
I'll drop this onto the next open commitfest. If it passes muster, it
sure wouldn't hurt to backpatch it to 9.0.
Committed. Not sure there's anything there worth
Hi folks,
I have just set up HS+SR for the first time, and for the most part,
the docs were excellent. The one exception for me was the discussion
of archive_cleanup_command. This is a pretty important part of
constructing a healthy standby server, and IMO the docs don't give it
the treatment
Hi folks,
One of the speedbumps I hit when setting up HS+SR was naming the user
the slave would connect as for streaming replication. At first I
picked 'replication', which seemed quite natural to me (and I don't
doubt will seem natural to others as well).
When I started up the slave, I got
On 23 September 2010 11:28, Abhijit Menon-Sen a...@toroid.org wrote:
This seems pretty dangerous, especially for people who are willing to
rely on git commit -a :-(
There is no danger. git commit -a will commit changes to files that
match .gitignore but are already in the repository. (I
On 18 August 2010 04:42, Tom Lane t...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
No, it doesn't. There are some policy decisions to be made here, too,
about what we wish to actually ignore. Personally, my preference
would be to arrange to ignore all and only *build
Apparently, the message I sent (quoted below) didn't make it to
-hackers. I know that Pavel received the message, as he replied to
it. I'm calling shenanigans on the mailing list server, but in the
meantime, here are those diffs again.
On 31 July 2010 07:37, Brendan Jurd dire...@gmail.com wrote
On 31 July 2010 07:58, Robert Haas robertmh...@gmail.com wrote:
Here's a second version of the main patch, in which I have attempted
to respond to Tom's concerns/suggestions.
(There is still a small, side issue with numeric_maximum_size() which
I plan to fix, but this patch is the good
On 22 July 2010 01:55, Robert Haas robertmh...@gmail.com wrote:
On Wed, Jul 21, 2010 at 9:39 AM, Pavel Stehule pavel.steh...@gmail.com
wrote:
I am thinking so we have to do decision about string_to_array and
array_to_string deprecation first.
Well, -1 from me for deprecating string_to_array
On 16 July 2010 03:47, Robert Haas robertmh...@gmail.com wrote:
On Jul 15, 2010, at 11:58 AM, Brendan Jurd dire...@gmail.com wrote:
I dropped one thousand numerics with value zero into a table and
checked the on-disk size of the relation with your patch and on a
stock 8.4 instance. In both
On 16 July 2010 22:51, Richard Huxton d...@archonet.com wrote:
On 16/07/10 13:44, Brendan Jurd wrote:
At this scale we should be seeing around 2 million bytes saved, but
instead the tables are identical. Is there some kind of disconnect in
how the new short numeric is making it to the disk
On 6 May 2010 04:42, Pavel Stehule pavel.steh...@gmail.com wrote:
attached patch contains to_string and to_array functions. These
functions are equivalent of array_to_string and string_to_array
function with maybe more correct NULL handling.
Hi Pavel,
I am reviewing your patch for the
On 17 July 2010 02:15, Pavel Stehule pavel.steh...@gmail.com wrote:
2010/7/16 Brendan Jurd dire...@gmail.com:
Regarding the behaviour of the third argument (null_string), I was a
little surprised by the results when I passed in a NULL.
I didn't thinking about NULL as separator before
On 17 July 2010 04:52, Pavel Stehule pavel.steh...@gmail.com wrote:
2010/7/16 Brendan Jurd dire...@gmail.com:
Also, if we're going to make the function non-strict, we need to
consider how to respond when the user specifies NULL for the other
arguments. If the field separator is NULL, bearing
On 17 July 2010 07:26, Joshua D. Drake j...@commandprompt.com wrote:
Yes. We should provide a single, well described grammar for interacting
with objects in the database regardless of client. I should be able to
open ANY SQL terminal, and type SHOW ME THE MONEY and have Benjamins
fall out.
On 10 July 2010 00:58, Robert Haas robertmh...@gmail.com wrote:
EnterpriseDB asked me to develop the attached patch to reduce the
on-disk size of numeric and to submit it for inclusion in PG 9.1.
After searching the archives, I found a possible design for this by
Tom Lane based on an earlier
On 8 April 2010 06:46, Tom Lane t...@sss.pgh.pa.us wrote:
Not a lot of zero suppression happening there :-(.
I believe the correct fix is to reduce the year mod 100 (or 10 or 1000)
before feeding it to snprintf, rather than playing games with printing
only part of the result string as the
On 3 March 2010 14:34, Bruce Momjian br...@momjian.us wrote:
Scott Bailey wrote:
Tom Lane wrote:
Asher Hoskins as...@piceur.co.uk writes:
I can't seem to get to_timestamp() or to_date() to work with quarters,
The source code says
* We ignore Q when converting to date
On 4 March 2010 04:08, Tom Lane t...@sss.pgh.pa.us wrote:
Brendan Jurd dire...@gmail.com writes:
For example, you're trying to import a date that is written as Wed
3rd March, Q1 2010. You might give to_date a format string like 'Dy
FMDDTH Month, QQ ' and expect to get the correct answer
2010/1/23 Mark Mielke m...@mark.mielke.cc:
Calling it
PostgreSQL, makes it very clear to the uninformed masses where the product
fits in a product map. Tell an executive of a company Postgres, and they
would ask what is it? Tell them PostgreSQL, and they'll say is that
like Oracle? The second
2009/12/20 Peter Eisentraut pete...@gmx.net:
Could we create an option to create index names automatically, so you'd
only have to write
CREATE INDEX ON foo (a);
Yes, please.
Cheers,
BJ
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
2009/12/3 Ron Mayer rm...@cheapcomplexdevices.com:
Tom Lane wrote:
Hmm. So the argument for it is let's make a machine-readable format
more human-readable? I'm not getting the point. People should look
at the regular text output.
IMHO YAML beats the regular text format for
2009/11/29 Bruce Momjian br...@momjian.us:
Wow, we mention 28k modems --- we are legacy software: ;-)
This initial checkout is a little slower than simply downloading
a filenametar.gz/filename file; expect it to take 40 minutes
or so if you have a 28.8K modem.
Yes, and what
2009/11/17 Joshua Tolley eggyk...@gmail.com:
On Sun, Nov 15, 2009 at 12:10:33PM +1100, Brendan Jurd wrote:
I noticed that there was a fairly large amount of bogus/inconsistent
whitespace
...
Thanks -- I tend to forget whitespace :)
In the documentation you refer to this feature as inline
2009/11/17 David Fetter da...@fetter.org:
In the PostgreSQL Weekly News, I track patches, and apparently at
least one person reads that section. Would it be helpful to track
reviews somehow during commitfests with the reviewers' names
prominently attached?
Yes. See also my suggestion [1]
2009/11/16 Andrew Dunstan and...@dunslane.net:
At Tom's suggestion I am looking at allowing use of parameter names in SQL
functions instead of requiring use of $1 etc. That raises the question of
how we would disambiguate a parameter name from a column name. Essentially,
ISTM, we could use
2009/11/16 Tom Lane t...@sss.pgh.pa.us:
The real problem with the entry that George picked up on was that it was
misdescribed and mislabeled as easy because whoever put it in ignored
the fact that there was not a consensus to do a half-baked fix ...
this is a problem with a wiki TODO list :-(
2009/11/10 Joshua Tolley eggyk...@gmail.com:
Ok, updated patch attached. As far as I know, this completes all outstanding
issues:
Hi Joshua,
I'm taking a look at this patch for the commitfest. I see that Andrew
has already taken an interest in the technical aspects of the patch,
so I'll
2009/11/15 Jeff Davis pg...@j-davis.com:
I know the error conventions are documented somewhere, but I completely
forgot where. Can you please point me to the right place? I thought most
error messages were supposed to be lower case, and detail messages were
supposed to read like sentences.
2009/11/14 Heikki Linnakangas heikki.linnakan...@enterprisedb.com:
I think we (the commitfest manager?) should simply send polite message
to any regulars who submits patches but hasn't volunteered for review.
Along the lines of:
I certainly endorse Heikki's suggestion, but I wonder if we can
2009/11/13 Euler Taveira de Oliveira eu...@timbira.com:
Simon Riggs escreveu:
So, I
propose that we simply ignore patches from developers until they have
done sufficient review to be allowed to develop again.
Is it really impolite for a first-contributor, no?
I support Simon's proposal,
2009/11/2 Alvaro Herrera alvhe...@commandprompt.com:
Peter Eisentraut wrote:
As a compromise, we could keep the combined Attributes column but
replace the line breaks by commas. This would at least get rid of the
confusing and ugly line breaks in the common cases.
That works for me.
Mmm,
2009/10/13 Tom Lane t...@sss.pgh.pa.us:
I started looking at this, and the first thing I noticed was that it
adds TABLES, FUNCTIONS, and SEQUENCES as unreserved keywords. Now
I'm not a fan of bloating the parser that way, but I have to admit
that GRANT ON ALL TABLE IN SCHEMA wouldn't read
2009/10/7 Peter Eisentraut pete...@gmx.net:
On Sun, 2009-10-04 at 22:07 -0400, Tom Lane wrote:
In short: while I haven't looked at the patch, I think Peter may be
steering you in the wrong direction.
In cases where you do have related functions, I suggest having
SQL-callable V1 functions
2009/10/6 Tom Lane t...@sss.pgh.pa.us:
Applied with a fair amount of editorial polishing. Notably I changed
the permissions requirements a bit:
Thanks and congratulations! I'm really looking forward to this feature.
I pulled the latest sources and gave it a whirl. Things worked as
expected
2009/10/6 Tom Lane t...@sss.pgh.pa.us:
Brendan Jurd dire...@gmail.com writes:
I pulled the latest sources and gave it a whirl. Things worked as
expected in psql, but I was a little surprised when I headed into the
documentation. The first place I visited was Chapter 20 - Database
Roles
2009/9/30 Pavel Stehule pavel.steh...@gmail.com:
So I dropped variadic functions from mixed/named notation and little
bit modified documentation. Please, can some native English speaker
look on documentation?
Hi Pavel,
I've had a look through the documentation and cleaned up a few things.
I
2009/9/28 Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp:
Thank you for reviewing.
I merged your fix and add INCLUDING ALL option to the new patch.
I changed InhRelation.options to be a bitmap of CreateStmtLikeOption.
INCLUDING just adds bits, and EXCLUDING drops bits.
I had two hunks fail
2009/9/28 Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp:
Brendan Jurd dire...@gmail.com wrote:
patching file src/bin/psql/sql_help.c
Hunk #1 FAILED at 3.
Hunk #2 FAILED at 1279.
2 out of 2 hunks FAILED -- saving rejects to file src/bin/psql/sql_help.c.rej
Oops, sql_help.c is an automatic
2009/9/7 Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp:
Here is a patch to implement the following items in our ToDo list:
* Add CREATE TABLE LIKE ... INCLUDING COMMENTS
* Have CREATE TABLE LIKE copy column storage parameters
Hello Itagaki-san,
I am doing an initial review of your patch.
2009/9/19 Pavel Stehule pavel.steh...@gmail.com:
2009/9/18 Selena Deckelmann selenama...@gmail.com:
Hi!
John Naylor and I reviewed this patch. John created two test cases to
demonstrated issues described later in this email. I've attached
those for reference.
On Thu, Aug 27, 2009 at 8:04
2009/9/21 Jeevan Chalke jeevan.cha...@enterprisedb.com:
Oracle returns 19-SEP-09 irrespective of the format.
Here in PG, we have getting the proper date irrespective of the format as
Oracle. But in the case to to_number the returned value is wrong. For
example following query returns '340' on
2009/9/21 Brendan Jurd dire...@gmail.com:
# SELECT regexp_replace('34,50', E'[\\d.]', '', 'g')::numeric;
3450
Sorry, that regex ought to have read E'[^\\d.]'.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
Hi Dimitri,
The commitfest app has you listed as the reviewer for this patch. Any
progress on your review?
Cheers,
BJ
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
2009/9/19 Tom Lane t...@sss.pgh.pa.us:
Should we have it throw an error if the input corresponding to a G
symbol doesn't match the expected group separator? I'm concerned that
that would break applications that work okay today.
It would be a substantial change to the behaviour, and to do it
2009/9/15 Jeff Davis pg...@j-davis.com:
Attached is the latest version.
Hi Jeff,
I'm just getting started reviewing this version now. I noticed that
your patch seems to have been generated by git. Are you hosting this
work on a public repo somewhere that I can pull from? Also I think
the
2009/9/15 Jeff Davis pg...@j-davis.com:
Attached is the latest version.
The new error message for a conflict is:
ERROR: index constraint violation detected
DETAIL: tuple conflicts with existing data
How about also including the name of the constraint (or index) that
was violated? I could
2009/9/15 Robert Haas robertmh...@gmail.com:
I believe the terminology we've been using, at least for the past year
since I've been involved, is as follows:
Open = open to new patches
In Progress = working on reviewing and committing patches, no longer
open to new patches
Closed = all
2009/9/16 Robert Haas robertmh...@gmail.com:
Instead of calling these generalized index constraints, I wonder if we
oughtn't to be calling them something like don't-overlap constraints
(that's a bad name, but something along those lines). They're not
really general at all, except compared to
2009/9/16 Robert Haas robertmh...@gmail.com:
On Tue, Sep 15, 2009 at 12:54 PM, Jeff Davis pg...@j-davis.com wrote:
I don't want to call them don't overlap constraints, because it's not
limited to a non-overlapping constraint.
Oh. What else can you do with it?
Anything that there is an
2009/9/16 Robert Haas robertmh...@gmail.com:
On Tue, Sep 15, 2009 at 1:14 PM, Brendan Jurd dire...@gmail.com wrote:
2009/9/16 Robert Haas robertmh...@gmail.com:
On Tue, Sep 15, 2009 at 12:54 PM, Jeff Davis pg...@j-davis.com wrote:
I don't want to call them don't overlap constraints, because
2009/8/21 Brendan Jurd dire...@gmail.com:
2009/8/21 Jeff Davis pg...@j-davis.com:
On Fri, 2009-08-21 at 12:23 +1000, Brendan Jurd wrote:
The current behaviour seems to be predicated on the unique constraint
being an integral part of the index itself. While this might be true
from a system
2009/9/9 Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp:
Alvaro Herrera alvhe...@commandprompt.com wrote:
This INCLUDING STORAGE is supposed to copy reloptions?
No. It copies only storage parameters of columns to control TOAST policy.
It might be good to have some features to copy reloptions
2009/9/4 Joshua D. Drake j...@commandprompt.com:
On Thu, 2009-09-03 at 12:00 -0400, Robert Haas wrote:
And /me pokes Brendan Jurd. :-)
Hah! I almost listed him. /me adds a poke to Brendan Jurd.
/me stirs from sleep to announce huh? whaddyawant?
Seriously though, I have been keeping an eye
2009/8/21 Heikki Linnakangas heikki.linnakan...@enterprisedb.com:
Jeff Davis wrote:
I'm leaning toward not allowing it at CREATE TABLE time.
Seems reasonable to me too.
+1
There are plenty of other things to do with tables that you can't mix
directly into a CREATE TABLE statement (grant
2009/8/21 Jeff Davis pg...@j-davis.com:
If they include indexes and not constraints, I think we should follow
the same policy as unique constraints, and create the index and the
constraint.
The behavior seems a little strange to me, but that's the current
behavior for unique indexes.
This
2009/8/21 Jeff Davis pg...@j-davis.com:
On Fri, 2009-08-21 at 12:23 +1000, Brendan Jurd wrote:
The current behaviour seems to be predicated on the unique constraint
being an integral part of the index itself. While this might be true
from a system catalog point of view (pg_index.indisunique
2009/8/11 Pavel Stehule pavel.steh...@gmail.com:
It's nice. I am playing with it, and now I found some potential issue.
The parser is maybe too tolerant:
postgres=# select to_char(3.14323,'9.9(a');
to_char
--
3.1e+00
(1 row)
I guess we *could* add code to throw an error
2009/8/11 Tom Lane t...@sss.pgh.pa.us:
Brendan Jurd dire...@gmail.com writes:
Here's version 7.
Applied with a couple of corrections: the numeric case wasn't dealing
with NaNs in the same way as the float cases,
Thanks for that.
I do think that the whole business of printing
2009/8/11 Tom Lane t...@sss.pgh.pa.us:
Alvaro Herrera alvhe...@commandprompt.com writes:
I wondered if it should just return char *. If we want to have this
functionality as its own fmgr-blessed function, shouldn't it return
text instead of cstring?
If we expose it at fmgr level it should
2009/8/11 Tom Lane t...@sss.pgh.pa.us:
If it's not meant to be in pg_proc, I wouldn't bother with using the V1
call protocol for it. extern char *numeric_out_sci(Numeric x) would
be sufficient, and less notation on both caller and callee sides.
Thanks Tom. I have removed the V1 stuff as you
2009/8/11 Tom Lane t...@sss.pgh.pa.us:
Working through this now, and I noticed that the example added to the
manual seems to be wrong:
entryliteralto_char(0.000485, '9.99')/literal/entry
entryliteral' 4.850e-04'/literal/entry
With 9.99 as the pattern, I'd expect (and
2009/8/9 Tom Lane t...@sss.pgh.pa.us:
Brendan Jurd dire...@gmail.com writes:
That would allow for a maximum of 10 exponent digits. As an aside, I
note that int4out() hardcodes the maximum number of digits rather than
exposing a constant (c.f. MAXINT8LEN in int8.c). I'm considering
adding
2009/8/9 Alvaro Herrera alvhe...@commandprompt.com:
Brendan Jurd escribió:
Here's version 6 of the patch, now with an all-new implementation
of (normalised) scientific notation in numeric.c, via the functions
numeric_out_sci() and get_str_from_var_sci(). So should now be
able
2009/8/8 Bruce Momjian br...@momjian.us:
Just to verify, this patch was about comments on composite columns, not
about dumping comments on index columns (as the subject states), right?
We do have a TODO for index column comments:
Correct.
If you scroll up a couple of messages [1] you'll see
2009/8/3 Tom Lane t...@sss.pgh.pa.us:
Uh, no, we had better support more. The actual limit of the current
numeric format is 1e+131072.
Given your comment above I'm thinking it reasonable to use an int32 to
store the exponent -- will that be safe?
That would allow for a maximum of 10 exponent
2009/8/3 Brendan Jurd dire...@gmail.com:
Okay, so Oracle just forces the output wider to accomodate the
exponent (i.e., you can't rely on it being fixed-width).
I can adjust the patch to imitate this behaviour; should be able to
post a new revision within 24 hours.
Please find attached
101 - 200 of 511 matches
Mail list logo
