Re: [Piglit] [PATCH] glsl-1.50: test gl_PrimitiveID xfb

2020-01-27 Thread Dave Airlie
On Mon, 6 Jan 2020 at 09:05, Ilia Mirkin wrote: > > This appears to trigger an issue on at least GP108 due to an odd shader > export write restriction. And we should be testing gl_PrimitiveID > anyways. > > Signed-off-by: Ilia Mirkin Reviewed-by: Dave Airlie > --- >

Re: [Piglit] [PATCH] intel_shader_atomic_float_minmax: Explicitly request std430 layout

2019-06-26 Thread Dave Airlie
On Thu, 27 Jun 2019 at 03:00, Ian Romanick wrote: > > From: Ian Romanick > > These tests preinit the ssbo contents but expect the driver to be doing > std430 packing by default, just specify std430 packing. Reviewed-by: Dave Airlie ___

[Piglit] [PATCH] ssbo/shared: fix min/max tests to specify std430

2019-06-25 Thread Dave Airlie
From: Dave Airlie These tests preinit the ssbo contents but expect the driver to be doing std430 packing by default, just specify std430 packing. --- .../execution/shared-atomicMax-int.shader_test | 2 +- .../execution/shared-atomicMax-uint.shader_test | 2

[Piglit] [PATCH] ssbo: fix min/max tests to specify std430

2019-06-25 Thread Dave Airlie
From: Dave Airlie These tests preinit the ssbo contents but expect the driver to be doing std430 packing by default, just specify std430 packing. This fixes the tests on softpipe --- .../execution/ssbo-atomicMax-int.shader_test| 2 +- .../execution/ssbo-atomicMax

Re: [Piglit] [PATCH] shader_runner: don't abort on atomic counter subtest failure

2019-05-23 Thread Dave Airlie
Reviewed-by: Dave Airlie On Fri, 24 May 2019 at 11:38, Marek Olšák wrote: > > From: Marek Olšák > > --- > tests/shaders/shader_runner.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_ru

[Piglit] [PATCH] glsl-4.60: backdate semicolon test to run from glsl 1.10

2018-06-13 Thread Dave Airlie
From: Dave Airlie Since this was a bug fix and real world apps have the old behaviour --- .../glsl-4.60/compiler/extra-semilons-at-global-scope.frag | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/spec/glsl-4.60/compiler/extra-semilons-at-global-scope.frag b

[Piglit] [PATCH] arb_gpu_shader_fp64/ssbo: add another vertex ssbo check.

2018-03-08 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This adds another checks for vertex ssbos --- tests/spec/arb_gpu_shader_fp64/vs-non-uniform-control-flow-ssbo.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/spec/arb_gpu_shader_fp64/vs-non-uniform-control-flow-ssbo.c b/test

Re: [Piglit] [PATCH] arb_gpu_shader_fp64/ssbo: fix tests to skip is no vertex ssbo available.

2018-03-07 Thread Dave Airlie
On 7 March 2018 at 17:52, Alejandro <apinhe...@igalia.com> wrote: > Typo on the commit message: "skip is no" => "skip if no" > > Some comments below. > > On 07/03/18 01:54, Dave Airlie wrote: >> From: Dave Airlie <airl...@redhat.com>

[Piglit] [PATCH] arb_gpu_shader_fp64/ssbo: fix tests to skip is no vertex ssbo available.

2018-03-06 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> These tests all require varying numbers of ssbos. --- .../shader_storage/layout-std140-fp64-mixed-shader.c | 5 + .../arb_gpu_shader_fp64/shader_storage/layout-std140-fp64-shader.c | 5 + .../shader_storage/layout-std430-fp64

Re: [Piglit] [PATCH] shader_image: fix max images if fragment shader has limited outputs.

2018-02-28 Thread Dave Airlie
On 1 March 2018 at 04:08, Francisco Jerez <curroje...@riseup.net> wrote: > Dave Airlie <airl...@gmail.com> writes: > >> From: Dave Airlie <airl...@redhat.com> >> >> This drops one from the max images as the fragment shader needs >> one output for

[Piglit] [PATCH] shader_image: fix max images if fragment shader has limited outputs.

2018-02-27 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This drops one from the max images as the fragment shader needs one output for outputing the results Signed-off-by: Dave Airlie <airl...@redhat.com> --- tests/spec/arb_shader_image_load_store/image.c | 5 - 1 file changed, 4 insertions(+)

[Piglit] [PATCH] shader_image: decrease number of images in indexing test

2018-02-27 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This decreases the indexing test to use 7 images, so it can run on GPUs which have a limit of 8 images. Signed-off-by: Dave Airlie <airl...@redhat.com> --- tests/spec/arb_shader_image_load_store/indexing.c | 12 ++-- 1 file changed,

Re: [Piglit] [PATCH 1/2] ssbo: block more tests on lack of vertex ssbo

2017-11-29 Thread Dave Airlie
> Hi. > > This patch introduced these compiler warnings. Thanks, pushed the fix. Dave. ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] arb_shader_clock: fix use of atomic counters

2017-11-29 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This test was trying to use two atomic counters at different buffer bindings, but the shader runner just allocates one bo, so just use the same binding, they will end up sequential. --- tests/spec/arb_shader_clock/execution/clock.shader_test

[Piglit] [PATCH 1/2] ssbo: block more tests on lack of vertex ssbo

2017-11-16 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> --- tests/spec/arb_shader_storage_buffer_object/array-ssbo-binding.c | 5 + .../arb_shader_storage_buffer_object/layout-std140-write-shader.c| 4 .../arb_shader_storage_buffer_object/layout-std430-write-shader.c| 5 + 3

[Piglit] [PATCH 2/2] ssbo/linker: move some linker tests to using a fragment shader ssbo

2017-11-16 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> --- .../linker/implicit_size_array_member.shader_test | 7 +++ .../linker/sized_arrays_of_arrays_member.shader_test | 6 ++ .../linker/unsized_arrays_of_arrays_member.shader_test | 7 +++ 3

[Piglit] [PATCH 1/5] ssbo: handle lack of vertex shader ssbo support in test.

2017-11-16 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> --- .../program-interface-query.c | 54 +++--- 1 file changed, 37 insertions(+), 17 deletions(-) diff --git a/tests/spec/arb_shader_storage_buffer_object/program-interface-query.c b/test

[Piglit] [PATCH 2/5] ssbo: make indirect test work on GL3.3

2017-11-16 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This uses extensions so I can test this on radeon. Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../execution/indirect.shader_test | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[Piglit] [PATCH 3/5] ssbo: make rendering test work without vertex ssbos.

2017-11-16 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> r600 doesn't have vertex ssbos, so this uses a mixture of ssbo and ubos for rendering in this case. --- .../arb_shader_storage_buffer_object/rendering.c | 141 - 1 file changed, 109 insertions(+), 32 deletions(-) diff --git a

[Piglit] [PATCH 4/5] ssbo/max-ssbo-size: handle lack of vertex shader ssbo.

2017-11-16 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> evergreen has no vertex shader ssbo, just skip on it. --- tests/spec/arb_shader_storage_buffer_object/max-ssbo-size.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/spec/arb_shader_storage_buffer_object/max-ssbo-size.c b/test

[Piglit] [PATCH 5/5] ssbo/linking: add check for vertex ssbo support.

2017-11-16 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> skip if we don't support and vertex ssbos --- ...stance-matching-shader-storage-blocks-array-size-mismatch.shader_test | 1 + ...matching-shader-storage-blocks-binding-qualifier-mismatch.shader_test | 1 + ...ance-matching-shader-storage-blocks-member

[Piglit] [PATCH] arrays_of_arrays/atomic_counter: check counters limit on linker test.

2017-10-10 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../arb_arrays_of_arrays/linker/vs-to-fs-atomic-counter.shader_test | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/arb_arrays_of_arrays/linker/vs-to-fs-atomic-counter.sh

[Piglit] [PATCH] arrays_of_arrays/atomic_counters: set requirements on atomic counter numbers.

2017-10-10 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> These both use 20 counters so check against the limits before running. Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../execution/atomic_counters/fs-simple-inc-dec-read.shader_test | 1 + .../execution/atomic_counters/vs-si

[Piglit] [PATCH] arb_shader_atomic_counter_ops: declare counters to fix undefined behaviour.

2017-10-10 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> It's undefined (including crashing) behaviour to use atomic counters without having bound enough storage for them. This fixes this test to bind the storage for the counters it uses. Signed-off-by: Dave Airlie <airl...@r

[Piglit] [PATCH] image_load_store: add a new test for a bug seen on AMD VEGA.

2017-08-24 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This is ported from a vulkan cts test showing the same brokenness. --- .../execution/image_checkerboard.shader_test | 67 ++ 1 file changed, 67 insertions(+) create mode 100644 tests/spec/arb_shader_image_load_store/exe

Re: [Piglit] [PATCH] ARB_gpu_shader_int64: test that swizzles of constants work

2017-08-20 Thread Dave Airlie
Reviewed-by: Dave Airlie <airl...@redhat.com> On 17 August 2017 at 12:20, Ilia Mirkin <imir...@alum.mit.edu> wrote: > Currently mesa produces this: > > glsl/ir_constant_expression.cpp:735: virtual ir_constant* > ir_swizzle::constant_expression_value(void*, hash_table*

Re: [Piglit] [PATCH 0/5] Add int64 conversion tests

2017-01-29 Thread Dave Airlie
ec/arb_gpu_shader_int64. Tested against radeonsi with the remaining > patches that I'm about to send to mesa-dev. Please review! > LGTM, I haven't gone too deep in looking, but idea seems sane, Acked-by: Dave Airlie <airl...@redhat.com> _

Re: [Piglit] Piglit tests that leave noise in dmesg on nvidia proprietary drivers

2016-10-20 Thread Dave Airlie
On 21 October 2016 at 12:26, Dan Kegel <d...@kegel.com> wrote: > On Thu, Oct 20, 2016 at 6:49 PM, Dave Airlie <airl...@gmail.com> wrote: >> If piglit crashes or explodes it's the driver's fault. > > Are you quite sure? There could be bugs in piglit, no? It would most

Re: [Piglit] Piglit tests that leave noise in dmesg on nvidia proprietary drivers

2016-10-20 Thread Dave Airlie
On 21 October 2016 at 05:56, Dan Kegel wrote: > I guess the underlying question is "how much work would it > be to get piglit to the point where errors it reports when > run against nvidia's proprietary drivers are actual problems in those > drivers". > I suspect it'd be a good

Re: [Piglit] [PATCH] generators: Add extensions requirements to gen_constant_array_size_tests

2016-07-06 Thread Dave Airlie
Reviewed-by: Dave Airlie <airl...@redhat.com> On 7 July 2016 at 05:31, Dylan Baker <dy...@pnwbakers.com> wrote: > This fixes int64 failures. > > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> > --- > generated_tests/gen_constant_array_size_tests.p

[Piglit] [PATCH] builtin_function: try and use casts for 64-bits instead of dtype setting.

2016-07-04 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> The dtype setting only works with numpy 1.9 and above, which doesn't seem to be in most distros yet. Reported-by: Jose Fonseca <jfons...@vmware.com> Signed-off-by: Dave Airlie <airl...@redhat.com> --- generated_tests/builti

[Piglit] [PATCH] arb_gpu_shader_int64: generate int64 conversion tests.

2016-06-19 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This is "ported" from the fp64 conversion generator, it probably has a lot of stuff left over it shouldn't, but it does generate the tests I expected to test 64-bit integer conversions both implicit and explicit. Signed-off-by: D

Re: [Piglit] [PATCH 2/2] arb_gpu_shader_int64: add builtin test generator.

2016-06-09 Thread Dave Airlie
On 10 June 2016 at 13:40, Dave Airlie <airl...@gmail.com> wrote: >> No, you can't use int and long here, python 3 doesn't have a long type >> at all, and it's int will grow until it uses all of your memory if you >> ask it to, while python2 has an int and long th

Re: [Piglit] [PATCH 2/2] arb_gpu_shader_int64: add builtin test generator.

2016-06-09 Thread Dave Airlie
> No, you can't use int and long here, python 3 doesn't have a long type > at all, and it's int will grow until it uses all of your memory if you > ask it to, while python2 has an int and long that are equivalent to int > and long in C for your architecture. You'll need to use the numpy types >

[Piglit] [PATCH] arb_gpu_shader_int64: add test generation to standard testing template

2016-06-09 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> Rather than forking this code further, I've just added support to the standard generator for the 64-bit tests. This relies on the shader_runner int64 support. Signed-off-by: Dave Airlie <airl...@redhat.com> --- generated_tests/builtin

[Piglit] [PATCH 1/2] shader_runner: add arb_gpu_shader_int64 support.

2016-06-08 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This adds support for 64-bit integer uniforms to shader_runner infrastructure. Signed-off-by: Dave Airlie <airl...@redhat.com> --- tests/shaders/shader_runner.c | 97 +++ 1 file changed, 97 insertions(+)

[Piglit] [PATCH 2/2] arb_gpu_shader_int64: add builtin test generator.

2016-06-08 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> Like the normal and fp64 generators, this generates a bunch of the built-in tests for use with shader_runner --- generated_tests/CMakeLists.txt |5 + generated_tests/builtin_function_int64.py

[Piglit] [PATCH] dsa/xfb: make the buffer large enough.

2016-05-30 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This bug in the test was triggered by a fix to mesa, the test creates a backing buffer smaller than the xfb range it requests then is surprised when it gets returned a truncated value for the size. Signed-off-by: Dave Airlie <airl...@redhat.com>

[Piglit] [PATCH] arb_shader_storage_buffer_object: test unsized vs implicit arrays.

2016-05-24 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This tests the difference between an unsized and an implicitly sized array This removes a compiler test as this will be a linker error now. The rules are you can have a [] array as long as the shader later implicitly sizes it. Signed-off-by: Dave

Re: [Piglit] [PATCH 0/4] Additional tests for ARB_vertex_attrib_64bit extension

2016-05-18 Thread Dave Airlie
nding bug to add support > for this extension into the i965 shader backend at: > > https://bugs.freedesktop.org/show_bug.cgi?id=94442 > > Cheers, > Andres (on behalf of the team that worked on this). I've had a quick look, so Acked-by: Dave Airlie <airl...@redhat.com> > > A

[Piglit] [PATCH 1/2] arb_separate_shader_objects: test linking of anon structs.

2016-05-16 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> I'm not 100% sure this an SSO test, but I just designed it from some UE4 failures we were seeing. Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../execution/anon-structs.shader_test | 32 ++ 1 file

[Piglit] [PATCH 2/2] arb_separate_shader_objects: test for same struct redeclaration

2016-05-16 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> As for previous test, suggestions for a better location, This tests redeclaring a struct like UE4 does works with mesa. Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../execution/redecl-struct.shader_test| 35 +

Re: [Piglit] [PATCH] gen_flat_interpolation_qualifier.py: Adds non-flat interpolation tests generator

2016-04-18 Thread Dave Airlie
Acked-by: Dave Airlie <airl...@redhat.com> On 18 April 2016 at 23:06, Andres Gomez <ago...@igalia.com> wrote: > Hi, > > this patch is still unreviewed. > > We'd welcome some help to get this into piglit with guarantees that the > tests added are OK :) > > Br. &

Re: [Piglit] [PATCH 0/8] Additional tests for ARB_gpu_shader_fp64 extension

2016-04-18 Thread Dave Airlie
On 18 April 2016 at 23:01, Andres Gomez wrote: > Hi Dave, > > can I, then, assume a "ack-b" from you for the all the patches but the > 3/8 and 5/8? Yup, you should be able to run the SSBO one against softpipe now in master, I'm not sure why the GetUniform test would fail,

Re: [Piglit] [PATCH 0/8] Additional tests for ARB_gpu_shader_fp64 extension

2016-04-05 Thread Dave Airlie
On 5 April 2016 at 18:09, Andres Gomez wrote: > Hi, > > this series is, for the most of it, still unreviewed. > > We'd welcome some help to get this into piglit with guarantees that the > tests added are OK :) Do the pass against softpipe/llvmpipe? I'd ack any that do, let me

Re: [Piglit] [PATCH 00/21] Tests for ARB_internalformat_query2 extension

2016-03-03 Thread Dave Airlie
I've spent immense amount of times looking at these tests, but it seems fairly sane, so I'm happy to give Acked-by: Dave Airlie <airl...@redhat.com> and for them to be merged. Dave. ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] ssbo: fix rendering test to check for vertex ssbo support.

2016-02-14 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This tests uses vertex ssbo's which fglrx on evergreen doesn't do, so refuse to run in this case. Signed-off-by: Dave Airlie <airl...@redhat.com> --- tests/spec/arb_shader_storage_buffer_object/rendering.c | 6 ++ 1 file changed, 6 inserti

[Piglit] [PATCH] arb_shader_storage_buffer_object: add missing GLSL versions.

2016-01-26 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> No GLSL version implies GLSL 1.10, but that isn't supported by fglrx in core profiles. This lets the tests run and fail in more interesting ways on fglrx. Signed-off-by: Dave Airlie <airl...@redhat.com> --- tests/spec/arb_shader_storage_buffe

Re: [Piglit] [PATCH] xts: Add a rendercheck case for a bug I made in glamor.

2016-01-21 Thread Dave Airlie
On 22 January 2016 at 12:37, Eric Anholt <e...@anholt.net> wrote: > Drawing to a8 is special now, and I missed it in the CA path. > --- Reviewed-by: Dave Airlie <airl...@redhat.com> ___ Piglit mailing list Piglit@lists.fr

Re: [Piglit] [PATCH 3/7] all.py: Add arb_viewport_array-render-viewport-2

2015-12-24 Thread Dave Airlie
Acked-by: Dave Airlie <airl...@redhat.com> On 24 December 2015 at 10:34, <baker.dyla...@gmail.com> wrote: > From: Dylan Baker <baker.dyla...@gmail.com> > > This was never added in the initial commit. > > cc: Brian Paul <bri...@vmware.com> > cc:

[Piglit] [PATCH] ARB_viewport_index: add a rendering test using geom shader invocations.

2015-12-10 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This is based of a CTS test GL41-CTS.viewport_array.draw_mulitple_viewports_with_single_invocation It currently passes on Haswell, but appears to fail on radeonsi/r600 --- tests/spec/arb_viewport_array/CMakeLists.gl.txt | 1 + test

[Piglit] [PATCH] arb_shader_subroutine/arb_shader_fp64: test returning doubles from subroutines

2015-12-10 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This found a bug in the mesa/st code, and is inspired by GL41-CTS.shader_subroutine.two_subroutines_single_subroutine_uniform from CTS. Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../two-subroutines-double-array.shader_tes

[Piglit] [PATCH] glsl-1.50: enhance vs input test to include matrix inputs.

2015-12-10 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This exercises a bug in mesa when vertex inputs are matrices and we return the wrong location to GetAttribLocation. Signed-off-by: Dave Airlie <airl...@redhat.com> --- tests/spec/glsl-1.50/execution/vs-input-arrays.c | 43

[Piglit] [PATCH] arb_tessellation_shader/arb_gpu_shader_fp64: test dmat4x3

2015-12-07 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This test passes a dmat4x3 from vs->tcs->tes->fs. Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../execution/dmat-vs-gs-tcs-tes.shader_test | 80 ++ 1 file changed, 80 insertions(+) create mo

[Piglit] [PATCH] arb_tessellation_shader/arb_gpu_shader_fp64: pass a dvec3

2015-12-07 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This passes a dvec3 through vs->tcs->tes->fs. This hits a bug in the glsl->tgsi code. --- .../execution/dvec3-vs-tcs-tes.shader_test | 79 ++ 1 file changed, 79 insertions(+) create mode

Re: [Piglit] [PATCH 1/2] arb_gpu_shader_fp64: fix wrong use of GLSL version

2015-11-18 Thread Dave Airlie
On 19 November 2015 at 02:05, Emil Velikov wrote: > On 17 November 2015 at 15:25, Samuel Pitoiset > wrote: >> piglit_require_GLSL_version() requires an integer as parameter, not a float. >> This fixes an implicit conversion spotted by Clang.

Re: [Piglit] [PATCH 1/2] arb_gpu_shader_fp64: fix wrong use of GLSL version

2015-11-17 Thread Dave Airlie
On 18 November 2015 at 01:25, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > piglit_require_GLSL_version() requires an integer as parameter, not a float. > This fixes an implicit conversion spotted by Clang. > > Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.co

Re: [Piglit] [PATCH v2] winsys-framework Default to showing window

2015-11-17 Thread Dave Airlie
On 18 November 2015 at 05:49, Arthur Huillet <arthur.huil...@free.fr> wrote: > Thanks :) > > Reviewed by: Arthur Huillet <ahuil...@nvidia.com> Reviewed-by: Dave Airlie <airl...@redhat.com> > > On Tue, 17 Nov 2015 11:33:31 -0800 > Alex Goins <ago...@nv

Re: [Piglit] [PATCH] framework: resmove es3conform support

2015-11-10 Thread Dave Airlie
On 11 November 2015 at 08:52, Eric Anholt wrote: > baker.dyla...@gmail.com writes: > >> From: Dylan Baker >> >> This is the old Khronos suite, which has been superseded by CTS. Since >> piglit can wrap cts it seems rather silly to have both CTS and >>

Re: [Piglit] [PATCH] winsys-framework Default to showing window

2015-11-08 Thread Dave Airlie
On 21 August 2015 at 22:08, Marek Olšák wrote: > Hi Alex, > > The tests which don't specifically test the behavior of the default > framebuffer should use -fbo. I think this is done by marking a test as > "concurrent" in all.py. A lot of tests don't do that, because nobody > had

Re: [Piglit] [PATCH] getteximage-depth: new test to create/readback depth textures

2015-11-05 Thread Dave Airlie
> > piglit_require_extension("GL_ARB_depth_texture") It's checked in the logic up above for the test sets. In theory I was hoping to expand this test to cover non-depth/stencil cases, but since they are mostly covered already I didn't expend the time right now. But I'd like to get to it at some

[Piglit] [PATCH] getteximage-depth: new test to create/readback depth textures

2015-11-02 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> for every supported target for all the depth/stencil formats this creates a texture, and then uses glGetTexImage to read it back. --- tests/texturing/CMakeLists.gl.txt | 1 + tests/texturing/getteximage-depth.c

Re: [Piglit] [PATCH 0/7] Add tests for ARB_vertex_attrib_binding

2015-10-16 Thread Dave Airlie
Hey Fredrik, were you going to finish these with Eric's comments? Dave. On 12 July 2013 at 14:16, Fredrik Höglund wrote: > All the tests pass on Mesa with my WIP implementation of the extension. > I don't know if they pass on other implementations though, so it would > be good

[Piglit] [PATCH] arb_gpu_shader_fp64: expand get uniform even further.

2015-10-11 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> Ilia pointed out the fix patch didn't go far enough, so add some tests to cover more cases, specifically: a) reading from a dvec4 into a float b) reading from a vec4 into doubles. Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../arb_gpu

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: expand get uniform even further.

2015-10-11 Thread Dave Airlie
On 12 October 2015 at 13:05, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Sun, Oct 11, 2015 at 11:02 PM, Dave Airlie <airl...@gmail.com> wrote: >> From: Dave Airlie <airl...@redhat.com> >> >> Ilia pointed out the fix patch didn't go far enough, s

[Piglit] [PATCH] arb_gpu_shader_fp64: test passing an array from vs->gs->fs works.

2015-10-11 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This adds two variants on the same basic test, passing an array of values from vs->gs->fs. The second variant just initialised the array from 64-bit attributes. Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../executi

[Piglit] [PATCH] tess/fp64: add some basic cross over tests

2015-09-30 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> CTS tests this a lot better than piglit, but this is a good place to start, I've got a bunch of fixes queued for mesa to address some of these problems. This adds 3 tests: simple double vs->tcs->tes->fs simple dvec2 vs->tcs->tes->fs

[Piglit] [PATCH] arb_gpu_shader_fp64: expand getuniform double coverage

2015-09-30 Thread Dave Airlie
values with GetUniformdv, and getting double values with float/int/uint interfaces. notes: currently mesa fails this. Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../arb_gpu_shader_fp64/execution/getuniformdv.c | 92 -- 1 file changed, 86 insertions(+), 6 del

[Piglit] [PATCH] arb_shader_subroutine: add a vertex shader test

2015-09-30 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This tests vertex shaders work with shader subroutine. Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../execution/vs-simple-subroutine.shader-test | 52 ++ 1 file changed, 52 insertions(+) create mode 100644

Re: [Piglit] [Announce] Summary updates have arrived

2015-09-23 Thread Dave Airlie
I'm not sure if it's related, but I'm not seeing the command lines in the html summary anymore. Dave. On 23 September 2015 at 08:05, Dylan Baker wrote: > Just a heads up. My series reworking summaries had landed. > > Most of this work is meant to be user-transparent,

[Piglit] [PATCH] glsl-1.10: test for rotating a variable components in a loop

2015-09-01 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This test fails on r600 with sb enabled, it does something similiar to what a lot of the CTS test cases do. Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../fs-while-loop-rotate-value.shader_test | 32 ++ 1

Re: [Piglit] [PATCH] ext_texture_integer: add new tex formats test

2015-08-31 Thread Dave Airlie
On 1 September 2015 at 09:21, Brian Paul wrote: > Test glTexImage2D() and glGetTexImage() with a variety of internalFormats > and user formats/types. > > Note: currently fails with Mesa, passes with NVIDIA. As requested this passes on mesa with my format patches applied.

Re: [Piglit] [PATCH] arb_transform_feedback3: test for an incorrect assert in mesa/st

2015-07-30 Thread Dave Airlie
On 30 July 2015 at 19:50, Marek Olšák mar...@gmail.com wrote: On Thu, Jul 30, 2015 at 2:52 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This test hits an assert in the state tracker from the API. Signed-off-by: Dave Airlie airl...@redhat.com --- .../spec

[Piglit] [PATCH] arb_gpu_shader_fp64: test glGetUniformdv interface

2015-07-26 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com I must have forgot this way back when, this just ports the getuniform02.c test to glsl 1.50 and tests the fp64 interface. Signed-off-by: Dave Airlie airl...@redhat.com --- tests/all.py | 1 + .../execution

Re: [Piglit] [PATCH] Test interpolateAtSample with dynamically nonuniform values

2015-07-23 Thread Dave Airlie
On 24 July 2015 at 02:00, Neil Roberts n...@linux.intel.com wrote: Adds a test which is similar to interpolateAtSample-different except that it draws a triangle which covers more than one fragment and makes sure to use a different sample ID for each fragment so that it won't be dynamically

Re: [Piglit] [PATCH] Test that interpolateAtSample returns different results

2015-07-21 Thread Dave Airlie
to use sample 0. Reviewed-by: Dave Airlie airl...@redhat.com --- tests/all.py | 2 + tests/spec/arb_gpu_shader5/CMakeLists.gl.txt | 1 + .../interpolateAtSample-different.c| 259 + 3 files changed, 262

[Piglit] [PATCH] texwrap: skip if integers or offset used with non-2D

2015-07-08 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com The test doesn't support these cases yet, since the shaders are hardcoded to use 2D samplers. Signed-off-by: Dave Airlie airl...@redhat.com --- tests/texturing/texwrap.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/texturing/texwrap.c b

Re: [Piglit] [PATCH] arb_blend_func_extended: output-location api test

2015-07-08 Thread Dave Airlie
On 3 July 2015 at 17:39, Tapani Pälli tapani.pa...@intel.com wrote: Linking should fail, test passes on NVIDIA's proprietary driver version 346.59 but crashes currently on i965 driver. Signed-off-by: Tapani Pälli tapani.pa...@intel.com Reviewed-by: Dave Airlie airl...@redhat.com

Re: [Piglit] [PATCH 1/2] xts: Add a profile for just the rendering tests.

2015-07-08 Thread Dave Airlie
On 9 July 2015 at 07:38, Eric Anholt e...@anholt.net wrote: Many X developers work on rendering code, and don't really care about the rest of xts. This is our equivalent of GL's quick.py. For the series, Reviewed-by: Dave Airlie airl...@redhat.com --- tests/xts-render.py | 32

[Piglit] [PATCH] arb_gpu_shader_fp64: add some tests for indirect double accesses

2015-06-29 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com while developing for llvmpipe, I realised we weren't testing indirect access to double arrays, so I wrote some tests. double array temp src double array temp dst double array constant src. Signed-off-by: Dave Airlie airl...@redhat.com --- .../fs-indirect

[Piglit] [PATCH] arb_gpu_shader5: add textureSize sampler indexing tests

2015-06-21 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com softpipe takes a different path for textureSize, so test it as well just in case other drivers do similiar. Signed-off-by: Dave Airlie airl...@redhat.com --- .../fs-simple-texture-size.shader_test | 68 ++ 1 file changed, 68

Re: [Piglit] [PATCH 00/40] Replace vpfp-generic with shader_runner.

2015-06-07 Thread Dave Airlie
On 7 June 2015 at 12:11, Kenneth Graunke kenn...@whitecape.org wrote: Hi all, This patch series ports all vpfp-generic tests to shader_runner, and then deletes vpfp-generic. A bit of history: - vpfp-generic was introduced by Nicolai Hähnle in 2009, as a generic

Re: [Piglit] [PATCH 00/40] Replace vpfp-generic with shader_runner.

2015-06-07 Thread Dave Airlie
On 8 June 2015 at 15:31, Kenneth Graunke kenn...@whitecape.org wrote: On Monday, June 08, 2015 06:29:26 AM Dave Airlie wrote: On 7 June 2015 at 12:11, Kenneth Graunke kenn...@whitecape.org wrote: Hi all, This patch series ports all vpfp-generic tests to shader_runner, and then deletes

Re: [Piglit] [PATCH] texwrap: test wrapping texture offsets

2015-05-27 Thread Dave Airlie
case GL_MIRROR_CLAMP_EXT: @@ -862,6 +868,10 @@ static void draw(const struct format_desc *format, scale[0] = scale[1] = scale[2] = scale[3] = 1.0/((1ull (bits-1))-1); glUseProgram(prog_int); glUniform4fv(int_scale_loc, 1, scale); +

[Piglit] [PATCH] texwrap: test wrapping texture offsets

2015-05-26 Thread Dave Airlie
while writing softpipe support I realised we didn't have tests for any of this, this just adds a new parameter to texwrap to test texture offsets, Signed-off-by: Dave Airlie airl...@redhat.com --- tests/texturing/texwrap.c | 66 +-- 1 file changed, 64

[Piglit] [PATCH] arb_gpu_shader_fp64: make sure implicit double-float doesnt' happen

2015-05-06 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Mesa is allowing this right now, so add a test to make it not happen again. Signed-off-by: Dave Airlie airl...@redhat.com --- .../compiler/implicit-conversion-bad.vert | 30 ++ 1 file changed, 30 insertions(+) create mode 100644

[Piglit] [PATCH 1/2] shader_runner: add ARB_shader_subroutine support (v3)

2015-04-23 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This adds basic support for executing shader subroutine tests. it comes with two intro tests, and probably a lot of bugs. tested against NVIDIA, for some reason -auto fails here. v2: add support for other shader types (Ilia) v2.1: fix printf v3: rework code

[Piglit] [PATCH] arb_texture_stencil8: add initial texture interface test (v2)

2015-04-07 Thread Dave Airlie
this just checks the basic API works, and that 3D is rejected. v2: add 1d/2d/cube array support (Anuj) Signed-off-by: Dave Airlie airl...@redhat.com --- tests/spec/CMakeLists.txt | 1 + tests/spec/arb_texture_stencil8/CMakeLists.gl.txt | 14 ++ tests/spec

Re: [Piglit] [PATCH 1/3] arb_vertex_attrib_64bit: add simple vertex input fp64 test

2015-04-07 Thread Dave Airlie
On 24 February 2015 at 11:30, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Feb 23, 2015 at 8:26 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This is just a simple 64-bit vertex attrib test. Signed-off-by: Dave Airlie airl...@redhat.com --- .../execution

[Piglit] nvidia fails with -auto was Re: [PATCH] drawpixels-color-index: new test for glDrawPixels(GL_COLOR_INDEX)

2015-04-07 Thread Dave Airlie
On 19 February 2015 at 02:40, Brian Paul bri...@vmware.com wrote: To exercise a Mesa failure after the format overhaul. Note: this test fails on nvidia if the -auto option is given. I noticed this on a bunch of tests I was writing, anyone got any idea when this started, if I had to guess at

[Piglit] [PATCH 2/2] arb_vertex_attrib_64bit: pass a 64-bit vertex attrib through to frag shader (v2)

2015-04-07 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Check the double value unpacks cleanly in the fragment shader. v2: just use a uniform to check value. Signed-off-by: Dave Airlie airl...@redhat.com --- .../execution/vs-fs-pass-vertex-attrib.shader_test | 50 ++ 1 file changed, 50

[Piglit] [PATCH 1/2] arb_vertex_attrib_64bit: add simple vertex input fp64 test

2015-04-07 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This just tests a single 64-bit attrib input that is truncated and used as position. Signed-off-by: Dave Airlie airl...@redhat.com --- .../execution/vs-fp64-input-trunc.shader_test | 36 ++ 1 file changed, 36 insertions(+) create

[Piglit] [PATCH 2/3] arb_vertex_attrib_64bit: use a dvec3 input

2015-04-07 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This just tests a dvec3 input takes up the correct amount of space. Signed-off-by: Dave Airlie airl...@redhat.com --- .../execution/vs-dvec3-input.shader_test | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 tests

[Piglit] [PATCH 1/3] arb_vertex_attrib_64bit: exercise the VertexAttribL interfaces

2015-04-07 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com this just writes attribs and reads the current value back. Signed-off-by: Dave Airlie airl...@redhat.com --- tests/all.py | 5 + tests/spec/CMakeLists.txt | 1 + tests/spec

[Piglit] [PATCH 7/9] arb_clear_buffer_object: add stencil index to invalid formats list.

2015-04-06 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Signed-off-by: Dave Airlie airl...@redhat.com --- tests/spec/arb_clear_buffer_object/invalid-internal-format.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/arb_clear_buffer_object/invalid-internal-format.c b/tests/spec

[Piglit] [PATCH 3/9] arb_texture_stencil8: add basic get teximage

2015-04-06 Thread Dave Airlie
This just tests the get tex image path works okay for stencil8 textures. Signed-off-by: Dave Airlie airl...@redhat.com --- tests/spec/arb_texture_stencil8/CMakeLists.gl.txt | 1 + tests/spec/arb_texture_stencil8/getteximage.c | 98 +++ 2 files changed, 99 insertions

[Piglit] [PATCH 5/9] fbo-formats: add texture_stencil8 support

2015-04-06 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Make sure to disable stencil textures everywhere we disable depth ones. Signed-off-by: Dave Airlie airl...@redhat.com --- tests/fbo/fbo-alphatest-formats.c | 1 + tests/fbo/fbo-blending-formats.c | 3 ++- tests/fbo/fbo-clear-formats.c

[Piglit] [PATCH 1/9] arb_texture_stencil8: add initial texture interface test

2015-04-06 Thread Dave Airlie
this just checks the basic API works, and that 3D is rejected. Signed-off-by: Dave Airlie airl...@redhat.com --- tests/spec/CMakeLists.txt | 1 + tests/spec/arb_texture_stencil8/CMakeLists.gl.txt | 14 ++ tests/spec/arb_texture_stencil8/CMakeLists.txt| 1 + tests

[Piglit] [PATCH 8/9] texwrap: add GL_ARB_texture_stencil8 support

2015-04-06 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Signed-off-by: Dave Airlie airl...@redhat.com --- tests/texturing/texwrap.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/texturing/texwrap.c b/tests/texturing/texwrap.c index 88afe4e..7be19a5 100644 --- a/tests

Re: [Piglit] [PATCH] generator: clear before rendering with the builtin tests

2015-04-05 Thread Dave Airlie
On 27 March 2015 at 12:18, Ilia Mirkin imir...@alum.mit.edu wrote: Can we just make shader_runner do a clear automatically? This has happened to me a number of times. I'm not sure we should do that though, I don't really like the idea of shader runner doing an implicit behavioural change, but

  1   2   >