D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 75883. trmdi added a comment. Improve code style REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=75879=75883 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27458 AFFECTED FILES

D27457: Move kcminit_startup and kded to plasma-session

lbeltrame added a comment. This completely breaks startup in my system and in openQA: https://openqa.opensuse.org/tests/1177118#step/finish_desktop/6 (Notice that there is *no* desktop loaded). Basically many programs that start early complain that the Qt plugin can't be found

Re: 2 kirigami fixes for a point release

In data martedì 18 febbraio 2020 04:03:05 CET, Nate Graham ha scritto: > think KDE software should be presented to users. Basically, we > acknowledge that Neon is already an actual OS--the "KDE OS"--and we Please don't suggest such downstream-hostile solutions, in particular because this

D27199: [Applet]Update layout based on T10470

ngraham added a comment. Thanks. Done: https://bugs.kde.org/show_bug.cgi?id=417816 REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27420: [Applet]Improvements for unavailable port.

ngraham accepted this revision. ngraham added a comment. LGTM. #plasma folks? REPOSITORY R115 Plasma Audio Volume Applet BRANCH freeThePort (branched from master) REVISION DETAIL https://phabricator.kde.org/D27420 To: gvgeo, #plasma, drosca,

D27422: [KCM]Update Device item layout based on applet

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. #plasma folks? In D27422#612797 , @gvgeo wrote: > Remove PlasmaComponents. > > So..

D27282: [Applet]Correct raise max volume functions for mic

ngraham added a comment. Looks like it. REPOSITORY R115 Plasma Audio Volume Applet BRANCH mic (branched from master) REVISION DETAIL https://phabricator.kde.org/D27282 To: gvgeo, #plasma, drosca, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27282: [Applet]Correct raise max volume functions for mic

This revision was automatically updated to reflect the committed changes. Closed by commit R115:06e9e3eebf18: [Applet]Correct raise max volume functions for mic (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27199: [Applet]Update layout based on T10470

jgrulich added a comment. In D27199#613246 , @ngraham wrote: > In D27199#612689 , @jgrulich wrote: > > > This is probably not related to the UI, it might be issue in the internals. Can you open a

D27205: [Applet]Always get valid device and stream name

This revision was automatically updated to reflect the committed changes. Closed by commit R115:830bded4d30b: [Applet]Always get valid device and stream name (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27469: Made a new variable called 'baseSize' for use by both itemSize value possibilities

ngraham added a comment. Seems like this was created by accident. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27469 To: The-Feren-OS-Dev Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D26660: [Applets/Task Manager] Fix and improve behavior tab layouts

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c32b5a85cae6: [Applets/Task Manager] Fix and improve behavior tab layouts (authored by gvgeo, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 75879. trmdi added a comment. Use asyncCall REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=75828=75879 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27458 AFFECTED FILES

D27453: [Applet]Update toolbar's checkbox spacing

This revision was automatically updated to reflect the committed changes. Closed by commit R116:88b8ce5e50b7: [Applet]Update toolbars checkbox spacing (authored by gvgeo, committed by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27391: [Applet]Fix dimensions of traffic Monitor

This revision was automatically updated to reflect the committed changes. Closed by commit R116:4ca1e7e34fd6: [Applet]Fix dimensions of traffic Monitor (authored by gvgeo, committed by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27391: [Applet]Fix dimensions of traffic Monitor

ngraham accepted this revision. ngraham added a comment. LGTM! REPOSITORY R116 Plasma Network Management Applet BRANCH monitor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27391 To: gvgeo, #plasma, #vdg, jgrulich, ngraham Cc: ngraham, broulik, plasma-devel,

D27199: [Applet]Update layout based on T10470

ngraham added a comment. In D27199#612689 , @jgrulich wrote: > This is probably not related to the UI, it might be issue in the internals. Can you open a bug for it? Ideally if you can restart plasmashell and enable plasma-nm debug Will

D27393: [Applet]Fix details layout.

This revision was automatically updated to reflect the committed changes. Closed by commit R116:2efaecee8874: [Applet]Fix details layout. (authored by gvgeo, committed by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27392: [Applet]Add info messages.

This revision was automatically updated to reflect the committed changes. Closed by commit R116:387609d10ac7: [Applet]Add info messages. (authored by gvgeo, committed by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27424: Add missing cursors for Chromium-based apps

ngraham added a comment. Landed for Plasma 5.18.1! Very nice patch. May it be the first of many! :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27424 To: guilhermesilva, #breeze, broulik, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27424: Add missing cursors for Chromium-based apps

This revision was automatically updated to reflect the committed changes. Closed by commit R31:3944c5f74d04: Add missing cursors for Chromium-based apps (authored by guilhermesilva, committed by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

Re: 2 kirigami fixes for a point release

On 2020-02-16 14:43, Albert Astals Cid wrote: Maybe i explain myself wrongly, i'm not blaming distros at all. They made a decision, we/I may agree with them or not, that's *my/our* problem, what I was disagreeing is to us having to do extra work because someone elses (the distros) decision.

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

ngraham added inline comments. INLINE COMMENTS > main.qml:44 > property bool vertical: plasmoid.formFactor === PlasmaCore.Types.Vertical > -readonly property int itemSize: > units.roundToIconSize(Math.min(Math.min(width, height), >

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 75873. The-Feren-OS-Dev added a comment. You gotta love arc/git sometimes... CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75872=75873 BRANCH D27466 (branched from master) REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 75872. The-Feren-OS-Dev added a comment. Arcanist please REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75871=75872 BRANCH D27466 (branched from master) REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 75871. The-Feren-OS-Dev added a comment. Hopefully fixed the diff again REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75870=75871 BRANCH D27466 (branched from master) REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 75870. The-Feren-OS-Dev added a comment. Updated diff to be in line with parent patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75864=75870 BRANCH arcpatch-D27465_1 REVISION DETAIL

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

The-Feren-OS-Dev updated this revision to Diff 75869. The-Feren-OS-Dev added a comment. Tidied up code a bit and introduced new baseSize variable - Slightly increase system tray icon hitboxes in Non Tablet Mode Plasma REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27469: Made a new variable called 'baseSize' for use by both itemSize value possibilities

The-Feren-OS-Dev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. The-Feren-OS-Dev requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH D27465 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27469

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

ngraham added inline comments. INLINE COMMENTS > main.qml:47 > +// Set the tray items' clickable areas on the panel to be bigger > than normal to allow for easier touchability > +return units.roundToIconSize(Math.min(Math.min(width, height), >

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. ...and now the split is complete. https://phabricator.kde.org/D27466 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham, davidre Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis,

D27467: make sure ifa_addr isn't null

sitter created this revision. sitter added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the manpage: The ifa_addr field points to a structure containing the interface address.

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

The-Feren-OS-Dev updated this revision to Diff 75863. The-Feren-OS-Dev added a comment. Got rid of unnecessary rounding of smallSpacing at the end of the Tablet Mode padding addition REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27465: Add foundations for two future patches to complete the splitting of patch D27438

The-Feren-OS-Dev updated this revision to Diff 75862. The-Feren-OS-Dev added a comment. Make the click areas of system tray icons larger in Kirigami Tablet Mode REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27465?vs=75860=75862 BRANCH master

D26813: Have user-manager write to SDDM's new config file

This revision was automatically updated to reflect the committed changes. Closed by commit R128:b2d0e463a490: Have user-manager write to SDDMs new config file (authored by filipf). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26813?vs=75007=75861

D27465: Add foundations for two future patches to complete the splitting of patch D27438

davidre added a comment. Do your second step here imo REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27465 To: The-Feren-OS-Dev, ngraham Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D27465: Added foundations for two future patches to complete the splitting of patch D27438

The-Feren-OS-Dev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. The-Feren-OS-Dev requested review of this revision. REVISION SUMMARY ngraham recommended that I split up https://phabricator.kde.org/D27438 into three patches: 1. This patch -

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. The initial patch of the three, now I've thought up a suitable way of doing this, has been made: https://phabricator.kde.org/D27465 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg,

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. There's no need for this property stuff We have: view->setScreen() (or ideally passed in the constructor, it's a lot faster) and

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. Actually, on second thought, @ngraham I'm not even sure if step 2 would even be worth it on its own, if possible. On your suggestion you have it adjusted to have step 3's tablet mode checker in step 2. If I don't have that check in place, for step 2,

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. In D27438#613097 , @ngraham wrote: > ...one to increase the spacing when in tablet mode, and another one to increase the spacing when in desktop mode. At this point each patch will be changing a different line

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev abandoned this revision. The-Feren-OS-Dev added a comment. Alright, I'll start splitting the patches up now. Marking this one as Abandoned. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham, davidre

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. In D27438#613104 , @IlyaBizyaev wrote: > I agree with @broulik in that the spacing already feels quite excessive, or at least doesn't need to be increased (: > > Does this depend on DPI/panel size maybe?

D27380: [GTK Config] Write Font without style name

gikari updated this revision to Diff 75858. gikari edited the summary of this revision. gikari added a comment. Use big helper function for constructing font style. Please test, many fonts may break and not work. REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added a comment. Since we plan to move more GTK related code to kde-gtk-config repo (specifically coloration of GTK apps from krdb), isn't it more reasonable to put this module in kde-gtk-config repo? REPOSITORY R98 Breeze for Gtk BRANCH arcpatch-D24275_1 REVISION DETAIL

D27438: Increase System Tray Plasmoid spacing value slightly

IlyaBizyaev added a comment. I agree with @broulik in that the spacing already feels quite excessive, or at least doesn't need to be increased (: Does this depend on DPI/panel size maybe? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To:

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 75856. cblack added a comment. Lower min version of CMake REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24275?vs=75205=75856 BRANCH arcpatch-D24275_1 REVISION DETAIL https://phabricator.kde.org/D24275

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

ngraham added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +cmake_minimum_required ( VERSION 3.14 ) > +project ( libcolorreload C ) As noticed by @The-Feren-OS-Dev, this is too high. REPOSITORY R98 Breeze for Gtk BRANCH arcpatch-D24275_1 REVISION DETAIL

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham added a comment. https://community.kde.org/Infrastructure/Phabricator#Marking_patches_as_dependent_on_other_patches It would probably be simplest do just do this though: 1. Abandon this patch 2. Submit a patch to refactor that logic to use a nested multi-line function for

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. How would I split it into two patches? Both patches would edit the exact same line. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham, davidre Cc: broulik, kmaterka, filipf, ndavis,

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

The-Feren-OS-Dev accepted this revision. The-Feren-OS-Dev added a comment. This revision is now accepted and ready to land. Had to lower the cmake version requirement to be able to compile this, but this works just fine, and it's definitely something that'd be nice to have. I can't see any

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham added a comment. This should probably be two patches at this point: one to increase the spacing when using tablet mode (which IMO is an uncontroversial no-brainer) and another to increase the spacing when in desktop mode. INLINE COMMENTS > main.qml:45 > +// If

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev updated this revision to Diff 75851. The-Feren-OS-Dev added a comment. Tweaked an added comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75850=75851 BRANCH master REVISION DETAIL

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. In D27438#613051 , @davidre wrote: > In D27438#613050 , @The-Feren-OS-Dev wrote: > > > In D27438#612719 , @davidre

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev updated this revision to Diff 75850. The-Feren-OS-Dev added a comment. Changed method used for increasing spacing between tray icons to something that increases hitbox sizes as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

bport added inline comments. INLINE COMMENTS > DeviceAutomounterKCM.cpp:84 > saveLayout(); > +delete m_settings; > } We can also change kcfgc to add parent in constructor REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27127 To: meven, ervin,

D27438: Increase System Tray Plasmoid spacing value slightly

davidre added a comment. In D27438#613050 , @The-Feren-OS-Dev wrote: > In D27438#612719 , @davidre wrote: > > > There is now not clickable space between items: > > F8108239: grafik.png

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. In D27438#612719 , @davidre wrote: > There is now not clickable space between items: > F8108239: grafik.png F8108241: grafik.png

D27052: Solid-device-automounter/kcm: Convert some foreach

ervin added inline comments. INLINE COMMENTS > meven wrote in DeviceAutomounter.cpp:73 > Unfortunately this is not possible line 78 requires a non-const ref to volume. const auto for volumes was possible though. I wonder if it wouldn't have made sense to have a non const ref in the loop then.

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

meven updated this revision to Diff 75847. meven marked 2 inline comments as done. meven added a comment. Add a missing space, improve comment as suggested REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27024?vs=74667=75847 BRANCH arcpatch-D27024

D27116: KCM/Component email: simplify code

meven updated this revision to Diff 75846. meven marked an inline comment as done. meven added a comment. Fix a couple missing spaces REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27116?vs=74897=75846 BRANCH arcpatch-D27116 REVISION DETAIL

D27407: Breeze widgetStyle value is Breeze

crossi added a comment. Will do in a separate commit. I guess it's more or less related to the KCM Style. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham Cc: ngraham, plasma-devel, Orage,

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven updated this revision to Diff 75845. meven marked 2 inline comments as done. meven added a comment. Add a delete for m_settings, move m_devices to ctor intialization REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27127?vs=74925=75845 BRANCH

D27442: fix(kcm): use explicit Kirigami.Units over singleton from a theme

This revision was automatically updated to reflect the committed changes. Closed by commit R104:357df7c5c48a: fix(kcm): use explicit Kirigami.Units over singleton from a theme (authored by davidedmundson). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75844. bport added a comment. Add missing space REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75813=75844 REVISION DETAIL https://phabricator.kde.org/D27156 AFFECTED FILES kcms/fonts/CMakeLists.txt

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1123cc4d0b59: [desktoppackage] Fix layout when an applet has no custom config modules (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27052: Solid-device-automounter/kcm: Convert some foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R119:efdf88ec48b4: Solid-device-automounter/kcm: Convert some foreach (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27052?vs=75840=75841#toc REPOSITORY R119 Plasma Desktop

D27052: Solid-device-automounter/kcm: Convert some foreach

meven added inline comments. INLINE COMMENTS > ervin wrote in DeviceAutomounter.cpp:73 > nitpick, feel free to ignore: would make sense to switch to a const ref here > since we're touching the line anyway. in the same vein, "const auto" on the > line before wouldn't be a bad idea either (if we

D27052: Solid-device-automounter/kcm: Convert some foreach

meven updated this revision to Diff 75840. meven marked an inline comment as done. meven added a comment. Add a space REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27052?vs=74803=75840 BRANCH arcpatch-D27052_1 REVISION DETAIL

D27407: Breeze widgetStyle value is Breeze

ngraham added a comment. Separate commit is probably fine, but if this lands on the stable branch, it should come soon. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham Cc: ngraham,

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

wstephenson added a comment. There is a change to the QML missing from this diff as it stands, will amend it tomorrow REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27353 To: wstephenson, #plasma, ivan, davidedmundson Cc: plasma-devel, Orage, LeGast00n,

D27424: Add missing cursors for Chromium-based apps

broulik accepted this revision. broulik added a comment. Cool, thanks! I was totally oblivious of the fact the page had three columns :) This can go into 5.18 I'd say REPOSITORY R31 Breeze BRANCH breeze-symlinks (branched from master) REVISION DETAIL

D27461: Sync Plasma theme settings instead of copying the plasmarc file

filipf added inline comments. INLINE COMMENTS > sddmauthhelper.cpp:138 > +QSharedPointer themeConfig = > openConfig(themeConfigLocation); > + > themeConfig->group(QStringLiteral("Theme")).writeEntry(QStringLiteral("name"), > args[QStringLiteral("plasmaTheme")].toString()); > +

D27462: Include comment for translators for Power Down

apol created this revision. apol added reviewers: broulik, aacid. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Should hopefully make it less confusing REPOSITORY R122 Powerdevil BRANCH master REVISION

D27461: Sync Plasma theme settings instead of copying the plasmarc file

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The first and the easiest part of finishing T12710 . Instead of copying the user's plasmarc

D27457: Move kcminit_startup and kded to plasma-session

This revision was automatically updated to reflect the committed changes. Closed by commit R120:930e991b0e7e: Move kcminit_startup and kded to plasma-session (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27457?vs=75827=75834

D27458: Set a better position for Krunner in wayland

apol added a comment. +1 on fixing this INLINE COMMENTS > view.cpp:240 > +QDBusInterface strutManager("org.kde.plasmashell", "/StrutManager", > "org.kde.PlasmaShell.StrutManager"); > +QDBusReply pr = strutManager.call("availableScreenRect", > shownOnScreen->name()); > +

D27391: [Applet]Fix dimensions of traffic Monitor

gvgeo updated this revision to Diff 75832. gvgeo added a comment. Added comment. Hope it is not semi-random-looking anymore. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27391?vs=75770=75832 BRANCH monitor (branched from

D27199: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 75831. gvgeo edited the summary of this revision. gvgeo added a dependency: D27392: [Applet]Add info messages.. gvgeo added a comment. Changes: Removed some parts that were split into separate patches. Reintroduce background. Moved highlight in

D27391: [Applet]Fix dimensions of traffic Monitor

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Accepting from my side. I'll wait for Nate to do the final review as I don't consider myself expert to QML and UI. REPOSITORY R116 Plasma Network Management Applet BRANCH monitor

D27458: Set a better position for Krunner in wayland

trmdi created this revision. trmdi added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY In wayland, QScreen::availableGeometry() returns QScreen::geometry(), we could get a

D27457: Move kcminit_startup and kded to plasma-session

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN Used it to start plasma REPOSITORY R120 Plasma Workspace BRANCH apol/kdedkcmtosession REVISION DETAIL

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

crossi added inline comments. INLINE COMMENTS > fontsaasettings.cpp:305 > +{ > +if(dpi() == newDPI) { > +return; add space between `if` and `(` please REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27156 To: bport, #plasma, ervin, crossi, meven

D27457: Move kcminit_startup and kded to plasma-session

apol updated this revision to Diff 75827. apol added a comment. Removed unused code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27457?vs=75826=75827 BRANCH apol/kdedkcmtosession REVISION DETAIL https://phabricator.kde.org/D27457 AFFECTED

D27380: [GTK Config] Write Font without style name

bport added a comment. I just read bug report again and the from seems to came from , not from localization. By the way I neved end with localized style, how do you achieve that ? (I mean even in UI) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D27380: [GTK Config] Write Font without style name

bport added a comment. I think a good fix can be to use @davidedmundson solution combined with a check to know if font styleName is not set (if it set it will be not translated. I think QFont yourFont = QFont(...); auto f = QFontInfo(youFont) f.styleName(); <<= is in theory empty

Monday meeting notes from 17/2/2020

Kai Uwe: Notifications: * File transfer labels in details section only grow, never shrink * Keeps the dialog from constantly resizing when copying many small files * Fixed Telegram to check action ID when invoked, in preparation for new quick reply API using the action signal instead *

D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

wstephenson added a comment. In D27322#612156 , @ivan wrote: > Cool idea, I'll have to think of something similar for the regular activity switcher @ivan it's here: https://phabricator.kde.org/D27353 REVISION DETAIL

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Looks good to me now, maybe try to get more reviewers before pushing though. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27156 To: bport, #plasma, ervin,

D27407: Breeze widgetStyle value is Breeze

ervin added a comment. Shall we expect the migration script in that patch or another one? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27380: [GTK Config] Write Font without style name

ervin added a comment. Can we give a shot to @davidedmundson proposal? Maybe slightly extended to cover some extra enum cases if necessary? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven Cc: davidre,

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 75820. gvgeo added a comment. Style REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75819=75820 BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 AFFECTED FILES

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 75819. gvgeo added a comment. Restore imports. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75818=75819 BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 AFFECTED

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 75818. gvgeo added a comment. Remove PlasmaComponents. So.. why all these different distinctions exist? REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75760=75818 BRANCH kcmports2

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

ervin added inline comments. INLINE COMMENTS > componentchooseremail.cpp:155 > KSharedConfig::Ptr profile = > KSharedConfig::openConfig(QStringLiteral("mimeapps.list"), > KConfig::NoGlobals, QStandardPaths::GenericConfigLocation); > -if (profile->isConfigWritable(true) &&

D27420: [Applet]Improvements for unavailable port.

gvgeo updated this revision to Diff 75817. gvgeo added a comment. avoid i18n puzzles REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27420?vs=75739=75817 BRANCH freeThePort (branched from master) REVISION DETAIL

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

jakobkummerow added a comment. Thanks for landing this! My name is Jakob Kummerow, email: jakob.kumme...@gmail.com I created the diff via Phabricator's web interface (uploading a .diff file), would have expected it to take the author information from my account... REPOSITORY R106

D27453: [Applet]Update toolbar's checkbox spacing

gvgeo added inline comments. INLINE COMMENTS > SwitchButton.qml:54 > left: switchButtonCheckbox.right > -leftMargin: units.gridUnit / 2 > -top: switchButtonCheckbox.top > -bottom: switchButtonCheckbox.bottom > +// Checkbox bug adds

D27453: [Applet]Update toolbar's checkbox spacing

broulik added inline comments. INLINE COMMENTS > SwitchButton.qml:54 > left: switchButtonCheckbox.right > -leftMargin: units.gridUnit / 2 > -top: switchButtonCheckbox.top > -bottom: switchButtonCheckbox.bottom > +// Checkbox bug adds

D27382: KCM: Fix connection list background and padding

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:f8a60c63876f: KCM: Fix connection list background and padding (authored by ahiemstra). REPOSITORY R116 Plasma

  1   2   >