[Powerdevil] [Bug 348529] When screen is locked, turn off screen with a shorter timeout

2023-02-03 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #50 from Chris --- Created attachment 155925 --> https://bugs.kde.org/attachment.cgi?id=155925=edit Shorten screen power off timeout when screen is locked -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 348529] When screen is locked, turn off screen at some point

2022-11-07 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #45 from Chris --- (In reply to Bug Janitor Service from comment #44) > A possibly relevant merge request was started @ > https://invent.kde.org/plasma/powerdevil/-/merge_requests/116 The merge request is about "dimming"

[Powerdevil] [Bug 348529] When screen is locked, turn off screen at some point

2022-11-05 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #43 from Chris --- (In reply to Aleix Pol from comment #42) > I'm sorry, I was just pointed to this MR and am not sure what the problem > exactly is. > > Shouldn't the default mechanisms from PowerDevil kick in here and event

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2022-07-29 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #40 from Chris --- (In reply to Kai Uwe Broulik from comment #4) > That script isn't particularly efficient. > I like the idea of reducing the timeout for turning off the screen when it's > locked (and/or making that a separate opt

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2022-05-29 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #38 from Chris --- (In reply to mágoa mångata from comment #36) > This bug is kind of annoying. Is there any problem about not solving it? > Since this is small bug. It's not resolved for 7 years! > I think the only thing to do

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2022-05-29 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #37 from Chris --- (In reply to Chris from comment #34) > The script above should work nicely, but it doesn't, not consistently at > least. > Related bugs: > https://bugs.kde.org/show_bug.cgi?id=348082 "monitor is random

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2021-08-08 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #34 from Chris --- The script above should work nicely, but it doesn't, not consistently at least. Related bugs: https://bugs.kde.org/show_bug.cgi?id=348082 "monitor is randomly powered back on" https://bugs.kde.org/show_bug.cgi

[Powerdevil] [Bug 348082] monitor is randomly powered back on when using ddcutil support

2021-08-02 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=348082 --- Comment #20 from Chris --- I've been experiencing this bug for a few years. My debian kde version is now sid/experimental/wayland. (Plasma 5.21) Powerdevil is installed, but nothing ddcutil: debian doesn't have the dependency. I think the bug

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2021-05-13 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=348529 Chris changed: What|Removed |Added CC||inkbottle...@gmail.com --- Comment #33 from Chris

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

2020-05-15 Thread Chris Holland
Zren added a comment. > The `plasma-framework` patch is D29463 Ran my KirigamiDevicePixelRatioTest.qml with `QT_QUICK_CONTROLS_STYLE=Plasma`, `/usr/.../styles/org.kde.desktop`, `/usr/.../styles/org.kde.desktop.plasma`, and `/usr/.../Kirigami.2`.

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

2020-05-05 Thread Chris Holland
Zren created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY I recently noticed that `Kirigami.Units.devicePixelRatio` was `1.3` even though I was at the default 96dpi when writing a widget's

D27346: emojier: Improve resizing performance

2020-02-15 Thread Chris Holland
Zren added a comment. As in `clip: true`? delegate: MouseArea { width: emojiView.cellWidth height: emojiView.cellHeight clip: true Rectangle { border.color: "#ff0"; anchors.fill: parent; border.width: 1; color: "transparent" }

D27346: emojier: Improve resizing performance

2020-02-12 Thread Chris Holland
Zren added a comment. Not sure. Backwards compatibility? Firefox renders a couple of them fine, while the TaskManager widget doesn't. Could it be the "Noto" font? The facepalm ones not working are 3 glyphs merged together (facepalm+skincolor+sex). It's rendering (facepalm+skincolor)

D27346: emojier: Improve resizing performance

2020-02-12 Thread Chris Holland
Zren added a comment. FixedSize 25pt does help, but "2 glyph emojis" will overlap each other. F8099880: 2020-02-12___11-38-36.png F8099891: screen-2020-02-12_11.34.09.mp4 Rectangle { width:

D27337: [Emojier] Optimize performance

2020-02-12 Thread Chris Holland
Zren added a comment. I used `Loader` as I didn't want loading glyphs to block scrollbar responsiveness. `GridView` reuses delegates, but I don't think it's the `MouseArea` + `Label` constructor that's slow. I think it's the "rendering the emoji glyph" in the GUI draw that is the root

D27337: [Emojier] Optimize performance

2020-02-11 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY BUG: 417454 The emojier fairly slow. Launching is slow. Resizing the window is slow. Changing pages is slow. Scrolling is also

D26773: Added option to blur background on active window

2020-01-19 Thread Chris Holland
Zren added a comment. I don't care if Inactive Blur is upstreamed or not as all my code is GPL. I didn't upstream it since I thought the feature was niche enough I shouldn't burden others with it's maintenance. This doesn't blur the desktop widgets,

D26681: [TabBox] Thumbnail Grid window switcher

2020-01-15 Thread Chris Holland
This revision was automatically updated to reflect the committed changes. Closed by commit R114:59cd237a7146: [TabBox] Add Thumbnail Grid window switcher (authored by Zren). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26681?vs=73648=73675 REVISION

D26681: [TabBox] Thumbnail Grid window switcher

2020-01-15 Thread Chris Holland
Zren updated this revision to Diff 73648. Zren edited the summary of this revision. Zren added a comment. Fix implicitWidth error by using Layout.min/maxWidth. Scale captionRow.spacing by dpi. Take into account the close button is 30x30. Use a ColumnLayout for thumbnailGridItems instead

D26681: [TabBox] Thumbnail Grid window switcher

2020-01-15 Thread Chris Holland
Zren added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:183 > you can use Layout.preferredWidth > > One shouldn't specifiy a width/height from an item inside a layout Uhg, I was using `width: parent.height` and `height: parent.height` but changed it when cleaning it up.

D26681: [TabBox] Thumbnail Grid window switcher

2020-01-14 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Cleaned up my code from https://github.com/Zren/kwin-tabbox-thumbnail_grid The column is calculated recursively, but survived a

D12827: Added process details in the process list context menu

2019-09-10 Thread Chris Xiong
chrisx updated this revision to Diff 65769. chrisx set the repository for this revision to R111 KSysguard Library. chrisx added a comment. @meven Sorry I've totally forgotten about your suggestions when I was updating the patch... I have renamed `DetailsDlg` to `ProcessDetailsDialog`. But

D12827: Added process details in the process list context menu

2019-09-07 Thread Chris Xiong
chrisx added a comment. Patch updated. Any suggestions? REVISION DETAIL https://phabricator.kde.org/D12827 To: chrisx, broulik, davidedmundson, mart Cc: meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D12827: Added process details in the process list context menu

2019-09-07 Thread Chris Xiong
chrisx updated this revision to Diff 65628. chrisx added a reviewer: mart. chrisx added a comment. Rebased to master. Removed uses of deprecated class (QRegExp). Tidied the code up a bit. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12827?vs=35891=65628 REVISION DETAIL

D12827: Added process details in the process list context menu

2019-08-16 Thread Chris Xiong
chrisx added a comment. In D12827#513118 , @meven wrote: > I quite like this feature @chrisx > I hope you can still push it forward after all this time. I'll definitely update the patch if the maintainers show more interest in

D19821: Fix breeze dialog background with Qt 5.12.2

2019-03-17 Thread Chris Holland
Zren added a comment. Another option I believe is to keep the

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

2019-03-05 Thread Chris Holland
Zren added a comment. Was skimming the Plasma Scripting API today for something else and found where I saw the "update scripts" before: - https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Update_scripts -

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

2019-02-28 Thread Chris Holland
Zren added inline comments. INLINE COMMENTS > configAppearance.qml:137 > +icon.name: "preferences-desktop-locale" > +onClicked: KCMShell.open("formats.desktop") > +} Was afk today sorry. Do we need `visible:

D19176: [weather] envcan: Fix typo in lowercase icon lookup string

2019-02-24 Thread Chris Holland
This revision was automatically updated to reflect the committed changes. Closed by commit R120:58e6cc6e119f: [weather] envcan: Fix typo in lowercase icon lookup string (authored by Zren). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19233: [plasmoidviewer] Add --nobuttons flag to hide button bar

2019-02-22 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY This also fixes the `Background { id: backgroundButtons }` not hiding by binding it's visibility to `buttons.visible`. Is the

D19194: Adjust date string height to match time string with vertical panel

2019-02-22 Thread Chris Holland
Zren added inline comments. INLINE COMMENTS > anthonyfieroni wrote in DigitalClock.qml:305 > You should check if panel orientation, now it's broken horizontal view? This is inside a `State { when: plasmoid.formFactor == PlasmaCore.Types.Vertical }` REPOSITORY R120 Plasma Workspace REVISION

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

2019-02-22 Thread Chris Holland
Zren added a comment. https://doc.qt.io/qt-5/qt.html#CheckState-enum `i18n("Use locale default")` should be in the middle (`currentIndex=1`). 12h should be `currentIndex=0`, and 24h should be `currentIndex=2`

D19176: [weather] envcan: Fix typo in lowercase icon lookup string

2019-02-19 Thread Chris Holland
Zren created this revision. Zren added reviewers: Plasma, kossebau. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY The capital `S` breaks the icon match. It was broken in Plasma 5.6

D19174: [weather] envcan: Document urls for example data + list all warnings

2019-02-19 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY I can place this in the `ion_envcan.h` or the `ion_envcan.cpp`. It's not worth backporting so it'll get merged to master. REPOSITORY

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

2019-02-15 Thread Chris Holland
Zren closed this revision. Zren added a comment. Shoot, I accidentally forgot the Phab Rev link in the commit message (though I remembered the bugzilla tags). I've setup a `.git/hook/prepare-commit-msg` -like thing for Sublime Text to

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

2019-02-14 Thread Chris Holland
Zren created this revision. Zren added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY In 12h system locales (eg: en_US), checked=1 is cast as Qt::PartiallyChecked=1 which defaults to the

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

2019-02-12 Thread Chris Holland
Zren added a comment. In D18961#410792 , @kossebau wrote: > > we no longer have to install the widget to .../share/plasma/plasmoids/ > > No experience here, but do we not still need to install the QML extension plugins to have the applet

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

2019-02-12 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY If `plasmoid.nativeInterface.source != ""`, we copy it to `plasmoid.configuration.source` + same with all other properties besides

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Chris Holland
This revision was automatically updated to reflect the committed changes. Closed by commit R114:46204a5e2a84: [weather] Fix weather Notices tab not showing (authored by Zren). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18936?vs=51449=51455#toc REPOSITORY R114 Plasma Addons

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Chris Holland
Zren added a comment. Ah, `NoticesView.qml` in Plasma 5.12 was slightly different. - https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/NoticesView.qml -

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Chris Holland
Zren added a comment. Note: Env Canada lists all their Warnings + Watches for all of Canada at https://weather.gc.ca/warnings/index_e.html should anyone need to test in the future. Is there any other Ion besides EnvCanada that currently displays "Warnings"? I can definitely push to

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Chris Holland
Zren updated this revision to Diff 51449. Zren edited the summary of this revision. Zren added a comment. Add `Layout.alignment: Qt.AlignHCenter` to the `PlasmaExtras.Heading` F6608836: 2019-02-11___17-47-22.png REPOSITORY R114 Plasma Addons

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Chris Holland
Zren added a comment. I just noticed that the "Warnings Issued" text is left aligned. Might as well center align it while we're at it. Add this as a child of `PlasmaExtras.Heading` to debug: Rectangle { anchors.fill: parent; border.color: "#f00"; border.width: 1; color:

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY `Toronto, ON` in the `Env Canada` ion currently has a weather warning. The weather widget's code currently has a bug that will only show

D18696: Update `libdbusmenuqt` and the AppMenu plugin

2019-02-04 Thread Chris Holland
Zren added inline comments. INLINE COMMENTS > CMakeLists.txt:27 > > -# add_subdirectory(test) > +add_subdirectory(test) We do not bundle the libdbusmenuqt test directory in this repo. So you need to comment this line out otherwise it will not build with the test directory missing.

D18580: Accept commas to separate processes on the Search Edit

2019-01-28 Thread Chris Rizzitello
rizzitello added a comment. +1 REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D18580 To: tcanabrava Cc: rizzitello, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

2019-01-18 Thread Chris Holland
This revision was automatically updated to reflect the committed changes. Closed by commit R114:80bd32b12a01: Consistent arrow key handling in the Informative Alt+Tab skin (authored by Zren). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

2019-01-18 Thread Chris Holland
Zren added a comment. I forgot to merge this after david's patch was merged. I just tested this in the Neon Beta ISO to confirm the fix still works. In D16093#359639 , @ngraham wrote: > Hmm, this does not actually work for me. Seems like it

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-14 Thread Chris Holland
Zren added a comment. There was a few +1s, but I wasn't exactly sure who specifically "approves" this for a merge to `plasma-workspace` or `digital-clock` specifically. My bad, I shouldn't of left this feature to the last minute and felt rushed to get it in. I'll try to avoid the time

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-13 Thread Chris Holland
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:235fa8107dab: [Digital Clock] Add ability to set a custom date format string (authored by Zren). REPOSITORY R120

D18206: Improve the Look and Feel KCM

2019-01-12 Thread Chris Rizzitello
rizzitello added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18206 To: GB_2, #plasma, #vdg Cc: rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-12 Thread Chris Holland
Zren added a comment. > D18155 Looking at the alternative patch, I've renamed the config key variable to `customDateFormat`. Most of the differences stem from not using a "variant" data type for `DigitalClock.qml`'s `dateFormat` variable. The `string

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-12 Thread Chris Holland
Zren updated this revision to Diff 49332. Zren edited the summary of this revision. Zren edited the test plan for this revision. Zren added a comment. - Rename config key from `dateFormatStr` and config TextField `dateFormatTextField` to `customDateFormat`. - Remove the "Color Format

D18168: [WIP] [Digital Clock] Embed date formatting variable documentation

2019-01-10 Thread Chris Holland
Zren created this revision. Zren added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Assuming D18019 is merged, this would: - Provides

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-10 Thread Chris Holland
Zren updated this revision to Diff 49137. Zren edited the summary of this revision. Zren added a comment. Translate the "Time Format Documentation" link. Add a link to QML's Text RichText docs under the "Color Format Documentation" label (translated). Place the 2 links below the text

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-10 Thread Chris Holland
Zren added a comment. The "show date" / "show seconds" toggles only affect the current widget instance as well. It would be nice if plasma had a `plasmoid.globalConfiguration.dateFormatStr` API which all widget instances (on all panels/screens) were bound to, so the user only had to

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-08 Thread Chris Holland
Zren added a comment. In D18019#388829 , @ndavis wrote: > Shouldn't the documentation explain that apostrophes need to be used or is the fact that they need to be used unusual and specific to this clock widget? The time format docs

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-07 Thread Chris Holland
Zren added a comment. In D18019#388811 , @ndavis wrote: > I'm leaning towards no, but a second link to text formatting documentation might be a good idea. Adding a second link is pretty easy, though I wrote this before I noticed your

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-07 Thread Chris Holland
Zren added inline comments. INLINE COMMENTS > configAppearance.qml:145 > +'name': "custom" > } > ] Does this also need a `i18nc("custom date format", "Custom")` translation context? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D18018: [Digital Clock] Add ability to change first day of week

2019-01-07 Thread Chris Holland
Zren added a comment. In D18018#387920 , @davidedmundson wrote: > Is there a use case for having it configurable inside the plasmoid separately from configuring it system wide? https://bugs.kde.org/show_bug.cgi?id=390330#c5 > Just

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-06 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Adds a new `dateFormatStr` config key which is used when the `dateFormat` "StringEnum" is set to `custom`. Shows a link to the Qt time

D18018: [Digital Clock] Add ability to change first day of week

2019-01-06 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY CCBUG: 390330 The Qt enum can have Sunday value of 0 or 7, so we start the enum at -1 to represent the locale's default value.

D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config

2019-01-02 Thread Chris Holland
Zren added a comment. That still requires the user to drag a button, which isn't exactly obvious or a normal behaviour, just to discover what it is. It doesn't look like a desktop widget, not that the user would recognize it as one, as KDE by default does not display any desktop widgets the

D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config

2019-01-02 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Even when a user scours the system settings + desktop config looking how to disable this button, the user will have no indication this

D15888: new icons (Breeze style)

2018-11-04 Thread Chris Holland
Zren added a comment. We're currently trying to draw the C++ Breeze/forks window decorations in T9899 (and https://bugs.kde.org/show_bug.cgi?id=399757), which would make these SVGs obsolete. However we can merge these in the short term until that code is

D16521: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app

2018-10-30 Thread Chris Holland
This revision was automatically updated to reflect the committed changes. Closed by commit R118:47e4fa8e5366: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app (authored by Zren). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE

D16521: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app

2018-10-29 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY QML `Shortcut` requires Qt 5.5, so we bumped QtQuick to 2.5. https://doc.qt.io/qt-5.11/qml-qtquick-shortcut.html As discussed

D16516: [cuttlefish] Auto-focus on search textfield when app opens

2018-10-29 Thread Chris Holland
Zren added a comment. - https://doc.qt.io/qt-5.11/qml-qtquick-shortcut.html - http://doc.qt.io/qt-5/qkeysequence.html#StandardKey-enum - http://doc.qt.io/archives/qt-4.8/qkeysequence.html#standard-shortcuts - `QKeySequence::Quit` - http://doc.qt.io/qt-5/qml-qtqml-qt.html#quit-method

D16516: [cuttlefish] Auto-focus on search textfield when app opens

2018-10-29 Thread Chris Holland
Zren added a comment. In D16516#350641 , @ngraham wrote: > YES lol, that annoyed you too eh? It's been bugging me for ages. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D16516 To: Zren, ngraham Cc:

D16516: [cuttlefish] Auto-focus on search textfield when app opens

2018-10-29 Thread Chris Holland
This revision was automatically updated to reflect the committed changes. Closed by commit R118:542388f984cf: [cuttlefish] Auto-focus on search textfield when app opens (authored by Zren). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16516?vs=7=8

D16516: [cuttlefish] Auto-focus on search textfield when app opens

2018-10-29 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. TEST PLAN Manually edited `/usr/share/plasma/packages/org.kde.plasma.cuttlefish/contents/ui/Tools.qml`, then launched cuttlefish. REPOSITORY R118

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

2018-10-24 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=304696 Chris Holland changed: What|Removed |Added CC||zrenf...@gmail.com --- Comment #14 from Chris

D16327: Update libdbusmenuqt folder

2018-10-24 Thread Chris Holland
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R884:bb680e8dbfc2: Update libdbusmenuqt folder (authored by Zren). REPOSITORY R884 Active Window Control Applet for

D16394: Hide Buttons With Empty Text (Gtk Separators)

2018-10-24 Thread Chris Holland
This revision was automatically updated to reflect the committed changes. Closed by commit R884:942169541d33: Hide Buttons With Empty Text (Gtk Separators) (authored by Zren). REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE

D16327: Update libdbusmenuqt folder

2018-10-24 Thread Chris Holland
Zren added a comment. For now, I'm going to merge this so I can keep the widget in sync with the global menu widget. We can revisit linking to a shared library later on. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D16327 To: Zren

D16394: Hide Buttons With Empty Text (Gtk Separators)

2018-10-23 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Fixes issue #146 on GitHub: https://github.com/kotelnik/plasma-applet-active-window-control/issues/146 This is the same method the

D16327: Update libdbusmenuqt folder

2018-10-20 Thread Chris Holland
Zren added a comment. KNotifications provides an example of linking to `dbusmenu-qt5`: https://github.com/KDE/knotifications/blob/master/src/CMakeLists.txt#L46-L49 However REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D16327

D16327: Update libdbusmenuqt folder

2018-10-20 Thread Chris Holland
Zren added a comment. Yeah, I'm not 100% sure why the Active Window Control widget needs it. I assume it should be dynamically linking to the `/usr/lib/x86_64-linux-gnu/libdbusmenu-qt.so.2`, but I wanted to update all the common code first before making major refactoring. REPOSITORY R884

D16329: Add a ReadMe with install from Git instructions and bugzilla links

2018-10-19 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY TODO: Figure out all the build dependencies. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL

D16328: Saner config defaults

2018-10-19 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Make sure the buttons have a dedicated place, filling the entire height of the panel rather than only 50%. We could probably limit the

D16327: Update libdbusmenuqt folder

2018-10-19 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY I needed to add `include(ECMQtDeclareLoggingCategory)` to the root `CMakeLists.txt` to get it to compile.

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-11 Thread Chris Rizzitello
rizzitello added a comment. In D16031#341646 , @davidedmundson wrote: > Why should the login screen look different to the lock screen? This is a response to user complaints about the login screen receiving the same blur used on the lock

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-10 Thread Chris Rizzitello
rizzitello accepted this revision as: rizzitello. rizzitello added a comment. This revision is now accepted and ready to land. This Looks Great! REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D16031 REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma,

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-10-09 Thread Chris Holland
Zren added a comment. Sorry, just merged both to master. Thanks davidedmundson for the patches that updated the ComboBox. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12040 To: Zren, #plasma, davidedmundson Cc: ngraham, cfeck, mart, davidedmundson,

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-10-09 Thread Chris Holland
This revision was automatically updated to reflect the committed changes. Closed by commit R119:347f43c42b70: Add Get Wallpaper Plugins... button to Config Desktop dialog (authored by Zren). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-10-09 Thread Chris Holland
This revision was automatically updated to reflect the committed changes. Closed by commit R120:5e1b650859fe: Add wallpaperplugin.knsrc + QML function to open GHNS dialog (authored by Zren). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-10-05 Thread Chris Holland
Zren updated this revision to Diff 42950. Zren added a comment. - Got rid of the signal+slot that emits KNewStuff changes since wallpaperComboBox is automagically updated. - Reordered the command arguments so the variable is last in `wallpaperplugin.knsrc`. - Put the `plasmoids.knsrc`

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-10-05 Thread Chris Holland
Zren added a comment. Finally got around to updating this patch and formally testing with `kdesrc-build` (sort of) in Neon Unstable which has Frameworks 5.51. F6306500: screen-2018-10-05_16.35.50.mp4 Updated diff incoming as soon as I figure

D15862: option to specify icons spacing for systray

2018-09-30 Thread Chris Holland
Zren added inline comments. INLINE COMMENTS > Zren wrote in main.qml:310 > Hmm. We might want to scale by DPI. While the default 0px will not be > affected by DPI, if a Look And Feel sets it to 10px, it would look different > for users with 1x DPI and 2x DPI. > > Eg: > > spacing:

D15862: option to specify icons spacing for systray

2018-09-30 Thread Chris Holland
Zren added inline comments. INLINE COMMENTS > main.qml:310 > id: tasksRow > -spacing: 0 > +spacing: plasmoid.configuration.iconsSpacing > height: parent.height - (vertical && expander.visible ? > expander.height : 0) Hmm. We might want to scale by DPI. While

D12827: Added process details in the process list context menu

2018-09-14 Thread Chris Xiong
chrisx added a comment. Any updates on whether this patch could be merged? It has been a long wait. If there are any improvements I can make to the patch I will be more than happy to put more work into it. REPOSITORY R111 KSysguard Library REVISION DETAIL

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-08-30 Thread Chris Holland
Zren added a comment. Awesome! The KPackage patch will end up in... Frameworks 5.51? And the Plasma 5.14.0 release is set to depend on Frameworks... 5.45 (according to `plasma-workspace`'s `CMakeList.txt`). So we'll need to wait for the 5.14 tag to appear (Oct 4th), but to be safe,

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-20 Thread Chris Rizzitello
rizzitello added a comment. > ... do people change their screen resolutions very often anymore? Yes I have to change my resolution quite often and its almost always because of one of two things. 1. Some application that was in fullscreen at a specific resolution has crashed

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-20 Thread Chris Rizzitello
rizzitello added a comment. In D14869#312041 , @filipf wrote: > > ! In D14869#311980 , @rooty wrote: > > you can always put in a wizard that runs on booting for the first time and asks people for

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Chris Rizzitello
rizzitello added a comment. > How does your suggestion relate to both the DPI value of your hardware and what Xorg uses? Do we actually set a higher DPI value for Hi(gher)DPI hardware automatically, so the actual size to the eye is independent of the display in use? If not, why not? I

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread Chris Rizzitello
rizzitello added a comment. The title bar with the bold font looks nice at both sizes. > Reduced text density (obviously) Our defaults are not very dense so the loss of density is only going to be bad, except for the case of small screens. On those its more then reasonable to

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread Chris Rizzitello
rizzitello added a comment. Honestly if you look at the last before and after shot the text now looks worse then when it was 10 pt. I think the issue is more your hinting then the font size. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14869 To: ngraham,

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

2018-08-03 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=375840 Chris changed: What|Removed |Added CC||scrutini...@pm.me --- Comment #8 from Chris --- Same

D10362: Swap reveal password button logic

2018-08-01 Thread Chris Rizzitello
rizzitello added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. In D10362#202592 , @elvisangelaccio wrote: > Would it be possible to implement this feature like in the Windows 10 lock

D14234: [Folder View] Improve file name text rendering

2018-07-19 Thread Chris Holland
Zren added a comment. I tested the `x: -main.x % 1` code. Before: F6120560: 2018-07-19___13-46-20.png After: F6120562: 2018-07-19___13-47-29.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

  1   2   3   >