D29393: Use player "poster" as album cover if available

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Media Sessions artwork takes precedence, if set. TEST PLAN Not sure how useful th

D29234: Fix various bugs introduced with heading

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > NotificationItem.qml:118 > +Layout.preferredWidth: notificationHeading.implicitWidth > +id: headingElement > + Put `id` at the top > NotificationItem

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

broulik added a comment. Very lovely idea! INLINE COMMENTS > main.qml:36 > > +property var kscreenAction: Kirigami.Action { > +visible: KCMShell.authorize("kcm_kscreen.desktop").length > 0 Why this as a `property`, not just an `Action` with an `id`? > main.qml:70 > +

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

broulik added a comment. Technically we don't have a "until turned off" state, just a date. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28740 To: broulik, #plasma Cc: ngraham, bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jralei

D29234: Fix various bugs introduced with heading

broulik added inline comments. INLINE COMMENTS > NotificationItem.qml:116 > +Layout.fillWidth: true > +implicitHeight: !notificationItem.inGroup ? > notificationHeading.implicitHeight : 0 > + When `inGroup` the height will be zero so you effectively leak the item contents outsi

D29111: [applet] Port to Kirigami.PlaceholderMessage

broulik added a comment. This now gives me a tiny icon on the button because this is a //Kirigami// component using desktop style: F8276714: Screenshot_20200501_221556.png REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D2911

D29297: [Notifications] Have checkIndex check if the index is valid

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f2e34dbbd3b9: [Notifications] Have checkIndex check if the index is valid (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29297?vs=81

D29333: Don't show an empty error dialog when canceling the sync password prompt

broulik added a comment. I would like KAuth or Polkit to be fixed to properly report user canceling REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D29333 To: ngraham, filipf, davidedmundson, #plasma Cc: broulik, mthw, plasma-devel, Orage, LeGas

D29311: Emit low battery notification immediately when plugging out AC

broulik planned changes to this revision. broulik added a comment. Hmm, odd, will have to do further testing then REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D29311 To: broulik, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jra

D29311: Emit low battery notification immediately when plugging out AC

broulik added a comment. Do you get the sound that you unplugged? For me it sometimes took quite a while for it to actually recognize I unplugged REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D29311 To: broulik, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00

D29309: Make low battery notification critical

This revision was automatically updated to reflect the committed changes. Closed by commit R122:45dd7bbfe18b: Make low battery notification critical (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29309?vs=81615&id=81618#toc REPOSITORY R122 Powerdevil CHANGES SIN

D29311: Emit low battery notification immediately when plugging out AC

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When plugging out AC, emit a low battery notification immediately, so one is notified of the fact

D29309: Make low battery notification critical

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This ensures you have to acknowledge it and be aware that the battery is running low. Other

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

broulik added a subscriber: dfaure. broulik added inline comments. INLINE COMMENTS > DeviceItem.qml:32 > > -MouseArea { > +// TODO: fix expanding when a new device is connected; done in > devicenotifier.qml > +// TODO: clean up list item expanding code in devicenotifier.qml There's an `expand

D29297: [Notifications] Have checkIndex check if the index is valid

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Apparently by default it only considers "out of range" indices invalid but an invalid one as vali

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

broulik added a comment. shipit REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29285 To: crossi, #plasma, bport, broulik Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesj

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks Can this go into 5.18? INLINE COMMENTS > main.cpp:147 > +const QModelIndex index = m_iconSizeCategoryModel->index(i, 0); > +if (!index.isValid()) { > +

D29279: Don't play volume feedback if max volume is reached

broulik added a comment. I'm with @cblack here. When I press the button i expect a feedback. If any, we should block repeated feedback sounds when pressing and holding the key without the volume changing but pressing the key once should always play the respective sound. REPOSITORY R115 Pl

D29226: [ksmserver] Use CommandLauncherJob for restoring applications

broulik added a comment. I did, oops, thanks :) https://cgit.kde.org/plasma-workspace.git/commit/?id=eebbf6d47a3e4e31697162eb082c3489aa1f506e REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29226 To: broulik, #plasma, dfaure Cc: jbbgameich, dfaure, plasma

D28926: Signal player gone in "pagehide" not "beforeunload"

This revision was automatically updated to reflect the committed changes. Closed by commit R856:229a5e2c9565: Signal player gone in "pagehide" not "beforeunload" (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28926?vs=

D29226: [ksmserver] Use CommandLauncherJob for restoring applications

This revision was automatically updated to reflect the committed changes. Closed by commit R120:963f41e5593c: [ksmserver] Use CommandLauncherJob for restoring applications (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29226?vs=

D29268: [WIP] Add Date/Time dialog

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:69 > +if(ANDROID) > +install(FILES > +"${CMAKE_CURRENT_BINARY_DIR}/KF5KirigamiAddonsConfig.cmake" Why this only on Android? or is that used for that dummy library? > FindGradle.cmake:2 > +#.rst: > +# FindGradle > +# --

D26111: Runner: make recentdocument use KActivityStats data

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:13 > KF5::I18n > +KF5::Activities > +KF5::ActivitiesStats Where's this being used? I only see stats > recentdocuments.cpp:78 > > -

D29234: Fix various bugs introduced with heading

broulik added inline comments. INLINE COMMENTS > niccolove wrote in NotificationItem.qml:125 > I originally did this but I had a problem. It displays and works just as > good, but it will throw a "you are using anchors in layouts" error in the > console. Even though I disable the anchors in the

D28926: Signal player gone in "pagehide" not "beforeunload"

broulik updated this revision to Diff 81430. broulik retitled this revision from "Signal player gone in "unload" not "beforeunload"" to "Signal player gone in "pagehide" not "beforeunload"". broulik edited the summary of this revision. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE L

D29226: [ksmserver] Use CommandLauncherJob for restoring applications

broulik updated this revision to Diff 81419. broulik added a comment. - Simplify - Remove pointless return REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29226?vs=81336&id=81419 REVISION DETAIL https://phabricator.kde.org/D29226 AFFECTED FILE

D29234: Fix various bugs introduced with heading

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > FullRepresentation.qml:454 > elementId: "vertical-line" > -svg: line

D26111: Runner: make recentdocument use KActivityStats data

broulik added a comment. +1 INLINE COMMENTS > CMakeLists.txt:85 >) > +find_package(KF5ActivitiesStats ${KF5_MIN_VERSION}) > +set_package_properties(KF5ActivitiesStats PROPERTIES DESCRIPTION " querying > of activity history" Do we not have this dep in p-w these days a

D29226: [ksmserver] Use CommandLauncherJob for restoring applications

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Rather than calling into `KLauncher` directly. TEST PLAN Compiles, session restore apps are sti

D29224: [Task Manager] Avoid crash with QStringBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0eba5453b9d4: [Task Manager] Avoid crash with QStringBuilder (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29224?vs=81333&id=81335 R

D29224: [Task Manager] Avoid crash with QStringBuilder

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The lambda returns a `QStringBuilder` which contains dangling references, see also QTBUG-47

D29157: force systemsettings for kcms

broulik added a comment. +1 INLINE COMMENTS > servicerunner.cpp:461 > if (actionName.isEmpty()) { > +if (service->serviceTypes().contains(QLatin1String("KCModule"))) { > +service->setExec(QStringLiteral("systemsettings5 ") + > service->desktopEntryName()); A comment

Re: Type=FSDevice desktop files

Hi, > Would it be OK if we dropped support for desktop files that represent devices? > This was a KDE1/KDE2/KDE3? feature, you'd write/ship a desktop file with Type=FSDevice and Dev=/dev/sdc and this would give you Mount and Unmount in the context menu. I believe macOS to this day automatica

D29214: [Notifications] Fix typo

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ed0a51886150: [Notifications] Fix typo (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29214?vs=81283&id=81301 REVISION DETAIL htt

D29214: [Notifications] Fix typo

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Fixes notifications of different origins being grouped together when they shouldn't. TEST PLAN

D28936: Use a Proxy object to detect changes within the MediaMetadata

broulik added a comment. Maybe if I overwrote `MediaMetadata` with a `Proxy` object already, then the website would never have a separate `Object` to work with.. hmm REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28936 To: broulik, #plasma, fvogt

D29152: Allow PlaceholderMessage to be text-less

broulik added inline comments. INLINE COMMENTS > PlaceholderMessage.qml:220 > > +visible: text && text.length > 0 > + `text` is a string property and as such always present, you can simplify this to visible: text !== "" or visible: text.length > 0 REPOSITORY R169 Kirigami RE

D28936: Use a Proxy object to detect changes within the MediaMetadata

broulik added a comment. > this doesn't catch something like this Yeah it doesn't. I thought I could "monitor" an Object but the caller actually has to //use// the Proxy for it to detect anything :/ Any ideas? :) INLINE COMMENTS > fvogt wrote in content-script.js:716 > That appears

D29133: [Icon Applet] Port jump list actions to KServiceAction

This revision was automatically updated to reflect the committed changes. Closed by commit R120:404b2be2168c: [Icon Applet] Port jump list actions to KServiceAction (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29133?vs=81001&i

D29144: [applets/weather] Improve UX for selecting a weather station

broulik added a comment. > what happens if we have more Weather Providers won't the dialog box be cluttered? I wonder how many we actually offer? Maybe the old way but with a more obvious label could work. Dunno... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.

D29144: [applets/weather] Improve UX for selecting a weather station

broulik added a comment. +1 that hidden flag thing always bugged me INLINE COMMENTS > WeatherStationPicker.qml:66 > +ColumnLayout { > +Kirigami.FormData.label: i18n("Select weather providers:") > +Kirigami.FormData.buddyFor: children[1] // 0 is the Repeater Pe

D29130: [Applet] Show in system tray iff at least one vault is open

broulik added inline comments. INLINE COMMENTS > vaultsmodel.h:36 > Q_PROPERTY(bool hasError READ hasError NOTIFY hasErrorChanged) > +Q_PROPERTY(bool hasOpen READ hasOpen NOTIFY hasOpenChanged) > Q_PROPERTY(int count READ rowCount NOTIFY rowCountChanged) I think this should be `ope

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

broulik accepted this revision. broulik added a comment. Clean up those minor comments and then ship it, thanks! INLINE COMMENTS > kcm.cpp:256 > +} > +return m_behaviorSettingsList[index.row()]; > +} `.value(index.row())` > kcm.cpp:269 > +QString groupName; > +QModel

D29064: Support module commandline paramenter

broulik added a comment. Note you can pass multiple arguments to `kcmshell5` to open a dedicated save window with random KCMs inside, e.g. done by battery monitor: kcmshell5 powerdevilprofilesconfig powerdevilactivitiesconfig powerdevilglobalconfig Not sure how this could be trans

D29132: [applet] Show toolbar unless Bluetooth hardware is absent

broulik added a comment. +1 REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D29132 To: ngraham, #vdg, niccolove, manueljlin Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, l

D29133: [Icon Applet] Port jump list actions to KServiceAction

broulik created this revision. broulik added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - Get browser actions on browser icon still - Launching them works and gives proper startup feed

D29124: Port all KRun::runService/runApplication to KIO/ApplicationLauncherJob

broulik added inline comments. INLINE COMMENTS > dfaure wrote in appentry.cpp:42 > No there's a KRun::run in this file. I only ported runService/runApplication > in this commit. Stupid highlighting, I had Ctrl+F for "KRun" but it didn't highlight int :) REPOSITORY R120 Plasma Workspace REVI

D29124: Port all KRun::runService/runApplication to KIO/ApplicationLauncherJob

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > iconapplet.cpp:354 > connect(action, &QAction::triggered, this, [this, exec] { > KRun::run(exec, {}, nullptr, m_name, m_iconName); >

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. If you want to rework it that'll be appreciated but I can look into it since I did the pioneer porting of Task manager REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

broulik added inline comments. INLINE COMMENTS > kcm.cpp:270 > +m_sourcesModel->load(); > +for (auto &settings : m_sourcesModel->settingsList()) { > +auto toAdd = new > NotificationManager::BehaviorSettings(settings.type, settings.groupName, > this); This method is

D29081: [QStyle] Make menu titles look less like menu items

broulik added a comment. Not a fan of making it hard to read. I agree that it makes it more obvious it's not clickable but we deliberately changed many places that used disabled menu items as sections to use proper sections for readability. REPOSITORY R31 Breeze REVISION DETAIL https://

D29071: FileChooser portal: add support for opening directories

broulik added inline comments. INLINE COMMENTS > filechooser.cpp:167 > > +if (options.contains(QStringLiteral("directory"))) { > +directory = options.value(QStringLiteral("directory")).toBool(); This check isn't needed, but is probably consistent with the rest and should be cleane

D29057: Introduce PlaceholderMessage component

broulik added inline comments. INLINE COMMENTS > PlaceholderMessage.qml:118 > + */ > +property QQC2.Action helperAction > + You can probably just make an `alias` to the button's `action` property. It got added in Qt 5.10, then it should take on the icon, text, visibility, trigger, etc

D28509: RFC: [libnotificationmanager] introduce the notification watcher

gt; +QVariantMap& hints() const; > +void setHints(const QVariantMap &hints); Maybe add a new `rawHints() const`? Not a fan of ref return > notification_p.h:100 > QList urls; > +QVariantMap hints = QVariantMap(); > No need to explicitly initialize > notific

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

broulik added a comment. > Why not change what the option do ? so how would you reflect a "forever" as a date? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28740 To: broulik, #plasma Cc: bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

broulik added a comment. This is for displaying whether do not disturb is on. The "until disabled" option just sets it to one year in the future. But it's odd to show "until 2021", so we don't show the date when it's too far in the future. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

broulik added a comment. > Does this really use KServiceAction anywhere? It doesn't but it should since it also supports jump list ations. Probably needs similar treatment like I did with task manager in D28286 REPOSITORY R114 Plasma Addons REVISI

D28939: Don't offer sending non-http(s) links and sources via KDE Connect

This revision was automatically updated to reflect the committed changes. Closed by commit R856:ec8da2dd5db3: Don't offer sending non-http(s)/ftp links and sources via KDE Connect (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.

D28965: Support Brave browser

This revision was automatically updated to reflect the committed changes. Closed by commit R856:257e4dd81f87: Support Brave browser (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28965?vs=80504&id=80613 REVISION DETAIL

D28988: Port hotplug from KRun::runCommand to CommandLauncherJob.

broulik added a comment. In principle dataengine actions are jobs, so they could communicate a result back REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28988 To: dfaure, davidedmundson, sitter Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

broulik added a comment. Also actually this should probably be refactored completely to use `KServiceAction` rather passing the exec to QML and then back here :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28990 To: dfaure, drosca, davidedmundson, broulik

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

broulik added a comment. Since it's an applet and thus run inside Plasma, do we not rather want the `KNotificationJobUiDelegate`? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28990 To: dfaure, drosca, davidedmundson, broulik Cc: plasma-devel, Orage, LeGast0

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

broulik accepted this revision. broulik added a comment. The lack of spacing looks bad but whatever REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from master) REVISION DETAIL https://phabricator.kde.org/D28989 To: ngraham, #vdg, #plasm

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

broulik added a comment. It's just a `QAbstractListModel`, if any, it does some `columnCount` behavior. I emit `dataChanged`, yes. Will check the actual column count later. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28649 To: broulik, #plasma Cc: david

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

broulik added a comment. :( I see. Thanks! At least by then I'll be able to use `sourceModels()` so I could make the mapping up the chain generic REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28649 To: broulik, #plasma Cc: davidre, dfaure, plasma-devel

D28965: Support Brave browser

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN With the deb package from their website - Media controls for video in Brave now show Brave log

D28939: Don't offer sending non-http(s) links and sources via KDE Connect

broulik added a comment. > How did that happen? lol I have no idea > I'd say yes, together with `ftps` it doesn't recognize/allow `ftps`, only `http`, `https`, `file`, and `ftp`, see https://developer.chrome.com/extensions/match_patterns > That sounds weird, none of the tar

D28939: Don't offer sending non-http(s) links and sources via KDE Connect

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `chrome://` and `about:` pages are typically local and browser-specific, and `blob:` pages

D28936: Use a Proxy object to detect changes within the MediaMetadata

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY According to spec [1] it is allowed to change properties within the `MediaMetadata` rather

D28926: Signal player gone in "unload" not "beforeunload"

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I don't recall if there was a particular reason for using *before* unload but this event is

D28917: [Media Controller] Don't set album art on tooltip anymore

This revision was automatically updated to reflect the committed changes. Closed by commit R120:38c269dc486d: [Media Controller] Don't set album art on tooltip anymore (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28917?vs=8037

D28917: [Media Controller] Don't set album art on tooltip anymore

broulik updated this revision to Diff 80378. broulik added a comment. - Set default state (It's overridden by the `State` below for stopped, playing, paused, but doesn't hurt to have it as fallback with the other props I guess) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDAT

D28917: [Media Controller] Don't set album art on tooltip anymore

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We don't show icons on tooltips anymore. And the System Tray config doesn't show images. BU

D28907: [Services Runner] Fix mimeDataForMatch

This revision was automatically updated to reflect the committed changes. Closed by commit R120:08bafc3b44ab: [Services Runner] Fix mimeDataForMatch (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28907?vs=80358&id=80373 REVISIO

D28906: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6d25115e4627: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28906?vs=80357&id=80372#toc REPOSI

D28905: Fix variable assignment

This revision was automatically updated to reflect the committed changes. Closed by commit R120:70fa173d466a: Fix variable assignment (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28905?vs=80354&id=80370 REVISION DETAIL http

D28908: Use the same icon mode calculation for comboboxes as for buttons

broulik added a comment. Now that we can properly recolorize all the icons, maybe we should drop the `State_Selected` handling altogether? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28908 To: davidre, broulik, #breeze Cc: plasma-devel, Orage, LeGast00n, The-Feren

D28907: [Services Runner] Fix mimeDataForMatch

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Regression introduced in 6e660cf92d7c3fb0e20527866691eaff9f8bc207

D28906: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - Launching pinned apps still works - Failure to launch results in a nice plasma notification now

D28905: Fix variable assignment

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Noticed this while refactoring something in the area. TEST PLAN 5.18, Not sure what the

D28904: Cleanup dependencies

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY That unused `EditPage::openUrl` pulled in `KIOWidgets` with all its dependencies. This includes

D28904: Cleanup dependencies

broulik updated this revision to Diff 80351. broulik edited the test plan for this revision. broulik added a comment. - Drop all `KComboBox` uses REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28904?vs=80350&id=80351 REVISION DETAIL https://phabricato

D28830: Don't set a custom palette if we have the same palette as the currently active one

broulik accepted this revision. broulik added a comment. Fixes the Dolphin toolbar icon color and KWrite save dialog button icon color. INLINE COMMENTS > breezehelper.cpp:1608 > +if (changePalette) { > +if(activePalette == QPalette()) { > +KIconLoader::glob

D28893: Detect Vivaldi based on binary name

This revision was automatically updated to reflect the committed changes. Closed by commit R856:97981b214ab6: Detect Vivaldi based on binary name (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28893?vs=80316&id=80347

D28893: Detect Vivaldi based on binary name

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Vivaldi no longer includes its name in the User Agent, see [1]. Try detecting it based on

D28837: Add device icons to KDE Connect context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R856:60d074467453: Add device icons to KDE Connect context menu (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28837?vs=80151&i

D28849: [KSysGuardProcessList] Port away from KRun

This revision was automatically updated to reflect the committed changes. Closed by commit R111:d8e46779566f: [KSysGuardProcessList] Port away from KRun (authored by broulik). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28849?vs=80175&id=80181 RE

D28707: Show purpose context menu only when enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R856:7f3bc46f9044: Show purpose context menu only when enabled (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28707?vs=80177&id

D28707: Show purpose context menu only when enabled

broulik updated this revision to Diff 80177. broulik added a comment. - Call `updatePurposeMenu()` on connect REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28707?vs=80149&id=80177 REVISION DETAIL https://phabricator.kde.org/D28707 AF

D28849: [KSysGuardProcessList] Port away from KRun

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead use `ApplicationLauncherJob` with `KDialogJobUiDelegate` TEST PLAN - Clicking "Run comm

D28837: Add device icons to KDE Connect context menu

broulik created this revision. broulik added reviewers: Plasma, KDE Connect, fvogt, ndavis. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Firefox supports setting icons on menus [1]. Chrome refuses to create a

D28707: Show purpose context menu only when enabled

broulik updated this revision to Diff 80149. broulik added a comment. - Remove caching We update the menu on startup and when settings change, no need to cache it. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28707?vs=79721&id=8014

D28792: [Purpose Plugin] Open shared URL when clicking notification

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:ae4890cf6f1a: [Purpose Plugin] Open shared URL when clicking notification (authored by broulik). REPOSITORY R856 Pla

D28821: [Notifier] Port from KRun::runCommand

This revision was automatically updated to reflect the committed changes. Closed by commit R134:53375168eb03: [Notifier] Port from KRun::runCommand (authored by broulik). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28821?vs=80097&id=80101 R

D28821: [Notifier] Port from KRun::runCommand

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Use `ApplicationLauncherJob` for launching the main application and `CommandLauncherJob` for laun

D28703: Make KAccess a regular startup application

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6df845ee5373: Make KAccess a regular startup application (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28703?vs=79713&id=80094 REVIS

D28703: Make KAccess a regular startup application

broulik added a comment. Autostart doesn't appear to respect that property and I don't think we just want to check `KService::noDisplay()` *but* kaccess appears to launch and even screen reader works. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28703 To:

D28657: [Notifications] Report roleNames in the relevant places

This revision was automatically updated to reflect the committed changes. Closed by commit R120:07dc5c49876c: [Notifications] Report roleNames in the relevant places (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28657?vs=79575&

D28650: [Notifications] Don't reverse() Array

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0fd991aa577a: [Notifications] Don't reverse() Array (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28650?vs=79565&id=80080 REVISION

D27701: [ComboBox] Use transparent dimmer

This revision was automatically updated to reflect the committed changes. Closed by commit R858:2c777b1b4661: [ComboBox] Use transparent dimmer (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27701?vs=76546&id=80072#toc REPOSITORY R858 Qt Quick Controls 2: Desktop

<    1   2   3   4   5   6   7   8   9   10   >