Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/08/2011 08:43 PM, Peter Maydell wrote: On 8 August 2011 18:06, Avi Kivitya...@redhat.com wrote: Somewhat clumsy since it needs a variable sized region. @@ -119,7 +120,7 @@ void omap_sdrc_reset(struct omap_sdrc_s *s); struct omap_gpmc_s; struct omap_gpmc_s

Re: [Qemu-devel] [PATCH v4 26/39] pcnet: convert to memory API

2011-08-09 Thread Bob Breuer
Avi Kivity wrote: Also related chips. Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/lance.c | 31 ++- hw/pcnet-pci.c | 74

Re: [Qemu-devel] [PATCH v4 26/39] pcnet: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/09/2011 09:55 AM, Bob Breuer wrote: static void lance_cleanup(VLANClientState *nc) @@ -117,13 +116,11 @@ static int lance_init(SysBusDevice *dev) SysBusPCNetState *d = FROM_SYSBUS(SysBusPCNetState, dev); PCNetState *s =d-state; -s-mmio_index = -

[Qemu-devel] [PATCH] lance: unbreak after memory API conversion

2011-08-09 Thread Avi Kivity
The conversion passed the wrong opaque pointer, causing a crash on first use. Pass the correct opaque. Signed-off-by: Avi Kivity a...@redhat.com --- hw/lance.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/lance.c b/hw/lance.c index 8e20360..d83e7f5 100644 ---

Re: [Qemu-devel] [PATCH] lance: unbreak after memory API conversion

2011-08-09 Thread Edgar E. Iglesias
On Tue, Aug 09, 2011 at 09:54:22AM +0300, Avi Kivity wrote: The conversion passed the wrong opaque pointer, causing a crash on first use. Pass the correct opaque. I've applied this, thanks. Signed-off-by: Avi Kivity a...@redhat.com --- hw/lance.c |2 +- 1 files changed, 1

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify drive is suitable for microdrive test

2011-08-09 Thread Kevin Wolf
Am 09.08.2011 06:32, schrieb andrzej zaborowski: On 4 August 2011 10:02, Kevin Wolf kw...@redhat.com wrote: Am 03.08.2011 22:20, schrieb andrzej zaborowski: On 3 August 2011 20:24, Markus Armbruster arm...@redhat.com wrote: andrzej zaborowski balr...@gmail.com writes: On 3 August 2011 18:38,

Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Peter Maydell
On 9 August 2011 07:34, Avi Kivity a...@redhat.com wrote: Also, my patchset focuses on mechanical transformations.  It is already risky enough in terms of regressions, I'm not going to rewrite/improve all of qemu; if you want those callbacks removed, you will have to remove them yourself.

Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/09/2011 10:37 AM, Peter Maydell wrote: On 9 August 2011 07:34, Avi Kivitya...@redhat.com wrote: Also, my patchset focuses on mechanical transformations. It is already risky enough in terms of regressions, I'm not going to rewrite/improve all of qemu; if you want those callbacks

[Qemu-devel] [PATCH v2 00/15] qcow/qcow2 cleanups

2011-08-09 Thread Frediano Ziglio
These patches mostly cleanup some AIO code using coroutines. Mostly they use stack instead of allocated AIO structure. Feel free to collapse it too short. Frediano Ziglio (15): qcow: allocate QCowAIOCB structure using stack qcow: QCowAIOCB field cleanup qcow: move some blocks of code to

[Qemu-devel] [PATCH v2 02/15] qcow: QCowAIOCB field cleanup

2011-08-09 Thread Frediano Ziglio
remove unused field from this structure and put some of them in qcow_aio_read_cb and qcow_aio_write_cb Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow.c | 137 +++-- 1 files changed, 65 insertions(+), 72 deletions(-) diff

[Qemu-devel] [PATCH v2 03/15] qcow: move some blocks of code to avoid useless variable initialization

2011-08-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow.c | 53 ++--- 1 files changed, 26 insertions(+), 27 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index f0b1599..e17f9c5 100644 --- a/block/qcow.c +++ b/block/qcow.c @@

[Qemu-devel] [PATCH v2 01/15] qcow: allocate QCowAIOCB structure using stack

2011-08-09 Thread Frediano Ziglio
instead of calling qemi_aio_get use stack Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow.c | 52 block/qcow2.c | 38 +++--- 2 files changed, 27 insertions(+), 63 deletions(-) diff --git

[Qemu-devel] [PATCH v2 15/15] qcow2: small optimization

2011-08-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2-refcount.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 0e31868..318d66d 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c

[Qemu-devel] [PATCH v2 13/15] qcow2: remove memory leak

2011-08-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 6073568..aed8da7 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -492,6 +492,7 @@ fail:

[Qemu-devel] [PATCH v2 14/15] qcow2: small math optimization

2011-08-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2-refcount.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 14b2f67..0e31868 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@

Re: [Qemu-devel] [PATCH 08/24] tusb6010: move declarations to new file tusb6010.h

2011-08-09 Thread Peter Maydell
On 8 August 2011 18:06, Avi Kivity a...@redhat.com wrote: diff --git a/hw/tusb6010.h b/hw/tusb6010.h new file mode 100644 index 000..6faa94d --- /dev/null +++ b/hw/tusb6010.h @@ -0,0 +1,10 @@ +#ifndef TUSB6010_H +#define TUSB6010_H + +typedef struct TUSBState TUSBState; +TUSBState

[Qemu-devel] [PATCH v2 11/15] qcow2: reindent and use while before the big jump

2011-08-09 Thread Frediano Ziglio
prepare to remove read/write callbacks Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c | 272 - 1 files changed, 135 insertions(+), 137 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index c7445cc..dfb969e

Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Peter Maydell
On 9 August 2011 08:41, Avi Kivity a...@redhat.com wrote: On 08/09/2011 10:37 AM, Peter Maydell wrote: On 9 August 2011 07:34, Avi Kivitya...@redhat.com  wrote:  Also, my patchset focuses on mechanical transformations.  It is already  risky enough in terms of regressions, I'm not going to

[Qemu-devel] [PATCH v2 10/15] qcow2: remove common from QCowAIOCB

2011-08-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 446946e..c7445cc 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -373,7 +373,7 @@ int

[Qemu-devel] [PATCH v2 06/15] qcow2: removed unused fields

2011-08-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index edc068e..5c454bb 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -381,11 +381,8 @@ typedef struct QCowAIOCB

[Qemu-devel] [PATCH v2 07/15] qcow2: removed cur_nr_sectors field in QCowAIOCB

2011-08-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c | 98 + 1 files changed, 43 insertions(+), 55 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 5c454bb..0cf4465 100644 --- a/block/qcow2.c +++

[Qemu-devel] [PATCH v2 08/15] qcow2: remove l2meta from QCowAIOCB

2011-08-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 0cf4465..adf31ce 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -381,7 +381,6 @@ typedef struct

[Qemu-devel] [PATCH v2 09/15] qcow2: remove cluster_offset from QCowAIOCB

2011-08-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index adf31ce..446946e 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -378,7 +378,6 @@ typedef

[Qemu-devel] [PATCH v2 05/15] qcow: remove old #undefined code

2011-08-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow.c | 63 -- 1 files changed, 0 insertions(+), 63 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 00f339f..0989799 100644 --- a/block/qcow.c +++ b/block/qcow.c @@

[Qemu-devel] [PATCH v2 12/15] qcow2: removed QCowAIOCB entirely

2011-08-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c | 207 ++--- 1 files changed, 80 insertions(+), 127 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index dfb969e..6073568 100644 --- a/block/qcow2.c +++

[Qemu-devel] [PATCH v2 04/15] qcow: embed qcow_aio_read_cb into qcow_co_readv and qcow_aio_write_cb into qcow_co_writev

2011-08-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow.c | 291 - 1 files changed, 123 insertions(+), 168 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index e17f9c5..00f339f 100644 --- a/block/qcow.c +++ b/block/qcow.c

Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/09/2011 11:07 AM, Peter Maydell wrote: On 9 August 2011 08:41, Avi Kivitya...@redhat.com wrote: On 08/09/2011 10:37 AM, Peter Maydell wrote: On 9 August 2011 07:34, Avi Kivitya...@redhat.comwrote: Also, my patchset focuses on mechanical transformations. It is already

Re: [Qemu-devel] [PATCH v5 2/4] block: add the block queue support

2011-08-09 Thread Ram Pai
On Tue, Aug 09, 2011 at 12:17:50PM +0800, Zhi Yong Wu wrote: The patch introduce one block queue for QEMU block layer. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- block/blk-queue.c | 141 + block/blk-queue.h | 73

Re: [Qemu-devel] [PATCH v5 2/4] block: add the block queue support

2011-08-09 Thread Zhi Yong Wu
On Tue, Aug 9, 2011 at 4:46 PM, Ram Pai linux...@us.ibm.com wrote: On Tue, Aug 09, 2011 at 12:17:50PM +0800, Zhi Yong Wu wrote: The patch introduce one block queue for QEMU block layer. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com ---  block/blk-queue.c |  141

Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/09/2011 11:44 AM, Avi Kivity wrote: ...isn't this just throwing away the warnings on bad-width accesses? It is; will fix. Reading the original code, it seems broken: uint32_t omap_badwidth_read32(void *opaque, target_phys_addr_t addr) { uint32_t ret; OMAP_32B_REG(addr);

Re: [Qemu-devel] [PATCH v5 3/4] block: add block timer and block throttling algorithm

2011-08-09 Thread Ram Pai
On Tue, Aug 09, 2011 at 12:17:51PM +0800, Zhi Yong Wu wrote: Note: 1.) When bps/iops limits are specified to a small value such as 511 bytes/s, this VM will hang up. We are considering how to handle this senario. 2.) When dd command is issued in guest, if its option bs is set to a

[Qemu-devel] [PATCH v1.1 08/24] tusb6010: move declarations to new file tusb6010.h

2011-08-09 Thread Avi Kivity
Avoid #include hell. Signed-off-by: Avi Kivity a...@redhat.com --- v1.1: add copyright/license blurb hw/devices.h |7 --- hw/nseries.c |1 + hw/tusb6010.c |2 +- hw/tusb6010.h | 25 + 4 files changed, 27 insertions(+), 8 deletions(-) create mode

[Qemu-devel] [PATCH v1.1 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Avi Kivity
Somewhat clumsy since it needs a variable sized region. Signed-off-by: Avi Kivity a...@redhat.com --- v1.1: set access size validity for omap gpmc region to allow only 32-bit accesses hw/omap.h |3 ++- hw/omap_gpmc.c | 56

Re: [Qemu-devel] [PATCH v5 3/4] block: add block timer and block throttling algorithm

2011-08-09 Thread Zhi Yong Wu
On Tue, Aug 9, 2011 at 4:57 PM, Ram Pai linux...@us.ibm.com wrote: On Tue, Aug 09, 2011 at 12:17:51PM +0800, Zhi Yong Wu wrote: Note:       1.) When bps/iops limits are specified to a small value such as 511 bytes/s, this VM will hang up. We are considering how to handle this senario.      

Re: [Qemu-devel] [ANNOUNCE] QEMU 0.15.0 Release

2011-08-09 Thread Avi Kivity
On 08/08/2011 10:16 PM, Anthony Liguori wrote: Hi, On behalf of the entire QEMU team, I'm please to announce the release of QEMU 0.15.0. This is the first release of the 0.15 branch and is intended for production usage. The 0.15.0 release is the product of almost 150 contributors with

[Qemu-devel] KVM call agenda for August 8

2011-08-09 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Later, Juan. PD. I was on vacation, and I forget to send the call for agenda before. Sorry.

Re: [Qemu-devel] [PATCH v1.1 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Peter Maydell
On 9 August 2011 10:02, Avi Kivity a...@redhat.com wrote: +static const MemoryRegionOps omap_gpmc_ops = { +    .read = omap_gpmc_read, +    .write = omap_gpmc_write, +    .endianness = DEVICE_NATIVE_ENDIAN, +    .valid = { +        .min_access_size = 4, +        .max_access_size = 4, +    

Re: [Qemu-devel] [PATCH v1.1 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/09/2011 12:23 PM, Peter Maydell wrote: On 9 August 2011 10:02, Avi Kivitya...@redhat.com wrote: +static const MemoryRegionOps omap_gpmc_ops = { +.read = omap_gpmc_read, +.write = omap_gpmc_write, +.endianness = DEVICE_NATIVE_ENDIAN, +.valid = { +

Re: [Qemu-devel] [PATCH v1.1 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Peter Maydell
On 9 August 2011 10:26, Avi Kivity a...@redhat.com wrote: On 08/09/2011 12:23 PM, Peter Maydell wrote: On 9 August 2011 10:02, Avi Kivitya...@redhat.com  wrote:  +static const MemoryRegionOps omap_gpmc_ops = {  +    .read = omap_gpmc_read,  +    .write = omap_gpmc_write,  +    

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-09 Thread supriya kannery
Kevin Wolf wrote: Am 08.08.2011 09:02, schrieb Supriya Kannery: On 08/05/2011 09:19 PM, Anthony Liguori wrote: On 08/05/2011 10:43 AM, Kevin Wolf wrote: Am 05.08.2011 17:24, schrieb Stefan Hajnoczi: On Fri, Aug 5, 2011 at 3:28 PM, Christoph Hellwigh...@lst.de wrote:

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-09 Thread Kevin Wolf
Am 09.08.2011 11:22, schrieb supriya kannery: Kevin Wolf wrote: Am 08.08.2011 09:02, schrieb Supriya Kannery: On 08/05/2011 09:19 PM, Anthony Liguori wrote: On 08/05/2011 10:43 AM, Kevin Wolf wrote: Am 05.08.2011 17:24, schrieb Stefan Hajnoczi: On Fri, Aug 5, 2011

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-09 Thread supriya kannery
Kevin Wolf wrote: Am 09.08.2011 11:22, schrieb supriya kannery: Kevin Wolf wrote: Am 08.08.2011 09:02, schrieb Supriya Kannery: On 08/05/2011 09:19 PM, Anthony Liguori wrote: On 08/05/2011 10:43 AM, Kevin Wolf wrote: Am 05.08.2011 17:24,

Re: [Qemu-devel] [PATCH v4 14/39] ac97: convert to memory API

2011-08-09 Thread malc
On Mon, 8 Aug 2011, Avi Kivity wrote: fixes BAR sizing as well. I'm fine with this version, thanks. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types

2011-08-09 Thread malc
On Mon, 8 Aug 2011, Peter Maydell wrote: On 8 August 2011 13:56, Avi Kivity a...@redhat.com wrote: QEMU deals with a lot of fixed width integer types; their names (uint64_t etc) are clumsy to use and take up a lot of space. Following Linux, introduce shorter names, for example U64 for

Re: [Qemu-devel] [PATCH v4 17/39] es1370: convert to memory API

2011-08-09 Thread malc
On Mon, 8 Aug 2011, Avi Kivity wrote: Fine with this too, thanks. [..snip..] -- mailto:av1...@comtv.ru

[Qemu-devel] [PATCH] qxl: allowing the command rings to be not empty when spice worker is stopped RHBZ #728984

2011-08-09 Thread Yonit Halperin
same as 8927cfbba232e28304734f7afd463c1b84134031, but for qxl_check_state, that was triggered by qxl_pre_load (which calls qxl_hard_reset, which calls qxl_soft_reset), and caused the migration target to crash. --- hw/qxl.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [PATCH v5 1/4] block: add the command line support

2011-08-09 Thread Stefan Hajnoczi
On Tue, Aug 9, 2011 at 5:17 AM, Zhi Yong Wu wu...@linux.vnet.ibm.com wrote: Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com ---  Makefile.objs   |    2 +-  blockdev.c      |   39 +++  qemu-config.c   |   24  qemu-option.c   |  

Re: [Qemu-devel] [ANNOUNCE] QEMU 0.15.0 Release

2011-08-09 Thread Anthony Liguori
On 08/09/2011 04:11 AM, Avi Kivity wrote: On 08/08/2011 10:16 PM, Anthony Liguori wrote: Hi, On behalf of the entire QEMU team, I'm please to announce the release of QEMU 0.15.0. This is the first release of the 0.15 branch and is intended for production usage. The 0.15.0 release is the

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-09 Thread Stefan Hajnoczi
On Tue, Aug 9, 2011 at 11:35 AM, Kevin Wolf kw...@redhat.com wrote: Am 09.08.2011 12:25, schrieb Stefan Hajnoczi: On Mon, Aug 8, 2011 at 4:16 PM, Kevin Wolf kw...@redhat.com wrote: Am 08.08.2011 16:49, schrieb Stefan Hajnoczi: On Fri, Aug 5, 2011 at 10:48 AM, Kevin Wolf kw...@redhat.com wrote:

[Qemu-devel] Regarding guest physical addresses for multithreaded program

2011-08-09 Thread Amit Roy
Hi, I have recently started using Qemu. I have a very specific requirement which has been discussed previously at length. I want to capture the guest physical address trace of multithreaded programs (x86_64 arch). After going through the archives, I have been able to record the guest virtual

Re: [Qemu-devel] KVM call agenda for August 8

2011-08-09 Thread Anthony Liguori
On 08/09/2011 04:21 AM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. I think we can skip since many people will be in Vancouver next week and we'll have plenty to talk about then. Just a couple reminders, for KVM Forum speakers, please post your

Re: [Qemu-devel] [Spice-devel] [PATCH] qxl: allowing the command rings to be not empty when spice worker is stopped RHBZ #728984

2011-08-09 Thread Arnon Gilboa
Acked-by: Arnon Gilboa agil...@redhat.com Yonit Halperin wrote: same as 8927cfbba232e28304734f7afd463c1b84134031, but for qxl_check_state, that was triggered by qxl_pre_load (which calls qxl_hard_reset, which calls qxl_soft_reset), and caused the migration target to crash. --- hw/qxl.c |

[Qemu-devel] [PATCH v1.2 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Avi Kivity
Somewhat clumsy since it needs a variable sized region. Signed-off-by: Avi Kivity a...@redhat.com --- v1.2: drop v1.1 changes, instead forward invalid size accesses to original omap_badwidth_*() functions v1.1: set access size validity for omap gpmc region to allow only 32-bit

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify drive is suitable for microdrive test

2011-08-09 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 09.08.2011 13:56, schrieb Markus Armbruster: bdrv_is_locked() is about the frontend's media lock. To make this more obvious, my PATCH 29/55 replaces it by bdrv_dev_is_medium_locked(). It does *not* query the backend's lock (which may not even exist!)

Re: [Qemu-devel] [PATCH v1.1 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/09/2011 12:41 PM, Peter Maydell wrote: On 9 August 2011 10:26, Avi Kivitya...@redhat.com wrote: On 08/09/2011 12:23 PM, Peter Maydell wrote: On 9 August 2011 10:02, Avi Kivitya...@redhat.comwrote: +static const MemoryRegionOps omap_gpmc_ops = { +.read =

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-09 Thread Stefan Hajnoczi
On Tue, Aug 9, 2011 at 11:50 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Aug 9, 2011 at 11:35 AM, Kevin Wolf kw...@redhat.com wrote: Am 09.08.2011 12:25, schrieb Stefan Hajnoczi: On Mon, Aug 8, 2011 at 4:16 PM, Kevin Wolf kw...@redhat.com wrote: Am 08.08.2011 16:49, schrieb Stefan

Re: [Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1

2011-08-09 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 4:52 PM, rowa 816...@bugs.launchpad.net wrote: Now it is possible to build qemu 0.15.0-rc1 with --disable-spice option on Ubuntu 10.10 „Maverick Meerkat“ . -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v4 26/39] pcnet: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/09/2011 03:48 PM, Michael S. Tsirkin wrote: But in some cases, we can't, and the it's a pain having to wrap MemoryRegion in another structure containing an opaque. I guess, even though that wrapping structure would use a proper type, not an opaque. Yes, of course - that's what the

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify drive is suitable for microdrive test

2011-08-09 Thread Kevin Wolf
Am 09.08.2011 14:36, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 09.08.2011 13:56, schrieb Markus Armbruster: bdrv_is_locked() is about the frontend's media lock. To make this more obvious, my PATCH 29/55 replaces it by bdrv_dev_is_medium_locked(). It does *not*

Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types

2011-08-09 Thread Juan Quintela
Peter Maydell peter.mayd...@linaro.org wrote: On 8 August 2011 13:56, Avi Kivity a...@redhat.com wrote: QEMU deals with a lot of fixed width integer types; their names (uint64_t etc) are clumsy to use and take up a lot of space. Following Linux, introduce shorter names, for example U64 for

Re: [Qemu-devel] [PATCH v4 26/39] pcnet: convert to memory API

2011-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2011 at 09:52:17AM +0300, Avi Kivity wrote: On 08/09/2011 09:55 AM, Bob Breuer wrote: static void lance_cleanup(VLANClientState *nc) @@ -117,13 +116,11 @@ static int lance_init(SysBusDevice *dev) SysBusPCNetState *d = FROM_SYSBUS(SysBusPCNetState, dev);

Re: [Qemu-devel] [PATCH 0/4] usb/hid: bugfixes, more on usb and hid split

2011-08-09 Thread Gerd Hoffmann
On 08/07/11 19:29, Michael Walle wrote: This USB patchset moves the VM state stuff from usb-hid.c to hid.c, so it can be reused by other devices. Nice. There is one major drawback: i need to increase the vmstate version_id of the usb-hid device. I don't know if you agree with this change.

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-09 Thread Stefan Hajnoczi
On Tue, Aug 09, 2011 at 01:39:13PM +0200, Kevin Wolf wrote: Am 09.08.2011 12:56, schrieb Stefan Hajnoczi: On Tue, Aug 9, 2011 at 11:50 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Aug 9, 2011 at 11:35 AM, Kevin Wolf kw...@redhat.com wrote: Am 09.08.2011 12:25, schrieb Stefan

Re: [Qemu-devel] [PATCH v5 2/4] block: add the block queue support

2011-08-09 Thread Stefan Hajnoczi
On Tue, Aug 9, 2011 at 5:17 AM, Zhi Yong Wu wu...@linux.vnet.ibm.com wrote: +/* The APIs for block request queue on qemu block layer. + */ + +static void qemu_block_queue_cancel(BlockDriverAIOCB *acb) +{ +    qemu_aio_release(acb); +} + +static AIOPool block_queue_pool = { +    

[Qemu-devel] [PATCH] etrax: QDevify the Ethernet MAC.

2011-08-09 Thread Edgar E. Iglesias
Hi, This QDevifies the ETRAX Ethernet MAC. DMA Connections remain adhoc.. Cheers commit ad1a1afaa185de0ed668f9bc3fb4f3cb076b32a0 Author: Edgar E. Iglesias edgar.igles...@gmail.com Date: Tue Aug 9 13:24:04 2011 +0200 etrax: QDevify the Ethernet MAC. Signed-off-by: Edgar E.

Re: [Qemu-devel] [PATCH] PPC: Fix sync instructions problem in SMP

2011-08-09 Thread Alexander Graf
On 08/04/2011 12:34 PM, Elie Richa wrote: bump. Anybody have opinions on this? I can provide a more thorough explanation of the problem if needed. I wrote the test case in Ada for an MPC8641D processor (2 e600 cores) on a board that is not yet submitted to the list, therefore I cannot

[Qemu-devel] [PATCH] hw/qxl: fir build break with newer spice

2011-08-09 Thread Alon Levy
ioport_write's val was changed from uint32_t to uint64_t, this broke two printfs. Use PRId64 instead of %d. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index db7ae7a..2335e4b 100644 ---

Re: [Qemu-devel] [PATCH v4 26/39] pcnet: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/09/2011 03:42 PM, Michael S. Tsirkin wrote: On Tue, Aug 09, 2011 at 09:52:17AM +0300, Avi Kivity wrote: On 08/09/2011 09:55 AM, Bob Breuer wrote: static void lance_cleanup(VLANClientState *nc) @@ -117,13 +116,11 @@ static int lance_init(SysBusDevice *dev)

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify drive is suitable for microdrive test

2011-08-09 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 09.08.2011 06:32, schrieb andrzej zaborowski: On 4 August 2011 10:02, Kevin Wolf kw...@redhat.com wrote: Am 03.08.2011 22:20, schrieb andrzej zaborowski: On 3 August 2011 20:24, Markus Armbruster arm...@redhat.com wrote: andrzej zaborowski

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-09 Thread Kevin Wolf
Am 09.08.2011 12:56, schrieb Stefan Hajnoczi: On Tue, Aug 9, 2011 at 11:50 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Aug 9, 2011 at 11:35 AM, Kevin Wolf kw...@redhat.com wrote: Am 09.08.2011 12:25, schrieb Stefan Hajnoczi: On Mon, Aug 8, 2011 at 4:16 PM, Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH v5 0/4] The intro of QEMU block I/O throttling

2011-08-09 Thread Stefan Hajnoczi
On Tue, Aug 9, 2011 at 5:17 AM, Zhi Yong Wu wu...@linux.vnet.ibm.com wrote:  Makefile.objs     |    2 +-  block.c           |  347 +++--  block.h           |    6 +-  block/blk-queue.c |  141 ++  block/blk-queue.h |   73

Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set.

2011-08-09 Thread Anthony PERARD
On Fri, Aug 5, 2011 at 17:53, Anthony Liguori anth...@codemonkey.ws wrote: You'll break some GCCs with -Wall -Werror with this.  Please do: if ((val E1000_CTRL_RST)) { :(, I never heard of this. But OK, I will do that. -- Anthony PERARD

Re: [Qemu-devel] [PATCH v4 26/39] pcnet: convert to memory API

2011-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2011 at 03:44:35PM +0300, Avi Kivity wrote: On 08/09/2011 03:42 PM, Michael S. Tsirkin wrote: On Tue, Aug 09, 2011 at 09:52:17AM +0300, Avi Kivity wrote: On 08/09/2011 09:55 AM, Bob Breuer wrote: static void lance_cleanup(VLANClientState *nc) @@ -117,13 +116,11 @@

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-09 Thread Kevin Wolf
Am 09.08.2011 12:25, schrieb Stefan Hajnoczi: On Mon, Aug 8, 2011 at 4:16 PM, Kevin Wolf kw...@redhat.com wrote: Am 08.08.2011 16:49, schrieb Stefan Hajnoczi: On Fri, Aug 5, 2011 at 10:48 AM, Kevin Wolf kw...@redhat.com wrote: Am 05.08.2011 11:29, schrieb Stefan Hajnoczi: On Fri, Aug 5, 2011

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify drive is suitable for microdrive test

2011-08-09 Thread Kevin Wolf
Am 09.08.2011 13:56, schrieb Markus Armbruster: bdrv_is_locked() is about the frontend's media lock. To make this more obvious, my PATCH 29/55 replaces it by bdrv_dev_is_medium_locked(). It does *not* query the backend's lock (which may not even exist!) set by bdrv_set_locked(). This sounds

Re: [Qemu-devel] KVM call agenda for August 8

2011-08-09 Thread Juan Quintela
Anthony Liguori anth...@codemonkey.ws wrote: On 08/09/2011 04:21 AM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. I think we can skip since many people will be in Vancouver next week and we'll have plenty to talk about then. Just a couple

[Qemu-devel] Información importante

2011-08-09 Thread Frank Mill
- This mail is in HTML. Some elements may be ommited in plain text. - Leer archivo adjunto para más detalles de sus fondos muertos miembro de la familia. Saludos, Yo soy el Sr. Frank Miller, el gerente de créditos del Sistema Nacional de Salud Fiduciario en Holanda. Hay una cuenta que

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-09 Thread Stefan Hajnoczi
On Mon, Aug 8, 2011 at 4:16 PM, Kevin Wolf kw...@redhat.com wrote: Am 08.08.2011 16:49, schrieb Stefan Hajnoczi: On Fri, Aug 5, 2011 at 10:48 AM, Kevin Wolf kw...@redhat.com wrote: Am 05.08.2011 11:29, schrieb Stefan Hajnoczi: On Fri, Aug 5, 2011 at 10:07 AM, Kevin Wolf kw...@redhat.com wrote:

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-09 Thread Kevin Wolf
Am 09.08.2011 14:00, schrieb Stefan Hajnoczi: On Tue, Aug 09, 2011 at 01:39:13PM +0200, Kevin Wolf wrote: Am 09.08.2011 12:56, schrieb Stefan Hajnoczi: On Tue, Aug 9, 2011 at 11:50 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Aug 9, 2011 at 11:35 AM, Kevin Wolf kw...@redhat.com wrote:

[Qemu-devel] Ahmed

2011-08-09 Thread Ahmed
e suis le fils de l'ancien ministre de la Guinée (Mariame Sy Diallo) mais je vis actuellement en Angleterre, j'ai trouvé votre adresse à la chambre de commerce ici à Londres, j'ai besoin de votre aide pour investir au Maroc ou Algérie ou en Tunisie. Si vous êtes intéressé à ma demandes'il vous

[Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1

2011-08-09 Thread rowa
Hi Stefan, here is the file qapi-visit-core.txt: http://pastebin.com/6sG5PdXQ Robert -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/816370 Title: compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1

Re: [Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1

2011-08-09 Thread Michael Roth
On 08/09/2011 07:02 AM, rowa wrote: Hi Stefan, here is the file qapi-visit-core.txt: http://pastebin.com/6sG5PdXQ Robert This seems to confirm ALSA's error.h is the culprit: # # 375 ./qemu-common.h 2 # # 18 ./qapi/qapi-types-core.h 2 # # 1 /usr/include/alsa/error.h 1 # # 45

Re: [Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1

2011-08-09 Thread Michael Roth
On 08/08/2011 11:46 PM, rowa wrote: This Bug is not fixed in QEMU 0.15.0 :-( Hi Rowa, Take a look at Gerd Hoffmann's comment: it looks like Spice server 0.8.2 pulls in some ALSA includes that contain a error.h which ends up clobbering the error.h that that particular C file is trying to

Re: [Qemu-devel] [PATCH v5 3/4] block: add block timer and block throttling algorithm

2011-08-09 Thread Stefan Hajnoczi
On Tue, Aug 9, 2011 at 5:17 AM, Zhi Yong Wu wu...@linux.vnet.ibm.com wrote: Note:      1.) When bps/iops limits are specified to a small value such as 511 bytes/s, this VM will hang up. We are considering how to handle this senario. If an I/O request is larger than the limit itself then I

Re: [Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1

2011-08-09 Thread Stefan Hajnoczi
On Tue, Aug 9, 2011 at 4:01 PM, Michael Roth 816...@bugs.launchpad.net wrote: Take a look at Gerd Hoffmann's comment: it looks like Spice server 0.8.2 pulls in some ALSA includes that contain a error.h which ends up clobbering the error.h that that particular C file is trying to pull in. Wow,

[Qemu-devel] coroutine-win32.c:36: error: thread-local storage not supported for this target

2011-08-09 Thread Sebastian Herbszt
CCcoroutine-win32.o coroutine-win32.c:36: error: thread-local storage not supported for this target coroutine-win32.c:37: error: thread-local storage not supported for this target make: *** [coroutine-win32.o] Error 1 Sebastian

Re: [Qemu-devel] coroutine-win32.c:36: error: thread-local storage not supported for this target

2011-08-09 Thread Paolo Bonzini
On 08/09/2011 05:53 PM, Sebastian Herbszt wrote: CC coroutine-win32.o coroutine-win32.c:36: error: thread-local storage not supported for this target coroutine-win32.c:37: error: thread-local storage not supported for this target make: *** [coroutine-win32.o] Error 1 You need a newer GCC.

Re: [Qemu-devel] [PATCH] hw/qxl: fir build break with newer spice

2011-08-09 Thread Alon Levy
On Tue, Aug 09, 2011 at 03:21:15PM +0300, Alon Levy wrote: ioport_write's val was changed from uint32_t to uint64_t, this broke two printfs. Use PRId64 instead of %d. Nack, missed a 'd' on the second fix. And the subject has a typo. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c

[Qemu-devel] [PATCH 0/3] PPC: Support -M pseries for PR KVM

2011-08-09 Thread Alexander Graf
We have support for -M pseries with TCG for a while now, but are missing integration with KVM. While the KVM HV target which is predestined for -M pseries is slightly more tricky to integrate and needs to evolve a bit still, we can easily support it with PR KVM. So this patch set adds support for

[Qemu-devel] [PATCH 2/3] PPC: Enable to use PAPR with PR style KVM

2011-08-09 Thread Alexander Graf
When running PR style KVM, we need to tell the kernel that we want to run in PAPR mode now. This means that we need to pass some more register information down and enable papr mode. We also need to align the HTAB to htab_size boundary. Using this patch, -M pseries works with kvm even on non-hv

[Qemu-devel] [PATCH 1/3] KVM: update kernel headers

2011-08-09 Thread Alexander Graf
This patch updates the kvm kernel headers to the latest version. Signed-off-by: Alexander Graf ag...@suse.de --- linux-headers/asm-powerpc/kvm.h | 23 +++ linux-headers/asm-x86/kvm_para.h | 14 ++ linux-headers/linux/kvm.h| 25

[Qemu-devel] [PATCH 3/3] PPC: SPAPR: Use KVM function for time info

2011-08-09 Thread Alexander Graf
One of the things we can't fake on PPC is the timer speed. So we need to extract the frequency information from the host and put it back into the guest device tree. Luckily, we already have functions for that from the non-pseries targets, so all we need to do is to connect the dots and the guest

Re: [Qemu-devel] coroutine-win32.c:36: error: thread-local storage not supported for this target

2011-08-09 Thread Sebastian Herbszt
Paolo Bonzini wrote: On 08/09/2011 05:53 PM, Sebastian Herbszt wrote: CC coroutine-win32.o coroutine-win32.c:36: error: thread-local storage not supported for this target coroutine-win32.c:37: error: thread-local storage not supported for this target make: *** [coroutine-win32.o] Error 1 You

[Qemu-devel] VNC server running on `127.0.0.1:5900'

2011-08-09 Thread Nithish R
Hi, I installed the latest version of Qemu 0.15.0 today. Until now I was using 0.14.1. Now after installing this new version, I am not able to boot into any guest OS that I had installed before. Also while trying to load any ISO file or img file, I get an output as: :~/Qemu$ qemu -m 512 -hda

Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set.

2011-08-09 Thread Peter Maydell
On 9 August 2011 15:10, Anthony PERARD anthony.per...@citrix.com wrote: On Fri, Aug 5, 2011 at 17:53, Anthony Liguori anth...@codemonkey.ws wrote: You'll break some GCCs with -Wall -Werror with this.  Please do: if ((val E1000_CTRL_RST)) { :(, I never heard of this. But OK, I will do that.

Re: [Qemu-devel] build failure with coroutine-gthread

2011-08-09 Thread Blue Swirl
On Mon, Aug 8, 2011 at 9:29 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Aug 8, 2011 at 10:01 AM, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote:  LINK  qemu-ga coroutine-gthread.o: In function `coroutine_init':

Re: [Qemu-devel] [PULL 0/7] ARM patch queue (for master)

2011-08-09 Thread Edgar E. Iglesias
On Mon, Aug 08, 2011 at 10:54:47AM +0100, Peter Maydell wrote: Ping? I've applied this, thanks. Cheers

Re: [Qemu-devel] build failure with coroutine-gthread

2011-08-09 Thread Aneesh Kumar K.V
On Tue, 9 Aug 2011 17:28:17 +, Blue Swirl blauwir...@gmail.com wrote: On Mon, Aug 8, 2011 at 9:29 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Aug 8, 2011 at 10:01 AM, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote:  LINK  qemu-ga coroutine-gthread.o: In function

[Qemu-devel] [PATCH 0/3] linux-user: Implement setxattr/getxattr/removexattr syscalls

2011-08-09 Thread An-Cheng Huang
These patches implement the setxattr, getxattr, and removexattr syscalls. Since libattr uses indirect syscalls for these, the fix for the indirect syscall handling on MIPS is needed for these to work. An-Cheng Huang (3): linux-user: Fix MIPS indirect syscall handling linux-user: Verify MIPS

[Qemu-devel] [PATCH 1/3] linux-user: Fix MIPS indirect syscall handling

2011-08-09 Thread An-Cheng Huang
Change the number of argument for MIPS sys_syscall from 0 to 8. This allows arguments for indirect syscalls to be processed correctly. Signed-off-by: An-Cheng Huang anch...@ubnt.com --- linux-user/main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/main.c

  1   2   >