Re: [Qemu-devel] [PATCH 4/4] block: drop bs->job

2019-06-17 Thread Vladimir Sementsov-Ogievskiy
17.06.2019 19:58, Kevin Wolf wrote: > Am 06.06.2019 um 17:41 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Drop remaining users of bs->job: >> 1. assertions actually duplicated by assert(!bs->refcnt) >> 2. trace-point seems not enough reason to change stream_start to return >> BlockJob point

Re: [Qemu-devel] [RFC PATCH v2 09/35] multi-process: setup PCI host bridge for remote device

2019-06-17 Thread Gerd Hoffmann
On Mon, Jun 17, 2019 at 11:15:39AM -0700, elena.ufimts...@oracle.com wrote: > From: Jagannathan Raman > > PCI host bridge is setup for the remote device process. It is > implemented using remote-pcihost object. It is an extension of the PCI > host bridge setup by QEMU. > Remote-pcihost configures

[Qemu-devel] [PULL v2 12/16] monitor: Split out monitor/hmp.c

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf Move HMP infrastructure from monitor/misc.c to monitor/hmp.c. This is code that can be shared for all targets, so compile it only once. The amount of function and particularly extern variables in monitor_int.h is probably a bit larger than it needs to be, but this way no non-tri

[Qemu-devel] [PULL v2 00/16] Monitor patches for 2019-06-17

2019-06-17 Thread Markus Armbruster
The following changes since commit 076243ffe6c1b687e9e6d98348c3bf3398df78f3: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-docs-20190617' into staging (2019-06-17 16:41:25 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-monit

Re: [Qemu-devel] [RFC PATCH v2 06/35] multi-process: build system for remote device process

2019-06-17 Thread Gerd Hoffmann
Hi, > +# > +# remote-pci-obj-y is common code used by remote devices > + > +remote-pci-obj-$(CONFIG_MPQEMU) += hw/ > +remote-pci-obj-$(CONFIG_MPQEMU) += qom/ > +remote-pci-obj-$(CONFIG_MPQEMU) += backends/ > +remote-pci-obj-$(CONFIG_MPQEMU)

Re: [Qemu-devel] [PULL 00/16] Monitor patches for 2019-06-17

2019-06-17 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 17 Jun 2019 at 19:51, Markus Armbruster wrote: >> >> The following changes since commit 076243ffe6c1b687e9e6d98348c3bf3398df78f3: >> >> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-docs-20190617' >&

Re: [Qemu-devel] [PATCH 2/3] net: Deprecate tap backend's parameter "helper"

2019-06-17 Thread Jason Wang
On 2019/6/18 下午1:32, Markus Armbruster wrote: Jason Wang writes: On 2019/6/4 下午7:52, Markus Armbruster wrote: -netdev tap,helper=... is a useless duplicate of -netdev bridge. Deprecate and de-document. Signed-off-by: Markus Armbruster This requires more thought as TAP could be used inde

Re: [Qemu-devel] [PATCH 2/3] net: Deprecate tap backend's parameter "helper"

2019-06-17 Thread Markus Armbruster
Jason Wang writes: > On 2019/6/4 下午7:52, Markus Armbruster wrote: >> -netdev tap,helper=... is a useless duplicate of -netdev bridge. >> Deprecate and de-document. >> >> Signed-off-by: Markus Armbruster > > > This requires more thought as TAP could be used independently. Force > using a "bridge"

Re: [Qemu-devel] [PATCH v1 1/9] target/riscv: Restructure deprecatd CPUs

2019-06-17 Thread Philippe Mathieu-Daudé
On 6/18/19 3:31 AM, Alistair Francis wrote: > Restructure the deprecated CPUs to make it clear in the code that these > are depreated. They are already marked as deprecated in > qemu-deprecated.texi. There are no functional changes. > > Signed-off-by: Alistair Francis > --- > target/riscv/cpu.c

Re: [Qemu-devel] [PATCH 2/5] i.mx7d: Add no-op/unimplemented PCIE PHY IP block

2019-06-17 Thread Philippe Mathieu-Daudé
On 4/16/19 3:38 AM, Andrey Smirnov wrote: > Add no-op/unimplemented PCIE PHY IP block. Needed by new kernels to > use PCIE. > > Signed-off-by: Andrey Smirnov > Cc: Peter Maydell > Cc: Michael S. Tsirkin > Cc: qemu-devel@nongnu.org > Cc: qemu-...@nongnu.org > --- > include/hw/arm/fsl-imx7.h | 3

[Qemu-devel] [PATCH v2] vhost-user: fix reconnection support for host notifier

2019-06-17 Thread Tiwei Bie
We need to destroy the host notifiers when cleaning up the backend. Otherwise, some resources are not released after the connection is closed, and it may prevent the external backend from reopening them (e.g. VFIO files) during restart. Fixes: 44866521bd6e ("vhost-user: support registering externa

Re: [Qemu-devel] [PATCH 1/5] i.mx7d: Add no-op/unimplemented APBH DMA module

2019-06-17 Thread Philippe Mathieu-Daudé
On 4/16/19 3:38 AM, Andrey Smirnov wrote: > Instantiate no-op APBH DMA module. Needed to boot latest Linux kernel. > > Signed-off-by: Andrey Smirnov > Cc: Peter Maydell > Cc: Michael S. Tsirkin > Cc: qemu-devel@nongnu.org > Cc: qemu-...@nongnu.org > --- > include/hw/arm/fsl-imx7.h | 3 +++ > h

Re: [Qemu-devel] [RFC PATCH v2 01/35] multi-process: memory: alloc RAM from file at offset

2019-06-17 Thread Gerd Hoffmann
On Mon, Jun 17, 2019 at 11:14:59AM -0700, elena.ufimts...@oracle.com wrote: > From: Jagannathan Raman > > Allow RAM MemoryRegion to be created from an offset in a file, instead > of allocating at offset of 0 by default. This is needed to synchronize > RAM between QEMU & remote process. > This wil

Re: [Qemu-devel] [PATCH 5/6] hw/timer/armv7m_systick: Forbid non-privileged accesses

2019-06-17 Thread Philippe Mathieu-Daudé
On 6/17/19 7:53 PM, Peter Maydell wrote: > Like most of the v7M memory mapped system registers, the systick > registers are accessible to privileged code only and user accesses > must generate a BusFault. We implement that for registers in > the NVIC proper already, but missed it for systick since

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

2019-06-17 Thread Richard Henderson
Ping. Otherwise I'll include it in my next tcg pull. r~ On 5/18/19 9:15 PM, Richard Henderson wrote: > Based-on: <20190518190157.21255-1-richard.hender...@linaro.org> > Aka "tcg: misc gvec improvements". > > Version 3 was last posted in March, > https://lists.gnu.org/archive/html/qemu-devel/20

[Qemu-devel] [Bug 639651] Re: DRIVER_IRQL_NOT_LESS_OR_EQUAL booting WIndows XP with Synaptics driver installed

2019-06-17 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/639651 Title: DRIVER_IRQL_

Re: [Qemu-devel] [PATCH 0/3] Some qemu-bridge-helper work

2019-06-17 Thread Jason Wang
On 2019/6/4 下午7:52, Markus Armbruster wrote: Markus Armbruster (3): MAINTAINERS: Add qemu-bridge-helper.c to "Network device backends" net: Deprecate tap backend's parameter "helper" qemu-bridge-helper: Document known shortcomings MAINTAINERS | 1 + qapi/net.json|

Re: [Qemu-devel] [PATCH 2/3] net: Deprecate tap backend's parameter "helper"

2019-06-17 Thread Jason Wang
On 2019/6/4 下午7:52, Markus Armbruster wrote: -netdev tap,helper=... is a useless duplicate of -netdev bridge. Deprecate and de-document. Signed-off-by: Markus Armbruster This requires more thought as TAP could be used independently. Force using a "bridge" backend may lead some confusion.

Re: [Qemu-devel] [PATCH v4 5/5] net/announce: Expand test for stopping self announce

2019-06-17 Thread Jason Wang
On 2019/6/13 下午5:59, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Expand self-announce test to check we can stop an announce timer. We set it up to send 300 packets, but after we receive the first one we tell it to stop. We error if: a) We receive more than 30 of th

Re: [Qemu-devel] [PATCH v4 3/5] net/announce: Add optional ID

2019-06-17 Thread Jason Wang
On 2019/6/13 下午5:59, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Previously there was a single instance of the timer used by monitor triggered announces, that's OK, but when combined with the previous change that lets you have announces for subsets of interfaces it's a

Re: [Qemu-devel] [PATCH v4 1/5] net/announce: Allow optional list of interfaces

2019-06-17 Thread Jason Wang
On 2019/6/13 下午5:59, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Allow the caller to restrict the set of interfaces that announces are sent on. The default is still to send on all interfaces. e.g. { "execute": "announce-self", "arguments": { "initial": 50, "max":

Re: [Qemu-devel] [PATCH v4 0/5] network announce; interface selection & IDs

2019-06-17 Thread Jason Wang
On 2019/6/13 下午5:59, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Laine asked for some extra features on the network announce support; It's better to explain why this feature is needed.  Is this because libvirt can change the host network topology on the fly? Thank

[Qemu-devel] [PATCH v1 7/9] target/riscv: Remove user version information

2019-06-17 Thread Alistair Francis
Remove the user version information. This was never used and never publically exposed in a release of QEMU, so let's just remove it. In future to manage versions we can extend the extension properties to specify version. Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 32 +--

[Qemu-devel] [PATCH v1 8/9] target/riscv: Add support for disabling/enabling Counters

2019-06-17 Thread Alistair Francis
Add support for disabling/enabling the "Counters" extension. Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 1 + target/riscv/cpu.h | 1 + target/riscv/csr.c | 7 +++ 3 files changed, 9 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index ddbe922958..5af1c9b38c

[Qemu-devel] [PATCH v1 6/9] target/riscv: Require either I or E base extension

2019-06-17 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index a23d83921a..21bfaa9722 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -373,6 +373,12 @@ static void riscv_cpu_realize(DeviceS

[Qemu-devel] [PATCH v1 3/9] target/riscv: Comment in the mcountinhibit CSR

2019-06-17 Thread Alistair Francis
Add a comment for the new mcountinhibit which conflicts with the CSR_MUCOUNTEREN from version 1.09.1. This can be updated when we remove 1.09.1. Signed-off-by: Alistair Francis --- target/riscv/cpu_bits.h | 1 + target/riscv/csr.c | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v1 9/9] target/riscv: Add Zifencei and Zicsr as command line options

2019-06-17 Thread Alistair Francis
For completeness let's add Zifencei and Zicsr as command line options, even though they can't be disabled at the moment. Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 9 + target/riscv/cpu.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/target/riscv/cpu.c b/target/ri

[Qemu-devel] [PATCH v1 1/9] target/riscv: Restructure deprecatd CPUs

2019-06-17 Thread Alistair Francis
Restructure the deprecated CPUs to make it clear in the code that these are depreated. They are already marked as deprecated in qemu-deprecated.texi. There are no functional changes. Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 18 ++ target/riscv/cpu.h | 13 +++--

[Qemu-devel] [PATCH v1 5/9] qemu-deprecated.texi: Deprecate the RISC-V privledge spec 1.09.1

2019-06-17 Thread Alistair Francis
Deprecate the RISC-V privledge spec version 1.09.1 in favour of the new 1.10.0 and the ratified 1.11.0. Signed-off-by: Alistair Francis --- qemu-deprecated.texi | 8 1 file changed, 8 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 50292d820b..bdebf7 10

[Qemu-devel] [PATCH v1 2/9] target/riscv: Add the privledge spec version 1.11.0

2019-06-17 Thread Alistair Francis
Add support for the ratified RISC-V privledge spec. Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 1 + target/riscv/insn_trans/trans_privileged.inc.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu

[Qemu-devel] [PATCH v1 0/9] Update the RISC-V specification versions

2019-06-17 Thread Alistair Francis
Based-on: Now that the RISC-V spec has started to be ratified let's update our QEMU implementation. There are a few things going on here: - Add priv version 1.11.0 to QEMU - This is the ratified version of the Privledge spec - There are almost no changes to 1.10 - Mark the 1.09.1 privle

[Qemu-devel] [PATCH v1 4/9] target/riscv: Set privledge spec 1.11.0 as default

2019-06-17 Thread Alistair Francis
Set the priv spec version 1.11.0 as the default and allow selecting it via the command line. Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index a4dd7ae6fc..a23d83921a 100

Re: [Qemu-devel] [PATCH 3/5] pci: designware: Update MSI mapping unconditionally

2019-06-17 Thread Michael S. Tsirkin
On Mon, Apr 15, 2019 at 06:39:00PM -0700, Andrey Smirnov wrote: > Expression to calculate update_msi_mapping in code handling writes to > DESIGNWARE_PCIE_MSI_INTR0_ENABLE is missing an ! operator and should > be: > > !!root->msi.intr[0].enable ^ !!val; > > so that MSI mapping is updated when

Re: [Qemu-devel] [PATCH 4/5] pci: designware: Update MSI mapping when MSI address changes

2019-06-17 Thread Michael S. Tsirkin
On Mon, Apr 15, 2019 at 06:39:01PM -0700, Andrey Smirnov wrote: > MSI mapping needs to be update when MSI address changes, so add the > code to do so. > > Signed-off-by: Andrey Smirnov > Cc: Peter Maydell > Cc: Michael S. Tsirkin > Cc: qemu-devel@nongnu.org > Cc: qemu-...@nongnu.org Acked-by:

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-17 Thread Vadim Rozenfeld
On Mon, 2019-06-17 at 14:49 -0300, Eduardo Habkost wrote: > On Mon, Jun 17, 2019 at 05:32:13PM +, Roman Kagan wrote: > > On Mon, Jun 17, 2019 at 11:23:01AM -0300, Eduardo Habkost wrote: > > > On Mon, Jun 17, 2019 at 01:48:59PM +, Roman Kagan wrote: > > > > On Sat, Jun 15, 2019 at 05:05:05PM

Re: [Qemu-devel] [PATCH 0/5] Various i.MX7 fixes

2019-06-17 Thread Andrey Smirnov
On Mon, Apr 15, 2019 at 6:39 PM Andrey Smirnov wrote: > > Everyone: > > I recently revisited my i.MX7 work and this series contains all of the > fixes I had to make to get it to work with latest (5.1-rc1) Linux > kernel again as well as fixes for genuine bugs that I somehow missed > during origina

Re: [Qemu-devel] [PATCH] atomic failures on qemu-system-riscv64

2019-06-17 Thread Richard Henderson
On 6/16/19 12:19 PM, Joel Sing wrote: > +/* > + * Clear the load reservation, since an SC must fail if there is > + * an SC to any address, in between an LR and SC pair. > + */ > +tcg_gen_movi_tl(load_res, 0); > + > gen_set_label(l2); This clear needs to be moved down belo

Re: [Qemu-devel] [PATCH v3 01/50] trace: expand mem_info:size_shift to 3 bits

2019-06-17 Thread Richard Henderson
On 6/17/19 1:22 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 6/14/19 10:11 AM, Alex Bennée wrote: >>> From: "Emilio G. Cota" >>> >>> This will allow us to trace 16B-long memory accesses. >>> >>> Reviewed-by: Alex Bennée >>> Signed-off-by: Emilio G. Cota >>> --- >>> trace-even

Re: [Qemu-devel] [PATCH v3 49/50] include/exec/cpu-defs.h: fix typo

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > - * This structure must be placed in ArchCPU immedately > + * This structure must be placed in ArchCPU immediately Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 47/50] accel/stubs: reduce headers from tcg-stub

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > We don't need much for these. However I do wonder why these aren't > just null inlines in exec-all.h > > Signed-off-by: Alex Bennée > --- > accel/stubs/tcg-stub.c | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 44/50] plugin: add qemu_plugin_insn_disas helper

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > Give the plugins access to the QEMU dissasembler so they don't have to > re-invent the wheel. > > Signed-off-by: Alex Bennée > --- > disas.c | 103 +++ > include/disas/disas.h| 2 + > include

Re: [Qemu-devel] [PATCH v3 40/50] linux-user: support -plugin option

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: Lluís Vilanova > > Signed-off-by: Lluís Vilanova > [ cota: s/instrument/plugin ] > Signed-off-by: Emilio G. Cota > --- > linux-user/main.c | 18 ++ > 1 file changed, 18 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 39/50] vl: support -plugin option

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: Lluís Vilanova > > Signed-off-by: Lluís Vilanova > [ cota: s/instrument/plugin ] > Signed-off-by: Emilio G. Cota > --- > qemu-options.hx | 17 + > vl.c| 11 +++ > 2 files changed, 28 insertions(+) Reviewed-by:

Re: [Qemu-devel] [PULL 00/16] Monitor patches for 2019-06-17

2019-06-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190617184903.19436-1-arm...@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that ha

Re: [Qemu-devel] [PATCH v3 36/50] target/openrisc: fetch code with translator_ld

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > --- > target/openrisc/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 37/50] translator: inject instrumentation from plugins

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > @@ -95,6 +103,10 @@ void translator_loop(const TranslatorOps *ops, > DisasContextBase *db, > ops->translate_insn(db, cpu); > } > > +if (plugin_enabled) { > +plugin_gen_insn_end(); > +} > + > /* S

Re: [Qemu-devel] [PATCH v3 34/50] target/sparc: fetch code with translator_ld

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > --- > target/sparc/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 35/50] target/xtensa: fetch code with translator_ld

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > --- > target/xtensa/translate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 33/50] target/riscv: fetch code with translator_ld

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > +++ b/target/riscv/translate.c > @@ -793,7 +793,7 @@ static void riscv_tr_translate_insn(DisasContextBase > *dcbase, CPUState *cpu) > DisasContext *ctx = container_of(dcbase, DisasContext, base); > CPURISCVState *env = cpu->env_ptr; > > -ct

Re: [Qemu-devel] [PATCH v3 32/50] target/alpha: fetch code with translator_ld

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > --- > target/alpha/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 28/50] target/sh4: fetch code with translator_ld

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > There is a small wrinkle with the gUSA instruction. The translator > effectively treats a (known) gUSA sequence as a single instruction. > For the purposes of the plugin we end up with a long multi-instruction > qemu_plugin_insn

Re: [Qemu-devel] [PATCH v3 31/50] target/m68k: fetch code with translator_ld

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > --- > target/m68k/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 29/50] target/i386: fetch code with translator_ld

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 30/50] target/hppa: fetch code with translator_ld

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > --- > target/hppa/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 27/50] target/ppc: fetch code with translator_ld

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > -if (unlikely(need_byteswap(ctx))) { > -ctx->opcode = bswap32(cpu_ldl_code(env, ctx->base.pc_next)); > -} else { > -ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next); > -} > +ctx->opcode = translator_ldl_swap(env, ctx->base.

Re: [Qemu-devel] [PATCH v3 26/50] target/arm: call qemu_plugin_insn_append

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > I considered using translator_ld* from arm_ldl_code > et al. However, note that there's a helper that also calls > arm_ldl_code, so we'd have to change that caller. We should in fact change that caller. Unfortunately, the SVC

Re: [Qemu-devel] [PATCH v3 25/50] translator: add translator_ld{ub, sw, uw, l, q}

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > +#define GEN_TRANSLATOR_LD(fullname, name, type, swap_fn)\ > +static inline type \ > +fullname ## _swap(CPUArchState *env, abi_ptr pc, bool do_swap) \ > +{

Re: [Qemu-devel] [PATCH v3 24/50] plugin-gen: add plugin_insn_append

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > By adding it to plugin-gen's header file, we can export is as > an inline, since tcg.h is included in the header (we need tcg_ctx). > > Signed-off-by: Emilio G. Cota > > --- > v3 > - use g_byte_array > --- > accel/tcg/plug

Re: [Qemu-devel] [PATCH v3 23/50] cpu: hook plugin vcpu events

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > static void qemu_wait_io_event(CPUState *cpu) > { > +bool slept = false; > + > while (cpu_thread_is_idle(cpu)) { > +if (!slept) { > +slept = true; > +qemu_plugin_vcpu_idle_cb(cpu); > +} > qemu_cond

Re: [Qemu-devel] [PATCH v3 22/50] *-user: plugin syscalls

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > --- > bsd-user/syscall.c | 9 + > linux-user/syscall.c | 3 +++ > 2 files changed, 12 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 21/50] *-user: notify plugin of exit

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Reviewed-by: Alex Bennée > Signed-off-by: Emilio G. Cota > --- > bsd-user/syscall.c | 3 +++ > linux-user/exit.c | 1 + > 2 files changed, 4 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 20/50] translate-all: notify plugin code of tb_flush

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Plugins might allocate per-TB data that then they get passed each > time a TB is executed (via the *userdata pointer). > > Notify plugin code every time a code cache flush occurs, so > that plugins can then reclaim the memory o

Re: [Qemu-devel] [PATCH v3 19/50] tcg: let plugins instrument memory accesses

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > +static inline void set_hostaddr(CPUArchState *env, TCGMemOp mo, void *haddr) > +{ > +#ifdef CONFIG_PLUGIN > +if (mo & MO_HADDR) { > +env_tlb(env)->c.hostaddr = haddr; > +} > +#endif > +} > + Even if we weren't talking about recomputing thi

Re: [Qemu-devel] [PATCH v3 18/50] cpu_ldst_useronly_template: remove redundant #ifndef CODE_ACCESS

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > This function is already under #ifndef CODE_ACCESS. > > Signed-off-by: Emilio G. Cota > --- > include/exec/cpu_ldst_useronly_template.h | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 17/50] atomic_template: add inline trace/plugin helpers

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > +#ifndef ATOMIC_TEMPLATE_COMMON > +#define ATOMIC_TEMPLATE_COMMON > +static inline > +void atomic_trace_rmw_pre(CPUArchState *env, target_ulong addr, uint8_t info) > +{ > +CPUState *cpu = env_cpu(env); > + > +trace_guest_mem_before_exec(cpu, addr, i

Re: [Qemu-devel] [PATCH v3 15/50] tcg: add MO_HADDR to TCGMemOp

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > +/* > + * SoftMMU-only: if set, the TCG backend puts the corresponding host > address > + * in CPUArchState.hostaddr. > + */ > +MO_HSHIFT = MO_ASHIFT + 3, > +MO_HADDR = 1 << MO_HSHIFT, FYI, Alex and I talked about recomputing the h

Re: [Qemu-devel] [PATCH v3 16/50] atomic_template: fix indentation in GEN_ATOMIC_HELPER

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Reviewed-by: Alex Bennée > Signed-off-by: Emilio G. Cota > --- > accel/tcg/atomic_template.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 14/50] tcg: add tcg_gen_st_ptr

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Will gain a user soon. > > Signed-off-by: Emilio G. Cota > --- > tcg/tcg-op.h | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PULL 00/16] Monitor patches for 2019-06-17

2019-06-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190617184903.19436-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/16] Monitor patches for 2019-06-17 Type: series Message-id: 20190617184903.19436-1-arm

Re: [Qemu-devel] [PATCH 6/6] target/arm: Execute Thumb instructions when their condbits are 0xf

2019-06-17 Thread Richard Henderson
On 6/17/19 10:53 AM, Peter Maydell wrote: > Thumb instructions in an IT block are set up to be conditionally > executed depending on a set of condition bits encoded into the IT > bits of the CPSR/XPSR. The architecture specifies that if the > condition bits are 0b this means "always execute" (

Re: [Qemu-devel] [PATCH 5/6] hw/timer/armv7m_systick: Forbid non-privileged accesses

2019-06-17 Thread Richard Henderson
On 6/17/19 10:53 AM, Peter Maydell wrote: > Like most of the v7M memory mapped system registers, the systick > registers are accessible to privileged code only and user accesses > must generate a BusFault. We implement that for registers in > the NVIC proper already, but missed it for systick since

Re: [Qemu-devel] [PATCH 4/6] target/arm: Use _ra versions of cpu_stl_data() in v7M helpers

2019-06-17 Thread Richard Henderson
On 6/17/19 10:53 AM, Peter Maydell wrote: > In the various helper functions for v7M/v8M instructions, use > the _ra versions of cpu_stl_data() and friends. Otherwise we > may get wrong behaviour or an assert() due to not being able > to locate the TB if there is an exception on the memory access >

Re: [Qemu-devel] [PATCH 3/6] target/arm: v8M: Check state of exception being returned from

2019-06-17 Thread Richard Henderson
On 6/17/19 10:53 AM, Peter Maydell wrote: > In v8M, an attempt to return from an exception which is not > active is an illegal exception return. For this purpose, > exceptions which can configurably target either Secure or > NonSecure are not considered to be active if they are > configured for the

Re: [Qemu-devel] [RFC PATCH v2 24/35] multi-process: add qdev_proxy_add to create proxy devices

2019-06-17 Thread Elena Ufimtseva
On Mon, Jun 17, 2019 at 02:22:08PM -0500, Eric Blake wrote: > On 6/17/19 1:16 PM, elena.ufimts...@oracle.com wrote: > > From: Elena Ufimtseva > > > > This is handled while parsing the command line options. > > The parsed options are being sent to remote process > > as the messgaes containing JSON

Re: [Qemu-devel] [RFC PATCH v2 01/35] multi-process: memory: alloc RAM from file at offset

2019-06-17 Thread Elena Ufimtseva
On Mon, Jun 17, 2019 at 02:14:49PM -0500, Eric Blake wrote: > On 6/17/19 1:14 PM, elena.ufimts...@oracle.com wrote: > > From: Jagannathan Raman > > > > Allow RAM MemoryRegion to be created from an offset in a file, instead > > of allocating at offset of 0 by default. This is needed to synchronize

Re: [Qemu-devel] [PATCH 2/6] arm v8M: Forcibly clear negative-priority exceptions on deactivate

2019-06-17 Thread Richard Henderson
On 6/17/19 10:53 AM, Peter Maydell wrote: > To prevent execution priority remaining negative if the guest > returns from an NMI or HardFault with a corrupted IPSR, the > v8M interrupt deactivation process forces the HardFault and NMI > to inactive based on the current raw execution priority, > even

Re: [Qemu-devel] [PATCH 1/6] target/arm: NS BusFault on vector table fetch escalates to NS HardFault

2019-06-17 Thread Richard Henderson
On 6/17/19 10:53 AM, Peter Maydell wrote: > + * The HardFault is Secure if BFHFNMINS is 0 (meaning that all HFs are > + * secure); otherwise it targets the same security state as the > + * underlying exception. > */ > -exc_secure = targets_secure || > -!(cpu->env.v7m.a

Re: [Qemu-devel] [RFC PATCH v2 01/35] multi-process: memory: alloc RAM from file at offset

2019-06-17 Thread Eric Blake
On 6/17/19 1:14 PM, elena.ufimts...@oracle.com wrote: > From: Jagannathan Raman > > Allow RAM MemoryRegion to be created from an offset in a file, instead > of allocating at offset of 0 by default. This is needed to synchronize > RAM between QEMU & remote process. > This will be needed for the fo

Re: [Qemu-devel] [PATCH 0/3] tricore: Convert to translate_loop

2019-06-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190617143533.15013-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190617143533.15013-1-kbast...@mail.uni-paderborn.de Type: series Subject: [Qemu-devel] [P

Re: [Qemu-devel] [PATCH] target/arm: Check for dp support for dp VFM, not sp

2019-06-17 Thread Richard Henderson
On 6/17/19 9:01 AM, Peter Maydell wrote: > In commit 1120827fa182f0e7622 we accidentally put the > "UNDEF unless FPU has double-precision support" check in > the single-precision VFM function. Put it in the dp > function where it belongs. > > Signed-off-by: Peter Maydell > --- > I just merged the

Re: [Qemu-devel] [RFC PATCH v2 24/35] multi-process: add qdev_proxy_add to create proxy devices

2019-06-17 Thread Eric Blake
On 6/17/19 1:16 PM, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > This is handled while parsing the command line options. > The parsed options are being sent to remote process > as the messgaes containing JSON strings. s/messgaes/messages/ > > Changes in v2: > - parse socket a

[Qemu-devel] [PULL 16/16] vl: Deprecate -mon pretty=... for HMP monitors

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf The -mon pretty=on|off switch of the -mon option applies only to QMP monitors. It's silently ignored for HMP. Deprecate this combination so that we can make it an error in future versions. Signed-off-by: Kevin Wolf Message-Id: <20190613153405.24769-16-kw...@redhat.com> Reviewed

[Qemu-devel] [PULL 15/16] monitor: Replace monitor_init() with monitor_init_{hmp, qmp}()

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf Most callers know which monitor type they want to have. Instead of calling monitor_init() with flags that can describe both types of monitors, make monitor_init_{hmp,qmp}() public interfaces that take specific bools instead of flags and call these functions directly. Signed-off-

Re: [Qemu-devel] [RFC PATCH v2 20/35] multi-process: Add QMP & extend HMP commands to list remote info

2019-06-17 Thread Eric Blake
On 6/17/19 1:16 PM, elena.ufimts...@oracle.com wrote: > From: Jagannathan Raman > > Add query-remote QMP command and extend "info" HMP command, to list > the remote objects used by QEMU. > > Signed-off-by: Jagannathan Raman > Signed-off-by: John G Johnson > Signed-off-by: Elena Ufimtseva > --

[Qemu-devel] [PULL 11/16] monitor: Split out monitor/qmp.c

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf Move QMP infrastructure from monitor/misc.c to monitor/qmp.c. This is code that can be shared for all targets, so compile it only once. The amount of function and particularly extern variables in monitor_int.h is probably a bit larger than it needs to be, but this way no non-tri

[Qemu-devel] [PULL 06/16] monitor: Remove Monitor.cmd_table indirection

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf Monitor.cmd_table is initialised to point to mon_cmds and never changed afterwards. We can remove the indirection and just reference mon_cmds directly instead. Signed-off-by: Kevin Wolf Message-Id: <20190613153405.24769-6-kw...@redhat.com> Reviewed-by: Markus Armbruster Signed

[Qemu-devel] [PULL 14/16] monitor: Split Monitor.flags into separate bools

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf Monitor.flags contains three different flags: One to distinguish HMP from QMP; one specific to HMP (MONITOR_USE_READLINE) that is ignored with QMP; and another one specific to QMP (MONITOR_USE_PRETTY) that is ignored with HMP. Split the flags field into three bools and move them

[Qemu-devel] [PULL 05/16] monitor: Create MonitorHMP with readline state

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf The ReadLineState in Monitor is only used for HMP monitors. Create MonitorHMP and move it there. Can't use container_of() in hmp_change(). Cast instead, and mark FIXME. Will be cleaned up shortly. Signed-off-by: Kevin Wolf Reviewed-by: Dr. David Alan Gilbert Message-Id: <20

[Qemu-devel] [PULL 07/16] monitor: Rename HMP command type and tables

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf This renames the type for HMP monitor commands and the tables holding the commands to make clear that they are related to HMP and to allow making them public later: * mon_cmd_t -> HMPCommand (fixing use of a reserved name, too) * mon_cmds -> hmp_cmds * info_cmds -> hmp_info_cmds

[Qemu-devel] [PULL 08/16] Move monitor.c to monitor/misc.c

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf Create a new monitor/ subdirectory and move monitor.c there. As the plan is to move the monitor core into separate files, use the chance to rename it to misc.c. Signed-off-by: Kevin Wolf Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Markus Armbruster Message-Id: <201906131

Re: [Qemu-devel] [PULL 00/16] Monitor patches for 2019-06-17

2019-06-17 Thread Peter Maydell
On Mon, 17 Jun 2019 at 19:51, Markus Armbruster wrote: > > The following changes since commit 076243ffe6c1b687e9e6d98348c3bf3398df78f3: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-docs-20190617' > into staging (2019-06-17 16:41:25 +0100) > > are

[Qemu-devel] [PULL 09/16] monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf Now that we have a monitor/ subdirectory, let's move hmp.c and qmp.c from the root directory there. As they contain implementations of monitor commands, rename them to {hmp,qmp}-cmds.c, so that {hmp,qmp}.c are free for the HMP and QMP infrastructure. Signed-off-by: Kevin Wolf R

[Qemu-devel] [PULL 01/16] monitor: Fix return type of monitor_fdset_dup_fd_find

2019-06-17 Thread Markus Armbruster
From: Yury Kotov monitor_fdset_dup_fd_find_remove() and monitor_fdset_dup_fd_find() return mon_fdset->id which is int64_t. Downcasting from int64_t to int leads to a bug with removing fd from fdset with id >= 2^32. So, fix return types for these function. Signed-off-by: Yury Kotov Reviewed-by:

[Qemu-devel] [PULL 10/16] monitor: Create monitor-internal.h with common definitions

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf Before we can split monitor/misc.c, we need to create a header file that contains the common definitions that will be used by multiple source files. For a start, add the type definitions for Monitor, MonitorHMP and MonitorQMP and their dependencies. We'll add functions as needed

[Qemu-devel] [PULL 04/16] monitor: Make MonitorQMP a child class of Monitor

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf Currently, struct Monitor mixes state that is only relevant for HMP, state that is only relevant for QMP, and some actually shared state. In particular, a MonitorQMP field is present in the state of any monitor, even if it's not a QMP monitor and therefore doesn't use the state.

[Qemu-devel] [RFC PATCH v2 30/35] multi-process: handle heartbit messages in remote process

2019-06-17 Thread elena . ufimtseva
From: Elena Ufimtseva and reply back to proxy object. Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva --- remote/remote-main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/remote/remote-main.c b/remote/remote-main.c index c1362be93e.

Re: [Qemu-devel] [PATCH v4] virtio-scsi: restart DMA after iothread

2019-06-17 Thread Paolo Bonzini
On 17/06/19 19:58, Kevin Wolf wrote: > Of course, this makes me think that maybe for the actual proper > solution, VM state change handlers should really be a feature that qdev > provides for devices. Then if a HBA doesn't have anything else to do, > the qdev core would just recurse into the childr

[Qemu-devel] [PULL 12/16] monitor: Split out monitor/hmp.c

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf Move HMP infrastructure from monitor/misc.c to monitor/hmp.c. This is code that can be shared for all targets, so compile it only once. The amount of function and particularly extern variables in monitor_int.h is probably a bit larger than it needs to be, but this way no non-tri

[Qemu-devel] [PULL 03/16] monitor: Split monitor_init in HMP and QMP function

2019-06-17 Thread Markus Armbruster
From: Kevin Wolf Instead of mixing HMP and QMP monitors in the same function, separate the monitor creation function for both. While in theory, one could pass both MONITOR_USE_CONTROL and MONITOR_USE_READLINE before this patch and both flags would do something, readline support is tightly couple

[Qemu-devel] [RFC PATCH v2 09/35] multi-process: setup PCI host bridge for remote device

2019-06-17 Thread elena . ufimtseva
From: Jagannathan Raman PCI host bridge is setup for the remote device process. It is implemented using remote-pcihost object. It is an extension of the PCI host bridge setup by QEMU. Remote-pcihost configures a PCI bus which could be used by the remote PCI device to latch on to. Signed-off-by:

  1   2   3   4   >