Anyone have any comments about this series?
Thanks
Zhang Chen
> -Original Message-
> From: Qemu-devel [mailto:qemu-devel-
> bounces+chen.zhang=intel@nongnu.org] On Behalf Of Zhang, Chen
> Sent: Monday, June 10, 2019 1:56 PM
> To: Jason Wang ; Li Zhijian ;
> Dr.
Please redirect to the V2 RESEND patch, this one not rebased on upstream code.
Thanks
Zhang Chen
> -Original Message-
> From: Zhang, Chen
> Sent: Friday, June 21, 2019 1:52 PM
> To: Xie Changlong ; Kevin Wolf
> ; Max Reitz ; qemu-block bl...@nongnu.org>; qemu-dev
From: Zhang Chen
If we try to close replication after failover, it will crash here.
So we need check the block job on active disk before cancel the job.
Signed-off-by: Zhang Chen
---
block/replication.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/replication.c
> -Original Message-
> From: Kevin Wolf [mailto:kw...@redhat.com]
> Sent: Friday, June 14, 2019 6:18 PM
> To: Zhang, Chen
> Cc: Xie Changlong ; Max Reitz
> ; qemu-block ; qemu-dev
> ; Zhang Chen ;
> vsement...@virtuozzo.com
> Subject: Re: [PATCH] block/rep
From: Zhang Chen
No block job on active disk after failover.
In the replication_stop() function have canceled the block job,
we check it again here.
Signed-off-by: Zhang Chen
---
block/replication.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/replication.c b
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Monday, June 10, 2019 12:09 PM
> To: Zhang, Chen ; Li Zhijian ;
> Dr. David Alan Gilbert ; Juan Quintela
> ; zhanghailiang ;
> qemu-dev ; Stefano Stabellini
> ; Paul Durrant
> Cc
From: Zhang Chen
We need to notify net filter to do checkpoint for Xen COLO, like KVM side.
Signed-off-by: Zhang Chen
---
migration/colo.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/colo.c b/migration/colo.c
index 8c1644091f..9f84b1fa3c 100644
--- a/migration/colo.c
+++ b
From: Zhang Chen
Add chardev handler to send notification to remote(current from Xen) colo-frame.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index
From: Zhang Chen
This patch make colo-compare can send message to remote COLO frame(Xen) when
occur checkpoint.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 54 +-
1 file changed, 44 insertions(+), 10 deletions(-)
diff --git a/net/colo
From: Zhang Chen
Xen COLO based on KVM COLO architecture, it shared COLO proxy and block
replication with KVM COLO. The only differece is Xen COLO have own
COLO-frame to handle live migration related function, so we need this
series make Xen COLO frame can communicate with other COLO modules
From: Zhang Chen
We need use this function to send notification message for remote
colo-frame(Xen).
So we add new parameter for this job.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 41 +
1 file changed, 33 insertions(+), 8 deletions(-)
diff
From: Zhang Chen
We add the "notify_dev=chardevID" parameter. After that colo-compare can
connect with
remote(currently just for Xen, KVM-COLO didn't need it.) colo-frame through
chardev socket,
it can notify remote(Xen) colo-frame to handle checkpoint event.
Signed-off-by:
From: Li Zhijian [mailto:lizhij...@cn.fujitsu.com]
Sent: Monday, June 3, 2019 10:33 AM
To: Zhang, Chen ; Dr. David Alan Gilbert
; Juan Quintela ; zhanghailiang
; Jason Wang ; qemu-dev
Cc: Zhang Chen
Subject: Re: [PATCH 4/6] COLO-compare: Add colo-compare remote notify support
how about do
From: Zhang Chen
We add the "notify_dev=chardevID" parameter. After that colo-compare can
connect with
remote(currently just for Xen, KVM-COLO didn't need it.) colo-frame through
chardev socket,
it can notify remote(Xen) colo-frame to handle checkpoint event.
Signed-off-by:
From: Zhang Chen
We need use this function to send notification message for remote
colo-frame(Xen).
So we add new parameter for this job.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 41 +
1 file changed, 33 insertions(+), 8 deletions(-)
diff
From: Zhang Chen
This patch make colo-compare can send message to remote COLO frame(Xen) when
occur checkpoint.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 51 +-
1 file changed, 46 insertions(+), 5 deletions(-)
diff --git a/net/colo
From: Zhang Chen
We have add the notify_remote_frame function for Xen,
so we rename the colo_compare_inconsistency_notify to
notify_native_frame(KVM-qemu COLO frame) looks better.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 8
1 file changed, 4 insertions(+), 4 deletions
From: Zhang Chen
Xen COLO based on KVM COLO architecture, it shared COLO proxy and block
replication with KVM COLO. The only differece is Xen COLO have own
COLO-frame to handle live migration related function, so we need this
series make Xen COLO frame can communicate with other COLO modules
From: Zhang Chen
Add chardev handler to send notification to remote(current from Xen) colo-frame.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index
From: Zhang Chen
We need to notify net filter to do checkpoint for Xen COLO, like KVM side.
Signed-off-by: Zhang Chen
---
migration/colo.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/colo.c b/migration/colo.c
index 8c1644091f..9f84b1fa3c 100644
--- a/migration/colo.c
+++ b
Hi Dave,
I noticed that you have reviewed all the patches in this series, can you queue
it?
Thanks
Zhang Chen
> -Original Message-
> From: Zhang, Chen
> Sent: Friday, April 26, 2019 5:07 PM
> To: Laurent Vivier ; Dr. David Alan Gilbert
> ; Juan Quintela ; zhanghail
From: Zhang Chen
No one to maintain qemu-options related file, add it to Markus's
Command line option argument parsing field.
Signed-off-by: Zhang Chen
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 23db6f8408..acc3b32f88 100644
This patch have been integrated in this series:
http://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg04520.html
Please review it at this link.
Thanks
Zhang Chen
> -Original Message-
> From: Zhang, Chen
> Sent: Friday, April 26, 2019 11:40 AM
> To: Laurent Vivier ; Dr
This patch have been integrated in this series:
http://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg04520.html
Please review it at this link.
Thanks
Zhang Chen
> -Original Message-
> From: Zhang, Chen
> Sent: Friday, April 26, 2019 11:40 AM
> To: Laurent Vivier ; Dr
From: Zhang Chen
Signed-off-by: Zhang Chen
---
include/migration/colo.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/migration/colo.h b/include/migration/colo.h
index ddebe0ad27..f6fbe23ec9 100644
--- a/include/migration/colo.h
+++ b/include/migration/colo.h
@@ -22,8 +22,6
From: Zhang Chen
We missed the iothread related args in this file.
This patch is used to fix this issue.
Signed-off-by: Zhang Chen
---
qemu-options.hx | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 08749a3391..a4500c99ef
From: Zhang Chen
In this series we optimize codes and fix some tiny issues.
Zhang Chen (3):
migration/colo.c: Remove redundant input parameter
migration/colo.h: Remove obsolete codes
qemu-option.hx: Update missed parameter for colo-compare
include/migration/colo.h | 4 +---
migration
From: Zhang Chen
The colo_do_failover no need the input parameter.
Signed-off-by: Zhang Chen
---
include/migration/colo.h | 2 +-
migration/colo-failover.c | 2 +-
migration/colo.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/migration/colo.h b
From: Zhang Chen
Signed-off-by: Zhang Chen
---
include/migration/colo.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/migration/colo.h b/include/migration/colo.h
index ddebe0ad27..f6fbe23ec9 100644
--- a/include/migration/colo.h
+++ b/include/migration/colo.h
@@ -22,8 +22,6
From: Zhang Chen
The colo_do_failover no need the input parameter.
Signed-off-by: Zhang Chen
---
include/migration/colo.h | 2 +-
migration/colo-failover.c | 2 +-
migration/colo.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/migration/colo.h b
> -Original Message-
> From: Lukas Straub [mailto:lukasstra...@web.de]
> Sent: Sunday, April 21, 2019 1:14 AM
> To: qemu-devel@nongnu.org
> Cc: Zhang, Chen
> Subject: [PATCH v2] net/colo-compare.c: Fix a crash in COLO Primary.
>
> From: Lukas Straub Because eve
> -Original Message-
> From: Lukas Straub [mailto:lukasstra...@web.de]
> Sent: Friday, April 19, 2019 9:56 PM
> To: qemu-devel@nongnu.org
> Cc: Zhang, Chen
> Subject: [PATCH] net/colo-compare.c: Fix a crash in COLO Primary.
>
> From: Lukas Straub Fixes th
Ping~ Anyone have comments about this patch?
Thanks
Zhang Chen
> -Original Message-
> From: Wang, Wei W
> Sent: Monday, April 1, 2019 5:12 PM
> To: Zhang, Chen ; Zhang Chen
> ; Dr. David Alan Gilbert ; Juan
> Quintela ; qemu-dev
> Subject: Re: [PATCH] migra
> -Original Message-
> From: Peter Maydell [mailto:peter.mayd...@linaro.org]
> Sent: Thursday, April 4, 2019 9:43 AM
> To: Zhang, Chen
> Cc: Dr. David Alan Gilbert ; qemu-dev de...@nongnu.org>; John Snow ; Fam Zheng
>
> Subject: Re: [Qemu-devel] [PATCH] bitops
> -Original Message-
> From: John Snow [mailto:js...@redhat.com]
> Sent: Wednesday, April 3, 2019 5:07 AM
> To: Zhang, Chen ; Laurent Vivier ;
> qemu-dev ; Fam Zheng
> Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap
> file to related field
&g
From: Zhang Chen
Address Markus's comments change the 'last_mode' to 'last-mode'.
Signed-off-by: Zhang Chen
---
qapi/migration.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index cfde29acf8..9217886c80 100644
--- a/qapi
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Tuesday, April 2, 2019 4:37 PM
> To: Zhang, Chen
> Cc: Markus Armbruster ; zhanghailiang
> ; Juan Quintela ;
> qemu-dev ; Dr. David Alan Gilbert
> ; Zhang Chen
> Subject: Re
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Tuesday, April 2, 2019 2:20 PM
> To: Zhang, Chen
> Cc: Zhang Chen ; Dr. David Alan Gilbert
> ; Juan Quintela ; zhanghailiang
> ; Eric Blake ; qemu-
> dev ; Zhang, Chen
> Subje
From: Zhang Chen
I found upstream codes conflict with COLO and lead to crash,
and I located to this patch:
commit 386a907b37a9321bc5d699bc37104d6ffba1b34d
Author: Wei Wang
Date: Tue Dec 11 16:24:49 2018 +0800
migration: use bitmap_mutex in migration_bitmap_clear_dirty
My colleague Wei's
From: Zhang Chen
Add bitmap.h and bitops.h to Dirty Bitmaps field.
Signed-off-by: Zhang Chen
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 56139ac8ab..360af3e8ca 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1773,6 +1773,8 @@ S
About this patch, do we need merge similar function as one with return value?
For example: test_and_set_bit()/set_bit(), test_and_clear_bit()/clear_bit().
Thanks
Zhang Chen
> -Original Message-
> From: Zhang, Chen
> Sent: Saturday, March 30, 2019 4:05 AM
> To: Dr. David
From: Zhang Chen
In current codes we use change_bit() to finish the job.
Signed-off-by: Zhang Chen
---
include/qemu/bitmap.h | 1 -
include/qemu/bitops.h | 15 ---
2 files changed, 16 deletions(-)
diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h
index 5c313346b9
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Friday, March 29, 2019 3:02 PM
> To: Zhang, Chen ; Li Zhijian ;
> Zhang Chen ; Dr. David Alan Gilbert
> ; Juan Quintela ; zhanghailiang
> ; Peter Maydell
> ; qemu-dev
> Subject: Re:
Ping... May need to wait until the 4.1 version?
Thanks
Zhang Chen
> -Original Message-
> From: Zhang, Chen
> Sent: Friday, March 15, 2019 2:13 PM
> To: Li Zhijian ; Zhang Chen ;
> Dr. David Alan Gilbert ; Juan Quintela
> ; zhanghailiang ;
> Jason Wang ; Peter Mayde
From: Zhang Chen
The documentation with the wrong initial version number of last_mode field,
This patch just fix this issue.
Signed-off-by: Zhang Chen
---
qapi/migration.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Tuesday, March 26, 2019 10:41 PM
> To: Juan Quintela ; qemu-devel@nongnu.org
> Cc: Dr. David Alan Gilbert ; zhanghailiang
> ; Markus Armbruster
> ; Zhang, Chen
> Subject: Re: [PULL 14/15
From: Zhang Chen
When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED.
The origin codes misunderstand the FAILOVER_STATUS_REQUIRE.
Signed-off-by: Zhang Chen
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions
From: Zhang Chen
Add the last_colo_mode to save the status after failover.
This patch can solve the issue that user want to get last colo mode
use query_colo_status after failover.
Signed-off-by: Zhang Chen
---
migration/colo.c| 16
qapi/migration.json | 7 ++-
2
From: Zhang Chen
In this patch we add the processing state for COLOExitReason,
because we have to identify COLO in the failover processing state or
failover error state. In the way, we can handle all the failover state.
We have improved the description of the COLOExitReason by the way.
Signed
From: Zhang Chen
Signed-off-by: Zhang Chen
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index dbe2b88807..d1ae2e6d11 100644
--- a/migration/colo.c
+++ b/migration
From: Zhang Chen
This series focus on COLO failover bug fix and optimization.
V5:
- Rewrite patch 4/4 to add new feild in query_colo_status.
V4:
- Remove merged patch.
- Fix grammer issues in patch 2/4 to address markus's comments.
- Rebased on upstream code.
V3:
- Fix grammer issues
-Original Message-
From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
Sent: Tuesday, March 19, 2019 10:57 PM
To: Zhang, Chen
Cc: Li Zhijian ; Zhang Chen ;
Juan Quintela ; zhanghailiang
; Markus Armbruster ; Eric
Blake ; qemu-dev
Subject: Re: [PATCH V3 7/7] Migration/colo.c
From: Zhang Chen
This series focus on COLO failover bug fix and optimization.
V4:
- Remove merged patch.
- Fix grammer issues in patch 2/4 to address markus's comments.
- Rebased on upstream code.
V3:
- Fix grammer issues in patch 4/7.
- Add more information in commit log of patch 5/7
From: Zhang Chen
Signed-off-by: Zhang Chen
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index dbe2b88807..d1ae2e6d11 100644
--- a/migration/colo.c
+++ b/migration
From: Zhang Chen
Add the last_colo_mode to save the status after failover.
This patch can solve the issue that user got nothing to call
query_colo_status after failover.
Signed-off-by: Zhang Chen
---
migration/colo.c | 28 +++-
1 file changed, 23 insertions(+), 5
From: Zhang Chen
When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED.
The origin codes misunderstand the FAILOVER_STATUS_REQUIRE.
Signed-off-by: Zhang Chen
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions
From: Zhang Chen
In this patch we add the processing state for COLOExitReason,
because we have to identify COLO in the failover processing state or
failover error state. In the way, we can handle all the failover state.
We have improved the description of the COLOExitReason by the way.
Signed
From: Zhang Chen
Signed-off-by: Zhang Chen
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0e7baa9aa2..f127b1356c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2167,7 +2167,7 @@ F: include/migration/failover.h
F: docs/COLO
-Original Message-
From: Markus Armbruster [mailto:arm...@redhat.com]
Sent: Sunday, March 10, 2019 1:06 AM
To: Zhang, Chen
Cc: Li Zhijian ; Zhang Chen ;
Dr. David Alan Gilbert ; Juan Quintela
; zhanghailiang ; Eric
Blake ; qemu-dev ; Zhang, Chen
Subject: Re: [Qemu-devel] [PATCH V3
-Original Message-
From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
Sent: Saturday, March 9, 2019 1:46 AM
To: Zhang, Chen
Cc: Li Zhijian ; Zhang Chen ;
Juan Quintela ; zhanghailiang
; Markus Armbruster ; Eric
Blake ; qemu-dev
Subject: Re: [PATCH V3 7/7] Migration/colo.c
-Original Message-
From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
Sent: Saturday, March 9, 2019 1:41 AM
To: Zhang, Chen
Cc: Li Zhijian ; Zhang Chen ;
Juan Quintela ; zhanghailiang
; Markus Armbruster ; Eric
Blake ; qemu-dev
Subject: Re: [PATCH V3 6/7] Migration/colo.c
-Original Message-
From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
Sent: Tuesday, March 5, 2019 11:23 PM
To: Zhang, Chen
Cc: Li Zhijian ; Zhang Chen ;
Juan Quintela ; zhanghailiang
; Markus Armbruster ; Eric
Blake ; qemu-dev
Subject: Re: [PATCH V3 0/7] Migration/colo: Fix
From: Zhang Chen
This series focus on COLO failover bug fix and optimization.
V3:
- Fix grammer issues in patch 4/7.
- Add more information in commit log of patch 5/7.
V2:
- Add patch 4/7 to handle failover state.
- Add new patches to optimize failover status.
V1:
- Init patch.
Zhang
From: Zhang Chen
In migration_incoming_state_destroy(void) will check the mis->to_src_file
to double close the mis->to_src_file when occur COLO failover.
Signed-off-by: Zhang Chen
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 1 +
1 file changed, 1 insertion(+)
diff
From: Zhang Chen
When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED.
The origin codes misunderstand the FAILOVER_STATUS_REQUIRE.
Signed-off-by: Zhang Chen
---
migration/colo.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/migration/colo.c b
From: Zhang Chen
Add the last_colo_mode to save the status after failover.
This patch can solve the issue that user got nothing to call
query_colo_status after failover.
Signed-off-by: Zhang Chen
---
migration/colo.c | 28 +++-
1 file changed, 23 insertions(+), 5
From: Zhang Chen
Delay to close COLO for auto start VM after failover.
Signed-off-by: Zhang Chen
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 1 -
migration/migration.c | 3 +++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/migration/colo.c b/migration
From: Zhang Chen
In this patch we add the processing state for COLOExitReason,
because we have to identify COLO in the failover processing state or
failover error state. In the way, we can handle all the failover state.
We have improved the description of the COLOExitReason by the way.
Signed
From: Zhang Chen
Signed-off-by: Zhang Chen
---
migration/colo.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index dbe2b88807..d1ae2e6d11 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -197,10 +197,16 @@ void
From: Zhang Chen
Remove the "active" variable in example for query-colo-status.
It is a doc bug from commit f56c0065
Signed-off-by: Zhang Chen
Reviewed-by: Eric Blake
---
qapi/migration.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/migration.j
-Original Message-
From: Eric Blake [mailto:ebl...@redhat.com]
Sent: Friday, March 1, 2019 1:07 AM
To: Zhang, Chen ; Li Zhijian ;
Zhang Chen ; Dr. David Alan Gilbert ;
Juan Quintela ; zhanghailiang
; Markus Armbruster ;
qemu-dev
Subject: Re: [PATCH V2 5/7] qapi/migration.json
-Original Message-
From: Eric Blake [mailto:ebl...@redhat.com]
Sent: Friday, March 1, 2019 1:05 AM
To: Zhang, Chen ; Li Zhijian ;
Zhang Chen ; Dr. David Alan Gilbert ;
Juan Quintela ; zhanghailiang
; Markus Armbruster ;
qemu-dev
Subject: Re: [PATCH V2 4/7] Migration/colo.c: Add new
From: Zhang Chen
Add the last_colo_mode to save the status after failover.
This patch can solve the issue that user got nothing to call
query_colo_status after failover.
Signed-off-by: Zhang Chen
---
migration/colo.c | 28 +++-
1 file changed, 23 insertions(+), 5
From: Zhang Chen
Delay to close COLO for auto start VM after failover.
Signed-off-by: Zhang Chen
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 1 -
migration/migration.c | 3 +++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/migration/colo.c b/migration
From: Zhang Chen
When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED.
The origin codes misunderstand the FAILOVER_STATUS_REQUIRE.
Signed-off-by: Zhang Chen
---
migration/colo.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/migration/colo.c b
From: Zhang Chen
In this patch we add the processing state for COLOExitReason,
because we have to identify COLO in the failover processing state or
failover error state. In the way, we can handle all the failover state.
We have improved the description of the COLOExitReason by the way.
Signed
From: Zhang Chen
Remove the "active" variable in example for query-colo-status.
Signed-off-by: Zhang Chen
---
qapi/migration.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 48e21880a3..f4c1762dfc 100644
From: Zhang Chen
In migration_incoming_state_destroy(void) will check the mis->to_src_file
to double close the mis->to_src_file when occur COLO failover.
Signed-off-by: Zhang Chen
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 1 +
1 file changed, 1 insertion(+)
diff
From: Zhang Chen
Signed-off-by: Zhang Chen
---
migration/colo.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index dbe2b88807..d1ae2e6d11 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -197,10 +197,16 @@ void
From: Zhang Chen
This series focus on COLO failover bug fix and optimization.
V2:
- Add patch 4/7 to handle failover state.
- Add new patches to optimize failover status.
V1:
- Init patch.
Zhang Chen (7):
Migration/colo.c: Fix double close bug when occur COLO failover
Migration/colo.c
-Original Message-
From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
Sent: Thursday, February 28, 2019 9:03 PM
To: Zhang, Chen
Cc: Li Zhijian ; Zhang Chen ;
Juan Quintela ; zhanghailiang
; qemu-dev
Subject: Re: [PATCH 2/3] Migration/colo.c: Fix COLO failover status error
-Original Message-
From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
Sent: Tuesday, February 26, 2019 6:55 PM
To: Zhang, Chen
Cc: Li Zhijian ; Zhang Chen ;
Juan Quintela ; zhanghailiang
; qemu-dev
Subject: Re: [PATCH 2/3] Migration/colo.c: Fix COLO failover status error
From: Zhang Chen
Fix three bugs after COLO failover.
Zhang Chen (3):
Migration/colo.c: Fix double close bug when occur COLO failover
Migration/colo.c: Fix COLO failover status error
Migration/colo.c: Make COLO node running after failover
migration/colo.c | 9 +
migration
From: Zhang Chen
In migration_incoming_state_destroy(void) will check the mis->to_src_file
to double close the mis->to_src_file when occur COLO failover.
Signed-off-by: Zhang Chen
---
migration/colo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/colo.c b/migration/
From: Zhang Chen
When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED.
The origin codes misunderstand the FAILOVER_STATUS_REQUIRE.
Signed-off-by: Zhang Chen
---
migration/colo.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/migration/colo.c b
From: Zhang Chen
Delay to close COLO for auto start VM after failover.
Signed-off-by: Zhang Chen
---
migration/colo.c | 1 -
migration/migration.c | 3 +++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/migration/colo.c b/migration/colo.c
index a13acac192..89325952c7
.
>
> Cc: Peter Maydell
> Cc: Li Zhijian
> Cc: Peter Xu
> Cc: Dr. David Alan Gilbert
> Cc: Zhang Chen
> Cc: Markus Armbruster
> Cc: Daniel P. Berrange
> Signed-off-by: Jason Wang
>
Looks good for me.
Reviewed-by: Zhang Chen
By the way: Do we nee
; > occasionally with TCG due to some bug I'm sure we've investigated
> > in the past) ?
>
> I don't think it relies on the CPU at all.
>
> Dave
>
>
I have no idea about this currently, but Jason and I designed the test
case.
Add Jason: Have any comments about this ?
Thanks
Z
Have fixed in this patch.
https://lists.nongnu.org/archive/html/qemu-devel/2019-01/msg02859.html
Thanks
Zhang Chen
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1811499
Title:
qemu/net/colo
From: Zhang Chen
Fix duplicated code:
https://bugs.launchpad.net/qemu/+bug/1811499
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 8
1 file changed, 8 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 9156ab3349..fa3fd0632d 100644
--- a/net/colo-compare.c
Signed-off-by: Mao Zhongyi
> > Signed-off-by: Li Zhijian
> > Signed-off-by: Zhang Chen
> > Reviewed-by: Zhang Chen
> > Tested-by: Zhang Chen
> > ---
> > net/colo-compare.c | 343
> +++--
> > net/colo.c
On Thu, Dec 6, 2018 at 4:38 AM Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> COLO uses a worker context (iothread) to drive the chardev. All
> backends are not able to switch the context, let's report an error in
> this case.
>
> Signed-off-by: Marc-André Lureau
On Thu, Nov 15, 2018 at 11:55 AM Peter Xu wrote:
> On Thu, Nov 15, 2018 at 03:09:12AM +0800, Zhang Chen wrote:
> > From: Zhang Chen
> >
> > Current COLO mode(independent disk mode) need replication module work
> > together. Suggested by Dr. David Alan Gilbert .
> &
On Sat, Nov 17, 2018, 2:29 AM Dr. David Alan Gilbert * Zhang Chen (zhangc...@gmail.com) wrote:
> > On Wed, Nov 14, 2018 at 7:17 PM Peter Maydell
> > wrote:
> >
> > > On 14 November 2018 at 11:06, Thomas Huth wrote:
> > > > On 2018-11-14 11:47, Peter Xu wro
On Wed, Nov 14, 2018 at 7:17 PM Peter Maydell
wrote:
> On 14 November 2018 at 11:06, Thomas Huth wrote:
> > On 2018-11-14 11:47, Peter Xu wrote:
> >> On Thu, Nov 01, 2018 at 10:12:26AM +0800, Zhang Chen wrote:
> >>> This compilation issue will occur when
From: Zhang Chen
Current COLO mode(independent disk mode) need replication module work
together. Suggested by Dr. David Alan Gilbert .
Signed-off-by: Zhang Chen
---
migration/migration.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
On Mon, Nov 5, 2018 at 6:02 PM Thomas Huth wrote:
> On 2018-11-01 03:12, Zhang Chen wrote:
> > This compilation issue will occur when user use --disable-replication
> > to config Qemu.
> >
> > Reported-by: Thomas Huth
> > Signed-off-by: Zhang Chen
&
Hi All,
Maybe we have forgot this patch? Ping again.
Related discussion:
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03352.html
Thanks
Zhang Chen
On Fri, Sep 14, 2018 at 2:32 PM Zhang Chen wrote:
> Hi All,
>
> No news update?
> Ping...
>
> Thanks
> Zhang C
This compilation issue will occur when user use --disable-replication
to config Qemu.
Reported-by: Thomas Huth
Signed-off-by: Zhang Chen
---
migration/colo.c | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/migration/colo.c b/migration/colo.c
On Wed, Oct 31, 2018 at 3:54 AM Dr. David Alan Gilbert
wrote:
> * Zhang Chen (zhangc...@gmail.com) wrote:
> > This compilation issue will occur when user use --disable-replication
> > to config Qemu.
> >
> > Reported-by: Thomas Huth
> > Signed-off-by: Zhan
601 - 700 of 1725 matches
Mail list logo
