Re: [Qemu-devel] [PATCH] configure: fix elf2dmp check

2018-11-23 Thread Philippe Mathieu-Daudé
On 23/11/18 10:01, Roman Kagan wrote: > elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be > set anywhere. > > The original intent was presumably to skip building it on Windows, so > check for "$mingw32" = "no" instead. > > Signed-off-by: Roman Kagan Reviewed-by: Philippe

[Qemu-devel] [PATCH] configure: fix elf2dmp check

2018-11-23 Thread Roman Kagan
elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be set anywhere. The original intent was presumably to skip building it on Windows, so check for "$mingw32" = "no" instead. Signed-off-by: Roman Kagan --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_cc

2018-10-19 Thread Richard Henderson
On 10/19/18 3:43 AM, Alex Bennée wrote: > The purpose of the code is to use the designated compiler for building > the targets test cases. This is not actually host_cc which will still > be cc even when we are cross compiling. As the tests for $cpu all use > $cc we should do the same. > >

Re: [Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_cc

2018-10-19 Thread Philippe Mathieu-Daudé
On 19/10/2018 12:43, Alex Bennée wrote: > The purpose of the code is to use the designated compiler for building > the targets test cases. This is not actually host_cc which will still > be cc even when we are cross compiling. As the tests for $cpu all use > $cc we should do the same. > >

Re: [Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_cc

2018-10-19 Thread Thomas Huth
On 2018-10-19 12:43, Alex Bennée wrote: > The purpose of the code is to use the designated compiler for building > the targets test cases. This is not actually host_cc which will still > be cc even when we are cross compiling. As the tests for $cpu all use > $cc we should do the same. > >

[Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_cc

2018-10-19 Thread Alex Bennée
The purpose of the code is to use the designated compiler for building the targets test cases. This is not actually host_cc which will still be cc even when we are cross compiling. As the tests for $cpu all use $cc we should do the same. Signed-off-by: Alex Bennée Reported-by: Richard Henderson

Re: [Qemu-devel] [PATCH] configure: remove glib_subprocess check

2018-10-04 Thread Thomas Huth
On 2018-10-03 15:20, Marc-André Lureau wrote: > This should have been removed as part of commit > 692fbdf9f4c6f6bafd0b3a4d4f94973effd3bbae. > > Signed-off-by: Marc-André Lureau > --- > configure | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/configure b/configure > index

Re: [Qemu-devel] [PATCH] configure: remove glib_subprocess check

2018-10-03 Thread Philippe Mathieu-Daudé
On 03/10/2018 15:20, Marc-André Lureau wrote: > This should have been removed as part of commit > 692fbdf9f4c6f6bafd0b3a4d4f94973effd3bbae. > > Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé > --- > configure | 6 -- > 1 file changed, 6 deletions(-) > > diff --git

[Qemu-devel] [PATCH] configure: remove glib_subprocess check

2018-10-03 Thread Marc-André Lureau
This should have been removed as part of commit 692fbdf9f4c6f6bafd0b3a4d4f94973effd3bbae. Signed-off-by: Marc-André Lureau --- configure | 6 -- 1 file changed, 6 deletions(-) diff --git a/configure b/configure index a7368044cc..4f6d6e03b1 100755 --- a/configure +++ b/configure @@ -3557,12

Re: [Qemu-devel] [PATCH] configure: Support --enable-capstone=internal

2018-09-11 Thread Eduardo Habkost
On Tue, Sep 11, 2018 at 07:33:08AM -0700, Richard Henderson wrote: > On 09/05/2018 08:19 AM, Eduardo Habkost wrote: > > Currently there's no way to make configure not try to use the > > system-provided capstone library using pkgconfig. > > Certainly there is. > > > > > Add support to

Re: [Qemu-devel] [PATCH] configure: Support --enable-capstone=internal

2018-09-11 Thread Richard Henderson
On 09/05/2018 08:19 AM, Eduardo Habkost wrote: > Currently there's no way to make configure not try to use the > system-provided capstone library using pkgconfig. Certainly there is. > > Add support to --enable-capstone=internal option to make QEMU not > use the system-provided library

[Qemu-devel] [PATCH] configure: Support --enable-capstone=internal

2018-09-05 Thread Eduardo Habkost
Currently there's no way to make configure not try to use the system-provided capstone library using pkgconfig. Add support to --enable-capstone=internal option to make QEMU not use the system-provided library automatically. Signed-off-by: Eduardo Habkost --- configure | 5 + 1 file

Re: [Qemu-devel] [PATCH] configure: Save PKG_CONFIG_LIBDIR and WINDRES in config.status

2018-09-04 Thread Peter Maydell
On 4 September 2018 at 11:53, Thomas Huth wrote: > But still, I think at least the PKG_CONFIG_LIBDIR part could be useful, > since the same problem e.g. also occurs when trying do a 32-bit build on > a 64-bit host, i.e. when running configure with "--extra-cflags=-m32". > Or is there also another

Re: [Qemu-devel] [PATCH] configure: Save PKG_CONFIG_LIBDIR and WINDRES in config.status

2018-09-04 Thread Thomas Huth
On 2018-09-04 12:43, Daniel P. Berrangé wrote: > On Tue, Sep 04, 2018 at 09:02:18AM +0200, Thomas Huth wrote: >> When cross-compiling QEMU for a target that significantly differs from >> the host, the current information in config.status is not enough to >> properly re-create the configuration.

Re: [Qemu-devel] [PATCH] configure: Save PKG_CONFIG_LIBDIR and WINDRES in config.status

2018-09-04 Thread Thomas Huth
On 2018-09-04 12:35, Peter Maydell wrote: > On 4 September 2018 at 08:02, Thomas Huth wrote: >> When cross-compiling QEMU for a target that significantly differs from >> the host, the current information in config.status is not enough to >> properly re-create the configuration. For example when I

Re: [Qemu-devel] [PATCH] configure: Save PKG_CONFIG_LIBDIR and WINDRES in config.status

2018-09-04 Thread Daniel P . Berrangé
On Tue, Sep 04, 2018 at 09:02:18AM +0200, Thomas Huth wrote: > When cross-compiling QEMU for a target that significantly differs from > the host, the current information in config.status is not enough to > properly re-create the configuration. For example when I try to test > my build with the

Re: [Qemu-devel] [PATCH] configure: Save PKG_CONFIG_LIBDIR and WINDRES in config.status

2018-09-04 Thread Peter Maydell
On 4 September 2018 at 08:02, Thomas Huth wrote: > When cross-compiling QEMU for a target that significantly differs from > the host, the current information in config.status is not enough to > properly re-create the configuration. For example when I try to test > my build with the mingw32

[Qemu-devel] [PATCH] configure: Save PKG_CONFIG_LIBDIR and WINDRES in config.status

2018-09-04 Thread Thomas Huth
When cross-compiling QEMU for a target that significantly differs from the host, the current information in config.status is not enough to properly re-create the configuration. For example when I try to test my build with the mingw32 cross-compiler, I regularly get this error after the build

Re: [Qemu-devel] [PATCH] configure: Support pkg-config for zlib

2018-07-18 Thread Peter Maydell
On 18 July 2018 at 18:04, Daniel P. Berrangé wrote: > On Wed, Jul 18, 2018 at 06:59:25PM +0200, Stefan Weil wrote: >> Am 18.07.2018 um 18:21 schrieb Daniel P. Berrangé: >> > this fallback support for non-pkgconfig scenarios can be entirely >> > deleted, just leaving the error_exit message.

Re: [Qemu-devel] [PATCH] configure: Support pkg-config for zlib

2018-07-18 Thread Daniel P . Berrangé
On Wed, Jul 18, 2018 at 06:59:25PM +0200, Stefan Weil wrote: > Am 18.07.2018 um 18:21 schrieb Daniel P. Berrangé: > > On Thu, Jul 12, 2018 at 09:26:03PM +0200, Stefan Weil wrote: > >> This is needed for builds with the mingw64-* packages from Cygwin, > >> but also works for Linux. > >> > >> Move

Re: [Qemu-devel] [PATCH] configure: Support pkg-config for zlib

2018-07-18 Thread Stefan Weil
Am 18.07.2018 um 18:21 schrieb Daniel P. Berrangé: > On Thu, Jul 12, 2018 at 09:26:03PM +0200, Stefan Weil wrote: >> This is needed for builds with the mingw64-* packages from Cygwin, >> but also works for Linux. >> >> Move the zlib test also more to the end because users should >> get information

Re: [Qemu-devel] [PATCH] configure: Support pkg-config for zlib

2018-07-18 Thread Daniel P . Berrangé
On Thu, Jul 12, 2018 at 09:26:03PM +0200, Stefan Weil wrote: > This is needed for builds with the mingw64-* packages from Cygwin, > but also works for Linux. > > Move the zlib test also more to the end because users should > get information on the really important missing packages > (which also

Re: [Qemu-devel] [PATCH] configure: Support pkg-config for zlib

2018-07-18 Thread Stefan Hajnoczi
On Thu, Jul 12, 2018 at 09:26:03PM +0200, Stefan Weil wrote: > This is needed for builds with the mingw64-* packages from Cygwin, > but also works for Linux. > > Move the zlib test also more to the end because users should > get information on the really important missing packages > (which also

[Qemu-devel] [PATCH] configure: Support pkg-config for zlib

2018-07-12 Thread Stefan Weil
This is needed for builds with the mingw64-* packages from Cygwin, but also works for Linux. Move the zlib test also more to the end because users should get information on the really important missing packages (which also require zlib) first. Signed-off-by: Stefan Weil --- configure | 40

Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Philippe Mathieu-Daudé
On 07/04/2018 01:26 PM, Daniel P. Berrangé wrote: > On Wed, Jul 04, 2018 at 05:21:49PM +0100, Alex Bennée wrote: >> >> Daniel P. Berrangé writes: >> >>> On Wed, Jul 04, 2018 at 04:41:30PM +0100, Alex Bennée wrote: Philippe Mathieu-Daudé writes: > This silent (since

Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 05:21:49PM +0100, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Wed, Jul 04, 2018 at 04:41:30PM +0100, Alex Bennée wrote: > >> > >> Philippe Mathieu-Daudé writes: > >> > >> > This silent (since d75402b5ee2): > >> > > >> > ./configure > >> > [...] > >> >

Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Alex Bennée
Daniel P. Berrangé writes: > On Wed, Jul 04, 2018 at 04:41:30PM +0100, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >> > This silent (since d75402b5ee2): >> > >> > ./configure >> > [...] >> > NOTE: cross-compilers enabled: 'cc' >> > >> > Reported-by: Dr. David Alan

Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 04:41:30PM +0100, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > This silent (since d75402b5ee2): > > > > ./configure > > [...] > > NOTE: cross-compilers enabled: 'cc' > > > > Reported-by: Dr. David Alan Gilbert > > Reported-by: Daniel P. Berrangé >

Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > This silent (since d75402b5ee2): > > ./configure > [...] > NOTE: cross-compilers enabled: 'cc' > > Reported-by: Dr. David Alan Gilbert > Reported-by: Daniel P. Berrangé > Signed-off-by: Philippe Mathieu-Daudé > --- > configure | 2 +- > 1 file

Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Cornelia Huck
On Wed, 4 Jul 2018 11:30:14 -0300 Philippe Mathieu-Daudé wrote: > This silent (since d75402b5ee2): s/silent/silences/ > > ./configure > [...] > NOTE: cross-compilers enabled: 'cc' > > Reported-by: Dr. David Alan Gilbert > Reported-by: Daniel P. Berrangé > Signed-off-by: Philippe

[Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

2018-07-04 Thread Philippe Mathieu-Daudé
This silent (since d75402b5ee2): ./configure [...] NOTE: cross-compilers enabled: 'cc' Reported-by: Dr. David Alan Gilbert Reported-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure

Re: [Qemu-devel] [PATCH] configure: Enable out-of-tree acceptance tests

2018-06-13 Thread Eduardo Habkost
On Tue, Jun 12, 2018 at 02:34:37PM -0300, Philippe Mathieu-Daudé wrote: > Currently to run Avocado acceptance tests in an out-of-tree > build directory, we need to use the full path to the test: > > build_dir$ avocado run > /full/path/to/sources/qemu/tests/acceptance/boot_linux_console.py > >

[Qemu-devel] [PATCH] configure: Enable out-of-tree acceptance tests

2018-06-12 Thread Philippe Mathieu-Daudé
Currently to run Avocado acceptance tests in an out-of-tree build directory, we need to use the full path to the test: build_dir$ avocado run /full/path/to/sources/qemu/tests/acceptance/boot_linux_console.py This patch adds a symlink in the build tree to simplify the tests invocation,

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-11 Thread Stefan Hajnoczi
On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > *

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread John Snow
On 06/08/2018 10:30 AM, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > * scripts/argparse.py

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Cleber Rosa
On 06/08/2018 10:30 AM, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > * scripts/argparse.py

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:55:59AM -0300, Eduardo Habkost wrote: > On Fri, Jun 08, 2018 at 03:37:47PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > > > All of the supported build platforms documented in qemu-doc.texi > > > should already

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > *

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Eduardo Habkost
On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > *

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/08/2018 11:40 AM, Daniel P. Berrangé wrote: > On Fri, Jun 08, 2018 at 11:37:36AM -0300, Philippe Mathieu-Daudé wrote: >> Cc'ing Eric >> >> On 06/08/2018 11:30 AM, Eduardo Habkost wrote: >>> All of the supported build platforms documented in qemu-doc.texi >>> should already support Python

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Eduardo Habkost
On Fri, Jun 08, 2018 at 03:37:47PM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > > All of the supported build platforms documented in qemu-doc.texi > > should already support Python 2.7. > > > > Removing support for Python 2.6 will allow us

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:37:36AM -0300, Philippe Mathieu-Daudé wrote: > Cc'ing Eric > > On 06/08/2018 11:30 AM, Eduardo Habkost wrote: > > All of the supported build platforms documented in qemu-doc.texi > > should already support Python 2.7. > >

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > *

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Philippe Mathieu-Daudé
Cc'ing Eric On 06/08/2018 11:30 AM, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg05173.html On 08/25/2017 11:40 AM, Peter Maydell wrote: > Our choices

[Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Eduardo Habkost
All of the supported build platforms documented in qemu-doc.texi should already support Python 2.7. Removing support for Python 2.6 will allow us to remove some compatibility modules we carry in the QEMU tree: * scripts/argparse.py * scripts/ordereddict.py Python 2.6 is also not receiving bug

Re: [Qemu-devel] [PATCH] configure: print virglrenderer version

2018-05-27 Thread Ján Tomko
On Fri, May 25, 2018 at 05:36:09PM +0200, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital

[Qemu-devel] [PATCH] configure: print virglrenderer version

2018-05-25 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index a8498ab393..4662e07a75 100755 --- a/configure +++ b/configure @@ -4606,6 +4606,7 @@ int main(void) {

Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-15 Thread Eric Blake
On 05/15/2018 10:04 AM, Peter Maydell wrote: I'd much prefer this to be: if $strings -a $TMPO | grep... That's because if I have something like this in my environment: STRINGS='/path/to/strings -a' it will only work if you allow word splitting on my variable. Conversely, if I have

Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-15 Thread Peter Maydell
On 15 May 2018 at 16:00, Eric Blake wrote: > On 05/13/2018 03:50 AM, Stefan Weil wrote: >> >> This fixes cross builds for the (rare) case where cross binutils >> but no native binutils are installed. >> >> Signed-off-by: Stefan Weil >> --- >> configure | 5

Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-15 Thread Eric Blake
On 05/13/2018 03:50 AM, Stefan Weil wrote: This fixes cross builds for the (rare) case where cross binutils but no native binutils are installed. Signed-off-by: Stefan Weil --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-14 Thread Richard Henderson
On 05/13/2018 01:50 AM, Stefan Weil wrote: > This fixes cross builds for the (rare) case where cross binutils > but no native binutils are installed. > > Signed-off-by: Stefan Weil > --- > configure | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by:

Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-13 Thread Philippe Mathieu-Daudé
On 05/13/2018 05:50 AM, Stefan Weil wrote: > This fixes cross builds for the (rare) case where cross binutils > but no native binutils are installed. > > Signed-off-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé > --- > configure | 5 +++-- > 1 file

[Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-13 Thread Stefan Weil
This fixes cross builds for the (rare) case where cross binutils but no native binutils are installed. Signed-off-by: Stefan Weil --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 24c411e346..4f6ace1ed4 100755

Re: [Qemu-devel] [PATCH] configure: Add explanation for --enable-xen-pci-passthrough

2018-05-04 Thread Markus Armbruster
Anthony PERARD writes: > Signed-off-by: Anthony PERARD > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 1443422e83..e961473e76 100755 > --- a/configure > +++

[Qemu-devel] [PATCH] configure: Add explanation for --enable-xen-pci-passthrough

2018-05-04 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1443422e83..e961473e76 100755 --- a/configure +++ b/configure @@ -1586,7 +1586,7 @@ disabled with --disable-FEATURE, default is

Re: [Qemu-devel] [PATCH] configure: add sanity check to catch builds from "git archive"

2018-04-18 Thread Peter Maydell
On 18 April 2018 at 11:11, Daniel P. Berrangé wrote: > The "git archive" feature creates tarballs which are missing all > submodule content. GitHub unhelpfully provides users with "Download" > links that claim to give them valid source release tarballs. These > GitHub

[Qemu-devel] [PATCH] configure: add sanity check to catch builds from "git archive"

2018-04-18 Thread Daniel P . Berrangé
The "git archive" feature creates tarballs which are missing all submodule content. GitHub unhelpfully provides users with "Download" links that claim to give them valid source release tarballs. These GitHub archives will not be buildable as they are created by the "git archive" feature and so are

Re: [Qemu-devel] [PATCH] configure: don't warn SDL abi if disabled

2018-04-10 Thread Peter Xu
On Tue, Apr 10, 2018 at 04:49:50PM +0800, Fam Zheng wrote: [...] > We have had > > function_name() > { > ... > > and > > function_name() { > ... > > and > > function_name () { > ... > > finally you invent the last in the family: > > function_name () > {

Re: [Qemu-devel] [PATCH] configure: don't warn SDL abi if disabled

2018-04-10 Thread Fam Zheng
On Tue, 04/10 13:40, Peter Xu wrote: > SDL has the same problem as GTK that we might get warnings on SDL ABI > version even if SDL is disabled. Fix that by only probing SDL if SDL is > enabled. Also this should let configure be a little bit faster since we > don't really need to probe SDL stuff

Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-10 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 04:23:23PM +0800, Peter Xu wrote: > We don't need to detect GTK ABI if GTK is disabled in general. > Otherwise we could get this warning (when host is installed with GTK ABI > version 2) even when configure with "--disable-gtk": > > WARNING: Use of GTK 2.0 is

Re: [Qemu-devel] [PATCH] configure: don't warn SDL abi if disabled

2018-04-10 Thread Daniel P . Berrangé
On Tue, Apr 10, 2018 at 01:40:34PM +0800, Peter Xu wrote: > SDL has the same problem as GTK that we might get warnings on SDL ABI > version even if SDL is disabled. Fix that by only probing SDL if SDL is > enabled. Also this should let configure be a little bit faster since we > don't really

[Qemu-devel] [PATCH] configure: don't warn SDL abi if disabled

2018-04-09 Thread Peter Xu
SDL has the same problem as GTK that we might get warnings on SDL ABI version even if SDL is disabled. Fix that by only probing SDL if SDL is enabled. Also this should let configure be a little bit faster since we don't really need to probe SDL stuff when it's off. CC: Paolo Bonzini

Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-09 Thread Peter Xu
On Mon, Apr 09, 2018 at 07:37:11PM +0200, Paolo Bonzini wrote: > On 09/04/2018 11:24, Peter Maydell wrote: > > On 9 April 2018 at 09:31, Daniel P. Berrangé wrote: > >> Feels to me that since we've deprecated 2.0, we could just *never* auto > >> detect - just do test -z

Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-09 Thread Paolo Bonzini
On 09/04/2018 11:24, Peter Maydell wrote: > On 9 April 2018 at 09:31, Daniel P. Berrangé wrote: >> Feels to me that since we've deprecated 2.0, we could just *never* auto >> detect - just do test -z "$gtkabi" && gtkabi=3.0 >> >> Anyone who wants gtk2 should have to use an

Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-09 Thread Peter Maydell
On 9 April 2018 at 09:31, Daniel P. Berrangé wrote: > Feels to me that since we've deprecated 2.0, we could just *never* auto > detect - just do test -z "$gtkabi" && gtkabi=3.0 > > Anyone who wants gtk2 should have to use an explicit --with-gtkabi=2.0 I think if we still

Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-09 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 04:23:23PM +0800, Peter Xu wrote: > We don't need to detect GTK ABI if GTK is disabled in general. > Otherwise we could get this warning (when host is installed with GTK ABI > version 2) even when configure with "--disable-gtk": > > WARNING: Use of GTK 2.0 is

[Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-09 Thread Peter Xu
We don't need to detect GTK ABI if GTK is disabled in general. Otherwise we could get this warning (when host is installed with GTK ABI version 2) even when configure with "--disable-gtk": WARNING: Use of GTK 2.0 is deprecated and will be removed in WARNING: future releases. Please switch

Re: [Qemu-devel] [PATCH] configure: Add missing configure options to help text

2018-04-05 Thread Paolo Bonzini
On 27/03/2018 17:09, Thomas Huth wrote: > We forgot to mention --with-git, --libexecdir and --with-pkgversion > so far. > > Signed-off-by: Thomas Huth > --- > configure | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configure b/configure > index 4d0e92c..a473609

Re: [Qemu-devel] [PATCH] configure: Add missing configure options to help text

2018-03-31 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1522163370-18544-1-git-send-email-th...@redhat.com Subject: [Qemu-devel] [PATCH

[Qemu-devel] [PATCH] configure: Add missing configure options to help text

2018-03-27 Thread Thomas Huth
We forgot to mention --with-git, --libexecdir and --with-pkgversion so far. Signed-off-by: Thomas Huth --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure index 4d0e92c..a473609 100755 --- a/configure +++ b/configure @@ -1497,16 +1497,19

Re: [Qemu-devel] [PATCH] configure: fix sanitizers' test program to mend ASan detection

2018-02-21 Thread Emilio G. Cota
On Wed, Feb 21, 2018 at 10:12:28 +0100, Marc-André Lureau wrote: > I sent a patch a few days ago: > "[PATCH 1/6] build-sys: fix -fsanitize=address check" Ouch, I missed that. Please disregard my patch. Thanks, Emilio

Re: [Qemu-devel] [PATCH] configure: fix sanitizers' test program to mend ASan detection

2018-02-21 Thread Marc-André Lureau
Hi On Wed, Feb 21, 2018 at 2:03 AM, Emilio G. Cota wrote: > Commit 218bb57 ("build-sys: check static linking of UBSAN", 2018-02-13) > adds a small test program to check whether ubsan works even when > configuring with --static. This added program is used to > detect all

[Qemu-devel] [PATCH] configure: fix sanitizers' test program to mend ASan detection

2018-02-20 Thread Emilio G. Cota
Commit 218bb57 ("build-sys: check static linking of UBSAN", 2018-02-13) adds a small test program to check whether ubsan works even when configuring with --static. This added program is used to detect all sanitizers, which breaks ASan's detection since the compilation fails with

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-15 Thread Eric Blake
On 02/15/2018 04:08 AM, Daniel P. Berrangé wrote: Hmm - here you're changing who supplies the ().  But that argues that maybe the callsites should supply " (" and ")" themselves. Yeah, that's likely the saner way to do this. The question is: What about the query-version QMP command? Should it

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-15 Thread Daniel P . Berrangé
On Thu, Feb 15, 2018 at 07:02:40AM +0100, Thomas Huth wrote: > On 14.02.2018 21:23, Eric Blake wrote: > > On 02/14/2018 11:31 AM, Thomas Huth wrote: > >> When running configure with --with-pkgversion=foo there is no > >> space anymore between the version number and the parentheses: > >> > >> $

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-14 Thread Thomas Huth
On 14.02.2018 21:23, Eric Blake wrote: > On 02/14/2018 11:31 AM, Thomas Huth wrote: >> When running configure with --with-pkgversion=foo there is no >> space anymore between the version number and the parentheses: >> >> $ m68k-softmmu/qemu-system-m68k -version >> QEMU emulator version 2.11.50(foo)

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-14 Thread Eric Blake
On 02/14/2018 11:31 AM, Thomas Huth wrote: When running configure with --with-pkgversion=foo there is no space anymore between the version number and the parentheses: $ m68k-softmmu/qemu-system-m68k -version QEMU emulator version 2.11.50(foo) Fix it by moving the space from the configure

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-14 Thread Eric Blake
On 02/14/2018 02:00 PM, Thomas Huth wrote: On 14.02.2018 19:33, Peter Maydell wrote: On 14 February 2018 at 17:31, Thomas Huth wrote: When running configure with --with-pkgversion=foo there is no space anymore between the version number and the parentheses: $

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-14 Thread Thomas Huth
On 14.02.2018 19:33, Peter Maydell wrote: > On 14 February 2018 at 17:31, Thomas Huth wrote: >> When running configure with --with-pkgversion=foo there is no >> space anymore between the version number and the parentheses: >> >> $ m68k-softmmu/qemu-system-m68k -version >> QEMU

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-14 Thread Peter Maydell
On 14 February 2018 at 17:31, Thomas Huth wrote: > When running configure with --with-pkgversion=foo there is no > space anymore between the version number and the parentheses: > > $ m68k-softmmu/qemu-system-m68k -version > QEMU emulator version 2.11.50(foo) > > Fix it by moving

[Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-14 Thread Thomas Huth
When running configure with --with-pkgversion=foo there is no space anymore between the version number and the parentheses: $ m68k-softmmu/qemu-system-m68k -version QEMU emulator version 2.11.50(foo) Fix it by moving the space from the configure script to the Makefile. Fixes:

Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator

2018-01-08 Thread Peter Maydell
On 8 January 2018 at 17:16, Philippe Mathieu-Daudé wrote: > On 01/08/2018 02:10 PM, Peter Maydell wrote: >> In commit c97d6d2cdf97ed we accidentally added code to configure >> that uses '==' for string equality testing. This is a bashism -- >> the portable way to write this is

Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator

2018-01-08 Thread Philippe Mathieu-Daudé
On 01/08/2018 02:10 PM, Peter Maydell wrote: > In commit c97d6d2cdf97ed we accidentally added code to configure > that uses '==' for string equality testing. This is a bashism -- > the portable way to write this is '='. > > This fixes the "Unexpected operator error" complaint produced > if the

Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator

2018-01-08 Thread Eric Blake
On 01/08/2018 11:10 AM, Peter Maydell wrote: > In commit c97d6d2cdf97ed we accidentally added code to configure > that uses '==' for string equality testing. This is a bashism -- > the portable way to write this is '='. > > This fixes the "Unexpected operator error" complaint produced > if the

[Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator

2018-01-08 Thread Peter Maydell
In commit c97d6d2cdf97ed we accidentally added code to configure that uses '==' for string equality testing. This is a bashism -- the portable way to write this is '='. This fixes the "Unexpected operator error" complaint produced if the system /bin/sh is dash. Fixes: c97d6d2cdf97ed Reported-by:

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-12-11 Thread Peter Maydell
On 26 November 2017 at 21:13, Brad Smith wrote: > Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). > > ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* > constants. > > Signed-off-by: Brad Smith > > > diff --git

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-27 Thread Fam Zheng
On Mon, 11/27 13:02, Peter Maydell wrote: > On 26 November 2017 at 22:13, Brad Smith wrote: > > Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). > > > > ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* > > constants. > > ncurses 5.7

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-27 Thread Brad Smith
On 11/27/17 07:02, Peter Maydell wrote: On 26 November 2017 at 22:13, Brad Smith wrote: Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* constants. ncurses 5.7 was released in

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-27 Thread Peter Maydell
On 27 November 2017 at 14:52, Brad Smith wrote: > On 11/27/2017 7:02 AM, Peter Maydell wrote: > >> On 26 November 2017 at 22:13, Brad Smith wrote: >>> >>> Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). >>> >>> ncurses 5.7 requires

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-27 Thread Brad Smith
On 11/27/2017 7:02 AM, Peter Maydell wrote: On 26 November 2017 at 22:13, Brad Smith wrote: Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* constants. ncurses 5.7 was released in

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-27 Thread Peter Maydell
On 26 November 2017 at 22:13, Brad Smith wrote: > Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). > > ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* > constants. ncurses 5.7 was released in 2008 and is now 9 years old. Why is

[Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-26 Thread Brad Smith
Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* constants. Signed-off-by: Brad Smith diff --git a/configure b/configure index 0c6e7572db..9715b9c2cc 100755 --- a/configure +++

Re: [Qemu-devel] [PATCH] configure: Deal with OpenBSD/i386 emulation linker

2017-11-09 Thread Peter Maydell
On 7 November 2017 at 23:51, Brad Smith wrote: > On Mon, Nov 06, 2017 at 11:37:45AM +, Peter Maydell wrote: >> On 6 November 2017 at 00:53, Brad Smith wrote: >> > OpenBSD/i386 uses elf_i386_obsd for the emulation linker. >> > >> > Signed-off-by: Brad

Re: [Qemu-devel] [PATCH] configure: Deal with OpenBSD/i386 emulation linker

2017-11-07 Thread Brad Smith
On Mon, Nov 06, 2017 at 11:37:45AM +, Peter Maydell wrote: > On 6 November 2017 at 00:53, Brad Smith wrote: > > OpenBSD/i386 uses elf_i386_obsd for the emulation linker. > > > > Signed-off-by: Brad Smith > > > > > > diff --git a/configure b/configure > >

Re: [Qemu-devel] [PATCH] configure: pick the right compiler for OpenBSD by default

2017-11-06 Thread Kamil Rytarowski
On 13.10.2017 12:52, Thomas Huth wrote: > On 13.10.2017 12:28, Daniel P. Berrange wrote: >> The system compiler in OpenBSD is gcc 4.2.1 which is too >> old for our needs. If doing 'pkg_add gcc' you can get a >> much newer version (4.9.4 in OpenBSD 6.1) which works with >> QEMU. This installs

Re: [Qemu-devel] [PATCH] configure: Deal with OpenBSD/i386 emulation linker

2017-11-06 Thread Peter Maydell
On 6 November 2017 at 00:53, Brad Smith wrote: > OpenBSD/i386 uses elf_i386_obsd for the emulation linker. > > Signed-off-by: Brad Smith > > > diff --git a/configure b/configure > index dd73cce62f..02799d38ac 100755 > --- a/configure > +++ b/configure > @@

[Qemu-devel] [PATCH] configure: Deal with OpenBSD/i386 emulation linker

2017-11-05 Thread Brad Smith
OpenBSD/i386 uses elf_i386_obsd for the emulation linker. Signed-off-by: Brad Smith diff --git a/configure b/configure index dd73cce62f..02799d38ac 100755 --- a/configure +++ b/configure @@ -5159,9 +5159,9 @@ if test \( "$cpu" = "i386" -o "$cpu" = "x86_64" \) -a \

Re: [Qemu-devel] [PATCH] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread Daniel Henrique Barboza
On 11/01/2017 04:23 PM, Peter Maydell wrote: On 1 November 2017 at 17:53, Daniel Henrique Barboza wrote: When executing 'configure' in a fresh QEMU clone, in a fresh OS install running in a ppc64le host, this is the error shown: - ../configure

Re: [Qemu-devel] [PATCH] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread Peter Maydell
On 1 November 2017 at 17:53, Daniel Henrique Barboza wrote: > When executing 'configure' in a fresh QEMU clone, in a fresh > OS install running in a ppc64le host, this is the error > shown: > > - > > ../configure --enable-trace-backend=simple --enable-debug >

[Qemu-devel] [PATCH] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread Daniel Henrique Barboza
When executing 'configure' in a fresh QEMU clone, in a fresh OS install running in a ppc64le host, this is the error shown: - ../configure --enable-trace-backend=simple --enable-debug --target-list=ppc64-softmmu ERROR: Unsupported CPU = ppc64le, try --enable-tcg-interpreter - This

<    1   2   3   4   5   6   7   8   9   10   >