[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 5: Verified+1 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. IMPALA-6405: Error when string to decimal ca

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 Dependency changes: - BE

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/9300/7/

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-03-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9497 ) Change subject: IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh .. IMPALA-6599: fixes return for NativeLibCa

[Impala-ASF-CR] IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9497 ) Change subject: IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh .. Patch Set 1: Verified+1 -- To view, visit http:

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 6: Verified+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. IMPALA-6553: [DOCS] load_catalog_in_bac

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 6: Build started: https://jenkins.im

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-03-05 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 6: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option

2018-03-05 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option .. Patch Set 5: Code-Review+1 -- To view, vi

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 5: Build started: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

2018-03-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9484 ) Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL .. Patch Set 1: > I am not 100% sure how to best ve

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. IMPALA-6405: Error when string to decimal cast overflows

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/9300/

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. IMPALA-6405: Error when string to decimal cast overflows

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. IMPALA-6405: Error when string to decimal cast overflows

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9493 to look at the new patch set (#4). Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9493/2/t

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9493/1/be/sr

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 5: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 7: > Patch Set 6: > > (1 comment) Thanks. It seems to be a

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-03-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 5: > Uploaded patch set 6. Removed extra spac

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-03-05 Thread Alex Rodoni (Code Review)
Hello John Russell, Balazs Jeszenszky, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9389 to look at the new patch set (#6). Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change ...

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloud

[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [DOCS] Removed the obsolete Llama options files .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [DOCS] Removed the obsolete Llama options files .. [DOCS] Removed the obsolete Llama options files Remo

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-03-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 5: > (4 comments) > > A couple of comments i

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9493 to look at the new patch set (#2). Change subject: IMPALA-6595: fix crash in NljBuilder::Close()

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9493/1/

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-03-05 Thread Alex Rodoni (Code Review)
Hello John Russell, Balazs Jeszenszky, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9389 to look at the new patch set (#5). Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change ...

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9300/6/b

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-03-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [DOCS] Removed the obsolete Llama options files .. Patch Set 5: Build started: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files

2018-03-05 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [DOCS] Removed the obsolete Llama options files .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9497 ) Change subject: IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh .. Patch Set 1: Build started: https://jenkins.impa

[Impala-ASF-CR] IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh

2018-03-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9497 ) Change subject: IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option

2018-03-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option .. Patch Set 4: (3 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option

2018-03-05 Thread Alex Rodoni (Code Review)
Hello John Russell, Alan Choi, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9293 to look at the new patch set (#5). Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option .

[Impala-ASF-CR] IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh

2018-03-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9497 Change subject: IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh .. IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefres

[Impala-ASF-CR] IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns

2018-03-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9346 ) Change subject: IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns .. Patch Set 1: (3 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. IMPALA-6394: Restart HDFS when blocks are under replicated HD

[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files

2018-03-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [DOCS] Removed the obsolete Llama options files .. Patch Set 5: > There are still tags referencing the removed files, wh

[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files

2018-03-05 Thread Alex Rodoni (Code Review)
Hello Michael Brown, John Russell, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9219 to look at the new patch set (#5). Change subject: [DOCS] Removed the obsolete Llama options files .

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-03-05 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 4: (4 comments) A couple of comments inline,

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9493/1/be/sr

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files

2018-03-05 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [DOCS] Removed the obsolete Llama options files .. Patch Set 4: There are still tags referencing the removed files, whi

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-03-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files

2018-03-05 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [DOCS] Removed the obsolete Llama options files .. Patch Set 4: For structural changes, it's a good idea to run a DITA-O

[Impala-ASF-CR] Draft: Add JSON output to MemTracker::LogUsage()

2018-03-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8955 ) Change subject: Draft: Add JSON output to MemTracker::LogUsage() .. Patch Set 1: This is a draft and not meant for reviewing. -- To vie

[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option

2018-03-05 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option .. Patch Set 3: (3 comments) Just a couple o

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 12: (2 comments) http://gerr

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-05 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#12). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-05 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 2: (10 comments) Sorry, I f

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9493/1//COMM

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-05 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9403 to look at the new patch set (#3). Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner ..

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2018-03-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has abandoned this change. ( http://gerrit.cloudera.org:8080/9225 ) Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Abandoned abandoned until IMPALA-6215 goes in -- To v

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9286 ) Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters .. IMPALA-6509: [DOCS] Note for haproxy for

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 ) Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters .. Patch Set 6: Verified+1 -- To view, visit http

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9493/1/be/sr

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 ) Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters .. Patch Set 6: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

2018-03-05 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 ) Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters .. Patch Set 6: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9493 Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. IMPALA-6595: fix crash in NljBuilder::Close() The bug is that the right

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-03-05 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 5: (2 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 2: (5 comments) Thx Attila for taking a look!

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 2: (5 comments) I took a quick pass to under

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2018-03-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9225 ) Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 1: Can we abandon this for now unti

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-05 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 2: (32 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 2: (10 comments) http://gerrit

[Impala-ASF-CR] Draft: Add JSON output to MemTracker::LogUsage()

2018-03-05 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8955 ) Change subject: Draft: Add JSON output to MemTracker::LogUsage() .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/89

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. IMPALA-2567: Enable KRPC by default This change enables the swit

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:80