[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 21: Build Successful

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 20: Build Successful

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Xiaoqing Gao (Code Review)
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Xiaoqing Gao (Code Review)
Hello Quanlong Huang, Fang-Yu Rao, lipeng...@sensorsdata.cn, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19252 to look at the new patch set (#21). Change subject: IMPALA-11728: Set fallback database for functions

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Xiaoqing Gao (Code Review)
Hello Quanlong Huang, Fang-Yu Rao, lipeng...@sensorsdata.cn, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19252 to look at the new patch set (#20). Change subject: IMPALA-11728: Set fallback database for functions

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 19: Code-Review+1 (2 comments) Thanks for the effort

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-01 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 15: (14 comments)

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-01 Thread Yida Wu (Code Review)
Yida Wu has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. IMPALA-11470: Add Cache For Codegen Functions The patch adds supports of

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-01 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 10: (1 comment) I added a new test case in

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-01 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19194 to look at the new patch set (#10). Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19186 ) Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19186 ) Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19186 ) Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables

2022-12-01 Thread Quanlong Huang (Code Review)
Hello Daniel Becker, Gergely Fürnstáhl, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19186 to look at the new patch set (#4). Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on

[Impala-ASF-CR] IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables

2022-12-01 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19186 ) Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables

2022-12-01 Thread Quanlong Huang (Code Review)
Hello Daniel Becker, Gergely Fürnstáhl, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19186 to look at the new patch set (#3). Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on

[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19262 ) Change subject: IMPALA-11736: Copy data between ofs buckets .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19262 ) Change subject: IMPALA-11736: Copy data between ofs buckets .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-12-01 Thread Michael Smith (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19262 to look at the new patch set (#5). Change subject: IMPALA-11736: Copy data between ofs buckets

[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19262 ) Change subject: IMPALA-11736: Copy data between ofs buckets .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-11738: Add toolchain libstdc++ to LD LIBRARY PATH for HiveServer2

2022-12-01 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19276 ) Change subject: IMPALA-11738: Add toolchain libstdc++ to LD_LIBRARY_PATH for HiveServer2 .. Patch Set 1: Seems the dryrun failure is due

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 10: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 3: Build Failed

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has removed a vote on this change. Change subject: IMPALA-11728: Set fallback database for functions .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/19252 To

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 19: Code-Review+2 The test failure looks like an

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-01 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19304 to look at the new patch set (#4). Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-01 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19304 to look at the new patch set (#3). Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-01 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19304 to look at the new patch set (#2). Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19304 Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. IMPALA-11549: Support Hive GenericUdfs

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned

2022-12-01 Thread Michael Smith (Code Review)
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19291 ) Change subject: IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned .. IMPALA-11766: In

[Impala-ASF-CR] IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned

2022-12-01 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19291 ) Change subject: IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned .. Patch Set 1: Code-Review+2 We should file

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-01 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables

2022-12-01 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19186 ) Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables .. Patch Set 2: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-01 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 14: Code-Review+1 (15 comments) Some additional comments to

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 19: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 14: Build Successful

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-01 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 14: Rebased and fixed one testcase issue. -- To view, visit

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-01 Thread Yida Wu (Code Review)
Yida Wu has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. IMPALA-11470: Add Cache For Codegen Functions The patch adds supports of

[Impala-ASF-CR] IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables

2022-12-01 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19186 ) Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables .. Patch Set 2: Agreed,

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 13: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-01 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 5: Code-Review+1 LGTM. Give +1 first if other reviewers also want to

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 9: Code-Review+2 Thanks for the changes!

[Impala-ASF-CR] IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables

2022-12-01 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19186 ) Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables .. Patch Set 2: > Patch Set 2:

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 19: Build Successful

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 19: Build started:

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Xiaoqing Gao (Code Review)
Hello Quanlong Huang, Fang-Yu Rao, lipeng...@sensorsdata.cn, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19252 to look at the new patch set (#19). Change subject: IMPALA-11728: Set fallback database for functions

[Impala-ASF-CR] IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables

2022-12-01 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19186 ) Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables .. Patch Set 2: Code-Review+1

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-01 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 10: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-01 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. IMPALA-11758: Fixed error detection for usage

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-01 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-01 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. IMPALA-11758: Fixed error detection for usage of

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 8: (6 comments)

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Anonymous Coward (Code Review)
lipeng...@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 18: Code-Review+1 Look good to me! Thanks

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 18: Code-Review+1 (1 comment) Thanks a lot for

[Impala-ASF-CR] IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned

2022-12-01 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19291 ) Change subject: IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned .. Patch Set 1: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-01 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-01 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19198/3//COMMIT_MSG

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-01 Thread Peter Rozsa (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19198 to look at the new patch set (#5). Change subject: IMPALA-11478: Cleanup JniCatalog

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Xiaoqing Gao (Code Review)
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 18: Build Successful

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-12-01 Thread Xiaoqing Gao (Code Review)
Hello Quanlong Huang, Fang-Yu Rao, lipeng...@sensorsdata.cn, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19252 to look at the new patch set (#18). Change subject: IMPALA-11728: Set fallback database for functions