[Impala-ASF-CR] IMPALA-12487: Skip reloading file metadata for ALTER TABLE events with trivial changes in StorageDescriptor

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21019 ) Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE events with trivial changes in StorageDescriptor ..

[Impala-ASF-CR] IMPALA-12487: Skip reloading file metadata for ALTER TABLE events with trivial changes in StorageDescriptor

2024-03-14 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21019 ) Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE events with trivial changes in StorageDescriptor ..

[Impala-ASF-CR] IMPALA-12487: Skip reloading file metadata for ALTER TABLE events with trivial changes in StorageDescriptor

2024-03-14 Thread Sai Hemanth Gantasala (Code Review)
Hello Quanlong Huang, k.venureddy2...@gmail.com, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21019 to look at the new patch set (#7). Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 ) Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

2024-03-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 ) Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables .. Patch Set 4: (4 comments) Thanks Joe for your feedback.

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

2024-03-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21088 ) Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables .. IMPALA-12802: Support ALTER TABLE for JDBC tables IMPALA-12793

[Impala-ASF-CR] IMPALA-12737: List key columns in query history

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 ) Change subject: IMPALA-12737: List key columns in query history .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-12626: Add Tables Queried to profile/history

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20886 ) Change subject: IMPALA-12626: Add Tables Queried to profile/history .. Patch Set 18: Build Successful

[Impala-ASF-CR] IMPALA-12737: List key columns in query history

2024-03-14 Thread Michael Smith (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21142 to look at the new patch set (#5). Change subject: IMPALA-12737: List key columns in query history ..

[Impala-ASF-CR] IMPALA-12626: Add Tables Queried to profile/history

2024-03-14 Thread Michael Smith (Code Review)
Hello Andrew Sherman, Jason Fehr, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20886 to look at the new patch set (#18). Change subject: IMPALA-12626: Add Tables Queried to profile/history

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

2024-03-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 ) Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 49: (1 comment)

[Impala-ASF-CR] IMPALA-12540: Add system.impala query live table

2024-03-14 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 ) Change subject: IMPALA-12540: Add system.impala_query_live table .. Patch Set 33: (4 comments)

[Impala-ASF-CR] IMPALA-12856: Event processor should ignore processing partition with empty partition values

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21143 ) Change subject: IMPALA-12856: Event processor should ignore processing partition with empty partition values .. Patch Set 3:

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 49: Build Successful

[Impala-ASF-CR] IMPALA-12856: Event processor should ignore processing partition with empty partition values

2024-03-14 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21143 ) Change subject: IMPALA-12856: Event processor should ignore processing partition with empty partition values .. Patch Set 3:

[Impala-ASF-CR] IMPALA-12856: Event processor should ignore processing partition with empty partition values

2024-03-14 Thread Sai Hemanth Gantasala (Code Review)
Hello Quanlong Huang, k.venureddy2...@gmail.com, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21143 to look at the new patch set (#3). Change subject: IMPALA-12856: Event processor should ignore processing

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 49: (1 comment)

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-14 Thread Michael Smith (Code Review)
Michael Smith has uploaded a new patch set (#49) to the change originally created by Jason Fehr. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. IMPALA-12426: Query History Table

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 48: (1 comment)

[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch

[Impala-ASF-CR] IMPALA-12818: Intermediate Result Caching plan node framework

2024-03-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21035 ) Change subject: IMPALA-12818: Intermediate Result Caching plan node framework .. IMPALA-12818: Intermediate Result Caching

[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions

2024-03-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 ) Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions .. Patch Set 1:

[Impala-ASF-CR] IMPALA-12904: test type conversions hive3 silently passes because of wrongly defined test dimensions

2024-03-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21151 Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions ..

[Impala-ASF-CR] IMPALA-12903: Querying virtual column FILE POSITION for TEXT and JSON tables crashes Impala

2024-03-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21148 ) Change subject: IMPALA-12903: Querying virtual column FILE__POSITION for TEXT and JSON tables crashes Impala .. Patch Set 1: (1

[Impala-ASF-CR] IMPALA-12737: List key columns in query history

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 ) Change subject: IMPALA-12737: List key columns in query history .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-12626: Add Tables Queried to profile/history

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20886 ) Change subject: IMPALA-12626: Add Tables Queried to profile/history .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 48: Build Failed

[Impala-ASF-CR] IMPALA-12626: Add Tables Queried to profile/history

2024-03-14 Thread Michael Smith (Code Review)
Hello Andrew Sherman, Jason Fehr, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20886 to look at the new patch set (#16). Change subject: IMPALA-12626: Add Tables Queried to profile/history

[Impala-ASF-CR] IMPALA-12737: List key columns in query history

2024-03-14 Thread Michael Smith (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21142 to look at the new patch set (#3). Change subject: IMPALA-12737: List key columns in query history ..

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-14 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 48: (1 comment)

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-14 Thread Jason Fehr (Code Review)
Hello Andrew Sherman, Riza Suminto, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20770 to look at the new patch set (#48). Change subject: IMPALA-12426: Query History Table

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 47: (1 comment) I like this layout better. Just one comment to

[Impala-ASF-CR] IMPALA-12818: Intermediate Result Caching plan node framework

2024-03-14 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/21035 ) Change subject: IMPALA-12818: Intermediate Result Caching plan node framework .. Patch Set 5: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-12602: Unregister queries on idle timeout

2024-03-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21074 ) Change subject: IMPALA-12602: Unregister queries on idle timeout .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-12602: Unregister queries on idle timeout

2024-03-14 Thread Michael Smith (Code Review)
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21074 to look at the new patch set (#7). Change subject: IMPALA-12602: Unregister queries on idle timeout

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 47: Build Successful

[Impala-ASF-CR] IMPALA-12737: List key columns in query history

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 ) Change subject: IMPALA-12737: List key columns in query history .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-12540: Add system.impala query live table

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 ) Change subject: IMPALA-12540: Add system.impala_query_live table .. Patch Set 31: Build Successful

[Impala-ASF-CR] IMPALA-11938: added definition of num nodes query option for test in QueryOptions.SetIntOptions

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21150 ) Change subject: IMPALA-11938: added definition of num_nodes query option for test in QueryOptions.SetIntOptions .. Patch Set

[Impala-ASF-CR] IMPALA-12626: Add Tables Queried to profile/history

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20886 ) Change subject: IMPALA-12626: Add Tables Queried to profile/history .. Patch Set 15: Build Failed

[Impala-ASF-CR] IMPALA-12883: Support updating the charge on an entry in the cache

2024-03-14 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21122 ) Change subject: IMPALA-12883: Support updating the charge on an entry in the cache .. Patch Set 5: Code-Review+1 (6 comments)

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-14 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 47: (2 comments)

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-03-14 Thread Jason Fehr (Code Review)
Hello Andrew Sherman, Riza Suminto, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20770 to look at the new patch set (#47). Change subject: IMPALA-12426: Query History Table

[Impala-ASF-CR] IMPALA-12626: Add Tables Queried to profile/history

2024-03-14 Thread Michael Smith (Code Review)
Hello Andrew Sherman, Jason Fehr, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20886 to look at the new patch set (#15). Change subject: IMPALA-12626: Add Tables Queried to profile/history

[Impala-ASF-CR] IMPALA-12540: Add system.impala query live table

2024-03-14 Thread Michael Smith (Code Review)
Hello Andrew Sherman, Jason Fehr, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20762 to look at the new patch set (#31). Change subject: IMPALA-12540: Add system.impala_query_live table

[Impala-ASF-CR] IMPALA-12737: List key columns in query history

2024-03-14 Thread Michael Smith (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21142 to look at the new patch set (#2). Change subject: IMPALA-12737: List key columns in query history ..

[Impala-ASF-CR] IMPALA-11938: added definition of num nodes query option for test in QueryOptions.SetIntOptions

2024-03-14 Thread Anonymous Coward (Code Review)
j_ansh...@yahoo.in has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21150 Change subject: IMPALA-11938: added definition of num_nodes query option for test in QueryOptions.SetIntOptions .. IMPALA-11938:

[Impala-ASF-CR] IMPALA-11938: added definition of num nodes query option for test in QueryOptions.SetIntOptions

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21150 ) Change subject: IMPALA-11938: added definition of num_nodes query option for test in QueryOptions.SetIntOptions .. Patch Set

[Impala-ASF-CR] IMPALA-12903: Querying virtual column FILE POSITION for TEXT and JSON tables crashes Impala

2024-03-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21148 ) Change subject: IMPALA-12903: Querying virtual column FILE__POSITION for TEXT and JSON tables crashes Impala .. Patch Set 1: (2

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21149 ) Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12602: Unregister queries on idle timeout

2024-03-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21074 ) Change subject: IMPALA-12602: Unregister queries on idle timeout .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-12903: Querying virtual column FILE POSITION for TEXT and JSON tables crashes Impala

2024-03-14 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21148 ) Change subject: IMPALA-12903: Querying virtual column FILE__POSITION for TEXT and JSON tables crashes Impala .. Patch Set 1: (4

[Impala-ASF-CR] IMPALA-12903: Querying virtual column FILE POSITION for TEXT and JSON tables crashes Impala

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21148 ) Change subject: IMPALA-12903: Querying virtual column FILE__POSITION for TEXT and JSON tables crashes Impala .. Patch Set 1:

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21149 Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables .. IMPALA-12729: Allow creating primary keys for Iceberg

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21149 ) Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-12903: Querying virtual column FILE POSITION for TEXT and JSON tables crashes Impala

2024-03-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21148 Change subject: IMPALA-12903: Querying virtual column FILE__POSITION for TEXT and JSON tables crashes Impala .. IMPALA-12903:

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 ) Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raisedERROR: Invalid value for query option NUM_NODES: is not in range [0, 1]

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 ) Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raisedERROR: Invalid value for query option NUM_NODES: is not in range [0, 1]

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-14 Thread Anonymous Coward (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21147 to look at the new patch set (#2). Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raisedERROR: Invalid value

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-14 Thread Anonymous Coward (Code Review)
j_ansh...@yahoo.in has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21147 Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM_NODES: is not in range [0, 1]

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 ) Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM_NODES: is not in range [0, 1]

[Impala-ASF-CR] IMPALA-12881: Use getFkPkJoinCardinality to reduce scan cardinality

2024-03-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21118 ) Change subject: IMPALA-12881: Use getFkPkJoinCardinality to reduce scan cardinality .. Patch Set 5: > Patch Set 4: Code-Review+1 > >

[Impala-ASF-CR] IMPALA-12881: Use getFkPkJoinCardinality to reduce scan cardinality

2024-03-14 Thread Riza Suminto (Code Review)
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21118 to look at the new patch set (#5). Change subject: IMPALA-12881: Use getFkPkJoinCardinality to reduce scan cardinality

[Impala-ASF-CR] IMPALA-12264: Add limit on number of HS2 sessions per user.

2024-03-14 Thread Xiang Yang (Code Review)
Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21128 ) Change subject: IMPALA-12264: Add limit on number of HS2 sessions per user. .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-12835: Fix event processing without hms event incremental refresh transactional table

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21116 ) Change subject: IMPALA-12835: Fix event processing without hms_event_incremental_refresh_transactional_table ..

[Impala-ASF-CR] IMPALA-12835: Fix event processing without hms event incremental refresh transactional table

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21116 ) Change subject: IMPALA-12835: Fix event processing without hms_event_incremental_refresh_transactional_table .. Patch Set 6:

[Impala-ASF-CR] IMPALA-12699: Set timeout for catalog RPCs

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21146 ) Change subject: IMPALA-12699: Set timeout for catalog RPCs .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-12856: Event processor should ignore processing partition with empty partition values

2024-03-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21143 ) Change subject: IMPALA-12856: Event processor should ignore processing partition with empty partition values .. Patch Set 2: (6

[Impala-ASF-CR] IMPALA-12699: Set timeout for catalog RPCs

2024-03-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21146 Change subject: IMPALA-12699: Set timeout for catalog RPCs .. IMPALA-12699: Set timeout for catalog RPCs We have seen trivial

[Impala-ASF-CR] IMPALA-12881: Use getFkPkJoinCardinality to reduce scan cardinality

2024-03-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21118 ) Change subject: IMPALA-12881: Use getFkPkJoinCardinality to reduce scan cardinality .. Patch Set 4: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-12835: Fix event processing without hms event incremental refresh transactional table

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21116 ) Change subject: IMPALA-12835: Fix event processing without hms_event_incremental_refresh_transactional_table .. Patch Set 6:

[Impala-ASF-CR] IMPALA-12835: Fix event processing without hms event incremental refresh transactional table

2024-03-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21116 ) Change subject: IMPALA-12835: Fix event processing without hms_event_incremental_refresh_transactional_table .. Patch Set 6:

[Impala-ASF-CR] IMPALA-12835: Fix event processing without hms event incremental refresh transactional table

2024-03-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21116 ) Change subject: IMPALA-12835: Fix event processing without hms_event_incremental_refresh_transactional_table .. Patch Set 5:

[Impala-ASF-CR] IMPALA-12835: Fix event processing without hms event incremental refresh transactional table

2024-03-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21116 ) Change subject: IMPALA-12835: Fix event processing without hms_event_incremental_refresh_transactional_table .. Patch Set 5: There

[Impala-ASF-CR] IMPALA-12782: Show info of the event processing in /events webUI

2024-03-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20986 ) Change subject: IMPALA-12782: Show info of the event processing in /events webUI .. Patch Set 9: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-12362: (part-1/4) Refactor service management scripts.

2024-03-14 Thread Zihao Ye (Code Review)
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20921 ) Change subject: IMPALA-12362: (part-1/4) Refactor service management scripts. .. Patch Set 10: (2 comments) Very useful feature, thanks

[Impala-ASF-CR] IMPALA-12543: Detect self-events before finishing DDL

2024-03-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21029 ) Change subject: IMPALA-12543: Detect self-events before finishing DDL .. Patch Set 16: (1 comment) Overall looks good to me. Just