[Impala-ASF-CR] WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala

2021-11-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17948 ) Change subject: WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala .. Patch Set 8: Code-Review+1 (1 comment)

[native-toolchain-CR] IMPALA-10951 (part 1): Upgrade protobuf library in toolchain

2021-11-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17946 ) Change subject: IMPALA-10951 (part 1): Upgrade protobuf library in toolchain .. Patch Set 7: Code-Review+1 -- To view, visit

[Impala-ASF-CR] WIP IMPALA-10931: Integrate protobuf 3.14.0 library with Impala

2021-10-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17948 ) Change subject: WIP IMPALA-10931: Integrate protobuf 3.14.0 library with Impala .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10557: Support Kudu's multi-row transaction

2021-06-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 ) Change subject: IMPALA-10557: Support Kudu's multi-row transaction .. Patch Set 20: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10557: Support Kudu's multi-row transaction

2021-06-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 ) Change subject: IMPALA-10557: Support Kudu's multi-row transaction .. Patch Set 19: (3 comments)

[Impala-ASF-CR] IMPALA-10557: Support Kudu's multi-row transaction

2021-06-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 ) Change subject: IMPALA-10557: Support Kudu's multi-row transaction .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-10557: Support Kudu's multi-row transaction

2021-06-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 ) Change subject: IMPALA-10557: Support Kudu's multi-row transaction .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-10557: Support Kudu's multi-row transaction

2021-06-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 ) Change subject: IMPALA-10557: Support Kudu's multi-row transaction .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-10557: Support Kudu's multi-row transaction

2021-06-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 ) Change subject: IMPALA-10557: Support Kudu's multi-row transaction .. Patch Set 17: (4 comments)

[Impala-ASF-CR] IMPALA-10557: Support Kudu's multi-row transaction

2021-06-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 ) Change subject: IMPALA-10557: Support Kudu's multi-row transaction .. Patch Set 14: (3 comments)

[Impala-ASF-CR] IMPALA-10557: Support Kudu's multi-row transaction

2021-06-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 ) Change subject: IMPALA-10557: Support Kudu's multi-row transaction .. Patch Set 8: (2 comments)

[Impala-ASF-CR] WIP IMPALA-10557: Support Kudu's multi-row transaction

2021-06-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 ) Change subject: WIP IMPALA-10557: Support Kudu's multi-row transaction .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-9990: Support SET OWNER for Kudu tables

2020-10-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16273 ) Change subject: IMPALA-9990: Support SET OWNER for Kudu tables .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-9990: Support SET OWNER for Kudu tables

2020-10-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16273 ) Change subject: IMPALA-9990: Support SET OWNER for Kudu tables .. Patch Set 4: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-9990: Support SET OWNER for Kudu tables

2020-10-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16273 ) Change subject: IMPALA-9990: Support SET OWNER for Kudu tables .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-9990: Support SET OWNER for Kudu tables

2020-08-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16273 ) Change subject: IMPALA-9990: Support SET OWNER for Kudu tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9990: Support SET OWNER for Kudu tables

2020-08-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16273 ) Change subject: IMPALA-9990: Support SET OWNER for Kudu tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9092: Add support for creating external Kudu table

2019-11-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 ) Change subject: IMPALA-9092: Add support for creating external Kudu table .. Patch Set 4: Code-Review+1 (2 comments) LGTM, just a

[Impala-ASF-CR] IMPALA-9092: Add support for creating external Kudu table

2019-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 ) Change subject: IMPALA-9092: Add support for creating external Kudu table .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-9092: Add support for creating external Kudu table

2019-11-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 ) Change subject: IMPALA-9092: Add support for creating external Kudu table .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration

2019-07-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 ) Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration .. Patch Set 10: Code-Review+1 Content LGTM too --

[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration

2019-07-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 ) Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration .. Patch Set 9: Code-Review+1 (2 comments) One minor

[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration

2019-07-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 ) Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 ) Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 ) Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 ) Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration

2019-07-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 ) Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-8504: Support CREATE TABLE statement with Kudu/HMS integration

2019-05-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13318 ) Change subject: IMPALA-8504: Support CREATE TABLE statement with Kudu/HMS integration .. Patch Set 7: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-8504: Support CREATE TABLE statement with Kudu/HMS integration

2019-05-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13318 ) Change subject: IMPALA-8504: Support CREATE TABLE statement with Kudu/HMS integration .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-4271: Introduce the new Kudu storage handler

2019-05-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13358 ) Change subject: IMPALA-4271: Introduce the new Kudu storage handler .. Patch Set 7: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration

2019-05-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13409 ) Change subject: IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration .. Patch Set 1: (3 comments) Looks good,

[Impala-ASF-CR] IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-05-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13400 ) Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration .. Patch Set 2: (3 comments) Didn't look very

[Impala-ASF-CR] IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration

2019-05-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13375 ) Change subject: IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration

2019-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13248 ) Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration .. Patch Set 3: I think this was folded into

[Impala-ASF-CR] IMPALA-8504: Support CREATE TABLE statement with Kudu/HMS integration

2019-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13318 ) Change subject: IMPALA-8504: Support CREATE TABLE statement with Kudu/HMS integration .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13358 ) Change subject: IMPALA-8504: Introduce the new Kudu storage handler .. Patch Set 5: Code-Review+1 (1 comment)