[native-toolchain-CR] Compile thrift using the python in our toolchain.

2020-03-25 Thread Hector Acosta (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15468 to look at the new patch set (#3). Change subject: Compile thrift using the python in our toolchain. .. Compile th

[native-toolchain-CR] Add support for centos8

2020-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/15465 ) Change subject: Add support for centos8 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15465/1/docker/all/postinsta

[native-toolchain-CR] WIP: Add platform tag for Ubuntu 14.04

2020-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has abandoned this change. ( http://gerrit.cloudera.org:8080/15469 ) Change subject: WIP: Add platform tag for Ubuntu 14.04 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/15469 To unsubscribe, visi

[native-toolchain-CR] Add support for centos8

2020-03-17 Thread Hector Acosta (Code Review)
Hello Laszlo Gaal, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15465 to look at the new patch set (#2). Change subject: Add support for centos8 .. Add support for centos8 This commit a

[native-toolchain-CR] Remove centos6, ubuntu12, ubuntu14 platforms

2020-03-17 Thread Hector Acosta (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15464 to look at the new patch set (#2). Change subject: Remove centos6, ubuntu12, ubuntu14 platforms .. Remove centos6,

[native-toolchain-CR] WIP: Add platform tag for Ubuntu 14.04

2020-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/15469 ) Change subject: WIP: Add platform tag for Ubuntu 14.04 .. Patch Set 1: > I must be missing something here: I was convinced that the ea

[native-toolchain-CR] Remove CYRUS SASL

2020-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15466 Change subject: Remove CYRUS_SASL .. Remove CYRUS_SASL CYRUS_SASL requires libdb4 which is not available in rhel8. Change-Id: I7f043c0

[native-toolchain-CR] Remove centos6, ubuntu12, ubuntu14 platforms

2020-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15464 Change subject: Remove centos6, ubuntu12, ubuntu14 platforms .. Remove centos6, ubuntu12, ubuntu14 platforms This commit removes unused

[native-toolchain-CR] Fix bison compilation with glibc 2.28

2020-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15467 Change subject: Fix bison compilation with glibc 2.28 .. Fix bison compilation with glibc 2.28 Change-Id: Ie07da9fcebde4ae5003885f442d8

[native-toolchain-CR] WIP: Add platform tag for Ubuntu 14.04

2020-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15469 Change subject: WIP: Add platform tag for Ubuntu 14.04 .. WIP: Add platform tag for Ubuntu 14.04 Without this the packages for Ubuntu 1

[native-toolchain-CR] Add support for centos8

2020-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15465 Change subject: Add support for centos8 .. Add support for centos8 This commit adds a new docker image.. Change-Id: Idc15c202f61e25176

[native-toolchain-CR] Compile thrift using the python in our toolchain.

2020-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15468 Change subject: Compile thrift using the python in our toolchain. .. Compile thrift using the python in our toolchain. Change-Id: Iec33

[native-toolchain-CR] Fix issues with toolchain Python and bump version

2019-05-07 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/13249 ) Change subject: Fix issues with toolchain Python and bump version .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/132

[native-toolchain-CR] Create CCACHE DIR if not present

2019-05-07 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/13232 ) Change subject: Create CCACHE_DIR if not present .. Patch Set 1: > LGTM, I should have caught it the first time around though... > Ap

[native-toolchain-CR] Create CCACHE DIR if not present

2019-05-07 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/13232 ) Change subject: Create CCACHE_DIR if not present .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/1323

[native-toolchain-CR] Enable reusing ccache directories.

2019-04-18 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12996 ) Change subject: Enable reusing ccache directories. .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/12996/1/functions

[native-toolchain-CR] Enable reusing ccache directories.

2019-04-16 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12996 ) Change subject: Enable reusing ccache directories. .. Enable reusing ccache directories. Commit 2d6d6ba119e2bf303f82dbc3ce07e8120e7e3914

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 ) Change subject: Bump CDP_BUILD_NUMBER to 1013201 .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13002/3/bin/bootstr

[native-toolchain-CR] Enable reusing ccache directories.

2019-04-16 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12996 ) Change subject: Enable reusing ccache directories. .. Enable reusing ccache directories. Commit 2d6d6ba119e2bf303f82dbc3ce07e8120e7e3914

[native-toolchain-CR] Enable reusing ccache directories.

2019-04-11 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12996 Change subject: Enable reusing ccache directories. .. Enable reusing ccache directories. Commit 2d6d6ba119e2bf303f82dbc3ce07e8120e7e391

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

2019-04-06 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12922 ) Change subject: IMPALA-8382 Add support for SLES 12 SP3 .. Patch Set 3: > Patch Set 2: Commit message was updated. Thanks! -- To vi

[Impala-ASF-CR] IMPALA-8383 Bump toolchain version

2019-04-04 Thread Hector Acosta (Code Review)
Hector Acosta has abandoned this change. ( http://gerrit.cloudera.org:8080/12923 ) Change subject: IMPALA-8383 Bump toolchain version .. Abandoned Included in another review -- To view, visit http://gerrit.cloudera.org:8080/12

[Impala-ASF-CR] IMPALA-8383 Bump toolchain version

2019-04-03 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12923 Change subject: IMPALA-8383 Bump toolchain version .. IMPALA-8383 Bump toolchain version Thrift's python bindings in the current toolch

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

2019-04-03 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12922 Change subject: IMPALA-8382 Add support for SLES 12 SP3 .. IMPALA-8382 Add support for SLES 12 SP3 Change-Id: Ia3cb1311b15226f1130be7e1

[native-toolchain-CR] Check for thirft.protocol.fastbinary in both lib and lib64

2019-04-02 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12915 Change subject: Check for thirft.protocol.fastbinary in both lib and lib64 .. Check for thirft.protocol.fastbinary in both lib and lib64

[native-toolchain-CR] Install newer nss version in centos 6.6

2019-03-31 Thread Hector Acosta (Code Review)
Hello Laszlo Gaal, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12862 to look at the new patch set (#4). Change subject: Install newer nss version in centos 6.6 .. Install newer nss vers

[native-toolchain-CR] Work around flatbuffers flaky build

2019-03-29 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12886 ) Change subject: Work around flatbuffers flaky build .. Work around flatbuffers flaky build The flatbuffers build ocasionally fails with

[native-toolchain-CR] Parallelize image building process

2019-03-28 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12864 ) Change subject: Parallelize image building process .. Parallelize image building process Images can now be built in parallel when using

[native-toolchain-CR] Install newer nss version in centos 6.6

2019-03-28 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12862 ) Change subject: Install newer nss version in centos 6.6 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12862/2/docke

[native-toolchain-CR] Install newer nss version in centos 6.6

2019-03-28 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12862 ) Change subject: Install newer nss version in centos 6.6 .. Install newer nss version in centos 6.6 Centos 6.6 ships with an nss version

[native-toolchain-CR] Fix debian:7 and debian:8 image builds

2019-03-28 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12863 ) Change subject: Fix debian:7 and debian:8 image builds .. Fix debian:7 and debian:8 image builds Wheezy and Jessie were moved out of the

[native-toolchain-CR] Include python-dev in all build images

2019-03-28 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12882 ) Change subject: Include python-dev in all build images .. Include python-dev in all build images Thrift doesn't fail the build if it fai

[native-toolchain-CR] Workaround flatbuffers flaky build

2019-03-28 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12886 Change subject: Workaround flatbuffers flaky build .. Workaround flatbuffers flaky build The flatbuffers build ocasionally fails with t

[native-toolchain-CR] Include python-dev in all build images

2019-03-28 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12882 ) Change subject: Include python-dev in all build images .. Include python-dev in all build images Thrift doesn't fail the build if it fai

[native-toolchain-CR] Include python-dev in all build images

2019-03-28 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12882 ) Change subject: Include python-dev in all build images .. Patch Set 2: Code-Review+1 Patchset one ended up failing for thrift-0.11. Th

[native-toolchain-CR] Let buildall.sh run without setting PUBLISH DEPENDENCIES*

2019-03-28 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12883 ) Change subject: Let buildall.sh run without setting PUBLISH_DEPENDENCIES* .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[native-toolchain-CR] Include python-dev in all build images

2019-03-28 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12882 Change subject: Include python-dev in all build images .. Include python-dev in all build images Thrift doesn't fail the build if it fa

[native-toolchain-CR] Install newer nss version in centos 6.6

2019-03-26 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12862 ) Change subject: Install newer nss version in centos 6.6 .. Install newer nss version in centos 6.6 Centos 6.6 ships with an nss version

[native-toolchain-CR] Prepend docker image to both stderr and stdout

2019-03-26 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12861 ) Change subject: Prepend docker image to both stderr and stdout .. Prepend docker image to both stderr and stdout Sometimes, it may be ha

[native-toolchain-CR] Install newer git version in centos 6.6

2019-03-26 Thread Hector Acosta (Code Review)
Hector Acosta has restored this change. ( http://gerrit.cloudera.org:8080/12862 ) Change subject: Install newer git version in centos 6.6 .. Restored -- To view, visit http://gerrit.cloudera.org:8080/12862 To unsubscribe, visit

[native-toolchain-CR] Install newer git version in centos 6.6

2019-03-26 Thread Hector Acosta (Code Review)
Hector Acosta has abandoned this change. ( http://gerrit.cloudera.org:8080/12862 ) Change subject: Install newer git version in centos 6.6 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/12862 To unsubscribe, vis

[native-toolchain-CR] Fix debian:7 and debian:8 image builds

2019-03-26 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12863 Change subject: Fix debian:7 and debian:8 image builds .. Fix debian:7 and debian:8 image builds Wheezy and Jessie were moved out of th

[native-toolchain-CR] Prepend docker image to both stderr and stdout

2019-03-26 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12861 Change subject: Prepend docker image to both stderr and stdout .. Prepend docker image to both stderr and stdout Sometimes, it may be h

[native-toolchain-CR] Install newer git version in centos 6.6

2019-03-26 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12862 Change subject: Install newer git version in centos 6.6 .. Install newer git version in centos 6.6 Centos 6.6 contains a git version th

[native-toolchain-CR] Parallelize image building process

2019-03-26 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12864 Change subject: Parallelize image building process .. Parallelize image building process Images can now be built in parallel when using

[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws

2019-03-25 Thread Hector Acosta (Code Review)
Hello Lars Volker, Laszlo Gaal, Jim Apple, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12727 to look at the new patch set (#6). Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws

[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws

2019-03-22 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Patch Set 4: (1 comment) http://gerrit.cl

[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws

2019-03-22 Thread Hector Acosta (Code Review)
Hello Lars Volker, Laszlo Gaal, Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12727 to look at the new patch set (#5). Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws ..

[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws

2019-03-21 Thread Hector Acosta (Code Review)
Hello Laszlo Gaal, Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12727 to look at the new patch set (#4). Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws ...

[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws

2019-03-21 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 3: Code-Review+1 Carry +1 --

[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws

2019-03-20 Thread Hector Acosta (Code Review)
Hello Laszlo Gaal, Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12727 to look at the new patch set (#3). Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws ...

[native-toolchain-CR] Add documentation for docker-based toolchain builds

2019-03-20 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12810 ) Change subject: Add documentation for docker-based toolchain builds .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/

[native-toolchain-CR] Add documentation for docker-based toolchain builds

2019-03-20 Thread Hector Acosta (Code Review)
Hello Thomas Marshall, Laszlo Gaal, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12810 to look at the new patch set (#2). Change subject: Add documentation for docker-based toolchain builds .

[native-toolchain-CR] Add documentation for docker-related toolchain builds

2019-03-20 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12810 Change subject: Add documentation for docker-related toolchain builds .. Add documentation for docker-related toolchain builds This com

[native-toolchain-CR] Fix error when PUBLISH DEPENDENCIES=0

2019-03-19 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12793 ) Change subject: Fix error when PUBLISH_DEPENDENCIES=0 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12793/1/functio

[native-toolchain-CR] Add ccache support

2019-03-18 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12574 ) Change subject: Add ccache support .. Patch Set 2: > Hector, are you blocked on something? Or just waiting for someone > to merge? J

[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws

2019-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 2: (1 comment) http://gerrit.cl

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

2019-03-15 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12724 ) Change subject: Add missing sudo call to `service postgresql start` .. Add missing sudo call to `service postgresql start` Change-Id: Ie

[Impala-ASF-CR] IMPALA-8307 Use test -x to check for ntp-wait

2019-03-15 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12726 ) Change subject: IMPALA-8307 Use test -x to check for ntp-wait .. IMPALA-8307 Use test -x to check for ntp-wait Running ntp-wait --help c

[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script

2019-03-15 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Move DEBIAN_FRONTEND=noninteractive

[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws

2019-03-15 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Use `wget http://169.254.169.254/` to determi

[Impala-ASF-CR] IMPALA-8314 Set correct permissions for ~/.ssh files

2019-03-15 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12725 ) Change subject: IMPALA-8314 Set correct permissions for ~/.ssh files .. IMPALA-8314 Set correct permissions for ~/.ssh files Without thi

[Impala-ASF-CR] Use `curl http://169.254.169.254/` to determine if we're running in aws

2019-03-13 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `curl http://169.254.169.254/` to determine if we're running in aws .. Patch Set 1: (1 comment) http://gerrit.cl

[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script

2019-03-13 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 1: > (1 comment) > >

[Impala-ASF-CR] Use test -x to check for ntp-wait

2019-03-13 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12726 ) Change subject: Use test -x to check for ntp-wait .. Patch Set 1: > This looks good to me. Quick question: Is this a cosmetic issue or

[Impala-ASF-CR] Use `curl http://169.254.169.254/` to determine if we're running in aws

2019-03-12 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12727 Change subject: Use `curl http://169.254.169.254/` to determine if we're running in aws .. Use `curl http://169.254.169.254/` to determ

[Impala-ASF-CR] Use test -x to check for ntp-wait

2019-03-12 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12726 Change subject: Use test -x to check for ntp-wait .. Use test -x to check for ntp-wait In centos 7, running ntp-wait --help results in:

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

2019-03-12 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12724 Change subject: Add missing sudo call to `service postgresql start` .. Add missing sudo call to `service postgresql start` Change-Id: I

[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script

2019-03-12 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12723 Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Move DEBIAN_FRONTEND=noninteractive

[Impala-ASF-CR] Set correct permissions for ~/.ssh files

2019-03-12 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12725 Change subject: Set correct permissions for ~/.ssh files .. Set correct permissions for ~/.ssh files Without this I got the following e

[native-toolchain-CR] Add ccache support

2019-03-04 Thread Hector Acosta (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12574 to look at the new patch set (#2). Change subject: Add ccache support .. Add ccache support Here we add ccache

[native-toolchain-CR] Add ccache support

2019-03-04 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12574 ) Change subject: Add ccache support .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12574/1/docker/debian7.df File do