[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ .. Pat

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-22 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17071 to look at the new patch set (#3). Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 ) Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. Patch Set 1: (4 comments) ht

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17039 ) Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution .. Patch Set 4: (4 commen

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17039 to look at the new patch set (#4). Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17081 Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. IMPALA-10512: ALTER TABLE ADD P

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 7

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 6

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ .. Pat

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17071 to look at the new patch set (#2). Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 6

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17071 Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ .. IMPA

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 6

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17039 ) Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution .. Patch Set 3: (4 commen

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17039 to look at the new patch set (#3). Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17039 to look at the new patch set (#2). Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 6

[Impala-ASF-CR] IMPALA-10482, IMPALA-10493: Fix bugs in full ACID collection query rewrites

2021-02-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17038 ) Change subject: IMPALA-10482, IMPALA-10493: Fix bugs in full ACID collection query rewrites .. Patch Set 1: (1 comment) http://g

[Impala-ASF-CR] IMPALA-10482, IMPALA-10493: Fix bugs in full ACID collection query rewrites

2021-02-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17038 to look at the new patch set (#3). Change subject: IMPALA-10482, IMPALA-10493: Fix bugs in full ACID collection query rewrites ..

[Impala-ASF-CR] IMPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException

2021-02-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17038 ) Change subject: IMPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException ..

[Impala-ASF-CR] IMPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException

2021-02-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17038 to look at the new patch set (#2). Change subject: IMPALA-10482: Select-star query on unrelative collection column of transactional table hit

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17039 Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution .. IMPALA-10485: part(1): m

[Impala-ASF-CR] MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException

2021-02-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17038 Change subject: MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException ..

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 3: (3 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17012 to look at the new patch set (#3). Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables ..

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 2: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 1: (2 comments) Thanks for the comments!

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17012 to look at the new patch set (#2). Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables ..

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17012 Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. IMPALA-10223: Implement INSERT OVERWRITE for Iceberg

[Impala-ASF-CR] IMPALA-10460: Impala should write normalized paths in Iceberg manifests

2021-02-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16993 ) Change subject: IMPALA-10460: Impala should write normalized paths in Iceberg manifests .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-10460: Impala should write normalized paths in Iceberg manifests

2021-02-01 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16993 to look at the new patch set (#2). Change subject: IMPALA-10460: Impala should write normalized paths in Iceberg manifests

[Impala-ASF-CR] IMPALA-10456: Implement TRUNCATE for Iceberg tables

2021-01-28 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16987 to look at the new patch set (#3). Change subject: IMPALA-10456: Implement TRUNCATE for Iceberg tables ...

[Impala-ASF-CR] IMPALA-10460: Impala should write normalized paths in Iceberg manifests

2021-01-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16993 Change subject: IMPALA-10460: Impala should write normalized paths in Iceberg manifests .. IMPALA-10460: Impala should write normal

[Impala-ASF-CR] IMPALA-10456: Implement TRUNCATE for Iceberg tables

2021-01-27 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16987 to look at the new patch set (#2). Change subject: IMPALA-10456: Implement TRUNCATE for Iceberg tables ..

[Impala-ASF-CR] IMPALA-10456: Implement TRUNCATE for Iceberg tables

2021-01-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16987 Change subject: IMPALA-10456: Implement TRUNCATE for Iceberg tables .. IMPALA-10456: Implement TRUNCATE for Iceberg tables This pat

[Impala-ASF-CR] IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax

2021-01-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16979 ) Change subject: IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax .. Patch Set 2: (1 comment) Thanks for the co

[Impala-ASF-CR] IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax

2021-01-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16979 to look at the new patch set (#2). Change subject: IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax ...

[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support

2021-01-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 ) Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support .. Patch Set 1: Code-Review+2 (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-01-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 5

[Impala-ASF-CR] IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax

2021-01-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16979 Change subject: IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax .. IMPALA-10452: CREATE Iceberg tables with old

[Impala-ASF-CR] IMPALA-10147: Avoid getting a file handle for data cache hits

2021-01-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16963 ) Change subject: IMPALA-10147: Avoid getting a file handle for data cache hits .. Patch Set 2: Code-Review+1 Thanks for fixing this

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-01-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 5

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16939 ) Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms .. Patch Set 5: (6 comments) Thanks for the c

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-01-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 4

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16939 ) Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms .. Patch Set 4: (4 comments) Thanks for the c

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-15 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16939 to look at the new patch set (#4). Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms ..

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16939 ) Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms .. Patch Set 3: (4 comments) Thanks for the c

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16939 to look at the new patch set (#3). Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms ..

[Impala-ASF-CR] IMPALA-10426: Fix crash when inserting invalid timestamps

2021-01-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16951 Change subject: IMPALA-10426: Fix crash when inserting invalid timestamps .. IMPALA-10426: Fix crash when inserting invalid timestam

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16939 to look at the new patch set (#2). Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms ..

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-01-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 4

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16939 Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms .. IMPALA-10432: INSERT INTO Iceberg tables with

[Impala-ASF-CR] IMPALA-10368: Support required/optional property when creating Iceberg table

2021-01-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16904 ) Change subject: IMPALA-10368: Support required/optional property when creating Iceberg table .. Patch Set 6: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-10368: Support required/optional property when creating Iceberg table

2021-01-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16904 ) Change subject: IMPALA-10368: Support required/optional property when creating Iceberg table .. Patch Set 4: Code-Review+2 (1 com

[Impala-ASF-CR] IMPALA-10422: EXPLAIN statements leak ACID transactions and locks

2021-01-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16923 Change subject: IMPALA-10422: EXPLAIN statements leak ACID transactions and locks .. IMPALA-10422: EXPLAIN statements leak ACID tra

[Impala-ASF-CR] IMPALA-6434: Add support to decode RLE DICTIONARY encoded pages

2021-01-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16893 ) Change subject: IMPALA-6434: Add support to decode RLE_DICTIONARY encoded pages .. Patch Set 4: Code-Review+2 (1 comment) An 'if'

[Impala-ASF-CR] IMPALA-6434: Add support to decode RLE DICTIONARY encoded pages

2021-01-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16893 ) Change subject: IMPALA-6434: Add support to decode RLE_DICTIONARY encoded pages .. Patch Set 3: (6 comments) Few nits, but the co

[Impala-ASF-CR] IMPALA-10368: Support required/optional property when creating Iceberg table

2021-01-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16904 ) Change subject: IMPALA-10368: Support required/optional property when creating Iceberg table .. Patch Set 2: (6 comments) Thanks

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 14: Code-Review+

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only .. Patch Set 12: (7 comments) Thanks fo

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#13). Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only ...

[Impala-ASF-CR] IMPALA-10398: Altering an Iceberg table might throw NullPointerException

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16882 Change subject: IMPALA-10398: Altering an Iceberg table might throw NullPointerException .. IMPALA-10398: Altering an Iceberg table

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#12). Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only ...

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 13: (2 comments

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-15 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#10). Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only ...

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only .. Patch Set 9: PS9 was a rebase to reso

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-15 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#9). Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16851 ) Change subject: IMPALA-10358: Correct Iceberg type mappings .. Patch Set 5: (1 comment) Thanks for the comments! http://gerrit.c

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16851 to look at the new patch set (#5). Change subject: IMPALA-10358: Correct Iceberg type mappings

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 12: (13 comment

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

2020-12-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16846 to look at the new patch set (#3). Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables ...

[Impala-ASF-CR] IMPALA-10393: Iceberg field id-based column resolution fails in ASAN builds

2020-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16873 Change subject: IMPALA-10393: Iceberg field id-based column resolution fails in ASAN builds .. IMPALA-10393: Iceberg field id-based

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only .. Patch Set 8: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only .. Patch Set 8: (3 comments) Thanks for

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#8). Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16851 ) Change subject: IMPALA-10358: Correct Iceberg type mappings .. Patch Set 3: (2 comments) PS3 was a rebase. http://gerrit.clouder

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16851 to look at the new patch set (#4). Change subject: IMPALA-10358: Correct Iceberg type mappings

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16851 to look at the new patch set (#3). Change subject: IMPALA-10358: Correct Iceberg type mappings

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16851 ) Change subject: IMPALA-10358: Correct Iceberg type mappings .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16851

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16851 to look at the new patch set (#2). Change subject: IMPALA-10358: Correct Iceberg type mappings

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness .. Patch Set 3: I mean Tamas... :) -- To view, visit h

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness .. Patch Set 2: Code-Review+2 Thanks for the fix, Mate!

[Impala-ASF-CR] IMPALA-10361: Use field id to resolve columns for Iceberg tables

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16788 ) Change subject: IMPALA-10361: Use field id to resolve columns for Iceberg tables .. IMPALA-10361: Use field id to resolve c

[Impala-ASF-CR] IMPALA-10361: Use field id to resolve columns for Iceberg tables

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16788 ) Change subject: IMPALA-10361: Use field id to resolve columns for Iceberg tables .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16851 Change subject: IMPALA-10358: Correct Iceberg type mappings .. IMPALA-10358: Correct Iceberg type mappings The Iceberg format spec

[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16850 to look at the new patch set (#3). Change subject: IMPALA-10384: Make partition names consistent between BE and FE .

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables .. Patch Set 7: PS7 is a rebase that resolves the me

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#7). Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#5). Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16850 to look at the new patch set (#2). Change subject: IMPALA-10384: Make partition names consistent between BE and FE

[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16850 Change subject: IMPALA-10384: Make partition names consistent between BE and FE .. IMPALA-10384: Make partition names consistent bet

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

2020-12-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16846 Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables .. IMPALA-10386: Don't allow PARTITION BY SPEC f

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables .. Patch Set 4: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#4). Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

[Impala-ASF-CR] IMPALA-10361: Use field id to resolve columns for Iceberg tables

2020-12-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16788 ) Change subject: IMPALA-10361: Use field id to resolve columns for Iceberg tables .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables .. Patch Set 3: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-10361: Use field id to resolve columns for Iceberg tables

2020-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16788 ) Change subject: IMPALA-10361: Use field id to resolve columns for Iceberg tables .. Patch Set 7: Code-Review+1 Thanks for the modi

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#3). Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16825 Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables .. IMPALA-10380: INSERT INTO identity-partitioned Iceb

<    11   12   13   14   15   16   17   18   19   20   >