[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 2: (4 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8312 : Alter database operations have race condition

2019-03-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 ) Change subject: IMPALA-8312 : Alter database operations have race condition .. Patch Set 5: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 ) Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. Patch Set 1: Code-Review+2 -- To v

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 ) Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. Patch Set 2: Code-Review+1 I'm not

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 ) Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. Patch Set 2: Code-Review+2 lets get

[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog

2019-03-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12859 ) Change subject: IMPALA-8362: Increase authorization test coverage with local catalog .. Patch Set 2: Code-Review+2 (4 comments

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 5: Code-Review+1 (1 comment) Other re

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should support flag names

2019-03-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should support flag names .. Patch Set 6: TBH, the original approach wasn

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should support flag names

2019-03-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should support flag names .. Patch Set 7: Code-Review+2 (1 comment) http

[Impala-ASF-CR] IMPALA-8312 : Alter database operations have race condition

2019-03-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 ) Change subject: IMPALA-8312 : Alter database operations have race condition .. Patch Set 8: Code-Review+1 (4 comments) http://

[Impala-ASF-CR] IMPALA-8293: Support for Ranger cache invalidation

2019-03-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12748 ) Change subject: IMPALA-8293: Support for Ranger cache invalidation .. Patch Set 6: (6 comments) Haven't looked into it very de

[Impala-ASF-CR] IMPALA-8312 : Alter database operations have race condition

2019-03-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 ) Change subject: IMPALA-8312 : Alter database operations have race condition .. Patch Set 9: Code-Review+1 Fredy, do you have an

[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable

2019-04-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable

2019-04-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable

2019-04-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. IMPALA-6216: Make PYTHON_EGG_CACHE configurable User

[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable

2019-04-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12954 ) Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. Patch Set 1: Code-Review+1 (2 comments) http://

[Impala-ASF-CR] WIP: Refactor file descriptor loading code

2019-04-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: WIP: Refactor file descriptor loading code .. Patch Set 2: (5 comments) refactor generally makes sense to me.

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12954 ) Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. Patch Set 1: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-8346: Specify hadoop user explicitly during data load

2019-04-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Specify hadoop user explicitly during data load .. Patch Set 1: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-04-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 3: (14 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. Patch Set 3: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. Patch Set 6: Code-Review+2 (2 comments) lgtm. http://gerrit.

[Impala-ASF-CR] This change bumps the CDH BUILD VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed for t

2019-04-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12965 ) Change subject: This change bumps the CDH_BUILD_VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed f

[Impala-ASF-CR] This change bumps the CDH BUILD VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed for t

2019-04-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12965 ) Change subject: This change bumps the CDH_BUILD_VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed f

[Impala-ASF-CR] This change bumps the CDH BUILD VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed for t

2019-04-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12965 ) Change subject: This change bumps the CDH_BUILD_VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed f

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 6: (18 comments) http://gerrit.clo

[Impala-ASF-CR] Bump CDH BUILD NUMBER to 1009254

2019-04-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12965 ) Change subject: Bump CDH_BUILD_NUMBER to 1009254 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] WIP: Refactor file descriptor loading code

2019-04-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: WIP: Refactor file descriptor loading code .. Patch Set 2: is it still a WIP or is this ready for review? --

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. Patch Set 2: Code-Review

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 13: (12 comments) I think we could

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 13: (1 comment) http://gerrit.clou

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: (6 comments) Looks pretty good to me, a bunch of nits an

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 14: (9 comments) Some more suggest

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. Patch

[Impala-ASF-CR] Initial support for recursive file listing within a partition

2019-04-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12991 ) Change subject: Initial support for recursive file listing within a partition .. Patch Set 1: (7 comments) Generally looks goo

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 14: (4 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. Patch Set 3: (3 comments) sorry for the dela

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 6: (4 comments

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 16: (5 comments) lgtm, can +2 once

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. Patch Set 5: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] Log scanner Open() errors

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13018 Change subject: Log scanner Open() errors .. Log scanner Open() errors While the status is propagated to the runtime profile, it

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 7: Code-Review+

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. Patch

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME while processing DROP DATABASE events.

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME while processing DROP_DATABASE events. .. Patch Set 14: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 16: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13058 ) Change subject: IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase .. Patch Set 1: (2 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 1: Code-Review+2 (1 comment) http://ger

[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 2: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 18: Code-Review+2 (3 comments) htt

[Impala-ASF-CR] IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13058 ) Change subject: IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase .. Patch Set 1: Code-Review+1 (2 comments) Vihang,

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 19: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13058 ) Change subject: IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase .. Patch Set 4: Code-Review+2 -- To view, visit htt

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 21: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 ) Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. Patch Set 3: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. Patch Set 2: (2 comments) Couple of m

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. Patch Set 6: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7973: Add support for fine grained updates at partition level.

2019-04-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13111 ) Change subject: IMPALA-7973: Add support for fine grained updates at partition level. .. Patch Set 2: (11 comments) http://ge

[Impala-ASF-CR] IMPALA-8454 (part 1): Refactor file descriptor loading code

2019-04-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: IMPALA-8454 (part 1): Refactor file descriptor loading code .. Patch Set 5: Code-Review+2 (2 comments) http://

[Impala-ASF-CR] IMPALA-8454 (part 1): Refactor file descriptor loading code

2019-04-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: IMPALA-8454 (part 1): Refactor file descriptor loading code .. Patch Set 6: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-8454 (part 2): Initial support for recursive file listing within a partition

2019-04-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12991 ) Change subject: IMPALA-8454 (part 2): Initial support for recursive file listing within a partition .. Patch Set 3: Code-Review

[Impala-ASF-CR] IMPALA-8454 (part 3): enable recursive file listing by default

2019-04-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13127 ) Change subject: IMPALA-8454 (part 3): enable recursive file listing by default .. Patch Set 1: Code-Review+2 (1 comment) Looks

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. IMPALA-7971: Add support for insert ev

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 24: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-8454 (part 3): enable recursive file listing by default

2019-04-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13127 ) Change subject: IMPALA-8454 (part 3): enable recursive file listing by default .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8463: fix skip.header.line.count on local catalog

2019-04-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13131 ) Change subject: IMPALA-8463: fix skip.header.line.count on local catalog .. Patch Set 5: Code-Review+1 -- To view, visit http:

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13134 ) Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. Patch Set 5: (11 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-8455: Gracefully handle failed loads in GET TABLES req

2019-04-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13186 Change subject: IMPALA-8455: Gracefully handle failed loads in GET_TABLES req .. IMPALA-8455: Gracefully handle failed loads in G

[Impala-ASF-CR] IMPALA-8455: Gracefully handle failed loads in GET TABLES req

2019-04-30 Thread Bharath Vissapragada (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13186 to look at the new patch set (#2). Change subject: IMPALA-8455: Gracefully handle failed loads in GET_TABLES req .

[Impala-ASF-CR] IMPALA-8455: Gracefully handle failed loads in GET TABLES req

2019-04-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13186 ) Change subject: IMPALA-8455: Gracefully handle failed loads in GET_TABLES req .. Patch Set 2: Code-Review+2 Rebased and fixed a

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13134 ) Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. Patch Set 7: Code-Review+1 (7 comments) Loo

[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path

2018-08-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11353 Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. [diagnostics] Make --minidump_dir

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-29 Thread Bharath Vissapragada (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11341 to look at the new patch set (#5). Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats ...

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11341 ) Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats .. Patch Set 5: (29 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11341 ) Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats .. Patch Set 5: (2 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-7137 fixup: only recreate AuthorizationChecker on full delta updates

2018-08-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11357 ) Change subject: IMPALA-7137 fixup: only recreate AuthorizationChecker on full delta updates .. Patch Set 1: Code-Review+2 --

[Impala-ASF-CR] IMPALA-7203. Support UDFs in CatalogdMetaProvider

2018-08-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11359 ) Change subject: IMPALA-7203. Support UDFs in CatalogdMetaProvider .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR](2.x) IMPALA-7513: Fix Sentry compilation error in 2.x

2018-08-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11362 ) Change subject: IMPALA-7513: Fix Sentry compilation error in 2.x .. Patch Set 3: Code-Review+2 (2 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-30 Thread Bharath Vissapragada (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11341 to look at the new patch set (#6). Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats ...

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11341 ) Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats .. Patch Set 6: (13 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-30 Thread Bharath Vissapragada (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11341 to look at the new patch set (#7). Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats ...

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11341 ) Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats .. Patch Set 7: (7 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11341 ) Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats .. Patch Set 7: (6 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-31 Thread Bharath Vissapragada (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11341 to look at the new patch set (#8). Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats ...

[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path

2018-08-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 3: Weird. clang-tidy b

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-08-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. Patch Set 7: Code-Review+1 (8 comments)

[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path

2018-08-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 3: After digging throu

[Impala-ASF-CR] IMPALA-7137 fixup: only recreate AuthorizationChecker on full delta updates

2018-09-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11357 ) Change subject: IMPALA-7137 fixup: only recreate AuthorizationChecker on full delta updates .. Patch Set 3: Code-Review+2 --

[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path

2018-09-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. [diagnostics] Make --mini

[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path

2018-09-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 4: Code-Review+2 Carry

[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path

2018-09-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 5: Filed IMPALA-7526 f

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 2: Forgot to git add FrontendProfi

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-09-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 12: (9 comments) Patch lgtm pending

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-09-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. Patch Set 10: Code-Review+1 I'll let Vuk

[Impala-ASF-CR] IMPALA-7203. Support UDFs in CatalogdMetaProvider

2018-09-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11359 ) Change subject: IMPALA-7203. Support UDFs in CatalogdMetaProvider .. Patch Set 6: Code-Review+2 (2 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-09-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 13: Code-Review+2 (5 comments) Feel

<    1   2   3   4   5   6   7   8   9   10   >