[Impala-ASF-CR] IMPALA-3819: Clarify stale block metadata warning message

2018-09-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11433 ) Change subject: IMPALA-3819: Clarify stale block metadata warning message .. Patch Set 2: Code-Review+2 Carrying +2. -- To

[Impala-ASF-CR] IMPALA-3819: Clarify stale block metadata warning message

2018-09-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11433 ) Change subject: IMPALA-3819: Clarify stale block metadata warning message .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3819: Clarify stale block metadata warning message

2018-09-13 Thread Bharath Vissapragada (Code Review)
Hello Zoram Thanga, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11433 to look at the new patch set (#2). Change subject: IMPALA-3819: Clarify stale block metadata warning message

[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 ) Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-7945: Fix test hdfs timeout.py on python 2.6

2018-12-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12059 ) Change subject: IMPALA-7945: Fix test_hdfs_timeout.py on python 2.6 .. Patch Set 1: On a related note, wondering why

[Impala-ASF-CR] IMPALA-7945: Fix test hdfs timeout.py on python 2.6

2018-12-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12059 ) Change subject: IMPALA-7945: Fix test_hdfs_timeout.py on python 2.6 .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-11-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#6) to the change originally created by piotr.findei...@gmail.com. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. Patch Set 2: Ran into IMPALA-7245. Retrying -- To view, visit

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 3: (23 comments) Thanks Paul and Fredy.

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-24 Thread Bharath Vissapragada (Code Review)
Hello Greg Rahn, Paul Rogers, Fredy Wijaya, Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12221 to look at the new patch set (#3). Change subject: IMPALA-5872: Testcase builder for query planner

[Impala-ASF-CR] [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls

2019-01-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. ( http://gerrit.cloudera.org:8080/10696 ) Change subject: [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls .. Abandoned Abandoning for now. Some work has gone into

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 11: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-01-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 2: (6 comments) Lgtm. There are

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

2019-01-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog .. Patch Set 3: Code-Review+1 (4

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. Patch Set 8: Code-Review+2 (5

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should support flag names

2019-03-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should support flag names .. Patch Set 6: TBH, the original approach

[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog

2019-03-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12859 ) Change subject: IMPALA-8362: Increase authorization test coverage with local catalog .. Patch Set 2: Code-Review+2 (4

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 ) Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. Patch Set 2: Code-Review+1 I'm not

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 ) Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. Patch Set 2: Code-Review+2 lets

[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable

2019-04-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable

2019-04-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable

2019-04-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. IMPALA-6216: Make PYTHON_EGG_CACHE configurable

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 4: (1

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 4: (1

[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable

2019-04-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should support flag names

2019-03-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should support flag names .. Patch Set 7: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8312 : Alter database operations have race condition

2019-03-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 ) Change subject: IMPALA-8312 : Alter database operations have race condition .. Patch Set 9: Code-Review+1 Fredy, do you have

[Impala-ASF-CR] IMPALA-8312 : Alter database operations have race condition

2019-03-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 ) Change subject: IMPALA-8312 : Alter database operations have race condition .. Patch Set 8: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-8293: Support for Ranger cache invalidation

2019-03-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12748 ) Change subject: IMPALA-8293: Support for Ranger cache invalidation .. Patch Set 6: (6 comments) Haven't looked into it very

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 5: Code-Review+1 (1 comment) Other

[Impala-ASF-CR] IMPALA-7645: Add a query option to set the default table file format

2019-02-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12568 ) Change subject: IMPALA-7645: Add a query option to set the default table file format .. Patch Set 6: Looks like PS5 is a

[Impala-ASF-CR] IMPALA-8243: Fix racy access to nonPartFieldSchemas

2019-02-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12572 ) Change subject: IMPALA-8243: Fix racy access to nonPartFieldSchemas_ .. IMPALA-8243: Fix racy access to

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 7: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 8: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 ) Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files. .. Patch Set 7: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-8240: Event processor should keep trying when metastore is unavailable.

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 ) Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-03-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-8272: Fix test catalog tablesfilesusage failing

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12649 ) Change subject: IMPALA-8272: Fix test_catalog_tablesfilesusage failing .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8273 : Change metastore configuration template to not exclude impala specific parameters

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore configuration template to not exclude impala specific parameters .. Patch Set

[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 2:

[Impala-ASF-CR] IMPALA-8272: Fix test catalog tablesfilesusage failing

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12649 ) Change subject: IMPALA-8272: Fix test_catalog_tablesfilesusage failing .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7560: Improve selectivity estimate for !=

2019-02-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12427 ) Change subject: IMPALA-7560: Improve selectivity estimate for != .. Patch Set 4: Gerrit still complaining about the merge

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 6: Gerrit says there are merge conflicts, rebase

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 3: Code-Review+2 (2 comments) Couple

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 ) Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files. .. Patch Set 5: (6 comments) Bunch

[Impala-ASF-CR] IMPALA-8240: Event processor should keep trying when metastore is unavailable.

2019-02-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 ) Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. .. Patch Set 4: (9 comments)

[Impala-ASF-CR] IMPALA-7645: Add a query option to set the default table file format

2019-02-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12568 ) Change subject: IMPALA-7645: Add a query option to set the default table file format .. Patch Set 7: Code-Review+2 (2

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Abandoned Stale now. Feel free to restore

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. Patch Set 8: Code-Review+1 (2 comments) Will let Paul +2

[Impala-ASF-CR] IMPALA-8014: Incorrect FK/PK cardinality estimation

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Incorrect FK/PK cardinality estimation .. Patch Set 4: I have some questions around how the Fk-Pk

[Impala-ASF-CR] IMPALA-8243: Fix racy access to nonPartFieldSchemas

2019-02-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12572 Change subject: IMPALA-8243: Fix racy access to nonPartFieldSchemas_ .. IMPALA-8243: Fix racy access to nonPartFieldSchemas_ **

[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 4:

[Impala-ASF-CR] IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12656 ) Change subject: IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness

2019-03-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12656 ) Change subject: IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness .. Patch Set 9: (8 comments)

[Impala-ASF-CR] IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness

2019-03-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12656 ) Change subject: IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. Patch Set 7: (9 comments) Nice clean separation. The

[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 ) Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files. .. Patch Set 9: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-8240: Event processor should keep trying when metastore is unavailable.

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 ) Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8240: Event processor should keep trying when metastore is unavailable.

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 ) Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. .. Patch Set 8: Code-Review+2

[Impala-ASF-CR] IMPALA-8240: Event processor should keep trying when metastore is unavailable.

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 ) Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. .. Patch Set 6: Code-Review+2

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 5: (16 comments) Mostly general

[Impala-ASF-CR] IMPALA-8185: Abstract out real/mock file system operations

2019-02-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12437 ) Change subject: IMPALA-8185: Abstract out real/mock file system operations .. Patch Set 5: (4 comments) The general

[Impala-ASF-CR] IMPALA-7975 : Improve supportability of the automatic invalidate feature

2019-02-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12549 ) Change subject: IMPALA-7975 : Improve supportability of the automatic invalidate feature .. Patch Set 2: (15 comments)

[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 ) Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files. .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12745 ) Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2 .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

2019-03-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12257 ) Change subject: IMPALA-8097: mt_dop for all queries via hidden flag .. Patch Set 8: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync

2019-03-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 7: Code-Review+1 (4 comments) I'll let Paul

[Impala-ASF-CR] IMPALA-8014: Incorrect FK/PK cardinality estimation

2019-03-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Incorrect FK/PK cardinality estimation .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8014: Incorrect FK/PK cardinality estimation

2019-03-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Incorrect FK/PK cardinality estimation .. Patch Set 4: (2 comments) My understanding of the math

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8312 : Alter database operations have race condition

2019-03-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 ) Change subject: IMPALA-8312 : Alter database operations have race condition .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-7974: [DOCS] Document automatic invalidation via HMS notification

2019-03-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12700 ) Change subject: IMPALA-7974: [DOCS] Document automatic invalidation via HMS notification .. Patch Set 6: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-03-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 12: (9 comments) I think the new

[Impala-ASF-CR] IMPALA-7974: [DOCS] Document automatic invalidation via HMS notification

2019-03-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12700 ) Change subject: IMPALA-7974: [DOCS] Document automatic invalidation via HMS notification .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8312 : Alter database operations have race condition

2019-03-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 ) Change subject: IMPALA-8312 : Alter database operations have race condition .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 ) Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

2019-02-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 ) Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. Patch Set 2: Code-Review+1 (1 comment) Lgtm. I'm not

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-07 Thread Bharath Vissapragada (Code Review)
Hello Greg Rahn, Paul Rogers, Fredy Wijaya, Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12221 to look at the new patch set (#8). Change subject: IMPALA-5872: Testcase builder for query planner

[Impala-ASF-CR] IMPALA-7976 : Add a flag to disable sync using events at a table level

2019-02-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12365 ) Change subject: IMPALA-7976 : Add a flag to disable sync using events at a table level .. Patch Set 2: (12 comments)

[Impala-ASF-CR] IMPALA-8163: Add banner showing for local catalog mode when enabled.

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12413 ) Change subject: IMPALA-8163: Add banner showing for local catalog mode when enabled. .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-08 Thread Bharath Vissapragada (Code Review)
Hello Greg Rahn, Paul Rogers, Fredy Wijaya, Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12221 to look at the new patch set (#9). Change subject: IMPALA-5872: Testcase builder for query planner

[Impala-ASF-CR] IMPALA-8163: Add banner showing for local catalog mode when enabled.

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12413 ) Change subject: IMPALA-8163: Add banner showing for local catalog mode when enabled. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 ) Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-12 Thread Bharath Vissapragada (Code Review)
Hello Paul Rogers, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12428 to look at the new patch set (#4). Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

2019-02-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 ) Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode. .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-8182: Add single-node plan to PlanCtx

2019-02-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12436 ) Change subject: IMPALA-8182: Add single-node plan to PlanCtx .. Patch Set 1: (6 comments) Few minor comments, lgtm otherwise.

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-12 Thread Bharath Vissapragada (Code Review)
Hello Paul Rogers, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12428 to look at the new patch set (#5). Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 ) Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. Patch Set 5: Redid the patch after discussing

<    1   2   3   4   5   6   7   8   9   10   >